| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
|
|
38d4811 p2p: fix exclusive node DNS resolution for certain hosts [release] (Jeffrey Ryan)
|
|
Fixes #8633. The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character.
@vtnerd comments 1
clear up 2nd conditional statement
|
|
|
|
2dab31f Don't exclusively drop tor/i2p outgoing cxns in idle loop (j-berman)
|
|
|
|
|
|
Thanks @mj-xmr: https://github.com/monero-project/monero/pull/8211#discussion_r823870855
|
|
Relevant commit from old PR:
330df2952cb2863a591158b984c0fb7f652887ac
|
|
|
|
Remove unused include statements or unused definitions.
|
|
Here lies dozens of unused files. This commit is ONLY file deletions except
for the removing of a couple of #includes and removing filenames from CmakeLists
where appropriate.
|
|
da9aa1f Copyright: Update to 2022 (mj-xmr)
|
|
|
|
|
|
|
|
9154883 node_server: fix race condition (anon)
8922f96 node_server: add race condition demo (anon)
|
|
2a8a511 Quicker resource cleanup on p2p socks timeout (Lee *!* Clagett)
|
|
|
|
4ced092 daemon: allow proxy configuration (anon, selsta, tobtoht)
|
|
Co-authored-by: selsta <selsta@sent.at>
Co-authored-by: tobtoht <thotbot@protonmail.com>
|
|
|
|
|
|
|
|
cbd54ea cmake: set 3.5 as minimum version (selsta)
|
|
5871e7a net_node: add seed node (selsta)
|
|
|
|
|
|
|
|
76fe73b Revert 'fix accessing an network address in a deleted context' (selsta)
|
|
aa3e89a p2p: fix set_peer_just_seen ignoring last_seen (moneromooo)
|
|
f10c9a1 remove obsolete pruning debug code (moneromooo-monero)
|
|
f815740 p2p: make REQUEST_SUPPORT_FLAGS optional, pass flags in node data (moneromooo-monero)
|
|
f208d98 p2p: ignore empty IP from DNS block list (moneromooo-monero)
|
|
Helps daemons behind a proxy get more than one connection.
Defaults to 1 (no change)
|
|
|
|
This reverts commit 63c7ca07fba2f063c760f786a986fb3e02fb040e, reversing
changes made to 2218e23e84a89e9a1e4c0be5d50f891ab836754f.
|
|
1d1c430 p2p: fix cubic selection in filtered peer list (moneromooo)
|
|
23aae55 Remove payload copy in all outgoing p2p messages (Lee Clagett)
|
|
|
|
c5c278c p2p: only log to global when a blocked IP is not already blocked (moneromooo-monero)
|
|
This reverts commit 4e74385a1ae9eae4ae9e8d155dfd96978eb10e7a.
|
|
|
|
removes a back and forth on connect, and the RPC can be removed
once all peers have updated
|
|
4e74385a1 fix accessing an network address in a deleted context (moneromooo-monero)
|
|
|
|
Both drop_connection and add_host_fail can drop the connection,
which invalidates the context, and thus the address it contains.
Thanks to wfaressuissia[m] for lots of help and prodding when
debugging this
|
|
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
|
|
|
|
Integer quantization biased the picks a lot (leading some indices
to never be selected)
|
|
ie, if the list ends in ;
|
|
|
|
|
|
56748e1d7 ban lists may now include subnets (moneromooo-monero)
|
|
68637bca3 p2p: remove peers from grey and anchors lists when blocked (moneromooo-monero)
|
|
e9abfea16 Optional DNS based blocklist (moneromooo-monero)
|
|
c0c75ac19 Fixed issues found by static analysis (SChernykh)
|
|
|
|
|
|
If enabled, pulls IPs to block on blocklist.moneropulse.*, and
blocks then for 8 days (so IPs dropping from the list will
eventually get unblocked, and DNS failures don't result in
instant clearing of the blocklist).
Enable with --enable-dns-blocklist
|
|
58651d1 p2p: ignore incoming peer list entries when we have them blocked (moneromooo-monero)
|
|
f3c0d4f protocol: remove unused (and cunningly uninitialized) field (moneromooo-monero)
8e62362 p2p: ifx getting seed nodes for uncommon cases (moneromooo-monero)
|
|
|
|
The code is technically correct, but liable to easily become incorrect with changes
|
|
|
|
|
|
- rolling_median: tried to free uninitialized pointer in a constructor
- net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv
- bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
|
|
bc7cd78 p2p: drop peers that spam peer lists (moneromooo-monero)
|
|
281b42a p2p: fix race condition accessing a deleted context (moneromooo-monero)
|
|
ff7fdf6 protocol: drop peers that don't reply to queries (moneromooo-monero)
89e984d keep only the last seen node on a given host in the white list (moneromooo-monero)
c74d8ff protocol: drop peers that decrease claimed height (moneromooo-monero)
61f5001 protocol: add scoring system to drop peers that don't behave (moneromooo-monero)
|
|
|
|
There's always some people who just want to abuse things
|
|
2395e0e67 p2p: add a tor seed node (moneromooo-monero)
|
|
13350f79d Do not use peer_id tracking method over i2p/tor (Lee Clagett)
|
|
|
|
|
|
c64b94bd1 p2p: fix endianness when checking IPv6 addresses mapping to IPv4 (moneromooo-monero)
67f2bec2d p2p: make this work with boost <= 1.65 (pffff) (moneromooo-monero)
ffdf1fb1d p2p: rewrite boost's make_address_v4 to cater for < 1.66 (moneromooo)
|
|
7a5e11645 net_node: add tor / i2p seed nodes (selsta)
|
|
|
|
|
|
|
|
even if some run more than one node
|
|
Co-authored-by: Lee Clagett <code@leeclagett.com>
|
|
3247f11 Silence stupid warnings (Howard Chu)
|
|
cb069d0 p2p: remove banned peers from the white list (moneromooo-monero)
|
|
1f04a31 p2p: use /16 filtering on IPv4-within-IPv6 addresses (moneromooo-monero)
|
|
aad2f87 net_node: add --ban-list option (selsta)
|
|
2abdbf6 Add support for i2p and tor seed nodes (vtnerd)
|
|
|
|
|
|
IPv6 addresses include a range that can map IPv4 addresses,
which allowed those mapped addresses to bypass filtering.
This filter should be replaced by AS filtering at some point.
|
|
|
|
|
|
|
|
|
|
|
|
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
|
|
1d31e6c00 net_node: remove dead seed nodes (selsta)
|
|
5ef0607da Update copyright year to 2020 (SomaticFanatic)
|
|
|
|
|
|
Update copyright year to 2020
|
|
c6a1294 add another seed node (Gingeropolous/selsta)
9faf3d1 Add erciccione's seed node (erciccione/selsta)
|
|
145be6d p2p: startup speedup, init seed nodes on first 'connect_to_seed()' (xiphon)
|
|
node is funded by random people and managed by me. currently functioning as public node at uwillrunanodesoon.moneroworld.com
|
|
|
|
|
|
|
|
7b9017f p2p: plug tor to clearnet association vector (Aaron Hook)
|
|
When a handshake fails, it can fail due to timeout or destroyed
connection, in which case the connection will be, or already is,
closed, and we don't want to do it twice.
Additionally, when closing a connection directly from the top
level code, ensure the connection is gone from the m_connects
list so it won't be used again.
AFAICT this is now clean in netstat, /proc/PID/fd and print_cn.
This fixes a noisy (but harmless) exception.
|
|
bcae95a2 p2p: do not add recently failed addresses to the peerlist (moneromooo-monero)
|
|
a84131ce p2p: fix off by one adding fallback peers (moneromooo-monero)
|
|
b818522d p2p: fix spurious warning when we're connected to at last one seed (moneromooo-monero)
|
|
36bdf402 p2p: fix adding wrong indices to the filtered peer list (moneromooo-monero)
|
|
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
- Stem loops detected in tx_pool.cpp
- Embargo timeout for a blackhole attack during stem phase
|
|
8d23047 p2p: add another seed node (moneromooo-monero)
|
|
Node from syksy, administered by mooo
|
|
|
|
|
|
4771a7ae p2p: remove obsolete local time in handshake (moneromooo-monero)
2fbbc4a2 p2p: avoid sending the same peer list over and over (moneromooo-monero)
3004835b epee: remove backward compatible endian specific address serialization (moneromooo-monero)
39a343d7 p2p: remove backward compatible peer list (moneromooo-monero)
60631802 p2p: simplify last_seen serialization now we have optional stores (moneromooo-monero)
9467b2e4 cryptonote_protocol: omit top 64 bits of difficulty when 0 (moneromooo-monero)
b595583f serialization: do not write optional fields with default value (moneromooo-monero)
5f98b46d p2p: remove obsolete local time from TIMED_SYNC (moneromooo-monero)
|
|
During the handshake for an incoming connection, the peer id is checked against the local node's peer id only for the specific zone of the incoming peer, in order to avoid linking public addresses to tor addresses:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L2343
However, on handshakes for outgoing connections, all zones are checked:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L1064
If an attacker wanted to link a specific tor node to a public node, they could potentially connect to as many public nodes as possible, get themselves added to the peer whitelist, maybe stuff some more attacker-owned addresses into the greylist, then disconnect, and for any future incoming connections, respond with the tor node's id in an attempt to link the public/tor addresses.
|
|
21c3d42e p2p: drop the peerlist dump to TRACE (moneromooo-monero)
|
|
deb350b7 always print peer IDs in the same format (moneromooo-monero)
|
|
|
|
Also removes a potential fingerprinting vector
|
|
Nodes remember which connections have been sent which peer addresses
and won't send it again. This causes more addresses to be sent as
the connection lifetime grows, since there is no duplication anymore,
which increases the diffusion speed of peer addresses. The whole
white list is now considered for sending, not just the most recent
seen peers. This further hardens against topology discovery, though
it will more readily send peers that have been last seen earlier
than it otherwise would. While this does save a fair amount of net
bandwidth, it makes heavy use of std::set lookups, which does bring
network_address::less up the profile, though not too aggressively.
|
|
|
|
|
|
|
|
|
|
24adee4a p2p: don't request flags after closing connection (moneromooo-monero)
|
|
70c9cd3c Change to Tx diffusion (Dandelion++ fluff) instead of flooding (Lee Clagett)
|
|
6f45cfa5 p2p: zero last seen timestamp when inserting a new peer (moneromooo-monero)
|
|
The code would ignore the first one to be added
|
|
|
|
It's spammy
|
|
|
|
|
|
|
|
|
|
|
|
65e8a89 Change monerod --proxy to --tx-proxy (vtnerd)
|
|
Daemons intended for public use can be set up to require payment
in the form of hashes in exchange for RPC service. This enables
public daemons to receive payment for their work over a large
number of calls. This system behaves similarly to a pool, so
payment takes the form of valid blocks every so often, yielding
a large one off payment, rather than constant micropayments.
This system can also be used by third parties as a "paywall"
layer, where users of a service can pay for use by mining Monero
to the service provider's address. An example of this for web
site access is Primo, a Monero mining based website "paywall":
https://github.com/selene-kovri/primo
This has some advantages:
- incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own
- incentive to run your own node instead of using a third party's, thereby promoting decentralization
- decentralized: payment is done between a client and server, with no third party needed
- private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance
- no payment occurs on the blockchain, so there is no extra transactional load
- one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy)
- no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do
- Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue
- no large credit balance maintained on servers, so they have no incentive to exit scam
- you can use any/many node(s), since there's little cost in switching servers
- market based prices: competition between servers to lower costs
- incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others
- increases network security
- helps counteract mining pools' share of the network hash rate
- zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner
And some disadvantages:
- low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine)
- payment is "random", so a server might go a long time without a block before getting one
- a public node's overall expected payment may be small
Public nodes are expected to compete to find a suitable level for
cost of service.
The daemon can be set up this way to require payment for RPC services:
monerod --rpc-payment-address 4xxxxxx \
--rpc-payment-credits 250 --rpc-payment-difficulty 1000
These values are an example only.
The --rpc-payment-difficulty switch selects how hard each "share" should
be, similar to a mining pool. The higher the difficulty, the fewer
shares a client will find.
The --rpc-payment-credits switch selects how many credits are awarded
for each share a client finds.
Considering both options, clients will be awarded credits/difficulty
credits for every hash they calculate. For example, in the command line
above, 0.25 credits per hash. A client mining at 100 H/s will therefore
get an average of 25 credits per second.
For reference, in the current implementation, a credit is enough to
sync 20 blocks, so a 100 H/s client that's just starting to use Monero
and uses this daemon will be able to sync 500 blocks per second.
The wallet can be set to automatically mine if connected to a daemon
which requires payment for RPC usage. It will try to keep a balance
of 50000 credits, stopping mining when it's at this level, and starting
again as credits are spent. With the example above, a new client will
mine this much credits in about half an hour, and this target is enough
to sync 500000 blocks (currently about a third of the monero blockchain).
There are three new settings in the wallet:
- credits-target: this is the amount of credits a wallet will try to
reach before stopping mining. The default of 0 means 50000 credits.
- auto-mine-for-rpc-payment-threshold: this controls the minimum
credit rate which the wallet considers worth mining for. If the
daemon credits less than this ratio, the wallet will consider mining
to be not worth it. In the example above, the rate is 0.25
- persistent-rpc-client-id: if set, this allows the wallet to reuse
a client id across runs. This means a public node can tell a wallet
that's connecting is the same as one that connected previously, but
allows a wallet to keep their credit balance from one run to the
other. Since the wallet only mines to keep a small credit balance,
this is not normally worth doing. However, someone may want to mine
on a fast server, and use that credit balance on a low power device
such as a phone. If left unset, a new client ID is generated at
each wallet start, for privacy reasons.
To mine and use a credit balance on two different devices, you can
use the --rpc-client-secret-key switch. A wallet's client secret key
can be found using the new rpc_payments command in the wallet.
Note: anyone knowing your RPC client secret key is able to use your
credit balance.
The wallet has a few new commands too:
- start_mining_for_rpc: start mining to acquire more credits,
regardless of the auto mining settings
- stop_mining_for_rpc: stop mining to acquire more credits
- rpc_payments: display information about current credits with
the currently selected daemon
The node has an extra command:
- rpc_payments: display information about clients and their
balances
The node will forget about any balance for clients which have
been inactive for 6 months. Balances carry over on node restart.
|
|
|
|
6fdaaba node.inl, add xmrchain.net IP to hardcoded peers (Gingeropolous)
|
|
ec7f2ff p2p: reject invalid rpc_port in peer lists (xiphon)
|
|
4ce40ed p2p: reject invalid pruning seeds in peer lists (moneromooo-monero)
|
|
d4d2b5c p2p+rpc: don't skip p2p or rpc port bind failure by default (xiphon)
|
|
3455efa ban peers sending bad pow outright (moneromooo-monero)
|
|
added for mainnet, testnet, and stagenet.
server is owner by snipa, both snipa and I have access to it. No idea where its hosted.
xmrchain.net is a block explorer thats been around a while.
|
|
|
|
f3b65c6 Request a thread stack size that is large enough for unbound (omartijn)
|
|
2a7d915 Fixed i2p/tor tx flooding bug (white noise disabled) (vtnerd)
|
|
|
|
|
|
PoW is expensive to verify, so be strict
|
|
Unbound uses a 64 kb large character array on the stack, which
leads to a stack overflow for some libc implementations. musl
only gives 80 kb in total. This PR changes the stack size for
these threads to 1mb, which solves the segmentation fault.
|
|
|
|
cae488d p2p: reject incoming connections to self (moneromooo-monero)
|
|
e353e3d p2p: sanitize peer lists (moneromooo-monero)
|
|
2e26536 p2p: move log away from global (moneromooo-monero)
|
|
IP addresses are stored in network byte order even on little
endian hosts
|
|
|
|
Also remove the delta time fixup, since we now ignore those
as they're attacker controlled
|
|
It was here while debugging, and I forgot to move it away
|
|
fd60d05 daemon: fix print_pl only printing public zone peers (moneromooo-monero)
|
|
|
|
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
|
|
3768db2 p2p: add a reference to Cao, Tong et al. for the last_seen changes (moneromooo-monero)
|
|
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero)
098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
|
|
According to [1], std::random_shuffle is deprecated in C++14 and removed
in C++17. Since std::shuffle is available since C++11 as a replacement
and monero already requires C++11, this is a good replacement.
A cryptographically secure random number generator is used in all cases
to prevent people from perhaps copying an insecure std::shuffle call
over to a place where a secure one would be warranted. A form of
defense-in-depth.
[1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
|
|
new cli options (RPC ones also apply to wallet):
--p2p-bind-ipv6-address (default = "::")
--p2p-bind-port-ipv6 (default same as ipv4 port for given nettype)
--rpc-bind-ipv6-address (default = "::1")
--p2p-use-ipv6 (default false)
--rpc-use-ipv6 (default false)
--p2p-require-ipv4 (default true, if ipv4 bind fails and this is
true, will not continue even if ipv6 bind
successful)
--rpc-require-ipv4 (default true, description as above)
ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except
in the cases of the cli args for bind address. For those the square
braces can be omitted.
|
|
|
|
068fa1c p2p: delay IGP probing on startup (moneromooo-monero)
|
|
fcfcc3a rpc: in/out peers can now return the setting's value (moneromooo-monero)
|
|
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
|
|
515ac29 p2p: store network address directly in blocked host list (moneromooo-monero)
65c4004 allow blocking whole subnets (moneromooo-monero)
|
|
a96c1a46 cryptonote_protocol: drop peers we can't download from when syncing (moneromooo-monero)
ab361df2 p2p: add a few missing connection close calls (moneromooo-monero)
|
|
|
|
|
|
rather than their string representation
|
|
|
|
|
|
Older nodes don't pass that information around
|
|
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
|
|
|
|
|
|
|
|
We might have external access without having to do this
|
|
|
|
|
|
This can be used for fingerprinting and working out the
network topology.
Instead of sending the first N (which are sorted by last
seen time), we sent a random subset of the first N+N/5,
which ensures reasonably recent peers are used, while
preventing repeated calls from deducing new entries are
peers the target node just connected to.
The list is also randomly shuffled so the original set of
timestamps cannot be approximated.
|
|
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
|
|
|
|
|
|
19f8089f p2p: don't lookup seed nodes when offline (moneromooo-monero)
|
|
This will cause DNS requests, which will block and timeout
if there is really no network connectivity
|
|
|
|
a54e81e5 daemon: add '--no-sync' arg to optionally disable blockchain sync (xiphon)
|
