aboutsummaryrefslogtreecommitdiff
path: root/src/p2p (follow)
AgeCommit message (Collapse)AuthorFilesLines
2019-10-08Merge pull request #5932luigi11111-1/+8
f3b65c6 Request a thread stack size that is large enough for unbound (omartijn)
2019-10-08Merge pull request #5921luigi11111-2/+2
2a7d915 Fixed i2p/tor tx flooding bug (white noise disabled) (vtnerd)
2019-09-25Request a thread stack size that is large enough for unboundMartijn Otto1-1/+8
Unbound uses a 64 kb large character array on the stack, which leads to a stack overflow for some libc implementations. musl only gives 80 kb in total. This PR changes the stack size for these threads to 1mb, which solves the segmentation fault.
2019-09-16p2p: fix bans taking port into accountmoneromooo-monero3-10/+10
2019-09-08Merge pull request #5841luigi11111-1/+10
cae488d p2p: reject incoming connections to self (moneromooo-monero)
2019-09-08Merge pull request #5839luigi11112-17/+26
e353e3d p2p: sanitize peer lists (moneromooo-monero)
2019-09-08Merge pull request #5838luigi11111-1/+1
2e26536 p2p: move log away from global (moneromooo-monero)
2019-09-04Fix IP address serialization on big endianmoneromooo-monero1-0/+2
IP addresses are stored in network byte order even on little endian hosts
2019-08-22p2p: reject incoming connections to selfmoneromooo-monero1-1/+10
2019-08-21p2p: sanitize peer listsmoneromooo-monero2-17/+26
Also remove the delta time fixup, since we now ignore those as they're attacker controlled
2019-08-21p2p: move log away from globalmoneromooo-monero1-1/+1
It was here while debugging, and I forgot to move it away
2019-08-20Merge pull request #5696luigi11112-0/+10
fd60d05 daemon: fix print_pl only printing public zone peers (moneromooo-monero)
2019-08-19daemon: fix print_pl only printing public zone peersmoneromooo-monero2-0/+10
2019-08-19Merge pull request #5727luigi11111-1/+1
7b9a420 Replace std::random_shuffle with std::shuffle (tomsmeding)
2019-08-15Merge pull request #5682luigi11111-0/+3
3768db2 p2p: add a reference to Cao, Tong et al. for the last_seen changes (moneromooo-monero)
2019-08-15Merge pull request #5674luigi11111-2/+3
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero) 098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
2019-08-15Replace std::random_shuffle with std::shuffleTom Smeding1-1/+1
According to [1], std::random_shuffle is deprecated in C++14 and removed in C++17. Since std::shuffle is available since C++11 as a replacement and monero already requires C++11, this is a good replacement. A cryptographically secure random number generator is used in all cases to prevent people from perhaps copying an insecure std::shuffle call over to a place where a secure one would be warranted. A form of defense-in-depth. [1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-07-31Add IPv6 supportThomas Winget4-34/+231
new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.
2019-07-29Fixed i2p/tor tx flooding bug (white noise disabled)Lee Clagett1-2/+2
2019-07-24Merge pull request #5610luigi11113-7/+54
068fa1c p2p: delay IGP probing on startup (moneromooo-monero)
2019-07-24Merge pull request #5582luigi11112-0/+20
fcfcc3a rpc: in/out peers can now return the setting's value (moneromooo-monero)
2019-07-24Merge pull request #5530luigi11113-18/+0
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
2019-07-24Merge pull request #5363luigi11113-18/+116
515ac29 p2p: store network address directly in blocked host list (moneromooo-monero) 65c4004 allow blocking whole subnets (moneromooo-monero)
2019-07-17Merge pull request #5732Riccardo Spagni1-2/+6
a96c1a46 cryptonote_protocol: drop peers we can't download from when syncing (moneromooo-monero) ab361df2 p2p: add a few missing connection close calls (moneromooo-monero)
2019-07-17Added support for "noise" over I1P/Tor to mask Tx transmission.Lee Clagett4-16/+115
2019-07-16allow blocking whole subnetsmoneromooo-monero3-10/+108
2019-07-16p2p: store network address directly in blocked host listmoneromooo-monero3-8/+8
rather than their string representation
2019-07-05p2p: don't connect to more than one IP per class B if we canmoneromooo-monero1-11/+45
2019-07-04p2p: add a few missing connection close callsmoneromooo-monero1-2/+6
2019-06-26p2p: don't forget pruning seed or public RPC port when updating peersmoneromooo-monero1-4/+16
Older nodes don't pass that information around
2019-06-21p2p: add a reference to Cao, Tong et al. for the last_seen changesmoneromooo-monero1-0/+3
"Exploring the Monero Peer-to-Peer Network". https://eprint.iacr.org/2019/411
2019-06-19p2p: close the right number of connections on setting max in/out peersmoneromooo-monero1-2/+2
2019-06-19p2p: propagate out peers limit to payload handlermoneromooo-monero1-0/+1
2019-06-08p2p: fix GCC 9.1 crashmoneromooo-monero1-4/+6
2019-06-06p2p: delay IGP probing on startupmoneromooo-monero3-7/+54
We might have external access without having to do this
2019-05-30rpc: in/out peers can now return the setting's valuemoneromooo-monero2-0/+20
2019-05-10remove obsolete save_graph skeleton codemoneromooo-monero3-18/+0
2019-04-24p2p: do not send last_seen timestamp to peersmoneromooo-monero3-12/+30
This can be used for fingerprinting and working out the network topology. Instead of sending the first N (which are sorted by last seen time), we sent a random subset of the first N+N/5, which ensures reasonably recent peers are used, while preventing repeated calls from deducing new entries are peers the target node just connected to. The list is also randomly shuffled so the original set of timestamps cannot be approximated.
2019-04-16Merge pull request #5425Riccardo Spagni1-1/+8
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
2019-04-11p2p: fix integer overflow in host bansmoneromooo-monero1-1/+8
2019-04-04crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)stoffu2-3/+3
2019-04-01Merge pull request #5334Riccardo Spagni1-1/+1
19f8089f p2p: don't lookup seed nodes when offline (moneromooo-monero)
2019-03-22p2p: don't lookup seed nodes when offlinemoneromooo-monero1-1/+1
This will cause DNS requests, which will block and timeout if there is really no network connectivity
2019-03-20Fix daemon startup parameter '--limit-rate' processing after parameter defaultsrbrunner71-4/+2
2019-03-19Merge pull request #5195Riccardo Spagni3-0/+6
a54e81e5 daemon: add '--no-sync' arg to optionally disable blockchain sync (xiphon)
2019-03-17Merge pull request #5190Riccardo Spagni5-12/+39
551104fb daemon: add --public-node mode, RPC port propagation over P2P (xiphon)
2019-03-05Update 2019 copyrightbinaryFate9-9/+9
2019-03-05p2p: avoid busy loop when we have nothing to connect tomoneromooo-monero1-1/+9
2019-03-04default initialize rpc structuresmoneromooo-monero2-17/+32
2019-03-04Merge pull request #5091Riccardo Spagni3-3/+60
123fc2a2 i2p: initial support (Jethro Grassie)
2019-02-25daemon: add '--no-sync' arg to optionally disable blockchain syncxiphon3-0/+6
2019-02-25daemon: add --public-node mode, RPC port propagation over P2Pxiphon5-12/+39
2019-02-02epee: add SSL supportmoneromooo-monero2-10/+13
RPC connections now have optional tranparent SSL. An optional private key and certificate file can be passed, using the --{rpc,daemon}-ssl-private-key and --{rpc,daemon}-ssl-certificate options. Those have as argument a path to a PEM format private private key and certificate, respectively. If not given, a temporary self signed certificate will be used. SSL can be enabled or disabled using --{rpc}-ssl, which accepts autodetect (default), disabled or enabled. Access can be restricted to particular certificates using the --rpc-ssl-allowed-certificates, which takes a list of paths to PEM encoded certificates. This can allow a wallet to connect to only the daemon they think they're connected to, by forcing SSL and listing the paths to the known good certificates. To generate long term certificates: openssl genrsa -out /tmp/KEY 4096 openssl req -new -key /tmp/KEY -out /tmp/REQ openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT /tmp/KEY is the private key, and /tmp/CERT is the certificate, both in PEM format. /tmp/REQ can be removed. Adjust the last command to set expiration date, etc, as needed. It doesn't make a whole lot of sense for monero anyway, since most servers will run with one time temporary self signed certificates anyway. SSL support is transparent, so all communication is done on the existing ports, with SSL autodetection. This means you can start using an SSL daemon now, but you should not enforce SSL yet or nothing will talk to you.
2019-01-30i2p: initial supportJethro Grassie3-3/+60
2019-01-28Adding initial support for broadcasting transactions over TorLee Clagett9-649/+1570
- Support for ".onion" in --add-exclusive-node and --add-peer - Add --anonymizing-proxy for outbound Tor connections - Add --anonymous-inbounds for inbound Tor connections - Support for sharing ".onion" addresses over Tor connections - Support for broadcasting transactions received over RPC exclusively over Tor (else broadcast over public IP when Tor not enabled).
2019-01-22Pruningmoneromooo-monero6-54/+234
The blockchain prunes seven eighths of prunable tx data. This saves about two thirds of the blockchain size, while keeping the node useful as a sync source for an eighth of the blockchain. No other data is currently pruned. There are three ways to prune a blockchain: - run monerod with --prune-blockchain - run "prune_blockchain" in the monerod console - run the monero-blockchain-prune utility The first two will prune in place. Due to how LMDB works, this will not reduce the blockchain size on disk. Instead, it will mark parts of the file as free, so that future data will use that free space, causing the file to not grow until free space grows scarce. The third way will create a second database, a pruned copy of the original one. Since this is a new file, this one will be smaller than the original one. Once the database is pruned, it will stay pruned as it syncs. That is, there is no need to use --prune-blockchain again, etc.
2019-01-16Merge pull request #5029Riccardo Spagni1-1/+1
d1b3990d p2p: don't stop the idle thread when no gray peers are found (moneromooo-monero)
2019-01-16Merge pull request #5001Riccardo Spagni1-3/+4
a5ffc2d5 Remove boost::lexical_cast for uuid and unused uuid function (Lee Clagett)
2019-01-16Merge pull request #4976Riccardo Spagni3-16/+16
85665003 epee: better network buffer data structure (moneromooo-monero)
2018-12-30p2p: don't stop the idle thread when no gray peers are foundmoneromooo-monero1-1/+1
2018-12-23epee: better network buffer data structuremoneromooo-monero3-16/+16
avoids pointless allocs and memcpy
2018-12-23Remove boost::lexical_cast for uuid and unused uuid functionLee Clagett1-3/+4
2018-12-07p2p: use vector instead of list for peer listsmoneromooo-monero4-24/+27
2018-12-04Merge pull request #4854Riccardo Spagni1-1/+3
bd98e99c Removed a lot of unnecessary includes (Martijn Otto)
2018-11-16Merge pull request #4776Riccardo Spagni2-4/+11
03fc731b p2p: less frequent incoming connections check (moneromooo-monero) 14a5c206 p2p: tone down "no incoming connections" warning to info if in peers is 0 (moneromooo-monero)
2018-11-15Removed a lot of unnecessary includesMartijn Otto1-1/+3
2018-11-01p2p: less frequent incoming connections checkmoneromooo-monero1-1/+1
2018-11-01p2p: tone down "no incoming connections" warning to info if in peers is 0moneromooo-monero1-3/+10
Also add an info if not offline, since it weakens the network
2018-10-31Expose limit-rate defaults from command line helpRaskaRuby2-4/+4
2018-10-26Merge pull request #4612Riccardo Spagni1-4/+8
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
2018-10-16p2p: only deinitialize what's been initialized in offline modemoneromooo-monero1-4/+8
2018-10-15p2p: a negative result from UPNP_GetValidIGD is an errormoneromooo-monero1-2/+2
as per the source documentation
2018-10-15Merge pull request #4578Riccardo Spagni1-3/+3
76d6d832 Revert "p2p: connect via the bound ip, if any" (moneromooo-monero)
2018-10-13Revert "p2p: connect via the bound ip, if any"moneromooo-monero1-3/+3
This reverts commit 909398efc79cb1fa92e330e9a50a316ca5858953. It looks like it's causing trouble with tor on some setups
2018-10-12Remove epee header dependency on cryptonote_coremoneromooo-monero1-0/+1
2018-08-15Merge pull request #4089luigi11111-3/+3
909398e p2p: connect via the bound ip, if any (moneromooo-monero)
2018-07-19Merge pull request #4075luigi11111-1/+0
438d52d remove epee from link lines where it's redundant (moneromooo-monero)
2018-07-19Merge pull request #3854luigi11111-0/+3
149da42 db_lmdb: enable batch transactions by default (stoffu) 34cb6b4 add --regtest and --fixed-difficulty for regression testing (vicsn) 9e1403e update get_info RPC and bump RPC version (vicsn) 207b66e first new functional tests (vicsn)
2018-07-02p2p: connect via the bound ip, if anymoneromooo-monero1-3/+3
2018-06-29add --regtest and --fixed-difficulty for regression testingvictorsintnicolaas1-0/+3
on_generateblocks RPC call combines functionality from the on_getblocktemplate and on_submitblock RPC calls to allow rapid block creation. Difficulty is set permanently to 1 for regtest. Makes use of FAKECHAIN network type, but takes hard fork heights from mainchain Default reserve_size in generate_blocks RPC call is now 1. If it is 0, the following error occurs 'Failed to calculate offset for'. Queries hard fork heights info of other network types
2018-06-28remove epee from link lines where it's redundantmoneromooo-monero1-1/+0
For some reason, this confuses and kills ASAN on startup as it thinks const uint8_t ipv4_network_address::ID is defined multiple times.
2018-06-27Merge pull request #3982luigi11111-16/+46
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu) 0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
2018-06-19Merge pull request #3861luigi11112-0/+16
de1ffe0 p2p: warn when no incoming connections are seen for a while (moneromooo-monero)
2018-06-11net_node: resolve host for node addresses given via command line flagsstoffu1-13/+43
2018-06-11cryptonote_config: add get_config to refactor x = testnet ? ↵stoffu1-3/+3
config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-05-26p2p: warn when no incoming connections are seen for a whilemoneromooo-monero2-0/+16
2018-04-29p2p: fix fallback seed node usagemoneromooo-monero2-3/+11
Those were added to the seed nodes list even when they had already been added. Moreover, the current index was not reset after they were added, typically causing previous seeds to be used, and some of those fallback seeds to not be tried.
2018-04-25Fix broken interactive daemon 'limit' commands plus RPC callsrbrunner71-2/+2
2018-04-21Build: update CMake and p2p for in-tree miniupnpanonimal1-10/+3
(cherry picked from commit a7366b5feeffaeb65b217b2d6f138e0ab1c90192)
2018-04-19CMake: update new location of in-tree miniupnpcanonimal1-3/+3
(cherry picked from commit b16a282f97d8f6c967e8a0b1ecfd75110f095182)
2018-04-12Merge pull request #3502Riccardo Spagni1-1/+1
11c933e1 fix lambda compile error on openbsd (moneromooo-monero)
2018-03-27fix lambda compile error on openbsdmoneromooo-monero1-1/+1
2018-03-22p2p: correct port number for seed nodesstoffu1-3/+3
2018-03-13p2p: fix network ID being uninitialised when using exclusive peersmoneromooo-monero1-1/+4
2018-03-05Stagenetstoffu3-18/+34
2018-02-20Merge pull request #3290Riccardo Spagni1-0/+1
1d28c0d8 p2p: restore m_testnet assignment lost during rebase (whythat)
2018-02-18p2p: restore m_testnet assignment lost during rebasewhythat1-0/+1
2018-02-18p2p: need libcryptonote_core due to arg_testnet_on being usedstoffu1-0/+1
2018-02-16options: add testnet option dependencieswhythat1-2/+6
2018-02-16options: remove testnet-* optionswhythat3-16/+6
2018-02-16Merge pull request #3196Riccardo Spagni1-1/+2
eda9fb5b p2p: fix testnet/mainnet port mixup (moneromooo-monero)
2018-02-16Merge pull request #3226Riccardo Spagni2-2/+2
e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero) 2e3e90ac pass large parameters by const ref, not value (moneromooo-monero) 61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero) 9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero) 8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero) 9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero) 24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero) f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero) c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero) fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero) 03887f11 keccak: fix sanity check bounds test (moneromooo-monero) ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero) bece67f9 miner: restore std::cout precision after modification (moneromooo-monero) 1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
2018-02-16Merge pull request #3221Riccardo Spagni1-0/+2
2e584dcb p2p: do not try to connect to peers in offline mode (moneromooo-monero)
2018-02-02pass large parameters by const ref, not valuemoneromooo-monero2-2/+2
Coverity 136394 136397 136409 136526 136529 136533 175302
2018-02-01p2p: do not try to connect to peers in offline modemoneromooo-monero1-0/+2
2018-01-29Allow the number of incoming connections to be limitedErik de Castro Lopo4-3/+63
It was already possible to limit outgoing connections. One might want to do this on home network connections with high bandwidth but low usage caps.
2018-01-29Rename delete_connections to delete_out_connectionsErik de Castro Lopo2-2/+2
This rename is needed so that delete_in_connections can be added.
2018-01-29Rename connections_count to max_out_connection_countErik de Castro Lopo2-12/+12
This is needed so that a max_in_connection_count can be added.
2018-01-28p2p: fix testnet/mainnet port mixupmoneromooo-monero1-1/+2
2018-01-27Merge pull request #3145Riccardo Spagni1-6/+6
fd1dfac5 p2p: don't lookup seed IPs if using an exclusive peer (moneromooo-monero) b50182ae p2p: don't connect to seeds if using an exclusive peer (moneromooo-monero)
2018-01-26Update 2018 copyrightxmr-eric9-9/+9
2018-01-18p2p: fix picking peers off an empty gray listmoneromooo-monero1-1/+4
2018-01-17p2p: don't lookup seed IPs if using an exclusive peermoneromooo-monero1-5/+5
2018-01-17p2p: don't connect to seeds if using an exclusive peermoneromooo-monero1-1/+1
2018-01-10fix some link errors in debug mode for macosstoffu1-0/+1
2017-12-25Merge pull request #2928Riccardo Spagni1-2/+5
d28c388f p2p: stop net server before closing starting connections (moneromooo-monero)
2017-12-18p2p: use size_t for arbitrary counters instead of uint8_tmoneromooo-monero1-2/+2
2017-12-17Merge pull request #2877Riccardo Spagni10-1261/+90
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
2017-12-16move connection_basic and network_throttle from src/p2p to epeemoneromooo-monero6-1214/+0
These even had the epee namespace. This fixes some ugly circular dependencies.
2017-12-16cryptonote_core does not depend on p2p anymoremoneromooo-monero4-47/+90
As a followon side effect, this makes a lot of inline code included only in particular cpp files (and instanciated when necessary.
2017-12-16move includes around to lessen overall loadmoneromooo-monero1-0/+2
2017-12-16Merge pull request #2878Riccardo Spagni1-4/+2
abebe392 rpc: add offline state in info rpc (moneromooo-monero) 7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
2017-12-15p2p: stop net server before closing starting connectionsmoneromooo-monero1-2/+5
This fixes a hang on exit due to race where a connection adds itself to the server after the starting connections are closed, but before the net server marks itself as stopped.
2017-11-30core: make --offline also disable DNS lookupsmoneromooo-monero1-4/+2
2017-11-28Corrections in rate limiting / trottle code, especially in 'out' directionrbrunner75-33/+18
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet that were erroneous / superfluous, which enabled the elimination of a "fudge" factor of 2.1 in connection_basic::set_rate_up_limit; also ended the multiplying of limit values and numbers of bytes transferred by 1024 before handing them over to the global throttle objects
2017-11-14Merge pull request #2736Riccardo Spagni1-2/+3
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu) 178014c9 split off readline code into epee_readline (moneromooo-monero) a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero) 437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero) e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero) ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero) 082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
2017-11-14move cryptonote command line options to cryptonote_coremoneromooo-monero1-2/+3
Those have no reason to be in a generic module
2017-11-14remove "using namespace std" from headersmoneromooo-monero1-2/+2
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;
2017-10-09Fix an object lifetime bug in net load testsmoneromooo-monero1-1/+1
The commands handler must not be destroyed before the config object, or we'll be accessing freed memory. An earlier attempt at using boost::shared_ptr to control object lifetime turned out to be very invasive, though would be a better solution in theory.
2017-10-05Upgrades to epee::net_utils::network_addressLee Clagett3-15/+22
- internal nullptr checks - prevent modifications to network_address (shallow copy issues) - automagically works with any type containing interface functions - removed fnv1a hashing - ipv4_network_address now flattened with no base class
2017-09-25version: fix link to new version stringsmoneromooo-monero1-0/+1
p2p uses it, and the cpp file needs to know the symbols should be public
2017-09-25Merge pull request #2424Riccardo Spagni1-20/+1
28b72b6e tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero) 50a629b2 core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero) fee15ef1 wallet2: catch failure to parse address (moneromooo-monero) 1399e26d net_peerlist: remove dead code (moneromooo-monero) 50e09698 tx_pool: guard against failure getting tx hash (moneromooo-monero) 54cc209a wallet_rpc_server: catch failure to create directory (moneromooo-monero) 3e55099c wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero) 7d0dde5e wallet_args: remove redundant default value for --log-file (moneromooo-monero) ed4a3350 wallet2: catch failure to save keys file (moneromooo-monero) 44434c8a wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero) 92f2f687 core: check return value from parse_hexstr_to_binbuff (moneromooo-monero) 5475692e wallet2_api: remove an unused, uninitialized, field (moneromooo-monero) a7ba3de1 libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero) b2763ace wallet2_api: init error code to "no error" in the ctor (moneromooo-monero) b5faac53 get_blockchain_top now returns void (moneromooo-monero) 2e44d8f2 wallet_rpc_server: guard against exceptions (moneromooo-monero) 4230876b simplewallet: guard against I/O exceptions (moneromooo-monero) 06c1e057 daemon: initialize decode_as_json in RPC request (moneromooo-monero) 11f71af5 http_base: init size_t in http_request_info ctor (moneromooo-monero)
2017-09-25Merge pull request #2442Riccardo Spagni1-2/+0
e29282d2 build: auto update version info without manually deleting version.h (stoffu)
2017-09-25net_peerlist: remove dead codemoneromooo-monero1-20/+1
CID 175290
2017-09-25Merge pull request #2428Riccardo Spagni1-0/+2
054054c9 p2p: disable gray list housekeeping when an exclusive node is given (moneromooo-monero)
2017-09-21Merge pull request #2302Riccardo Spagni1-0/+5
ef005f5e p2p: add a couple early outs when the stop signal is received (moneromooo-monero) 80d361c7 abstract_tcp_server2: improve tracking/cancelling of early connections (moneromooo-monero)
2017-09-21build: auto update version info without manually deleting version.hstoffu1-2/+0
2017-09-20Merge pull request #2376Riccardo Spagni2-48/+102
e3680b69 Rename m_listenning_port to m_listening_port (MaxXor) a1ea475f Delete UPnP port mapping on exit (MaxXor)
2017-09-10p2p: disable gray list housekeeping when an exclusive node is givenmoneromooo-monero1-0/+2
Exclusive nodes may be used for privacy reasons, and thus we don't want to connect to other nodes, even for checking connectivity. See https://github.com/monero-project/monero/issues/2346
2017-09-02Merge pull request #2329Riccardo Spagni1-0/+2
e3c4395a p2p: init hashes after deserializing a network address (moneromooo-monero)
2017-09-01Rename m_listenning_port to m_listening_portMaxXor2-7/+7
2017-08-29Delete UPnP port mapping on exitMaxXor2-43/+97
2017-08-23print peer id in 0 padded hex for consistencymoneromooo-monero2-6/+13
2017-08-23p2p: init hashes after deserializing a network addressmoneromooo-monero1-0/+2
Fixes multiple connections to the same address
2017-08-21cryptonote_protocol: misc fixes to the new sync algorithmmoneromooo-monero1-0/+2
Fix sync wedge corner case: It could happen if a connection went into standby mode, while it was the one which had requested the next span, and that span was still waiting for the data, and that peer is not on the main chain. Other peers can then start asking for that data again and again, but never get it as only that forked peer does. And various other fixes
2017-08-16p2p: add a couple early outs when the stop signal is receivedmoneromooo-monero1-0/+5
This avoids quicker exit
2017-08-15Merge pull request #2282Riccardo Spagni1-0/+2
7fdc178a p2p: fix random peer index being too large (moneromooo-monero)
2017-08-15Merge pull request #2277Riccardo Spagni1-4/+3
6ce769c1 p2p: get net log spam down a bit (moneromooo-monero)
2017-08-15Merge pull request #2236Riccardo Spagni1-22/+22
cb2d5110 Tweak net logs so we get more info on why networking can't start (moneromooo-monero)
2017-08-15Tweak net logs so we get more info on why networking can't startmoneromooo-monero1-22/+22
This should prevent "silent" failures to start
2017-08-11p2p: fix random peer index being too largemoneromooo-monero1-0/+2
2017-08-10p2p: get net log spam down a bitmoneromooo-monero1-4/+3
2017-08-09p2p: fallback on seed nodes if we can't make a connectionmoneromooo-monero2-6/+26
This avoids failing to connect to the network in case all known peers are unavailable (which can happen if the peer list is small).
2017-08-08net_node: fix m_in_timedsync initializationmoneromooo-monero2-1/+2
This fixes nodes not being able to connect to nodes which use recent code. While there, init peer_id too.
2017-08-07Merge pull request #2149Riccardo Spagni3-0/+14
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero) f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero) 90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero) 84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero) 5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
2017-08-07Merge pull request #2234Riccardo Spagni7-15/+17
214fd81e some include cleanup (moneromooo-monero)
2017-08-07Merge pull request #2220Riccardo Spagni1-0/+3
c6ba7d11 p2p: move m_in_timedsync from connection_context to p2p_connection_context (moneromooo-monero)
2017-08-07Merge pull request #2219Riccardo Spagni1-6/+14
04ebfbfe p2p: close connections when exiting (moneromooo-monero) 9a10148c p2p: fix thread leak (moneromooo-monero)
2017-08-07Merge pull request #2215Riccardo Spagni2-1/+9
06aea2cf move get_proof_of_trust_hash from util.h to p2p_protocol_defs.h (moneromooo-monero)
2017-08-07cryptonote_protocol_handler: sync speedupmoneromooo-monero3-0/+14
A block queue is now placed between block download and block processing. Blocks are now requested only from one peer (unless starved). Includes a new sync_info coommand.
2017-08-01network_throttle: remove unneeded heap allocationsmoneromooo-monero2-19/+6
This will keep leak traces less noisy, as those were one off allocations that were technically leaking.
2017-08-01p2p: move m_in_timedsync from connection_context to p2p_connection_contextmoneromooo-monero1-0/+3
It's got no place in the base class as it's P2P specific field
2017-07-31some include cleanupmoneromooo-monero7-15/+17
2017-07-29p2p: close connections when exitingmoneromooo-monero1-0/+8
This ensures they don't leak if they were in the middle of an async operation.
2017-07-28p2p: fix thread leakmoneromooo-monero1-6/+6
2017-07-27move get_proof_of_trust_hash from util.h to p2p_protocol_defs.hmoneromooo-monero2-1/+9
This avoids having to include p2p_protocol_defs.h in util.h, as util.h is used a lot, and p2p_protocol_defs.h includes a lot of other things that most users don't need.
2017-06-28Remove typeid use in network_addressmoneromooo-monero3-20/+12
Since I had to add an ID to the derived classes anyway, this can be used instead. This removes an apparently pointless warning from CLANG too.
2017-06-24Merge pull request #2073Riccardo Spagni1-2/+6
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu) cf3a376c Don't timeout a slow operation that's making progress (Howard Chu) 340830de Fix PR#2039 (Howard Chu)
2017-06-15Don't issue a new timedsync while one is already in progressHoward Chu1-2/+6
A timedsync is issued every minute on a connection, but the input tineout is 2 minutes. This means a new sync request could be issued while a slow sync request was already in progress. The additional request will further clog the network on a slow connection, and cause a premature timeout.
2017-05-27abstracted nework addressesmoneromooo-monero6-189/+320
All code which was using ip and port now uses a new IPv4 object, subclass of a new network_address class. This will allow easy addition of I2P addresses later (and also IPv6, etc). Both old style and new style peer lists are now sent in the P2P protocol, which is inefficient but allows peers using both codebases to talk to each other. This will be removed in the future. No other subclasses than IPv4 exist yet.
2017-05-05Merge pull request #1701Riccardo Spagni5-18/+207
8277e67f Add anchor connections (Miguel Herranz)
2017-03-18p2p: use the fallback seed IPs when not enough seeds are foundmoneromooo-monero2-27/+64
In case the DNS seed(s) is/are down, which would otherwise cause the fallback seeds to never be used. Also if the seeds resolve to too few IPs.
2017-02-28Make gray peer selection uniformMiguel Herranz1-1/+8
Prevents the system from always picking the gray peers with the most recent last_seen.
2017-02-27Make get_random_gray_peer distribution uniformMiguel Herranz1-5/+2
get_random_gray_peer is used to implement feeler connections, described in: https://eprint.iacr.org/2015/263.pdf 2. Random selection
2017-02-21updated fallback nodesRiccardo Spagni1-6/+12
2017-02-21update copyright year, fix occasional lack of newline at line endRiccardo Spagni14-14/+14
2017-02-21core: add p2p bind port options from net_nodemoneromooo-monero1-2/+2
They're now used by core to determine the data directory to use for the txpool directory. This fixes an assert in the core tests, which don't use the RPC server, which normally initializes the P2P code.
2017-02-13network_throttle: demote spammy logs to TRACEmoneromooo-monero1-2/+2
2017-02-12net_node: fix spurious warning about using uninitialized datamoneromooo-monero1-1/+1
This is only used to load, not save
2017-02-10Add anchor connectionsMiguel Herranz5-18/+207
Based on https://eprint.iacr.org/2015/263.pdf 4. Anchor connections. Peer list serialisation version bumped to 5.
2017-02-08extract some basic code from libcryptonote_core into libcryptonote_basickenshi841-0/+1
2017-02-02Merge pull request #1641Riccardo Spagni1-0/+5
ca94d0a4 Separate data per P2P port (Miguel Herranz)
2017-02-02Merge pull request #1617Riccardo Spagni7-12/+8
0644eed7 Remove boost/foreach.cpp includes (Miguel Herranz) 36dd3e23 Replace BOOST_REVERSE_FOREACH with ranged for (Miguel Herranz) 629e3101 Replace BOOST_FOREACH with C++11 ranged for (Miguel Herranz)
2017-01-28Separate data per P2P portMiguel Herranz1-0/+5
poolstate.bin and p2pstate.bin are stored in .bitmonero/ if the default P2P port is being used. If another port is used both files are stored in .bitmonero/PORTNUMBER/.
2017-01-23Remove unreachable returnsMiguel Herranz1-3/+0
CATCH_ENTRY_L0 already returns the second value.
2017-01-22Remove boost/foreach.cpp includesMiguel Herranz5-5/+0
2017-01-22Replace BOOST_REVERSE_FOREACH with ranged forMiguel Herranz1-3/+4
2017-01-22Replace BOOST_FOREACH with C++11 ranged forMiguel Herranz3-4/+4
2017-01-22Merge pull request #1609Riccardo Spagni2-2/+17
4cdf0a35 p2p: always recreate a new peer id on startup (moneromooo-monero)
2017-01-22Merge pull request #1606Riccardo Spagni1-3/+3
f8b97aef p2p: show ban/unban logs by default again (moneromooo-monero)
2017-01-22p2p: always recreate a new peer id on startupmoneromooo-monero2-2/+17
This prevents easy fingerprinting when you change IPs, and will be a must when kovri gets used.
2017-01-21p2p: show ban/unban logs by default againmoneromooo-monero1-3/+3
2017-01-21Rename method to get_random_gray_peerMiguel Herranz2-4/+4
2017-01-21Fix logging that broke after rebasingMiguel Herranz1-1/+1
2017-01-21Use set_peer_just_seen to keep last_seen updatedMiguel Herranz1-1/+1
2017-01-21Add gray peer list housekeeping systemMiguel Herranz3-0/+121
A random peer from the gray peer list is selected and a connection is made to check if the peer is alive. If the connection and handshake are successful the peer is promoted to the white peer list, in case of failure the peer is evicted from the gray peer list. The connection is closed after the check in either case.
2017-01-20Merge pull request #1593Riccardo Spagni1-2/+4
cbcdf8ad Honor depth in get_peerlist_head method (Miguel Herranz)
2017-01-20Merge pull request #1572Riccardo Spagni2-0/+32
0e0e6c5f Reduce to one connection per IP (Miguel Herranz) 3f269e98 Limit incoming connections from the same IP (Miguel Herranz)
2017-01-18Honor depth in get_peerlist_head methodMiguel Herranz1-2/+4
The method returned depth + 2 because: - push_back was executed before the condition. - > instead of >= causing one more iteration.
2017-01-16Reduce to one connection per IPMiguel Herranz1-1/+1