aboutsummaryrefslogtreecommitdiff
path: root/src/p2p/net_node.inl (follow)
AgeCommit message (Collapse)AuthorFilesLines
2020-02-06Merge pull request #6053Alexander Blair1-6/+6
deb350b7 always print peer IDs in the same format (moneromooo-monero)
2020-01-26network: log traffic and add a simple traffic analysis scriptmoneromooo-monero1-4/+4
2020-01-24Merge pull request #6153Alexander Blair1-1/+1
24adee4a p2p: don't request flags after closing connection (moneromooo-monero)
2020-01-24Merge pull request #6146Alexander Blair1-6/+8
70c9cd3c Change to Tx diffusion (Dandelion++ fluff) instead of flooding (Lee Clagett)
2020-01-16Merge pull request #6119Alexander Blair1-0/+1
6f45cfa5 p2p: zero last seen timestamp when inserting a new peer (moneromooo-monero)
2019-11-19p2p: don't request flags after closing connectionmoneromooo-monero1-1/+1
2019-11-11p2p: zero last seen timestamp when inserting a new peermoneromooo-monero1-0/+1
2019-11-04Change to Tx diffusion (Dandelion++ fluff) instead of floodingLee Clagett1-6/+8
2019-11-02Adding support for hidden (anonymity) txpoolLee Clagett1-3/+8
2019-10-29always print peer IDs in the same formatmoneromooo-monero1-6/+6
2019-10-25Merge pull request #6021luigi11111-4/+4
65e8a89 Change monerod --proxy to --tx-proxy (vtnerd)
2019-10-25daemon, wallet: new pay for RPC use systemmoneromooo-monero1-3/+8
Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
2019-10-24Change monerod --proxy to --tx-proxyLee Clagett1-4/+4
2019-10-22Merge pull request #5985luigi11111-0/+3
6fdaaba node.inl, add xmrchain.net IP to hardcoded peers (Gingeropolous)
2019-10-16Merge pull request #5956luigi11111-0/+2
ec7f2ff p2p: reject invalid rpc_port in peer lists (xiphon)
2019-10-16Merge pull request #5954luigi11111-0/+2
4ce40ed p2p: reject invalid pruning seeds in peer lists (moneromooo-monero)
2019-10-14Merge pull request #5943luigi11111-2/+2
d4d2b5c p2p+rpc: don't skip p2p or rpc port bind failure by default (xiphon)
2019-10-14Merge pull request #5933luigi11111-2/+2
3455efa ban peers sending bad pow outright (moneromooo-monero)
2019-10-13node.inl, add xmrchain.net IP to hardcoded peersGingeropolous1-0/+3
added for mainnet, testnet, and stagenet. server is owner by snipa, both snipa and I have access to it. No idea where its hosted. xmrchain.net is a block explorer thats been around a while.
2019-10-13p2p+rpc: don't skip p2p or rpc port bind failure by defaultxiphon1-2/+2
2019-10-08Merge pull request #5932luigi11111-1/+8
f3b65c6 Request a thread stack size that is large enough for unbound (omartijn)
2019-10-08Merge pull request #5921luigi11111-2/+2
2a7d915 Fixed i2p/tor tx flooding bug (white noise disabled) (vtnerd)
2019-10-02p2p: reject invalid pruning seeds in peer listsmoneromooo-monero1-0/+2
2019-10-02p2p: reject invalid rpc_port in peer listsxiphon1-0/+2
2019-09-25ban peers sending bad pow outrightmoneromooo-monero1-2/+2
PoW is expensive to verify, so be strict
2019-09-25Request a thread stack size that is large enough for unboundMartijn Otto1-1/+8
Unbound uses a 64 kb large character array on the stack, which leads to a stack overflow for some libc implementations. musl only gives 80 kb in total. This PR changes the stack size for these threads to 1mb, which solves the segmentation fault.
2019-09-16p2p: fix bans taking port into accountmoneromooo-monero1-4/+4
2019-09-08Merge pull request #5841luigi11111-1/+10
cae488d p2p: reject incoming connections to self (moneromooo-monero)
2019-09-08Merge pull request #5839luigi11111-15/+25
e353e3d p2p: sanitize peer lists (moneromooo-monero)
2019-09-08Merge pull request #5838luigi11111-1/+1
2e26536 p2p: move log away from global (moneromooo-monero)
2019-08-22p2p: reject incoming connections to selfmoneromooo-monero1-1/+10
2019-08-21p2p: sanitize peer listsmoneromooo-monero1-15/+25
Also remove the delta time fixup, since we now ignore those as they're attacker controlled
2019-08-21p2p: move log away from globalmoneromooo-monero1-1/+1
It was here while debugging, and I forgot to move it away
2019-08-19daemon: fix print_pl only printing public zone peersmoneromooo-monero1-0/+9
2019-08-15Merge pull request #5674luigi11111-2/+3
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero) 098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
2019-07-31Add IPv6 supportThomas Winget1-31/+161
new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.
2019-07-29Fixed i2p/tor tx flooding bug (white noise disabled)Lee Clagett1-2/+2
2019-07-24Merge pull request #5610luigi11111-5/+43
068fa1c p2p: delay IGP probing on startup (moneromooo-monero)
2019-07-24Merge pull request #5582luigi11111-0/+18
fcfcc3a rpc: in/out peers can now return the setting's value (moneromooo-monero)
2019-07-24Merge pull request #5530luigi11111-6/+0
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
2019-07-24Merge pull request #5363luigi11111-11/+99
515ac29 p2p: store network address directly in blocked host list (moneromooo-monero) 65c4004 allow blocking whole subnets (moneromooo-monero)
2019-07-17Merge pull request #5732Riccardo Spagni1-2/+6
a96c1a46 cryptonote_protocol: drop peers we can't download from when syncing (moneromooo-monero) ab361df2 p2p: add a few missing connection close calls (moneromooo-monero)
2019-07-17Added support for "noise" over I1P/Tor to mask Tx transmission.Lee Clagett1-1/+82
2019-07-16allow blocking whole subnetsmoneromooo-monero1-8/+96
2019-07-16p2p: store network address directly in blocked host listmoneromooo-monero1-3/+3
rather than their string representation
2019-07-05p2p: don't connect to more than one IP per class B if we canmoneromooo-monero1-11/+45
2019-07-04p2p: add a few missing connection close callsmoneromooo-monero1-2/+6
2019-06-19p2p: close the right number of connections on setting max in/out peersmoneromooo-monero1-2/+2
2019-06-19p2p: propagate out peers limit to payload handlermoneromooo-monero1-0/+1
2019-06-06p2p: delay IGP probing on startupmoneromooo-monero1-5/+43
We might have external access without having to do this
2019-05-30rpc: in/out peers can now return the setting's valuemoneromooo-monero1-0/+18
2019-05-10remove obsolete save_graph skeleton codemoneromooo-monero1-6/+0
2019-04-24p2p: do not send last_seen timestamp to peersmoneromooo-monero1-2/+2
This can be used for fingerprinting and working out the network topology. Instead of sending the first N (which are sorted by last seen time), we sent a random subset of the first N+N/5, which ensures reasonably recent peers are used, while preventing repeated calls from deducing new entries are peers the target node just connected to. The list is also randomly shuffled so the original set of timestamps cannot be approximated.
2019-04-16Merge pull request #5425Riccardo Spagni1-1/+8
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
2019-04-11p2p: fix integer overflow in host bansmoneromooo-monero1-1/+8
2019-04-04crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)stoffu1-2/+2
2019-04-01Merge pull request #5334Riccardo Spagni1-1/+1
19f8089f p2p: don't lookup seed nodes when offline (moneromooo-monero)
2019-03-22p2p: don't lookup seed nodes when offlinemoneromooo-monero1-1/+1
This will cause DNS requests, which will block and timeout if there is really no network connectivity
2019-03-20Fix daemon startup parameter '--limit-rate' processing after parameter defaultsrbrunner71-4/+2
2019-03-19Merge pull request #5195Riccardo Spagni1-0/+4
a54e81e5 daemon: add '--no-sync' arg to optionally disable blockchain sync (xiphon)
2019-03-17Merge pull request #5190Riccardo Spagni1-3/+8
551104fb daemon: add --public-node mode, RPC port propagation over P2P (xiphon)
2019-03-05Update 2019 copyrightbinaryFate1-1/+1
2019-03-05p2p: avoid busy loop when we have nothing to connect tomoneromooo-monero1-1/+9
2019-02-25daemon: add '--no-sync' arg to optionally disable blockchain syncxiphon1-0/+4
2019-02-25daemon: add --public-node mode, RPC port propagation over P2Pxiphon1-3/+8
2019-02-02epee: add SSL supportmoneromooo-monero1-7/+8
RPC connections now have optional tranparent SSL. An optional private key and certificate file can be passed, using the --{rpc,daemon}-ssl-private-key and --{rpc,daemon}-ssl-certificate options. Those have as argument a path to a PEM format private private key and certificate, respectively. If not given, a temporary self signed certificate will be used. SSL can be enabled or disabled using --{rpc}-ssl, which accepts autodetect (default), disabled or enabled. Access can be restricted to particular certificates using the --rpc-ssl-allowed-certificates, which takes a list of paths to PEM encoded certificates. This can allow a wallet to connect to only the daemon they think they're connected to, by forcing SSL and listing the paths to the known good certificates. To generate long term certificates: openssl genrsa -out /tmp/KEY 4096 openssl req -new -key /tmp/KEY -out /tmp/REQ openssl x509 -req -days 999999 -sha256 -in /tmp/REQ -signkey /tmp/KEY -out /tmp/CERT /tmp/KEY is the private key, and /tmp/CERT is the certificate, both in PEM format. /tmp/REQ can be removed. Adjust the last command to set expiration date, etc, as needed. It doesn't make a whole lot of sense for monero anyway, since most servers will run with one time temporary self signed certificates anyway. SSL support is transparent, so all communication is done on the existing ports, with SSL autodetection. This means you can start using an SSL daemon now, but you should not enforce SSL yet or nothing will talk to you.
2019-01-28Adding initial support for broadcasting transactions over TorLee Clagett1-432/+693
- Support for ".onion" in --add-exclusive-node and --add-peer - Add --anonymizing-proxy for outbound Tor connections - Add --anonymous-inbounds for inbound Tor connections - Support for sharing ".onion" addresses over Tor connections - Support for broadcasting transactions received over RPC exclusively over Tor (else broadcast over public IP when Tor not enabled).
2019-01-22Pruningmoneromooo-monero1-49/+149
The blockchain prunes seven eighths of prunable tx data. This saves about two thirds of the blockchain size, while keeping the node useful as a sync source for an eighth of the blockchain. No other data is currently pruned. There are three ways to prune a blockchain: - run monerod with --prune-blockchain - run "prune_blockchain" in the monerod console - run the monero-blockchain-prune utility The first two will prune in place. Due to how LMDB works, this will not reduce the blockchain size on disk. Instead, it will mark parts of the file as free, so that future data will use that free space, causing the file to not grow until free space grows scarce. The third way will create a second database, a pruned copy of the original one. Since this is a new file, this one will be smaller than the original one. Once the database is pruned, it will stay pruned as it syncs. That is, there is no need to use --prune-blockchain again, etc.
2019-01-16Merge pull request #5029Riccardo Spagni1-1/+1
d1b3990d p2p: don't stop the idle thread when no gray peers are found (moneromooo-monero)
2019-01-16Merge pull request #5001Riccardo Spagni1-3/+4
a5ffc2d5 Remove boost::lexical_cast for uuid and unused uuid function (Lee Clagett)
2019-01-16Merge pull request #4976Riccardo Spagni1-4/+4
85665003 epee: better network buffer data structure (moneromooo-monero)
2018-12-30p2p: don't stop the idle thread when no gray peers are foundmoneromooo-monero1-1/+1
2018-12-23epee: better network buffer data structuremoneromooo-monero1-4/+4
avoids pointless allocs and memcpy
2018-12-23Remove boost::lexical_cast for uuid and unused uuid functionLee Clagett1-3/+4
2018-12-07p2p: use vector instead of list for peer listsmoneromooo-monero1-5/+5
2018-11-01p2p: tone down "no incoming connections" warning to info if in peers is 0moneromooo-monero1-3/+10
Also add an info if not offline, since it weakens the network
2018-10-26Merge pull request #4612Riccardo Spagni1-4/+8
2d48861d p2p: only deinitialize what's been initialized in offline mode (moneromooo-monero)
2018-10-16p2p: only deinitialize what's been initialized in offline modemoneromooo-monero1-4/+8
2018-10-15p2p: a negative result from UPNP_GetValidIGD is an errormoneromooo-monero1-2/+2
as per the source documentation
2018-10-13Revert "p2p: connect via the bound ip, if any"moneromooo-monero1-3/+3
This reverts commit 909398efc79cb1fa92e330e9a50a316ca5858953. It looks like it's causing trouble with tor on some setups
2018-08-15Merge pull request #4089luigi11111-3/+3
909398e p2p: connect via the bound ip, if any (moneromooo-monero)
2018-07-19Merge pull request #3854luigi11111-0/+3
149da42 db_lmdb: enable batch transactions by default (stoffu) 34cb6b4 add --regtest and --fixed-difficulty for regression testing (vicsn) 9e1403e update get_info RPC and bump RPC version (vicsn) 207b66e first new functional tests (vicsn)
2018-07-02p2p: connect via the bound ip, if anymoneromooo-monero1-3/+3
2018-06-29add --regtest and --fixed-difficulty for regression testingvictorsintnicolaas1-0/+3
on_generateblocks RPC call combines functionality from the on_getblocktemplate and on_submitblock RPC calls to allow rapid block creation. Difficulty is set permanently to 1 for regtest. Makes use of FAKECHAIN network type, but takes hard fork heights from mainchain Default reserve_size in generate_blocks RPC call is now 1. If it is 0, the following error occurs 'Failed to calculate offset for'. Queries hard fork heights info of other network types
2018-06-27Merge pull request #3982luigi11111-16/+46
08b85a8 cryptonote_config: add get_config to refactor x = testnet ? config::testnet::X : stagenet ? config::stagenet::X : config::X (stoffu) 0cf80ba net_node: resolve host for node addresses given via command line flags (stoffu)
2018-06-19Merge pull request #3861luigi11111-0/+14
de1ffe0 p2p: warn when no incoming connections are seen for a while (moneromooo-monero)
2018-06-11net_node: resolve host for node addresses given via command line flagsstoffu1-13/+43
2018-06-11cryptonote_config: add get_config to refactor x = testnet ? ↵stoffu1-3/+3
config::testnet::X : stagenet ? config::stagenet::X : config::X
2018-05-26p2p: warn when no incoming connections are seen for a whilemoneromooo-monero1-0/+14
2018-04-29p2p: fix fallback seed node usagemoneromooo-monero1-3/+10
Those were added to the seed nodes list even when they had already been added. Moreover, the current index was not reset after they were added, typically causing previous seeds to be used, and some of those fallback seeds to not be tried.
2018-04-21Build: update CMake and p2p for in-tree miniupnpanonimal1-10/+3
(cherry picked from commit a7366b5feeffaeb65b217b2d6f138e0ab1c90192)
2018-04-19CMake: update new location of in-tree miniupnpcanonimal1-3/+3
(cherry picked from commit b16a282f97d8f6c967e8a0b1ecfd75110f095182)
2018-03-22p2p: correct port number for seed nodesstoffu1-3/+3
2018-03-13p2p: fix network ID being uninitialised when using exclusive peersmoneromooo-monero1-1/+4
2018-03-05Stagenetstoffu1-11/+25
2018-02-18p2p: restore m_testnet assignment lost during rebasewhythat1-0/+1
2018-02-16options: remove testnet-* optionswhythat1-8/+2
2018-02-16Merge pull request #3196Riccardo Spagni1-1/+2
eda9fb5b p2p: fix testnet/mainnet port mixup (moneromooo-monero)
2018-02-16Merge pull request #3226Riccardo Spagni1-1/+1
e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero) 2e3e90ac pass large parameters by const ref, not value (moneromooo-monero) 61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero) 9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero) 8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero) 9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero) 24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero) f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero) c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero) fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero) 03887f11 keccak: fix sanity check bounds test (moneromooo-monero) ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero) bece67f9 miner: restore std::cout precision after modification (moneromooo-monero) 1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
2018-02-16Merge pull request #3221Riccardo Spagni1-0/+2
2e584dcb p2p: do not try to connect to peers in offline mode (moneromooo-monero)
2018-02-02pass large parameters by const ref, not valuemoneromooo-monero1-1/+1
Coverity 136394 136397 136409 136526 136529 136533 175302
2018-02-01p2p: do not try to connect to peers in offline modemoneromooo-monero1-0/+2
2018-01-29Allow the number of incoming connections to be limitedErik de Castro Lopo1-3/+54
It was already possible to limit outgoing connections. One might want to do this on home network connections with high bandwidth but low usage caps.
2018-01-29Rename delete_connections to delete_out_connectionsErik de Castro Lopo1-1/+1
This rename is needed so that delete_in_connections can be added.
2018-01-29Rename connections_count to max_out_connection_countErik de Castro Lopo1-10/+10
This is needed so that a max_in_connection_count can be added.
2018-01-28p2p: fix testnet/mainnet port mixupmoneromooo-monero1-1/+2
2018-01-27Merge pull request #3145Riccardo Spagni1-6/+6
fd1dfac5 p2p: don't lookup seed IPs if using an exclusive peer (moneromooo-monero) b50182ae p2p: don't connect to seeds if using an exclusive peer (moneromooo-monero)
2018-01-26Update 2018 copyrightxmr-eric1-1/+1
2018-01-18p2p: fix picking peers off an empty gray listmoneromooo-monero1-1/+4
2018-01-17p2p: don't lookup seed IPs if using an exclusive peermoneromooo-monero1-5/+5
2018-01-17p2p: don't connect to seeds if using an exclusive peermoneromooo-monero1-1/+1
2017-12-25Merge pull request #2928Riccardo Spagni1-2/+5
d28c388f p2p: stop net server before closing starting connections (moneromooo-monero)
2017-12-18p2p: use size_t for arbitrary counters instead of uint8_tmoneromooo-monero1-2/+2
2017-12-16cryptonote_core does not depend on p2p anymoremoneromooo-monero1-36/+1
As a followon side effect, this makes a lot of inline code included only in particular cpp files (and instanciated when necessary.
2017-12-16Merge pull request #2878Riccardo Spagni1-4/+2
abebe392 rpc: add offline state in info rpc (moneromooo-monero) 7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
2017-12-15p2p: stop net server before closing starting connectionsmoneromooo-monero1-2/+5
This fixes a hang on exit due to race where a connection adds itself to the server after the starting connections are closed, but before the net server marks itself as stopped.
2017-11-30core: make --offline also disable DNS lookupsmoneromooo-monero1-4/+2
2017-11-28Corrections in rate limiting / trottle code, especially in 'out' directionrbrunner71-12/+10
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet that were erroneous / superfluous, which enabled the elimination of a "fudge" factor of 2.1 in connection_basic::set_rate_up_limit; also ended the multiplying of limit values and numbers of bytes transferred by 1024 before handing them over to the global throttle objects
2017-11-14move cryptonote command line options to cryptonote_coremoneromooo-monero1-2/+3
Those have no reason to be in a generic module
2017-10-09Fix an object lifetime bug in net load testsmoneromooo-monero1-1/+1
The commands handler must not be destroyed before the config object, or we'll be accessing freed memory. An earlier attempt at using boost::shared_ptr to control object lifetime turned out to be very invasive, though would be a better solution in theory.
2017-10-05Upgrades to epee::net_utils::network_addressLee Clagett1-4/+4
- internal nullptr checks - prevent modifications to network_address (shallow copy issues) - automagically works with any type containing interface functions - removed fnv1a hashing - ipv4_network_address now flattened with no base class
2017-09-25Merge pull request #2428Riccardo Spagni1-0/+2
054054c9 p2p: disable gray list housekeeping when an exclusive node is given (moneromooo-monero)
2017-09-21Merge pull request #2302Riccardo Spagni1-0/+5
ef005f5e p2p: add a couple early outs when the stop signal is received (moneromooo-monero) 80d361c7 abstract_tcp_server2: improve tracking/cancelling of early connections (moneromooo-monero)
2017-09-10p2p: disable gray list housekeeping when an exclusive node is givenmoneromooo-monero1-0/+2
Exclusive nodes may be used for privacy reasons, and thus we don't want to connect to other nodes, even for checking connectivity. See https://github.com/monero-project/monero/issues/2346
2017-09-01Rename m_listenning_port to m_listening_portMaxXor1-5/+5
2017-08-29Delete UPnP port mapping on exitMaxXor1-43/+95
2017-08-23print peer id in 0 padded hex for consistencymoneromooo-monero1-6/+6
2017-08-21cryptonote_protocol: misc fixes to the new sync algorithmmoneromooo-monero1-0/+2
Fix sync wedge corner case: It could happen if a connection went into standby mode, while it was the one which had requested the next span, and that span was still waiting for the data, and that peer is not on the main chain. Other peers can then start asking for that data again and again, but never get it as only that forked peer does. And various other fixes
2017-08-16p2p: add a couple early outs when the stop signal is receivedmoneromooo-monero1-0/+5
This avoids quicker exit
2017-08-15Merge pull request #2282Riccardo Spagni1-0/+2
7fdc178a p2p: fix random peer index being too large (moneromooo-monero)
2017-08-15Merge pull request #2236Riccardo Spagni1-22/+22
cb2d5110 Tweak net logs so we get more info on why networking can't start (moneromooo-monero)
2017-08-15Tweak net logs so we get more info on why networking can't startmoneromooo-monero1-22/+22
This should prevent "silent" failures to start
2017-08-11p2p: fix random peer index being too largemoneromooo-monero1-0/+2
2017-08-09p2p: fallback on seed nodes if we can't make a connectionmoneromooo-monero1-6/+25
This avoids failing to connect to the network in case all known peers are unavailable (which can happen if the peer list is small).
2017-08-08net_node: fix m_in_timedsync initializationmoneromooo-monero1-0/+1
This fixes nodes not being able to connect to nodes which use recent code. While there, init peer_id too.
2017-08-07Merge pull request #2149Riccardo Spagni1-0/+8
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero) f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero) 90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero) 84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero) 5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
2017-08-07Merge pull request #2219Riccardo Spagni1-6/+14
04ebfbfe p2p: close connections when exiting (moneromooo-monero) 9a10148c p2p: fix thread leak (moneromooo-monero)
2017-08-07cryptonote_protocol_handler: sync speedupmoneromooo-monero1-0/+8
A block queue is now placed between block download and block processing. Blocks are now requested only from one peer (unless starved). Includes a new sync_info coommand.
2017-07-29p2p: close connections when exitingmoneromooo-monero1-0/+8
This ensures they don't leak if they were in the middle of an async operation.
2017-07-28p2p: fix thread leakmoneromooo-monero1-6/+6
2017-07-27move get_proof_of_trust_hash from util.h to p2p_protocol_defs.hmoneromooo-monero1-1/+1
This avoids having to include p2p_protocol_defs.h in util.h, as util.h is used a lot, and p2p_protocol_defs.h includes a lot of other things that most users don't need.
2017-06-28Remove typeid use in network_addressmoneromooo-monero1-8/+8
Since I had to add an ID to the derived classes anyway, this can be used instead. This removes an apparently pointless warning from CLANG too.
2017-06-24Merge pull request #2073Riccardo Spagni1-2/+6
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu) cf3a376c Don't timeout a slow operation that's making progress (Howard Chu) 340830de Fix PR#2039 (Howard Chu)
2017-06-15Don't issue a new timedsync while one is already in progressHoward Chu1-2/+6
A timedsync is issued every minute on a connection, but the input tineout is 2 minutes. This means a new sync request could be issued while a slow sync request was already in progress. The additional request will further clog the network on a slow connection, and cause a premature timeout.
2017-05-27abstracted nework addressesmoneromooo-monero1-108/+107
All code which was using ip and port now uses a new IPv4 object, subclass of a new network_address class. This will allow easy addition of I2P addresses later (and also IPv6, etc). Both old style and new style peer lists are now sent in the P2P protocol, which is inefficient but allows peers using both codebases to talk to each other. This will be removed in the future. No other subclasses than IPv4 exist yet.
2017-05-05Merge pull request #1701Riccardo Spagni1-12/+105
8277e67f Add anchor connections (Miguel Herranz)
2017-03-18p2p: use the fallback seed IPs when not enough seeds are foundmoneromooo-monero1-26/+61
In case the DNS seed(s) is/are down, which would otherwise cause the fallback seeds to never be used. Also if the seeds resolve to too few IPs.
2017-02-28Make gray peer selection uniformMiguel Herranz1-1/+8
Prevents the system from always picking the gray peers with the most recent last_seen.
2017-02-21updated fallback nodesRiccardo Spagni1-6/+12
2017-02-21update copyright year, fix occasional lack of newline at line endRiccardo Spagni1-1/+1
2017-02-21core: add p2p bind port options from net_nodemoneromooo-monero1-2/+2
They're now used by core to determine the data directory to use for the txpool directory. This fixes an assert in the core tests, which don't use the RPC server, which normally initializes the P2P code.
2017-02-10Add anchor connectionsMiguel Herranz1-12/+105
Based on https://eprint.iacr.org/2015/263.pdf 4. Anchor connections. Peer list serialisation version bumped to 5.
2017-02-02Merge pull request #1641Riccardo Spagni1-0/+5
ca94d0a4 Separate data per P2P port (Miguel Herranz)
2017-01-28Separate data per P2P portMiguel Herranz1-0/+5
poolstate.bin and p2pstate.bin are stored in .bitmonero/ if the default P2P port is being used. If another port is used both files are stored in .bitmonero/PORTNUMBER/.
2017-01-22Replace BOOST_FOREACH with C++11 ranged forMiguel Herranz1-2/+2
2017-01-22Merge pull request #1609Riccardo Spagni1-1/+10
4cdf0a35 p2p: always recreate a new peer id on startup (moneromooo-monero)
2017-01-22Merge pull request #1606Riccardo Spagni1-3/+3
f8b97aef p2p: show ban/unban logs by default again (moneromooo-monero)
2017-01-22p2p: always recreate a new peer id on startupmoneromooo-monero1-1/+10
This prevents easy fingerprinting when you change IPs, and will be a must when kovri gets used.
2017-01-21p2p: show ban/unban logs by default againmoneromooo-monero1-3/+3
2017-01-21Rename method to get_random_gray_peerMiguel Herranz1-1/+1
2017-01-21Fix logging that broke after rebasingMiguel Herranz1-1/+1
2017-01-21Use set_peer_just_seen to keep last_seen updatedMiguel Herranz1-1/+1
2017-01-21Add gray peer list housekeeping systemMiguel Herranz1-0/+71
A random peer from the gray peer list is selected and a connection is made to check if the peer is alive. If the connection and handshake are successful the peer is promoted to the white peer list, in case of failure the peer is evicted from the gray peer list. The connection is closed after the check in either case.
2017-01-20Merge pull request #1572Riccardo Spagni1-0/+30
0e0e6c5f Reduce to one connection per IP (Miguel Herranz) 3f269e98 Limit incoming connections from the same IP (Miguel Herranz)
2017-01-16Reduce to one connection per IPMiguel Herranz1-1/+1
2017-01-16Change logging to easylogging++moneromooo-monero1-83/+80
This replaces the epee and data_loggers logging systems with a single one, and also adds filename:line and explicit severity levels. Categories may be defined, and logging severity set by category (or set of categories). epee style 0-4 log level maps to a sensible severity configuration. Log files now also rotate when reaching 100 MB. To select which logs to output, use the MONERO_LOGS environment variable, with a comma separated list of categories (globs are supported), with their requested severity level after a colon. If a log matches more than one such setting, the last one in the configuration string applies. A few examples: This one is (mostly) silent, only outputting fatal errors: MONERO_LOGS=*:FATAL This one is very verbose: MONERO_LOGS=*:TRACE This one is totally silent (logwise): MONERO_LOGS="" This one outputs all errors and warnings, except for the "verify" category, which prints just fatal errors (the verify category is used for logs about incoming transactions and blocks, and it is expected that some/many will fail to verify, hence we don't want the spam): MONERO_LOGS=*:WARNING,verify:FATAL Log levels are, in decreasing order of priority: FATAL, ERROR, WARNING, INFO, DEBUG, TRACE Subcategories may be added using prefixes and globs. This example will output net.p2p logs at the TRACE level, but all other net* logs only at INFO: MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE Logs which are intended for the user (which Monero was using a lot through epee, but really isn't a nice way to go things) should use the "global" category. There are a few helper macros for using this category, eg: MGINFO("this shows up by default") or MGINFO_RED("this is red"), to try to keep a similar look and feel for now. Existing epee log macros still exist, and map to the new log levels, but since they're used as a "user facing" UI element as much as a logging system, they often don't map well to log severities (ie, a log level 0 log may be an error, or may be something we want the user to see, such as an important info). In those cases, I tried to use the new macros. In other cases, I left the existing macros in. When modifying logs, it is probably best to switch to the new macros with explicit levels. The --log-level options and set_log commands now also accept category settings, in addition to the epee style log levels.
2017-01-15Limit incoming connections from the same IPMiguel Herranz1-0/+30
2016-12-20also use portable serializer for boost_serialization_helper.h and ↵kenshi841-6/+26
net_node.inl, completely adandon boost/archive/binary_oarchive.hpp
2016-12-04Merge pull request #1398Riccardo Spagni1-4/+4
f4772bae Fix a few minor typos (Pierre Boyer)
2016-12-04Merge pull request #1397Riccardo Spagni1-0/+1
3f7d6fb5 Fix delayed exit when syncing (moneromooo-monero)
2016-12-04Merge pull request #1396Riccardo Spagni1-4/+6
7c0dd5e4 net_node: drop connections from banned IPs after looping through connections (moneromooo-monero)
2016-12-04Fix a few minor typosPierre Boyer1-4/+4
2016-12-04Fix delayed exit when syncingmoneromooo-monero1-0/+1
2016-12-03net_node: drop connections from banned IPs after looping through connectionsmoneromooo-monero1-4/+6
This keeps the connections lock just for the time of looping and adding connectoins to a list, and the dropping happens after it. This should avoid lengthy delays waiting for the connections lock.
2016-12-01p2p: possibly fix crash in relay_blocksmoneromooo-monero1-6/+11
2016-11-23Fix DNS failures in offline mode preventing daemon startupmoneromooo-monero1-1/+1
2016-11-09add lightweight block propagation ("fluffy blocks")Dion Ahmetaj1-3/+49
Added a new command to the P2P protocol definitions to allow querying for support flags. Implemented handling of new support flags command in net_node. Changed for_each callback template to include support flags. Updated print_connections command to show peer support flags. Added p2p constant for signaling fluffy block support. Added get_pool_transaction function to cryptnote_core. Added new commands to cryptonote protocol for relaying fluffy blocks. Implemented handling of fluffy block command in cryptonote protocol. Enabled fluffy block support in node initial configuration. Implemented get_testnet function in cryptonote_core. Made it so that fluffy blocks only run on testnet.
2016-10-02p2p: drop any existing connection to a banned IPmoneromooo-monero1-0/+12
2016-09-18remove dead backup seed nodes, add new onesRiccardo Spagni1-24/+6
2016-07-03allow peers without portmoneromooo-monero1-0/+5
The default port is then used
2016-04-17net_node: fix connection leak when ping fails with bad responsemoneromooo-monero1-0/+1
If there is no comms error, but the response is not as expected, close would not be called.
2016-03-11Use boost::thread instead of std::threadHoward Chu1-1/+1
and all other associated IPC
2016-02-18Use boost::thread instead of std::threadHoward Chu1-1/+1
std::thread crashes on (at least) ARMv6 g++ 4.8/4.9
2016-01-14'max limit of...' is redundant wording, rephrasebinaryFate1-1/+1
2015-12-31updated copyright yearRiccardo Spagni1-1/+1
2015-12-22net_node: fix a hang on exitmoneromooo-monero1-1/+1
One loop was not paying attention to the stop signal, and could end up looping forever
2015-12-19Add missing semicolons after log statementsmoneromooo-monero1-1/+1
2015-12-18Merge pull request #543Riccardo Spagni1-1/+1
63cb1a5 move another non user useful log to L1 (moneromooo-monero) 02827d5 p2p: minor log formatting fix (moneromooo-monero)
2015-12-17p2p: minor log formatting fixmoneromooo-monero1-1/+1
2015-12-15Replace tabs with two spaces for consistency with rest of codebasewarptangent1-203/+203
Remove trailing whitespace in same files.
2015-12-09Merge pull request #527Riccardo Spagni1-2/+1
336b375 Register daemon command line arguments to core if they're used in core (moneromooo-monero)
2015-12-08Register daemon command line arguments to core if they're used in coremoneromooo-monero1-2/+1
This fixes coretests, which does not register daemon specific arguments, but uses core, which uses those arguments. Also gets rid of an unwanted dependency on daemon code from core.
2015-12-08Merge pull request #526Riccardo Spagni1-0/+10
2c83055 net_node: add a --offline argument (moneromooo-monero)
2015-12-07net_node: add a --offline argumentmoneromooo-monero1-0/+10
It will not try to connect to the monero network, nor listen
2015-12-07p2p: failure to load p2pstate.bin is not fatal anymoremoneromooo-monero1-2/+11
Clear any partially loaded data, and start with a default config
2015-11-26add RPC calls and commands to get/set bansmoneromooo-monero1-1/+13
2015-11-25net_node: allow bans for custom amounts of timemoneromooo-monero1-3/+3
m_blocked_ips now stores the unblocking time, rather than the blocking time. Also change > to >=, since banning for 0 seconds should not ban
2015-11-23Add IP blocking for misbehaving nodes (adapted from Boolberry)Javier Smooth1-0/+68
With minor cleanup and fixes (spelling, indent) by moneromooo
2015-11-23quiet down p2p logging a bitJavier Smooth1-1/+1
2015-10-05Update to compile with latest miniupnpcwarptangent1-0/+6
upnpDiscover() takes a new argument for TTL. Use the suggested default of 2.