Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
0f7b20a Added support for Ledger Nano S Plus (Mathias Herberts)
|
|
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
|
|
|
|
|
|
The current code does work by accident, but it might break if
someone uses ASSERT_SW in a different place, or if variables
get renamed.
|
|
|
|
d52d21b ledger: don't lock for software device (tobtoht)
|
|
|
|
|
|
|
|
The scalar z has not been generated on the HW thus it can't be sent
encrypted. The value is derived from the exported private view key.
|
|
|
|
|
|
They are allowed from v12, and MLSAGs are rejected from v13.
|
|
267ce5b71 avoid a couple needless copies (moneromooo-monero)
|
|
72cdfa4a2 fix a few typos in error messages (moneromooo-monero)
|
|
5ef0607da Update copyright year to 2020 (SomaticFanatic)
|
|
|
|
buffer_send[4] (LC) is an unsigned char, len should not
exceed 254 (255 - 1 for the option).
|
|
Reported by adrelanos
|
|
Update copyright year to 2020
|
|
688a3e8 Add timelock verification on device (cslashm)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
26f7a26 device: fix ledger requesting secret keys export twice (xiphon)
|
|
Coverity 200183
|
|
|
|
GCC wants operator= aand copy ctor to be both defined, or neither
|
|
|
|
Enhance debug info
|
|
New scheme key destination contrfol
Fix dummy decryption in debug mode
|
|
|
|
|
|
|
|
|
|
|
|
Implies protocol version management.
|
|
6c060e6a device: proper handling of user input (selsta)
|
|
93c21644 device_ledger: remove full_name variable (selsta)
|
|
Found by knaccc
|
|
(1) If the user denies something on the Ledger,
a proper error message is now shown.
(2) Ledger doesn't time out anymore while waiting
on user input.
(3) Lower the timeout to 2 seconds, this is enough for
normal Ledger <-> System communication.
|
|
This variable was never set, resulting in the
device name always showing as "disconnected".
|
|
Found by codacy.com
|
|
|
|
|
|
|
|
|
|
Remove PCSC dependencies which is a bit hard (not user friendly) to install on linux and Mac
Split Ledger logic and device IO
|
|
|
|
Also constrains bulletproofs to simple rct, for simplicity
|
|
|
|
|
|
87e158b device_ledger: factor the prologue code (moneromooo-monero)
|
|
34de7bc2 device_ledger: fix buffer underflow on bad data from device (moneromooo-monero)
41e9cab4 device: misc cleanup (moneromooo-monero)
3b4dec2d device_ledger: fix potential buffer overflow from bad size calc (moneromooo-monero)
|
|
0309615 device_ledger: fix bad memory access on connect error (moneromooo-monero)
|
|
|
|
|
|
use snprintf "just in case" where appropriate
consistently use unsigned for temp values
pass std::string by const ref rather than by value
add length check (which can't happen in practice) for memcpy
|
|
|
|
|
|
PR3843 based on release-v0.12 => rebased on master
|
|
When additional keys was needed, the TX scan failed because the
derivation data was always recomputed with the main tx_key and not
the corresponding additional one.
Moreover this patch avoid perf decreasing when not using HW device.
|
|
On client startup the device asks for authorization to export the private view key.
If user agree, the client hold the private view key allowing a fast blockchain scan.
If the user does not agree, the blockchain scan is fully done via the device.
|
|
Additional cosmetic fixes:
move 'name' as protected
remove unnecessary local var
Fix debug log
|
|
hash: add prehashed version cn_slow_hash_prehashed
slow-hash: let cn_slow_hash take 4th parameter for deciding prehashed or not
slow-hash: add support for prehashed version for the other 3 platforms
|
|
When #3303 was merged, a cyclic dependency chain was generated:
libdevice <- libcncrypto <- libringct <- libdevice
This was because libdevice needs access to a set of basic crypto operations
implemented in libringct such as scalarmultBase(), while libringct also needs
access to abstracted crypto operations implemented in libdevice such as
ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct
into libringct_basic and libringct, where the basic crypto ops previously in
libringct are moved into libringct_basic. The cyclic dependency is now resolved
thanks to this separation:
libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct
This eliminates the need for crypto_device.cpp and rctOps_device.cpp.
Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and
get_subaddress_secret_key() were previously implemented in libcryptonote_basic
(cryptonote_format_utils.cpp) and were then called from hw::core::device_default,
which is odd because libdevice is supposed to be independent of libcryptonote_basic.
Therefore, those functions were moved to device_default.cpp.
|
|
|
|
Fix the way the REAL mode is handle:
Let create_transactions_2 and create_transactions_from construct the vector of transactions.
Then iterate on it and resign.
We just need to add 'outs' list in the TX struct for that.
Fix default secret keys value when DEBUG_HWDEVICE mode is off
The magic value (00...00 for view key and FF..FF for spend key) was not correctly set
when DEBUG_HWDEVICE was off. Both was set to 00...00.
Add sub-address info in ABP map in order to correctly display destination sub-address on device
Fix DEBUG_HWDEVICE mode:
- Fix compilation errors.
- Fix control device init in ledger device.
- Add more log.
Fix sub addr control
Fix debug Info
|
|
This is the first variant of many, with the intent to improve
Monero's resistance to ASICs and encourage mining decentralization.
|
|
|
|
The basic approach it to delegate all sensitive data (master key, secret
ephemeral key, key derivation, ....) and related operations to the device.
As device has low memory, it does not keep itself the values
(except for view/spend keys) but once computed there are encrypted (with AES
are equivalent) and return back to monero-wallet-cli. When they need to be
manipulated by the device, they are decrypted on receive.
Moreover, using the client for storing the value in encrypted form limits
the modification in the client code. Those values are transfered from one
C-structure to another one as previously.
The code modification has been done with the wishes to be open to any
other hardware wallet. To achieve that a C++ class hw::Device has been
introduced. Two initial implementations are provided: the "default", which
remaps all calls to initial Monero code, and the "Ledger", which delegates
all calls to Ledger device.
|