aboutsummaryrefslogtreecommitdiff
path: root/src/cryptonote_core (unfollow)
AgeCommit message (Collapse)AuthorFilesLines
2023-10-16gcc: fix uninitialized constructor warningsjeff3-3/+7
2023-10-01Fix: long term block weight cacheBoog9001-33/+2
The long term block weight cache was doing a wrong calculation when adding a new block to the cache.
2023-07-01blockchain_and_pool: move to crytonote_core and enforce its usagejeffro2565-21/+83
2023-05-12daemon: remove --fluffy-blockstobtoht1-9/+0
2023-05-11blockchain: ensure base fee cannot reach 0Crypto City1-1/+1
reported by sech1
2023-05-05core: do not force sync the db when finding a block in regtest modeCrypto City1-1/+2
for a slight performance boost in functional tests
2023-05-05bump lmdb sync threshold for performancemoneromooo-monero1-0/+4
Force sync every 100k blocks instead of every 1k blocks. Bumping this value is reported to make a big difference in sync performance, eg: https://github.com/monero-project/monero/issues/8189
2023-03-29cryptonote core/protocol: don't drop peers for soft offensesjeffro2562-1/+3
Also: txs with tx_extra which is too large will not get published to ZMQ Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
2023-03-17verRctNonSemanticsSimpleCached: fix fragilityJeffrey Ryan5-73/+279
2023-03-07Enforce restricted # pool txs served via RPC + optimize chunked reqsj-berman5-37/+74
- `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when returning pool txs via a restricted RPC daemon. - A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs in the `added_pool_txs` field, and returns any remaining pool hashes in the `remaining_added_pool_txids` field. The client then requests the remaining txs via `/gettransactions` in chunks. - `/gettransactions` no longer does expensive no-ops for ALL pool txs if the client requests a subset of pool txs. Instead it searches for the txs the client explicitly requests. - Reset `m_pool_info_query_time` when a user: (1) rescans the chain (so the wallet re-requests the whole pool) (2) changes the daemon their wallets points to (a new daemon would have a different view of the pool) - `/getblocks.bin` respects the `req.prune` field when returning pool txs. - Pool extension fields in response to `/getblocks.bin` are optional with default 0'd values.
2023-02-26Add a size limit for tx_extra in tx pooltevador2-0/+11
2023-01-16Copyright: Update to 2023mj-xmr13-13/+13
Co-authored-by: plowsof <plowsof@protonmail.com> extra files
2023-01-09Refactored rx-slow-hash.cSChernykh4-43/+41
- Straight-forward call interface: `void rx_slow_hash(const char *seedhash, const void *data, size_t length, char *result_hash)` - Consensus chain seed hash is now updated by calling `rx_set_main_seedhash` whenever a block is added/removed or a reorg happens - `rx_slow_hash` will compute correct hash no matter if `rx_set_main_seedhash` was called or not (the only difference is performance) - New environment variable `MONERO_RANDOMX_FULL_MEM` to force use the full dataset for PoW verification (faster block verification) - When dataset is used for PoW verification, dataset updates don't stall other threads (verification is done in light mode then) - When mining is running, PoW checks now also use dataset for faster verification
2022-12-30wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 callrbrunner74-19/+258
2022-12-22common: move boost_serialization_helper.h out and cleanup includesJeffrey Ryan2-2/+0
2022-12-20Cache successful `verRctNonSemanticsSimple` callsSChernykh1-1/+1
2022-09-22Move update_checkpoints() to a later stageSChernykh1-4/+0
update_checkpoints() makes a few DNS requests and can take up to 20-30 seconds to complete (3-6 seconds on average). It is currently called from core::handle_incoming_block() which holds m_incoming_tx_lock, so it blocks all incoming transactions and blocks processing while update_checkpoints() is running. This PR moves it to until after a new block has been processed and relayed, to avoid full monerod locking.
2022-09-20Second thread pool for IOSChernykh2-3/+3
2022-09-12wallet2: check wallet compatibility with daemon's hard fork versionj-berman1-0/+7
2022-09-06rpc: skip bootstrap nodes that are lower than last checkpointselsta3-0/+18
2022-08-19blockchain: fix invalid memory read getting fee on empty chainCrypto City1-1/+1
2022-07-26Fixed get_block_template_backlog performanceSChernykh2-17/+56
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load. After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
2022-07-21Publish submitted txs via zmqj-berman4-5/+67
2022-07-13build: prepare v0.18.0.0selsta1-1/+1
2022-07-01continue pool pruning even if a tx can't be foundj-berman2-5/+31
2022-06-30multisig: fix critical vulnerabilities in signinganon3-21/+11
2022-05-12fix backoff delay logic when re-relaying txsj-berman1-4/+4
2022-04-18Bump ring size to 16 for v15 & remove set default in wallet clij-berman1-9/+15
2022-04-18Add view tags to outputs to reduce wallet scanning timej-berman5-32/+62
Implements view tags as proposed by @UkoeHB in MRL issue https://github.com/monero-project/research-lab/issues/73 At tx construction, the sender adds a 1-byte view tag to each output. The view tag is derived from the sender-receiver shared secret. When scanning for outputs, the receiver can check the view tag for a match, in order to reduce scanning time. When the view tag does not match, the wallet avoids the more expensive EC operations when deriving the output public key using the shared secret.
2022-04-10Fee changes from ArticMinemoneromooo-monero2-7/+146
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf with a change to use 1.7 instead of 2.0 for the max long term increase rate
2022-04-06CMake: Add missing headers via monero_find_all_headers macromj-xmr1-7/+1
2022-04-05plug bulletproofs plus into consensusmoneromooo-monero2-5/+53
2022-03-10Remove footgun doc comment in miner TX validationLuke Parker1-3/+0
This comment suggests this check is unnecessary, when it is completely necessary as miner TXs can have multiple outputs *which is a statement directly, and incorrectly, contradicted by this comment*. While I don't ever see someone removing this code and getting their edits merged into Monero, someone inexperienced who thinks they're cleaning old code may break their own work, and then there's really just zero benefit to keeping this around.
2022-03-04Compil. time: cryptonote_core minus portable_storage headermj-xmr1-1/+0
2022-03-04Copyright: Update to 2022mj-xmr13-13/+13
2022-02-22multisig key exchange update and refactorkoe1-1/+0
2021-11-20Add calcpow RPCHoward Chu2-4/+11
Calculate PoW hash for a block candidate
2021-11-16cryptonote_core: fix unused lambda warningselsta1-1/+1
2021-11-01tx_pool: full tx revalidation on fork boundariesmoneromooo-monero2-45/+64
avoids mining txes after a fork that are invalid by this fork's rules, but were valid by the previous fork rules at the time they were verified and added to the txpool.
2021-10-11blockchain: fix pedantic assertselsta1-0/+2
2021-09-11RPC and ZeroMQ APIs to support p2poolSChernykh7-9/+174
Adds the following: - "get_miner_data" to RPC API - "json-miner-data" to ZeroMQ subscriber contexts Both provide the necessary data to create a custom block template. They are used by p2pool. Data provided: - major fork version - current height - previous block id - RandomX seed hash - network difficulty - median block weight - coins mined by the network so far - mineable mempool transactions
2021-08-20daemon: allow proxy configurationanon2-3/+6
Co-authored-by: selsta <selsta@sent.at> Co-authored-by: tobtoht <thotbot@protonmail.com>
2021-06-20doc: update IRC references to Liberafdov1-1/+1
2021-05-08Warnings: unused variable in core/blockchain.cppmj-xmr1-1/+1
2021-05-02Warnings: unused var at cryptonote_tx_utils.cppmj-xmr1-1/+3
2021-04-26blockchain: speed up repeated pops (mostly in tests)moneromooo-monero1-1/+4
The heavy rolling median reset only has to be performed after all blocks are popped
2021-04-16Revert "Merge pull request #7136"luigi11111-1/+0
This reverts commit 63c7ca07fba2f063c760f786a986fb3e02fb040e, reversing changes made to 2218e23e84a89e9a1e4c0be5d50f891ab836754f.
2021-03-28Reduce compilation time of epee/portable_storage_template_helper.hmj-xmr1-0/+2
2021-03-18core: speed up print_coinbase_tx_summoneromooo-monero4-12/+14
It only needs to parse the tx headers, not the full tx data
2021-03-05fix serialization being different on macmoneromooo-monero1-2/+2
On Mac, size_t is a distinct type from uint64_t, and some types (in wallet cache as well as cold/hot wallet transfer data) use pairs/containers with size_t as fields. Mac would save those as full size, while other platforms would save them as varints. Might apply to other platforms where the types are distinct. There's a nasty hack for backward compatibility, which can go after a couple forks.
2021-02-09Remove unused variables in monero codebaseKevin Barbour2-3/+0
There are quite a few variables in the code that are no longer (or perhaps never were) in use. These were discovered by enabling compiler warnings for unused variables and cleaning them up. In most cases where the unused variables were the result of a function call the call was left but the variable assignment removed, unless it was obvious that it was a simple getter with no side effects.
2021-01-28Remove copies from foreach loops (thanks to Clang)Lee Clagett2-2/+2
2021-01-19Remove payload copy in all outgoing p2p messagesLee Clagett1-0/+1
2021-01-16Remove payload copy in all outgoing p2p messagesLee Clagett1-0/+1
2021-01-02blockchain: lock access to m_blocks_hash_of_hashesmoneromooo-monero1-0/+2
it is accessed both when adding and when prevalidating a set of new hashes from a peer
2020-12-31protocol: more sanity checks in new chain block hashesmoneromooo-monero4-6/+28
2020-12-29rpc: limit the number of txes for get_blocks.binmoneromooo-monero4-8/+9
2020-11-25cryptonote_core: dandelion - use local height or median height if syncingxiphon3-3/+16
2020-11-17Change Dandelion++ fluff probability to 20%, and embargo timeout to 39sLee Clagett1-2/+2
A 20% fluff probability increases the precision of a spy connected to every node by 10% on average, compared to a network using 0% fluff probability. The current value (10% fluff) should increase precision by ~5% compared to baseline. This decreases the expected stem length from 10 to 5. The embargo timeout was therefore lowered to 39s; the fifth node in a stem is expected to have a 90% chance of being the first to timeout, which is the same probability we currently have with an expected stem length of 10 nodes.
2020-11-15Fix timeout checks for forwarded and Dandelion++ stem txesLee Clagett4-9/+46
2020-10-20blockchain: remove some dead codemoneromooo-monero1-8/+0
This is already done
2020-10-20Make Blockchain::get_fee_quantization_mask() compile timeSChernykh2-14/+5
This also removes potential thread safety bug in that function.
2020-10-19cryptonote_core: Fix missing override warningsNathan Dorfman1-2/+2
2020-10-18blockchain: fix sync at v14 boundarymoneromooo-monero1-3/+15
Miners with MLSAG txes which they'd already verified included a couple in that block, but the consensus rules had changed in the meantime, so that block is technically invalid and any node which did not already have those two txes in their txpool could not sync. Grandfather them in, since it has no effect in practice.
2020-10-12tx_pool: silence spammy harmless warning till we fix the bugmoneromooo-monero1-1/+4
2020-10-12Dandelion++: skip desynced peers in stem phasexiphon2-1/+2
2020-09-15blockchain: deterministic UNIX time unlock checksmoneromooo-monero2-28/+64
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-14build: prepare v0.17selsta1-1/+1
2020-09-07blockchain: fix pow skipping for old blocks without precalc hashmoneromooo-monero1-1/+1
2020-09-01threadpool: guard against exceptions in jobs, and armour platingmoneromooo-monero2-10/+14
Those would, if uncaught, exit run and leave the waiter to wait indefinitely for the number of active jobs to reach 0
2020-08-27functional_tests: add a large (many randomx epochs) p2p reorg testmoneromooo-monero1-4/+35
2020-08-27core: fix mining from a block that's not the current topmoneromooo-monero6-22/+66
2020-08-27Integrate CLSAGs into moneromoneromooo-monero2-4/+55
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-21enforce claiming maximum coinbase amountmoneromooo-monero1-2/+2
Claiming a slightly lesser amount does not yield the size gains that were seen pre rct, so this closes a fingerprinting vector
2020-08-17Avoid some temporary strings when reading off the databasemoneromooo-monero3-17/+17
2020-08-16Fix build with Boost 1.74moneromooo-monero1-0/+3
Thanks iDunk for testing
2020-07-30blockchain: guard against exceptions in add_new_block/childrenmoneromooo-monero1-0/+11
Reporter requested credit to be given to Decred
2020-07-24Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' commandrbrunner71-3/+2
2020-07-09tx_pool: mine stem txes in fake chain modemoneromooo-monero3-6/+14
This fixes the functional tests, since txes would not be mined after being sent to the daemon (they'd be waiting for the dandelion timeout first)
2020-07-08blockchain: fix timestamp/difficulty cache getting out of syncmoneromooo-monero2-1/+17
The cache is discarded when a block is popped, but then gets rebuilt when the difficulty for next block is requested. While this is all properly locked, it does not take into account the delay caused by a database transaction being only committed (and thus its effects made visible to other threads) later on, which means another thread could request difficulty between the pop and the commit, which would end up using stale database view to build the cache, but that cache would not be invalidated again when the transaction gets committed, which would cause the cache to not match the new database data. To fix this, we now keep track of when the cache is invalidated so we can invalidate it again upon database transaction commit to ensure it gets calculated again with fresh data next time it is nedeed.
2020-06-14avoid a couple needless copiesmoneromooo-monero1-1/+1
2020-06-12Fix D++ block template checkLee Clagett1-1/+1
2020-06-09daemon: guard against rare 'difficulty drift' bug with checkpoints and ↵stoffu4-0/+146
recalculation On startup, it checks against the difficulty checkpoints, and if any mismatch is found, recalculates all the blocks with wrong difficulties. Additionally, once a week it recalculates difficulties of blocks after the last difficulty checkpoint.
2020-06-05blockchain: fix total_height in getblocks.bin responsemoneromooo-monero1-0/+1
2020-05-19cryptonote_core: remove "We are most likely forked" messagemoneromooo-monero2-36/+0
It's time based and we don't have forks every 6 months anymore
2020-05-17blockchain: detect and log bad difficulty calculationsmoneromooo-monero1-5/+72
2020-05-15Add randomized delay when forwarding txes from i2p/tor -> ipv4/6Lee Clagett2-10/+54
2020-05-13build: prepare v0.16.0.0 releaseselsta1-1/+1
2020-05-13blockchain: fix theoretical race getting bulk timestampsmoneromooo-monero1-0/+1
2020-05-06Update copyright year to 2020SomaticFanatic13-13/+13
Update copyright year to 2020
2020-05-06cryptonote_core: take out the time based upgrade warningmoneromooo-monero1-2/+0
It doesn't really work anymore since we don't have a fork soon
2020-05-04Adding ZMQ/Pub support for txpool_add and chain_main eventsLee Clagett4-16/+77
2020-04-29txpool.cpp: rename var to fix for old g++ version (xenial default)Sumo Gr1-2/+2
2020-04-24Used legacy category to match insert_key_images behaviorLee Clagett1-1/+1
2020-04-22cryptonote: fix reuse of non default tx data when relayingmoneromooo-monero1-1/+1
An automatic tx variable is initialized properly on the first run through the loop, but not the second. Moving the variable inside the loop ensures the ctor is called again to init it.
2020-04-20cryptonote_core: skip dns checkpoints on startup if not enforcedxiphon2-4/+5
2020-04-08Add timelock verification on devicecslashm1-1/+1
2020-03-30Always reject duplicate key-images from second txidLee Clagett2-12/+16
2020-03-30Allow unrestricted rpc calls to get full txpool infoLee Clagett2-6/+8
2020-03-26Adding Dandelion++ support to public networks:Lee Clagett2-32/+88
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode - Stem loops detected in tx_pool.cpp - Embargo timeout for a blackhole attack during stem phase
2020-03-22protocol: request txpool contents when syncedmoneromooo-monero4-0/+53
A newly synced Alice sends a (typically quite small) list of txids in the local tpxool to a random peer Bob, who then uses the existing tx relay system to send Alice any tx in his txpool which is not in the list Alice sent
2020-03-20p2p: remove old debug commandsAaron Hook2-21/+0
2020-03-14Correct key image check in tx_poolLee Clagett1-16/+7
2020-03-12core: move the LockedTXN class out of txpool so it may be reusedmoneromooo-monero1-30/+12
for example, in the RPC server
2020-02-27blockchain_db: faster fetching of consecutive txesmoneromooo-monero1-30/+2
Useful for wallet refresh or node sync
2020-02-19cryptonote_core: skip block notify on blockchain switching rollbackxiphon2-10/+20
2020-02-17remove empty statementsInterchained2-3/+3
Cleaning up a little around the code base.
2020-02-12tx_pool: catch theoretical error in get_block_rewardmoneromooo-monero1-1/+5
Coverity 196626
2020-02-10core: mention time being off in hash rate changes messagemoneromooo-monero1-1/+1
2020-01-14wallet: reroll fake outs selection on local tx_sanity_check failurexiphon2-9/+13
2020-01-09Fix check_fee() discrepancy.UkoeHB1-2/+2
M100 = max{300kb, min{100block_median, m_long_term_effective_median_block_weight}} not M100 = max{300kb, m_long_term_effective_median_block_weight} Fix base reward in get_dynamic_base_fee_estimate(). get_dynamic_base_fee_estimate() should match check_fee() Fee is calculated based on block reward, and the reward penalty takes into account 0.5*max_block_weight (both before and after HF_VERSION_EFFECTIVE_SHORT_TERM_MEDIAN_IN_PENALTY). Moved median calculation according to best practice of 'keep definitions close to where they are used'.
2019-12-14blockchain: fix flushing txes from the txpoolmoneromooo-monero1-1/+1
2019-12-12print_coinbase_tx_sum now supports 128 bits sumsmoneromooo-monero2-5/+5
The tail emission will bring the total above 64 bits
2019-12-02rpc: add bad-blocks to flush_cache RPCmoneromooo-monero4-0/+21
Flushes m_invalid_blocks in Blockchain.
2019-11-15blockchain: speedup fetching pruned contiguous tx blobsmoneromooo-monero1-3/+10
About twice as fast, very roughly
2019-11-13simplewallet: noob-friendly help menuwowario1-2/+3
2019-11-12blockchain: error out if the builtin hashes data size is wrongmoneromooo-monero1-1/+6
2019-11-04Change to Tx diffusion (Dandelion++ fluff) instead of floodingLee Clagett2-18/+2
2019-11-02Adding support for hidden (anonymity) txpoolLee Clagett7-205/+334
2019-11-02Merge pull request #6079Riccardo Spagni1-1/+1
e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
2019-11-020.15.0.0 release engineeringRiccardo Spagni1-1/+1
2019-11-01Add a --keep-fakechain option to keep fakechain databasesJamesWrigley1-1/+8
This is handy when doing tests that generate a lot of transactions, since that takes time it's preferable to re-use the database for future runs.
2019-10-31cryptonote: untangle dependency from miner to blockchainmoneromooo-monero2-2/+6
It causes link errors at least on mac
2019-10-31cryptonote: untangle dependency from miner to blockchainmoneromooo-monero2-2/+6
It causes link errors at least on mac
2019-10-29blockchain: fix comment wrongly refering to SHA-3 rather than Keccakmoneromooo-monero1-1/+1
2019-10-29tx_pool: fix error message assuming incorrectlymoneromooo-monero1-2/+2
2019-10-28core: point out when we hit the block rate visibility limitmoneromooo-monero1-2/+3
2019-10-27blockchain: fix unwanted error when probing the pool for a txmoneromooo-monero1-2/+11
2019-10-27blockchain: fix unwanted error when probing the pool for a txmoneromooo-monero1-2/+11
2019-10-25rpc: add a flush_cache RPCmoneromooo-monero2-0/+13
This allows flushing internal caches (for now, the bad tx cache, which will allow debugging a stuck monerod after it has failed to verify a transaction in a block, since it would otherwise not try again, making subsequent log changes pointless)
2019-10-25tx_pool: fix divide by 0 in logmoneromooo-monero1-1/+1
Coverity 205394
2019-10-21Support median block size > 4 GBmoneromooo-monero1-8/+3
add a 128/64 division routine so we can use a > 32 bit median block size in calculations
2019-10-16blockchain: initialize pow to ff..ffmoneromooo-monero1-2/+4
as a safety to reject if it somehow does not get initialised
2019-10-11blockchain: use effective median block weight for penalty from v12moneromooo-monero1-3/+12
It was using the raw block weight median, which was not what was intended in ArticMine's design
2019-10-11tx_pool: do not divide by 0moneromooo-monero1-2/+2
In case of a 0 tx weight, we use a placeholder value to insert in the fee-per-byte set. This is used for pruning and mining, and those txes are pruned, so will not be too large, nor added to the block template if mining, so this is safe. CID 204465
2019-10-11cryptonote: don't leave block_weight uninitializedmoneromooo-monero1-0/+1
CID 204467
2019-10-10blockchain: fill in cumulative block weight for alt blocksmoneromooo-monero3-0/+86
2019-10-10cryptonote: fill in tx weight when syncing from pruned blocksmoneromooo-monero1-5/+1
2019-10-06tx_pool: make spent return-by-reference as intendedstoffu2-2/+2
2019-10-03Add hmac over encrypted value during transactioncslashm1-15/+19
2019-09-28blockchain: tweak fee as a function of median valuesmoneromooo-monero1-1/+2
Use the lesser of the short and long terms medians, rather then the long term median alone From ArticMine: I found a bug in the new fee calculation formula with using only the long term median It actually needs to be the lesser of the long term median and the old (modified short term median) short term median with the last 10 blocks calculated as empty Yes the issue occurs if there is a large long term median and, the short term median then falls and tries to then rise again The fees are could be not high enough for example LTM and STM rise to say 2000000 bytes STM falls back to 300000 bytes Fees are now based on 2000000 bytes until LTM also falls So the STM is could prevented from rising back up STM short term median LTM long term median
2019-09-27monerod can now sync from pruned blocksmoneromooo-monero6-89/+314
If the peer (whether pruned or not itself) supports sending pruned blocks to syncing nodes, the pruned version will be sent along with the hash of the pruned data and the block weight. The original tx hashes can be reconstructed from the pruned txes and theur prunable data hash. Those hashes and the block weights are hashes and checked against the set of precompiled hashes, ensuring the data we received is the original data. It is currently not possible to use this system when not using the set of precompiled hashes, since block weights can not otherwise be checked for validity. This is off by default for now, and is enabled by --sync-pruned-blocks
2019-09-25RandomX integrationHoward Chu5-6/+119
Support RandomX PoW algorithm
2019-09-25ban peers sending bad pow outrightmoneromooo-monero1-0/+2
PoW is expensive to verify, so be strict
2019-09-19core: move hardforks into its own libmoneromooo-monero4-133/+7
So it can be used by others without encumbrance
2019-09-17blockchain: enforce 10 block age for spending outputsmoneromooo-monero1-0/+10
Some custom wallet code apparently ignores this, which causes users of that code to be fingerprinted
2019-09-16Properly format multiline logsmoneromooo-monero1-1/+1
As a side effect, colouring on Windows should now work regardless of version
2019-09-16Removed Berkeley DB and db switching logicJesus Ramirez2-5/+4
2019-09-11blockchain: keep block template timestamp not below recent medianmoneromooo-monero1-1/+3
Such a template would yield an invalid block, though would require an attacker to have mined a long blockchain with drifting times (assuming the miner's clock is roughly correct) Fixed by crCr62U0
2019-09-02Changed the use of boost:value_initialized for C++ list initializerJesus Ramirez3-13/+13
2019-08-28blockchain: fix logging bad number of blocks if first one failsmoneromooo-monero1-2/+3
2019-08-28Fix bug in mempool get_transaction_stats histogram calculationTom Smeding1-3/+10
The 98th percentile position in the agebytes map was incorrectly calculated: it assumed the transactions in the mempool all have unique timestamps at second-granularity. This commit fixes this by correctly finding the right cumulative number of transactions in the map suffix. This bug could lead to an out-of-bounds write in the rare case that all transactions in the mempool were received (and added to the mempool) at a rate of at least 50 transactions per second. (More specifically, the number of *unique* receive_time values, which have second- granularity, must be at most 2% of the number of transactions in the mempool for this crash to trigger.) If this condition is satisfied, 'it' points to *before* the agebytes map, 'delta' gets a nonsense value, and the value of 'i' in the first stats.histo-filling loop will be out of bounds of stats.histo.
2019-08-26core: make the "update probably needed soon" message less scarymoneromooo-monero1-4/+4
2019-08-19blockchain: reject rct signatures in coinbase txes from v12moneromooo-monero1-0/+7
2019-08-19core: from v12, require consistent ring size for mixable txesmoneromooo-monero1-8/+23
We're supposed to have a fixed ring size now Already checked by MLSAG verification, but here seems more intuitive
2019-08-19blockchain: forbid v1 coinbase from v12moneromooo-monero2-5/+9
2019-08-18blockchain: Fix alt chain generated coins overflowiamamyth1-1/+2
Apply the overflow logic used for computing already_generated_coins in the main chain to alternative chains.
2019-08-15Replace std::random_shuffle with std::shuffleTom Smeding1-1/+1
According to [1], std::random_shuffle is deprecated in C++14 and removed in C++17. Since std::shuffle is available since C++11 as a replacement and monero already requires C++11, this is a good replacement. A cryptographically secure random number generator is used in all cases to prevent people from perhaps copying an insecure std::shuffle call over to a place where a secure one would be warranted. A form of defense-in-depth. [1]: https://en.cppreference.com/w/cpp/algorithm/random_shuffle
2019-07-18update checkpoints.dat hashRiccardo Spagni1-1/+1
2019-07-15improve tx_sanity_check clarificationvicsn1-2/+2
2019-07-15Remove unused txs member in NOTIFY_RESPONSE_GET_OBJECTDoyle1-2/+0
2019-07-10wallet: provide original address for outgoing transfersxiphon1-0/+15
2019-07-03Remove unnecessary m_check_txin_table, fix const correctnessMartijn Otto2-43/+12
2019-06-19tx_sanity_check: relax the median check a lotmoneromooo-monero1-1/+1
we don't want to prevent bona fide txes, just obvious bad ones
2019-06-17core: fix --prune-blockchain not pruning if no blockchain existsmoneromooo-monero1-1/+1
2019-06-16blockchain: silence an error getting blocks for pruned nodesmoneromooo-monero1-4/+8
This happens often when a pre-pruning node asks a pruned node for data it does not have
2019-06-14prep for 0.14.1 releaseRiccardo Spagni1-1/+1
2019-06-13core: do not complain about low block rate if disconnectedmoneromooo-monero1-1/+1
In that case, we'll still keep the "Monero is now disconnected from the network" near the end of the log
2019-06-12tx_sanity_check: don't print an error when not enough outs to checkmoneromooo-monero1-1/+1
2019-05-29Unused private member m_miner_addressJesus Ramirez2-2/+0
2019-05-28core: update pruning if using --prune-blockchain on a pruned blockchainmoneromooo-monero1-1/+7
Avoids a massive amount of spurious warnings if the last update before the daemon exited was a while ago and the daemon was syncing
2019-05-26blockchain: do not try to pop blocks down to the genesis blockmoneromooo-monero1-0/+3
2019-05-25core: do not commit half constructed batch db txnmoneromooo-monero3-14/+35
2019-05-19Fix #5553Howard Chu1-1/+2
Make sure the tip hash still matches the cached block
2019-05-09daemon: sort alt chains by heightmoneromooo-monero2-4/+4
2019-05-08blockchain: keep alternative blocks in LMDBmoneromooo-monero3-93/+140
Alternative blocks are cleared on startup unless --keep-alt-blocks is passed on the command line
2019-05-02blockchain: keep a rolling long term block weight medianmoneromooo-monero2-33/+36
2019-05-01fix wide difficulty conversion with some versions of boostmoneromooo-monero1-2/+2
2019-04-29remove unused codemoneromooo-monero1-6/+2
2019-04-29add a few checks where it seems appropriatemoneromooo-monero1-0/+2
2019-04-23consensus: from v12, enforce >= 2 outputsmoneromooo-monero1-0/+13
2019-04-23tx_sanity_check: relax uniqueness check a bitmoneromooo-monero1-2/+2
It triggers easily on testnet
2019-04-15rpc: fix get_block_hashes.bin from wallet on pruned blockchainmoneromooo-monero2-6/+11
We want to get all blocks here, even pruned ones
2019-04-15blockchain: lock the blockchain while pruningmoneromooo-monero1-0/+4
2019-04-14blockchain_db: fix db txn ending too earlymoneromooo-monero1-29/+23
The db txn in add_block ending caused the entire overarching batch txn to stop. Also add a new guard class so a db txn can be stopped in the face of exceptions. Also use a read only db txn in init when the db itself is read only, and do not save the max tx size in that case.
2019-04-12rpc: new sanity check on relayed transactionsmoneromooo-monero3-0/+138
This will weed out some transactions with silly rings
2019-04-11functional_tests: add more blockchain related testsmoneromooo-monero4-68/+164
Related to emission, reorgs, getting tx data back, output distribution and histogram
2019-04-09blockchain: remove unused calc of short_term_constraintstoffu1-1/+0
2019-04-07core: don't check block rate nor fork time in regtest modemoneromooo-monero1-1/+4
2019-04-05cryptonote: rework block blob size sanity checkmoneromooo-monero2-8/+24
Use the actual block weight limit, assuming that weight is always greater or equal to size
2019-04-01blockchain: some debug info when adding txes-from-block failsmoneromooo-monero1-0/+2
2019-04-01Allow pruning before v10moneromooo-monero1-6/+0
This check is now not needed anymore, and would prevent people from using --prune-blockchain when starting a new sync
2019-03-30blockchain: fix returned height in create_block_templatemoneromooo-monero2-3/+6
It's now needed for CNv4, and was not retained when cached
2019-03-28blockchain: incremental long term block weight cachemoneromooo-monero1-0/+22
2019-03-28blockchain: simple cache for the long term block weightsmoneromooo-monero2-0/+24
2019-03-28Add support for V11 protocol with BulletProofV2 and short amount.cslashm1-0/+7
New scheme key destination contrfol Fix dummy decryption in debug mode
2019-03-25cryptonote: block parsing + hash calculation speedupmoneromooo-monero2-5/+8
This saves a duplicate serialization step
2019-03-25blockchain: avoid unneeded block copymoneromooo-monero1-1/+2
2019-03-25save some database calls when getting top block hash and heightmoneromooo-monero1-0/+1
2019-03-25Avoid repeated (de)serialization when syncingmoneromooo-monero1-2/+1
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-26 18:40:28 +0000