aboutsummaryrefslogtreecommitdiff
path: root/contrib (follow)
AgeCommit message (Collapse)AuthorFilesLines
2021-04-22Merge pull request #7658luigi11111-18/+52
834e23b Doc: Update Gitian (Reproducible Builds) with small code snippets and fixes (mj-xmr)
2021-04-22Merge pull request #7643luigi11111-0/+1
19ed7ab Test: Enable coverage for external repositories (mj-xmr)
2021-04-16Split epee/string_tools.h and encapsulate boost::lexical_castmj-xmr17-492/+718
2021-04-16Revert "Merge pull request #7136"luigi11117-164/+135
This reverts commit 63c7ca07fba2f063c760f786a986fb3e02fb040e, reversing changes made to 2218e23e84a89e9a1e4c0be5d50f891ab836754f.
2021-04-16Merge pull request #7652luigi11111-4/+0
02f4954 gitian: remove osslsigncode (selsta)
2021-04-16Merge pull request #7136luigi11117-135/+164
23aae55 Remove payload copy in all outgoing p2p messages (Lee Clagett)
2021-04-16Merge pull request #7002luigi11114-199/+242
673c6d2 Reduce compilation time of epee/portable_storage_template_helper.h (mj-xmr)
2021-04-11Doc: Update Gitian (Reproducible Builds) with small code snippets and fixesmj-xmr1-18/+52
2021-04-08gitian: remove osslsigncodeselsta1-4/+0
Unused and archive is offline
2021-04-01Test: Enable coverage for external repositoriesmj-xmr1-0/+1
Add monero_enable_coverage() for reuse in case C/CXX_FLAGS are overwritten.
2021-03-30Doc: Add ccache to README.md and Brewfilemj-xmr1-0/+1
2021-03-29Merge pull request #7439luigi11111-2/+2
0f2b5af Reduced executable size; reduced call sequence to 'allowed' log function (Lee Clagett)
2021-03-29Merge pull request #7636luigi11111-2/+2
18c7f9c depends: openssl 1.1.1i -> 1.1.1k (selsta)
2021-03-29Merge pull request #7460luigi11111-28/+24
2935a0c async_protocol_handler_config: fix deadlock (anon) c877705 async_protocol_handler_config: add deadlock demo (anon)
2021-03-28Reduce compilation time of epee/portable_storage_template_helper.hmj-xmr4-199/+242
2021-03-25depends: openssl 1.1.1i -> 1.1.1kselsta1-2/+2
2021-03-20Merge pull request #7402luigi11111-1/+10
240d382 Epee: add headers to project files (via glob), to be able to search for them easily. (mj-xmr)
2021-03-20Merge pull request #7394luigi11111-1/+2
b900fa0 Fix compiler warning for in keyvalue_serialization.h (mj-xmr)
2021-03-20Merge pull request #7366luigi11113-0/+57
9867a91 Store RPC SSL key/cert for consistent authentication between runs (Lee Clagett)
2021-03-20Merge pull request #7274luigi11111-4/+4
daf023d epee: don't log raw packet data (moneromooo-monero)
2021-03-20Merge pull request #7005luigi11112-5/+21
249eae5 Allow byte_stream->byte_slice conversion to shrink unused buffer space (Lee Clagett)
2021-03-12async_protocol_handler_config: fix deadlockanon1-28/+24
2021-03-05Merge pull request #7399luigi11111-2/+14
556af11 epee: return HTTP error 400 (Bad request) on deserialization error (moneromooo-monero)
2021-02-25Epee: add headers to project files (via glob), to be able to search for them ↵mj-xmr1-1/+10
easily. Use case: IDEs
2021-02-23epee: return HTTP error 400 (Bad request) on deserialization errormoneromooo-monero1-2/+14
It's better than 404 (Not found)
2021-02-21Fix compiler warning for in keyvalue_serialization.hmj-xmr1-1/+2
2021-02-19async_protocol_handler_config: remove connection correctlyanon1-1/+1
2021-02-18Merge pull request #7343luigi11111-32/+2
545b982 Remove unnecessary atomic operations in levin code (Lee Clagett)
2021-02-15Merge pull request #7308luigi11112-7/+19
df2f00f boosted_tcp_server: fix connection lifetime (anon) 3833624 boosted_tcp_server: add segfault demo (anon)
2021-02-13Store RPC SSL key/cert for consistent authentication between runsLee Clagett3-0/+57
2021-02-06Reduce compilation time of epee/portable_storage.hmj-xmr11-216/+286
2021-01-19boosted_tcp_server: fix connection lifetimeanon2-7/+19
2021-01-19Remove unnecessary atomic operations in levin codeLee Clagett1-32/+2
2021-01-16Reduced executable size; reduced call sequence to "allowed" log functionLee Clagett1-2/+2
2021-01-16Remove payload copy in all outgoing p2p messagesLee Clagett7-135/+164
2021-01-15Merge pull request #7149luigi11111-2/+2
0660db3 fuzz_tests: add a test for utf8canonical (moneromooo-monero)
2021-01-15Merge pull request #7137luigi11111-2/+16
f2ad539 readline_buffer: Avoid consecutive duplicates in the history (codesoap)
2021-01-07storages: overridable limits for loading portable_storage from binarymoneromooo-monero5-33/+63
2021-01-06Merge pull request #7281luigi11111-1/+11
b9092dd epee: also limit number of strings in portable_storage (moneromooo-monero)
2021-01-05epee: also limit number of strings in portable_storagemoneromooo-monero1-1/+11
They require at least 24 bytes
2021-01-03Merge pull request #7263Alexander Blair1-4/+13
b652d598d add a max levin packet size by command type (moneromooo-monero)
2021-01-03epee: don't log raw packet datamoneromooo-monero1-4/+4
2021-01-03add a max levin packet size by command typemoneromooo-monero1-4/+13
2021-01-02portable_storage: better sanity checkingmoneromooo-monero1-2/+7
2021-01-01Merge pull request #7250Alexander Blair2-10/+25
61b6e4cc6 Add aggressive restrictions to pre-handshake p2p buffer limit (Lee Clagett)
2021-01-01Merge pull request #7243Alexander Blair1-1/+6
8e2caf3fb portable_storage: check object limit where appropriate (moneromooo)
2021-01-01Merge pull request #7220Alexander Blair3-0/+3
20bdbd7aa portable_storage: forbid unnamed sections (xiphon)
2020-12-31portable_storage: check object limit where appropriatemoneromooo1-1/+6
also fix pedantic off by one in check
2020-12-29Merge pull request #7218Alexander Blair1-5/+0
353f93ee1 portable_storage: remove array element limit (moneromooo-monero)
2020-12-29Merge pull request #7207Alexander Blair5-13/+14
f7ab8bc6d ssl: buffered handshake detection (anon)
2020-12-28portable_storage: forbid unnamed sectionsxiphon3-0/+3
2020-12-28portable_storage: remove array element limitmoneromooo-monero1-5/+0
some people don't want it
2020-12-28ssl: buffered handshake detectionanon5-13/+14
2020-12-27portable_storage: remove overly aggressive cutoffmoneromooo-monero1-2/+0
2020-12-26Merge pull request #7192Alexander Blair1-6/+21
95575cda6 epee: fix some issues using connections after shutdown (moneromooo-monero)
2020-12-26Merge pull request #7190Alexander Blair1-1/+35
7f407c027 portable_storage: add some sanity checks on data size (moneromooo-monero)
2020-12-26Merge pull request #7099Alexander Blair1-0/+1
9d2bb586a Add command to sign freebsd assert file for gitian (MoneroArbo)
2020-12-26Merge pull request #7098Alexander Blair1-1/+0
c0c75ac19 Fixed issues found by static analysis (SChernykh)
2020-12-26epee: fix some issues using connections after shutdownmoneromooo-monero1-6/+21
2020-12-26portable_storage: add some sanity checks on data sizemoneromooo-monero1-1/+35
especially when allocated size is >> serialized data size
2020-12-20Restrict duplicate keys in epee binary formatLee Clagett1-1/+4
2020-12-17Add aggressive restrictions to pre-handshake p2p buffer limitLee Clagett2-10/+25
2020-12-14Fix byte_stream::put_nLee Clagett1-1/+1
2020-12-14fuzz_tests: add a test for utf8canonicalmoneromooo-monero1-2/+2
2020-12-13readline_buffer: Avoid consecutive duplicates in the historycodesoap1-2/+16
2020-12-10Merge pull request #7100Alexander Blair2-43/+12
5b30203fe depends: Update OpenSSL to 1.1.1i (Howard Chu)
2020-12-10Merge pull request #7009Alexander Blair12-51/+71
7414e2bac Change epee binary output from std::stringstream to byte_stream (Lee Clagett)
2020-12-10Merge pull request #7003Alexander Blair2-18/+8
08eb0949f Change to more efficient allocation strategy in byte_stream (Lee Clagett)
2020-12-10Merge pull request #6947Alexander Blair1-0/+93
19d1b3590 add a convenience script to start monero with inbound tor (moneromooo-monero)
2020-12-09depends: Update OpenSSL to 1.1.1iHoward Chu2-43/+12
Remove some obsolete patches (they were integrated upstream). Tweak to work with Android support (they second-guess our CC definition, etc).
2020-12-08Add command to sign freebsd assert file for gitianMoneroArbo1-0/+1
Add FreeBSD to "Signing assert files" section of gitian readme / guide
2020-12-08Fixed issues found by static analysisSChernykh1-1/+0
- rolling_median: tried to free uninitialized pointer in a constructor - net_node.inl: erase-remove idiom was used incorrectly. remove_if doesn't actually remove elements, see http://cpp.sh/6fcjv - bulletproofs.cc: call to sizeof() instead of vector.size(), luckily it only impacts performance and not code logic there
2020-12-06protocol: drop peers that don't reply to queriesmoneromooo1-8/+6
2020-12-04keep only the last seen node on a given host in the white listmoneromooo1-0/+33
2020-11-29Merge pull request #6999luigi11111-4/+4
c5f6629 epee: tighten the URL parsing regexp a little (moneromooo-monero)
2020-11-29Merge pull request #6995luigi11111-1/+9
60bc676 epee: readline_buffer - fix thread safety, fix sync() after stop() (xiphon)
2020-11-09epee: tighten the URL parsing regexp a littlemoneromooo-monero1-4/+4
fixes massive amounts of time spent on pathological inputs Found by OSS-Fuzz
2020-11-07epee: readline_buffer - fix thread safety, fix sync() after stop()xiphon1-1/+9
2020-10-28add a convenience script to start monero with inbound tormoneromooo-monero1-0/+93
2020-10-19Force CMAKE_SKIP_RPATH=ONHoward Chu2-2/+2
Fix empty RPATH token issue. Only affects Linux and FreeBSD.
2020-10-18Merge pull request #6862Alexander Blair1-12/+17
5f228e4b7 Fix lgamma/signgam dependency (Howard Chu)
2020-10-13Change to more efficient allocation strategy in byte_streamLee Clagett2-18/+8
2020-10-13Allow byte_stream->byte_slice conversion to shrink unused buffer spaceLee Clagett2-5/+21
2020-10-10Change epee binary output from std::stringstream to byte_streamLee Clagett12-51/+71
2020-10-06Fix lgamma/signgam dependencyHoward Chu1-12/+17
This is a new indirect dependency due to the use of poisson_distribution, introduced in PR#6354 commit 67ade8005
2020-09-17Depends: Bump qt to 5.15.1TheCharlatan7-107/+166
2020-09-14build: prepare v0.17selsta6-7/+7
2020-08-27Merge pull request #6769Alexander Blair1-0/+3
b641e0a2c Add clear method to byte_stream (Lee Clagett)
2020-08-20depends: fix broken links for ds_store / mac_aliasselsta2-8/+8
2020-08-17Add clear method to byte_streamLee Clagett1-0/+3
2020-08-16Merge pull request #6736Alexander Blair1-0/+7
05ad4fa39 epee: further defending against exceptions in command handlers (moneromooo-monero)
2020-08-16Merge pull request #6727Alexander Blair1-9/+31
13eee1d6a rpc: reject wrong sized txid (moneromooo-monero) 92e6b7df2 easylogging++: fix crash with reentrant logging (moneromooo-monero) 6dd95d530 epee: guard against exceptions in RPC handlers (moneromooo-monero) 90016ad74 blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
2020-08-16Merge pull request #6720Alexander Blair1-26/+0
86abf558c epee: Remove unused functions in local_ip.h (Jean Pierre Dudey)
2020-08-16Merge pull request #6718Alexander Blair2-2/+12
85efc88c1 Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with unit test (koe)
2020-08-16Merge pull request #6716Alexander Blair3-8/+6
76c16822d wallet2_api: implement runtime proxy configuration (xiphon)
2020-08-16Merge pull request #6691Alexander Blair1-1/+1
6111689cf cmake: allow custom openssl path on macOS (selsta)
2020-08-16Merge pull request #6614Alexander Blair1-0/+25
fb31167b1 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command (rbrunner7)
2020-08-16Merge pull request #6500Alexander Blair1-1/+1
a07c8abcc Update expat.mk (ArqTras)
2020-08-02epee: further defending against exceptions in command handlersmoneromooo-monero1-0/+7
2020-07-30epee: guard against exceptions in RPC handlersmoneromooo-monero1-9/+31
2020-07-24Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' commandrbrunner71-0/+25
2020-07-23Fix overflow issue in epee:misc_utils::rolling_median_t and median(), with ↵koe2-2/+12
unit test
2020-07-22epee: Remove unused functions in local_ip.hJean Pierre Dudey1-26/+0
Signed-off-by: Jean Pierre Dudey <me@jeandudey.tech>
2020-07-20wallet2_api: implement runtime proxy configurationxiphon3-8/+6
2020-07-19Merge pull request #6565Alexander Blair1-1/+1
72cdfa4a2 fix a few typos in error messages (moneromooo-monero)
2020-07-19Merge pull request #6516Alexander Blair2-7/+0
8656a8c9f remove double includes (sumogr)
2020-07-19Merge pull request #6512Alexander Blair22-22/+22
5ef0607da Update copyright year to 2020 (SomaticFanatic)
2020-07-16Merge pull request #6476Alexander Blair1-18/+0
6d41d9e8 contrib: remove codefresh pipeline (selsta)
2020-07-16Merge pull request #6475Alexander Blair4-96/+0
91182330 snap: remove from repo (selsta)
2020-07-08Merge pull request #6675luigi11111-1/+1
3721d56 epee: fix array underflow in unicode parsing (moneromooo-monero)
2020-07-08Merge pull request #6584luigi11111-1/+1
78d435a rpc: don't display invalid json errors on default log level (moneromooo-monero)
2020-07-08Merge pull request #6559luigi11111-1/+4
15538f7 ByteSlice: Fix persisting ptr to std::moved SSO buffer (Doy-lee)
2020-07-08Merge pull request #6528luigi11115-5/+5
b73f4e7 [master]: Update gitian yml files (iDunk5400)
2020-06-25cmake: allow custom openssl path on macOSselsta1-1/+1
2020-06-21epee: fix array underflow in unicode parsingmoneromooo-monero1-1/+1
Reported by minerscan Also independently found by OSS-Fuzz just recently
2020-06-08Merge pull request #6539luigi11111-6/+6
85164a8 epee: use memwipe rather than memset for md5 secrets (moneromooo-monero)
2020-06-08Merge pull request #6522luigi11111-9/+17
29e563b Fixed bugs for take_slice and byte_stream->byte_slice (vtnerd)
2020-06-08Merge pull request #6514luigi11111-2/+2
4baee20 build: prepare v0.16.0.0 release (selsta)
2020-05-31Fix boost <1.60 compilation and fix boost 1.73+ warningsLee Clagett4-17/+17
2020-05-23rpc: don't display invalid json errors on default log levelmoneromooo-monero1-1/+1
It's not something the user needs to know, and will display attacker controlled data
2020-05-20ByteSlice: Fix persisting ptr to std::moved SSO bufferDoyle1-1/+4
The Bug: 1. Construct `byte_slice.portion_` with `epee::span(buffer)` which copies a pointer to the SSO buffer to `byte_slice.portion_` 2. It constructs `byte_slice.storage_` with `std::move(buffer)` (normally this swap pointers, but SSO means a memcpy and clear on the original SSO buffer) 3. `slice.data()` returns a pointer from `slice.portion_` that points to the original SSO cleared buffer, `slice.storage_` has the actual string.
2020-05-19fix a few typos in error messagesmoneromooo-monero1-1/+1
Reported by adrelanos
2020-05-16epee: use memwipe rather than memset for md5 secretsmoneromooo-monero1-6/+6
That's used by HTTP auth now
2020-05-16Support for supercop ASM in wallet, and benchmark for supercopLee Clagett1-2/+3
2020-05-14build: fix boost 1.73 compatibilityselsta2-6/+6
2020-05-13[master]: Update gitian yml filesiDunk54005-5/+5
2020-05-13build: prepare v0.16.0.0 releaseselsta1-2/+2
2020-05-12Fixed bugs for take_slice and byte_stream->byte_sliceLee Clagett1-9/+17
2020-05-11remove double includessumogr2-7/+0
2020-05-06Update copyright year to 2020SomaticFanatic22-22/+22
Update copyright year to 2020
2020-05-03Update expat.mkArqTras1-1/+1
2020-05-01Merge pull request #6446luigi11112-0/+11
e509ede trezor: adapt to new passphrase mechanism (ph4r05)
2020-04-27trezor: adapt to new passphrase mechanismDusan Klinec2-0/+11
- choice where to enter passphrase is now made on the host - use wipeable string in the comm stack - wipe passphrase memory - protocol optimizations, prepare for new firmware version - minor fixes and improvements - tests fixes, HF12 support
2020-04-25contrib: remove codefresh pipelineselsta1-18/+0
2020-04-25snap: remove from reposelsta4-96/+0
2020-04-21Merge pull request #6414luigi11111-1/+1
14e8035 update openssl 1.0.2r link (sumogr)
2020-04-21Merge pull request #6359luigi11111-3/+3
f9441c5 Fixed string_ref usage bug in epee::from_hex::vector (vtnerd)
2020-04-15Allow wallet2.h to run in WebAssemblywoodser6-159/+260
- Add abstract_http_client.h which http_client.h extends. - Replace simple_http_client with abstract_http_client in wallet2, message_store, message_transporter, and node_rpc_proxy. - Import and export wallet data in wallet2. - Use #if defined __EMSCRIPTEN__ directives to skip incompatible code.
2020-04-11Add byte_stream for zero-copy serialization, and add support in ZMQ-JSON.Lee Clagett5-4/+386
2020-04-10Merge pull request #6398luigi11111-1/+1
8688b46 depends: update qt 5.7.1 download link (sumogr)
2020-04-04Merge pull request #6397luigi11112-1/+27
323a9e3 depends: libsodium disable getrandom()/getentropy() (glibc < 2.25) (xiphon)
2020-04-04Merge pull request #6387luigi11111-2/+2
0dbdba8 epee: avoid spamming 'Generating SSL certificate' in the logs (xiphon)
2020-04-04Merge pull request #6371luigi11111-15/+0
b40c27c cppzmq: remove leftovers (selsta)
2020-04-04Merge pull request #6370luigi11111-1/+3
3031deb Bump downloaded boost version to 1.72 (omartijn) 6079042 Use boost::asio::ssl::context::sslv23 for backwards compatibility (omartijn)
2020-04-04Merge pull request #6351luigi11114-40/+63
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd) 5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd) 3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
2020-04-04Merge pull request #6339luigi11113-3/+3
c61abf8 remove empty statements (shopglobal)
2020-04-04Merge pull request #6335luigi11111-3/+4
0078ce7 wipeable_string: split - treat CR, LF and Tabs as separators (xiphon)
2020-04-03Use byte_slice for sending zmq messages - removes data copy within zmqLee Clagett2-5/+24
2020-04-01update openssl 1.0.2r linkSumo Gr1-1/+1
2020-03-31p2p: fix frequent weak_ptr exception on connectionmoneromooo-monero1-1/+6
When a handshake fails, it can fail due to timeout or destroyed connection, in which case the connection will be, or already is, closed, and we don't want to do it twice. Additionally, when closing a connection directly from the top level code, ensure the connection is gone from the m_connects list so it won't be used again. AFAICT this is now clean in netstat, /proc/PID/fd and print_cn. This fixes a noisy (but harmless) exception.
2020-03-31Merge pull request #6336luigi11111-3/+7
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero) 09c8111 threadpool: lock mutex in create (moneromooo-monero) e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
2020-03-31Merge pull request #6311luigi11111-0/+7
5002a03 Explicitly define copy assignment operator (omartijn)
2020-03-30Fixed string_ref usage bug in epee::from_hex::vectorLee Clagett1-3/+3
2020-03-27Merge pull request #6290Alexander Blair1-2/+5
019c1dc0 gitian-build.py: Fixing check for docker command. (Jonathan Cross)
2020-03-20depends: update qt 5.7.1 download linkSumo Gr1-1/+1
5.7.1 was removed from official qt.io archive, this is one of the few mirrors remaining that keep a copy. I think it would be better if @TheCharlatan updated to a newer version soon than merging this PR
2020-03-20depends: libsodium disable getrandom()/getentropy() (glibc < 2.25)xiphon2-1/+27
2020-03-13epee: avoid spamming 'Generating SSL certificate' in the logsxiphon1-2/+2
2020-03-12Merge pull request #6273Alexander Blair1-1/+11
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
2020-03-12Merge pull request #6263Alexander Blair2-5/+5
c11e64fc Gitian: Change lxc ip link (TheCharlatan)
2020-03-12Merge pull request #6251Alexander Blair1-0/+10
0eac0c43 depends: set several missing build tags (moneromooo-monero)
2020-03-12Merge pull request #6244Alexander Blair1-5/+16
352bd132 abstract_tcp_server2: guard against negative timeouts (moneromooo-monero)
2020-03-12Merge pull request #6243Alexander Blair2-6/+4
4771a7ae p2p: remove obsolete local time in handshake (moneromooo-monero) 2fbbc4a2 p2p: avoid sending the same peer list over and over (moneromooo-monero) 3004835b epee: remove backward compatible endian specific address serialization (moneromooo-monero) 39a343d7 p2p: remove backward compatible peer list (moneromooo-monero) 60631802 p2p: simplify last_seen serialization now we have optional stores (moneromooo-monero) 9467b2e4 cryptonote_protocol: omit top 64 bits of difficulty when 0 (moneromooo-monero) b595583f serialization: do not write optional fields with default value (moneromooo-monero) 5f98b46d p2p: remove obsolete local time from TIMED_SYNC (moneromooo-monero)
2020-03-11Use boost::asio::ssl::context::sslv23 for backwards compatibilityMartijn Otto1-1/+3
All the insecure protocols that this enables are then disabled, so they cannot be actually used. The end-result is the same.
2020-03-09Move hex->bin conversion to monero copyright files and with less includesLee Clagett4-36/+58
2020-03-09Remove temporary std::string creation in some hex->bin callsLee Clagett1-5/+6
2020-03-06cppzmq: remove leftoversselsta1-15/+0
2020-03-05Various improvements to the ZMQ JSON-RPC handling:Lee Clagett1-1/+11
- Finding handling function in ZMQ JSON-RPC now uses binary search - Temporary `std::vector`s in JSON output now use `epee::span` to prevent allocations. - Binary -> hex in JSON output no longer allocates temporary buffer - C++ structs -> JSON skips intermediate DOM creation, and instead write directly to an output stream.
2020-02-28Merge pull request #6255Alexander Blair1-3/+3
81494e3f depends: empty spaces in PATH variable cause build failure (kozyilmaz)
2020-02-28Merge pull request #6220Alexander Blair6-56/+53
a9bdc6e4 Improved performance for epee serialization: (Lee Clagett)
2020-02-28Merge pull request #6205Alexander Blair1-1/+1
021cf733 ssl: server-side: allow multiple version of TLS (Bertrand Jacquin)
2020-02-17remove empty statementsInterchained3-3/+3
Cleaning up a little around the code base.
2020-02-12wipeable_string: split - treat CR, LF and Tabs as separatorsxiphon1-3/+4
2020-02-12console_handler: do not let exception past the dormoneromooo-monero1-3/+7
Coverity 208373
2020-02-06Merge pull request #6184Alexander Blair1-0/+42
2d1afceb net_ssl: load default certificates in CA mode on Windows (moneromooo-monero)
2020-02-06Merge pull request #6182Alexander Blair2-2/+2
e896cca8 epee: reorder a couple init list fields to match declaration (moneromooo-monero)
2020-01-28Explicitly define copy assignment operatorMartijn Otto1-0/+7
The implicit copy assignment operator was deprecated because the class has an explicit copy constructor. According to the standard: The generation of the implicitly-defined copy assignment operator is deprecated (since C++11) if T has a user-declared destructor or user-declared copy constructor. Recent versions of gcc (9.1+) and clang (10.0) warn about this.
2020-01-26epee: remove backward compatible endian specific address serializationmoneromooo-monero1-6/+2
2020-01-26serialization: do not write optional fields with default valuemoneromooo-monero1-0/+2
2020-01-26network: log traffic and add a simple traffic analysis scriptmoneromooo-monero1-5/+43
2020-01-24Merge pull request #6160Alexander Blair1-1/+1
bd6a5778 Gitian: Fix sigs generation (TheCharlatan)
2020-01-16Merge pull request #6143Alexander Blair1-0/+2
6efeefbc epee: set application/json MIME type on json errors (moneromooo-monero)
2020-01-16Merge pull request #6133Alexander Blair1-1/+1
b2ad757f Replace memset with memwipe. (Bert Peters)
2020-01-16Merge pull request #6125Alexander Blair1-1/+8
584d057f epee: fix console_handlers_binder race, wait for thread to finish (xiphon)
2020-01-16Merge pull request #6120Alexander Blair1-1/+3
feef1c6a epee: fix peer ids being truncated on display (moneromooo-monero)
2020-01-10gitian-build.py: Fixing check for docker command.Jonathan Cross1-2/+5
2020-01-06Gitian: Change lxc ip linkTheCharlatan2-5/+5
The ip link currently listed in the README no longer works on the newest version of lxc shipped with ubuntu 18.04, this commit corrects this.
2019-12-19depends: empty spaces in PATH variable cause build failurekozyilmaz1-3/+3
2019-12-18depends: set several missing build tagsmoneromooo-monero1-0/+10
2019-12-16abstract_tcp_server2: guard against negative timeoutsmoneromooo-monero1-5/+16
2019-12-12depends: update libsodium to 1.0.18TheCharlatan2-4/+4
2019-12-03ssl: server-side: allow multiple version of TLSBertrand Jacquin1-1/+1
boost::asio::ssl::context is created using specifically TLSv1.2, which blocks the ability to use superior version of TLS like TLSv1.3. Filtering is also made specially later in the code to remove unsafe version for TLS such SSLv2, SSLv3 etc.. This change is removing double filtering to allow TLSv1.2 and above to be used. testssl.sh 3.0rc5 now reports the following (please note monerod was built with USE_EXTRA_EC_CERT): $ ./testssl.sh --openssl=/usr/bin/openssl \ --each-cipher --cipher-per-proto \ --server-defaults --server-preference \ --vulnerable --heartbleed --ccs --ticketbleed \ --robot --renegotiation --compression --breach \ --poodle --tls-fallback --sweet32 --beast --lucky13 \ --freak --logjam --drown --pfs --rc4 --full \ --wide --hints 127.0.0.1:38081 Using "OpenSSL 1.1.1d 10 Sep 2019" [~80 ciphers] on ip-10-97-15-6:/usr/bin/openssl (built: "Dec 3 21:14:51 2019", platform: "linux-x86_64") Start 2019-12-03 21:51:25 -->> 127.0.0.1:38081 (127.0.0.1) <<-- rDNS (127.0.0.1): -- Service detected: HTTP Testing protocols via sockets except NPN+ALPN SSLv2 not offered (OK) SSLv3 not offered (OK) TLS 1 not offered TLS 1.1 not offered TLS 1.2 offered (OK) TLS 1.3 offered (OK): final NPN/SPDY not offered ALPN/HTTP2 not offered Testing for server implementation bugs No bugs found. Testing cipher categories NULL ciphers (no encryption) not offered (OK) Anonymous NULL Ciphers (no authentication) not offered (OK) Export ciphers (w/o ADH+NULL) not offered (OK) LOW: 64 Bit + DES, RC[2,4] (w/o export) not offered (OK) Triple DES Ciphers / IDEA not offered (OK) Average: SEED + 128+256 Bit CBC ciphers not offered Strong encryption (AEAD ciphers) offered (OK) Testing robust (perfect) forward secrecy, (P)FS -- omitting Null Authentication/Encryption, 3DES, RC4 PFS is offered (OK), ciphers follow (client/browser support is important here) Hexcode Cipher Suite Name (OpenSSL) KeyExch. Encryption Bits Cipher Suite Name (IANA/RFC) ----------------------------------------------------------------------------------------------------------------------------- x1302 TLS_AES_256_GCM_SHA384 ECDH 253 AESGCM 256 TLS_AES_256_GCM_SHA384 x1303 TLS_CHACHA20_POLY1305_SHA256 ECDH 253 ChaCha20 256 TLS_CHACHA20_POLY1305_SHA256 xc030 ECDHE-RSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 xc02c ECDHE-ECDSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 xcca9 ECDHE-ECDSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 xcca8 ECDHE-RSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 x1301 TLS_AES_128_GCM_SHA256 ECDH 253 AESGCM 128 TLS_AES_128_GCM_SHA256 xc02f ECDHE-RSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 xc02b ECDHE-ECDSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 Elliptic curves offered: prime256v1 secp384r1 secp521r1 X25519 X448 Testing server preferences Has server cipher order? yes (OK) Negotiated protocol TLSv1.3 Negotiated cipher TLS_AES_256_GCM_SHA384, 253 bit ECDH (X25519) Cipher order TLSv1.2: ECDHE-ECDSA-CHACHA20-POLY1305 ECDHE-ECDSA-AES256-GCM-SHA384 ECDHE-ECDSA-AES128-GCM-SHA256 ECDHE-RSA-CHACHA20-POLY1305 ECDHE-RSA-AES256-GCM-SHA384 ECDHE-RSA-AES128-GCM-SHA256 TLSv1.3: TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_AES_128_GCM_SHA256 Testing server defaults (Server Hello) TLS extensions (standard) "renegotiation info/#65281" "EC point formats/#11" "supported versions/#43" "key share/#51" "max fragment length/#1" "extended master secret/#23" Session Ticket RFC 5077 hint no -- no lifetime advertised SSL Session ID support yes Session Resumption Tickets no, ID: no TLS clock skew Random values, no fingerprinting possible Server Certificate #1 (in response to request w/o SNI) Signature Algorithm SHA256 with RSA Server key size RSA 4096 bits Server key usage -- Server extended key usage -- Serial / Fingerprints 01 / SHA1 132E42981812F5575FA0AE64922B18A81B38C03F SHA256 EBA3CC4AA09DEF26706E64A70DB4BC8D723533BB67EAE12B503A845019FB61DC Common Name (CN) (no CN field in subject) subjectAltName (SAN) missing (NOT ok) -- Browsers are complaining Issuer Trust (hostname) certificate does not match supplied URI Chain of trust NOT ok (self signed) EV cert (experimental) no "eTLS" (visibility info) not present Certificate Validity (UTC) 181 >= 60 days (2019-12-03 21:51 --> 2020-06-02 21:51) # of certificates provided 1 Certificate Revocation List -- OCSP URI -- NOT ok -- neither CRL nor OCSP URI provided OCSP stapling not offered OCSP must staple extension -- DNS CAA RR (experimental) not offered Certificate Transparency -- Server Certificate #2 (in response to request w/o SNI) Signature Algorithm ECDSA with SHA256 Server key size EC 256 bits Server key usage -- Server extended key usage -- Serial / Fingerprints 01 / SHA1 E17B765DD8124525B1407E827B89A31FB167647D SHA256 AFB7F44B1C33831F521357E5AEEB813044CB02532143E92D35650A3FF792A7C3 Common Name (CN) (no CN field in subject) subjectAltName (SAN) missing (NOT ok) -- Browsers are complaining Issuer Trust (hostname) certificate does not match supplied URI Chain of trust NOT ok (self signed) EV cert (experimental) no "eTLS" (visibility info) not present Certificate Validity (UTC) 181 >= 60 days (2019-12-03 21:51 --> 2020-06-02 21:51) # of certificates provided 1 Certificate Revocation List -- OCSP URI -- NOT ok -- neither CRL nor OCSP URI provided OCSP stapling not offered OCSP must staple extension -- DNS CAA RR (experimental) not offered Certificate Transparency -- Testing HTTP header response @ "/" HTTP Status Code 404 Not found (Hint: supply a path which doesn't give a "404 Not found") HTTP clock skew Got no HTTP time, maybe try different URL? Strict Transport Security not offered Public Key Pinning -- Server banner Epee-based Application banner -- Cookie(s) (none issued at "/") -- maybe better try target URL of 30x Security headers -- Reverse Proxy banner -- Testing vulnerabilities Heartbleed (CVE-2014-0160) not vulnerable (OK), no heartbeat extension CCS (CVE-2014-0224) not vulnerable (OK) Ticketbleed (CVE-2016-9244), experiment. not vulnerable (OK), no session ticket extension ROBOT Server does not support any cipher suites that use RSA key transport Secure Renegotiation (CVE-2009-3555) not vulnerable (OK) Secure Client-Initiated Renegotiation not vulnerable (OK) CRIME, TLS (CVE-2012-4929) not vulnerable (OK) BREACH (CVE-2013-3587) no HTTP compression (OK) - only supplied "/" tested POODLE, SSL (CVE-2014-3566) not vulnerable (OK) TLS_FALLBACK_SCSV (RFC 7507) No fallback possible, no protocol below TLS 1.2 offered (OK) SWEET32 (CVE-2016-2183, CVE-2016-6329) not vulnerable (OK) FREAK (CVE-2015-0204) not vulnerable (OK) DROWN (CVE-2016-0800, CVE-2016-0703) not vulnerable on this host and port (OK) make sure you don't use this certificate elsewhere with SSLv2 enabled services https://censys.io/ipv4?q=EBA3CC4AA09DEF26706E64A70DB4BC8D723533BB67EAE12B503A845019FB61DC could help you to find out LOGJAM (CVE-2015-4000), experimental not vulnerable (OK): no DH EXPORT ciphers, no DH key detected with <= TLS 1.2 BEAST (CVE-2011-3389) no SSL3 or TLS1 (OK) LUCKY13 (CVE-2013-0169), experimental not vulnerable (OK) RC4 (CVE-2013-2566, CVE-2015-2808) no RC4 ciphers detected (OK) Testing ciphers per protocol via OpenSSL plus sockets against the server, ordered by encryption strength Hexcode Cipher Suite Name (OpenSSL) KeyExch. Encryption Bits Cipher Suite Name (IANA/RFC) ----------------------------------------------------------------------------------------------------------------------------- SSLv2 SSLv3 TLS 1 TLS 1.1 TLS 1.2 xc030 ECDHE-RSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 xc02c ECDHE-ECDSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 xcca9 ECDHE-ECDSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 xcca8 ECDHE-RSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 xc02f ECDHE-RSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 xc02b ECDHE-ECDSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS 1.3 x1302 TLS_AES_256_GCM_SHA384 ECDH 253 AESGCM 256 TLS_AES_256_GCM_SHA384 x1303 TLS_CHACHA20_POLY1305_SHA256 ECDH 253 ChaCha20 256 TLS_CHACHA20_POLY1305_SHA256 x1301 TLS_AES_128_GCM_SHA256 ECDH 253 AESGCM 128 TLS_AES_128_GCM_SHA256 Running client simulations (HTTP) via sockets Browser Protocol Cipher Suite Name (OpenSSL) Forward Secrecy ------------------------------------------------------------------------------------------------ Android 4.2.2 No connection Android 4.4.2 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Android 5.0.0 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 256 bit ECDH (P-256) Android 6.0 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 256 bit ECDH (P-256) Android 7.0 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Android 8.1 (native) No connection Android 9.0 (native) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) Chrome 65 Win 7 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Chrome 74 (Win 10) No connection Firefox 62 Win 7 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Firefox 66 (Win 8.1/10) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) IE 6 XP No connection IE 7 Vista No connection IE 8 Win 7 No connection IE 8 XP No connection IE 11 Win 7 No connection IE 11 Win 8.1 No connection IE 11 Win Phone 8.1 No connection IE 11 Win 10 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Edge 15 Win 10 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 253 bit ECDH (X25519) Edge 17 (Win 10) TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 253 bit ECDH (X25519) Opera 60 (Win 10) No connection Safari 9 iOS 9 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Safari 9 OS X 10.11 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Safari 10 OS X 10.12 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Apple ATS 9 iOS 9 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Tor 17.0.9 Win 7 No connection Java 6u45 No connection Java 7u25 No connection Java 8u161 TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Java 9.0.4 TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.0.1l TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.0.2e TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.1.0j (Debian) TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) OpenSSL 1.1.1b (Debian) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) Thunderbird (60.6) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519)
2019-11-26net_ssl: load default certificates in CA mode on Windowsmoneromooo-monero1-0/+42
Because it always does things wonkily doens't it
2019-11-25epee: reorder a couple init list fields to match declarationmoneromooo-monero2-2/+2
This is a bug waiting to happen
2019-11-20Merge pull request #6117luigi11111-6/+5
0f7c9f4 Gitian Readme: adding android signing & fix v0.15 checksum. (jonathancross)
2019-11-20Gitian: Fix sigs generationTheCharlatan1-1/+1
2019-11-18Merge pull request #6118luigi111136-172/+410
gitian: add FreeBSD support (75c5a04, 607c01a, cca6e5c, 35b5e91, 024a1c7, b14d9ab, 5eea312, 9cbba5a, 2e435df, abeed9a) (hyc)
2019-11-18"Fix" non-determinism in native_cctools buildHoward Chu2-0/+16
By omitting the otool binary which is built non-deterministically. We don't use it anyway.
2019-11-17Fixup compiled python in OSXHoward Chu1-1/+1
2019-11-17Fix unwind library orderingHoward Chu2-0/+16
Sort objects being archived
2019-11-17Fixup sodium darwinHoward Chu3-31/+2
get rid of sodium-darwin.mk special case, unify back with sodium.mk