aboutsummaryrefslogtreecommitdiff
path: root/contrib (follow)
AgeCommit message (Collapse)AuthorFilesLines
2018-02-25Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windowsrbrunner71-1/+82
2018-02-20Merge pull request #3289Riccardo Spagni1-3/+6
4789f859 wipeable_string: don't try to wipe an empty buffer (moneromooo-monero)
2018-02-20Merge pull request #3243Riccardo Spagni1-2/+2
2bc8c3db epee get_ns_count: cast to uint64_t before multiplying 10^9 to avoid overflow (stoffu)
2018-02-18wipeable_string: don't try to wipe an empty buffermoneromooo-monero1-3/+6
memset_s doesn't like it
2018-02-17memwipe: add missing #include <stdio.h>stoffu1-0/+1
2018-02-16Merge pull request #3226Riccardo Spagni4-11/+11
e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero) 2e3e90ac pass large parameters by const ref, not value (moneromooo-monero) 61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero) 9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero) 8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero) 9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero) 24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero) f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero) c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero) fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero) 03887f11 keccak: fix sanity check bounds test (moneromooo-monero) ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero) bece67f9 miner: restore std::cout precision after modification (moneromooo-monero) 1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
2018-02-16Merge pull request #3252Riccardo Spagni1-0/+3
f689a77e Fix #602 Turn on socket keepalive (Howard Chu)
2018-02-16Merge pull request #3217Riccardo Spagni2-13/+6
fde4489e wipeable_string: call memwipe directly (moneromooo-monero)
2018-02-16Merge pull request #3187Riccardo Spagni1-0/+6
851bd057 call _exit instead of abort in release mode (moneromooo-monero)
2018-02-11Fix #602 Turn on socket keepaliveHoward Chu1-0/+3
2018-02-08epee get_ns_count: cast to uint64_t before multiplying 10^9 to avoid overflowstoffu1-2/+2
2018-02-02pass large parameters by const ref, not valuemoneromooo-monero4-11/+11
Coverity 136394 136397 136409 136526 136529 136533 175302
2018-02-01call _exit instead of abort in release modemoneromooo-monero1-0/+6
Avoids cores being created, as they're nowadays often piped to some call home system
2018-01-31wipeable_string: call memwipe directlymoneromooo-monero2-13/+6
since the original reason for the indirect call (that memwipe was not in contrib) is now gone
2018-01-29Fix method name in invoke_http_json_rpcErik de Castro Lopo1-1/+1
Previously, the method name was printed as an exmpty string because the input string had already been moved with `std::move`.
2018-01-29Allow the number of incoming connections to be limitedErik de Castro Lopo1-33/+45
It was already possible to limit outgoing connections. One might want to do this on home network connections with high bandwidth but low usage caps.
2018-01-27Merge pull request #2969Riccardo Spagni3-12/+15
95171614 Remove is_pod trait, and replace with is_standard_layout requirement (Lee Clagett)
2018-01-27Merge pull request #3098Riccardo Spagni1-1/+1
935e39c7 levin_protocol_handler_async: erase from back of vector instead of front (stoffu)
2018-01-26Readd copyright starting datexmr-eric7-7/+7
2018-01-26Update 2018 copyrightxmr-eric18-18/+18
2018-01-26levin_protocol_handler_async: erase from back of vector instead of frontstoffu1-1/+1
2018-01-25Merge pull request #3155Riccardo Spagni1-1/+0
21bd2157 remove unnecessary include (Jethro Grassie)
2018-01-25Merge pull request #3012Riccardo Spagni1-8/+18
e4bbeff2 epee: check some error return values (moneromooo-monero)
2018-01-18remove unnecessary includeJethro Grassie1-1/+0
2018-01-18Merge pull request #3107Riccardo Spagni1-0/+6
b7e5a70b epee: detect strptime, use std::get_time as fallback (moneromooo-monero)
2018-01-18Remove is_pod trait, and replace with is_standard_layout requirementLee Clagett3-12/+15
2018-01-11epee: detect strptime, use std::get_time as fallbackmoneromooo-monero1-0/+6
2018-01-11Keep readline optionalJethro Grassie1-1/+1
2018-01-10Merge pull request #2995Riccardo Spagni1-1/+1
6ccc51f6 wipeable_string: fix buffer overread (moneromooo-monero)
2018-01-10Merge pull request #2990Riccardo Spagni1-1/+0
2d17feb0 factor STL container serialization (moneromooo-monero)
2018-01-10Merge pull request #2986Riccardo Spagni1-3/+3
373d1d50 epee: use strptime instead of std::get_time, for compatibility (moneromooo-monero)
2018-01-10move memwipe to epee to avoid common<->crypto circular dependenciesmoneromooo-monero3-1/+195
2018-01-10epee: remove dependency on commonmoneromooo-monero7-13/+12
2017-12-27epee: check some error return valuesmoneromooo-monero1-8/+18
2017-12-25Merge pull request #2936Riccardo Spagni1-9/+12
cb9aa23c levin_protocol_handler_async: another attempt at fixing at exception (moneromooo-monero) 64d23ce3 Revert "epee: keep a ref to a connection we're deleting" (moneromooo-monero)
2017-12-25Merge pull request #2930Riccardo Spagni1-5/+9
7f4bb612 levin_protocol_handler_async: add missing response handler locking (moneromooo-monero)
2017-12-25Merge pull request #2929Riccardo Spagni1-0/+20
ae55bacd resumption support for updates using range requests (moneromooo-monero) fe0fae50 epee: add a get_file_size function (moneromooo-monero)
2017-12-25Merge pull request #2920Riccardo Spagni9-14/+27
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
2017-12-25Merge pull request #2909Riccardo Spagni1-0/+1
dba2de61 levin_protocol_handler_async: call handler destroy function on dtor (moneromooo-monero)
2017-12-25Merge pull request #2905Riccardo Spagni2-81/+121
bd1f6029 http_client: rewrite header parsing manually for speed (moneromooo-monero) ec724eb6 tests: add levin fuzz test (moneromooo-monero) f1bdc9a4 tests: add http client fuzz test (moneromooo-monero) 0272df9e add parse_url fuzz test (moneromooo-monero) 261b0dd0 tests: add base58 fuzz test (moneromooo-monero) fd052087 fuzz_testing: allow automatically resuming an interrupted job (moneromooo-monero) c80bb0eb tests: don't init stuff we don't need in fuzz tests - faster (moneromooo-monero) 53b83a83 tests: better load-from-binary fuzz test data file (moneromooo-monero) 1a379ef6 fuzz_testing: build with ASAN (assumed to be available) (moneromooo-monero) 4cd4a431 fuzz_testing: create out directory if needed, and fix filename passing (moneromooo-monero) c27d9092 Makefile: build fuzz tests statically, starts faster (moneromooo-monero) 95aa0bf7 add load_from_binary/load_from_json fuzzers (moneromooo-monero)
2017-12-23wipeable_string: fix buffer overreadmoneromooo-monero1-1/+1
2017-12-23Fix Windows builddEBRUYNE-11-0/+4
Fix no new line
2017-12-23http_client: rewrite header parsing manually for speedmoneromooo-monero1-74/+95
boost::regex is stupendously atrocious at parsing malformed data
2017-12-23tests: add levin fuzz testmoneromooo-monero1-3/+3
2017-12-23tests: add http client fuzz testmoneromooo-monero2-6/+17
2017-12-23add parse_url fuzz testmoneromooo-monero1-3/+3
2017-12-23tests: add base58 fuzz testmoneromooo-monero1-3/+3
2017-12-23fuzz_testing: allow automatically resuming an interrupted jobmoneromooo-monero1-1/+8
2017-12-23fuzz_testing: create out directory if needed, and fix filename passingmoneromooo-monero1-1/+2
2017-12-23add load_from_binary/load_from_json fuzzersmoneromooo-monero1-3/+3
2017-12-22factor STL container serializationmoneromooo-monero1-1/+0
2017-12-21epee: use strptime instead of std::get_time, for compatibilitymoneromooo-monero1-3/+3
2017-12-19wipeable_string: move a wipe from reserve to growmoneromooo-monero1-3/+2
That way, all implicit wipes ends up in grow, which is more robust
2017-12-19wipeable_string: ignore reserve size less than actual sizemoneromooo-monero1-2/+1
This was asserting, but stoffu pointed out the std::string standard considers this ok and ignorable
2017-12-19wipeable_string: fix clear and push_backmoneromooo-monero1-1/+4
2017-12-18network_throttle: fix ineffective lockingmoneromooo-monero1-3/+5
2017-12-18network_throttle: remove unused xxx static membermoneromooo-monero2-5/+0
2017-12-18abstract_tcp_server2: log init_server errors as fatalmoneromooo-monero1-1/+11
so they show up by default
2017-12-18net_parse_helpers: fix regex error checkingmoneromooo-monero1-2/+2
2017-12-18catch const exceptionsmoneromooo-monero1-1/+1
2017-12-18add empty container sanity checks when using front() and back()moneromooo-monero1-1/+1
2017-12-18epee: trap failure to parse URI from requestmoneromooo-monero1-1/+6
2017-12-18mlog: terminate a string at last char, just in casemoneromooo-monero1-0/+1
2017-12-17Merge pull request #2857Riccardo Spagni1-1/+1
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
2017-12-17Merge pull request #2877Riccardo Spagni8-3/+1218
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
2017-12-16move connection_basic and network_throttle from src/p2p to epeemoneromooo-monero8-3/+1218
These even had the epee namespace. This fixes some ugly circular dependencies.
2017-12-16move includes around to lessen overall loadmoneromooo-monero22-75/+87
2017-12-16Scrub keys from memory just before scope end.moneromooo-monero1-1/+1
Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.
2017-12-16Merge pull request #2866Riccardo Spagni1-5/+4
cf5f6236 Corrections in rate limiting / trottle code, especially in 'out' direction (rbrunner7)
2017-12-16Merge pull request #2860Riccardo Spagni5-4/+228
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)
2017-12-15levin_protocol_handler_async: another attempt at fixing at exceptionmoneromooo-monero1-3/+12
2017-12-15Revert "epee: keep a ref to a connection we're deleting"moneromooo-monero1-8/+2
This reverts commit f2939bdce8c86b0f96921f731184c361106390c8.
2017-12-15levin_protocol_handler_async: add missing response handler lockingmoneromooo-monero1-5/+9
2017-12-15epee: add a get_file_size functionmoneromooo-monero1-0/+20
2017-12-11levin_protocol_handler_async: call handler destroy function on dtormoneromooo-monero1-0/+1
2017-12-10Merge pull request #2906Riccardo Spagni2-5/+27
27aa8ce9 net_utils_base: fix peer list parsing (moneromooo-monero) fe5ab2c4 epee: fix kv_unserialize return value when a field is not found (moneromooo-monero)
2017-12-09net_utils_base: fix peer list parsingmoneromooo-monero1-3/+25
Fields are written with their "name" as key, and that name changed.
2017-12-07epee: add do while(0) around brace statement in a macromoneromooo-monero1-1/+1
Allows use in more complex expressions
2017-12-02Merge pull request #2847Riccardo Spagni1-1/+5
7256d9a7 Fix versioning (vdo) e459d467 Update snap version to 0.11.1 (vdo)
2017-12-02Merge pull request #2832Riccardo Spagni1-9/+15
287dde63 Added command descriptions (Cifrado)
2017-12-01epee: fix kv_unserialize return value when a field is not foundmoneromooo-monero1-2/+2
2017-11-28Corrections in rate limiting / trottle code, especially in 'out' directionrbrunner71-5/+4
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet that were erroneous / superfluous, which enabled the elimination of a "fudge" factor of 2.1 in connection_basic::set_rate_up_limit; also ended the multiplying of limit values and numbers of bytes transferred by 1024 before handing them over to the global throttle objects
2017-11-27new wipeable_string class to replace std::string passphrasesmoneromooo-monero5-4/+228
2017-11-26Added command descriptionsCifrado1-9/+15
2017-11-22Fix versioningvdo1-1/+1
2017-11-20Update snap version to 0.11.1vdo1-1/+5
2017-11-16RPC: CORS add Access-Control-Allow-Headers to OPTIONS preflightTim L1-0/+3
2017-11-14Merge pull request #2811Riccardo Spagni1-0/+2
f80f408b epee: don't disable -Wtautological-constant-out-of-range-compare on GCC (moneromooo-monero)
2017-11-14Merge pull request #2736Riccardo Spagni1-3/+14
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu) 178014c9 split off readline code into epee_readline (moneromooo-monero) a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero) 437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero) e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero) ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero) 082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
2017-11-14Merge pull request #2629Riccardo Spagni1-2/+0
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
2017-11-14epee: don't disable -Wtautological-constant-out-of-range-compare on GCCmoneromooo-monero1-0/+2
It's a CLANG only option, and causes GCC to error out
2017-11-14split off readline code into epee_readlinemoneromooo-monero1-3/+14
2017-11-14remove "using namespace std" from headersmoneromooo-monero1-2/+0
It's nasty, and actually breaks on Solaris, where if.h fails to build due to: struct map *if_memmap;
2017-11-14Merge pull request #2756Riccardo Spagni6-0/+0
0bf09154 Fix file permission issue (Tim L)
2017-11-14Merge pull request #2753Riccardo Spagni2-0/+11
fa514082 RPC: get_info add rpc_connections_count (Tim L)
2017-11-14Merge pull request #2743Riccardo Spagni1-0/+1
9ff8e139 epee: disable a spurious warning for a storage function (moneromooo-monero)
2017-11-14Merge pull request #2617Riccardo Spagni5-6/+27
7dbf76d0 Fix an object lifetime bug in net load tests (moneromooo-monero)
2017-11-07RPC: get_info add rpc_connections_countTim L2-0/+11
2017-11-03Fix file permission issueTim L6-0/+0
This branch fixes a file permission issue introduced by https://github.com/monero-project/monero/commit/69c37200aa87f100f731e755bdca7a0dc6ae820a
2017-11-01Merge pull request #2663Riccardo Spagni2-3/+10
4b228dd3 cmake: epee: use var from FindOpenSSL.cmake (redfish) 29497f79 epee: use boost type for SSL error code (redfish)
2017-10-31Merge pull request #2723Riccardo Spagni6-17/+60
69c37200 RPC Add cross origin resource sharing support (Tim L)
2017-10-30RPC Add cross origin resource sharing supportTim L6-17/+60
2017-10-28epee: disable a spurious warning for a storage functionmoneromooo-monero1-0/+1
2017-10-20net_helper: fix massive slowdown after SSL supportmoneromooo-monero1-5/+5
2017-10-17cmake: epee: use var from FindOpenSSL.cmakeredfish1-2/+1
This fixes linking when path to openssl is defined manually: cmake -DOPENSSL_ROOT_DIR='/usr/include/openssl-1.0;/usr/lib/openssl-1.0' ... This is useful for building with OpenSSL v1.0 when default system installation is v1.1. The linking error is undefined SSL_load_error_strings symbol. This is due to -L /usr/lib/openssl-1.0 not making it onto the linkline (so -lssl pulls in the default system openssl).
2017-10-17epee: use boost type for SSL error coderedfish1-1/+9
Fixes compile error when building with OpenSSL v1.1: contrib/epee/include/net/net_helper.h: In member function ‘void epee::net_utils::blocked_mode_client::shutdown_ssl()’: contrib/epee/include/net/net_helper.h:579:106: error: ‘SSL_R_SHORT_READ’ was not declared in this scope if (ec.category() == boost::asio::error::get_ssl_category() && ec.value() != ERR_PACK(ERR_LIB_SSL, 0, SSL_R_SHORT_READ)) ^ contrib/epee/include/net/net_helper.h:579:106: note: suggested alternative: ‘SSL_F_SSL_READ’ See boost/asio/ssl/error.hpp. Boost handles differences between OpenSSL versions. cmake: fail if Boost is too old for OpenSSL v1.1
2017-10-15epee: link against ssl/crypto for the new SSL codemoneromooo-monero1-0/+2
2017-10-15Merge pull request #2613Riccardo Spagni1-0/+5
2051f89f cmake: build tests last (redfish)
2017-10-15Merge pull request #2602Riccardo Spagni3-6/+6
bc1b9333 frob level 1 logs a bit for consistency (moneromooo-monero)
2017-10-15add string_tools::validate_hex()Jaquee1-0/+6
2017-10-15Serializer: string to integer conversion for MyMonero compatibilityJaquee1-0/+27
mymonero timestamp conversion
2017-10-15epee http_client SSL supportJaquee3-46/+111
2017-10-09Fix an object lifetime bug in net load testsmoneromooo-monero5-6/+27
The commands handler must not be destroyed before the config object, or we'll be accessing freed memory. An earlier attempt at using boost::shared_ptr to control object lifetime turned out to be very invasive, though would be a better solution in theory.
2017-10-08cmake: build tests lastredfish1-0/+5
Keep -Werror for src, contrib and do not pass it for tests/
2017-10-07frob level 1 logs a bit for consistencymoneromooo-monero3-6/+6
Level 1 logs map to INFO, so setting log level to 1 should show these. Demote some stuff to DEBUG to avoid spam, though.
2017-10-07Subaddresseskenshi841-5/+41
2017-10-06Merge pull request #2541Riccardo Spagni1-0/+2
15e62581 connection_context: initialize m_callback_request_count to 0 (moneromooo-monero) 5fa199c6 copyable_atomic: add a ctor with initial value (moneromooo-monero)
2017-10-05Upgrades to epee::net_utils::network_addressLee Clagett4-73/+189
- internal nullptr checks - prevent modifications to network_address (shallow copy issues) - automagically works with any type containing interface functions - removed fnv1a hashing - ipv4_network_address now flattened with no base class
2017-10-02Merge pull request #2512Riccardo Spagni2-4/+41
792ba4f0 Log categories can now be added to and removed from (moneromooo-monero) 48f92eb6 easylogging++: add categories getter (moneromooo-monero) f35afe62 epee: factor log level/categories setting (moneromooo-monero)
2017-10-02Merge pull request #2475Riccardo Spagni1-2/+8
f2939bdc epee: keep a ref to a connection we're deleting (moneromooo-monero)
2017-10-02Merge pull request #2467Riccardo Spagni1-0/+3
2e82b232 epee: give virtual dtor to network_address_base (moneromooo-monero)
2017-09-27copyable_atomic: add a ctor with initial valuemoneromooo-monero1-0/+2
2017-09-25serialization: add deque serializationmoneromooo-monero1-0/+36
2017-09-25Merge pull request #2456Riccardo Spagni2-3/+4
91def9a5 daemon, wallet: add --max-log-file-size option (selsta)
2017-09-25http_base: init size_t in http_request_info ctormoneromooo-monero1-1/+2
CID 161879
2017-09-22Log categories can now be added to and removed frommoneromooo-monero2-2/+40
Also, set_log without parameters now prints the log categories
2017-09-22epee: factor log level/categories settingmoneromooo-monero1-2/+1
2017-09-21Merge pull request #2302Riccardo Spagni2-22/+15
ef005f5e p2p: add a couple early outs when the stop signal is received (moneromooo-monero) 80d361c7 abstract_tcp_server2: improve tracking/cancelling of early connections (moneromooo-monero)
2017-09-19epee: keep a ref to a connection we're deletingmoneromooo-monero1-2/+8
close might end up dropping a ref, ending up removing the connection from m_connects, as the lock is recursive. This'd cause an out of bounds exception and kill the idle connection maker thread
2017-09-18epee: give virtual dtor to network_address_basemoneromooo-monero1-0/+3
It has virtual functions and is used as a base class
2017-09-17daemon, wallet: add --max-log-file-size optionselsta2-3/+4
2017-08-26Merge pull request #2320Riccardo Spagni3-140/+85
c656dd0e Fix refresh counter display (Howard Chu) c088d38a Simplify readline support (Howard Chu)
2017-08-25Merge pull request #2311Riccardo Spagni2-0/+13
df0cffed cryptonote_protocol: warn if we see a higher top version we expect (moneromooo-monero) 317ab21a cryptonote_protocol: less strict check on top version on connect (moneromooo-monero) cc81a371 cryptonote_protocol: update target height when syncing too (moneromooo-monero) e2ad372b cryptonote_protocol: simplify and remove unnecessary casts (moneromooo-monero) 727e67ca cryptonote_protocol: print peer top height along with its version (moneromooo-monero) b5345ef4 crypto: use malloc instead of alloca (moneromooo-monero) 80794b31 thread_group: set thread size to THREAD_STACK_SIZE (moneromooo-monero) 5524bc31 print peer id in 0 padded hex for consistency (moneromooo-monero) 8f8cc09b contrib: add sync_info to rlwrap command set (moneromooo-monero) 70b8c6d7 cryptonote_protocol: misc fixes to the new sync algorithm (moneromooo-monero)
2017-08-23print peer id in 0 padded hex for consistencymoneromooo-monero1-0/+12
2017-08-22http_client: add getters for host and portmoneromooo-monero1-0/+3
2017-08-22contrib: add sync_info to rlwrap command setmoneromooo-monero1-0/+1
2017-08-22Simplify readline supportHoward Chu3-140/+85
And don't use std::mutex
2017-08-16abstract_tcp_server2: improve tracking/cancelling of early connectionsmoneromooo-monero2-22/+15
We don't actually need to keep them past the call to start, as this adds them to the config object list, and so they'll then be cancelled already when the stop signal arrives. This allows removing the periodic call to cleanup connections.
2017-08-16Construct on first use for completion_commandsJethro Grassie2-15/+23
2017-08-16Add sync lock on stopJethro Grassie1-5/+4
Also added and moved two free's hoping to fix leaks.
2017-08-15Merge pull request #2236Riccardo Spagni1-1/+1
cb2d5110 Tweak net logs so we get more info on why networking can't start (moneromooo-monero)
2017-08-15Tweak net logs so we get more info on why networking can't startmoneromooo-monero1-1/+1
This should prevent "silent" failures to start
2017-08-15Merge pull request #2253Riccardo Spagni1-2/+2
51ebedb8 epee: remove a couple unused locals (moneromooo-monero)
2017-08-15Merge pull request #2240Riccardo Spagni1-11/+16
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero) fa23a500 wallet2: add a is_synced function (moneromooo-monero) f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
2017-08-15Merge pull request #2237Riccardo Spagni2-5/+17
5d4ef719 core: speed up output index unique set calculation (moneromooo-monero) 19d7f568 perf_timer: allow profiling more granular than millisecond (moneromooo-monero) bda8c598 epee: add nanosecond timer and pause/restart profiling macros (moneromooo-monero)
2017-08-09epee: fixup KV_SERIALIZE_OPT to work in more casesmoneromooo-monero1-1/+4
2017-08-07Merge pull request #2189Riccardo Spagni1-1/+1
335fc8ab mlog: fix crash accessing stale data when rotating logs (moneromooo-monero)
2017-08-07Merge pull request #2149Riccardo Spagni1-0/+14
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero) f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero) 90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero) 84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero) 5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
2017-08-07Merge pull request #2220Riccardo Spagni1-3/+0
c6ba7d11 p2p: move m_in_timedsync from connection_context to p2p_connection_context (moneromooo-monero)
2017-08-07Merge pull request #2201Riccardo Spagni1-0/+7
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero) 5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
2017-08-07Merge pull request #2197Riccardo Spagni1-13/+24
d75cff1a Fix readline prompt when command does not output (Jethro Grassie)
2017-08-07Merge pull request #2195Riccardo Spagni2-1/+2
599436a4 mlog: default to msgwriter logs only for log level 1 (moneromooo-monero) 58f3fc68 Make msgwriter logs go to file only (moneromooo-monero)
2017-08-07Merge pull request #2151Riccardo Spagni1-1/+1
13a8d64f epee: don't send the body of the response to a HEAD HTTP request (Guillaume LE VAILLANT)
2017-08-07Merge pull request #2153Riccardo Spagni6-9/+9
35d68b2c Fix spelling errors (Erik de Castro Lopo)
2017-08-07cryptonote_protocol_handler: sync speedupmoneromooo-monero1-0/+14
A block queue is now placed between block download and block processing. Blocks are now requested only from one peer (unless starved). Includes a new sync_info coommand.
2017-08-05epee: remove a couple unused localsmoneromooo-monero1-2/+2
2017-08-02simplewallet: add (out of sync) or (no daemon) markers in the promptmoneromooo-monero1-11/+16
Should help people who don't realize why they haven't seen their monero yet.
2017-08-01p2p: move m_in_timedsync from connection_context to p2p_connection_contextmoneromooo-monero1-3/+0
It's got no place in the base class as it's P2P specific field
2017-08-01epee: add nanosecond timer and pause/restart profiling macrosmoneromooo-monero2-5/+17
Nanosecond timer precision won't work on Windows, but we don't care since I'm using that just for profiling incremental code paths, but a Windows coder is welcome to add it if there's a way.
2017-07-24epee: add a KV_SERIALIZE variant for optional parametersmoneromooo-monero1-0/+7
2017-07-24Fix readline prompt when command does not outputJethro Grassie1-13/+24
2017-07-24mlog: default to msgwriter logs only for log level 1moneromooo-monero1-1/+1
There might be privacy issues doing it by default
2017-07-24Make msgwriter logs go to file onlymoneromooo-monero1-0/+1
This was the case for monero-wallet-cli already, but not for monerod, which was making it pretty spammy as it was duplicating intended output. Since my original intent was to ensure logs included command output for debugging, this achieves both.
2017-07-22mlog: fix crash accessing stale data when rotating logsmoneromooo-monero1-1/+1
2017-07-19Merge pull request #2159Riccardo Spagni3-16/+74
6955976b Add various readline related fixes (Jethro Grassie)
2017-07-19Merge pull request #2157Riccardo Spagni1-0/+1
6a23cd07 Add notification on stop (Jethro Grassie)
2017-07-19Merge pull request #2173Riccardo Spagni1-1/+1
a02d7458 mlog: make MONERO_LOGS env var understand N,logs type spec (moneromooo-monero)
2017-07-19Merge pull request #2154Riccardo Spagni1-2/+2
97069380 mlog: add msgwriter:INFO to log 0 and 1 defaults (moneromooo-monero)
2017-07-19Merge pull request #2131Riccardo Spagni1-3/+3
a04faf56 abstract_tcp_server2: guard against accessing lock on a destroyed object (moneromooo-monero)
2017-07-15mlog: make MONERO_LOGS env var understand N,logs type specmoneromooo-monero1-1/+1
2017-07-09Add various readline related fixesJethro Grassie3-16/+74
- Add missing unbind key - Fix colored messages - Add command completion - Preserve last command input - Fix cursor position issues - Fix trailing whitespace in commands - Synchronize set_prompt
2017-07-07Add notification on stopJethro Grassie1-0/+1
2017-07-06mlog: add msgwriter:INFO to log 0 and 1 defaultsmoneromooo-monero1-2/+2
This ensures command output gets logged by default
2017-07-05epee: don't send the body of the response to a HEAD HTTP requestGuillaume LE VAILLANT1-1/+1
According to the HTTP spec: "The HEAD method is identical to GET except that the server MUST NOT return a message-body in the response".
2017-07-05Fix spelling errorsErik de Castro Lopo6-9/+9
2017-07-03Merge pull request #2130Riccardo Spagni1-15/+20
a0d2c745 Fix issue #2119 SEGV (Howard Chu)
2017-07-03Merge pull request #2122Riccardo Spagni1-1/+0
a282c575 Fix #2071: remove declaration of unused variable "it" in epee (binaryFate)
2017-07-03Merge pull request #2116Riccardo Spagni1-0/+21
841231e5 Add fuzz testing using american fuzzy lop (moneromooo-monero)
2017-07-03Merge pull request #2112Riccardo Spagni1-5/+16
76043b17 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero) a73a42a6 monero-wallet-cli: hang on exit in readline code (#2117) (moneromooo-monero) be9d4f04 Fix multiline wallet cli output with readline (Jethro Grassie)
2017-07-03Merge pull request #2098Riccardo Spagni2-3/+10
fdccf7e6 Add readline improvements (Jethro Grassie)
2017-07-01Fix issue #2119 SEGVHoward Chu1-15/+20
Due to bad refactoring in PR #2073. timeout_handler() doesn't work as a virtual function.
2017-06-28monero-wallet-cli: hang on exit in readline code (#2117)moneromooo-monero1-3/+2
readline_buffer: move a local to local scope Also limit the select fd limit to what we use Signed-off-by: Jethro Grassie <jtg@xtrabass.com>
2017-06-28monero-wallet-cli: hang on exit in readline code (#2117)moneromooo-monero1-2/+10
readline_buffer: fix start/stop threads being starved by process process could run for quite some time re-acquiring the process lock, leaving start/stop starving. Yielding after unlock in process is much better but doesn't seem to be enough to reliably yield, so we sleep for a millisecond, which should be transparent for user input anyway. Signed-off-by: Jethro Grassie <jtg@xtrabass.com>
2017-06-28abstract_tcp_server2: guard against accessing lock on a destroyed objectmoneromooo-monero1-3/+3
2017-06-28Remove typeid use in network_addressmoneromooo-monero1-3/+2
Since I had to add an ID to the derived classes anyway, this can be used instead. This removes an apparently pointless warning from CLANG too.
2017-06-26Fix #2071: remove declaration of unused variable "it" in epeebinaryFate1-1/+0
2017-06-25Fix multiline wallet cli output with readlineJethro Grassie1-1/+5
monero-wallet-cli commands which have multine output sometimes causes issues with the readline support. This patch fixes show_transfers, payments and incoming_transfers.
2017-06-24Add fuzz testing using american fuzzy lopmoneromooo-monero1-0/+21
Existing tests: block, transaction, signature, cold outputs, cold transaction. Data for these is in tests/data/fuzz. A convenience shell script is in contrib/fuzz_testing/fuzz.sh, eg: contrib/fuzz_testing/fuzz.sh signature The fuzzer will run indefinitely, ^C to stop. Fuzzing is currently supported for GCC only. I can't get CLANG to build Monero here as it dies on some system headers, so if someone wants to make it work on both, that'd be great. In particular, the __AFL_LOOP construct should be made to work so that a given run can fuzz multiple inputs, as the C++ load time is substantial.
2017-06-24Add readline improvementsJethro Grassie2-3/+10
Color prompt now working and no reprompting on exit command.
2017-06-24Merge pull request #2111Riccardo Spagni1-1/+1
8261ba69 readline_buffer: fix busy wait (moneromooo-monero)
2017-06-24Merge pull request #2103Riccardo Spagni2-4/+4
21b939e1 readline: fix invalid memory access (moneromooo-monero) 5f8f2905 readline_buffer: add a couple const (moneromooo-monero)
2017-06-24Merge pull request #2073Riccardo Spagni2-9/+49
07c4276c Don't issue a new timedsync while one is already in progress (Howard Chu) cf3a376c Don't timeout a slow operation that's making progress (Howard Chu) 340830de Fix PR#2039 (Howard Chu)
2017-06-23readline_buffer: fix busy waitmoneromooo-monero1-1/+1
It'd eat up a core constantly, due to spending its time jumping back and forth between userland and kernel. We now wait for up to a millisecond in kernel, which will be transparent to the user and drop to idle most of the time.
2017-06-21readline: fix invalid memory accessmoneromooo-monero1-1/+1
m_cout_buf was not initialized
2017-06-21readline_buffer: add a couple constmoneromooo-monero2-3/+3
2017-06-19net_utils_base: added missing template keywordkenshi841-1/+1
2017-06-18Add readline support to clijethro4-1/+283
This PR adds readline support to the daemon and monero-wallet-cli. Only GNU readline is supported (e.g. not libedit) and there are cmake checks to ensure this. There is a cmake variable, Readline_ROOT_DIR that can specify a directory to find readline, otherwise some default paths are searched. There is also a cmake option, USE_READLINE, that defaults to ON. If set to ON, if readline is not found, the build continues but without readline support. One negative side effect of using readline is that the color prompt in the wallet-cli now has no color and just uses terminal default. I know how to fix this but it's quite a big change so will tackle another time.
2017-06-18Merge pull request #2052Riccardo Spagni8-26/+122
072102cf abstracted nework addresses (moneromooo-monero)
2017-06-15Don't issue a new timedsync while one is already in progressHoward Chu1-0/+3
A timedsync is issued every minute on a connection, but the input tineout is 2 minutes. This means a new sync request could be issued while a slow sync request was already in progress. The additional request will further clog the network on a slow connection, and cause a premature timeout.
2017-06-15Don't timeout a slow operation that's making progressHoward Chu1-9/+46
If we got at least MIN_BYTES_WANTED (default 512) during any network poll, reset the timeout to allow more time for data to arrive.