aboutsummaryrefslogtreecommitdiff
path: root/contrib (follow)
AgeCommit message (Collapse)AuthorFilesLines
2020-03-06cppzmq: remove leftoversselsta1-15/+0
2020-02-28Merge pull request #6255Alexander Blair1-3/+3
81494e3f depends: empty spaces in PATH variable cause build failure (kozyilmaz)
2020-02-28Merge pull request #6220Alexander Blair6-56/+53
a9bdc6e4 Improved performance for epee serialization: (Lee Clagett)
2020-02-28Merge pull request #6205Alexander Blair1-1/+1
021cf733 ssl: server-side: allow multiple version of TLS (Bertrand Jacquin)
2020-02-06Merge pull request #6184Alexander Blair1-0/+42
2d1afceb net_ssl: load default certificates in CA mode on Windows (moneromooo-monero)
2020-02-06Merge pull request #6182Alexander Blair2-2/+2
e896cca8 epee: reorder a couple init list fields to match declaration (moneromooo-monero)
2020-01-26network: log traffic and add a simple traffic analysis scriptmoneromooo-monero1-5/+43
2020-01-24Merge pull request #6160Alexander Blair1-1/+1
bd6a5778 Gitian: Fix sigs generation (TheCharlatan)
2020-01-16Merge pull request #6143Alexander Blair1-0/+2
6efeefbc epee: set application/json MIME type on json errors (moneromooo-monero)
2020-01-16Merge pull request #6133Alexander Blair1-1/+1
b2ad757f Replace memset with memwipe. (Bert Peters)
2020-01-16Merge pull request #6125Alexander Blair1-1/+8
584d057f epee: fix console_handlers_binder race, wait for thread to finish (xiphon)
2020-01-16Merge pull request #6120Alexander Blair1-1/+3
feef1c6a epee: fix peer ids being truncated on display (moneromooo-monero)
2019-12-19depends: empty spaces in PATH variable cause build failurekozyilmaz1-3/+3
2019-12-12depends: update libsodium to 1.0.18TheCharlatan2-4/+4
2019-12-03ssl: server-side: allow multiple version of TLSBertrand Jacquin1-1/+1
boost::asio::ssl::context is created using specifically TLSv1.2, which blocks the ability to use superior version of TLS like TLSv1.3. Filtering is also made specially later in the code to remove unsafe version for TLS such SSLv2, SSLv3 etc.. This change is removing double filtering to allow TLSv1.2 and above to be used. testssl.sh 3.0rc5 now reports the following (please note monerod was built with USE_EXTRA_EC_CERT): $ ./testssl.sh --openssl=/usr/bin/openssl \ --each-cipher --cipher-per-proto \ --server-defaults --server-preference \ --vulnerable --heartbleed --ccs --ticketbleed \ --robot --renegotiation --compression --breach \ --poodle --tls-fallback --sweet32 --beast --lucky13 \ --freak --logjam --drown --pfs --rc4 --full \ --wide --hints 127.0.0.1:38081 Using "OpenSSL 1.1.1d 10 Sep 2019" [~80 ciphers] on ip-10-97-15-6:/usr/bin/openssl (built: "Dec 3 21:14:51 2019", platform: "linux-x86_64") Start 2019-12-03 21:51:25 -->> 127.0.0.1:38081 (127.0.0.1) <<-- rDNS (127.0.0.1): -- Service detected: HTTP Testing protocols via sockets except NPN+ALPN SSLv2 not offered (OK) SSLv3 not offered (OK) TLS 1 not offered TLS 1.1 not offered TLS 1.2 offered (OK) TLS 1.3 offered (OK): final NPN/SPDY not offered ALPN/HTTP2 not offered Testing for server implementation bugs No bugs found. Testing cipher categories NULL ciphers (no encryption) not offered (OK) Anonymous NULL Ciphers (no authentication) not offered (OK) Export ciphers (w/o ADH+NULL) not offered (OK) LOW: 64 Bit + DES, RC[2,4] (w/o export) not offered (OK) Triple DES Ciphers / IDEA not offered (OK) Average: SEED + 128+256 Bit CBC ciphers not offered Strong encryption (AEAD ciphers) offered (OK) Testing robust (perfect) forward secrecy, (P)FS -- omitting Null Authentication/Encryption, 3DES, RC4 PFS is offered (OK), ciphers follow (client/browser support is important here) Hexcode Cipher Suite Name (OpenSSL) KeyExch. Encryption Bits Cipher Suite Name (IANA/RFC) ----------------------------------------------------------------------------------------------------------------------------- x1302 TLS_AES_256_GCM_SHA384 ECDH 253 AESGCM 256 TLS_AES_256_GCM_SHA384 x1303 TLS_CHACHA20_POLY1305_SHA256 ECDH 253 ChaCha20 256 TLS_CHACHA20_POLY1305_SHA256 xc030 ECDHE-RSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 xc02c ECDHE-ECDSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 xcca9 ECDHE-ECDSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 xcca8 ECDHE-RSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 x1301 TLS_AES_128_GCM_SHA256 ECDH 253 AESGCM 128 TLS_AES_128_GCM_SHA256 xc02f ECDHE-RSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 xc02b ECDHE-ECDSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 Elliptic curves offered: prime256v1 secp384r1 secp521r1 X25519 X448 Testing server preferences Has server cipher order? yes (OK) Negotiated protocol TLSv1.3 Negotiated cipher TLS_AES_256_GCM_SHA384, 253 bit ECDH (X25519) Cipher order TLSv1.2: ECDHE-ECDSA-CHACHA20-POLY1305 ECDHE-ECDSA-AES256-GCM-SHA384 ECDHE-ECDSA-AES128-GCM-SHA256 ECDHE-RSA-CHACHA20-POLY1305 ECDHE-RSA-AES256-GCM-SHA384 ECDHE-RSA-AES128-GCM-SHA256 TLSv1.3: TLS_AES_256_GCM_SHA384 TLS_CHACHA20_POLY1305_SHA256 TLS_AES_128_GCM_SHA256 Testing server defaults (Server Hello) TLS extensions (standard) "renegotiation info/#65281" "EC point formats/#11" "supported versions/#43" "key share/#51" "max fragment length/#1" "extended master secret/#23" Session Ticket RFC 5077 hint no -- no lifetime advertised SSL Session ID support yes Session Resumption Tickets no, ID: no TLS clock skew Random values, no fingerprinting possible Server Certificate #1 (in response to request w/o SNI) Signature Algorithm SHA256 with RSA Server key size RSA 4096 bits Server key usage -- Server extended key usage -- Serial / Fingerprints 01 / SHA1 132E42981812F5575FA0AE64922B18A81B38C03F SHA256 EBA3CC4AA09DEF26706E64A70DB4BC8D723533BB67EAE12B503A845019FB61DC Common Name (CN) (no CN field in subject) subjectAltName (SAN) missing (NOT ok) -- Browsers are complaining Issuer Trust (hostname) certificate does not match supplied URI Chain of trust NOT ok (self signed) EV cert (experimental) no "eTLS" (visibility info) not present Certificate Validity (UTC) 181 >= 60 days (2019-12-03 21:51 --> 2020-06-02 21:51) # of certificates provided 1 Certificate Revocation List -- OCSP URI -- NOT ok -- neither CRL nor OCSP URI provided OCSP stapling not offered OCSP must staple extension -- DNS CAA RR (experimental) not offered Certificate Transparency -- Server Certificate #2 (in response to request w/o SNI) Signature Algorithm ECDSA with SHA256 Server key size EC 256 bits Server key usage -- Server extended key usage -- Serial / Fingerprints 01 / SHA1 E17B765DD8124525B1407E827B89A31FB167647D SHA256 AFB7F44B1C33831F521357E5AEEB813044CB02532143E92D35650A3FF792A7C3 Common Name (CN) (no CN field in subject) subjectAltName (SAN) missing (NOT ok) -- Browsers are complaining Issuer Trust (hostname) certificate does not match supplied URI Chain of trust NOT ok (self signed) EV cert (experimental) no "eTLS" (visibility info) not present Certificate Validity (UTC) 181 >= 60 days (2019-12-03 21:51 --> 2020-06-02 21:51) # of certificates provided 1 Certificate Revocation List -- OCSP URI -- NOT ok -- neither CRL nor OCSP URI provided OCSP stapling not offered OCSP must staple extension -- DNS CAA RR (experimental) not offered Certificate Transparency -- Testing HTTP header response @ "/" HTTP Status Code 404 Not found (Hint: supply a path which doesn't give a "404 Not found") HTTP clock skew Got no HTTP time, maybe try different URL? Strict Transport Security not offered Public Key Pinning -- Server banner Epee-based Application banner -- Cookie(s) (none issued at "/") -- maybe better try target URL of 30x Security headers -- Reverse Proxy banner -- Testing vulnerabilities Heartbleed (CVE-2014-0160) not vulnerable (OK), no heartbeat extension CCS (CVE-2014-0224) not vulnerable (OK) Ticketbleed (CVE-2016-9244), experiment. not vulnerable (OK), no session ticket extension ROBOT Server does not support any cipher suites that use RSA key transport Secure Renegotiation (CVE-2009-3555) not vulnerable (OK) Secure Client-Initiated Renegotiation not vulnerable (OK) CRIME, TLS (CVE-2012-4929) not vulnerable (OK) BREACH (CVE-2013-3587) no HTTP compression (OK) - only supplied "/" tested POODLE, SSL (CVE-2014-3566) not vulnerable (OK) TLS_FALLBACK_SCSV (RFC 7507) No fallback possible, no protocol below TLS 1.2 offered (OK) SWEET32 (CVE-2016-2183, CVE-2016-6329) not vulnerable (OK) FREAK (CVE-2015-0204) not vulnerable (OK) DROWN (CVE-2016-0800, CVE-2016-0703) not vulnerable on this host and port (OK) make sure you don't use this certificate elsewhere with SSLv2 enabled services https://censys.io/ipv4?q=EBA3CC4AA09DEF26706E64A70DB4BC8D723533BB67EAE12B503A845019FB61DC could help you to find out LOGJAM (CVE-2015-4000), experimental not vulnerable (OK): no DH EXPORT ciphers, no DH key detected with <= TLS 1.2 BEAST (CVE-2011-3389) no SSL3 or TLS1 (OK) LUCKY13 (CVE-2013-0169), experimental not vulnerable (OK) RC4 (CVE-2013-2566, CVE-2015-2808) no RC4 ciphers detected (OK) Testing ciphers per protocol via OpenSSL plus sockets against the server, ordered by encryption strength Hexcode Cipher Suite Name (OpenSSL) KeyExch. Encryption Bits Cipher Suite Name (IANA/RFC) ----------------------------------------------------------------------------------------------------------------------------- SSLv2 SSLv3 TLS 1 TLS 1.1 TLS 1.2 xc030 ECDHE-RSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 xc02c ECDHE-ECDSA-AES256-GCM-SHA384 ECDH 253 AESGCM 256 TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384 xcca9 ECDHE-ECDSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 xcca8 ECDHE-RSA-CHACHA20-POLY1305 ECDH 253 ChaCha20 256 TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 xc02f ECDHE-RSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 xc02b ECDHE-ECDSA-AES128-GCM-SHA256 ECDH 253 AESGCM 128 TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 TLS 1.3 x1302 TLS_AES_256_GCM_SHA384 ECDH 253 AESGCM 256 TLS_AES_256_GCM_SHA384 x1303 TLS_CHACHA20_POLY1305_SHA256 ECDH 253 ChaCha20 256 TLS_CHACHA20_POLY1305_SHA256 x1301 TLS_AES_128_GCM_SHA256 ECDH 253 AESGCM 128 TLS_AES_128_GCM_SHA256 Running client simulations (HTTP) via sockets Browser Protocol Cipher Suite Name (OpenSSL) Forward Secrecy ------------------------------------------------------------------------------------------------ Android 4.2.2 No connection Android 4.4.2 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Android 5.0.0 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 256 bit ECDH (P-256) Android 6.0 TLSv1.2 ECDHE-RSA-AES128-GCM-SHA256 256 bit ECDH (P-256) Android 7.0 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Android 8.1 (native) No connection Android 9.0 (native) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) Chrome 65 Win 7 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Chrome 74 (Win 10) No connection Firefox 62 Win 7 TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) Firefox 66 (Win 8.1/10) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) IE 6 XP No connection IE 7 Vista No connection IE 8 Win 7 No connection IE 8 XP No connection IE 11 Win 7 No connection IE 11 Win 8.1 No connection IE 11 Win Phone 8.1 No connection IE 11 Win 10 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Edge 15 Win 10 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 253 bit ECDH (X25519) Edge 17 (Win 10) TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 253 bit ECDH (X25519) Opera 60 (Win 10) No connection Safari 9 iOS 9 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Safari 9 OS X 10.11 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Safari 10 OS X 10.12 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Apple ATS 9 iOS 9 TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Tor 17.0.9 Win 7 No connection Java 6u45 No connection Java 7u25 No connection Java 8u161 TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) Java 9.0.4 TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.0.1l TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.0.2e TLSv1.2 ECDHE-ECDSA-AES256-GCM-SHA384 256 bit ECDH (P-256) OpenSSL 1.1.0j (Debian) TLSv1.2 ECDHE-RSA-CHACHA20-POLY1305 253 bit ECDH (X25519) OpenSSL 1.1.1b (Debian) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519) Thunderbird (60.6) TLSv1.3 TLS_AES_256_GCM_SHA384 253 bit ECDH (X25519)
2019-11-26net_ssl: load default certificates in CA mode on Windowsmoneromooo-monero1-0/+42
Because it always does things wonkily doens't it
2019-11-25epee: reorder a couple init list fields to match declarationmoneromooo-monero2-2/+2
This is a bug waiting to happen
2019-11-20Merge pull request #6117luigi11111-6/+5
0f7c9f4 Gitian Readme: adding android signing & fix v0.15 checksum. (jonathancross)
2019-11-20Gitian: Fix sigs generationTheCharlatan1-1/+1
2019-11-18Merge pull request #6118luigi111136-172/+410
gitian: add FreeBSD support (75c5a04, 607c01a, cca6e5c, 35b5e91, 024a1c7, b14d9ab, 5eea312, 9cbba5a, 2e435df, abeed9a) (hyc)
2019-11-18"Fix" non-determinism in native_cctools buildHoward Chu2-0/+16
By omitting the otool binary which is built non-deterministically. We don't use it anyway.
2019-11-17Fixup compiled python in OSXHoward Chu1-1/+1
2019-11-17Fix unwind library orderingHoward Chu2-0/+16
Sort objects being archived
2019-11-17Fixup sodium darwinHoward Chu3-31/+2
get rid of sodium-darwin.mk special case, unify back with sodium.mk
2019-11-17Use standard time for depends cachesHoward Chu5-66/+59
streamline, remove obsolete wrappers
2019-11-17Add ARFLAGSHoward Chu23-20/+89
Needed to invoke deterministic mode on some archivers
2019-11-15epee: set application/json MIME type on json errorsmoneromooo-monero1-0/+2
2019-11-14epee: fix peer ids being truncated on displaymoneromooo-monero1-1/+3
2019-11-14gitian: add FreeBSDHoward Chu2-17/+145
2019-11-14depends: Add FreeBSD supportHoward Chu9-14/+68
2019-11-14gitian: Parametrize target platformsHoward Chu1-30/+25
2019-11-13Replace memset with memwipe.Bert Peters1-1/+1
2019-11-12epee: fix console_handlers_binder race, wait for thread to finishxiphon1-1/+8
2019-11-11epee: close connection when the peer has done somoneromooo-monero1-1/+7
This fixes rapid reconnections failing as the peer hasn't yet worked out the other side is gone, and will reject "duplicate" connections until a timeout.
2019-11-11gitian: Update to latest gitian-builderHoward Chu1-5/+1
2019-11-11Gitian Readme: adding android signing & fix v0.15 checksum.Jonathan Cross1-6/+5
2019-11-04Merge pull request #6088Riccardo Spagni1-1/+1
e8c5ab515 gitian: fix out dir location (iDunk5400)
2019-11-04gitian: fix out dir locationiDunk54001-1/+1
2019-11-04Copy LICENSE to all archivesHoward Chu4-3/+13
2019-11-04Improved performance for epee serialization:Lee Clagett6-56/+53
- Removed copy of field names in binary deserialization - Removed copy of array values in binary deserialization - Removed copy of string values in json deserialization - Removed unhelpful allocation in json string value parsing - Removed copy of blob data on binary and json serialization
2019-11-04depends: fix typo in packagesselsta1-1/+1
2019-11-03Merge pull request #6074Riccardo Spagni1-4/+16
38f691048 simplewallet: plug a timing leak (moneromooo-monero) dcff02e4c epee: allow a random component in once_a_time timeouts (moneromooo-monero) e10833024 wallet: reuse cached height when set after refresh (moneromooo-monero) 5956beaa1 wallet2: fix is_synced checking target height, not height (moneromooo-monero) fd35e2304 wallet: fix another facet of "did I get some monero" information leak (moneromooo-monero) d5472bd87 wallet2: do not send an unnecessary last getblocks.bin call on refresh (moneromooo-monero) 97ae7bb5c wallet2: do not repeatedly ask for pool txes sent to us (moneromooo-monero)
2019-11-03Merge pull request #6077Riccardo Spagni13-21/+329
240dbb124 gitian: add --rebuild option (Howard Chu) 643860776 Add Android support (Howard Chu)
2019-11-03gitian: add --rebuild optionHoward Chu2-12/+48
Avoids delays when sourceforge is slow to respond; allows rebuilding when disconnected from networks.
2019-11-03Add Android supportHoward Chu12-9/+281
2019-11-03Fix readline buildHoward Chu4-5/+6630
Make sure it links to our libtinfo from our ncurses build. Hardcode some basic terminal descriptions into our libtinfo. Re-enable $HOME/.terminfo support to allow user customization. Use unlikely terminfo-dir, to prevent accidentally using differently-configured system databases.
2019-11-02Adding support for hidden (anonymity) txpoolLee Clagett1-1/+2
2019-11-02Merge pull request #6079Riccardo Spagni1-3/+3
e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
2019-11-020.15.0.0 release engineeringRiccardo Spagni1-3/+3
2019-11-01epee: allow a random component in once_a_time timeoutsmoneromooo-monero1-4/+16
2019-11-01Merge pull request #6059Riccardo Spagni3-3/+3
45b6b6038 Updating gitian yml files for v0.15 (Jonathan Cross)
2019-10-31Updating gitian yml files for v0.15Jonathan Cross3-3/+3
2019-10-25Merge pull request #6022luigi11112-4/+4
dd28383 depends: bump cppzmq version to 4.4.1 (anonimal) 157b3fc depends: bump zeromq version to 4.1.7 (anonimal)
2019-10-25Merge pull request #5357luigi11115-8/+51
b3a9a4d add a quick early out to get_blocks.bin when up to date (moneromooo-monero) 2899379 daemon, wallet: new pay for RPC use system (moneromooo-monero) ffa4602 simplewallet: add public_nodes command (moneromooo-monero)
2019-10-25daemon, wallet: new pay for RPC use systemmoneromooo-monero5-8/+51
Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
2019-10-25depends: bump zeromq version to 4.1.7anonimal1-2/+2
Resolves https://hackerone.com/reports/652911
2019-10-25depends: bump cppzmq version to 4.4.1anonimal1-2/+2
2019-10-24Merge pull request #6006luigi11111-2/+6
9f3be3b epee: use SO_REUSEADDR on non-Windows targets (xiphon)
2019-10-22epee: use SO_REUSEADDR on non-Windows targetsxiphon1-2/+6
2019-10-22Merge pull request #5996luigi11112-2/+11
23ba69e epee: fix SSL server handshake, run_one() can block, use poll_one() (xiphon)
2019-10-22Merge pull request #5986luigi11111-1/+1
1080136 abstract_tcp_server2: move 'Trying to connect' from error to debug (moneromooo-monero)
2019-10-22Merge pull request #5966luigi11113-1/+53
be82c40 Support median block size > 4 GB (moneromooo-monero)
2019-10-21Support median block size > 4 GBmoneromooo-monero3-1/+53
add a 128/64 division routine so we can use a > 32 bit median block size in calculations
2019-10-18epee: fix SSL server handshake, run_one() can block, use poll_one()xiphon2-2/+11
2019-10-16Merge pull request #5911luigi11111-0/+5
e48dcb7 levin: armour against some 'should not happen' case (moneromooo-monero)
2019-10-15levin: armour against some "should not happen" casemoneromooo-monero1-0/+5
If adding a response handler after the protocol is released, they could never be cancelled again, and would end up keeping a ref that never goes away
2019-10-14Merge pull request #5947luigi11111-4/+2
c9cfbf7 epee: tcp server - set SO_LINGER instead of SO_REUSEADDR option (xiphon)
2019-10-14Merge pull request #5937luigi11111-1/+1
4b654f6 abstract_tcp_server2: log pointer, not contents, where appropriate (moneromooo-monero)
2019-10-14abstract_tcp_server2: move "Trying to connect" from error to debugmoneromooo-monero1-1/+1
and fix the message grammar
2019-10-08Merge pull request #5936luigi11111-2/+2
24473d7 build: fix MinGW GUI dependencies build (xiphon)
2019-10-08Merge pull request #5918luigi11113-5/+30
4371791 epee: implement handshake timeout for SSL connections (xiphon)
2019-10-08Merge pull request #5917luigi11111-1/+2
7d81850 epee: fix network timeouts in blocked_mode_client (xiphon)
2019-10-02epee: tcp server - set SO_LINGER instead of SO_REUSEADDR optionxiphon1-4/+2
2019-09-30Merge pull request #5910luigi11111-0/+5
1b91beb abstract_tcp_server2: fix lingering connections (moneromooo-monero)
2019-09-30Merge pull request #5893luigi11112-1/+15
Coverity fixes [3a81639, 1bd962d, 2825f07, d099658, d46f701, cd57a10] (anonimal)
2019-09-30Merge pull request #5653luigi11111-28/+37
5f8524e Streamline build setup (hyc)
2019-09-27abstract_tcp_server2: log pointer, not contents, where appropriatemoneromooo-monero1-1/+1
2019-09-26build: fix MinGW GUI dependencies buildxiphon1-2/+2
2019-09-25Don't set ARCH_ID if it's already setHoward Chu1-3/+5
Usually it's unset, but depends toolchain files set it explicitly for cross-compiling. Don't override preset values. But make sure it's set for all x86 / x86_64 builds, not just Linux. Also make sure -std=c++11 is set for Darwin builds, not all submodules were getting it consistently before.
2019-09-24Streamline build setupHoward Chu1-28/+37
Use shorter, prefix-unique directory names gitian-builder -> builder gitian-sigs -> sigs monero-binaries -> out Just use builder/inputs/monero, no need for 2nd repo clone
2019-09-24epee: misc_log_ex.h can now be used in C codemoneromooo-monero2-11/+51
use mfatal/merror/mwarning/minfo/mdebug/mtrace
2019-09-24Merge pull request #5892luigi11114-7/+13
ab2819a depends: attempt to fix readline (iDunk5400)
2019-09-24Merge pull request #5891luigi11111-6/+6
e09dbc6 depends: fix monero binaries Boost linking errors (iDunk5400)
2019-09-24Merge pull request #5875luigi11111-0/+1
0c55837 contrib: add a suppressions file for leak sanitizer (moneromooo-monero)
2019-09-17epee: implement handshake timeout for SSL connectionsxiphon3-5/+30
2019-09-16epee: fix network timeouts in blocked_mode_clientxiphon1-1/+2
2019-09-16Properly format multiline logsmoneromooo-monero2-22/+58
As a side effect, colouring on Windows should now work regardless of version
2019-09-14Merge pull request #5898luigi11111-1/+1
73f22c4 depends: fix MacOS build with Clang 3.7.1 (vtnerd)
2019-09-12abstract_tcp_server2: fix lingering connectionsmoneromooo-monero1-0/+5
Resetting the timer after shutdown was initiated would keep a reference to the object inside ASIO, which would keep the connection alive until the timer timed out
2019-09-09depends: fix monero binaries Boost linking errorsiDunk54001-6/+6
It would try to link against host system Boost libs when building outside gitian. Tested with x86_64-linux-gnu target.
2019-09-08Merge pull request #5858luigi11111-1/+1
5f4bd92 Fix Travis build on Windows + Mac (hyperreality)
2019-09-08depends: fix MacOS build with Clang 3.7.1Lee Clagett1-1/+1
2019-09-08epee: abstract_tcp_server2: resolve CID 203919 (DC.WEAK_CRYPTO)anonimal1-1/+13
The problem actually exists in two parts: 1. When sending chunks over a connection, if the queue size is greater than N, the seed is predictable across every monero node. >"If rand() is used before any calls to srand(), rand() behaves as if it was seeded with srand(1). Each time rand() is seeded with the same seed, it must produce the same sequence of values." 2. The CID speaks for itself: "'rand' should not be used for security-related applications, because linear congruential algorithms are too easy to break." *But* this is an area of contention. One could argue that a CSPRNG is warranted in order to fully mitigate any potential timing attacks based on crafting chunk responses. Others could argue that the existing LCG, or even an MTG, would suffice (if properly seeded). As a compromise, I've used an MTG with a full bit space. This should give a healthy balance of security and speed without relying on the existing crypto library (which I'm told might break on some systems since epee is not (shouldn't be) dependent upon the existing crypto library).
2019-09-07depends: attempt to fix readlineiDunk54004-7/+13
Make readline actually compile, and make ncurses use existing terminfo data (if available).
2019-09-06epee: connection_basic: resolve CID 203916 (UNINIT_CTOR)anonimal1-0/+1
2019-09-06epee: connection_basic: resolve CID 203920 (UNINIT_CTOR)anonimal1-0/+1
2019-09-04Fix IP address serialization on big endianmoneromooo-monero1-1/+15
IP addresses are stored in network byte order even on little endian hosts
2019-09-04storages: fix "portable" storage on big endianmoneromooo-monero4-3/+99
2019-09-04storages: fix writing varints on big endianmoneromooo-monero1-1/+1
2019-09-04epee: fix local/loopback checks on big endianmoneromooo-monero1-0/+7
IPv4 addresses are kept in network byte order in memory
2019-09-04Merge pull request #5824luigi11111-1/+1
2a41dc0 epee: fix connections not being properly closed in some instances (moneromooo-monero)
2019-09-04Merge pull request #5814luigi11111-91/+0
bdcdb0e Remove unused code under WINDWOS_PLATFORM guard (tomsmeding) a84aa04 syncobj.h no longer defines shared_guard, so remove those define's (tomsmeding)
2019-09-04Merge pull request #5796luigi11111-3/+3
e3cff3d Gitian build script fixes for MacOS (jonathancross)
2019-09-04Merge pull request #5764luigi11113-4/+4
f26e663 Gitian build (mac, linux): gzip => bzip2 (jonathancross)
2019-09-04Merge pull request #5536luigi11113-13/+88
1a367d6 simplewallet: lock console on inactivity (moneromooo-monero)
2019-08-29contrib: add a suppressions file for leak sanitizermoneromooo-monero1-0/+1
with the Cryptonight per-thread buffer
2019-08-28simplewallet: lock console on inactivitymoneromooo-monero3-13/+88
2019-08-27Fix Travis build on Windows + Machyperreality1-1/+1
Following 13c0b8c, the unwind package is being attempted to be built on Windows and Mac when it should only be built on Linux.
2019-08-23syncobj.h no longer defines shared_guard, so remove those define'sTom Smeding1-3/+0
The removed preprocessor macro's refer to types that are not defined in the file anymore; the only other place where shared_guard is defined is in winobj.h, which also defines the same macro's. Therefore, this change is safe. (Side note is that these macro's weren't used at all anyway, but that is orthogonal to the issue.)
2019-08-21Merge pull request #5827luigi11111-1/+1
30779de fix feature not introduced until boost 1.66 (jtgrassie)
2019-08-21Merge pull request #5702luigi11115-1/+16
13c0b8c Add depends riscv 64 bit support (TheCharlatan)
2019-08-20Add depends riscv 64 bit supportTheCharlatan5-1/+16
2019-08-20fix feature not introduced until boost 1.66Jethro Grassie1-1/+1
2019-08-19Merge pull request #5706luigi11113-3/+25
9a5933f Gitian: Add version string to output tar archives (TheCharlatan)
2019-08-19Merge pull request #5705luigi11111-4/+4
59eecc7 Update icu4c to latest support version (TheCharlatan)
2019-08-19epee: fix connections not being properly closed in some instancesmoneromooo-monero1-1/+1
Fixed by Fixed by crCr62U0
2019-08-16epee: support unicode in parsed stringsmoneromooo-monero2-22/+61
2019-08-15Merge pull request #5756luigi11111-38/+78
28c3e73 gitian build README improvements (jonathancross)
2019-08-15Merge pull request #5674luigi11111-0/+24
fcbf7b3 p2p: propagate out peers limit to payload handler (moneromooo-monero) 098aadf p2p: close the right number of connections on setting max in/out peers (moneromooo-monero)
2019-08-15Merge pull request #5649luigi11112-2/+6
a182df2 Bans for RPC connections (hyc)
2019-08-15Remove unused code under WINDWOS_PLATFORM guardTom Smeding1-88/+0
This code has been present, unchanged, ever since the original move to github in 2014 with commit 296ae46ed.
2019-08-06Gitian build script fixes for MacOSJonathan Cross1-3/+3
2019-07-31Add IPv6 supportThomas Winget8-67/+461
new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.
2019-07-30gitian build README improvementsJonathan Cross1-38/+78
2019-07-24Merge pull request #5627luigi11112-21/+25
afbf05b Add option to run gitian-build.py on non-debian os (TheCharlatan)
2019-07-24Merge pull request #5531luigi11111-4/+8
9a6006b abstract_tcp_server2: move some things out of a lock (moneromooo-monero)
2019-07-24Merge pull request #5530luigi11113-7/+0
6abaaaa remove obsolete save_graph skeleton code (moneromooo-monero)
2019-07-24Merge pull request #5528luigi11111-1/+1
f61a315 net_utils: fix m_ssl type from time_t to bool (moneromooo-monero)
2019-07-18Gitian build (mac, linux): gzip => bzip2Jonathan Cross3-4/+4
2019-07-17Added support for "noise" over I1P/Tor to mask Tx transmission.Lee Clagett10-64/+289
2019-07-16Add ref-counted buffer byte_slice. Currently used for sending TCP data.Lee Clagett10-149/+445
2019-07-16allow blocking whole subnetsmoneromooo-monero3-2/+67
2019-07-12Merge pull request #5704luigi11111-3/+3
8f22279 Depends: Update HIDAPI version (TheCharlatan)
2019-06-27Gitian: Add version string to output tar archivesTheCharlatan3-3/+25
The tar archives generated by gitian are currently unversioned. This adds either a tag name when building from a tag, or a short commit id when building from a commit hash.
2019-06-27Depends: Update HIDAPI versionTheCharlatan1-3/+3
The macos binaries in release v0.14.1.0 were compiled with the buggy hidapi-0.8.0-rc1 version. This resulted in users not being able to use their Ledger with the latest cli wallet. After the patch depends now fetches the source from the libusb hidapi repository that has taken over maintenance of hidapi.
2019-06-27Update icu4c to latest support versionTheCharlatan1-9/+4
Before this commit the icu4c repo was fetched from TheCharlatan's repository. This step was made, because up until recently the source code was hosted on sourceforge and their downloads proved very unreliable. The origin is now the official icu4c repository. Also remove some commented lines left over from development.
2019-06-26Add option to run gitian-build.py on non-debian osTheCharlatan2-21/+25
This commits adds the `--no-apt` flag to the gitian-build.py script. This allows gitian builds to be run without root access and non-debian based operating systems.
2019-06-25Add ncurses package for linux and darwin readlineTheCharlatan4-14/+69
Readline support is now compiled with the ncurses backend.
2019-06-25Remove clutter in depends installed packagesTheCharlatan12-9/+42
To speedup the depends cached builds, remove some some clutter from the package files. This mainly incldues removing all the shared libraries and .la linker files. It also gives stronger guarantees that monero only links the static libs without any external rvalues.
2019-06-25Add debug targets to depends MakefileTheCharlatan2-0/+10
Packages can now be built individually and for each stage. This allows easier debugging.
2019-06-19p2p: close the right number of connections on setting max in/out peersmoneromooo-monero1-0/+24
2019-06-16Bans for RPC connectionsHoward Chu2-2/+6
Make bans control RPC sessions too. And auto-ban some bad requests. Drops HTTP connections whenever response code is 500.
2019-06-14ensure no NULL is passed to memcpymoneromooo-monero2-6/+14
NULL is valid when size is 0, but memcpy uses nonnull attributes, so let's not poke the bear
2019-06-14abstract_tcp_server2: improve DoS resistancemoneromooo-monero1-4/+5
2019-06-14epee: basic sanity check on allocation size from untrusted sourcemoneromooo-monero1-0/+1
Reported by guidov
2019-06-12Merge pull request #5632luigi11115-4/+8
3a0fbea Don't use -march=native (hyc) f8b2f25 Allow parallel make (hyc) 01ced20 Delete redundant cppzmq dependency (hyc) 1dc4ebf Use 9 digit build IDs (hyc)
2019-06-12Merge pull request #5552luigi11111-2/+2
c27d961 [depends] update openssl to 1.0.2r (who-biz)
2019-06-12Use 9 digit build IDsHoward Chu3-0/+3
2019-06-12Delete redundant cppzmq dependencyHoward Chu1-1/+1
2019-06-12Allow parallel makeHoward Chu3-3/+3
2019-06-12Don't use -march=nativeHoward Chu1-0/+1
2019-06-11Merge pull request #5618luigi11111-6/+4
b0a04f7 epee: fix SSL autodetect on reconnection (xiphon)
2019-06-10epee: fix SSL autodetect on reconnectionxiphon1-6/+4
2019-06-09Fix GCC 9.1 build warningsmoneromooo-monero1-0/+5
GCC wants operator= aand copy ctor to be both defined, or neither
2019-05-22Add ssl_options support to monerod's rpc mode.Lee Clagett1-0/+38
2019-05-18[depends] update openssl to 1.0.2rwho-biz1-2/+2
- This addresses https://www.openssl.org/news/secadv/20190226.txt (CVE: 2019-1559) which impacted all versions of openssl-1.0. Note that this does not address CVE-2019-1543 (https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-1543), which impacts all versions of openssl 1.1 through 1.1.0j and 1.1.1b. The above (1.1) is patched in openssl, where it was marked as low severity. Similar issues possibly present in monero, should be looked into w.r.t. CVE-2019-1543.
2019-05-15Merge pull request #5539Riccardo Spagni3-108/+138
3f612cda Changed odd bullet point to low level header (Rohaq) af9bc4ec Used subeaders to avoid slightly wonky looking formatting (Rohaq) 1873af35 Made code block usage consistent across all .md files (Rohaq) 68103075 Updated Copyright notice (Rohaq) 39bd157f Added Table of Contents to main README.md (Rohaq)
2019-05-14Merge pull request #5527luigi11111-2/+2
9a7a453 net_ssl: free certs after setting them up (moneromooo-monero)
2019-05-14Merge pull request #5519luigi11111-1/+1
b8b957d cmake: fix incorrect hint for OPENSSL_ROOT_DIR (moneromooo-monero) 367bb80 mlog: default to not showing SSL errors (moneromooo-monero)
2019-05-12Made code block usage consistent across all .md filesRohaq3-108/+138
2019-05-10abstract_tcp_server2: move some things out of a lockmoneromooo-monero1-4/+8
The lock is meant for the network throttle object only, and this should help coverity get unconfused
2019-05-10remove obsolete save_graph skeleton codemoneromooo-monero3-7/+0
2019-05-10net_utils: fix m_ssl type from time_t to boolmoneromooo-monero1-1/+1
2019-05-10net_ssl: free certs after setting them upmoneromooo-monero1-2/+2
2019-05-07Merge pull request #5509Riccardo Spagni2-4/+128
a62e0725 net_ssl: SSL config tweaks for compatibility and security (moneromooo-monero)
2019-05-07Merge pull request #5499Riccardo Spagni1-0/+236
a4c4a2d8 blockchain: keep a rolling long term block weight median (moneromooo-monero)
2019-05-07Merge pull request #5419Riccardo Spagni6-5/+87
f29fecd5 build: debug and test builds via contrib (Dusan Klinec)
2019-05-07net_ssl: SSL config tweaks for compatibility and securitymoneromooo-monero2-4/+128
add two RSA based ciphers for Windows/depends compatibility also enforce server cipher ordering also set ECDH to auto because vtnerd says it is good :) When built with the depends system, openssl does not include any cipher on the current whitelist, so add this one, which fixes the problem, and does seem sensible.
2019-05-06mlog: default to not showing SSL errorsmoneromooo-monero1-1/+1
2019-05-02blockchain: keep a rolling long term block weight medianmoneromooo-monero1-0/+236
2019-04-26change SSL certificate fingerprint whitelisting from SHA1 to SHA-256moneromooo-monero2-1/+3
SHA1 is too close to bruteforceable
2019-04-24Merge pull request #5482Riccardo Spagni1-0/+1
9956500d net_helper: clear recv buffer on eof (moneromooo-monero)
2019-04-24Merge pull request #5479Riccardo Spagni1-1/+1
edbae2d0 levin_protocol_handler_async: tune down preallocation a fair bit (moneromooo-monero)
2019-04-23net_helper: clear recv buffer on eofmoneromooo-monero1-0/+1
2019-04-22levin_protocol_handler_async: tune down preallocation a fair bitmoneromooo-monero1-1/+1
It can allocate a lot when getting a lot of connections (in particular, the stress test on windows apparently pushes that memory to actual use, rather than just allocated)
2019-04-21serialization: set default log categorymoneromooo-monero3-1/+7
2019-04-18epee: use boost/timer/timer.hpp, boost/timer.hpp is deprecatedmoneromooo-monero1-1/+1
2019-04-16Merge pull request #5447Riccardo Spagni1-0/+34
02c01c0b Add Brewfile to allow for an even easier management of dependencies (Florian)
2019-04-16Merge pull request #5445Riccardo Spagni1-0/+12
b18f0b10 wallet: new --offline option (moneromooo-monero)
2019-04-16Merge pull request #5436Riccardo Spagni1-3/+4
61d63900 net_helper: avoid unnecessary memcpy (moneromooo-monero)
2019-04-16Merge pull request #5432Riccardo Spagni2-2/+9
c3cf930f abstract_tcp_server2: fix timeout on exit (moneromooo-monero)
2019-04-15Add Brewfile to allow for an even easier management of dependenciesFlorian1-0/+34
2019-04-15wallet: new --offline optionmoneromooo-monero1-0/+12
It will avoid connecting to a daemon (so useful for cold signing using a RPC wallet), and not perform DNS queries.
2019-04-15Merge pull request #5369Riccardo Spagni2-2/+2
e72c2c5d do not build in parallel as it is non-deterministic (Jane Mercer)
2019-04-13net_helper: avoid unnecessary memcpymoneromooo-monero1-3/+4
2019-04-12abstract_tcp_server2: fix timeout on exitmoneromooo-monero2-2/+9
When closing connections due to exiting, the IO service is already gone, so the data exchange needed for a gracious SSL shutdown cannot happen. We just close the socket in that case.
2019-04-11epee: init a new ssl related variable in ctormoneromooo-monero1-0/+1
2019-04-11simplewallet: new net_stats commandmoneromooo-monero2-2/+30
displays total sent and received bytes
2019-04-10build: debug and test builds via contribDusan Klinec6-5/+87
2019-04-07Enabling daemon-rpc SSL now requires non-system CA verificationLee Clagett2-0/+22
If `--daemon-ssl enabled` is set in the wallet, then a user certificate, fingerprint, or onion/i2p address must be provided.
2019-04-07Require manual override for user chain certificates.Lee Clagett2-1/+5
An override for the wallet to daemon connection is provided, but not for other SSL contexts. The intent is to prevent users from supplying a system CA as the "user" whitelisted certificate, which is less secure since the key is controlled by a third party.
2019-04-07Only check top-level certificate against fingerprint list.Lee Clagett1-2/+4
This allows "chain" certificates to be used with the fingerprint whitelist option. A user can get a system-ca signature as backup while clients explicitly whitelist the server certificate. The user specified CA can also be combined with fingerprint whitelisting.
2019-04-07Call `use_certificate_chain_file` instead of `use_certificate_file`Lee Clagett1-1/+1
The former has the same behavior with single self signed certificates while allowing the server to have separate short-term authentication keys with long-term authorization keys.
2019-04-07Perform RFC 2818 hostname verification in client SSL handshakesLee Clagett3-5/+26
If the verification mode is `system_ca`, clients will now do hostname verification. Thus, only certificates from expected hostnames are allowed when SSL is enabled. This can be overridden by forcible setting the SSL mode to autodetect. Clients will also send the hostname even when `system_ca` is not being performed. This leaks possible metadata, but allows servers providing multiple hostnames to respond with the correct certificate. One example is cloudflare, which getmonero.org is currently using.
2019-04-07Require server verification when SSL is enabled.Lee Clagett2-11/+16
If SSL is "enabled" via command line without specifying a fingerprint or certificate, the system CA list is checked for server verification and _now_ fails the handshake if that check fails. This change was made to remain consistent with standard SSL/TLS client behavior. This can still be overridden by using the allow any certificate flag. If the SSL behavior is autodetect, the system CA list is still checked but a warning is logged if this fails. The stream is not rejected because a re-connect will be attempted - its better to have an unverified encrypted stream than an unverified + unencrypted stream.
2019-04-07Add `verify_fail_if_no_cert` option for proper client authenticationLee Clagett1-1/+1
Using `verify_peer` on server side requests a certificate from the client. If no certificate is provided, the server silently accepts the connection and rejects if the client sends an unexpected certificate. Adding `verify_fail_if_no_cert` has no affect on client and for server requires that the peer sends a certificate or fails the handshake. This is the desired behavior when the user specifies a fingerprint or CA file.
2019-04-07Pass SSL arguments via one class and use shared_ptr instead of referenceLee Clagett9-167/+229
2019-04-06Do not require client certificate unless server has some whitelisted.Lee Clagett1-12/+27
Currently a client must provide a certificate, even if the server is configured to allow all certificates. This drops that requirement from the client - unless the server is configured to use a CA file or fingerprint(s) for verification - which is the standard behavior for SSL servers. The "system-wide" CA is not being used as a "fallback" to verify clients before or after this patch.
2019-04-06Change SSL certificate file list to OpenSSL builtin load_verify_locationLee Clagett7-76/+65
Specifying SSL certificates for peer verification does an exact match, making it a not-so-obvious alias for the fingerprints option. This changes the checks to OpenSSL which loads concatenated certificate(s) from a single file and does a certificate-authority (chain of trust) check instead. There is no drop in security - a compromised exact match fingerprint has the same worse case failure. There is increased security in allowing separate long-term CA key and short-term SSL server keys. This also removes loading of the system-default CA files if a custom CA file or certificate fingerprint is specified.
2019-04-06Merge pull request #5375Riccardo Spagni1-0/+1
1569776a Add missing include (Leon Klingele)
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-28 04:58:49 +0000