Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
- Detach & re-process txs >= lowest scan height
- ensures that if a user calls scan_tx(tx1) after scanning tx2,
the wallet correctly processes tx1 and tx2
- if a user provides a tx with a height higher than the wallet's
last scanned height, the wallet will scan starting from that tx's
height
- scan_tx requires trusted daemon iff need to re-process existing
txs: in addition to querying a daemon for txids, if a user
provides a txid of a tx with height *lower* than any *already*
scanned txs in the wallet, then the wallet will also query the
daemon for all the *higher* txs as well. This is likely
unexpected behavior to a caller, and so to protect a caller from
revealing txid's to an untrusted daemon in an unexpected way,
require the daemon be trusted.
|
|
Removing preprocessor macro and replacing it with constexpr.
Co-authored-by: Jeffro <jeffreyryan@tutanota.com>
|
|
Before this change, if a multisig peer asked you to sign a transaction with a frozen enote, the wallet will do it without any error or warning. This change makes it
so that wallets will refuse to sign multisig transactions with frozen enotes.
Disclaimer: This PR was generously funded by @LocalMonero.
|
|
* Adding blake2b test function to src/tests/hash
* New files for testvector.
* Adding the test to CMakeLists.txt
* Adding brief documentation for the test.
|
|
|
|
|
|
|
|
All Monero binaries have 1 second startup delay because of this code. This is especially noticeable and affects UX in Monero GUI wallet with local node where it often starts another monerod instance to run commands and query node status.
|
|
|
|
On systems where `ULONG_MAX` != `ULLONG_MAX` (e.g. most 32-bit systems), the `round_money_up` function will not correctly detect overflows.
|
|
|
|
|
|
|
|
Ensures both transfers and sweeps use a fee that's calculated
from the tx's weight. Using different logic could theoretically
enable distinguishability between the two types of txs. We don't
want that.
|
|
|
|
|
|
|
|
|
|
|
|
c32befe fix missing <cstdint> includes (tobtoht)
|
|
|
|
|
|
|
|
|
|
reported by sech1
|
|
|
|
|
|
for a slight performance boost in functional tests
|
|
Force sync every 100k blocks instead of every 1k blocks. Bumping this
value is reported to make a big difference in sync performance, eg:
https://github.com/monero-project/monero/issues/8189
|
|
|
|
1698cb1 remove defunct light wallet code (tobtoht)
|
|
4080796 serialization: remove unused function dump_json (Jeffrey Ryan)
|
|
|
|
|
|
d2a591d wallet, simplewallet: Drop support for mine-to-use RPC system (Jeffrey Ryan)
|
|
eb0e405 gamma picker: relax constructor requirements and test for selecting outputs from first spendable block (jeffro256)
|
|
f383fd3 wallet2: make m_process_pool_txs local to refresh method (jeffro256)
|
|
833dd6b add libunbound to package list for OpenBSD (Nihal Jere)
|
|
7a4a03d wallet2: do not commit transactions more than once (moneromooo-monero)
|
|
3a34c63 depends: cleanup Makefile (tobtoht)
|
|
df9aa6b epee: remove dead code in net_helper (Jeffro256)
|
|
c61d33e wallet2: fix outdated wallet check (Crypto City)
|
|
4e16559 rpc: give reason when sending non-hex raw tx (jeffro256)
|
|
2eaa523 cryptonote::transaction_prefix: fix IDE parsing error (koe)
|
|
630906c cryptonote_basic: remove unused struct (tobtoht)
|
|
b13ddb9 Handle case where a command line flag is not allowed in the config file (almalh)
|
|
5a7a5f1 build: BUILD_DEBUG_UTILITIES fix (Jeffro256)
|
|
Using post-PR wallet with pre-PR node will generate error message specific to this PR and not generic "command failed" mesages.
|
|
11a8360 simplewallet: print fully qualified filename for new wallets (moneromooo-monero)
|
|
9e09093 wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
|
|
1082720 README: fix void ssl package (tobtoht)
|
|
9c7d28b wallet2: add on_reorg callback (Crypto City)
|
|
5b4fea7 Copyright: Update to 2023 (mj-xmr)
|
|
d89e7a2 util: make GMT timestamps explicit for clarity (moneromooo-monero)
|
|
b986421 adjust multiexp pippenger_cached_data for better reusability (koe)
|
|
|
|
|
|
|
|
from first spendable block
|
|
d594981 Fixed deadlock and crash when syncing with full dataset on Windows (SChernykh)
|
|
caa7561 cryptonote core/protocol: don't drop peers for soft offenses (jeffro256)
|
|
85a4558 wallet2: fix infinite loop in fake out selection (Crypto City)
|
|
The gamma picker and the caller code did not quite agree on the
number of rct outputs available for use - by one block - which
caused an infinite loop if the picker could never pick outputs
from that block but already had picked all other outputs from
previous blocks.
Also change the range to select from using code from UkoeHB.
|
|
Also: txs with tx_extra which is too large will not get published to ZMQ
Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
|
|
It's not allowed to use WaitForSingleObject with _beginthread, because the thread closes its own handle before exiting.
So the wait function will either wait on an invalid handle, or on a different handle used by something else.
Or, if it starts waiting before the thread exits, the behavior is undefined according to MS: "If this handle is closed while the wait is still pending, the function's behavior is undefined."
In my test sync I observed threads getting stuck infinitely on WaitForSingleObject, and then rx_set_main_seedhash spamming new threads when RandomX seed changes again. Eventually the system ran out of resources, and monerod aborted with "Couldn't start RandomX seed thread" message.
This PR fixes it by using `_beginthreadex` instead and explicitly closing the handle when it's safe.
|
|
|
|
d7a81cc p2p: do not log to global when re-blocking a subnet (moneromooo-monero)
d84a0d7 p2p: avoid spam blocking ipv4 addresses in a blocked subnet (moneromooo-monero)
|
|
|
|
Fixes #8793
|
|
|
|
Needed by libcrypto at least
|
|
|
|
|
|
|
|
|
|
it was mistaking the number of forks in the fork table for
the last fork, and assuming the table was including every
single fork
|
|
1b27fcd device: Add ledger Stax device id to device detection (Francois Beutin)
|
|
eaf5902 workflows: update dependencies to fix warnings (selsta)
|
|
7a44eb7 depends: remove unused packages (tobtoht)
|
|
3771641 Add a size limit for tx_extra in tx pool (tevador)
|
|
7159f92 verRctNonSemanticsSimpleCached: fix fragility (Jeffrey Ryan)
|
|
c4af33e Enforce restricted # pool txs served via RPC + optimize chunked reqs (j-berman)
9752116 wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call (rbrunner7)
|
|
|
|
|
|
|
|
|
|
|
|
- `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when
returning pool txs via a restricted RPC daemon.
- A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs
in the `added_pool_txs` field, and returns any remaining pool hashes
in the `remaining_added_pool_txids` field. The client then requests
the remaining txs via `/gettransactions` in chunks.
- `/gettransactions` no longer does expensive no-ops for ALL pool txs
if the client requests a subset of pool txs. Instead it searches for
the txs the client explicitly requests.
- Reset `m_pool_info_query_time` when a user:
(1) rescans the chain (so the wallet re-requests the whole pool)
(2) changes the daemon their wallets points to (a new daemon would
have a different view of the pool)
- `/getblocks.bin` respects the `req.prune` field when returning
pool txs.
- Pool extension fields in response to `/getblocks.bin` are optional
with default 0'd values.
|
|
|
|
|
|
|
|
Co-authored-by: Jethro Grassie <jtg@xtrabass.com>
|
|
|
|
from time to time, some people don't realize their wallets get
created in their current working directory
|
|
|
|
|
|
21fb856 depends: bump openssl to 1.1.1t (tobtoht)
|
|
ac9a897 Revert 'epee: when loading a JSON RPC payload, ensure params is an object' (moneromooo-monero)
|
|
d8a8448 p2p: add plowsof seed nodes (selsta)
69153e8 p2p: remove offline seed nodes (selsta)
|
|
|
|
https://www.openssl.org/news/secadv/20230207.txt
Patch can be removed, it was included upstream.
|
|
This reverts commit b67e931843cd0c8191ec49f80448c010cba39901.
This turns out to be a bad idea, because we do have weird RPC which
do actually go counter to this
|
|
eaa3aff depends: bump hidapi/libusb (tobtoht)
|
|
cb756b6 blockchain-stats: print any remaining data at end of loop (Howard Chu)
|
|
b247f98 Demote large pages warning to mdebug (SChernykh)
b27a171 RandomX: print VM allocation warnings only once (SChernykh)
|
|
3461a19 daemonizer: don't uninstall windows service on exit (selsta)
|
|
f3420cb readline_buffer: disable bracketed paste escape sequences (Jeffrey Ryan)
|
|
e91f35e win-service: enable auto startup (plowsof)
|
|
bfd7c00 heed NO_COLOR environment variable (moneromooo-monero)
|
|
b67e931 epee: when loading a JSON RPC payload, ensure params is an object (moneromooo-monero)
|
|
934b798 rpc: do not misidentify coinbase txes as pruned (moneromooo-monero)
|
|
|
|
it's too low a limit (at least one person mentioned having to
call create_address in a loop due to it)
|
|
|
|
|
|
|
|
fixes Trezor connectivity issues on Windows 10/11
Co-authored-by: selsta <selsta@sent.at>
|
|
https://voidlinux.org/news/2021/02/OpenSSL.html
|
|
|
|
Fix #8711
|
|
|
|
Co-authored-by: plowsof <plowsof@protonmail.com>
extra files
|
|
|
|
1a568de Cache successful erRctNonSemanticsSimple calls (SChernykh)
|
|
7a3a593 common: move boost_serialization_helper.h out and cleanup includes (Jeffrey Ryan)
|
|
96677ff common: add missing includes (selsta)
|
|
fe8522c Bump WINVER to 0x0600 (Windows Vista) (SChernykh) dab7d01 Refactored rx-slow-hash.c (SChernykh)
|
|
a160270 update readme with v0.18.1.2 version number (Gingeropolous)
|
|
b1bce85 miscellaneous crypto updates (koe)
|
|
61842f9 workflows: set a public DNS when doing tests (selsta)
|
|
6558e7e Correct/modernize build instructions for OpenBSD (Offshore Monero)
0e5ecd4 Turn readline off on OpenBSD because it is broken (Offshore Monero)
|
|
8687da6 common: DNSResolver can handle hostnames without dot characters (Jeffrey Ryan)
|
|
832173a gpg_keys: bump my key validity by another two years (moneromooo-monero)
|
|
faaf2af p2p: fix exclusive node DNS resolution for certain hosts (Jeffrey Ryan)
|
|
1a3ae18 p2p: fix back ping to discover healthy peers to connect to (j-berman)
|
|
ab7102e epee: remove dead HTTP code (Jeffrey Ryan)
|
|
This is required to use SRW locks in Windows - see `src/crypto/c_threads.h`
|
|
- Straight-forward call interface: `void rx_slow_hash(const char *seedhash, const void *data, size_t length, char *result_hash)`
- Consensus chain seed hash is now updated by calling `rx_set_main_seedhash` whenever a block is added/removed or a reorg happens
- `rx_slow_hash` will compute correct hash no matter if `rx_set_main_seedhash` was called or not (the only difference is performance)
- New environment variable `MONERO_RANDOMX_FULL_MEM` to force use the full dataset for PoW verification (faster block verification)
- When dataset is used for PoW verification, dataset updates don't stall other threads (verification is done in light mode then)
- When mining is running, PoW checks now also use dataset for faster verification
|
|
|
|
|
|
|
|
|
|
|
|
For privacy reasons, time functions use GMT, to avoid logs leaking
timezones. It'd make more sense to use localtime for wallet output
(which are not logged by default), but that adds inconsistencies
which can also be confusing. So add a Z suffix for now to make it
clear these are not local time.
|
|
|
|
this makes it easier to spot those mistakes by the caller
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
updated readme with all relevant instances of v0.18.0.0 changed to v0.18.1.2
|
|
|
|
error reporting
|
|
8b8326a workflows: ubuntu 18.04 is deprecated (selsta)
|
|
a7bf3af Fix dandelion++ fluff/stem bug with local txes (Lee Clagett)
|
|
1114e7e fix(trezor-tests): fix trezor tests build, fix integrated addr test (Dusan Klinec)
|
|
cac5083 wallet2: fix create view-only wallet from existing wallet (j-berman)
|
|
97b86a0 wallet_api: take priority into account when estimating fee (selsta)
|
|
6f00070 workflows: skip ci when only changing documentation (selsta)
|
|
8e98aaa workflows: build gitian on tag (selsta)
|
|
98ce6f1 depends: remove unused file (selsta)
|
|
50b7492 unit_tests: suppress memwipe unit warning (Jeffrey Ryan)
|
|
d06202d blockchain_prune: faster (moneromooo-monero)
|
|
|
|
|
|
|
|
Unrelated, but similar code-wise to #8643. There is a check in `DNSResolver` which automatically fails to resolve hostnames which do not contain the `.` character. This PR removes that check.
|
|
Fixes #8633. The function `append_net_address` did not parse hostname + port addresses (e.g. `bar:29080`) correctly if the hostname did not contain a `'.'` character.
@vtnerd comments 1
clear up 2nd conditional statement
|
|
|
|
- fix integrated address test, it was not testing integrated address suport
- fix trezor test build as dependent classes were changed
- add a friend test class for Monero::WalletImpl to support wallet api tests
When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
|
|
|
|
|
|
http_client.h
|
|
|
|
be8efec workflows: ubuntu 18.04 is deprecated (selsta)
|
|
74ec950 readme: fix instructions for win64 cross builds (erciccione)
|
|
ebb85d7 Add Gitian builds to README (duggavo)
|
|
9274426 Keys: Update for expired 'rbrunner7' key, valid 2 years (rbrunner7)
|
|
8923441 fix build in netbsd (mmyjona)
|
|
b526a4b levin_abstract_invoke: remove dead code (Jeffrey Ryan)
|
|
f69adef Fix static builds for Ubuntu 22.04 (AgoraDesk / LocalMonero)
|
|
d21fd92 rpc: dont shrink slice when loading from binary (Jeffrey Ryan)
|
|
09d69b6 rpc: remove overwriting value (SerHack)
|
|
e988530 Remove redundant check (SerHack)
|
|
501db2c Wallet RPC: remove duplicate line (SerHack)
|
|
6f0fb76 blockchain: fix invalid memory read getting fee on empty chain (Crypto City)
|
|
26c630f Update release check-list with lessons learned from v15/v16 fork (Seth For Privacy)
|
|
23fde15 wallet_rpc_server: chunk refresh to keep responding to RPC while refreshing (moneromooo-monero) 5bb2369 wallet_rpc_server: add --no-initial-sync flag for quicker network binding (moneromooo-monero)
|
|
b15aee2 readme edits squash (Gingeropolous)
|
|
|
|
|
|
|