Age | Commit message (Collapse) | Author | Files | Lines |
|
- fix integrated address test, it was not testing integrated address suport
- fix trezor test build as dependent classes were changed
- add a friend test class for Monero::WalletImpl to support wallet api tests
When using wallet_api in tests, synthetic chain is used. Without being able to set `allow_mismatched_daemon_version` in the underlying wallet, we are not able to use a synthetic chain with the tests
|
|
8e7c7af Move update_checkpoints() to a later stage (SChernykh)
|
|
e9ce347 wallet2: fail to establish daemon cxn == 'Disconnected' cxn status (j-berman)
|
|
28f25c0 Second thread pool for IO (SChernykh)
|
|
fa7622c depends: remove unused Qt package (selsta)
|
|
6d8fa2b workflows: add android to depends (selsta)
|
|
4b0785f add an option to force-update multisig key exchange under some circumstances (koe)
|
|
update_checkpoints() makes a few DNS requests and can take up to 20-30 seconds to complete (3-6 seconds on average). It is currently called from core::handle_incoming_block() which holds m_incoming_tx_lock, so it blocks all incoming transactions and blocks processing while update_checkpoints() is running. This PR moves it to until after a new block has been processed and relayed, to avoid full monerod locking.
|
|
|
|
|
|
|
|
|
|
b8271ab wallet2: check wallet compatibility with daemon's hard fork version (j-berman)
|
|
eca7f6a Fix segfault restoring encrypted multisig seed (j-berman)
f713c3c Require user ack multisig is experimental to restore (j-berman)
564a7a3 multisig: fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
|
|
|
|
76a5b54 Fix missing semi-colon in error message (j-berman)
|
|
e410ab7 Windows: fix unicode file path support (tobtoht)
|
|
3987827 Fix shared_ptr cycle in test_epee_connection.test_lifetime (Lee Clagett)
|
|
2639c4f rpc: skip bootstrap nodes that are lower than last checkpoint (selsta)
|
|
959a3e6 wallet2: ensure imported outputs subaddresses are created (moneromooo-monero)
a098504 wallet2: better test on whether to allow output import (moneromooo-monero)
c5579ac allow exporting outputs in chunks (moneromooo-monero)
1e912ec wallet2: fixes for export/import output flow (j-berman)
692f1d4 wallet2: do not assume imported outputs must be non empty (moneromooo-monero)
67b6d6a wallet2: prevent importing outputs in a hot wallet (moneromooo-monero)
d9fc666 wallet2: fix missing subaddress indices in 'light' exported outputs (moneromooo-monero)
|
|
a4cb77f epee: update 'http_server_handlers_map2.h' macros to use fully qualified names (Jeffrey Ryan)
|
|
|
|
Co-authored-by: woodser <woodser@protonmail.com>
|
|
|
|
|
|
- spend secret key is no longer the sum of multisig key shares;
no need to check that is the case upon restore.
- restoring a multisig wallet from multisig info means that the
wallet must have already completed all setup rounds. Upon restore,
set the number of rounds completed accordingly.
|
|
|
|
|
|
reported by j-berman
|
|
8305a9f depends: remove unused packages (selsta)
|
|
7b15f21 README: unbound is not vendored anymore (selsta)
|
|
796513f repo: remove ldns leftovers (selsta)
|
|
f8d76ec version: bump master version number (selsta)
|
|
6b61628 dns_util: remove outdated DNSSEC DS trust anchor (selsta)
|
|
04a1e28 ledger support for hf 15 (BP+, view tags) (j-berman)
|
|
f7f1445 device: set ledger min app version (selsta)
|
|
85e697f randomx: update submodule (selsta)
|
|
600de07 wallet_rpc_server: longer timeout for stop_mining (moneromooo-monero)
ac6db92 functional_tests: silence the cpu power test program (moneromooo-monero)
|
|
308e3fa gpg_keys: add jeffro256 key (Jeffrey Ryan)
|
|
ef1924a Bump to v0.18.1.0 (Seth For Privacy)
89a2df6 Migrate VERSION variable to non-export (Seth For Privacy)
b83874e Set version in ENV var (Seth For Privacy)
bb955d1 Bump Gitian build instructions to v0.18.0.0 (Seth For Privacy)
|
|
7a31d25 keccak: error out if passed mdlen 100 (moneromooo-monero)
|
|
1fc60ca Publish submitted txs via zmq (j-berman)
|
|
8ea6c33 Fix some paths for toolchain / build (Howard Chu)
|
|
628fdcd continue pool pruning even if a tx can't be found (j-berman)
|
|
f797655 Fixed get_block_template_backlog performance (SChernykh)
|
|
4a4936b Fix use of rtxn without a mdb_txn_safe wrapper (Howard Chu)
|
|
4d7f6f5 GCC: fix some unused warnings (Jeffrey Ryan)
|
|
552528b Remove async_blocked_mode_client (Jeffrey Ryan)
3ee2174 string_coding: unused functions (Jeffrey Ryan)
285d9f0 http_server_handlers_map2: dead macros (Jeffrey Ryan)
|
|
0093bc2 Focus Doxygen documentation (Jeffrey Ryan)
|
|
564fa30 DOCS: Rework Portable storage format example (Jeffrey Ryan)
|
|
a0df140 feat(trezor): add HF15 support, BP+ (Dusan Klinec)
|
|
Being offline is not a good enough heuristic, so we keep track
of whether the wallet ever refreshed from a daemon, which is a
lot better, and probably the best we can do without manual user
designation (which would break existing cold wallet setups till
the user designates those wallets)
|
|
this will make it easier huge wallets to do so without hitting
random limits (eg, max string size in node).
|
|
- only allow offline wallets to import outputs
- don't import empty outputs
- export subaddress indexes when exporting outputs
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Otherwise Ledger rejects the wallet.
|
|
|
|
|
|
Before the fix, it processed all transactions in the mempool which could be very slow when mempool grows to several MBs in size. I observed `get_block_template_backlog` taking up to 15 seconds of CPU time under high mempool load.
After the fix, only transactions that can potentially be mined in the next block will be processed (a bit more than the current block median weight).
|
|
|
|
|
|
@jtgrassie pointed out that the example I provided was colored incorrectly. He also made the good point that the image wasn't easy to review/correct. I reworked the example so that it's text-only. It's easier to review and edit, and reveals the structure better in my opinion. Also this is easier for people who can't distinguish colors as easily.
Make sure to double-check this work because there's a decent chance I screwed up the comments. The actual byte data was generated and should be solid.
|
|
|
|
That RPC will wait for mining to actually stop, which can be a while
if randomx has just started on randomx_init_dataset.
This fixes occasional failures in the mining functional test
|
|
it's very spammy and drowns the test output
|
|
|
|
|
|
|
|
|
|
|
|
cf3be99 Template hash func to fix compiler error on < gcc-6 (j-berman)
|
|
a82fba4 address PR comments (j-berman)
3be1dbd connection: fix implementation (anon)
724ff21 connection: add segfault and deadlocks demo (anon)
|
|
fe5d1be build: prepare v0.18.0.0 (selsta)
|
|
2ba391f hardforks: set mainnet and stagenet v15/16 fork height (selsta)
|
|
db8181a wallet2: force using output distribution for ringct outs (tobtoht)
|
|
edcc094 derive multisig tx secret keys from an entropy source plus the tx inputs' key images (koe)
|
|
5770265 wallet2: keep around transaction prefix for confirmed transfers (tobtoht)
|
|
|
|
|
|
key images
|
|
bd1e7c5 wallet2: prevent crash when reading tx w/fewer outputs than expected (j-berman)
|
|
c7b2944 multisig: fix critical vulnerabilities in signing (anon)
|
|
Right now Doxygen is documenting everything in the repo including submodules, everything in contrib,
util, tests, etc. This bogs down the documentation to the point where it is very hard to navigate. I think
it would be a good move to focus on documenting only the main C++ code which is specific to this repo.
Right now this means documenting `src/` (without SUPERCOP), `contrib/epee/`, `external/easylogging++`. After this commit,
Doxygen went from running >6000 graphs to about 2200 graphs.
|
|
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed
device_ledger: move anonymous global variable apdu_verbose into .cpp file
Add comments to `refreshed` method variable in wallet2
|
|
If we were to call it with 100, it would cause rsiz to be 0,
leading to an infinite loop.
This is really a pedantic patch, but since there's already a
range test, might as well make it better.
|
|
|
|
|
|
|
|
8e9c60a README: depends has only been tested on ubuntu 18.04 and 20.04 (selsta)
|
|
83aa817 (fix): Confusingly named CI-Job (Klaus Frank)
|
|
09a597b wallet2: don't use DNS to obtain segregation heights (tobtoht)
|
|
50ccc7e wallet2: remove obsolete rpc version check (tobtoht)
|
|
6f3abbe Depends: Unbound disable getentropy()/reallocarray() (glibc < 2.26) (TheCharlatan)
|
|
4278a3a cryptonote_basic: catch crypto api errors (moneromooo-monero)
|
|
41b1a6b simplewallet: print usage when given no args (hinto.janaiyo)
|
|
d486c03 utils: add fish shell completions (Leo Nerone)
|
|
04c0da2 Chunk /gettransactions to avoid hitting restricted RPC limit (tobtoht)
|
|
16f8e04 Remove erraneous commas (Luke Parker)
da0715e Improve consistency between on_money_received and on_money_received_unconfirmed (Luke Parker)
|
|
|
|
|
|
|
|
8460fcc Revert 'Merge pull request #7937' (j-berman)
|
|
fb3f7ce clang warning fix for #8338 (Jeffrey Ryan)
|
|
bc05d2d README.md: Add v15/v16 network upgrade (garth-xmr)
|
|
de2f0d0 wallet_api: add scanTransactions function (selsta)
|
|
61d0712 Gitian: refresh the stale Monero dir via --setup switch (mj-xmr)
|
|
ade464a ITS#9385 fix using MDB_NOSUBDIR with nonexistent file (Kris Zyp)
033a32a Remove check is_directory check on lmdb path (Howard Chu)
b096e16 Revert 'db_lmdb: test for mmap support at init time' (Howard Chu)
493577a Silence spurious fallthru warning (Howard Chu)
b46a60e Fix rawpart flag collision (Howard Chu)
4e7586c More RAWPART support (Howard Chu)
747f5d3 Preliminary raw partition support (Howard Chu)
|
|
|
|
|
|
Fish shell completions for monerod, monero-wallet-cli, and monero-wallet-rpc.
|
|
|
|
|
|
Rename the "build-macos" job within "depends", as it is not building on macOS as the similarly named job within build.yml does. Also, both names overlap which is confusing when looking for step-by-step build instruction examples or when looking at the logfile.
|
|
|
|
|
|
Co-authored-by: j-berman <justinberman@protonmail.com>
|
|
|
|
|
|
|
|
- BP+ support added for Trezor
- old Trezor firmware version support removed, code cleanup
|
|
|
|
|
|
This reverts commit 50410d1f7d04bf60053f2263410c39e81d3ddad1, reversing
changes made to d054def63f9b8950fe20b2d8e841f5a9ae09418f.
|
|
|
|
|
|
The check interferes with raw device/partition support.
|
|
This reverts commit bd96536637724413173271e8d5df1777f7879c29.
The check interferes with raw device/partition support.
|
|
|
|
|
|
Use mmap to read and initialize the meta pages, raw device
may not support read/write syscalls.
|
|
Autodetects that a block device is being used.
|
|
|
|
unconfirmed solely uses a - b, and received now accepts b so it can
provide more detailed logs on what occurred (printing a - b, yet with a
and b).
|
|
Unlike some other warnings, clang does not have a `stringop-overflow` group so it doesn't recognize the `#pragma GCC ...` directive in #8338
|
|
08080df unit_tests: add more sha256sum test cases (Jeffrey Ryan)
a66a52d common: update sha256sum to use OpenSSL 3.0 API (Jeffrey Ryan)
|
|
5858f05 GCC: Fix -Wstringop-overflow= warnings (Jeffrey Ryan)
|
|
1164874 src, epee: fix a couple compiler warnings (selsta)
|
|
fde7c96 wallet2: fix spurious reorg detection with untrusted nodes (moneromooo-monero)
|
|
2dab31f Don't exclusively drop tor/i2p outgoing cxns in idle loop (j-berman)
|
|
2979474 disable multisig by default (moneromooo-monero)
|
|
b9d2c78 fix backoff delay logic when re-relaying txs (j-berman)
|
|
62914e7 Ignore gitian build files (Jeffrey Ryan)
|
|
bae4a1a Don't send peerlist larger than max allowed (j-berman)
|
|
af08c83 utils: delete outdated windows build script (selsta)
|
|
Remade #8270 (includes edits from UkoeHB)
|
|
|
|
|
|
|
|
quick patch which fixes the issue where if you use some macros from `http_server_handlers_map2.h` you have to be in the `epee` namespace or it doesn't compile. Now can remove `using namespace epee;` from header file `core_rpc_server.h`, which caused a couple of name qualifying mistakes
|
|
026dbc8 Windows build: fix narrowing error for WaitForSingleObject (Jeffrey Ryan)
|
|
`WaitForSingleObject` returns a `DWORD`, not an int, so assign `retval` as such and it should fix the error.
|
|
|
|
|
|
As of OpenSSL 3.0, `SHA256_Init`, `SHA256_Update`, and `SHA256_Final`
are deprectaed in favor of the higher-level `EVP_*` class of functions.
This causes compiler warnings, and sooner or later, will cause build
errors as these functions are excluded from distro headers.
Also add some documentation.
|
|
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
|
|
Resolves #8320
|
|
|
|
1ddb1ee Give better error messages when missing SSL files (Jeffrey Ryan)
|
|
5c27fd8 depends: Package cleanup (Howard Chu)
c1d47eb Update randomx: fix Mac linking error (Howard Chu)
02e6af2 Update CI for aarch64 mac build (selsta)
7ea1e21 Make Mac SDK into a regular depends package (Howard Chu)
e81ab9b Silence some protobuf link warnings (Howard Chu)
fe5c2ae Fix arm64 darwin package defs (Howard Chu)
fb68465 Boost 1.64 doesn't recognize arm64 darwin (Howard Chu)
617f908 more... update to clang 9.0.0 (Howard Chu)
83ae3ad Split native_clang out of native_cctools (Howard Chu)
1008318 Update native_cctools for newer SDK support (Howard Chu)
a86c4cb Update to MacOSX SDK 11.1, add Mac M1 (Howard Chu)
|
|
f63f7dc wallet2: fix a couple unused variable warnings (selsta)
|
|
b7978cf Remove src/serialization/list.h (Jeffrey)
|
|
ab9766e depends: update unbound to 1.15.0 (selsta)
|
|
df2e680 wallet2: speedup large tx construction: reserve vector memory (moneromooo-monero)
38cdf01 wallet2: speedup large tx construction: batch ringdb lookups (Crypto City)
353cd53 wallet2: speedup large tx construction: no pointless clsag generation (Crypto City)
2b95178 wallet2: speedup large tx construction: batch ringdb updates (Crypto City)
c9cf0b7 wallet2: speedup large tx construction: cache public key validity (moneromooo-monero)
|
|
When forced to deal with an untrusted node, a wallet will quantize
its current height to disguise the real height to the adversary, to
try and minimize the daemon's ability to distinguish returning
wallets.
Daemons will thus return more blocks than the wallet needs, starting
from earlier in the chain. These extra blocks will be disregarded
by the wallet, which had already scanned them.
However, for the purposes of reorg size detection, the wallet assumes
all blocks the daemon sends are different, which is only correct if
the wallet hasn't been coy, which is only the case for trusted
daemons (which you should use). This causes an issue when the size
of this "fake reorg" is above the sanity check threshold at which
the wallet refuses a reorg.
To fix this, the reorg size check is moved later on, when the reorg
is about to actually happen, after the wallet has checked which
blocks are actually different from the ones it expects.
|
|
2.8 seconds -> 2.6 seconds on a test case
|
|
3.3 seconds -> 2.8 seconds on a test case
|
|
4.1 seconds -> 3.3 seconds on a test case
|
|
5.2 seconds -> 4.1 seconds on a test case
|
|
5.9 second -> 5.2 seconds on a test case
|
|
|
|
|
|
|
|
7d6c748 Set hf v15 testnet fork heights (j-berman)
|
|
0226df9 More tests for view tags (SChernykh)
|
|
41da2fe Update copyright to 2022 for Hardfork files (Akrit)
|
|
6ef945d Doxygen: Hide anonymous namespaces from documentation by default (Jeffrey)
|
|
070e41d Change Github to GitHub (Abdullah)
|
|
4f08bcd refactor(bp+): save one inversion, use sc_muladd (Dusan Klinec)
|
|
ca5921d readme: arch/fedora deps + small fixes (hinto.janaiyo)
|
|
fc9b77d Changes to PORTABLE_STORAGE.md (Jeffrey)
34941ac Docs: Add documentation for EPEE Portable Storage (Jeffrey)
|
|
f7d50cb EPEE: Remove gzip_encoding.h (Jeffrey)
|
|
63c7f8b EPEE: Remove hmac-md5 (Jeffrey)
|
|
baee2c0 Preserve commitment format inside transactions (kayabaNerve)
|
|
268a039 Optimized keccak implementation (SChernykh)
|
|
9c42b72 CMake: Add missing BUILD_SHARED_LIBS option (mj-xmr)
|
|
002bf9c Fix typo: SERIALIZE_TYPE_DUOBLE (Jeffrey)
|
|
0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
|
|
All patching should be in _preprocess_cmd. config_cmd should just run
configure and nothing else before it, otherwise $PATH is broken when it runs.
Also remove redundant settings to configure, _autoconf already sets them.
We leave explicit AR_FLAGS settings because the builtin rule uses ARFLAGS,
and so would leave AR_FLAGS unset otherwise.
|
|
Also silence randomx malloc exceptions
|
|
|
|
|
|
|
|
4 warnings remain but it's better than before
|
|
|