| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
fde7c96 wallet2: fix spurious reorg detection with untrusted nodes (moneromooo-monero)
|
|
2dab31f Don't exclusively drop tor/i2p outgoing cxns in idle loop (j-berman)
|
|
2979474 disable multisig by default (moneromooo-monero)
|
|
b9d2c78 fix backoff delay logic when re-relaying txs (j-berman)
|
|
62914e7 Ignore gitian build files (Jeffrey Ryan)
|
|
bae4a1a Don't send peerlist larger than max allowed (j-berman)
|
|
af08c83 utils: delete outdated windows build script (selsta)
|
|
026dbc8 Windows build: fix narrowing error for WaitForSingleObject (Jeffrey Ryan)
|
|
`WaitForSingleObject` returns a `DWORD`, not an int, so assign `retval` as such and it should fix the error.
|
|
|
|
There are vulnerabilities in multisig protocol if the parties do not
trust each other, and while there is a patch for it, it has not been
throroughly reviewed yet, so it is felt safer to disable multisig by
default for now.
If all parties in a multisig setup trust each other, then it is safe
to enable multisig.
|
|
1ddb1ee Give better error messages when missing SSL files (Jeffrey Ryan)
|
|
5c27fd8 depends: Package cleanup (Howard Chu)
c1d47eb Update randomx: fix Mac linking error (Howard Chu)
02e6af2 Update CI for aarch64 mac build (selsta)
7ea1e21 Make Mac SDK into a regular depends package (Howard Chu)
e81ab9b Silence some protobuf link warnings (Howard Chu)
fe5c2ae Fix arm64 darwin package defs (Howard Chu)
fb68465 Boost 1.64 doesn't recognize arm64 darwin (Howard Chu)
617f908 more... update to clang 9.0.0 (Howard Chu)
83ae3ad Split native_clang out of native_cctools (Howard Chu)
1008318 Update native_cctools for newer SDK support (Howard Chu)
a86c4cb Update to MacOSX SDK 11.1, add Mac M1 (Howard Chu)
|
|
f63f7dc wallet2: fix a couple unused variable warnings (selsta)
|
|
b7978cf Remove src/serialization/list.h (Jeffrey)
|
|
ab9766e depends: update unbound to 1.15.0 (selsta)
|
|
df2e680 wallet2: speedup large tx construction: reserve vector memory (moneromooo-monero)
38cdf01 wallet2: speedup large tx construction: batch ringdb lookups (Crypto City)
353cd53 wallet2: speedup large tx construction: no pointless clsag generation (Crypto City)
2b95178 wallet2: speedup large tx construction: batch ringdb updates (Crypto City)
c9cf0b7 wallet2: speedup large tx construction: cache public key validity (moneromooo-monero)
|
|
When forced to deal with an untrusted node, a wallet will quantize
its current height to disguise the real height to the adversary, to
try and minimize the daemon's ability to distinguish returning
wallets.
Daemons will thus return more blocks than the wallet needs, starting
from earlier in the chain. These extra blocks will be disregarded
by the wallet, which had already scanned them.
However, for the purposes of reorg size detection, the wallet assumes
all blocks the daemon sends are different, which is only correct if
the wallet hasn't been coy, which is only the case for trusted
daemons (which you should use). This causes an issue when the size
of this "fake reorg" is above the sanity check threshold at which
the wallet refuses a reorg.
To fix this, the reorg size check is moved later on, when the reorg
is about to actually happen, after the wallet has checked which
blocks are actually different from the ones it expects.
|
|
2.8 seconds -> 2.6 seconds on a test case
|
|
3.3 seconds -> 2.8 seconds on a test case
|
|
4.1 seconds -> 3.3 seconds on a test case
|
|
5.2 seconds -> 4.1 seconds on a test case
|
|
5.9 second -> 5.2 seconds on a test case
|
|
|
|
|
|
|
|
7d6c748 Set hf v15 testnet fork heights (j-berman)
|
|
0226df9 More tests for view tags (SChernykh)
|
|
41da2fe Update copyright to 2022 for Hardfork files (Akrit)
|
|
6ef945d Doxygen: Hide anonymous namespaces from documentation by default (Jeffrey)
|
|
070e41d Change Github to GitHub (Abdullah)
|
|
4f08bcd refactor(bp+): save one inversion, use sc_muladd (Dusan Klinec)
|
|
ca5921d readme: arch/fedora deps + small fixes (hinto.janaiyo)
|
|
fc9b77d Changes to PORTABLE_STORAGE.md (Jeffrey)
34941ac Docs: Add documentation for EPEE Portable Storage (Jeffrey)
|
|
f7d50cb EPEE: Remove gzip_encoding.h (Jeffrey)
|
|
63c7f8b EPEE: Remove hmac-md5 (Jeffrey)
|
|
baee2c0 Preserve commitment format inside transactions (kayabaNerve)
|
|
268a039 Optimized keccak implementation (SChernykh)
|
|
9c42b72 CMake: Add missing BUILD_SHARED_LIBS option (mj-xmr)
|
|
002bf9c Fix typo: SERIALIZE_TYPE_DUOBLE (Jeffrey)
|
|
0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
|
|
All patching should be in _preprocess_cmd. config_cmd should just run
configure and nothing else before it, otherwise $PATH is broken when it runs.
Also remove redundant settings to configure, _autoconf already sets them.
We leave explicit AR_FLAGS settings because the builtin rule uses ARFLAGS,
and so would leave AR_FLAGS unset otherwise.
|
|
Also silence randomx malloc exceptions
|
|
|
|
|
|
|
|
4 warnings remain but it's better than before
|
|
|
|
|
|
|
|
|
|
|
|
Needed for compiling native_libtapi
|
|
|
|
While copying my data dir to another drive, I missed copying the rpc_ssl.key file b/c of the file permissions.
This change will give a much more clear, descriptive error in that scenario.
|
|
|
|
* More information about array entries (especially nesting)
* Varint encoding examples
* Expanded string and integer encoding information
|
|
|
|
Unused ;)
Also a comment from serialization.h
|
|
P2Pool can create transactions with more than 128 outputs, which make output_index's varint larger than 1 byte. Added this test case.
|
|
have completed the multisig address
|
|
Update Makefile and LICENSE
|
|
Bonus: little doc fix for net_ssl.h
|
|
|
|
|
|
9209880 add a sanity check to RPC input data size (moneromooo-monero)
|
|
50ae6ba Tiny: add .vscode/ to .gitignore (mj-xmr)
|
|
a14fdf8 Remove /include (Jeffrey)
|
|
d1cb9c3 Remove serialization/enableable (Jeffrey)
|
|
5d388eb Bump ring size to 16 for v15 & remove set default in wallet cli (j-berman)
|
|
Ripped directly from @jtgrassie 's monero-binary-rpc repo. It's a very helpful little document and I think it deserves a place in the main repo.
|
|
|
|
|
|
|
|
reported by m31007
|
|
9df7179 wallet2: use BP+ for cold signing (moneromooo-monero)
|
|
b99242f readme: small fixes (hinto.janaiyo)
|
|
6491700 Makefile: fix spelling of CMAKE_BUILD_TYPE value (selsta)
|
|
3593a98 simplewallet: fix integrated_address output string (selsta)
|
|
c68d78d randomx: update submodule (selsta)
|
|
0f7b20a Added support for Ledger Nano S Plus (Mathias Herberts)
|
|
ea87b30 Add view tags to outputs to reduce wallet scanning time (j-berman)
|
|
|
|
|
|
|
|
1137142 Change C-cast to static_cast in net_peerlist.h (Jeffrey)
175b411 Change C-style-casts to static_cast in time_helper.h (Jeffrey)
b49ed59 Remove the only 4 non-UTF8 characters in codebase (Jeffrey)
1f25aa2 Factor out move_it_backward from misc_language.h (Jeffrey)
7764d69 Move copyable_atomic into connection_context (Jeffrey)
801568d Refactor out to_nonconst_iterator.h (Jeffrey)
87ec36c Refactor out pragma_comp_defs (Jeffrey)
441c860 Merge functionality of misc_os_dependent into time_helper.h (Jeffrey)
40f02f9 Add Include statements (Jeffrey)
12b1b74 Trimming Fat (Jeffrey
690ce56 Boring Old Deletes (Jeffrey)
|
|
Thanks @mj-xmr: https://github.com/monero-project/monero/pull/8211#discussion_r823870855
|
|
At the request of @mj-xmr: https://github.com/monero-project/monero/pull/8211#discussion_r822868321
|
|
Relevant commit in old PR:
1b798a7042070cc8063bd341ebf7025da554b632
|
|
Relevant commit from old PR:
330df2952cb2863a591158b984c0fb7f652887ac
|
|
Relevant commit from old PR:
bd0a5119957d3ef9130a0b82599e1696995ef235
|
|
Relevant commit on old PR:
2499269696192ce30dd125ddee90a80d4326dff9
|
|
Relevant commits on the old cleanup PR:
36933c7f5c7778e2d7fbfea5361c11fb41070467
21e43de0f300ee47b7e597098908601bf591950b
3c678bb1cedfd7b865ac2e7aaf014de4bfb3eb3d
|
|
Actions:
1. Remove unused functions from misc_os_dependent.h
2. Move three remaining functions, get_gmt_time, get_ns_count, and get_tick_count into time_helper.h
3. Remove unused functions from time_helper.h
4. Refactor get_ns_count and get_internet_time_str and get_time_interval_string
5. Remove/add includes as needed
Relevant commits on the old PR:
a9fbe52b02ffab451e90c977459fea4642731cd1
9a59b131c4ed1be8afe238fff3780fe203c65a46
7fa9e2817df9b9ef3f0290f7f86357939829e588
|
|
|
|
Remove unused include statements or unused definitions.
|
|
Here lies dozens of unused files. This commit is ONLY file deletions except
for the removing of a couple of #includes and removing filenames from CmakeLists
where appropriate.
|
|
All tests were conducted on the same PC (Ryzen 5 5600X running at fixed 4.65 GHz).
Before:
test_cn_fast_hash<32> (100000 calls) - OK: 1 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 164 us/call
After:
test_cn_fast_hash<32> (100000 calls) - OK: 0 us/call
test_cn_fast_hash<16384> (1000 calls) - OK: 31 us/call
More than 5 times speedup for cn_fast_hash.
Also noticed consistent 1-2% improvement in test_construct_tx results.
|
|
Implements view tags as proposed by @UkoeHB in MRL issue
https://github.com/monero-project/research-lab/issues/73
At tx construction, the sender adds a 1-byte view tag to each
output. The view tag is derived from the sender-receiver
shared secret. When scanning for outputs, the receiver can
check the view tag for a match, in order to reduce scanning
time. When the view tag does not match, the wallet avoids the
more expensive EC operations when deriving the output public
key using the shared secret.
|
|
4db6aed CMake: Add missing headers via monero_find_all_headers macro (mj-xmr)
|
|
b030f20 Fee changes from ArticMine (moneromooo-monero)
9f786f0 epee: allow copying a rolling_median_t object (moneromooo-monero)
|
|
|
|
reported by ukoehb
|
|
|
|
https://github.com/ArticMine/Monero-Documents/blob/master/MoneroScaling2021-02.pdf
with a change to use 1.7 instead of 2.0 for the max long term increase rate
|
|
|
|
* `IWallet.h` hasn't been touched since 2014, and has been replaced by `src/wallet/api/wallet2_api.h`
* `INode.h` is in a similar situation with `src/p2p/net_node.h`
|
|
Currently working on an EPEE [ser/de]ialization library for Rust and at first glance, EPEE seemed to have support for optional wrappers. However, after looking into it, this feature appears to be half-baked and unused. Furthermore, adding support for optional values would be better suited to implement at the storage level, in my opinion. That would make parsing DOMs easier and less error-prone. If anyone is currently using this code, please comment. Thanks!
At the time of writing, this PR has no merge conflicts with #8211
|
|
|
|
|
|
6abe3fe tests: integrated_address: remove missing payment id assertion (reemuru)
|
|
The integrated address functional test fails in the workflows due
to an assertion for missing payment id that is no longer needed.
Remove the assertion and update the assertion count.
Fixes 7dcfccb: ("wallet_rpc_server: fix make_integrated_address with no payment id")
|
|
|
|
|
|
1ce9e9c Remove dead code from parserse_base_utils and fix unit tests (Jeffrey)
|
|
17772ef Eliminate dependence on boost::interprocess #8223 (Jeffrey)
|
|
d1f1947 wallet_rpc_server: support regex for get_accounts tag (reemuru)
|
|
7dcfccb wallet_rpc_server: fix make_integrated_address with no payment id (moneromooo-monero)
|
|
591c174 Remove footgun doc comment in miner TX validation (Luke Parker)
|
|
0d6fce8 Compil. time: cryptonote_core minus portable_storage header (mj-xmr)
|
|
da9aa1f Copyright: Update to 2022 (mj-xmr)
|
|
3c82958 wallet2: update stagenet rollback blocks (selsta)
|
|
3f88fdd simplewallet: add option for exporting tx keys (reemuru)
|
|
ae0a840 wallet2: decrease the amount of data exchanged for output export (moneromooo-monero)
|
|
cf44349 account info text alignment (im)
|
|
83bb027 Make RPC server functions that read db thread safe (j-berman)
|
|
bd27deb Bulletproofs+ (SarangNoether)
b7713cc Precompute initial transcript hash (SarangNoether)
b535d66 Updates from security audit (SarangNoether)
a0d80b1 plug bulletproofs plus into consensus (moneromooo-monero)
75bd004 ringct: a few minor optimizations from review (moneromooo-monero)
a345060 ringct: port some of vtnerd's review changes from BP+ to BP (moneromooo-monero)
4c94cfe store outPk/8 in the tx for speed (moneromooo-monero)
5acdd0e bulletproofs+: some minor cleanup from vtnerd's review (moneromooo-monero)
|
|
354e1d9 Make the wallet name optional when locked. (Norman Moeschter)
|
|
- grab an lmdb db_rtxn_guard to ensure consistent data from the db
- fixed on_getblockhash error resp when requested height >= blockchain height
- left functions that read shared memory untouched for now
|
|
|
|
It avoids dividing by 8 when deserializing a tx, which is a slow
operation, and multiplies by 8 when verifying and extracing the
amount, which is much faster as well as less frequent
|
|
|
|
|
|
|
|
https://suyash67.github.io/homepage/assets/pdfs/bulletproofs_plus_audit_report_v1.1.pdf
|
|
|
|
|
|
|
|
* Remove `match_string()`, `match_number()`, and `match_word()`
* Remove `match_word_with_extrasymb()` and `match_word_til_equal_mark()`
* Adapt unit test for `match_number()` to `match_number2()`
* Adapt unit test for `match_string()` to `match_string2()`
Note: the unit tests were testing for the old version of the functions, and
the interfaces for these functions changed slightly, so I had to also edit
the tests.
As of writing, this PR has no merge conflicts with #8211
Additional changes during review:
* Explicitly set up is_[float/signed]_val to be changed before each call
* Structify the tests and fix uninitialized variables
|
|
In this repo, `boost::interprocess` was being used soley to make `uint32_t` operations atomic. So I replaced each instance of
`boost::interprocess::ipcdetail::atomic(...)32` with `std::atomic` methods. I replaced member declarations as applicable. For example,
when I needed to change a `volatile uint32_t` into a `std::atomic<uint32_t>`. Sometimes, a member was being used a boolean flag, so
I replaced it with `std::atomic<bool>`.
You may notice that I didn't touch `levin_client_async.h`. That is because this file is entirely unused and will be deleted in PR monero-project#8211.
Additional changes from review:
* Make some local variables const
* Change postfix operators to prefix operators where value was not need
|
|
|
|
|
|
f22051d replace erciccione's seednode with one on haveno's infrastructure (erciccione)
|
|
9bde2db Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168 (Jeffrey)
|
|
f68f927 Undefined behaviour fixes (SChernykh)
|
|
14eb42d systemd: remove outdated torsocks example (selsta)
|
|
5e201fe rpc: add explicit restricted flag to /get_info (tobtoht)
|
|
e5000a9 Balance includes unconfirmed transfers to self (woodser)
|
|
de4413b workflows: don't build PRs if only docs and READMEs are being changed (erciccione)
|
|
This commit adds a 'regexp' boolean field to the get_accounts
request. The flag is set to false by default and maintains backwards
compatibility. When set to true the user can search tags by regular
expression filters. An additional error message was added for failed
regular expression searches. Bump minor version to 25.
|
|
|
|
|
|
This comment suggests this check is unnecessary, when it is completely necessary as miner TXs can have multiple outputs *which is a statement directly, and incorrectly, contradicted by this comment*. While I don't ever see someone removing this code and getting their edits merged into Monero, someone inexperienced who thinks they're cleaning old code may break their own work, and then there's really just zero benefit to keeping this around.
|
|
|
|
|
|
|
|
b8beac3 Fix typos in docs (Robert Theis)
|
|
fb5b2b3 support authentication in monero-wallet-rpc set_daemon (woodser)
|
|
c36ea26 fix ge_p3_is_point_at_infinity(), which is evaluating field elements that haven't been reduced by the field order (koe)
|
|
e08abaa multisig key exchange update and refactor (koe)
|
|
06e6c8b crypto: fix constant randomx exceptions in large page allocator (moneromooo-monero)
|
|
|
|
This commit adds an option to export transaction
keys when performing export_transfers all. By passing
option=with_keys a new column 'tx key' will be
populated with respective keys.
|
|
|
|
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168
|
|
If allocating large pages fails, we don't try again.
This has the obvious drawback of not being able to use large pages
if they fail once.
|
|
Fixes issues reported in #8120
|
|
|
|
|
|
|
|
|
|
haven't been reduced by the field order
|
|
2d0a518 Update Copyright year in README.md (IceCruelStuff)
|
|
1051276 Update net_node.inl (Gingeropolous)
|
|
e73e1e7 Use CMD in Dockerfile (Kevin Thomas)
|
|
4446cc8 wallet inits cache if file and blob missing (woodser)
|
|
505b382 cmake: enable build on riscv{64, 32} (Xeonacid)
|
|
6366187 Fixed warnings for Clang (used as CMAKE_CXX compiler) (SerHack)
|
|
fef0280 Fix docker instructions to account for non-root user (Kevin Thomas)
|
|
6a46f8c Add copy commands for compiled binaries (Seth For Privacy)
52612e7 Add archive details to post-build section (Seth For Privacy)
03a256e Add git clone and cd commands for initial prep (Seth For Privacy)
cd76011 Add note on adding SSH keys for Github (Seth For Privacy)
9d02531 Update DOCKRUN.md (Seth For Privacy)
eeb0be4 Bump versions in DOCKRUN.md and add log commands (Seth For Privacy)
|
|
a02b342 Avoid unnecessary 'Invalid hashing blob' error message (rbrunner7)
|
|
361f621 Fix typos (Dimitris Apostolou)
|
|
|
|
|
|
|
|
According to Dockerfile best practices
(https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#entrypoint)
the best use for ENTRYPOINT is to set the image’s main command and then
use CMD as the default flags. This makes it easier to change the flags
passed to monerod when running the Docker image.
|
|
|
|
tested on Arch Linux RISC-V.
|
|
|
|
e9156d7 functional_tests: update uri test with external pid (selsta)
|
|
|
|
Since the non-root user 'monero' is specified in the Dockerfile, the
bind mount when running the container should be set to this user's home
directory be default, not the root user's home directory.
|
|
|
|
Also moved the tail of in-progress logs to two distinct and precise tail commands, was a good recommendation by @hyc.
|
|
|
|
|
|
|
|
|
|
6e6ad80 Fix Android OpenSSL build (Howard Chu)
|
|
53be72c make_uri disallows standalone payment ids (woodser)
|
