aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-08-28Add rct core testsmoneromooo-monero7-10/+764
2016-08-28Use the supplied hard fork version in validate_miner_transactionmoneromooo-monero1-1/+1
rather than using the current one. No functional changes, but may save some bugs in the future.
2016-08-28wallet: update spent status when an accepted tx disappearsmoneromooo-monero1-0/+19
2016-08-28wallet: reset output spent status on blockchain reorgmoneromooo-monero2-11/+61
If the blockchain gets reorganized, all outputs spent in the part of the blockchain that's blown away need to be reset to unspent (they may end up spent again on the blocks that replace the blocks that are removed, however).
2016-08-28ringct: catch errors from ge_frombytes_vartimemoneromooo-monero1-11/+12
2016-08-28tests: test for ringct rctSig data sizesmoneromooo-monero1-3/+44
ie, more data or less data than expected in various fields
2016-08-28ringct: add missing size check for ecdhInfomoneromooo-monero1-0/+1
2016-08-28ringct: change asserts to return false for boolean functionsmoneromooo-monero1-10/+10
2016-08-28add rct to the protocolmoneromooo-monero26-274/+1208
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-28db_lmdb: update reset for recent db changesmoneromooo-monero1-0/+10
- we need to drop the new m_tx_indices database - we reset the version to current version This fixes the core tests failing to initialize.
2016-08-28ringct: add functions to commit to an amountmoneromooo-monero2-0/+21
One to commit to an amount with zero key (for use with fake commitments for pre-rct outputs), and one with an arbitrary key (for rct outputs).
2016-08-28make rct tx serialization workmoneromooo-monero4-28/+305
It may be suboptimal, but it's a pain to have to rebuild everything when some of this changes. Also, no clue why there seems to be two different code paths for serializing a tx...
2016-08-28crypto: error out where appropriatemoneromooo-monero1-2/+2
2016-08-28ringct: allow no outputs, and add tests for this and feesmoneromooo-monero2-33/+75
2016-08-28ringct: make fee optionalmoneromooo-monero1-2/+9
2016-08-28ringct: txn fee stuffShen Noether4-13/+85
2016-08-28ringct: new {gen,decode}Rct APIs for conveniencemoneromooo-monero2-11/+27
A new version of genRct takes the mixRing as parameter, instead of the inPk. inPk are part of the mixRing, and it is cleaner to pass the mixRing data than to fetch it from the RingCT code. A new version of decodeRct also returns the mask. Also, failure to decode throws, so errors are properly detected.
2016-08-28ringct: add more convenience functionsmoneromooo-monero1-4/+14
2016-08-28core: link against libringctmoneromooo-monero1-0/+1
2016-08-28core: new /getrandom_rctouts.bin binary RPC callmoneromooo-monero7-0/+192
to get random ringct outputs to mix with
2016-08-28ringct: add convenience functions to bridge ringct and cryptonotemoneromooo-monero1-0/+5
2016-08-28blockchain_db: add functions for adding/removing/getting rct commitmentsmoneromooo-monero4-0/+157
2016-08-28ringct: restore verRange check in debug modemoneromooo-monero1-1/+1
2016-08-28ringct: add check for destinations/amount size being equalmoneromooo-monero1-0/+1
2016-08-28ringct: fix off by 1 in mixin usagemoneromooo-monero1-3/+3
2016-08-28ringct: simplify random key generationmoneromooo-monero1-7/+2
2016-08-28tests: new ringct test for checking H2 valuesShen Noether1-0/+11
Ported from Shen's RingCT repo
2016-08-28ringct: cosmetic fixesShen Noether4-46/+9
Ported from Shen's RingCT repo
2016-08-28ringct: changes to hashToPointSimple to calcualte H2 valuesShen Noether1-0/+5
Ported from Shen's RingCT repo
2016-08-28ringct: compare keys with bitwise equality, not crypto opsShen Noether1-7/+6
Ported from Shen's RingCT repo
2016-08-28ringct: fix size argument to cn_fast_hashShen Noether1-1/+1
Ported from Shen's RingCT repo
2016-08-28tests: zero inputs/outputs are in fact supposed to be acceptedmoneromooo-monero1-14/+14
2016-08-28ringct: add a test for prooveRange being non deterministicmoneromooo-monero1-0/+9
2016-08-28Fix sc_0 to skGen in ProveRangeShen Noether1-1/+1
2016-08-28ringct: add a few consts where appropriatemoneromooo-monero2-6/+6
2016-08-28tests: more ringct range proof testsmoneromooo-monero2-1/+246
2016-08-28rct: add serialization machinery to rct typesmoneromooo-monero2-10/+61
2016-08-28serialization: declare do_serialize specializations before usemoneromooo-monero2-1/+6
This lets my gcc picks those instead of the generic template where appropriate (and then fail since std::vector<something> does not have a serialize method.
2016-08-28Added note on generating H2Shen Noether1-1/+2
2016-08-28Fixed missing last index H2Shen Noether1-1/+2
2016-08-28remove original Cryptonote blockchain_storage blockchain formatmoneromooo-monero24-2966/+8
2016-08-28ringct: lock access to the PRNGmoneromooo-monero1-2/+2
2016-08-28ringct: add simple input validationmoneromooo-monero2-32/+74
Throw when inputs aren't the expected size.
2016-08-28tests: add some more ringct building block testsmoneromooo-monero1-1/+50
2016-08-28ringct: add convenience operators to keymoneromooo-monero1-0/+4
2016-08-28tests: add Shen Noether's basic ringct testsmoneromooo-monero2-1/+209
2016-08-28ringct: import of Shen Noether's ring confidential transactionsmoneromooo-monero15-13/+2410
2016-08-26Merge pull request #991Riccardo Spagni1-4/+12
f88029e db_lmdb: do not try to modify the database in read only mode (moneromooo-monero)
2016-08-26db_lmdb: do not try to modify the database in read only modemoneromooo-monero1-4/+12
2016-08-26Merge pull request #989Riccardo Spagni1-1/+1
0ed35f7 README.md: Boost version updated for windows (tobiasw2)
2016-08-26Merge pull request #986Riccardo Spagni1-1/+1
da58422 Update README.i18n (arb0r)
2016-08-26Merge pull request #984Riccardo Spagni2-2/+5
78035d2 Fix fake 'network synchronized, begin using' messages (Thomas Winget)
2016-08-26Merge pull request #982Riccardo Spagni1-1/+1
65238d2 fix #691 removed help about leaving wallet name empty on --generate-new-wallet (guzzi_jones)
2016-08-26Merge pull request #978Riccardo Spagni3-5/+103
99dd572 libwallet_api: tests: checking for result while opening wallet (Ilya Kitaev) bcf7b67 libwallet_api: Wallet::amountFromString fixed (Ilya Kitaev) 32bc7b4 libwallet_api: helper method to return maximumAllowedAmount (Ilya Kitaev) cbe534d libwallet_api: tests: removed logged passwords (Ilya Kitaev) b1a5a93 libwallet_api: do not store wallet on close if status is not ok (Ilya Kitaev)
2016-08-26Merge pull request #976Riccardo Spagni1-1/+8
c2f4e16 simplewallet: default to max-concurrency 1 on MacOS X (moneromooo-monero)
2016-08-25README.md: Boost version updated for windowstobiasw21-1/+1
2016-08-24Merge pull request #988Riccardo Spagni1-0/+1
5f873ea added Symas as a sponsor (Riccardo Spagni)
2016-08-24added Symas as a sponsorRiccardo Spagni1-0/+1
2016-08-24Merge pull request #981Riccardo Spagni1-1/+1
3729ac8 Docs: re-introduce Boost 1.58 min req from 2a2b655 (anonimal)
2016-08-24Merge branch 'ranok-patch-1'Riccardo Spagni1-8/+4
2016-08-24resolved conflicts in readme.mdRiccardo Spagni1-8/+4
2016-08-24Update README.i18narb0r1-1/+1
Fixed typo.
2016-08-23Fix fake 'network synchronized, begin using' messagesThomas Winget2-2/+5
2016-08-24fix #691 removed help about leaving wallet name empty on --generate-new-walletguzzi_jones1-1/+1
2016-08-23Docs: re-introduce Boost 1.58 min req from 2a2b655anonimal1-1/+1
2016-08-23libwallet_api: tests: checking for result while opening walletIlya Kitaev1-4/+6
2016-08-23libwallet_api: Wallet::amountFromString fixedIlya Kitaev2-1/+24
2016-08-23libwallet_api: helper method to return maximumAllowedAmountIlya Kitaev2-0/+6
2016-08-22Merge branch 'radfish-PR--readme-clarify-conf-syntax'Riccardo Spagni1-7/+44
2016-08-22fix README conflictsRiccardo Spagni1-7/+44
2016-08-22Merge pull request #972Riccardo Spagni1-1/+1
2c5e68f cmake: fix typo in handling of STACK_TRACE (redfish)
2016-08-22Merge pull request #970Riccardo Spagni1-0/+3
25f529a wallet: store key images after importing them (moneromooo-monero)
2016-08-22Merge pull request #968Riccardo Spagni1-0/+1
9cca53a wallet: fix build on Mac and Windows (missing include) (moneromooo-monero)
2016-08-22Merge pull request #967Riccardo Spagni1-1/+3
e596e25 simplewallet: do not suggest removing cache if the password was wrong (moneromooo-monero)
2016-08-22Merge pull request #964Riccardo Spagni2-8/+4
2a2b655 Build: make boost 1.58 minimum requirement. Fixes #956 (anonimal)
2016-08-22README formattingJacob Torrey1-4/+4
Very slight changes to make the markdown slightly more readable and easy to copy/paste from.
2016-08-22libwallet_api: tests: removed logged passwordsIlya Kitaev1-2/+2
2016-08-22libwallet_api: do not store wallet on close if status is not okIlya Kitaev2-5/+72
2016-08-21readme: format Windows deps as a listredfish1-1/+8
2016-08-21readme: formatting for rlwrap command snippetredfish1-2/+6
2016-08-21simplewallet: default to max-concurrency 1 on MacOS Xmoneromooo-monero1-1/+8
A suspected bug in pthread/kernel, though might be that I messed something up too... This might rope in more platforms though.
2016-08-20readme: add deps for documentationredfish1-1/+6
2016-08-20readme: add deps: miniupnpc and libunwindredfish1-0/+2
miniupnpc is included in source repo, but list it anyway, eventually that fork will hopefully go away from this repo.
2016-08-20readme: add pkg-config depredfish1-0/+1
2016-08-20readme: decrease size of sponsor logosredfish1-1/+6
2016-08-20readme: format dependencies into a list #951redfish1-2/+15
2016-08-20readme: clarify conf syntax re leading dashesredfish1-1/+1
2016-08-19cmake: fix typo in handling of STACK_TRACEredfish1-1/+1
This fixes the log output not getting redirected to log file.
2016-08-17wallet: store key images after importing themmoneromooo-monero1-0/+3
It avoids rescan_spent resetting spent status, for example.
2016-08-17wallet: fix build on Mac and Windows (missing include)moneromooo-monero1-0/+1
Reported by RaskaRuby, tested by iDunk5400.
2016-08-16simplewallet: do not suggest removing cache if the password was wrongmoneromooo-monero1-1/+3
2016-08-16Build: make boost 1.58 minimum requirement. Fixes #956anonimal2-8/+4
2016-08-16Merge pull request #963Riccardo Spagni2-5/+9
44dab04 Build: use libstdc++ with clang < 3.7 (anonimal) 455ded4 Build: use Boost 1.58 for Travis build. Refs #956 (anonimal)
2016-08-16Merge pull request #959Riccardo Spagni5-2/+50
7e4e002 daemon: print time to next fork (moneromooo-monero)
2016-08-16Build: use libstdc++ with clang < 3.7anonimal1-2/+2
2016-08-15Build: use Boost 1.58 for Travis build. Refs #956anonimal1-3/+7
2016-08-12daemon: print time to next forkmoneromooo-monero5-2/+50
2016-08-11Merge pull request #955Riccardo Spagni1-6/+12
7442dd0 More for Issue #855 (Howard Chu)
2016-08-11Merge pull request #948Riccardo Spagni16-80/+345
11dc091 Fake outs set is now decided by the wallet (moneromooo-monero) 1593553 new unlocked parameter to output_histogram (moneromooo-monero)
2016-08-11More for Issue #855Howard Chu1-6/+12
Plug rpage leak in cursor_set
2016-08-11Fake outs set is now decided by the walletmoneromooo-monero13-62/+304
This plugs a privacy leak from the wallet to the daemon, as the daemon could previously see what input is included as a transaction input, which the daemon hadn't previously supplied. Now, the wallet requests a particular set of outputs, including the real one. This can result in transactions that can't be accepted if the wallet happens to select too many outputs with non standard unlock times. The daemon could know this and select another output, but the wallet is blind to it. It's currently very unlikely since I don't think anything uses non default unlock times. The wallet requests more outputs than necessary so it can use spares if any of the returns outputs are still locked. If there are not enough spares to reach the desired mixin, the transaction will fail.
2016-08-11Merge pull request #953Riccardo Spagni1-2/+1
240864f db_lmdb: errors dropping hf starting height db on reset are not fatal (moneromooo-monero)
2016-08-11Merge pull request #952Riccardo Spagni2-4/+9
709c724 Better fix (#4) (hyc) d2644c1 fix restore-deterministic height (luigi1111)
2016-08-11Merge pull request #949Riccardo Spagni2-69/+64
da1007f simplewallet: make the refresh thread into more generic idle thread (moneromooo-monero)
2016-08-11Merge pull request #947Riccardo Spagni1-1/+2
663fc32 wallet2: if importing key images fails, print failure index (moneromooo-monero)
2016-08-11Merge pull request #943Riccardo Spagni4-53/+106
f0c0a3f Fix #864 Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true (guzzi_jones)
2016-08-11Merge pull request #940Riccardo Spagni1-0/+2
e890f51 Build: take out tests in Travis CI (anonimal) 198e408 Build: add vanilla clang to Travis CI (anonimal) 659bee6 Build: add make release-test to Travis CI (anonimal)
2016-08-11Merge pull request #939Riccardo Spagni2-42/+45
33b5ebd cmake: do not pass -O2 in debug build on ARM (redfish) 35dc40a cmake: libatomic only needed for 32-bit Clang builds (redfish) 042db0b cmake: cleanup logic that sets flags per target/subdir (redfish)
2016-08-10db_lmdb: errors dropping hf starting height db on reset are not fatalmoneromooo-monero1-2/+1
This db is now dropped unconditionally, so may or may not be there in the first place.
2016-08-09Better fix (#4)hyc2-4/+9
2016-08-09fix restore-deterministic heightluigi11111-2/+2
Simplewallet improperly skipped the restore from height code if restoring a deterministic wallet AND not specifying a wallet file in the command line. The other generate options require a wallet file as an argument, which prevents "ask_wallet_create_if_needed()" from being called, which in turn causes "m_generate_new" to remain unset. Specifying a wallet file at launch with --restore-deterministic emulated this behavior.
2016-08-07simplewallet: make the refresh thread into more generic idle threadmoneromooo-monero2-69/+64
2016-08-04wallet2: if importing key images fails, print failure indexmoneromooo-monero1-1/+2
2016-08-01cmake: do not pass -O2 in debug build on ARMredfish1-7/+8
Also, minor cleanup of redundant flag-setting code.
2016-08-01new unlocked parameter to output_histogrammoneromooo-monero9-18/+41
This constrains the number of instances of any amount to the unlocked ones (as defined by the default unlock time setting: outputs with non default unlock time are not considered, so may be counted as unlocked even if they are not actually unlocked).
2016-08-01Fix #864guzzi_jones4-53/+106
Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true
2016-07-30Build: take out tests in Travis CIanonimal1-1/+1
2016-07-29Build: add vanilla clang to Travis CIanonimal1-0/+2
2016-07-29Build: add make release-test to Travis CIanonimal1-1/+1
2016-07-28cmake: libatomic only needed for 32-bit Clang buildsredfish1-5/+3
2016-07-28cmake: cleanup logic that sets flags per target/subdirredfish2-32/+36
The previous logic that used a COMMON_*_FLAGS intermediate variable and then re-assigned CMAKE_*_FLAGS before including each subdirectory was confusing and ugly. This PR is the right way to do it. This commit is purely refactoring: built binaries unchanged.
2016-07-27Merge pull request #937Riccardo Spagni4-25/+35
0f990d0 cmake,common: flag for stack trace (redfish)
2016-07-27Merge pull request #936Riccardo Spagni4-19/+36
4618873 tests: fix a bitflag test typo (moneromooo-monero) 89e68d7 unit_tests: check adding checkpoints succeeded (moneromooo-monero) 121165f db_lmdb: add some missing api call checks (moneromooo-monero) 22d8344 core_rpc_server: fix gray/white peer list mixup (moneromooo-monero)
2016-07-27cmake,common: flag for stack traceredfish4-25/+35
By default the flag is enabled whenever libunwind is found on the system, with the exception of static build on OSX (for which we can't install the throw hook #932 due to lack of support for --wrap in OSX ld64 linker).
2016-07-26tests: fix a bitflag test typomoneromooo-monero1-1/+1
2016-07-26unit_tests: check adding checkpoints succeededmoneromooo-monero1-3/+3
2016-07-26db_lmdb: add some missing api call checksmoneromooo-monero1-14/+31
2016-07-26core_rpc_server: fix gray/white peer list mixupmoneromooo-monero1-1/+1
2016-07-26Merge pull request #928Riccardo Spagni8-1/+364
ebf97d7 wallet: new {ex,im}port_key_images commands and RPC calls (moneromooo-monero)
2016-07-26Merge pull request #931Riccardo Spagni1-3/+8
b3801fa hardfork: fix off by one in rescaning fork state after restart (moneromooo-monero)
2016-07-26Merge pull request #934Riccardo Spagni1-6/+17
4b3a788 cmake: install throw hook in OSX build too (redfish) 3c92c2f cmake: do not install hook on throw when building tests (redfish)
2016-07-26cmake: install throw hook in OSX build tooredfish1-0/+3
This is an attempt to fix build with STATIC=ON on OSX (#932): [ 95%] Linking CXX executable ../../bin/bitmonerod Undefined symbols for architecture x86_64: "___real___cxa_throw", referenced from: ___wrap___cxa_throw in libcommon.a(stack_trace.cpp.o) ld: symbol(s) not found for architecture x86_64
2016-07-26cmake: do not install hook on throw when building testsredfish1-6/+14
This fixes build of tests with STATIC=ON, which failed with: /tmp/cc8lNtqY.ltrans12.ltrans.o: In function `boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::thread_resource_error> >::rethrow() const [clone .lto_priv.41]': cc8lNtqY.ltrans12.o:(.text+0x4e): undefined reference to `__wrap___cxa_throw' The hook is implemented in libcommon, which is not linked into some of the test binaries. An alternative solution is to link all tests against libcommon, but that seems worse because it introduces a false dependency (also, I tried that and for some of the test binaries the linker still failed to pick up the symol from libcommon, strangely.)
2016-07-25hardfork: fix off by one in rescaning fork state after restartmoneromooo-monero1-3/+8
This code should die anyway.
2016-07-24Merge pull request #927Riccardo Spagni1-22/+4
8bed9a4 cmake: wallet: libunbound is not always static (redfish)
2016-07-24wallet: new {ex,im}port_key_images commands and RPC callsmoneromooo-monero8-1/+364
They are used to export a signed set of key images from a wallet with a private spend key, so an auditor with the matching view key may see which of those are spent, and which are not.
2016-07-23cmake: wallet: libunbound is not always staticredfish1-22/+4
It is not clear why libunbound was added to this in the first place, since it wasn't here before and #915 doesn't seem to introduce any new dependency on it. Tested build with STATIC=OFF (with and without libunbound-dev libunbound8 installed) and STATIC=ON, on Ubuntu Trusty, Debian Jessie, and Arch Linux. For static builds, beware of #926 and #907. If this hack was introduced to make it build on some other system (Windows? OS X?), then it will have to be dealt with, but not this way.
2016-07-23Merge pull request #923Riccardo Spagni1-0/+1
8312887 simplewallet: suggest removing cache when loading fails (moneromooo-monero)
2016-07-23Merge pull request #916Riccardo Spagni5-54/+243
b89b963 wallet: add unconfirmed incoming txes from the txpool (moneromooo-monero)
2016-07-23Merge pull request #915Riccardo Spagni7-75/+450
d7597c5 refreshing wallet even if error happened (Ilya Kitaev) 6d32a3d wallet_api: async init, Wallet::connected status, log level (Ilya Kitaev) 193d251 libwallet_api cmake: conditionally creating libwallet_merged2 only for STATIC build (Ilya Kitaev) 10c06dd wallet_api: segfault on refresh fixed (Ilya Kitaev) 9d2cb4f WalletListener functionality (Ilya Kitaev) d27b883 hack to successfull linking for MSYS2 (Ilya Kitaev) 083380c Transaction fee multiplier aka priority integraged (Ilya Kitaev) 00ed12b Wallet::paymentIdValid (Ilya Kitaev)
2016-07-23Merge pull request #910Riccardo Spagni1-0/+2
080a606 simplewallet: revert to foreground refresh at startup (moneromooo-monero)
2016-07-23Merge pull request #886Riccardo Spagni1-15/+22
dca9fe1 cmake: do not pass -Werror when building tests (redfish)
2016-07-23Merge pull request #920Riccardo Spagni1-0/+8
ca33ce6 include result in the notifications template (Riccardo Spagni) 2a8352d only alert on IRC when the status changes (Riccardo Spagni) 6b6fb7f add IRC notifications to travis (Riccardo Spagni)
2016-07-23include result in the notifications templateRiccardo Spagni1-1/+1
2016-07-23only alert on IRC when the status changesRiccardo Spagni1-0/+2
2016-07-23Merge pull request #924Riccardo Spagni1-1/+1
61ed40a Tests: fix signed/unsigned comparison in hash-target (anonimal)
2016-07-22cmake: do not pass -Werror when building testsredfish1-15/+22
The tests currently issue a warning that "warning: -fassociative-math disabled; other options take precedence" The associative math optimization is turned on indirectly by -Ofast. Apparently, the optimization is forced to be disabled, while compiling test harnesses generated by Google Test framework. Unfortunately, there is no -Wno-error=* flag to disable this warning (see gcc --help=warnings). An alternative to this patch is to disable the optimization explicitly with -fno-associative-math, but that seems worse. Another alternative is to not pass -Ofast for tests build, but we want the tests to be built with exact same optimization flags as the code being tested, otherwise the value of the tests is diminished. Another alternative is to remove -Werror from the entire build, but it's good to include that flag to preclude people leaving warnings. A note regarding implementation of not passing -Werror for tests: I considered filtering out -Werror from CMAKE_{C,CXX}_FLAGS but that seems to be worse because it's surprizing behavior, to those reading the code that adds -Werror. It is better to add it for when it is used and not added otherwise. I also considered relying on order, adding -Werror after inluding 'tests' subdir, but before including the other subdirs, but that also seems cryptic to the reader. So, I settled with the current solution, of explicitly setting CMAKE_{C,CXX}_FLAGS to different values before including the respective subdir. Testing done: compared compiler invocation for non-tests source files using `make VERBOSE=1` with and without this commit: the only difference is the position of -Werror. So, this commit doesn't change the binary.
2016-07-22Tests: fix signed/unsigned comparison in hash-targetanonimal1-1/+1
* References #886
2016-07-22simplewallet: suggest removing cache when loading failsmoneromooo-monero1-0/+1
2016-07-20wallet: add unconfirmed incoming txes from the txpoolmoneromooo-monero5-54/+243
Shown in show_transfers simplewallet command, and get_transfers RPC command, if req.pool is true.
2016-07-20simplewallet: revert to foreground refresh at startupmoneromooo-monero1-0/+2
Background refresh is confusing to users at startup.
2016-07-20add IRC notifications to travisRiccardo Spagni1-0/+6
2016-07-20Merge pull request #914Riccardo Spagni1-2/+2
87b1153 wallet2_api: use uint64_t for amounts (moneromooo-monero)
2016-07-20Merge pull request #919Riccardo Spagni1-7/+6
48e14ef fix atomic library to only fire off for clang (Riccardo Spagni) 39f7fad fix duplicate clang block in cmake (Riccardo Spagni)
2016-07-20Merge pull request #918Riccardo Spagni1-5/+5
b249482 Docs: fix 'Development Resources' formatting in README. (anonimal)
2016-07-20fix atomic library to only fire off for clangRiccardo Spagni1-3/+5
2016-07-20fix duplicate clang block in cmakeRiccardo Spagni1-4/+1
2016-07-20Docs: fix 'Development Resources' formatting in README.anonimal1-5/+5
2016-07-20Merge pull request #911Riccardo Spagni9-186/+9
d7b681c remove hf_starting_height db (moneromooo-monero)
2016-07-20Merge pull request #917Riccardo Spagni1-1/+1
ea44142 change travis badge (Riccardo Spagni)
2016-07-20change travis badgeRiccardo Spagni1-1/+1
2016-07-20Merge pull request #909Riccardo Spagni2-5/+34
bbba197 Docs: update 'Development Resources' in README. (anonimal) 2feb94b Travis-CI: add build-status badge to README.md (anonimal) f025622 Travis-CI: remote redundant make release-test. (anonimal) b332da3 Travis-CI: implement first-draft configuration. (anonimal)
2016-07-20Merge pull request #904Riccardo Spagni2-14/+41
f07f120 cmake: don't try to link with atomic on Apple (redfish) 19349d7 cmake: ARM: clang: make warning non-fatal: inline asm (redfish) f3e09f3 cmake: link with -latomic for clang (redfish) f4b35ae cmake: include -ldl via cmake built-in var (redfish) fa85cd8 common: stack trace: make clang happy with func ptrs (redfish) 4dce26b cmake: do not pass -stdlib=c++ to clang >=3.7 (redfish)
2016-07-20Merge pull request #902Riccardo Spagni7-18/+84
014f3a0 Add a daemon RPC version, and make simplewallet check it (moneromooo-monero)
2016-07-20Merge pull request #900Riccardo Spagni2-5/+3
78cc10f daemon: fix ban seconds being misinterpreted as absolute (moneromooo-monero) 34ecfdb rpc: fix get_bans and set_bans RPC names, they were missing a _ (moneromooo-monero)
2016-07-20Merge pull request #899Riccardo Spagni1-1/+8
a95a2cb wallet_rpc_server: add payment id from integrated addresses to extra (moneromooo-monero)
2016-07-20Merge pull request #897Riccardo Spagni1-14/+0
ce6b831 daemonizer: posix: keep parent's working dir and umask (redfish)
2016-07-20Merge pull request #896Riccardo Spagni1-1/+1
1e89f4f cmake: do not ignore dangerous warnings with -Wno-error (redfish)
2016-07-20Merge pull request #887Riccardo Spagni1-0/+5
ab25075 cmake: pass -fno-strict-aliasing to fix build with GCC 6.1.1 (redfish)
2016-07-20Merge pull request #818Riccardo Spagni8-1/+194
89d9f38 wallet: add command and RPC to sign/verify data (moneromooo-monero)
2016-07-19wallet: add command and RPC to sign/verify datamoneromooo-monero8-1/+194
Signing is done using the spend key, since the view key may be shared. This could be extended later, to let the user choose which key (even a per tx key). simplewallet's sign/verify API uses a file. The RPC uses a string (simplewallet can't easily do strings since commands receive a tokenized set of arguments).
2016-07-18refreshing wallet even if error happenedIlya Kitaev2-6/+18
2016-07-18wallet_api: async init, Wallet::connected status, log levelIlya Kitaev5-38/+172
2016-07-18libwallet_api cmake: conditionally creating libwallet_merged2 only forIlya Kitaev2-9/+17
STATIC build
2016-07-18wallet_api: segfault on refresh fixedIlya Kitaev2-5/+9
2016-07-18WalletListener functionalityIlya Kitaev5-52/+195
2016-07-18hack to successfull linking for MSYS2Ilya Kitaev1-2/+6
2016-07-18Transaction fee multiplier aka priority integragedIlya Kitaev4-4/+67
2016-07-18Wallet::paymentIdValidIlya Kitaev2-0/+7
2016-07-17wallet2_api: use uint64_t for amountsmoneromooo-monero1-2/+2
2016-07-13remove hf_starting_height dbmoneromooo-monero9-186/+9
It's not really needed, it used to be an optimization for when that code was not using the db and needed to recalculate things fast on startup.
2016-07-13Docs: update 'Development Resources' in README.anonimal1-5/+4
* Branch development was recently removed. All PR's now go directly to master. * Also, removed EOL whitespace
2016-07-13Travis-CI: add build-status badge to README.mdanonimal1-0/+2
* Currently points to anonimal/bitmonero. This should be changed to monero-project/bitmonero once the project signs-up for Travis-CI.
2016-07-13Travis-CI: remote redundant make release-test.anonimal1-1/+1
2016-07-12Travis-CI: implement first-draft configuration.anonimal1-0/+28
2016-07-12cmake: don't try to link with atomic on Appleredfish1-1/+1
-latomic is necessary with Clang on Linux, but apparently, on OSX it's not found.
2016-07-10cmake: ARM: clang: make warning non-fatal: inline asmredfish1-0/+3
Clang issues a warning for some inline asm in stack_trace.cpp. This patch ieaves the warning to be displayed as a reminder to fix the code.
2016-07-10cmake: link with -latomic for clangredfish1-0/+5
otherwise clang build fails with ../cryptonote_core/libcryptonote_core.a(miner.cpp.o): In function `std::__atomic_base<unsigned long long>::load(std::memory_order) const': /usr/bin/../lib/gcc/i686-pc-linux-gnu/6.1.1/../../../../include/c++/6.1.1/bits/atomic_base.h:396: undefined reference to `__atomic_load_8' This has no effect on the gcc build. The one strange thing is that test code like std::atomic<int> x; int main() { return x; } compiles and links without errors with clang, without -latomic. This alone would suggest that this patch is unnecessary, but that is not the case. It's not clear exactly why, though. The bitmonero code is including the same header, but it must be doing something more complex than in this test code snippet that causes the failure at link time pasted above. In any case, passing -latomic fixes the problem and seems safe. .
2016-07-10cmake: include -ldl via cmake built-in varredfish1-4/+1
This does two things: 1. fixes clang build, which otherwise errors with undefined symbol 'dlsym'. 2. simplifies the cmake script, delegating to cmake to figure out platform-specific flags for linking against the dl library.
2016-07-10common: stack trace: make clang happy with func ptrsredfish1-9/+29
Tested that it builds with: gcc 6.1.1, STATIC=OFF,i686 gcc 6.1.1, STATIC=OFF,armv7h clang 3.8, STATIC=OFF,i686 clang 3.8, STATIC=OFF,armv7h gcc 6.1.1, STATIC=ON,i686 clang 3.8, STATIC=ON,i686 Also tested that stack trace is generated fine on exception on: i686, gcc 6.1.1, STATIC=OFF (didn't bother testing all the other platforms/configs) This should fix the build problem on OSX (#871, #901), but I don't have OSX, so I could only test Clang on Linux.
2016-07-10cmake: do not pass -stdlib=c++ to clang >=3.7redfish1-2/+4
Tested on Linux (Arch) with clang 3.7 and 3.8 i686 and ARM: if -stdlib=c++ is passed to clang, then the build errors out with <string>,<iostrea>,etc. headers not found. Simply not passing the arg fixes the problem. **NOTE**: not tested on OSX.
2016-07-10Add a daemon RPC version, and make simplewallet check itmoneromooo-monero7-18/+84
If the version is different, simplewallet will refuse to use that daemon, unless --allow-mismatched-daemon-version is used.
2016-07-10daemon: fix ban seconds being misinterpreted as absolutemoneromooo-monero1-3/+1
Absolute to relative conversion is already done by the callee.
2016-07-10rpc: fix get_bans and set_bans RPC names, they were missing a _moneromooo-monero1-2/+2
2016-07-10wallet_rpc_server: add payment id from integrated addresses to extramoneromooo-monero1-1/+8
2016-07-09daemonizer: posix: keep parent's working dir and umaskredfish1-14/+0
Keep the working directory (and umask) inherited from the parent. Otherwise, it's impossible to control the working directory of the daemon (from systemd, for example). Furthermoer, bitmonerod attempts to create logging directories and files *in current working directory*. This fails due to permission denied and generates a (caught, nonfatal) exception. Below is the strace with this patch applied (so, no `chdir("/")`), showing successful opens at `log/` relative path. Without this patch they fail (sorry, didn't save the trace). ``` 28911 getcwd("/.../bitmonero", 128) = 25 28911 stat64("/var/lib/bitmonero/.bitmonero", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0 28911 stat64("/etc/bitmonerod.conf", {st_mode=S_IFREG|0644, st_size=244, ...}) = 0 28911 open("/etc/bitmonerod.conf", O_RDONLY|O_LARGEFILE) = 3 28911 open("/var/log/bitmonero/bitmonero.log", O_WRONLY|O_CREAT|O_APPEND|O_LARGEFILE, 0666) = 3 28911 stat64("log", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 stat64("log/dbg", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0 28911 open("log/dbg/main.log", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 4 ``` The reasoning of chdir("/") in order to prevent the daemon from holding a filesystem in busy state is not compelling at all: the choice of working directory for the daemon is the user's business not the daemon's.
2016-07-09cmake: do not ignore dangerous warnings with -Wno-errorredfish1-1/+1
Shorten the list of warnings that are reported, but which are forced to NOT generate an error, via -Wno-error. Unwhitelist these: strict-aliasing, sign-compare, type-limits For example, ignoring strict-aliasing warning caused lots of wasted time diagnosing Issue #847.
2016-07-08cmake: pass -fno-strict-aliasing to fix build with GCC 6.1.1redfish1-0/+5
This patch is a temprorary workaround until aliasing is fixed in the code (Issue #847).
2016-07-08Merge pull request #889Riccardo Spagni1-1/+1
a0bf85d wallet2_api: make this build (smatch needs .str() for /=) (moneromooo-monero)
2016-07-07wallet2_api: make this build (smatch needs .str() for /=)moneromooo-monero1-1/+1
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 17:33:36 +0000