| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
ef941855 Wallet RPC: Add prompt-for-password flag (Tim L)
|
|
998777ec Tx proof (revised): - refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string (stoffu)
|
|
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp
- allow an arbitrary message to be signed together with txid
- introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion
- wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof
- wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof
- get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
|
|
|
|
c4587e83 simplewallet: wrong ns for input_line in sweep_single (fix #2634) (stoffu)
|
|
|
|
c957795b fix output_stream_header memory leak (MaxXor)
|
|
ffe5b857 Correct totals computation (Michał Sałaban)
|
|
5d92c7cc wallet2: typo fix in error message (moneromooo-monero)
|
|
e3e838d0 kaccak: remove unused return value (moneromooo-monero)
4877aca2 keccak: some paranoid "can't happen" checks (moneromooo-monero)
|
|
b738f4b5 wallet: add sweep_single command (stoffu)
|
|
7cb303a4 wallet2: simplify incoming tx processing code (moneromooo-monero)
|
|
|
|
a17b8233 wallet2 bugfix: loading old m_unconfirmed_payments (stoffu)
|
|
|
|
987eb662 More missed readline dependencies thru scoped_message_writer (Howard Chu)
|
|
|
|
29cee4ec Fix 383ff4f68943c5d998fba8caa20aee481583f214 (Howard Chu)
b85e82bf Fix e89994e98f85be95d68c7bf471fcadf9aabbc93a (Howard Chu)
95e784ad Fix 437421ce42f1deaa7ec3f28c0c17aff519f1230d (Howard Chu)
|
|
Missed a crypto::null_pkey in PR#2629
|
|
Missed an input_line() change
|
|
Missing an error argument for an exception
|
|
b0416f07 checkpoints: add a testnet checkpoint at 1000000 (moneromooo-monero)
|
|
fc85d7a9 simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc (stoffu)
|
|
a3ea62f2 CMake: include RPC when building GUI deps (anonimal)
|
|
|
|
9ac52127 unit_tests: fix build after wallet2 list/vector change (moneromooo-monero)
|
|
f80f408b epee: don't disable -Wtautological-constant-out-of-range-compare on GCC (moneromooo-monero)
|
|
0f2c2d4c rpc: remove obsolete busy core checks (moneromooo-monero)
|
|
99f398a2 wallet2: avoid growing the short history when refreshing in a loop (moneromooo-monero)
|
|
0d9c0db9 Do not build against epee_readline if it was not built (Howard Chu)
178014c9 split off readline code into epee_readline (moneromooo-monero)
a9e14a19 link against readline only for monerod and wallet-wallet-{rpc,cli} (moneromooo-monero)
437421ce wallet: move some scoped_message_writer calls from the libs (moneromooo-monero)
e89994e9 wallet: rejig to avoid prompting in wallet2 (moneromooo-monero)
ec5135e5 move input_line from command_line to simplewallet (moneromooo-monero)
082db75f move cryptonote command line options to cryptonote_core (moneromooo-monero)
|
|
a17efcb0 make this build on SunOS/Solaris (Pavel Maryanov)
|
|
ad03f778 simplewallet: factor transfer related exception handling (moneromooo-monero)
|
|
383ff4f6 remove "using namespace std" from headers (moneromooo-monero)
|
|
|
|
It's a CLANG only option, and causes GCC to error out
|
|
|
|
|
|
|
|
|
|
|
|
|
|
wallet2 is a library, and should not prompt for stdin. Instead,
pass a function so simplewallet can prompt on stdin, and a GUI
might display a window, etc.
|
|
It was only used there, and this removes one part of the common
dependency on libreadline
|
|
Those have no reason to be in a generic module
|
|
|
|
This ensures they don't go out of sync when adding/changing them,
and makes the code easier to deal with.
|
|
It's nasty, and actually breaks on Solaris, where if.h fails to
build due to:
struct map *if_memmap;
|
|
wallet2::get_payments etc
|
|
0bf09154 Fix file permission issue (Tim L)
|
|
d70515fc Used declared default refresh status as default rather than it's current value (Maxime THIEBAUT)
|
|
fa514082 RPC: get_info add rpc_connections_count (Tim L)
|
|
68c01782 updates: add a special case for "install-" build tags on windows (moneromooo-monero)
|
|
424852a6 Fix 'sweep_all' command when called with no args (Leon Klingele)
|
|
f732e723 Disguise password length in prompt (Leon Klingele)
|
|
37e1fd94 simplewallet: mark the active account in print_accounts (moneromooo-monero)
|
|
6cf33446 Remove wallet dependency on p2p (moneromooo-monero)
|
|
9ff8e139 epee: disable a spurious warning for a storage function (moneromooo-monero)
|
|
7c7d3672 Increase LMDB maxreaders if large number of threads in use (Howard Chu)
6738753b Use max_concurrency as-is (Howard Chu)
|
|
4a17f0c2 rpc: add performance timers (moneromooo-monero)
|
|
a524b750 rpc: added miner_tx_hash to resp of getblock (stoffu)
|
|
ba1b89fb Updated OpenBSD build instructions and fixed libressl linking issue (ston1th)
|
|
9d6c6c5d wallet2: do not bother downloading block hashes below last checkpoint (moneromooo-monero)
|
|
|
|
2677ade5 simplewallet: forbid 0 ring size (moneromooo-monero)
da8b60cb simplewallet: reject attempts to use too low mixin early (moneromooo-monero)
|
|
110339f5 unit_tests: fix data dir determination (moneromooo-monero)
|
|
867b67c4 Wallet API: override update subdir when built from src (Jaquee)
|
|
d269bff2 wallet2: use a vector, not a list, for selected_transfers (moneromooo-monero)
|
|
937e7f8a Initialize openssl on startup (moneromooo-monero)
|
|
It'd be interpreted as a huge one (~0 fake outs)
|
|
f92f1606 core_tests: do not include chaingen_tests_list.h in all tests (moneromooo-monero)
|
|
This yields a clear error message rather then some possibly
confusing more technical errors down the line
|
|
21b9f6f3 always use core_tests for consistency, not coretests (moneromooo-monero)
|
|
1ff638e9 protocol: drop connections which don't handshake after some time (moneromooo-monero)
|
|
105425b7 simplewallet: reject invalid argument for boolean parameter (stoffu)
|
|
8ddcf1e7 simplewallet: remove XMR mentions (moneromooo-monero)
|
|
ec48e8d8 core: do not forbid txes without destination (moneromooo-monero)
523084bc core: don't add empty additional pub keys field to extra (moneromooo-monero)
|
|
00cc1fdd subaddress: remove unneeded scalarmultBase (kenshi84)
|
|
4fb77946 unit tests: OOB indexes & adding subaddress (Cole Lightfighter)
4fd6a3d2 Subaddress unit tests (Cole Lightfighter)
|
|
ac4018a7 wallet2: workaround for lightwallet before supporting subaddress (followup #2656) (kenshi84)
|
|
118a1bed rpc: make get_coinbase_tx_sum a restricted RPC (moneromooo-monero)
|
|
6bab9efe debug utils: fix debug build: rm unused identifier (redfish)
b92d3f96 cmake: fix shared library build (redfish)
|
|
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
|
|
0aa4cc80 ITS#8339 Solaris 10/11 robust mutex fixes (Howard Chu)
|
|
6bd4dac6 util: ignore SIGPIPE (moneromooo-monero)
|
|
7dbf76d0 Fix an object lifetime bug in net load tests (moneromooo-monero)
|
|
10013e94 Protect node privacy by proper filtering in restricted-mode RPC answers (binaryFate)
|
|
ccf53a56 track double spending in the txpool (moneromooo-monero)
|
|
78cf010e Add stoffu's GPG key (stoffu)
|
|
|
|
|
|
|
|
|
|
Friendlier on memory/speed, we know in advance the max amount
of items, which are small and constant size, and there's a lot
of list walking involved.
|
|
|
|
Makes working on testnet a lot easier (much less I/O when loading
and saving wallets, and exercises the hashchain code before any
changes are merged)
|
|
11e0deef cmake: add dep of version lib on version.cpp (redfish)
35340259 .gitignore: do not ignore cmake source files (redfish)
|
|
|
|
This patch allows to filter out sensitive information for queries that rely on the pool state, when running in restricted mode.
This filtering is only applied to data sent back to RPC queries. Results of inline commands typed locally in the daemon are not affected.
In practice, when running with `--restricted-rpc`:
* get_transaction_pool will list relayed transactions with the fields "last relayed time" and "received time" set to zero.
* get_transaction_pool will not list transaction that have do_not_relay set to true, and will not list key images that are used only for such transactions
* get_transaction_pool_hashes.bin will not list such transaction
* get_transaction_pool_stats will not count such transactions in any of the aggregated values that are computed
The implementation does not make filtering the default, so developers should be mindful of this if they add new RPC functionality.
Fixes #2590.
|
|
|
|
|
|
37c3792b wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked balance() (stoffu)
|
|
|
|
|
|
balance()
|
|
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.
Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
|
|
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
|
|
8041b4e9 wallet-cli: allow priority argument for sweep_all and donate (stoffu)
|
|
93ad1f87 Fix #2559: more flexible print_tx daemon command (binaryFate)
|
|
b2d416f2 Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
|
|
ff7745bb Edited test readme for accuracy and depth (Cole Lightfighter)
c300ae56 Added test documentation & Keccak unit test (Cole Lightfighter)
f6119a8e Added test documentation & Keccak unit test (Cole Lightfighter)
|
|
161401dd Fix JSON-RPC response object over ZMQ (Lee Clagett)
|
|
|
|
This branch fixes a file permission issue introduced by https://github.com/monero-project/monero/commit/69c37200aa87f100f731e755bdca7a0dc6ae820a
|
|
|
|
88ebfd64 core_tests: fix for subaddress patch (kenshi84)
e373a203 performance_tests: add master spend pubkey to subaddress hashtable (kenshi84)
|
|
Those will have a ".exe" file extension, not .zip.
|
|
Executing 'sweep_all' with no arguments segfaulted before.
|
|
|
|
|
|
|
|
Don't try to 2nd guess user
|
|
|
|
8233a24b unit_tests: fix build on windows (moneromooo-monero)
|
|
6a90506a Link against libpgm/libnorm if found, optional libzmq ldependencies (moneromooo-monero)
|
|
4b228dd3 cmake: epee: use var from FindOpenSSL.cmake (redfish)
29497f79 epee: use boost type for SSL error code (redfish)
|
|
d0463312 fix libwallet api test after api change (Jaquee)
a46c1eed Wallet2: Don't throw when subaddress label doesn't exist (Jaquee)
086b7db2 Wallet API: default values for account and subaddr index (Jaquee)
|
|
52c13810 blockchain_utilities: Add monero-blockchain-{ex,im}port binaries to default install targets (Bertrand Jacquin)
|
|
66255c0e Problem: Copyright notice is very confusing (Gareth)
|
|
69c37200 RPC Add cross origin resource sharing support (Tim L)
|
|
fab3b722 Add more specific RPC error codes (Michał Sałaban)
|
|
935f7462 blockchain: do not lock the blockchain lock for simple DB getters (moneromooo-monero)
|
|
626e8078 wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
|
|
44f14638 wallet2: fix tx size estimator for large number of inputs (moneromooo-monero)
|
|
f946bb7b fixed an LMDB issue on OpenBSD (#2699) which leads to a crash in monerod (ston1th)
|
|
969b5a2a net_helper: fix massive slowdown after SSL support (moneromooo-monero)
|
|
4dd05a2f subaddress: change prefix so that it starts with 8 (kenshi84)
|
|
ca87cbd8 wallet2: fix subaddress fields serialization (moneromooo-monero)
|
|
|
|
|
|
Enable with perf:DEBUG
|
|
It is safe in those cases, though might return slightly out of date
information if another thread is busy modifying the blockchain,
but it avoids potentially lengthy delays just to get things like
the current blockchain height.
|
|
|
|
|
|
|
|
|
|
Issue: #2575
Build instructions for OpenBSD 6.2:
* boost (built with clang)
* cppzmq
Fixed a issue, where cmake was not able to find and link against libressl in unbound.
restored OpenBSD 5.8 build instructions
|
|
|
|
|
|
|
|
|
|
When loading an older wallet cache, they wouldn't be initialized,
leading them to have random(ish) values, and so assigned to some
random subaddress.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, move cmake source files into cmake/ to keep them together.
|
|
|
|
This fixes all tests being annoyingly rebuilt when one changes
|
|
|
|
Tests for checking proper error throwing for out-of-bounds subaddress
indexes, and proper addition of subaddresses.
Signed-off-by: Cole Lightfighter <cole@onicsla.bz>
|
|
Other tests use unit_tests, performance_tests, etc.
This fixes getting it wrong half the time when typing.
|
|
Solution: add line break to copyright notice and fix grammar.
|
|
They are actually wrong if the wallet is setup in a different
denomination, and it's incursion of extrinsic lingo where monero
fits perfectly in the first place.
|
|
This was spuriously forbidden in the recent subaddress patch,
which isn't inherently incompatible with these.
|
|
Saves a couple bytes per tx
|
|
|
|
This fixes linking when path to openssl
is defined manually:
cmake -DOPENSSL_ROOT_DIR='/usr/include/openssl-1.0;/usr/lib/openssl-1.0' ...
This is useful for building with OpenSSL v1.0
when default system installation is v1.1.
The linking error is undefined SSL_load_error_strings symbol.
This is due to -L /usr/lib/openssl-1.0 not making it onto
the linkline (so -lssl pulls in the default system openssl).
|
|
Fixes compile error when building with OpenSSL v1.1:
contrib/epee/include/net/net_helper.h: In member function ‘void epee::net_utils::blocked_mode_client::shutdown_ssl()’:
contrib/epee/include/net/net_helper.h:579:106: error: ‘SSL_R_SHORT_READ’ was not declared in this scope
if (ec.category() == boost::asio::error::get_ssl_category() && ec.value() != ERR_PACK(ERR_LIB_SSL, 0, SSL_R_SHORT_READ))
^
contrib/epee/include/net/net_helper.h:579:106: note: suggested alternative: ‘SSL_F_SSL_READ’
See boost/asio/ssl/error.hpp.
Boost handles differences between OpenSSL versions.
cmake: fail if Boost is too old for OpenSSL v1.1
|
|
Basic unit test fixture, and initialization of a subaddress account.
Signed-off-by: Cole Lightfighter <cole@onicsla.bz>
|
|
|
|
|
|
Fix #1530
|
|
Reported by iDunk on IRC
|
|
|
|
#2656)
|
|
|
|
default install targets
Binaries available to download on https://getmonero.org/downloads/ as
embedding monerod, monero-wallet-{cli,rpc} and
monero-blockchain-{ex,im}port.
This change synchronise download results with a manual build from
source
|
|
4d35ad76 Fix compiler warnings with Clang 6.0.0. (Vasil Dimov)
|
|
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{ }
monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
tools::signal_handler::install([&wrpc, &wal](int) {
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
|
|
fddd8d22 performance_tests: fix build after subaddress patch (moneromooo-monero)
|
|
|
|
52ec0e7f epee: link against ssl/crypto for the new SSL code (moneromooo-monero)
|
|
|
|
3492de01 fix lightwallet and subaddresses conflict (Jaquee)
329f149e remove reference to cryptonote::null_hash (Jaquee)
|
|
|
|
|
|
22b51e06 db_lmdb: include chain height when failing to find an output key (moneromooo-monero)
5db433b3 blockchain: avoid exceptions in output verification (moneromooo-monero)
|
|
529a6a4a core: guard against a mined block not finding all txes in the pool (moneromooo-monero)
|
|
2051f89f cmake: build tests last (redfish)
|
|
44c1d160 unit_tests: fix compiling on Windows (iDunk5400)
|
|
fe484f30 unit_tests: data dir is now overridden with --data-dir (moneromooo-monero)
|
|
4090e8c6 simplewallet: add get/set for refresh-from-height (moneromooo-monero)
|
|
0a872798 protocol: kick idle peers by dropping them (moneromooo-monero)
|
|
bc1b9333 frob level 1 logs a bit for consistency (moneromooo-monero)
|
|
885c773a cmake: print which stack trace lib is used (redfish)
|
|
b776c725 daemon: use @N syntax to output_histogram for specific amounts (moneromooo-monero)
|
|
c4136134 miner: always update block template when starting (moneromooo-monero)
|
|
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
|
