| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
and remove a leftover debugging sanity check
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
also avoid integer underflow on zero height
|
|
|
|
ceabc4f9 change the N-1/N multisig second message signer for auth (moneromooo-monero)
55c2845d core_tests: multisig test now tests multiple inputs (moneromooo-monero)
98db7ee4 wallet: factor multisig info parsing (moneromooo-monero)
31a97e76 wallet: use raw encrypted data in multisig import/export RPC (moneromooo-monero)
2fa707d1 wallet: add multisig sign/submit RPC (moneromooo-monero)
e36f5b60 Match surae's recommendation to derive multisig keys (moneromooo-monero)
a36c261d wallet2: fix slow multisig unit tests with subaddress patch (moneromooo-monero)
fa569712 make multisig work with subaddresses (moneromooo-monero)
dffa0dce simplewallet: add export_raw_multisig command (moneromooo-monero)
7f4c220b simplewallet: add multisig to wallet type in wallet_info output (moneromooo-monero)
26529038 wallet: guard against partly initialized multisig wallet (moneromooo-monero)
66e34e85 add multisig core test and factor multisig building blocks (moneromooo-monero)
f4eda44c N-1/N multisig (moneromooo-monero)
cd64c799 multisig address generation RPC (moneromooo-monero)
fff871a4 gen_multisig: generates multisig wallets if participants trust each other (moneromooo-monero)
95a21a79 wallet2: allow empty wallet filename to avoid saving data (moneromooo-monero)
b84b3565 tests: add multisig unit tests (moneromooo-monero)
4c313324 Add N/N multisig tx generation and signing (moneromooo-monero)
6d219a92 wallet: add multisig key generation (moneromooo-monero)
|
|
d9b137f1 cryptonote_core: fix blockchain init call after prototype change (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
While there, move the wallet2 ctor to the cpp file as it's a huge
amount of init list now, and remove an unused one.
|
|
Thanks to kenshi84 for help getting this work
|
|
It exports raw transactions, so they may be used by other tools,
for instance to be relayed to the network externally.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Useful to speed tests up and avoid unnecessary leftover files
|
|
|
|
Scheme by luigi1111:
Multisig for RingCT on Monero
2 of 2
User A (coordinator):
Spendkey b,B
Viewkey a,A (shared)
User B:
Spendkey c,C
Viewkey a,A (shared)
Public Address: C+B, A
Both have their own watch only wallet via C+B, a
A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants)
A and B watch for incoming outputs
B creates "half" key images for discovered output D:
I2_D = (Hs(aR)+c) * Hp(D)
B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D),
and sending the pubkeys with I2_D.
A also creates "half" key images:
I1_D = (Hs(aR)+b) * Hp(D)
Then I_D = I1_D + I2_D
Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction).
A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D
to his own generated ones where they are needed (secret row L, R).
At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r,
which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo).
B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well).
B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D
to his cache, allowing him to verify spent status as well.
NOTE:
A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively.
Otherwise, trickery like the following becomes possible:
A creates viewkey a,A, spendkey b,B, and sends a,A,B to B.
B creates a fake key C = zG - B. B sends C back to A.
The combined spendkey C+B then equals zG, allowing B to spend funds at any time!
The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature).
2 of 3
User A (coordinator)
Shared viewkey a,A
"spendkey" j,J
User B
"spendkey" k,K
User C
"spendkey" m,M
A collects K and M from B and C
B collects J and M from A and C
C collects J and K from A and B
A computes N = nG, n = Hs(jK)
A computes O = oG, o = Hs(jM)
B anc C compute P = pG, p = Hs(kM) || Hs(mK)
B and C can also compute N and O respectively if they wish to be able to coordinate
Address: N+O+P, A
The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other
needed part of the signature/key images from either of the other two.
Alternatively, if secure communication exists between parties:
A gives j to B
B gives k to C
C gives m to A
Address: J+K+M, A
3 of 3
Identical to 2 of 2, except the coordinator must collect the key images from both of the others.
The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it
or send it back to A.
N-1 of N
Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around
(using either the secure or insecure method).
For example (ignoring viewkey so letters line up):
[4 of 5]
User: spendkey
A: a
B: b
C: c
D: d
E: e
a -> B, b -> C, c -> D, d -> E, e -> A
Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with
the transaction so the signers know if they should use 1 or both keys.
Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each.
Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning:
1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image)
2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator
must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use.
You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might
also be straightforward enough to support with minimal changes from N-1 format.
You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc.
The process is somewhat cumbersome:
To create a N/N multisig wallet:
- each participant creates a normal wallet
- each participant runs "prepare_multisig", and sends the resulting string to every other participant
- each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N)
As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent:
- each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant
- each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants
Then, a transaction may be initiated:
- one of the participants runs "transfer ADDRESS AMOUNT"
- this partly signed transaction will be written to the "multisig_monero_tx" file
- the initiator sends this file to another participant
- that other participant runs "sign_multisig multisig_monero_tx"
- the resulting transaction is written to the "multisig_monero_tx" file again
- if the threshold was not reached, the file must be sent to another participant, until enough have signed
- the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
|
|
Scheme by luigi1111
|
|
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
|
|
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero)
bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero)
4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
|
|
09ce03d6 move includes around to lessen overall load (moneromooo-monero)
|
|
The shared RPC code is now moved off into a separate lib
|
|
These even had the epee namespace.
This fixes some ugly circular dependencies.
|
|
As a followon side effect, this makes a lot of inline code
included only in particular cpp files (and instanciated
when necessary.
|
|
|
|
Partially implements #74.
Securely erases keys from memory after they are no longer needed. Might have a
performance impact, which I haven't measured (perf measurements aren't
generally reliable on laptops).
Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod
functions. Using overloads + SFINAE instead generalizes it so other types can
be marked as scrubbed without adding more boilerplate.
|
|
41fc11fa Scheduled mandatory software upgrades (xmr-eric)
3b5382fe Keep VRP a proper noun (xmr-eric)
7160cbd6 CONTRIBUTING.md capitalization (xmr-eric)
f36ffc07 Shorten a title, remove a section, small edits (xmr-eric)
00179917 Capitalization on first word only (xmr-eric)
6ffae079 Readme.md: Normalize heading capitalization (xmr-eric)
|
|
abebe392 rpc: add offline state in info rpc (moneromooo-monero)
7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
|
|
25f4ab81 fixed linking against libreadline on OpenBSD (ston1th)
|
|
1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric)
3f18c642 Fix password capitalization mismatch (xmr-eric)
|
|
2b0a32f8 Small cleanup of daemon synchronization output (xmr-eric)
|
|
cf5f6236 Corrections in rate limiting / trottle code, especially in 'out' direction (rbrunner7)
|
|
a1e3670b catch wallet decrypt false positive (Riccardo Spagni)
|
|
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero)
7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero)
54950829 use memwipe in a few relevant places (moneromooo-monero)
000666ff add a memwipe function (moneromooo-monero)
|
|
009eed17 rpc: increase the max number of outs one can request (moneromooo-monero)
|
|
3af19c80 set_node command, allows setting node without restart (Tobias Hoffmann)
|
|
b927f0b1 cryptonote_protocol: fix corner case looping asking for same block hashes (moneromooo-monero)
|
|
27aa8ce9 net_utils_base: fix peer list parsing (moneromooo-monero)
fe5ab2c4 epee: fix kv_unserialize return value when a field is not found (moneromooo-monero)
|
|
5cc84693 easylogging: show the 'no stack trace' warning only once (ston1th)
|
|
Fields are written with their "name" as key, and that name changed.
|
|
46eaaae7 ringct: always use outPk.mask to decode amounts (moneromooo-monero)
|
|
|
|
8d4469a0 ringct: do not include bulletproof commitments in signed message (moneromooo-monero)
|
|
ead48f7d core: fix input ordering from v7 (moneromooo-monero)
|
|
Those are not serialized, but are restored from the outPk masks,
so depending on what tries to validate the tx, those commitments
may or may not be filled with valid data at the time. The outPk
masks are already hashed as part of the rctSigBase field.
|
|
|
|
If execinfo.h is not available, output the stack trace warning only once, so we don't spam the build logs with it.
|
|
c83d0b3e add bulletproofs from v7 on testnet (moneromooo-monero)
8620ef0a bulletproofs: switch H/G in Pedersen commitments to match rct (moneromooo-monero)
d58835b2 integrate bulletproofs into monero (moneromooo-monero)
90b8d9f2 add bulletproofs to the build, with basic unit tests (moneromooo-monero)
fe120264 perf_timer: add non scoped start/stop timer defines (moneromooo-monero)
ada42914 add a version of ge_double_scalarmult_precomp_vartime with A precomp (moneromooo-monero)
d43eef6d ringct: add a version of addKeys which returns the result (moneromooo-monero)
7ff07928 sc_mul and sc_muladd (luigi1111)
3d0b54bd epee: add do while(0) around brace statement in a macro (moneromooo-monero)
|
|
|
|
Changes from sarang
|
|
|
|
Based on Java code from Sarang Noether
|
|
|
|
|
|
|
|
|
|
|
|
Allows use in more complex expressions
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
c256a248 Android dockerfile: add zmq dependency (MoroccanMalinois)
|
|
8198f031 Add mdb_drop tool (Howard Chu)
|
|
26ce640f Update README.md with info about release timelines (Gingeropolous)
|
|
23b6f685 RPC: allow binding of restricted port in addition to core port (Tim L)
|
|
b0426d4c Fixes #759 Add sanity check on restore height (Cifrado)
|
|
36b41ab2 added missing link for OpenBSD build instructions (ston1th)
|
|
c0ae52c0 simplewallet: prevent (wrong) integrated adresses on accounts > 0 (moneromooo-monero)
|
|
631b35e7 CONTRIBUTING.md: mention git add -p as a way to avoid spurious changes (moneromooo-monero)
|
|
d875a9ff wallet2: detect multiple outputs from a tx to different subaddresses (moneromooo-monero)
|
|
7256d9a7 Fix versioning (vdo)
e459d467 Update snap version to 0.11.1 (vdo)
|
|
f9fad186 blockchain_db: sanity check on tx/hash vector sizes (flozilla)
|
|
310b790a make connection_id a string in RPC (moneromooo-monero)
|
|
e41cc58d Fix docker image dependencies, don't install libraries statically linked (Bruno Clermont)
2ddbc3ef use make (Bruno Clermont)
81ac0e91 Force docker image to use --non-interactive (Bruno Clermont)
e03be11a fix and improve docker image, add doc for docker-compose (Bruno Clermont)
|
|
287dde63 Added command descriptions (Cifrado)
|
|
d73d7aca Add two configuration options to monerod.service: (0xB44EFD8751077F97)
|
|
f5461a6a RPC: CORS add Access-Control-Allow-Headers to OPTIONS preflight (Tim L)
|
|
6cbe7bcd wallet2: check generate_key_derivation return value (moneromooo-monero)
|
|
|
|
|
|
|
|
Deleted 3 out of 4 calls to method connection_basic::sleep_before_packet
that were erroneous / superfluous, which enabled the elimination of a
"fudge" factor of 2.1 in connection_basic::set_rate_up_limit;
also ended the multiplying of limit values and numbers of bytes
transferred by 1024 before handing them over to the global throttle
objects
|
|
To fix the linking error described here https://github.com/monero-project/monero/pull/2841#issuecomment-346129030 we also need to link libcurses.
|
|
Monero.ts: Fewer pleases in seed NOTE
Monero_it.ts: Fewer pleases in seed NOTE
Monero_fr.ts: Fewer pleases in seed NOTE
|
|
|
|
|
|
It will be reinitialized later once we know about log file
and other command line configuration
|
|
|
|
It's meant to avoid being optimized out
memory_cleanse lifted from bitcoin
|
|
Add period to second sentence
|
|
37c1ce3b tests: disable libwallet_api_tests when BUILD_GUI_DEPS is not set (moneromooo-monero)
|
|
36f0538a cmake: fix building when readline is not found (moneromooo-monero)
|
|
0b08bf39 fixed common/util.cpp to link against libressl (ston1th)
|
|
|
|
|
|
fdf0acbf Tools, daemonizer: fix building on Windows (iDunk5400)
|
|
ac5cd865 simplewallet: fix typo in incoming monero message (moneromooo-monero)
|
|
51895fd7 split wallet and wallet_api (moneromooo-monero)
|
|
0d149f70 Add out-of-bound exceptions and handle them in RPC (Michał Sałaban)
|
|
93c33985 simplewallet: translate ring size 0 to mixin 0 (default values) (moneromooo-monero)
|
|
f493eabb unit_tests: fix running without --data-dir (moneromooo-monero)
|
|
61712384 daemon & simplewallet: don't set max-concurrency when unspecified (stoffu)
|
|
da706b61 Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized' (binaryFate)
|
|
0b726be7 wallet2: minimize the number of construct_tx calls (moneromooo-monero)
9d505d26 wallet2: cleanup some debug logs (moneromooo-monero)
|
|
7e387fb1 wallet2: only add a dummy 0 output if there's one output otherwise (moneromooo-monero)
|
|
b42ee213 Wallet: update ring size in outdated error msgs with set_default_ring_size (binaryFate)
|
|
54a4c1cb cryptonote: do not overwrite const data (moneromooo-monero)
|
|
b0b7e0f0 Spend proof without txkey (stoffu)
|
|
43f27c7d core: warn when free disk space is low (moneromooo-monero)
|
|
3501ed1f Do not require libatomic on FreeBSD (Vasil Dimov)
|
|
47c0948a Implement missing miner functions on FreeBSD (Vasil Dimov)
fdb5bd16 Remove unused variables and fix typos in comments (Vasil Dimov)
|
|
5b452248 fixed easylogging compile issue on OpenBSD (Dyrcona)
|
|
9739da1e wallet_rpc_server: new relay_tx command (moneromooo-monero)
01dc8297 wallet: transfer RPC can now return tx metadata (pending_tx) (moneromooo-monero)
83fa9047 serialization: add std::set and std::unordered_set serialization (moneromooo-monero)
|
|
2d1ccc1b mnemonics: support for arbitrary (if multiple of 4 bytes) length data (moneromooo-monero)
|
|
be1c0129 fix for tx proof: use exception instead of error_str when signature gen failed (stoffu)
|
|
It takes a full tx+metadata hex string as input
|
|
|
|
|
|
It's getting hit too easily
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
416a7933 Print msg upon success for commands that were silent (binaryFate)
|
|
ef941855 Wallet RPC: Add prompt-for-password flag (Tim L)
|
|
998777ec Tx proof (revised): - refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp - allow an arbitrary message to be signed together with txid - introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion - wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof - wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof - get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string (stoffu)
|
|
|
|
|
|
Added a heading in the readme that describes the release staging schedule and protocol.
|
|
|
|
|
|
- refactoring: proof generation/checking code was moved from simplewallet.cpp to wallet2.cpp
- allow an arbitrary message to be signed together with txid
- introduce two types (outbound & inbound) of tx proofs; with the same syntax, inbound is selected when <address> belongs to this wallet, outbound otherwise. see GitHub thread for more discussion
- wallet RPC: added get_tx_key, check_tx_key, get_tx_proof, check_tx_proof
- wallet API: moved WalletManagerImpl::checkPayment to Wallet::checkTxKey, added Wallet::getTxProof/checkTxProof
- get_tx_key/check_tx_key: handle additional tx keys by concatenating them into a single string
|
|
|
|
|
|
|
|
It's sent as JSON, so raw binary is not appropriate
|
|
|
|
|
|
|
|
Restart=always
PrivateTmp=true
|
|
|
|
This speeds up building a lot when wallet2.h (or something it
includes) changes, since all the API includes wallet2.h
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Avoids turning it to a huge number
|
|
c4587e83 simplewallet: wrong ns for input_line in sweep_single (fix #2634) (stoffu)
|
|
|
|
While there, also use the new is_arg_defaulted API instead of
going to poke the internal API directly.
|
|
It could trip on a corrupt/crafted file if the user has disabled
input verification.
|
|
c957795b fix output_stream_header memory leak (MaxXor)
|
|
ffe5b857 Correct totals computation (Michał Sałaban)
|
|
5d92c7cc wallet2: typo fix in error message (moneromooo-monero)
|
|
e3e838d0 kaccak: remove unused return value (moneromooo-monero)
4877aca2 keccak: some paranoid "can't happen" checks (moneromooo-monero)
|
|
b738f4b5 wallet: add sweep_single command (stoffu)
|
|
7cb303a4 wallet2: simplify incoming tx processing code (moneromooo-monero)
|
|
|
|
a17b8233 wallet2 bugfix: loading old m_unconfirmed_payments (stoffu)
|
|
|
|
987eb662 More missed readline dependencies thru scoped_message_writer (Howard Chu)
|
|
|
|
29cee4ec Fix 383ff4f68943c5d998fba8caa20aee481583f214 (Howard Chu)
b85e82bf Fix e89994e98f85be95d68c7bf471fcadf9aabbc93a (Howard Chu)
95e784ad Fix 437421ce42f1deaa7ec3f28c0c17aff519f1230d (Howard Chu)
|
|
Missed a crypto::null_pkey in PR#2629
|
|
Missed an input_line() change
|
|
Missing an error argument for an exception
|
|
b0416f07 checkpoints: add a testnet checkpoint at 1000000 (moneromooo-monero)
|
|
fc85d7a9 simplewallet: fix in show_transfer passing wrong arg to wallet2::get_payments etc (stoffu)
|
|
a3ea62f2 CMake: include RPC when building GUI deps (anonimal)
|
