aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-01-07Ignore cmake-build-debug folderMaxithi1-0/+1
2018-01-02Merge pull request #3019Riccardo Spagni1-32/+30
294adc83 Additional fix for core_tests (Howard Chu) d52b732e Fix stale readcursor flags (Howard Chu)
2018-01-02Merge pull request #2977Riccardo Spagni1-1/+7
c70e8daa threadpool: fix deadlock in recursive waiter usage (moneromooo-monero)
2018-01-02Merge pull request #2967Riccardo Spagni3-303/+118
55556fab wallet_rpc_server: factor transfer info return and add missing info (moneromooo-monero)
2018-01-02Merge pull request #2965Riccardo Spagni2-2/+2
5388c81b Added using TOOLCHAIN_DIR varable on symlinking in android dockerfiles (damir)
2018-01-02Merge pull request #2964Riccardo Spagni1-24/+0
3ed1a74c tests: remove unused/unfinished keccak bits (moneromooo-monero)
2018-01-02Merge pull request #2963Riccardo Spagni4-43/+4
0e19a394 tests: test wallets don't need a dummy temp file anymore (moneromooo-monero)
2018-01-02Merge pull request #2962Riccardo Spagni1-0/+1
14c29814 wallet2: fix use of uninitialized data (moneromooo-monero)
2018-01-02Merge pull request #2960Riccardo Spagni5-45/+326
5cbcf0aa wallet: support for multisig seeds (moneromooo-monero)
2018-01-02Merge pull request #2956Riccardo Spagni3-0/+70
dc642631 performance_tests: add a test for subaddress expansion (moneromooo-monero)
2018-01-02Merge pull request #2934Riccardo Spagni4-13/+174
db2bc965 Embed the translation files in the binary (Guillaume LE VAILLANT)
2017-12-28Additional fix for core_testsHoward Chu1-10/+15
Reset thread-local info if it doesn't match the current env. Only happens when a process opens/closes env multiple times in the same process, doesn't affect monerod.
2017-12-28Merge pull request #2955Riccardo Spagni1-0/+1
0bcaf86c tests: fix link error in hash tests now needing common (moneromooo-monero)
2017-12-28Merge pull request #2949Riccardo Spagni4-20/+20
e20e489a Better definite article use (xmr-eric)
2017-12-28Merge pull request #2947Riccardo Spagni1-5/+1
e12ee76a README.md: Improve copy for supporting the project (xmr-eric)
2017-12-28Merge pull request #2946Riccardo Spagni1-1/+1
1a686bf8 daemon: print num txes in print_bc (moneromooo-monero)
2017-12-28Merge pull request #2945Riccardo Spagni4-5/+2
9e07ccf1 daemon: remove some superfluous includes (moneromooo-monero)
2017-12-28Merge pull request #2944Riccardo Spagni1-1/+1
223e3788 unit_tests: fix memwipe test comparison (moneromooo-monero)
2017-12-28Merge pull request #2942Riccardo Spagni1-82/+1
4f45f9da simplewallet: factor out tx exceptions (moneromooo-monero)
2017-12-28Merge pull request #2941Riccardo Spagni1-8/+18
d0d38dc8 wallet2: print tx size in bytes and kB (moneromooo-monero)
2017-12-28Merge pull request #2940Riccardo Spagni2-4/+8
da0fd71d only include the easylogging++ stack trace code when needed (moneromooo-monero) 81b04cfa easlogging++: omit some unneded macros (moneromooo-monero)
2017-12-28Fix stale readcursor flagsHoward Chu1-22/+15
Reset thread-specific flags when a write txn is started. Also remove some redundant start-readtxn code.
2017-12-27Merge pull request #2952Riccardo Spagni2-0/+6
e3530789 wallet-api: added Utils::onStartup (stoffu)
2017-12-26Merge pull request #2996Riccardo Spagni1-0/+1
1a271d25 unbound: enable SHA1 (moneromooo-monero)
2017-12-26only include the easylogging++ stack trace code when neededmoneromooo-monero2-4/+7
2017-12-26easlogging++: omit some unneded macrosmoneromooo-monero1-0/+1
2017-12-26wallet-api: added Utils::onStartupstoffu2-0/+6
2017-12-25Merge pull request #2611Riccardo Spagni1-1/+3
cdd516fa tests : remove lib_wallet_api tests (guzzijones)
2017-12-25Merge pull request #3006Riccardo Spagni1-1/+0
7e7b1a82 Revert "return subaddress in get_bulk_payments" (moneromooo-monero)
2017-12-25Revert "return subaddress in get_bulk_payments"moneromooo-monero1-1/+0
This reverts commit b60f48f0e31c17638f771042887b2fffdbad15b4.
2017-12-25Merge pull request #2895Riccardo Spagni9-69/+101
5ad312a1 wallet2: switch to chacha20 instead of chacha8 (moneromooo-monero) 1e5491e9 Add a chacha20 variant to go with chacha8 (moneromooo-monero)
2017-12-25Merge pull request #2938Riccardo Spagni1-1/+13
aaae94f0 wallet2: reinstate the single preferred output selection (moneromooo-monero)
2017-12-25wallet2: switch to chacha20 instead of chacha8moneromooo-monero1-19/+36
Wallet caches and keys files are loaded with chacha8 as needed, but only saved with chacha20. Other data (eg, cold wallet data files, etc) will be incompatible.
2017-12-25Add a chacha20 variant to go with chacha8moneromooo-monero9-50/+65
2017-12-25Merge pull request #2936Riccardo Spagni1-9/+12
cb9aa23c levin_protocol_handler_async: another attempt at fixing at exception (moneromooo-monero) 64d23ce3 Revert "epee: keep a ref to a connection we're deleting" (moneromooo-monero)
2017-12-25Merge pull request #2931Riccardo Spagni1-1/+5
04349492 wallet2: error out in get_seed if the language is invalid (moneromooo-monero)
2017-12-25Merge pull request #2930Riccardo Spagni1-5/+9
7f4bb612 levin_protocol_handler_async: add missing response handler locking (moneromooo-monero)
2017-12-25Merge pull request #2929Riccardo Spagni3-12/+104
ae55bacd resumption support for updates using range requests (moneromooo-monero) fe0fae50 epee: add a get_file_size function (moneromooo-monero)
2017-12-25Merge pull request #2928Riccardo Spagni1-2/+5
d28c388f p2p: stop net server before closing starting connections (moneromooo-monero)
2017-12-25Merge pull request #2926Riccardo Spagni7-5/+369
6b5bd129 Account tagging (stoffu)
2017-12-25Merge pull request #2924Riccardo Spagni1-0/+4
67fe4b1b Add Guix SD to available distro packages in README.md (vasi)
2017-12-25Merge pull request #2923Riccardo Spagni1-1/+1
a7e2e1b0 fix: bind RPC to all interfaces inside Docker container (Alexander Azarov)
2017-12-25Merge pull request #2922Riccardo Spagni2-3/+4
a1d44f27 updates: use https for updates (moneromooo-monero) 472a93c8 download: SSL suport (moneromooo-monero)
2017-12-25Merge pull request #2920Riccardo Spagni39-191/+197
bd5cce07 network_throttle: fix ineffective locking (moneromooo-monero) e0a61299 network_throttle: remove unused xxx static member (moneromooo-monero) 24f584d9 cryptonote_core: remove unused functions with off by one bugs (moneromooo-monero) b1634aa3 blockchain: don't leave dangling pointers in this (moneromooo-monero) 8e60b81c cryptonote_core: fix db leak on error (moneromooo-monero) 213e326c abstract_tcp_server2: log init_server errors as fatal (moneromooo-monero) b51dc566 use const refs in for loops for non tiny types (moneromooo-monero) f0568ca6 net_parse_helpers: fix regex error checking (moneromooo-monero) b49ddc76 check accessing an element past the end of a container (moneromooo-monero) 2305bf26 check return value for generate_key_derivation and derive_public_key (moneromooo-monero) a4240d9f catch const exceptions (moneromooo-monero) 45a1c4c0 add empty container sanity checks when using front() and back() (moneromooo-monero) 56fa6ce1 tests: fix a buffer overread in a unit test (moneromooo-monero) b4524892 rpc: guard against json parsing a non object (moneromooo-monero) c2ed8618 easylogging++: avoid buffer underflow (moneromooo-monero) 187a6ab2 epee: trap failure to parse URI from request (moneromooo-monero) 061789b5 checkpoints: trap failure to load JSON checkpoints (moneromooo-monero) ba2fefb9 checkpoints: pass std::string by const ref, not const value (moneromooo-monero) 38c8f4e0 mlog: terminate a string at last char, just in case (moneromooo-monero) d753d716 fix a few leaks by throwing objects, not newed pointers to objects (moneromooo-monero) fe568db8 p2p: use size_t for arbitrary counters instead of uint8_t (moneromooo-monero) 46d6fa35 cryptonote_protocol: sanity check chain hashes from peer (moneromooo-monero) 25584f86 cryptonote_protocol: print peer versions when unexpected (moneromooo-monero) 490a5d41 rpc: do not try to use an invalid txid in relay_tx (moneromooo-monero)
2017-12-25Merge pull request #2918Riccardo Spagni1-1/+1
f5bc7f18 simplewallet: fix default unspent_outputs output with subaddresses (moneromooo-monero)
2017-12-25Merge pull request #2916Riccardo Spagni2-4/+22
a9217641 wallet-rpc: added receiving address to res of get(_bulk)_payments; selective addresses for getaddress (stoffu)
2017-12-25Merge pull request #2910Riccardo Spagni2-1/+7
37f9c6e6 Dockerfile: add option to set build parallelism (MoroccanMalinois)
2017-12-25Merge pull request #2909Riccardo Spagni1-0/+1
dba2de61 levin_protocol_handler_async: call handler destroy function on dtor (moneromooo-monero)
2017-12-25Merge pull request #2905Riccardo Spagni20-114/+965
bd1f6029 http_client: rewrite header parsing manually for speed (moneromooo-monero) ec724eb6 tests: add levin fuzz test (moneromooo-monero) f1bdc9a4 tests: add http client fuzz test (moneromooo-monero) 0272df9e add parse_url fuzz test (moneromooo-monero) 261b0dd0 tests: add base58 fuzz test (moneromooo-monero) fd052087 fuzz_testing: allow automatically resuming an interrupted job (moneromooo-monero) c80bb0eb tests: don't init stuff we don't need in fuzz tests - faster (moneromooo-monero) 53b83a83 tests: better load-from-binary fuzz test data file (moneromooo-monero) 1a379ef6 fuzz_testing: build with ASAN (assumed to be available) (moneromooo-monero) 4cd4a431 fuzz_testing: create out directory if needed, and fix filename passing (moneromooo-monero) c27d9092 Makefile: build fuzz tests statically, starts faster (moneromooo-monero) 95aa0bf7 add load_from_binary/load_from_json fuzzers (moneromooo-monero)
2017-12-25Merge pull request #2902Riccardo Spagni1-1/+0
1741fb5f node_rpc_proxy: remove unused local and time call (moneromooo-monero)
2017-12-25Merge pull request #2899Riccardo Spagni1-0/+1
b60f48f0 return subaddress in get_bulk_payments (Dmitriy Plekhanov)
2017-12-25Merge pull request #2897Riccardo Spagni1-0/+2
463d385c add libsodium as dependency for building in readme (Gingeropolous)
2017-12-25Merge pull request #2891Riccardo Spagni1-8/+8
3f24e901 wallet2: don't write a .new file when not needed (moneromooo-monero)
2017-12-25Merge pull request #2890Riccardo Spagni3-8/+10
83b0f9e6 version: add -master to master version (moneromooo-monero) 493f7d09 util: allow non numeric version parts (moneromooo-monero)
2017-12-25Merge pull request #2888Riccardo Spagni2-3/+7
ca18ff64 wallet2: detect spends in txes without a valid public tx key (moneromooo-monero) 6afcd8e3 cn_deserialize: print tx extra fields in partly decoded tx extra (moneromooo-monero)
2017-12-24Merge pull request #2994Riccardo Spagni3-0/+8
2018cf74 Fix Windows build (dEBRUYNE-1)
2017-12-23unbound: enable SHA1moneromooo-monero1-0/+1
Fixes the unit test failure about SHA1 being unavailable, and hopefully the monerod complaints about not being able to verify DNSSEC. Thanks to iDunk for the remote Windows testing.
2017-12-23Fix Windows builddEBRUYNE-13-0/+8
Fix no new line
2017-12-23http_client: rewrite header parsing manually for speedmoneromooo-monero1-74/+95
boost::regex is stupendously atrocious at parsing malformed data
2017-12-23tests: add levin fuzz testmoneromooo-monero4-3/+362
2017-12-23tests: add http client fuzz testmoneromooo-monero5-6/+137
2017-12-23add parse_url fuzz testmoneromooo-monero5-3/+92
2017-12-23tests: add base58 fuzz testmoneromooo-monero5-3/+90
2017-12-23fuzz_testing: allow automatically resuming an interrupted jobmoneromooo-monero1-1/+8
2017-12-23tests: don't init stuff we don't need in fuzz tests - fastermoneromooo-monero1-32/+1
2017-12-23tests: better load-from-binary fuzz test data filemoneromooo-monero1-0/+0
Looks like there's some kind of header/signature
2017-12-23fuzz_testing: build with ASAN (assumed to be available)moneromooo-monero2-1/+11
2017-12-23fuzz_testing: create out directory if needed, and fix filename passingmoneromooo-monero1-1/+2
2017-12-23Makefile: build fuzz tests statically, starts fastermoneromooo-monero1-1/+1
2017-12-23add load_from_binary/load_from_json fuzzersmoneromooo-monero6-3/+180
2017-12-23threadpool: fix deadlock in recursive waiter usagemoneromooo-monero1-1/+7
If a queued job uses a waiter, then we want to run that waiter's jobs in the current thread if all threads are busy, even if the queue is empty, since there is no guarantee that any thread will free up to take care of that new job, since all the threads might be running a job which spawns such a recursive job and will block till that recursive job is done, which it will never be since it relies on the queue being polled by one of those blocked threads.
2017-12-22tests : remove lib_wallet_api testsguzzijones1-1/+3
2017-12-20wallet: support for multisig seedsmoneromooo-monero5-45/+326
They are hex rather than words, because they are a lot longer than "normal" seeds, as they have to embed a lot more information
2017-12-20wallet_rpc_server: factor transfer info return and add missing infomoneromooo-monero3-303/+118
Additional tx keys, amounts and fees were missing in some cases
2017-12-19Merge pull request #2961Riccardo Spagni1-6/+7
6c94516f wipeable_string: move a wipe from reserve to grow (moneromooo-monero) 5f801b6a wipeable_string: ignore reserve size less than actual size (moneromooo-monero) 9ec44a2b wipeable_string: fix clear and push_back (moneromooo-monero)
2017-12-19Added using TOOLCHAIN_DIR varable on symlinking in android dockerfilesdamir2-2/+2
2017-12-19wipeable_string: move a wipe from reserve to growmoneromooo-monero1-3/+2
That way, all implicit wipes ends up in grow, which is more robust
2017-12-19wipeable_string: ignore reserve size less than actual sizemoneromooo-monero1-2/+1
This was asserting, but stoffu pointed out the std::string standard considers this ok and ignorable
2017-12-19tests: remove unused/unfinished keccak bitsmoneromooo-monero1-24/+0
The author doesn't seem to be finishing/fixing this, and it doesn't do anything.
2017-12-19tests: test wallets don't need a dummy temp file anymoremoneromooo-monero4-43/+4
2017-12-19wallet2: fix use of uninitialized datamoneromooo-monero1-0/+1
2017-12-19wipeable_string: fix clear and push_backmoneromooo-monero1-1/+4
2017-12-18performance_tests: add a test for subaddress expansionmoneromooo-monero3-0/+70
2017-12-18simplewallet: factor out tx exceptionsmoneromooo-monero1-82/+1
2017-12-18network_throttle: fix ineffective lockingmoneromooo-monero1-3/+5
2017-12-18network_throttle: remove unused xxx static membermoneromooo-monero2-5/+0
2017-12-18cryptonote_core: remove unused functions with off by one bugsmoneromooo-monero4-105/+0
2017-12-18blockchain: don't leave dangling pointers in thismoneromooo-monero1-0/+2
2017-12-18cryptonote_core: fix db leak on errormoneromooo-monero2-2/+3
2017-12-18abstract_tcp_server2: log init_server errors as fatalmoneromooo-monero1-1/+11
so they show up by default
2017-12-18use const refs in for loops for non tiny typesmoneromooo-monero5-5/+5
2017-12-18net_parse_helpers: fix regex error checkingmoneromooo-monero1-2/+2
2017-12-18check accessing an element past the end of a containermoneromooo-monero8-12/+46
2017-12-18check return value for generate_key_derivation and derive_public_keymoneromooo-monero2-11/+22
2017-12-18catch const exceptionsmoneromooo-monero4-7/+7
2017-12-18add empty container sanity checks when using front() and back()moneromooo-monero9-6/+32
2017-12-18tests: fix a buffer overread in a unit testmoneromooo-monero1-3/+1
and remove a leftover debugging sanity check
2017-12-18rpc: guard against json parsing a non objectmoneromooo-monero1-1/+1
2017-12-18easylogging++: avoid buffer underflowmoneromooo-monero1-2/+3
2017-12-18epee: trap failure to parse URI from requestmoneromooo-monero1-1/+6
2017-12-18checkpoints: trap failure to load JSON checkpointsmoneromooo-monero1-1/+5
2017-12-18checkpoints: pass std::string by const ref, not const valuemoneromooo-monero2-4/+4
2017-12-18mlog: terminate a string at last char, just in casemoneromooo-monero1-0/+1
2017-12-18fix a few leaks by throwing objects, not newed pointers to objectsmoneromooo-monero2-6/+6
2017-12-18p2p: use size_t for arbitrary counters instead of uint8_tmoneromooo-monero1-2/+2
2017-12-18cryptonote_protocol: sanity check chain hashes from peermoneromooo-monero1-0/+6
2017-12-18cryptonote_protocol: print peer versions when unexpectedmoneromooo-monero1-6/+10
also avoid integer underflow on zero height
2017-12-18rpc: do not try to use an invalid txid in relay_txmoneromooo-monero1-6/+17
2017-12-18tests: fix link error in hash tests now needing commonmoneromooo-monero1-0/+1
2017-12-18wallet-rpc: added receiving address to res of get(_bulk)_payments; selective ↵stoffu2-4/+22
addresses for getaddress
2017-12-18Account taggingstoffu7-5/+369
2017-12-17Merge pull request #2134Riccardo Spagni41-378/+4823
ceabc4f9 change the N-1/N multisig second message signer for auth (moneromooo-monero) 55c2845d core_tests: multisig test now tests multiple inputs (moneromooo-monero) 98db7ee4 wallet: factor multisig info parsing (moneromooo-monero) 31a97e76 wallet: use raw encrypted data in multisig import/export RPC (moneromooo-monero) 2fa707d1 wallet: add multisig sign/submit RPC (moneromooo-monero) e36f5b60 Match surae's recommendation to derive multisig keys (moneromooo-monero) a36c261d wallet2: fix slow multisig unit tests with subaddress patch (moneromooo-monero) fa569712 make multisig work with subaddresses (moneromooo-monero) dffa0dce simplewallet: add export_raw_multisig command (moneromooo-monero) 7f4c220b simplewallet: add multisig to wallet type in wallet_info output (moneromooo-monero) 26529038 wallet: guard against partly initialized multisig wallet (moneromooo-monero) 66e34e85 add multisig core test and factor multisig building blocks (moneromooo-monero) f4eda44c N-1/N multisig (moneromooo-monero) cd64c799 multisig address generation RPC (moneromooo-monero) fff871a4 gen_multisig: generates multisig wallets if participants trust each other (moneromooo-monero) 95a21a79 wallet2: allow empty wallet filename to avoid saving data (moneromooo-monero) b84b3565 tests: add multisig unit tests (moneromooo-monero) 4c313324 Add N/N multisig tx generation and signing (moneromooo-monero) 6d219a92 wallet: add multisig key generation (moneromooo-monero)
2017-12-17Merge pull request #2950Riccardo Spagni1-1/+1
d9b137f1 cryptonote_core: fix blockchain init call after prototype change (moneromooo-monero)
2017-12-17cryptonote_core: fix blockchain init call after prototype changemoneromooo-monero1-1/+1
2017-12-17Better definite article usexmr-eric4-20/+20
2017-12-17README.md: Improve copy for supporting the projectxmr-eric1-5/+1
2017-12-17change the N-1/N multisig second message signer for authmoneromooo-monero1-10/+9
2017-12-17core_tests: multisig test now tests multiple inputsmoneromooo-monero3-136/+209
2017-12-17wallet: factor multisig info parsingmoneromooo-monero4-102/+68
2017-12-17wallet: use raw encrypted data in multisig import/export RPCmoneromooo-monero5-163/+73
2017-12-17wallet: add multisig sign/submit RPCmoneromooo-monero6-108/+465
2017-12-17Match surae's recommendation to derive multisig keysmoneromooo-monero6-37/+49
2017-12-17wallet2: fix slow multisig unit tests with subaddress patchmoneromooo-monero3-8/+48
While there, move the wallet2 ctor to the cpp file as it's a huge amount of init list now, and remove an unused one.
2017-12-17make multisig work with subaddressesmoneromooo-monero8-82/+89
Thanks to kenshi84 for help getting this work
2017-12-17simplewallet: add export_raw_multisig commandmoneromooo-monero2-0/+74
It exports raw transactions, so they may be used by other tools, for instance to be relayed to the network externally.
2017-12-17simplewallet: add multisig to wallet type in wallet_info outputmoneromooo-monero1-1/+11
2017-12-17wallet: guard against partly initialized multisig walletmoneromooo-monero6-19/+82
2017-12-17add multisig core test and factor multisig building blocksmoneromooo-monero17-127/+1019
2017-12-17N-1/N multisigmoneromooo-monero12-140/+846
2017-12-17multisig address generation RPCmoneromooo-monero6-6/+400
2017-12-17gen_multisig: generates multisig wallets if participants trust each othermoneromooo-monero9-10/+283
2017-12-17wallet2: allow empty wallet filename to avoid saving datamoneromooo-monero2-40/+58
Useful to speed tests up and avoid unnecessary leftover files
2017-12-17tests: add multisig unit testsmoneromooo-monero2-0/+179
2017-12-17Add N/N multisig tx generation and signingmoneromooo-monero18-273/+1420
Scheme by luigi1111: Multisig for RingCT on Monero 2 of 2 User A (coordinator): Spendkey b,B Viewkey a,A (shared) User B: Spendkey c,C Viewkey a,A (shared) Public Address: C+B, A Both have their own watch only wallet via C+B, a A will coordinate spending process (though B could easily as well, coordinator is more needed for more participants) A and B watch for incoming outputs B creates "half" key images for discovered output D: I2_D = (Hs(aR)+c) * Hp(D) B also creates 1.5 random keypairs (one scalar and 2 pubkeys; one on base G and one on base Hp(D)) for each output, storing the scalar(k) (linked to D), and sending the pubkeys with I2_D. A also creates "half" key images: I1_D = (Hs(aR)+b) * Hp(D) Then I_D = I1_D + I2_D Having I_D allows A to check spent status of course, but more importantly allows A to actually build a transaction prefix (and thus transaction). A builds the transaction until most of the way through MLSAG_Gen, adding the 2 pubkeys (per input) provided with I2_D to his own generated ones where they are needed (secret row L, R). At this point, A has a mostly completed transaction (but with an invalid/incomplete signature). A sends over the tx and includes r, which allows B (with the recipient's address) to verify the destination and amount (by reconstructing the stealth address and decoding ecdhInfo). B then finishes the signature by computing ss[secret_index][0] = ss[secret_index][0] + k - cc[secret_index]*c (secret indices need to be passed as well). B can then broadcast the tx, or send it back to A for broadcasting. Once B has completed the signing (and verified the tx to be valid), he can add the full I_D to his cache, allowing him to verify spent status as well. NOTE: A and B *must* present key A and B to each other with a valid signature proving they know a and b respectively. Otherwise, trickery like the following becomes possible: A creates viewkey a,A, spendkey b,B, and sends a,A,B to B. B creates a fake key C = zG - B. B sends C back to A. The combined spendkey C+B then equals zG, allowing B to spend funds at any time! The signature fixes this, because B does not know a c corresponding to C (and thus can't produce a signature). 2 of 3 User A (coordinator) Shared viewkey a,A "spendkey" j,J User B "spendkey" k,K User C "spendkey" m,M A collects K and M from B and C B collects J and M from A and C C collects J and K from A and B A computes N = nG, n = Hs(jK) A computes O = oG, o = Hs(jM) B anc C compute P = pG, p = Hs(kM) || Hs(mK) B and C can also compute N and O respectively if they wish to be able to coordinate Address: N+O+P, A The rest follows as above. The coordinator possesses 2 of 3 needed keys; he can get the other needed part of the signature/key images from either of the other two. Alternatively, if secure communication exists between parties: A gives j to B B gives k to C C gives m to A Address: J+K+M, A 3 of 3 Identical to 2 of 2, except the coordinator must collect the key images from both of the others. The transaction must also be passed an additional hop: A -> B -> C (or A -> C -> B), who can then broadcast it or send it back to A. N-1 of N Generally the same as 2 of 3, except participants need to be arranged in a ring to pass their keys around (using either the secure or insecure method). For example (ignoring viewkey so letters line up): [4 of 5] User: spendkey A: a B: b C: c D: d E: e a -> B, b -> C, c -> D, d -> E, e -> A Order of signing does not matter, it just must reach n-1 users. A "remaining keys" list must be passed around with the transaction so the signers know if they should use 1 or both keys. Collecting key image parts becomes a little messy, but basically every wallet sends over both of their parts with a tag for each. Thia way the coordinating wallet can keep track of which images have been added and which wallet they come from. Reasoning: 1. The key images must be added only once (coordinator will get key images for key a from both A and B, he must add only one to get the proper key actual key image) 2. The coordinator must keep track of which helper pubkeys came from which wallet (discussed in 2 of 2 section). The coordinator must choose only one set to use, then include his choice in the "remaining keys" list so the other wallets know which of their keys to use. You can generalize it further to N-2 of N or even M of N, but I'm not sure there's legitimate demand to justify the complexity. It might also be straightforward enough to support with minimal changes from N-1 format. You basically just give each user additional keys for each additional "-1" you desire. N-2 would be 3 keys per user, N-3 4 keys, etc. The process is somewhat cumbersome: To create a N/N multisig wallet: - each participant creates a normal wallet - each participant runs "prepare_multisig", and sends the resulting string to every other participant - each participant runs "make_multisig N A B C D...", with N being the threshold and A B C D... being the strings received from other participants (the threshold must currently equal N) As txes are received, participants' wallets will need to synchronize so that those new outputs may be spent: - each participant runs "export_multisig FILENAME", and sends the FILENAME file to every other participant - each participant runs "import_multisig A B C D...", with A B C D... being the filenames received from other participants Then, a transaction may be initiated: - one of the participants runs "transfer ADDRESS AMOUNT" - this partly signed transaction will be written to the "multisig_monero_tx" file - the initiator sends this file to another participant - that other participant runs "sign_multisig multisig_monero_tx" - the resulting transaction is written to the "multisig_monero_tx" file again - if the threshold was not reached, the file must be sent to another participant, until enough have signed - the last participant to sign runs "submit_multisig multisig_monero_tx" to relay the transaction to the Monero network
2017-12-17wallet: add multisig key generationmoneromooo-monero6-7/+332
Scheme by luigi1111
2017-12-17daemon: print num txes in print_bcmoneromooo-monero1-1/+1
2017-12-17Merge pull request #2857Riccardo Spagni6-23/+60
7193b89f Scrub keys from memory just before scope end. (moneromooo-monero)
2017-12-17Merge pull request #2877Riccardo Spagni30-89/+206
43f5269f Wallets now do not depend on the daemon rpc lib (moneromooo-monero) bb89ae8b move connection_basic and network_throttle from src/p2p to epee (moneromooo-monero) 4abf25f3 cryptonote_core does not depend on p2p anymore (moneromooo-monero)
2017-12-17Merge pull request #2864Riccardo Spagni73-161/+212
09ce03d6 move includes around to lessen overall load (moneromooo-monero)
2017-12-17daemon: remove some superfluous includesmoneromooo-monero4-5/+2
2017-12-17unit_tests: fix memwipe test comparisonmoneromooo-monero1-1/+1
free might overwrite the memory, so we can't expect to see the NULs we overwrote with, but at least we shouldn't see the original data.
2017-12-16Wallets now do not depend on the daemon rpc libmoneromooo-monero3-4/+23
The shared RPC code is now moved off into a separate lib
2017-12-16move connection_basic and network_throttle from src/p2p to epeemoneromooo-monero11-14/+15
These even had the epee namespace. This fixes some ugly circular dependencies.
2017-12-16cryptonote_core does not depend on p2p anymoremoneromooo-monero18-72/+169
As a followon side effect, this makes a lot of inline code included only in particular cpp files (and instanciated when necessary.
2017-12-16move includes around to lessen overall loadmoneromooo-monero73-161/+212
2017-12-16Scrub keys from memory just before scope end.moneromooo-monero6-23/+60
Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.
2017-12-16Merge pull request #2881Riccardo Spagni2-37/+33
41fc11fa Scheduled mandatory software upgrades (xmr-eric) 3b5382fe Keep VRP a proper noun (xmr-eric) 7160cbd6 CONTRIBUTING.md capitalization (xmr-eric) f36ffc07 Shorten a title, remove a section, small edits (xmr-eric) 00179917 Capitalization on first word only (xmr-eric) 6ffae079 Readme.md: Normalize heading capitalization (xmr-eric)
2017-12-16Merge pull request #2878Riccardo Spagni7-13/+42
abebe392 rpc: add offline state in info rpc (moneromooo-monero) 7696e849 core: make --offline also disable DNS lookups (moneromooo-monero)
2017-12-16Merge pull request #2874Riccardo Spagni1-0/+4
25f4ab81 fixed linking against libreadline on OpenBSD (ston1th)
2017-12-16Merge pull request #2873Riccardo Spagni5-6/+6
1c838552 Simplewallet.cpp: Fewer pleases in seed NOTE (xmr-eric) 3f18c642 Fix password capitalization mismatch (xmr-eric)
2017-12-16Merge pull request #2871Riccardo Spagni1-2/+2
2b0a32f8 Small cleanup of daemon synchronization output (xmr-eric)
2017-12-16Merge pull request #2866Riccardo Spagni8-41/+25
cf5f6236 Corrections in rate limiting / trottle code, especially in 'out' direction (rbrunner7)
2017-12-16Merge pull request #2885Riccardo Spagni1-1/+6
a1e3670b catch wallet decrypt false positive (Riccardo Spagni)
2017-12-16Merge pull request #2860Riccardo Spagni22-69/+528
3dffe71b new wipeable_string class to replace std::string passphrases (moneromooo-monero) 7a2a5741 utils: initialize easylogging++ in on_startup (moneromooo-monero) 54950829 use memwipe in a few relevant places (moneromooo-monero) 000666ff add a memwipe function (moneromooo-monero)
2017-12-16Merge pull request #2856Riccardo Spagni1-1/+1
009eed17 rpc: increase the max number of outs one can request (moneromooo-monero)
2017-12-16Merge pull request #2551Riccardo Spagni2-2/+44
3af19c80 set_node command, allows setting node without restart (Tobias Hoffmann)
2017-12-16wallet2: print tx size in bytes and kBmoneromooo-monero1-8/+18
Helpful now that tx sizes are smaller
2017-12-16wallet2: reinstate the single preferred output selectionmoneromooo-monero1-1/+13
Removing it nullified the min-outputs-{count,value} system, and will not increase the number of attempted transactions in the general case.
2017-12-15levin_protocol_handler_async: another attempt at fixing at exceptionmoneromooo-monero1-3/+12
2017-12-15Embed the translation files in the binaryGuillaume LE VAILLANT4-13/+174
If a translation file exists in a "translations" directory located in the same directory as the binary, it is used in priority (this can be useful when working on translations as you don't have to recompile the whole program all the time), and if no such file is found the embedded translation file is used (if it exists).
2017-12-15Add Guix SD to available distro packages in README.mdvasi1-0/+4
2017-12-15Revert "epee: keep a ref to a connection we're deleting"moneromooo-monero1-8/+2
This reverts commit f2939bdce8c86b0f96921f731184c361106390c8.
2017-12-15wallet2: error out in get_seed if the language is invalidmoneromooo-monero1-1/+5
2017-12-15levin_protocol_handler_async: add missing response handler lockingmoneromooo-monero1-5/+9
2017-12-15resumption support for updates using range requestsmoneromooo-monero2-12/+84
2017-12-15epee: add a get_file_size functionmoneromooo-monero1-0/+20
2017-12-15p2p: stop net server before closing starting connectionsmoneromooo-monero1-2/+5
This fixes a hang on exit due to race where a connection adds itself to the server after the starting connections are closed, but before the net server marks itself as stopped.
2017-12-14fix: bind RPC to all interfaces inside Docker containerAlexander Azarov1-1/+1
Binding RPC to 127.0.0.1 makes no sense. Despite the fact port 18081 is exposed, no one will be able to connect to the daemon. RPC should be listening at all interfaces when running inside a Docker container.
2017-12-14updates: use https for updatesmoneromooo-monero1-1/+1
2017-12-14download: SSL suportmoneromooo-monero1-2/+3
2017-12-13simplewallet: fix default unspent_outputs output with subaddressesmoneromooo-monero1-1/+1
If no subaddress index is given, consider all of them
2017-12-12Merge pull request #2913Riccardo Spagni1-0/+4
b927f0b1 cryptonote_protocol: fix corner case looping asking for same block hashes (moneromooo-monero)
2017-12-11Dockerfile: add option to set build parallelismMoroccanMalinois2-1/+7
2017-12-11levin_protocol_handler_async: call handler destroy function on dtormoneromooo-monero1-0/+1
2017-12-10Merge pull request #2906Riccardo Spagni2-5/+27
27aa8ce9 net_utils_base: fix peer list parsing (moneromooo-monero) fe5ab2c4 epee: fix kv_unserialize return value when a field is not found (moneromooo-monero)
2017-12-10Merge pull request #2900Riccardo Spagni2-5/+7
5cc84693 easylogging: show the 'no stack trace' warning only once (ston1th)
2017-12-09net_utils_base: fix peer list parsingmoneromooo-monero1-3/+25
Fields are written with their "name" as key, and that name changed.
2017-12-09Merge pull request #2904Riccardo Spagni1-19/+3
46eaaae7 ringct: always use outPk.mask to decode amounts (moneromooo-monero)
2017-12-09ringct: always use outPk.mask to decode amountsmoneromooo-monero1-19/+3
2017-12-09Merge pull request #2903Riccardo Spagni1-3/+3
8d4469a0 ringct: do not include bulletproof commitments in signed message (moneromooo-monero)
2017-12-09Merge pull request #2901Riccardo Spagni1-1/+1
ead48f7d core: fix input ordering from v7 (moneromooo-monero)
2017-12-09ringct: do not include bulletproof commitments in signed messagemoneromooo-monero1-3/+3
Those are not serialized, but are restored from the outPk masks, so depending on what tries to validate the tx, those commitments may or may not be filled with valid data at the time. The outPk masks are already hashed as part of the rctSigBase field.
2017-12-09node_rpc_proxy: remove unused local and time callmoneromooo-monero1-1/+0
2017-12-09core: fix input ordering from v7moneromooo-monero1-1/+1
2017-12-09easylogging: show the 'no stack trace' warning only onceston1th2-5/+7
If execinfo.h is not available, output the stack trace warning only once, so we don't spam the build logs with it.
2017-12-08Merge pull request #2883Riccardo Spagni25-95/+1911
c83d0b3e add bulletproofs from v7 on testnet (moneromooo-monero) 8620ef0a bulletproofs: switch H/G in Pedersen commitments to match rct (moneromooo-monero) d58835b2 integrate bulletproofs into monero (moneromooo-monero) 90b8d9f2 add bulletproofs to the build, with basic unit tests (moneromooo-monero) fe120264 perf_timer: add non scoped start/stop timer defines (moneromooo-monero) ada42914 add a version of ge_double_scalarmult_precomp_vartime with A precomp (moneromooo-monero) d43eef6d ringct: add a version of addKeys which returns the result (moneromooo-monero) 7ff07928 sc_mul and sc_muladd (luigi1111) 3d0b54bd epee: add do while(0) around brace statement in a macro (moneromooo-monero)
2017-12-08return subaddress in get_bulk_paymentsDmitriy Plekhanov1-0/+1
2017-12-08add bulletproofs from v7 on testnetmoneromooo-monero11-64/+195
2017-12-08bulletproofs: switch H/G in Pedersen commitments to match rctmoneromooo-monero1-13/+14
Changes from sarang
2017-12-08integrate bulletproofs into moneromoneromooo-monero9-71/+164
2017-12-08add bulletproofs to the build, with basic unit testsmoneromooo-monero5-2/+914
Based on Java code from Sarang Noether
2017-12-07add libsodium as dependency for building in readmeGingeropolous1-0/+2
this finally got my debug-static-all to build. Obviously, its me, so this could use some edits or something.
2017-12-07Scheduled mandatory software upgradesxmr-eric1-4/+4
2017-12-07perf_timer: add non scoped start/stop timer definesmoneromooo-monero1-0/+3
2017-12-07add a version of ge_double_scalarmult_precomp_vartime with A precompmoneromooo-monero4-3/+19
2017-12-07ringct: add a version of addKeys which returns the resultmoneromooo-monero2-0/+6
2017-12-07sc_mul and sc_muladdluigi11112-0/+654
2017-12-07epee: add do while(0) around brace statement in a macromoneromooo-monero1-1/+1
Allows use in more complex expressions
2017-12-07wallet2: don't write a .new file when not neededmoneromooo-monero1-8/+8
2017-12-07version: add -master to master versionmoneromooo-monero1-1/+1
This makes master versions play better with automated update checks