Age | Commit message (Collapse) | Author | Files | Lines |
|
The recent change to not keep separate track of the blockchain
height caused the reported height to jump early in the lmdb
transaction (when the block data is added to the blocks table),
rather than at the end, after everything succeeded. Since the
block data is added before the transaction data, this caused
the transaction data to be saved with a height one more than
its expected value.
Fix this by saving the block data last. This should have no
side effects.
|
|
9459f331 simplewallet: print error when address is wrong (kenshi84)
|
|
6ea3e3cc Fix race in setThreadName/getThreadName (Lee Clagett)
|
|
27c3a0ea ITS#8582 keep mutex at end of struct (Howard Chu)
|
|
5d00659e disable ELPP_STACKTRACE_ON_CRASH for android (MoroccanMalinois)
|
|
ce7fcbb4 Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
|
|
bceaf4b7 wallet2: fix transactions not considering rct inputs (moneromooo-monero)
|
|
7549116e Wallet API: Easylogger wrapper for gui (Jaquee)
|
|
1c782a92 easylogging++: do not disable DEBUG level based on _DEBUG/NDEBUG (moneromooo-monero)
|
|
db0a5392 Clarify in/out connections for users (NanoAkron)
|
|
8027ce0c extract some basic code from libcryptonote_core into libcryptonote_basic (kenshi84)
|
|
|
|
|
|
4efc926d Wallet API: Catch error from tools::is_local_address (Jaquee)
|
|
c833a39a cmake set atomic for android (MoroccanMalinois)
|
|
92978b2c common: fix link error on at least one platform (no clue which one) (moneromooo-monero)
|
|
bab1e9a3 bugfix: infinite recursion in get_account_address_from_str_or_url (kenshi84)
|
|
|
|
since it's variable size on Linux/glibc
|
|
I broke this very recently in 2bf029be172a47ace8134143e1320fdb10d3ea44
and didn't notice in time
|
|
|
|
|
|
|
|
|
|
|
|
b14d109b update wallet api tests (Jaquee)
0cc50bdd GUI: Improved refresh performance (Jaquee)
805625b5 wallet api: Remove initAsync() and don't start refresh automatically on init (Jaquee)
031b060a wallet2::init() - disconnect before init if connected Makes it possible for GUI to reinit with new daemon without closing and reopening wallet. (Jaquee)
|
|
|
|
Bug and fix reported by tdprime
|
|
|
|
|
|
|
|
|
|
|
|
Makes it possible for GUI to reinit with new daemon without closing and reopening wallet.
|
|
4f5b130d wallet_rpc_server: add address book RPC calls (moneromooo-monero)
|
|
c3d7a198 mlog: probable fix for gmtime_r not being available on windows (moneromooo-monero)
|
|
cd34fc65 Use easylogging++'s stack trace facility where possible (moneromooo-monero)
|
|
cbdfa757 mlog: fix default logging being not verbose enough (moneromooo-monero)
|
|
03ff3639 Fix missing parentheses (Miguel Herranz)
|
|
34719071 simplewallet: cleanup (moneromooo-monero)
a9a9b64b simplewallet: fix build (unqualified type not in current scope) (moneromooo-monero)
|
|
b5cb8861 core: fix integrated addresses breaking with auto zero change (moneromooo-monero)
|
|
f97526e6 simplewallet: option to always ask password for any crytical operations (kenshi84)
|
|
|
|
This avoids using libunwind, which often causes trouble.
|
|
|
|
|
|
|
|
|
|
Remove empty static function which was refactored, as well as
leftover exception testing code.
|
|
|
|
Zero change is sent to a random address, which confuses the code
which determines which key to use to encrypt the payment id.
Ignore zero amounts for this purpose, so the payment id gets
encrypted with the real destination's key.
|
|
bbcc3a12 Add missing include (Miguel Herranz)
|
|
ca94d0a4 Separate data per P2P port (Miguel Herranz)
|
|
edfd7f6e Workaround VL32 cursor refcounting miscount (Howard Chu)
|
|
084aef70 Added days uptime to the status message (NanoAkron)
|
|
fba9332d Changed console output for transaction from L0 to L1 (NanoAkron)
|
|
fc91e6a7 Fixed a deadlock issue with easylogger++ (NanoAkron)
|
|
2bf029be wallet2: fix corner case failing to send a second output (moneromooo-monero)
|
|
95f3e193 Update and use blockchain data files defines (Miguel Herranz)
|
|
9bd9906e Factor is_address_local code into a tools function (moneromooo-monero)
|
|
69d2ad39 wallet_rpc_server: fix logs going to the wrong file (moneromooo-monero)
|
|
3ae79a59 core: set missing verifivation_failed flag when rejecting a tx (moneromooo-monero)
ea6549e9 core_tests: decrease trace level from trace to debug (moneromooo-monero)
|
|
48aa9cf0 Add change_password for simplewallet (Ashley Perpetual)
|
|
cc1462e0 Add concurrency check to rpc mining to ensure not too many threads. number of cores times 4 or 257. (Ashley Perpetual)
|
|
Fails to build without it.
|
|
99f58437 Fix invalid + of std::string and int (Timothy D. Prime)
|
|
58e82506 Blockfill - Sort tx pool correctly (Alexis Enston)
5f7a8741 Blockfill - Take TX fees into account properly (Alexis Enston)
4ecab0d8 Consider empty block when filling with TXs (Alexis Enston)
|
|
c02e1cb9 Updates to epee HTTP client code - http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed (Lee Clagett)
|
|
66665003 Clear feedback to user when daemon has stopped successfully (NanoAkron)
|
|
55a8e982 moved get_account_address_from_str_or_url from libcommon to libcryptonote_core (kenshi84)
|
|
a39cd745 rpc: fix bc_dyn_stats not setting grace blocks (moneromooo-monero)
|
|
0644eed7 Remove boost/foreach.cpp includes (Miguel Herranz)
36dd3e23 Replace BOOST_REVERSE_FOREACH with ranged for (Miguel Herranz)
629e3101 Replace BOOST_FOREACH with C++11 ranged for (Miguel Herranz)
|
|
7b6a9e91 Added instructions for getting stack traces with gdb (NanoAkron)
|
|
Ubuntu 16.04/GCC 5.4.0/ARMv8 fix to match previous recursive mutex fix for GCC
|
|
Don't try to deref cursor page if txn's pagelist is empty
|
|
Also broke down the time calculations for legibility
|
|
aa95619 GUI: Add install target for epee (Jaqueeee)
|
|
6b14576 Fix clang build failure, caused by mixing C and C++ (tdprime)
|
|
774a213 Wallet API: Create wallet from keys (Jaqueeee)
|
|
8c8482a wallet_rpc_server: fix short payment id validation in transfer (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
If a rct transaction can be made with just one input, a second
output will be added. This output will be the smallest amount
output available. However, if this output is a non rct output
with less available fake outs than requested, the transaction
will be rejected. We now check the histogram to only consider
outputs with enough available fake outs in the first place.
|
|
|
|
|
|
poolstate.bin and p2pstate.bin are stored in .bitmonero/ if the default
P2P port is being used.
If another port is used both files are stored in
.bitmonero/PORTNUMBER/.
|
|
|
|
This fixes two core rct tests
|
|
It had become very, very spammy
|
|
of cores times 4 or 257.
|
|
|
|
Easily fixed by moving a C++ header out of 'extern "C" {...}'.
When building with CC=clang CXX=clang++ make,
[ 21%] Building CXX object src/ringct/CMakeFiles/obj_ringct.dir/rctTypes.cpp.o
In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.cpp:31:
In file included from /home/tdprime/bitmonero/src/ringct/rctTypes.h:43:
In file included from /home/tdprime/bitmonero/src/crypto/generic-ops.h:34:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/cstring:100:3: error: conflicting types for 'memchr'
memchr(void* __s, int __c, size_t __n)
^
/usr/include/string.h:92:14: note: previous declaration is here
extern void *memchr (const void *__s, int __c, size_t __n)
^
... and 4 more similar errors
|
|
These warnings were emitted by clang++, and they are real bugs.
src/rpc/core_rpc_server.cpp:208:58: warning: adding 'uint64_t'
(aka 'unsigned long') to a string does not append to the string
[-Wstring-plus-int]
res.status = "Error retrieving block at height " + height;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
The obvious intent is achieved by using std::to_string().
|
|
- http_simple_client now uses std::chrono for timeouts
- http_simple_client accepts timeouts per connect / invoke call
- shortened names of epee http invoke functions
- invoke command functions only take relative path, connection
is not automatically performed
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This caused a random value to be used, and the resulting
incorrect fee when it wasn't 0.
|
|
8141973e Remove unreachable returns (Miguel Herranz)
|
|
feed6175 fixed typo: monero-wallet-cli,log (kenshi84)
|
|
98357db4 Update log messages to reflect fact we no longer need to type `exit` to save database before quitting (NanoAkron)
|
|
CATCH_ENTRY_L0 already returns the second value.
|
|
|
|
database before quitting
|
|
|
|
|
|
|
|
|
|
1e8cc676 mlog: allow using numerical level as default prefix (moneromooo-monero)
8028b532 protocol: log received messages in a separate category (moneromooo-monero)
|
|
eg, 2,foo:ERROR,bar:INFO
|
|
Makes it easier to log just what's going on on P2P
|
|
f0989893 core: cache tx hashes of failing semantics txes (moneromooo-monero)
|
|
13dd102e mlog: fix default level/category mapping (moneromooo-monero)
|
|
20f71527 wallet2: fix sending a rct tx with a single output available (moneromooo-monero)
|
|
b70ab128 rpc: fix orphan_status when getting blocks (moneromooo-monero)
|
|
4cdf0a35 p2p: always recreate a new peer id on startup (moneromooo-monero)
|
|
f9293b69 unit_tests: fix missing return after batch_start prototype change (moneromooo-monero)
|
|
f8b97aef p2p: show ban/unban logs by default again (moneromooo-monero)
|
|
7c3f79cb core: early out in handle_incoming_tx if already in pool or blockchain (moneromooo-monero)
6cc7d261 ringct: reorder a bit to check quicker tests first (moneromooo-monero)
|
|
a854cec3 Make stack trace show up in log file with default settings (moneromooo-monero)
|
|
c3b8ddff streamline (vdo)
|
|
1c4d65c0 Rename method to get_random_gray_peer (Miguel Herranz)
03a54ee0 Fix logging that broke after rebasing (Miguel Herranz)
6bdd3a59 Use set_peer_just_seen to keep last_seen updated (Miguel Herranz)
82dbeedd Add gray peer list housekeeping system (Miguel Herranz)
|
|
4d6976fb undelete epee tests.cpp (moneroexamples)
0fd2508b removing some unsed epee files (moneroexamples)
|
|
|
|
It was not matching the LOG_PRINT_Lx mapping for 2/3/4
|
|
This would have tried to send a second output to make the tx
look like the 2/2 ideal, but it would not fail to find one
because picking an output from preferred_inputs priority list
did not remove it from the unused tranfer/dust outputs, so
it would try to send the same output twice.
While there, I also added a check to avoid sending a second
input if it's related to the first. Better 1/2 than linking
inputs, I think.
|
|
It was always set to false, even for orphan blocks
|
|
This prevents easy fingerprinting when you change IPs, and
will be a must when kovri gets used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
A random peer from the gray peer list is selected and a connection is
made to check if the peer is alive.
If the connection and handshake are successful the peer is promoted to
the white peer list, in case of failure the peer is evicted from the
gray peer list.
The connection is closed after the check in either case.
|
|
|
|
|
|
17246d05 wallet: print exception message on get_random_outs_error (moneromooo-monero)
|
|
7c0c5c17 easylogging++: detect DragonFly BSD as a UNIX (moneromooo-monero)
|
|
cbcdf8ad Honor depth in get_peerlist_head method (Miguel Herranz)
|
|
78d560a9 simplewallet: use MAKE_CORE_RPC_VERSION(1,4) instead of 0x10004 (kenshi84)
|
|
87c658f8 wallet2_api: add API to set log categories (moneromooo-monero)
|
|
843769f8 Tweak some msg loglevels (Howard Chu)
|
|
5e61687f mlog: allow overriding log format (moneromooo-monero)
5161f16f easylogging++: enforce recursive mutex (moneromooo-monero)
|
|
0e0e6c5f Reduce to one connection per IP (Miguel Herranz)
3f269e98 Limit incoming connections from the same IP (Miguel Herranz)
|
|
|
|
|
|
|
|
The method returned depth + 2 because:
- push_back was executed before the condition.
- > instead of >= causing one more iteration.
|
|
|
|
|
|
|
|
using the MONERO_LOG_FORMAT environment variable.
Default is:
%datetime{%Y-%M-%d %H:%m:%s.%g}\t%thread\t%level\t%logger\t%loc\t%msg
Field list in easylogging++ documentation.
Don't forget to escape as needed.
|
|
This fixes a hang when logging something which causes some other
logging code to be called
|
|
|
|
a480bf6b fixups in logging init calls, and add missing net context in a log (moneromooo-monero)
|
|
990e08f0 Fix PR#1506, off by one in chain height (Howard Chu)
|
|
e389bd9e Makefile: remove mistakenly added local custom target (moneromooo-monero)
|
|
693c1908 wallet: add a node RPC cache layer for simple RPC calls (moneromooo-monero)
d86ae2be wallet2: reuse fake outs when adjusting fee on transfer (moneromooo-monero)
64da0983 core: don't try to deserialize an empty extra to remove a field (moneromooo-monero)
|
|
|
|
|
|
Mostly getinfo and get_hard_fork_info, which are called
pretty often. This speeds up transfers as a bonus.
|
|
This avoids indirectly leaking the real output to the daemon,
and is faster.
This will still happen for more complex cases, especially
when cancelling a tx and "re-rolling" it.
|
|
|
|
|
|
16b8b66a specify restore height by YYYY-MM-DD format (kenshi84)
|
|
5833d66f Change logging to easylogging++ (moneromooo-monero)
dc98019b easylogging++: fix logging with static const header only data members (moneromooo-monero)
3b46617b easylogging++: add ELPP_DISABLE_CHECK_MACROS (moneromooo-monero)
6fe39d90 easylogging++: allow clipping a common filename prefix (moneromooo-monero)
43abf6ff easylogging++: add file-only logs (moneromooo-monero)
c313bea4 eayslogging++: Fix bad memory access before opening any files (moneromooo-monero)
0af5d168 easylogging++: avoid creating directory/filename for the builtin default log file (moneromooo-monero)
28362847 easylogging++: allow setting thread names (moneromooo-monero)
ec71ce8d easylogging++: Print thread ID in a nicer way (moneromooo-monero)
2a0bf783 easylogging++: Add logging categories (moneromooo-monero)
c50bbbfe easylogging++: import upstream (moneromooo-monero)
|
|
|
|
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
|
|
|
|
|
|
|
|
|
|
|
|
file
|
|
|
|
|
|
|
|
|
|
ce866d1c macro to define core RPC version for avoiding future mistake (kenshi84)
|
|
6da9335a blockchain_import: fix build after tx_pool::add_tx changes (moneromooo-monero)
|
|
d561f4ad enable clang checks that were disabled (Chris Vickio)
0aefb2f6 remove std::move from return statements (pessimizing-move warning) (Chris Vickio)
629d5b76 change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio)
fb76d439 add extra braces around subobjects (missing-braces warning) (Chris Vickio)
3b6d5f25 make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio)
fcf66925 remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio)
296f8c16 inline unused function (for unused-function warning) (Chris Vickio)
|
|
|
|
|
|
f5f4109f mnemonics: fix language detection with checksum word (moneromooo-monero)
|
|
feb499aa core: check block version for alt chains too (moneromooo-monero)
|
|
ba3968f6 rct: split rct checks between semantics and other (moneromooo-monero)
|
|
b3ca0c62 unit_tests: fix portable serialization tests hardcoded data path (moneromooo-monero)
|
|
d276a165 wallet2: use at least two rct inputs if possible (moneromooo-monero)
|
|
dea53962 fix timeout in check_connection (Jaquee)
|
|
81c384e4 fix do_not_relay not preventing relaying on a timer (moneromooo-monero)
|
|
5b5017e2 rpc: add a command to get info about the current blockchain (moneromooo-monero)
|