Age | Commit message (Collapse) | Author | Files | Lines |
|
6efeefbc epee: set application/json MIME type on json errors (moneromooo-monero)
|
|
b9b5c473 threadpool: use std::move when taking an element off the queue (moneromooo-monero)
|
|
56dced2d translations: fix "monero_" prefix when taking languages from file (moneromooo-monero)
be3a4326 translations: find lrelease disguised as lrelease-qt5 (moneromooo-monero)
|
|
a7a40e28 Actually concatenate error strings. (Bert Peters)
|
|
b2ad757f Replace memset with memwipe. (Bert Peters)
|
|
6dec0013 simplewallet: fix restore height warning (selsta)
|
|
584d057f epee: fix console_handlers_binder race, wait for thread to finish (xiphon)
|
|
21d4c216 blockchain: error out if the builtin hashes data size is wrong (moneromooo-monero)
|
|
feef1c6a epee: fix peer ids being truncated on display (moneromooo-monero)
|
|
6f45cfa5 p2p: zero last seen timestamp when inserting a new peer (moneromooo-monero)
|
|
27522aaa core_tests: reset thread pool between tests (moneromooo-monero)
|
|
7c1d31b0 build: fix IOS, build blockchain_db and rpc, skip wallet_rpc_server (xiphon)
|
|
da6c807f tests: fix HF12 chaingen - construct bc object from events (Dusan Klinec)
|
|
0de8a0d3 wallet_rpc_server: new estimate_tx_size_and_weight RPC (moneromooo-monero)
|
|
8e338e5 depends: update libsodium to 1.0.18 (TheCharlatan)
|
|
f9b48b91c GPGKey: Add Snipa (Alexander Blair)
|
|
aa9ba30 add binaryFate's PGP key (binaryFate)
|
|
Adds GPG key for Alexander Blair (Snipa)
|
|
|
|
|
|
3b8dcc2 wallet2: make keys unlocker reentrant (moneromooo-monero)
|
|
5a44893 python-rpc: add missing strict_balances parameter for get_accounts (moneromooo-monero)
|
|
886ed25 blockchain: fix comment wrongly refering to SHA-3 rather than Keccak (moneromooo-monero)
|
|
017f816 daemon: handle printing higher hash rates (moneromooo-monero)
|
|
c96b7ee tx_pool: fix error message assuming incorrectly (moneromooo-monero)
|
|
45fd72b Updated paper references (SarangNoether)
277003f Minor prover simplification (SarangNoether)
|
|
261abf7 functional_tests: ensure mining stops on error in mining test (moneromooo-monero)
|
|
f49a8ca easylogging++: add screen.xterm-256color to the 'allow colour' TERM list (moneromooo-monero)
|
|
9768e96 simplewallet: remove remaining payment id dead code (moneromooo-monero)
|
|
dce6f05 rpc: Only show version string if it matches expected pattern (ndorf)
3293780 daemon: Use rpc for 'version' command (ndorf)
|
|
5d7ae2d Adding support for hidden (anonymity) txpool (vtnerd)
|
|
9cb8d92 ANONYMITY_NETWORKS.md : fix unintentional wrapping (jonathancross)
|
|
|
|
0f7c9f4 Gitian Readme: adding android signing & fix v0.15 checksum. (jonathancross)
|
|
d8fc8d8 make d2h et al. constant-time (jtgrassie)
|
|
|
|
47d094c Fix #6147 DB corruption from child process overwrite (hyc)
|
|
gitian: add FreeBSD support (75c5a04, 607c01a, cca6e5c, 35b5e91, 024a1c7, b14d9ab, 5eea312, 9cbba5a, 2e435df, abeed9a) (hyc)
|
|
By omitting the otool binary which is built non-deterministically.
We don't use it anyway.
|
|
Don't leave stdout/stderr dangling on a fork.
|
|
|
|
Sort objects being archived
|
|
get rid of sodium-darwin.mk special case, unify back with sodium.mk
|
|
streamline, remove obsolete wrappers
|
|
Needed to invoke deterministic mode on some archivers
|
|
09f59ec wallet: set non-empty error string on connection failure (xiphon)
|
|
3d649d5 epee: close connection when the peer has done so (moneromooo-monero)
|
|
|
|
It has a std::function, which can have a capture context, and
the function runtime might be small
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
27457a2 wallet2: fix pool txes not being flushed when mined (moneromooo-monero)
|
|
This fixes rapid reconnections failing as the peer hasn't yet
worked out the other side is gone, and will reject "duplicate"
connections until a timeout.
|
|
|
|
|
|
|
|
Avoids a DB error (leading to an assert) where a thread uses
a read txn previously created with an environment that was
since closed and reopened. While this usually works since
BlockchainLMDB renews txns if it detects the environment has
changed, this will not work if objects end up being allocated
at the same address as the previous instance, leading to stale
data usage.
Thanks hyc for the LMDB debugging.
|
|
|
|
|
|
|
|
e8c5ab515 gitian: fix out dir location (iDunk5400)
|
|
5b78c27c5 Copy LICENSE to all archives (Howard Chu)
|
|
|
|
|
|
2bfd41b29 depends: fix typo in packages (selsta)
|
|
|
|
38f691048 simplewallet: plug a timing leak (moneromooo-monero)
dcff02e4c epee: allow a random component in once_a_time timeouts (moneromooo-monero)
e10833024 wallet: reuse cached height when set after refresh (moneromooo-monero)
5956beaa1 wallet2: fix is_synced checking target height, not height (moneromooo-monero)
fd35e2304 wallet: fix another facet of "did I get some monero" information leak (moneromooo-monero)
d5472bd87 wallet2: do not send an unnecessary last getblocks.bin call on refresh (moneromooo-monero)
97ae7bb5c wallet2: do not repeatedly ask for pool txes sent to us (moneromooo-monero)
|
|
240dbb124 gitian: add --rebuild option (Howard Chu)
643860776 Add Android support (Howard Chu)
|
|
436e4c336 Fix readline build (Howard Chu)
4ad0f0038 Merge pull request #6079 (Riccardo Spagni)
fb9b741bf README update upgrade table (Gingeropolous)
5ae029881 unit_tests: fix use after free (moneromooo-monero)
d31024c2e cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
0e3b823a1 daemon: always use bootstrap daemon (if set) in '--no-sync' mode (xiphon)
508dcfada RandomX: Update to v1.1.6 (tevador)
78e59f531 Merge pull request #6059 (Riccardo Spagni)
86ac20f64 blockchain: fix unwanted error when probing the pool for a tx (moneromooo-monero)
8ff9e6bc3 wallet: do not warn if the rpc cost was free (moneromooo-monero)
|
|
Avoids delays when sourceforge is slow to respond; allows rebuilding
when disconnected from networks.
|
|
|
|
Make sure it links to our libtinfo from our ncurses build.
Hardcode some basic terminal descriptions into our libtinfo.
Re-enable $HOME/.terminfo support to allow user customization.
Use unlikely terminfo-dir, to prevent accidentally using
differently-configured system databases.
|
|
|
|
e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
|
|
e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
|
|
1554a7768 unit_tests: fix use after free (moneromooo-monero)
|
|
ebc6ce44f cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
|
|
2e2bf8a20 daemon: always use bootstrap daemon (if set) in '--no-sync' mode (xiphon)
|
|
2efc6acdb RandomX: Update to v1.1.6 (tevador)
|
|
|
|
fb9b741bf README update upgrade table (Gingeropolous)
|
|
f89ea437d README update upgrade table with details (Gingeropolous)
|
|
As reported by Tramèr et al, timing of refresh requests can be used
to see whether a password was requested (and thus at least one output
received) since this will induce a delay in subsequent calls.
To avoid this, we schedule calls at a given time instead of sleeping
for a set time (which would make delays additive).
To further avoid a scheduled call being during the time in which a
password is prompted, the actual scheduled time is now randomized.
|
|
|
|
Refreshing sets cached height, which is otherwise got by calling
get_info. Since get_info is called upon needing to display a prompt
after a command has finished, it can be used to determine how much
time a given command took to run if the cache timeout lapses while
the command runs. Refreshing caches the height as a side effect, so
get_info will never be called as a result of displaying a prompt
after refreshing (and potentially leaking how much time it took to
process a set of transactions, therefore leaking whether we got
some monero in them).
|
|
Target height would be appropriate for the daemon, which syncs
off other daemons, but the wallet syncs off the daemon it's
connected to, and its target is the daemon's current height.
|
|
We get new pool txes before processing any tx, pool or not.
This ensures that if we're asked for a password, this does not
cause a measurable delay in the txpool query after the last
block query.
|
|
The "everything refreshed" state was detected when a refresh call did
not return any new blocks. This can be detected without that extra
"empty" call by comparing the claimed node height to the height of
the last block retrieved. Doing this avoids that last call, saves
some bandwidth, and makes the common refresh case use only one call
rather than two.
As a side effect, it prevents an information leak reported by
Tramèr et al: if the wallet retrieves a set of blocks which includes
an output sent to the refreshing wallet, the wallet will prompt the
user for the password to decode the amount and calculate the key
image for the new output, and this will delay subsequent calls to
getblocks.bin, allowing a passive adversary to note the delay and
deduce when the wallet receives at least one output.
This can still happen if the wallet downloads more than 1000 blocks,
since this will be split in several calls, but then the most the
adversary can tell is which 1000 block section the user received
some monero (the adversary can estimate the heights of the blocks
by calculating how many "large" transfers are done, which will be
sections of blocks, the last of which will usually be below 1000,
but the size of the data should allow the actual number of blocks
sent to be determined fairly accurately).
This timing trick still be used via the subsequent scan for incoming
txes in the txpool, which will be fixed later.
|
|
5ae029881 unit_tests: fix use after free (moneromooo-monero)
|
|
d31024c2e cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
|
|
0e3b823a1 daemon: always use bootstrap daemon (if set) in '--no-sync' mode (xiphon)
|
|
508dcfada RandomX: Update to v1.1.6 (tevador)
|
|
45b6b6038 Updating gitian yml files for v0.15 (Jonathan Cross)
|
|
45b6b6038 Updating gitian yml files for v0.15 (Jonathan Cross)
|
|
This lets a passive attacker with access to the network link
between node and wallet perform traffic analysis to deduce
when an idle wallet receives a transaction.
Reported by Tramèr et al.
|
|
with details for nov 30th network upgrade
|
|
of the november 30th fork
|
|
|
|
|
|
It causes link errors at least on mac
|
|
It causes link errors at least on mac
|
|
|
|
|
|
|
|
|
|
protects against having your keys mangled
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
eb16755 blockchain: fix unwanted error when probing the pool for a tx (moneromooo-monero)
|
|
e8964c2 wallet: do not warn if the rpc cost was free (moneromooo-monero)
|
|
86ac20f blockchain: fix unwanted error when probing the pool for a tx (moneromooo-monero)
|
|
8ff9e6b wallet: do not warn if the rpc cost was free (moneromooo-monero)
|
|
|
|
|
|
this prevents messing up any subsequent test too
|
|
|
|
|
|
|
|
7bca3e0 CMake build out of source (trasherdk)
|
|
|
|
da2ffd6 python-rpc: add missing daemon RPC (moneromooo-monero)
|
|
5734686 rpc: Include tag in get_info version string (ndorf)
|
|
aceb1dc Translations from weblate + resync (Monero-Weblate)
|
|
f7f7513 rpc: fix PRIx64 build error on some systems (moneromooo-monero)
|
|
978a61f functional_tests: fix rpc_payment tests with python 3 (moneromooo-monero)
|
|
|
|
|
|
|
|
296ec7c device: bounds checking in Ledger send_secret/receive_secret (xiphon)
|
|
d25acd7 Add hmac over encrypted value during transaction (clashm)
34f28a7 Add display address (clashm)
235b94e Revert PR #5835 (export view key) (clashm)
32febd2 Fix debug feature (clashm)
|
|
27cb8bc revert changes to translations (moneromooo-monero)
|
|
Those should be updated from the Weblate tool only
|
|
174a6ac tx_pool: fix divide by 0 in log (moneromooo-monero)
|
|
a4dc575 rpc: add a flush_cache RPC (moneromooo-monero)
|
|
643dcb9 net: link with libzmq (moneromooo-monero)
|
|
dd28383 depends: bump cppzmq version to 4.4.1 (anonimal)
157b3fc depends: bump zeromq version to 4.1.7 (anonimal)
|
|
65e8a89 Change monerod --proxy to --tx-proxy (vtnerd)
|
|
3816ac2 build: fix building on Windows due to _FORTIFY_SOURCE changes in MSYS2 (iDunk5400)
78b076c Windows: enable high-entropy ASLR where available (iDunk5400)
|
|
d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
|
|
93e7426 wallet2: error out when we need a daemon password but have no prompt function (moneromooo-monero)
|
|
635401b wallet2: fix the logged number of detached transfers (moneromooo-monero)
|
|
This allows flushing internal caches (for now, the bad tx cache,
which will allow debugging a stuck monerod after it has failed to
verify a transaction in a block, since it would otherwise not try
again, making subsequent log changes pointless)
|
|
b3a9a4d add a quick early out to get_blocks.bin when up to date (moneromooo-monero)
2899379 daemon, wallet: new pay for RPC use system (moneromooo-monero)
ffa4602 simplewallet: add public_nodes command (moneromooo-monero)
|
|
Coverity 205394
|
|
pointed out by coverity
|
|
Translators:
* Ukrainian
* Agent LvM
* TheFuzzStone
* Italian
* erciccione
* Luca Ciavatta
* Alessandro Lotta
* stefanomarty
* Chinese (Traditional)
* Lafudoci
* Catalan
* Assumpta Anglada
* BennyBeat
* Ecron
* Joan Montané
* Russian
* Agent LvM
* TheFuzzStone
* Russian Bear
* Japanese
* Andrew Onishi
* Scott Anecito
* French
* el00ruobuob
* glv2
* Viktor
* Czech
* dskch83
* Chinese (Simplified)
* jindouyunz
* TE Scott
* razorshaman909
* Dutch
* Jonathan Heirbaut
* siesero
* German
* fullmetalScience
* Christian
* M5M400
* Sneaky Squid
* Paul Rant
* Tim Hartmann
|
|
|
|
|
|
Lists nodes exposing their RPC port for public use
|
|
Daemons intended for public use can be set up to require payment
in the form of hashes in exchange for RPC service. This enables
public daemons to receive payment for their work over a large
number of calls. This system behaves similarly to a pool, so
payment takes the form of valid blocks every so often, yielding
a large one off payment, rather than constant micropayments.
This system can also be used by third parties as a "paywall"
layer, where users of a service can pay for use by mining Monero
to the service provider's address. An example of this for web
site access is Primo, a Monero mining based website "paywall":
https://github.com/selene-kovri/primo
This has some advantages:
- incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own
- incentive to run your own node instead of using a third party's, thereby promoting decentralization
- decentralized: payment is done between a client and server, with no third party needed
- private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance
- no payment occurs on the blockchain, so there is no extra transactional load
- one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy)
- no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do
- Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue
- no large credit balance maintained on servers, so they have no incentive to exit scam
- you can use any/many node(s), since there's little cost in switching servers
- market based prices: competition between servers to lower costs
- incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others
- increases network security
- helps counteract mining pools' share of the network hash rate
- zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner
And some disadvantages:
- low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine)
- payment is "random", so a server might go a long time without a block before getting one
- a public node's overall expected payment may be small
Public nodes are expected to compete to find a suitable level for
cost of service.
The daemon can be set up this way to require payment for RPC services:
monerod --rpc-payment-address 4xxxxxx \
--rpc-payment-credits 250 --rpc-payment-difficulty 1000
These values are an example only.
The --rpc-payment-difficulty switch selects how hard each "share" should
be, similar to a mining pool. The higher the difficulty, the fewer
shares a client will find.
The --rpc-payment-credits switch selects how many credits are awarded
for each share a client finds.
Considering both options, clients will be awarded credits/difficulty
credits for every hash they calculate. For example, in the command line
above, 0.25 credits per hash. A client mining at 100 H/s will therefore
get an average of 25 credits per second.
For reference, in the current implementation, a credit is enough to
sync 20 blocks, so a 100 H/s client that's just starting to use Monero
and uses this daemon will be able to sync 500 blocks per second.
The wallet can be set to automatically mine if connected to a daemon
which requires payment for RPC usage. It will try to keep a balance
of 50000 credits, stopping mining when it's at this level, and starting
again as credits are spent. With the example above, a new client will
mine this much credits in about half an hour, and this target is enough
to sync 500000 blocks (currently about a third of the monero blockchain).
There are three new settings in the wallet:
- credits-target: this is the amount of credits a wallet will try to
reach before stopping mining. The default of 0 means 50000 credits.
- auto-mine-for-rpc-payment-threshold: this controls the minimum
credit rate which the wallet considers worth mining for. If the
daemon credits less than this ratio, the wallet will consider mining
to be not worth it. In the example above, the rate is 0.25
- persistent-rpc-client-id: if set, this allows the wallet to reuse
a client id across runs. This means a public node can tell a wallet
that's connecting is the same as one that connected previously, but
allows a wallet to keep their credit balance from one run to the
other. Since the wallet only mines to keep a small credit balance,
this is not normally worth doing. However, someone may want to mine
on a fast server, and use that credit balance on a low power device
such as a phone. If left unset, a new client ID is generated at
each wallet start, for privacy reasons.
To mine and use a credit balance on two different devices, you can
use the --rpc-client-secret-key switch. A wallet's client secret key
can be found using the new rpc_payments command in the wallet.
Note: anyone knowing your RPC client secret key is able to use your
credit balance.
The wallet has a few new commands too:
- start_mining_for_rpc: start mining to acquire more credits,
regardless of the auto mining settings
- stop_mining_for_rpc: stop mining to acquire more credits
- rpc_payments: display information about current credits with
the currently selected daemon
The node has an extra command:
- rpc_payments: display information about clients and their
balances
The node will forget about any balance for clients which have
been inactive for 6 months. Balances carry over on node restart.
|
|
Resolves https://hackerone.com/reports/652911
|
|
|
|
|
|
0136bf7 v12 fork heights (tevador)
|
|
|
|
afcfb3b easylogging++: windows does not need terminal colour support (moneromooo-monero)
|
|
56895ee cmake: Fix generation of version.cpp (ndorf)
|
|
|
|
Also, enable other hardening options that work on Windows with GCC 9.x
|
|
|
|
28a627c gen_ssl_cert: new tool to generate SSL certs for Monero (moneromooo-monero)
|
|
|
|
951ceab daemon: print difficulty in decimal, as it used to be (moneromooo-monero)
|
|
9f3be3b epee: use SO_REUSEADDR on non-Windows targets (xiphon)
|
|
0da09ed protocol: fix syncing from peers being too choosy about peers (moneromooo-monero)
|
|
It got switched to hexadecimal when we went to 128 bit values
|
|
22d1a6c RandomX: update to v1.1.5 (tevador)
|
|
|
|
705edd8 daemon: fix coinbase txes always being seen as pruned (moneromooo-monero)
|
|
641c9cf daemon: add miner tx hash in print_block output (moneromooo-monero)
|
|
fbf8168 utils: Increase max block size for import/export (ndorf)
|
|
37cccb8 db_lmdb: an empty prunable data record means the tx is not pruned (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
abd3763 cryptonote: fill in tx weight when syncing from pruned blocks (moneromooo-monero)
|
|
9447e72 cryptonote: add function to get weight from a pruned tx (moneromooo-monero)
|
|
23ba69e epee: fix SSL server handshake, run_one() can block, use poll_one() (xiphon)
|
|
4f583d5 daemon: fix print_pl synopsis missing recent options (moneromooo-monero)
|