Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
9b00d80f wallet2: pass by const ref where possible (moneromooo-monero)
|
|
f4a3ce15 Fix sending outputs from a tx with more than one pubkey (moneromooo-monero)
|
|
dfbb85b6 blockchain: fix setting non trovial alternate chain as invalid (moneromooo-monero)
|
|
b9c5f29d Revert forcing -fPIC for all ARMv8 builds (NanoAkron)
|
|
Reported by kenshi84
|
|
A bug in cold signing caused a spurious pubkey to be included
in transactions, so we need to ensure we use the correct one
when sending outputs from one of those.
|
|
|
|
The wrong iterator was being used.
Also preincrement iterators to avoid possibly invalidating them,
I'm not sure this is necessary, but let's be safe.
|
|
0b91d825 simplewallet: restore automatically setting trusted local daemon (moneromooo-monero)
|
|
6c44f5c6 wallet: send 0 change to a random address where necessary with rct (moneromooo-monero)
|
|
3b005275 ringct: add sc_check calls in MLSAG_Ver for ss and cc (moneromooo-monero)
2f1732a7 ringct: guard against bad data exceptions in worker threads (moneromooo-monero)
|
|
648ea6be blockchain: bring the v4 fork height one block forward (luigi1111)
46a0dcc1 ringct: luigi1111's changes to fix and speedup Borromean sigs (luigi1111)
76958fc7 ringct: switch to Borromean signatures (Shen Noether)
|
|
d1a75754 Remove infinite loop in refresh code (Jaquee)
|
|
18462aa0 Added confirmation before binding wallet-rpc to external IP (Lee Clagett)
|
|
|
|
luigi1111's recommendation
|
|
If purported pubkeys aren't actually valid pubkeys, exceptions
will fly. These will terminate if thrown in a worker thread.
Guard against this.
|
|
If a rct transaction would cause no change to be generated, a zero
change output is added, and sent to a randomly generated address.
This ensures that no transaction will be sent with just one output,
which could cause the receiver to be able to determine which of the
inputs in the sent rings is the real one.
This is very rare, since it requires the sum of outputs to be equal
to the sum of outputs plus the fee, which is now a function of the
last few blocks.
|
|
This will ensure the early 0.10 daemons will barf at the fork
height, and not a bit later, which could be confusing.
|
|
|
|
This reverts commit fd181b03bb58a8b0628d2af8637cf6bb968fc437.
|
|
|
|
|
|
60633cf6 Spelling in errors (taushet)
|
|
bdd3fb85 Spelling in errors. (taushet)
|
|
73ac3b8e wallet2: avoid possible undefined behavior on empty string (moneromooo-monero)
|
|
f4772bae Fix a few minor typos (Pierre Boyer)
|
|
3f7d6fb5 Fix delayed exit when syncing (moneromooo-monero)
|
|
7c0dd5e4 net_node: drop connections from banned IPs after looping through connections (moneromooo-monero)
|
|
59443bf9 ringct: fix MGs serialization to JSON (moneromooo-monero)
|
|
0e18f465 db_lmdb: add info in an error message when we can't get an output (moneromooo-monero)
c96f9b02 db_lmdb: guard against going out of sync on unexpected db results (moneromooo-monero)
bef51e67 db_lmdb: minor pedantic tweaks (moneromooo-monero)
3465c4eb db_lmdb: set same packing format for output_data_t and pre_rct_output_data_t (moneromooo-monero)
|
|
204b1bff blockchain: use high bound block reward on error where appropriate (moneromooo-monero)
|
|
4adde042 p2p: possibly fix crash in relay_blocks (moneromooo-monero)
|
|
5783dd8c tests: add unit tests for uri parsing (moneromooo-monero)
82ba2108 wallet: add API and RPC to create/parse monero: URIs (moneromooo-monero)
d9001b43 epee: add functions to convert from URL format (ie, %XX values) (moneromooo-monero)
|
|
fcd178ef wallet_api: add a few daemon related getters (moneromooo-monero)
|
|
8f6ec90c blockchain: reject invalid pubkeys from v4 (moneromooo-monero)
|
|
8b0e04cb monero.supp: add a suppression for noisy boost cond var signalling (moneromooo-monero)
c3527daf epee: signal cond var before unlocking (moneromooo-monero)
|
|
00592189 change 'invalid address format' loglevel (Jaquee)
|
|
657a70e0 wallet: add a getter for the filename path (moneromooo-monero)
|
|
d6086f5b Improve daemon RPC version handling (moneromooo-monero)
|
|
91ffb61c Added command_line::is_yes (Lee Clagett)
|
|
1df0fc71 Fix formatting of RPi2 build instructions (NanoAkron)
|
|
|
|
|
|
|
|
|
|
|
|
This keeps the connections lock just for the time of looping
and adding connectoins to a list, and the dropping happens
after it. This should avoid lengthy delays waiting for the
connections lock.
|
|
|
|
|
|
If the block reward to use for the fee calculation can't be
calculated (should not happen in practice), use a high bound,
so we use a fee overestimate that will be accepted by the network.
|
|
Will be useful to debug
|
|
m_num_outputs keeps track of the number of outputs, which should
be the same as the size of both the output_txs and output_amounts
databases. If one goes out of sync, we need to throw to abort
whatever it is we were doing.
|
|
Add consts in a few places where it makes sense, avoid unnecessary
memory reallocation where we know the full size needed at the outset,
simplify and avoid memory copy.
|
|
For safety, though it seems to have been the case already.
Also add a comment about the necessary layout identity.
|
|
Blockchain height, version, Mining hash rate...
|
|
|
|
|
|
|
|
|
|
|
|
This is more canonical, and avoids some helgrind spam
|
|
|
|
|
|
Daemon RPC version is now composed of a major and minor number,
so that incompatible changes bump the major version, while
compatible changes can still bump the minor version without
causing clients to unnecessarily complain.
|
|
|
|
17b6bd6 Fix DNS failures in offline mode preventing daemon startup (moneromooo-monero)
|
|
8dadf02 Fixed undefined behavior in TestDB (Lee Clagett)
|
|
6d76072 simplewallet: remove double confirmation when submitting signed tx (moneromooo-monero)
92dea04 wallet2: fix wrong change being recorded for cold signed txes (moneromooo-monero)
|
|
f6660e1 Updated GPG key for Jaquee (Jaquee)
|
|
67e910a Instructions for debugging LMDB crashes taken from #1360 (NanoAkron)
|
|
f025198 Added task_region - a fork/join task implementation (Lee Clagett)
|
|
ab7b56e tests: fix uninitialized data valgrind reports in levin tests (moneromooo-monero)
73e8a76 tests: fix uninitialized data valgrind reports in serialization tests (moneromooo-monero)
|
|
1d9e223 rpc: do not include output indices for pool txes (moneromooo-monero)
e227d6e rpc: bump version after RPC changes (moneromooo-monero)
2c0173c Add a get_outs (fully text based) version of get_outs.bin (moneromooo-monero)
e05907b rpc: add output indices to gettransactions (moneromooo-monero)
|
|
7abfc54 wallet: fix exporting outputs and key images with txes with two pubkeys (moneromooo-monero)
|
|
5fc36f9 wallet2_api: fix history leak on destruction (moneromooo-monero)
|
|
69b188c wallet2_api: fix payment ids from integrated addresses being ignored (moneromooo-monero)
|
|
452aeca epee: blind attempt to fix exit hang on windows (moneromooo-monero)
|
|
d01f5c7 wallet2: fix illegal memory access removing newlines from password (moneromooo-monero)
|
|
e6264a2 wallet2: fix decrypting a bit too much in authenticated mode (moneromooo-monero)
|
|
fd181b0 Clamp refresh from height to blockchain height. (Dion Ahmetaj)
|
|
|
|
|
|
|
|
|
|
|
|
Those aren't yet in the blockchain, so will not be found
(and aren't yet known, since it depends on where exactly the
tx will be mined in the next block or blocks)
|
|
|
|
|
|
|
|
Someone apparently needs that to make a wallet but never asked.
If you read that and that's not what you wanted, the bugtracker
is at https://github.com/monero-project/monero/issues
|
|
|
|
|
|
|
|
|
|
This also needs to make sure to pick the correct one, in the case
where cold signing caused to tx keys to be included.
|
|
|
|
|
|
|
|
Thanks to duckduckgo and the internet.
This might even compile.
|
|
|
|
|
|
4eb7347 wallet: return fee in transfer RPC (moneromooo-monero)
|
|
4fca34d Wallet2: calculate approximate blockchain height on offline creation (Jacob Brydolf)
|
|
a0131c8 wallet: auto sync outputs and key images in cold signing files (moneromooo-monero)
f806611 wallet2: fill key image and pubkey maps when importing outputs (moneromooo-monero)
5fe363c wallet: cast indices to string in logs to be nice to CLANG (moneromooo-monero)
11ae187 wallet2: try all tx keys when scanning a new transaction (moneromooo-monero)
072d646 wallet2: fill in key image map when importing key images (moneromooo-monero)
23d80b1 core: remove any tx pubkey from extra before adding one (moneromooo-monero)
d72376d simplewallet: add a verbose flag to incoming_transfers (moneromooo-monero)
47413a5 simplewallet: spell out change when signing a transfer (moneromooo-monero)
14cb088 simplewallet: print public keys too on spendkey/viewkey commands (moneromooo-monero)
a99ab49 wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
|
|
18772a3 tests: fix another fee test on 32 bit (moneromooo-monero)
|
|
bd4da18 simplewallet: include amount sent in transfer confirmation (moneromooo-monero)
|
|
d48f2e9 wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
|
|
|
|
When passing around unsigned and signed transactions, outputs
and key images are passed along (outputs are passed along unsigned
transactions from the hot wallet to the cold wallet, key images
are passed along with signed transations from the cold wallet
to the hot wallet), to allow more user friendly syncing between
hot and cold wallets.
|
|
|
|
|
|
The vast majority of transactions will have just one tx pubkey,
but a bug with cold wallet signing caused two such keys to be
there, with the second one being the real one.
|
|
|
|
This will happen when signing a transaction from a cold wallet,
and we don't want the placeholder the hot wallet put in it.
|
|
Prints pubkey and key image as well
|
|
Also catch change to multiple addresses, this is unexpected
|
|
|
|
|
|
|
|
|
|
|
|
265e460 Fixed generate-from-json bug introduced in 358e068 (Lee Clagett)
|
|
e1dd15b Don't build monero-wallet-rpc when building the GUI (iDunk5400)
|
|
|
|
Wallet API: add approximateBlockChainHeight()
|
|
|
|
70d4915 wallet: add version dependency to the wallet target (moneromooo-monero)
|
|
cd929b8 levin: fix wrong value passed as return code to remote call (moneromooo-monero)
|
|
77e5bec added cmd to compile gtest (Gingeropolous)
|
|
2078cb6 tests: fix tests builds after fluffy blocks merge (moneromooo-monero)
|
|
65528ae Always compile Position Independent Code on 64-bit ARMv8 systems (NanoAkron)
|
|
|
|
When receiving an answer packet, the command code was passed
to the callback instead of the error code. This was hiding
the "command not found" failure from the peer, and in turn
causing the code to attempt to deserialize a non existent
reply string.
|
|
|
|
|
|
|
|
358e068 Created monero-wallet-rpc, moving functionality from monero-wallet-cli (Lee Clagett)
|
|
0e418d2 rpc: bump RPC version (moneromooo-monero)
|
|
c27c0fe tests: fix fee unit tests on 32 bit (moneromooo-monero)
|
|
9150a16 Wallet API: use stored refresh height when rebuilding cache (Jacob Brydolf)
|
|
63772e4 wallet: fix corner case of no recent outputs available (moneromooo-monero)
|
|
1669621 wallet2_api: support for sweeping all (moneromooo-monero)
|
|
d61bd81 add lightweight block propagation ("fluffy blocks") (Dion Ahmetaj)
|
|
I forgot to bump it previously when changing RPC, most notably
for the addition of the unlocked field in the histogram RPC.
This causes new wallets to not realize when they're talking to
an older daemon, and get confused trying to get outputs to use
as fake outs. This otherwise gratuitous bump ensures than old
daemons will be detected by wallets using this code.
|
|
|
|
|
|
|
|
Added a new command to the P2P protocol definitions to allow querying for support flags.
Implemented handling of new support flags command in net_node. Changed for_each callback template to include support flags. Updated print_connections command to show peer support flags.
Added p2p constant for signaling fluffy block support.
Added get_pool_transaction function to cryptnote_core.
Added new commands to cryptonote protocol for relaying fluffy blocks.
Implemented handling of fluffy block command in cryptonote protocol.
Enabled fluffy block support in node initial configuration.
Implemented get_testnet function in cryptonote_core.
Made it so that fluffy blocks only run on testnet.
|
|
|
|
Also clarify related logs
|
|
acf908c thread_group: fix build with asserts enabled (moneromooo-monero)
|
|
5c4cb96 cryptonote_protocol: drop connection when find_blockchain_supplement fails (moneromooo-monero)
|
|
40a68e2 wallet2_api: add API for create_unmixable_sweep_transactions (moneromooo-monero)
|
|
c441a61 wallet2_api: API to sign and verify a message (moneromooo-monero)
|
|
4dcb74f wallet_api: PendingTransaction::txCount - number of split transactions (Ilya Kitaev)
|
|
c80f4d4 wallet: fix output collision detection for view wallets (moneromooo-monero)
|
|
See https://github.com/monero-project/monero/pull/1291
|
|
This will be when we can't find common ground between the peer's
short chain history and our blockchain.
This fixes bad peers claiming a higher blockchain height from never
dropped, and keeping the node in synchronizing state forever, since
we will never get blocks from that peer.
|
|
|
|
|
|
0c530de Wallet API: Pause refresh while creating transaction (Jacob Brydolf)
|
|
8aba0d4 wallet: encrypt outputs and key images files with the view key (moneromooo-monero)
|
|
63fe6fd wallet2_api: allow connection to return "yes, but wrong version" (moneromooo-monero)
|
|
35da3cb Wallet API: added getTxKey() (Jacob Brydolf)
|
|
|
|
eb19492 wallet2_api: do not copy the whole pending tx when iterating (moneromooo-monero)
|
|
97288a5 wallet2_api: add API for tx notes (moneromooo-monero)
|
|
af8a260 wallet_api: txkey checking functions for the GUI (moneromooo.monero)
|
|
e59caf8 performance_tests: re-enable them... (moneromooo-monero)
|
|
64094e5 adding thread_group for managing async tasks (Lee Clagett)
|
|
7edf76f CONTRIBUTING: add something about testing and bug reporting (moneromooo-monero)
|
|
a970a4e refresh speedup (luigi1111)
|
|
bc9b498 README: update coverity project number (anonimal)
9d9ab38 README: update armv8 link, add more coverage types (anonimal)
6f7f21f README: update build matrix (distro and ordering) (anonimal)
6711b98 README: add Freenode custom webchat link (anonimal)
b57d1e1 README: add build matrix like that in Kovri (anonimal)
38dc0bf README/Repo: remove Travis CI (anonimal)
|
|
18f66f4 wallet: use the dynamic per kB fee (moneromooo-monero)
e6deb8a rpc: add a dynamic fee estimation RPC call (moneromooo-monero)
82dbba1 core: dynamic fee algorithm from ArticMine (moneromooo-monero)
|
|
|
|
|
|
This key is available to both cold and hot wallet.
Authenticated encryption will guard against interception and/or
modification of the file.
|
|
View wallets do not have the spend secret key, and are thus
unable to derive key images for incoming outputs. Moreover,
a previous patch set key images to zero as a means to mark
an output as having an unknown key image, so they could be
filled in when importing key images at a later time. That
later patch caused spurious collisions. We now use public
keys to detect duplicate outputs. Public keys obtained from
the blockchain are checked to be identical to the ones
derived locally, so can't be spoofed.
|
|
|
|
|
|
- Fixes armv8 build link
- Adds coverage matrix, coverity and license badges
|
|
|
|
|
|
|
|
b5d6faa wallet: fix bad amounts/fees again (moneromooo-monero)
|
|
|
|
I think I'm the only one to review things here...
|
|
|
|
m_amount_out was sometimes getting initialized with the sum of
an transaction's outputs, and sometimes with the sum of outputs
that were not change. This caused confusion and bugs. We now
always set it to the sum of outputs. This reverts an earlier
fix for bad amounts as this used the other semantics. The wallet
data should be converted automatically in a percentage of cases
that I'm hesitant to estimate. In any case, restoring from seed
or keys or rebuilding the cache will get it right.
|
|
48b57d8 monero.supp: valgrind suppressions file (moneromooo-monero)
ffd8c41 ringct: check the size of amount_keys is the same as destinations (moneromooo-monero)
836669d ringct: always shutdown the boost io service (moneromooo-monero)
|
|
Compute derivation only once per tx, instead of once per output. Approx 33% faster while using 75% as much CPU on my machine. Note old functions in cryptonote_core (lookup_acc_outs and is_out_to_acc) are still used by tests.
|
|
43ec2d0 Wallet API: added walletExists logic (Jacob Brydolf)
|
|
4869db7 adding static_assert to pod functions in string tools (Lee Clagett)
|
|
f5ccfa4 core: fix removal of extra nonce using wrong type (moneromooo-monero)
3c2cad2 Revert "remove cn_deserialize" (moneromooo-monero)
|
|
bb560dd wallet: new import_outputs/export_outputs commands (moneromooo-monero)
|
|
7e6d3cf wallet: set incoming outputs' key image to 0 on view wallets (moneromooo-monero)
1f9e6a4 wallet: print tx overview on submit_transfer too (moneromooo-monero)
|
|
4bfb81a simplewallet: remove destinations with zero amount in sign_transfer (moneromooo-monero)
|
|
f71b067 Changed to ..._HASHBITS everywhere for consistency (NanoAkron)
|