Age | Commit message (Collapse) | Author | Files | Lines |
|
0dbdba8 epee: avoid spamming 'Generating SSL certificate' in the logs (xiphon)
|
|
68ffc1c README: clean up TOC (selsta)
|
|
ec01077 db_lmdb: fix race crash using a stale cursor (moneromooo-monero)
|
|
e719760 Fix receive order leakage with tx fluffing (vtnerd)
|
|
ebf3c10 Added logging for dropped local txes with no i2p/tor connections (vtnerd)
|
|
7b9017f p2p: plug tor to clearnet association vector (Aaron Hook)
|
|
b40c27c cppzmq: remove leftovers (selsta)
|
|
3031deb Bump downloaded boost version to 1.72 (omartijn)
6079042 Use boost::asio::ssl::context::sslv23 for backwards compatibility (omartijn)
|
|
6e1cb5a device: Ledger - fix wide char hidapi error string conversion (xiphon)
|
|
68a6507 Fixed bug in ZMQ JSON-RPC method field (vtnerd)
|
|
42a7a4d daemon: auto public nodes - cache and prioritize most stable nodes (xiphon)
|
|
56c4eda Provides safer semaphore privilege to jail; notes port/pkg availability (scoobybejesus)
|
|
6810150 daemon: if no banned IPs print something (sumogr)
|
|
81c5943 Remove temporary std::string creation in some hex->bin calls (vtnerd)
5fcc23a Move hex->bin conversion to monero copyright files and with less includes (vtnerd)
3387f0e Reduce template bloat in hex->bin for ZMQ json (vtnerd)
|
|
fcb06f7 cryptonote_core: skip block notify on blockchain switching rollback (xiphon)
|
|
dbfa4f8 unit_tests: fix missing test names (xiphon)
|
|
82da832 rpc: Add check for too old timestamps in payment signatures. (glv2)
|
|
c61abf8 remove empty statements (shopglobal)
|
|
80d5320 Hash domain separation (SarangNoether)
|
|
0078ce7 wipeable_string: split - treat CR, LF and Tabs as separators (xiphon)
|
|
cc18926 wallet2_api: wallet recovery - seed offset passphrase support (xiphon)
|
|
9bde70e core: mention time being off in hash rate changes message (moneromooo-monero)
|
|
29b7cd1 device_ledger: include status code name in error message (xiphon)
|
|
1a6e7bd wallet2: mention --daemon-ssl-allow-any-cert in --proxy error msg (xiphon)
|
|
e69acff functional_tests: update cookie at 10 seconds interval (moneromooo-monero)
f5a11f0 functional_tests: speed up signature generation (moneromooo-monero)
|
|
6d6af70 cryptonote_basic: drop unused verification_context::m_not_rct field (xiphon)
|
|
21fe6a2 p2p: fix frequent weak_ptr exception on connection (moneromooo-monero)
|
|
|
|
|
|
When a handshake fails, it can fail due to timeout or destroyed
connection, in which case the connection will be, or already is,
closed, and we don't want to do it twice.
Additionally, when closing a connection directly from the top
level code, ensure the connection is gone from the m_connects
list so it won't be used again.
AFAICT this is now clean in netstat, /proc/PID/fd and print_cn.
This fixes a noisy (but harmless) exception.
|
|
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero)
09c8111 threadpool: lock mutex in create (moneromooo-monero)
e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
|
|
3627e53 rpc: fix print_pool_sh not finding local txes (moneromooo-monero)
|
|
ad806dc gpg_keys: add selsta key (selsta)
|
|
52d2ccd Translations from Weblate + updated language files (Monero-Weblate)
|
|
5002a03 Explicitly define copy assignment operator (omartijn)
|
|
2e9d1e6 wallet2: fix store-tx-info loading (moneromooo-monero)
|
|
dab604e wallet2_api: implement estimateTransactionFee (xiphon)
|
|
9989cb0 simplewallet: warn about correlations if print-ring-members is not set (moneromooo-monero)
|
|
fe92fa1 [randomx] Add missing randomx_vm_set_cache() (cohcho)
|
|
320bc84 rpc: add --rpc-payment-allow-free-loopback (moneromooo-monero)
|
|
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
|
|
0c29e17 Fix network unit tests after epee changes (vtnerd)
|
|
|
|
The warning about spending more than one output with similar creation
time was skipped if print-ring-members was not set, and it defaults to
false, which means most people probably aren't getting this warning if
they spend correlated outputs.
Reported by SeventhAlpaca.
|
|
9c1f970b wallet2: remember daemon address overrides when loading a new wallet (moneromooo-monero)
|
|
50e59cfa wallet2: reject zero keys in json input (moneromooo-monero)
|
|
bcae95a2 p2p: do not add recently failed addresses to the peerlist (moneromooo-monero)
|
|
019c1dc0 gitian-build.py: Fixing check for docker command. (Jonathan Cross)
|
|
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
|
|
0349347e ringdb: use a different iv for key and data in rings table (moneromooo-monero)
7b882087 simplewallet: reword mixin in user message in terms of ring size (moneromooo-monero)
f507a43a wallet2: do not remove known rings when a tx fails (moneromooo-monero)
|
|
d0641b42 net: fix incorrect less operator for top/i2p addresses (Aaron Hook)
|
|
02224e71 Fix check_fee() discrepancy. (UkoeHB)
|
|
a84131ce p2p: fix off by one adding fallback peers (moneromooo-monero)
|
|
66472074 Daemon: Guard against reporting "synchronized" too early (rbrunner7)
|
|
6772ce70 10 block time is for incoming outputs, not transactions (rating89us)
|
|
b818522d p2p: fix spurious warning when we're connected to at last one seed (moneromooo-monero)
|
|
36bdf402 p2p: fix adding wrong indices to the filtered peer list (moneromooo-monero)
|
|
aa93e388 p2p: remove old debug commands (Aaron Hook)
|
|
f8d76f39 core: move the LockedTXN class out of txpool so it may be reused (moneromooo-monero)
|
|
Executing a new binary for each signature can get really slow
|
|
Otherwise the daemon will start rejecting
|
|
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
|
|
|
|
|
|
c075aa7 workaround for GetObject windows.h macro and rapidjson conflict (xiphon)
|
|
|
|
|
|
a26cbce easylogging++: fix 'ELPP_OS_EMSCRIPTEN is not defined' warning (xiphon)
|
|
|
|
for example, in the RPC server
|
|
This allows RPC coming from the loopback interface to not have
to pay for service. This makes it possible to run an externally
accessible RPC server for payment while also having a local RPC
server that can be run unrestricted and payment free.
|
|
0f78b06e Various improvements to the ZMQ JSON-RPC handling: (Lee Clagett)
|
|
a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
|
|
c11e64fc Gitian: Change lxc ip link (TheCharlatan)
|
|
0eac0c43 depends: set several missing build tags (moneromooo-monero)
|
|
352bd132 abstract_tcp_server2: guard against negative timeouts (moneromooo-monero)
|
|
4771a7ae p2p: remove obsolete local time in handshake (moneromooo-monero)
2fbbc4a2 p2p: avoid sending the same peer list over and over (moneromooo-monero)
3004835b epee: remove backward compatible endian specific address serialization (moneromooo-monero)
39a343d7 p2p: remove backward compatible peer list (moneromooo-monero)
60631802 p2p: simplify last_seen serialization now we have optional stores (moneromooo-monero)
9467b2e4 cryptonote_protocol: omit top 64 bits of difficulty when 0 (moneromooo-monero)
b595583f serialization: do not write optional fields with default value (moneromooo-monero)
5f98b46d p2p: remove obsolete local time from TIMED_SYNC (moneromooo-monero)
|
|
If a db resize happened, the txpool meta cursor might be stale,
and was not being renewed when necessary.
It would cause this SEGSEGV:
in mdb_cursor_set ()
in mdb_cursor_get ()
in cryptonote::BlockchainLMDB::get_txpool_tx_blob(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::tx_memory_pool::get_transaction(crypto::hash const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&, cryptonote::relay_category) const ()
in cryptonote::t_cryptonote_protocol_handler<cryptonote::core>::handle_notify_new_fluffy_block(int, epee::misc_utils::struct_init<cryptonote::NOTIFY_NEW_FLUFFY_BLOCK::request_t>&, cryptonote::cryptonote_connection_context&) ()
|
|
|
|
All the insecure protocols that this enables are then disabled, so they
cannot be actually used. The end-result is the same.
|
|
|
|
|
|
|
|
|
|
|
|
During the handshake for an incoming connection, the peer id is checked against the local node's peer id only for the specific zone of the incoming peer, in order to avoid linking public addresses to tor addresses:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L2343
However, on handshakes for outgoing connections, all zones are checked:
https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L1064
If an attacker wanted to link a specific tor node to a public node, they could potentially connect to as many public nodes as possible, get themselves added to the peer whitelist, maybe stuff some more attacker-owned addresses into the greylist, then disconnect, and for any future incoming connections, respond with the tor node's id in an attempt to link the public/tor addresses.
|
|
|
|
|
|
|
|
- Finding handling function in ZMQ JSON-RPC now uses binary search
- Temporary `std::vector`s in JSON output now use `epee::span` to
prevent allocations.
- Binary -> hex in JSON output no longer allocates temporary buffer
- C++ structs -> JSON skips intermediate DOM creation, and instead
write directly to an output stream.
|
|
|
|
21c3d42e p2p: drop the peerlist dump to TRACE (moneromooo-monero)
|
|
f717d593 wallet2: guard against race with multiple decrypt_keys users (moneromooo-monero)
|
|
a6a2ad6c simplewallet: set manual refresh mode in rescan_bc (moneromooo-monero)
|
|
94853487 easylogging++: add emscripten support (moneromooo-monero)
|
|
f1091c41 core_tests: remove some useless verbose logs (moneromooo-monero)
|
|
88b82bef simplewallet: point to "set help" in the lock screen message (moneromooo-monero)
f19c9f23 util: allow newlines in string to be split (moneromooo-monero)
|
|
69336931 rpc: fill miner_tx_hash again (moneromooo-monero)
|
|
81494e3f depends: empty spaces in PATH variable cause build failure (kozyilmaz)
|
|
716012ca rpc: drop the obsolete and wrong "unpruned size" log (moneromooo-monero)
|
|
ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
|
|
bc6d8aa3 Corrected message typo (palomato)
|
|
5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
|
|
987c3139 print_coinbase_tx_sum now supports 128 bits sums (moneromooo-monero)
|
|
d93e1dff simplewallet: warn on refresh if refresh-from-block-height seems off (moneromooo-monero)
|
|
c3613031 Silence miner debugmsg spam (Howard Chu)
|
|
a9bdc6e4 Improved performance for epee serialization: (Lee Clagett)
|
|
72ca7e3b Fix time comparison math (Jason Rhinelander)
|
|
a2578892 --disable-ban-rpc option to prevent RPC users from banning (naughtyfox)
|
|
94266eeb simplewallet: fix output age display with duplicate heights (moneromooo-monero)
f1d379d2 simplewallet: fix "outputs in same tx" detector (moneromooo-monero)
|
|
5985c5af rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
|
|
021cf733 ssl: server-side: allow multiple version of TLS (Bertrand Jacquin)
|
|
1d78db27 Add travis freebsd (TheCharlatan)
|
|
ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
|
|
02b80513 unit_tests: remove invalid bulletproofs unit test (moneromooo-monero)
|
|
|
|
bcaa865 workflows: fix macOS build (selsta)
|
|
1af7d16 workflows: log test output on failure (xiphon)
|
|
a836f30 workflows: windows j3 -> j2 (selsta)
|
|
a3bddcd workflows: add libwallet compile check (selsta)
|
|
From the FreeBSD architecture handbook (https://www.freebsd.org/doc/en/books/arch-handbook/jail-restrictions.html) as it relates to `allow.sysvipc`, "By default, this sysctl is set to 0. If it were set to 1, it would defeat the whole purpose of having a jail; privileged users from the jail would be able to affect processes outside the jailed environment." This is undesirable behavior.
Per `man jail`, regarding `allow.sysvipc`, "A process within the jail has access to System V primitives. This is deprecated in favor of the per-module parameters."
Since FreeBSD 11, the new way to deal with this (the per-module parameters) is with: `sysvshm`, for shared memory, `sysvsem`, for semaphores, and `sysvmsg`, for message queues. These can be set selectively to either `disable`; `inherit`, for the previous behavior (problematic due to UID collision, apparently); and `new`, for new behavior that avoids the UID collision problem.
Monero only uses semaphores, therefore we should recommend that jails be run with `sysvsem="new"` in the jail's jail.conf. Tested on FreeBSD 12.1.
Also, Monero is now able to be downloaded as a package or built from ports as `monero-cli` with a versioned suffix. It's got `Monero 'Carbon Chamaeleon' (v0.15.0.1-release)` as of right now, and it's been there 2-3 months, meaning it's currently and timely.
|
|
|
|
|
|
5f2a32c daemon: run with -rpc-payment-address and --rpc-restricted-bind-port (moneromooo-monero)
|
|
f812783 simplewallet: fix encrypted payment id note triggering on dummy ones (moneromooo-monero)
|
|
316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
|
|
096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
|
|
0bae227 update readme to encourage joining #monero-dev (Gingeropolous)
|
|
f498dfc README: add Void Linux package dependencies (kevcrumb)
|
|
|
|
|
|
|
|
Cleaning up a little around the code base.
|
|
|
|
|
|
Coverity 196626
|
|
In some contrived case, it might theoretically be the case that
destroy is called from another thread, which would modify the
threads array from two threads.
Coverity 208372
|
|
Coverity 208373
|
|
|
|
|
|
|
|
|
|
|
|
c2095fc2 miner: use verification mode for low diff one block nonce searches (moneromooo-monero)
|
|
|
|
|
|
This avoids lengthy init times when testing
|
|
2d1afceb net_ssl: load default certificates in CA mode on Windows (moneromooo-monero)
|
|
3813a992 download: catch exceptions checking for size (moneromooo-monero)
|
|
e896cca8 epee: reorder a couple init list fields to match declaration (moneromooo-monero)
|
|
7ac7d5d3 updates: fix source code URL on _WIN32 (selsta)
|
|
67b4a19e simplewallet: noob-friendly help menu (wowario)
|
|
4b384003 wallet2: don't try to lock an empty filename (moneromooo-monero)
|
|
b328de6b wallet_rpc_server: add tx weight in transfer commands responses (moneromooo-monero)
|
|
4d804443 Fixes a minor formatting error (TheGoose)
|
|
a633f85d daemon: allow printing N blocks from the end of the chain (moneromooo-monero)
|
|
7ba31191 daemon: add +meta print_tx parameter (moneromooo-monero)
|
|
236d2a88 blockchain_stats: make it work on pruned blockchains (moneromooo-monero)
|
|
b9fc2066 Add a --keep-fakechain option to keep fakechain databases (JamesWrigley)
|
|
22d30866 simplewallet: add missing inactivity-lock-timeout to set help blurb (moneromooo-monero)
9f57f0df simplewallet: do not mention inactivity if a lock was manual (moneromooo-monero)
|
|
d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)
|
|
deb350b7 always print peer IDs in the same format (moneromooo-monero)
|
|
65301c40 core: point out when we hit the block rate visibility limit (moneromooo-monero)
|
|
2f8f3a94 rpc: base flush_cache request/response on the new base structs (moneromooo-monero)
|
|
b90c4bc3 rpc: error out from get_info if the proxied call errors out (moneromooo-monero)
fa16df99 make_test_signature: exit nicely on top level exception (moneromooo-monero)
054b2621 node_rpc_proxy: init some new rpc payment fields in invalidate (moneromooo-monero)
d0faae2a rpc: init a few missing client_info members (moneromooo-monero)
d56a483a rpc: do not propagate exceptions out of a dtor (moneromooo-monero)
3c849188 rpc: always set the update field in update on sucess (moneromooo-monero)
|
|
8a27645 blockchain: fix flushing txes from the txpool (moneromooo-monero)
|
|
|
|
|
|
Also removes a potential fingerprinting vector
|
|
Nodes remember which connections have been sent which peer addresses
and won't send it again. This causes more addresses to be sent as
the connection lifetime grows, since there is no duplication anymore,
which increases the diffusion speed of peer addresses. The whole
white list is now considered for sending, not just the most recent
seen peers. This further hardens against topology discovery, though
it will more readily send peers that have been last seen earlier
than it otherwise would. While this does save a fair amount of net
bandwidth, it makes heavy use of std::set lookups, which does bring
network_address::less up the profile, though not too aggressively.
|
|
Found 1148 source text(s) (46 new and 1102 already existing)
Removed 9 obsolete entries
Spanish
Currently translated at 9.0% (100 of 1111 strings)
Translate-URL: https://translate.getmonero.org/projects/monero/cli-wallet/es/
Italian
Currently translated at 71.9% (799 of 1111 strings)
Translate-URL: https://translate.getmonero.org/projects/monero/cli-wallet/it/
Dutch
Currently translated at 4.5% (50 of 1111 strings)
Translate-URL: https://translate.getmonero.org/projects/monero/cli-wallet/nl/
Dutch
Currently translated at 4.5% (50 of 1111 strings)
Translate-URL: https://translate.getmonero.org/projects/monero/cli-wallet/nl/
Portuguese (Brazil)
Currently translated at 0.3% (3 of 1111 strings)
Translate-URL: https://translate.getmonero.org/projects/monero/cli-wallet/pt_BR/
|
|
The implicit copy assignment operator was deprecated because the class
has an explicit copy constructor. According to the standard:
The generation of the implicitly-defined copy assignment operator is
deprecated (since C++11) if T has a user-declared destructor or
user-declared copy constructor.
Recent versions of gcc (9.1+) and clang (10.0) warn about this.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
08635a08 blockchain: speedup fetching pruned contiguous tx blobs (moneromooo-monero)
|
|
56a4469e network: log traffic and add a simple traffic analysis script (moneromooo-monero)
|
|
dd8c6b17 wallet: do not split integrated addresses in address book api (moneromooo-monero)
|
|
|
|
|
|
|
|
2e58eb5c lmdb: Remove meaningless const qualifier on function type (Nathan Dorfman)
|
|
6f330865 fix tests bug added in #6110 (Dusan Klinec)
|
|
2aa80b1d build: autodetect MSYS2 install path, support non-standard location (xiphon)
|
|
957ae887 workflows: add build and test workflow (selsta)
|
|
dbcfae6f README: remove unmaintained build status (selsta)
|
|
cce4ea02 README: fix translation link (moneromooo-monero)
|
|
8231c7cd rpc: fix bootstrap RPC payment RPC being made in raw JSON, not JSON RPC (moneromooo-monero)
81c26589 rpc: don't auto fail RPC needing payment in bootstrap mode (moneromooo-monero)
|
|
d7cf8727 rpc: add received_timestamp for pool txes in gettransactions (moneromooo-monero)
|
|
dc589ef0 Add TheCharlatan pgp key (TheCharlatan)
|
|
bd6a5778 Gitian: Fix sigs generation (TheCharlatan)
|
|
f3e155ea add xiphon's GPG key (xiphon)
|
|
402dd207 db_lmdb: guard against non NUL terminated keys (moneromooo-monero)
|
|
3b419333 wallet: don't issue node rpc proxy requests in '--offline' mode (xiphon)
|
|
24adee4a p2p: don't request flags after closing connection (moneromooo-monero)
|
|
70c9cd3c Change to Tx diffusion (Dandelion++ fluff) instead of flooding (Lee Clagett)
|
|
9fe8a76c perf_timer: fix pause/resume macros dereferencing too much (moneromooo-monero)
|