Age | Commit message (Collapse) | Author | Files | Lines |
|
e499ff33 simplewallet: factor out message_writer (moneromooo-monero)
7ed5ab47 scoped_message_writer: pause readline to match simplewallet (moneromooo-monero)
|
|
359517c7 wallet_rpc_server: fix possible privacy leak in on_import_key_images() (Jaquee)
20495b27 simplewallet: fix possible privacy leak in import_key_images() (Jaquee)
|
|
a1891ebe tests: fix tests build (moneromooo-monero)
|
|
6ce769c1 p2p: get net log spam down a bit (moneromooo-monero)
|
|
88e83f94 cryptonote_protocol_handler: log versions as unsigned ints (moneromooo-monero)
|
|
cb2d5110 Tweak net logs so we get more info on why networking can't start (moneromooo-monero)
|
|
7591c528 p2p: fallback on seed nodes if we can't make a connection (moneromooo-monero)
|
|
0e8d60c0 cryptonote_protocol: fix recv/send idle time before handshake (moneromooo-monero)
|
|
f90bbe2a cryptonote_protocol: keep target in sync with dropped connections (moneromooo-monero)
|
|
1307e3cc WalletAPI: add getDefaultDataDir() (Jaquee)
|
|
7007bd14 Change default block sync size from 200 to 20 (moneromooo-monero)
|
|
980e476c cryptonote_basic: fix silly CLANG warning about not emitting function (moneromooo-monero)
|
|
74597bd1 wallet2: improve refresh height determination (moneromooo-monero)
|
|
042b86c4 simplewallet: do not ask wallet filename twice when restoring (moneromooo-monero)
|
|
This should prevent "silent" failures to start
|
|
8bbed275 simplewallet: Be explicit about secret keys (Erik de Castro Lopo)
|
|
51ebedb8 epee: remove a couple unused locals (moneromooo-monero)
|
|
9707998a wallet2: clear some missing containers in clear() (moneromooo-monero)
|
|
f4f7eeba blockchain: log more info when we reject an orphan (moneromooo-monero)
|
|
71e28760 debug_utilities: only build for debug builds (moneromooo-monero)
55e150ff debug_utilities: new object-sizes debug tool (moneromooo-monero)
fbaf5375 cn_deserialize: move to new debug_utilities subdirectory (moneromooo-monero)
|
|
d732c73e blockchain: remove a few unused variables (moneromooo-monero)
|
|
c8640a3d difficulty: fix misleading comment (Guillaume LE VAILLANT)
|
|
b7d6ec83 simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero)
fa23a500 wallet2: add a is_synced function (moneromooo-monero)
f1307bbd node_rpc_proxy: add a proxy for target height (moneromooo-monero)
|
|
ad4649ac Enable verifying wallet password with having to load wallet. (m2049r)
|
|
5d4ef719 core: speed up output index unique set calculation (moneromooo-monero)
19d7f568 perf_timer: allow profiling more granular than millisecond (moneromooo-monero)
bda8c598 epee: add nanosecond timer and pause/restart profiling macros (moneromooo-monero)
|
|
67ce4910 wallet2: store testnet bool in keys file (Jaquee)
|
|
87b5ede9 miner: fix ignoring battery from command line (moneromooo-monero)
|
|
c97d1bd3 wallet: return unlock_time in get_transfers (moneromooo-monero)
|
|
35e01a6e cryptonote_protocol: fix "holes" in block download schedule (moneromooo-monero)
3da1edfd cryptonote_protocol: fix out of order addition (moneromooo-monero)
6edb1b3e block_queue: do not add empty spans (moneromooo-monero)
|
|
|
|
This was broken by the reorg fix, since we now have to add blocks
regardless of their starting height. We now check whether we know
the parent for the first block in the next span, or whether it was
requested. If neither, it's an orphan. If it is not known, but was
requested, we wait to get that block.
|
|
|
|
2ec15a69 daemon: print peers' top height in sync_info (moneromooo-monero)
08abb670 protocol: fix reorgs while syncing (moneromooo-monero)
|
|
|
|
They're interpreted as characters otherwise
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Add get_fork_version and add_ideal_fork_version to core so
cryptonote_protocol does not have to need the Blockchain
class directly, as it's not in its dependencies, and add
those to the fake core classes in tests too.
|
|
This avoids failing to connect to the network in case all
known peers are unavailable (which can happen if the peer
list is small).
|
|
|
|
When a node is dropped, we stop considering its claimed blockchain
height as a factor in the target height calculation. This prevents
a runaway chain from being still thought to be the target even if
the nodes carrying it are dropped.
|
|
3ff5ce63 connection_context: initialize state (moneromooo-monero)
|
|
Why this was initialized properly before I have no idea, but
it is not anymore. Fix it, which fixes syncing in release mode.
|
|
635929ea protocol: add checks for top block hard fork version (moneromooo-monero)
7482253a epee: fixup KV_SERIALIZE_OPT to work in more cases (moneromooo-monero)
|
|
|
|
We won't even talk to a peer which claims a wrong version
for its top block. This will avoid syncing to known bad
peers in the first place.
Also add IP fails when failing to verify a block.
|
|
|
|
e49f6d43 net_node: fix m_in_timedsync initialization (moneromooo-monero)
|
|
This fixes nodes not being able to connect to nodes which use
recent code. While there, init peer_id too.
|
|
With the new sync algorithm, the network overhead will be masked
as the thread adding blocks isn't interrupted by network calls
anymore. This should reduce memory usage a lot during sync.
|
|
|
|
a839a6fa Wallet API: add tx unlock time (Jaquee)
|
|
49ffb156 cmake: do not use GREATER_EQUAL, it's too new (moneromooo-monero)
|
|
61770ec2 change mixin to ring size in user visible places (moneromooo-monero)
|
|
|
|
|
|
7f7d42f8 core: fix invalid memory access creating tx (moneromooo-monero)
|
|
5d91b26c blockchain: skip checking tx semantics in embedded block hash range (moneromooo-monero)
|
|
04bd1925 cmake: Update detection of external miniupnpc (Erik de Castro Lopo)
|
|
|
|
c93b7692 blockchain_import: much faster when verifying with cryptonote::core (moneromooo-monero)
38756d00 core: new API to disable DNS checkpoint lookups (moneromooo-monero)
|
|
e31aac80 walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b wallet api: pause refresh while commiting tx (Jaquee)
f233c01c CMakeLists.txt - ios/xcode fix (Jaquee)
|
|
569b9b2b updates: add "misc_log_ex.h" for logs (moneromooo-monero)
74628941 dns_utils: add <functional> for std::function (moneromooo-monero)
|
|
|
|
|
|
Quick test with the first 56569 blocks from mainnet
version verify batch time
old 0 200 1:16
new 0 200 0:57
old 0 5000 0:53
new 0 5000 0:51
old 1 200 est > 1h
new 1 200 10:21
old 1 5000 est > 1h
new 1 5000 8:27
|
|
|
|
02f13d6c Fix handling of strings & simplify summation of spendkeys (JollyMort)
40fc9d7b Add option to join multisig wallet pieces together (JollyMort)
|
|
380009e5 README: give credit where credit is due (moneromooo-monero)
|
|
335fc8ab mlog: fix crash accessing stale data when rotating logs (moneromooo-monero)
|
|
158c3ecf core: thread most of handle_incoming_tx (moneromooo-monero)
f57ee382 cryptonote_protocol: retry stale spans early (moneromooo-monero)
90df52e1 cryptonote_protocol: light cleanup (moneromooo-monero)
84e23156 cryptonote_protocol: avoid spurious SYNCHRONIZED OK messages (moneromooo-monero)
5be43fcd cryptonote_protocol_handler: sync speedup (moneromooo-monero)
|
|
044c5b55 Readme: add android docker build instruction (MoroccanMalinois)
82836be4 Utils: Add dockerfile for android NDK build (MoroccanMalinois)
|
|
98cb3fee italian translation (erciccione)
ff07cdc9 updates monero_fr.ts (erciccione)
f675fedc updates monero.ts (erciccione)
|
|
328bebbe daemon: some more include cleanup (moneromooo-monero)
|
|
4d873046 blockchain: add testnet v6 fork height at 971400 (moneromooo-monero)
|
|
1c9196b0 cryptonote_protocol: fix days behind calc on testnet (moneromooo-monero)
|
|
600353e2 fix wallet callback signatures (m2049r)
|
|
214fd81e some include cleanup (moneromooo-monero)
|
|
5dd722be core: add a message when loading checkpoints at init time (moneromooo-monero)
|
|
14ec6ed8 tx_pool: remove obsolete unused m_config_folder field (moneromooo-monero)
|
|
d37e8f88 daemon: add average seconds per block in bc_dyn_stats (moneromooo-monero)
|
|
878205f1 core: fix lock ordering bug at init time (moneromooo-monero)
|
|
c6ba7d11 p2p: move m_in_timedsync from connection_context to p2p_connection_context (moneromooo-monero)
|
|
04ebfbfe p2p: close connections when exiting (moneromooo-monero)
9a10148c p2p: fix thread leak (moneromooo-monero)
|
|
d8becf2e blockchain: fix cryptonight buffer leak on exit (moneromooo-monero)
91aa90fc blockchain: ensure all blocks get their longhash precalculated (moneromooo-monero)
ff4bcaed blockchain: pass correct height to get_block_longhash (moneromooo-monero)
|
|
06aea2cf move get_proof_of_trust_hash from util.h to p2p_protocol_defs.h (moneromooo-monero)
|
|
41f935dd network_throttle: remove unneeded heap allocations (moneromooo-monero)
|
|
525975ac wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
|
|
cb0b5594 Move OpenAlias console input back from libs (moneromooo-monero)
|
|
340feede core: randomly shuffle outputs (moneromooo-monero)
|
|
0c57df97 wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
|
|
dc0b312f wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983 epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
|
|
f1b76c84 cryptonote_protocol: Set send_idle_time in connection_info correctly (rbrunner7)
|
|
53af9768 blockchain: one off warning when seeing a block with unknown version (moneromooo-monero)
|
|
d75cff1a Fix readline prompt when command does not output (Jethro Grassie)
|
|
16a55347 simplewallet: show payment ids on sign_transfer (moneromooo-monero)
|
|
599436a4 mlog: default to msgwriter logs only for log level 1 (moneromooo-monero)
58f3fc68 Make msgwriter logs go to file only (moneromooo-monero)
|
|
23909bb0 Make successful transfer log message more informative (JollyMort)
|
|
a5031a7d core: forbid duplicate ring members from v6 (moneromooo-monero)
|
|
2fac03e6 Update monerod systemd service file (Erik de Castro Lopo)
51efb217 daemon: Add ability to write a PID file (Erik de Castro Lopo)
|
|
13a8d64f epee: don't send the body of the response to a HEAD HTTP request (Guillaume LE VAILLANT)
|
|
35d68b2c Fix spelling errors (Erik de Castro Lopo)
|
|
125f823b Add on_get_alt_blocks_hashes RPC call (moneroexamples)
|
|
94717021 fix on_battery_power for linux (Ryan Mehta)
|
|
94dd5cb4 Makefile: Add debug-static-all target (Erik de Castro Lopo)
|
|
464afd4d Ensure DNSResolver destructor runs on exit (Howard Chu)
|
|
|
|
|
|
Connections can be dropped by the net_node layer,
unbeknownst to cryptonote_protocol, which would then
not flush any spans scheduled to that connection,
which would cause it to be only downloaded again
once it becomes the next span (possibly after a small
delay if it had been requested less than 5 seconds
ago).
|
|
|
|
|
|
A block queue is now placed between block download and
block processing. Blocks are now requested only from one
peer (unless starved).
Includes a new sync_info coommand.
|
|
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
|
|
It's annoying and pointless (especially as it's the only thing
where the user is asked twice)
|
|
Previously, the wallet just asked for "Spend key" and "View key" but
now it specifies that these should be the secret versions of these
keys.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
|
|
We want to know what happened when a block is wrongly rejected
|
|
Integrated addresses are shown when an encrypted payment id is used
|
|
|
|
It prints the size of various interesting types, to make it
easier to match leaks to possible leaked object types
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Should help people who don't realize why they haven't seen their
monero yet.
|
|
|
|
|
|
also show it in simplewallet's show_transfer
|
|
|
|
This will keep leak traces less noisy, as those were one off
allocations that were technically leaking.
|
|
It's got no place in the base class as it's P2P specific field
|
|
A sort+uniq step was done for every tx in a 200 block chunk,
causing a lot of repeated scanning as the size of the offset
map got larger with every added tx. We now do the step only
once at the end of the loop.
Doing it this way potentially uses more memory, but testing
shows that it's currently only about 2% more.
|
|
|
|
Nanosecond timer precision won't work on Windows, but we don't
care since I'm using that just for profiling incremental code
paths, but a Windows coder is welcome to add it if there's a way.
|
|
|
|
|
|
This uses DNS, which can take a while, so it's useful to know
this is the culprit when loading pauses
|
|
|
|
If the txes are bad, this'll be picked up by the block hash mismatch
since the tx merkle root is part of the block hash.
|
|
The version of miniupnpc in external/ uses API version 16, but the
code also seems to work for API version 10. Also remove detection
of older unsupported versions.
|
|
Also make debug-all target statically link all internal libraries.
|
|
|
|
|
|
|
|
This ensures they don't leak if they were in the middle of an
async operation.
|
|
Asks user for all the data required to merge secret keys from multisig wallets into one master wallet, which then gets full control of the multisig wallet. The resulting wallet will be the same as any other regular wallet.
|
|
|
|
|
|
If the number of blocks to check was not a multiple of the
number of preparation threads, the last few blocks would
not be included in the threaded long hash calculation.
Those would still get calculated when the block gets added
to the chain, however, so this was only a tiny performance
hit, rather than a security bug.
|
|
|
|
This avoids having to include p2p_protocol_defs.h in util.h,
as util.h is used a lot, and p2p_protocol_defs.h includes
a lot of other things that most users don't need.
|
|
|
|
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
|
|
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
|
|
They used to be sorted by amount, which was fine before rct,
but is now suboptimal, since amounts are not known anymore.
In particular, it would give a recipient knowledge of whether
change was higher or lower than the amount received.
|
|
|
|
|
|
|
|
|
|
There might be privacy issues doing it by default
|
|
This was the case for monero-wallet-cli already, but not for
monerod, which was making it pretty spammy as it was duplicating
intended output. Since my original intent was to ensure logs
included command output for debugging, this achieves both.
|
|
|
|
"Payment successfully sent" can be misleading if the TX isn't confirmed and drops from TX-pool.
|
|
|
|
This avoids someone adding what amounts to mixin 0 rings in
practice, as there is no other good reason to allow this.
|
|
Make monerod use a PID file and let systemd know where that file is.
|
|
The PID file will only be written if the daemon is called with the
`--detach` command line argument and a `--pidfile /some/file/path`
argument.
|
|
|
|
|
|
|
|
6955976b Add various readline related fixes (Jethro Grassie)
|
|
6a23cd07 Add notification on stop (Jethro Grassie)
|
|
a02d7458 mlog: make MONERO_LOGS env var understand N,logs type spec (moneromooo-monero)
|
|
c3bb6bec daemon: fix status in command line mode if using restricted rpc (moneromooo-monero)
|
|
f5f985c0 miner: fix background mining options parsing (moneromooo-monero)
|
|
33d17c37 Don't hardcode /tmp (Howard Chu)
|
|
8db68a57 Fix #2164 histogram output (Howard Chu)
|
|
97069380 mlog: add msgwriter:INFO to log 0 and 1 defaults (moneromooo-monero)
|
|
02d66db4 tx_pool: initialize padding in txpool meta structure (moneromooo-monero)
0722aea3 cryptonote_core: initialize checkpoint flag (moneromooo-monero)
|
|
d765cd91 epee: Remove unused variable (Erik de Castro Lopo)
|
|
5cea3552 simplewallet: lock idle scope when sweeping (moneromooo-monero)
|
|
a04faf56 abstract_tcp_server2: guard against accessing lock on a destroyed object (moneromooo-monero)
|
|
|
|
|
|
|
|
|
|
They were set as uint8_t, which boost was apparently treating
as a character type, rather than a numeric type
|