aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-04-17Merge pull request #5415Riccardo Spagni3-77/+28
299052bc Remove unneeded SFINAE on check_tx/block verification in core_tests (Doyle)
2019-04-17Merge pull request #5413Riccardo Spagni4-138/+106
5fafb90e testdb: add override keyword where missing (stoffu)
2019-04-17Merge pull request #5455Riccardo Spagni1-1/+12
e3dea478 unit_tests: undo is_blocked implementation factoring (moneromooo-monero)
2019-04-17Merge pull request #5454Riccardo Spagni1-5/+1
b0a34668 daemon: fix absolute/relative log file test for windows (moneromooo-monero)
2019-04-17testdb: add override keyword where missingstoffu4-138/+106
and delete obsolete BlockchainBDB::get_tx_output_indices along the way
2019-04-17Remove unneeded SFINAE on check_tx/block verification in core_testsDoyle3-77/+28
2019-04-16unit_tests: undo is_blocked implementation factoringmoneromooo-monero1-1/+12
The is_host_blocked method is not on master yet
2019-04-16daemon: fix absolute/relative log file test for windowsmoneromooo-monero1-5/+1
2019-04-16Merge pull request #5430Riccardo Spagni5-1/+104
294e858d wallet_rpc_server: add set_log_level/set_log_categories (moneromooo-monero)
2019-04-16wallet_rpc_server: add set_log_level/set_log_categoriesmoneromooo-monero5-1/+104
2019-04-16Merge pull request #5452Riccardo Spagni2-1/+4
c30d93fc rpc: add a pruned bool to the prune_blockchain call (moneromooo-monero)
2019-04-16Merge pull request #5450Riccardo Spagni1-0/+8
926e0472 simplewallet: add another warning about long payment ids (moneromooo-monero)
2019-04-16Merge pull request #5447Riccardo Spagni2-2/+36
02c01c0b Add Brewfile to allow for an even easier management of dependencies (Florian)
2019-04-16Merge pull request #5448Riccardo Spagni4-14/+18
d009f6dd rpc: fix get_block_hashes.bin from wallet on pruned blockchain (moneromooo-monero) bb0ef5b1 blockchain: lock the blockchain while pruning (moneromooo-monero)
2019-04-16Merge pull request #5445Riccardo Spagni5-60/+127
b18f0b10 wallet: new --offline option (moneromooo-monero)
2019-04-16Merge pull request #5446Riccardo Spagni7-14/+96
7d79222f daemon: remove debug info (moneromooo-monero) 8fec0f98 functional_tests: add sweep_single test (moneromooo-monero) 9880d61b wallet_rpc_server: remove unused code (moneromooo-monero) 8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero) 56508524 rpc: add relayed in get_transaction output (moneromooo-monero) 82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)
2019-04-16Merge pull request #5444Riccardo Spagni1-0/+1
6643b047 Increment m_threads_active when mining thread starts (Doyle)
2019-04-16Merge pull request #5443Riccardo Spagni1-20/+2
07dd5536 hardfork: remove "no hf version db" recreation check (moneromooo-monero)
2019-04-16Merge pull request #5442Riccardo Spagni2-5/+22
428249c5 easylogging++: minimal stdout logging format (moneromooo-monero)
2019-04-16Merge pull request #5441Riccardo Spagni2-4/+2
b3648232 daemon: fix ratio not being floating point (moneromooo-monero) e1b097b9 core_rpc_server: remove dummy assigning int to bool (moneromooo-monero)
2019-04-16Merge pull request #5439Riccardo Spagni1-0/+2
f26e0b5d cryptonote_protocol: warn when the last connection goes (moneromooo-monero)
2019-04-16Merge pull request #5437Riccardo Spagni1-29/+33
acb68dba bulletproofs: cut down on keyV allocations (moneromooo-monero)
2019-04-16Merge pull request #5436Riccardo Spagni1-3/+4
61d63900 net_helper: avoid unnecessary memcpy (moneromooo-monero)
2019-04-16Merge pull request #5435Riccardo Spagni1-1/+6
5140c15e daemon: if a log file has a /, interpret it from the cwd (moneromooo-monero)
2019-04-16Merge pull request #5434Riccardo Spagni7-1/+154
ccb996af rpc: new sanity check on relayed transactions (moneromooo-monero)
2019-04-16Merge pull request #5432Riccardo Spagni2-2/+9
c3cf930f abstract_tcp_server2: fix timeout on exit (moneromooo-monero)
2019-04-16Merge pull request #5431Riccardo Spagni1-1/+1
34f8c237 simplewallet: fix warning about long payment id using the old option (moneromooo-monero)
2019-04-16Merge pull request #5429Riccardo Spagni3-45/+77
bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
2019-04-16Merge pull request #5428Riccardo Spagni1-1/+4
f3425f8d rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0 (stoffu)
2019-04-16Merge pull request #5425Riccardo Spagni2-13/+25
58585986 p2p: fix integer overflow in host bans (moneromooo-monero)
2019-04-16Merge pull request #5424Riccardo Spagni4-142/+60
93bb2f48 ringct: prevent use of full ringct signatures for more than one input (moneromooo-monero)
2019-04-16Merge pull request #5422Riccardo Spagni1-1/+1
2c221d1b wallet2: update estimate_rct_tx_size for smaller rct proofs (moneromooo-monero)
2019-04-16Merge pull request #5418Riccardo Spagni4-9/+13
374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
2019-04-16Merge pull request #5414Riccardo Spagni3-12/+11
e9fac29a unit_tests/long_term_block_weight: some tweaks that seem to make more sense (stoffu) 467f4c7e tests/block_weight: use integer division when computing median (stoffu) 815d08dc tests/block_weight: remove unused MULTIPLIER_SMALL (stoffu) 661f1fb8 blockchain: remove unused calc of short_term_constraint (stoffu)
2019-04-16Merge pull request #5412Riccardo Spagni1-2/+2
f4f1471c readme: add some more instructions for translators (erciccione)
2019-04-16Merge pull request #5410Riccardo Spagni1-1/+10
d4a78c74 build: libusb static compilation fix (Dusan Klinec)
2019-04-16Merge pull request #5409Riccardo Spagni5-6/+6
ac874e2d tests: fix test_options initialization error (Dusan Klinec)
2019-04-16Merge pull request #5407Riccardo Spagni2-15/+21
66d73d2f easylogging++: update to v9.96.7 (moneromooo-monero)
2019-04-16Merge pull request #5406Riccardo Spagni1-1/+5
bea1918a blockchain_import: error out if preparing to handle blocks fails (moneromooo-monero)
2019-04-16Merge pull request #5405Riccardo Spagni1-1/+4
ffdbcfb6 core: don't check block rate nor fork time in regtest mode (moneromooo-monero)
2019-04-16Merge pull request #5404Riccardo Spagni0-0/+0
d34599da wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero)
2019-04-16Merge pull request #5400Riccardo Spagni9-95/+144
5e673c03 blockchain_db: fix db txn ending too early (moneromooo-monero)
2019-04-16rpc: add a pruned bool to the prune_blockchain callmoneromooo-monero2-1/+4
2019-04-16simplewallet: add another warning about long payment idsmoneromooo-monero1-0/+8
2019-04-15daemon: remove debug infomoneromooo-monero1-1/+1
2019-04-15rpc: fix get_block_hashes.bin from wallet on pruned blockchainmoneromooo-monero4-14/+14
We want to get all blocks here, even pruned ones
2019-04-15blockchain: lock the blockchain while pruningmoneromooo-monero1-0/+4
2019-04-15Add Brewfile to allow for an even easier management of dependenciesFlorian2-2/+36
2019-04-15wallet: new --offline optionmoneromooo-monero5-60/+127
It will avoid connecting to a daemon (so useful for cold signing using a RPC wallet), and not perform DNS queries.
2019-04-15functional_tests: add sweep_single testmoneromooo-monero2-0/+71
2019-04-15wallet_rpc_server: remove unused codemoneromooo-monero1-5/+1
2019-04-15rpc: omit irrelevant fields for pool txes in gettransactionsmoneromooo-monero1-4/+10
2019-04-15rpc: add relayed in get_transaction outputmoneromooo-monero2-5/+11
2019-04-15rpc: set default log category in core_rpc_server.hmoneromooo-monero1-0/+3
2019-04-15Merge pull request #5440Riccardo Spagni1-0/+2
b6420e12 lmdb: catch non-LMDB negative errors before strerror (moneromooo-monero)
2019-04-15Merge pull request #5421Riccardo Spagni1-0/+1
e78cea74 rpc: fix off by one in get_height (moneromooo-monero)
2019-04-15Merge pull request #5417Riccardo Spagni2-1/+93
8df82707 Fix linker issues using easylogging (Martijn Otto)
2019-04-15Merge pull request #5408Riccardo Spagni1-0/+1
c4f8a8a6 build fix: combinator.h stdexcept missing include (Dusan Klinec)
2019-04-15Merge pull request #5402Riccardo Spagni4-8/+26
cbf32241 rpc: make wide_difficulty hexadecimal (moneromooo-monero)
2019-04-15Merge pull request #5398Riccardo Spagni6-45/+128
41901b8d device/trezor: env-configurable ports (Dusan Klinec) c97a1f79 tests: trezor tests fixes and improvements (Dusan Klinec)
2019-04-15Merge pull request #5396Riccardo Spagni2-3/+10
b40392fb wallet2: add --no-dns flag (moneromooo-monero)
2019-04-15Merge pull request #5395Riccardo Spagni1-7/+9
15f27c80 wallet2: support multi out txes without change in sanity check (moneromooo-monero)
2019-04-15Merge pull request #5393Riccardo Spagni4-0/+15
c5d3ea2f tests: add a few try/catch in main to shut coverity up (moneromooo-monero)
2019-04-15Merge pull request #5392Riccardo Spagni5-12/+36
a2195b9b crypto: replace rand<T>()%N idiom with unbiased rand_idx(N) (stoffu)
2019-04-15Merge pull request #5369Riccardo Spagni2-2/+2
e72c2c5d do not build in parallel as it is non-deterministic (Jane Mercer)
2019-04-15Merge pull request #5365Riccardo Spagni1-2/+1
383c38fd fix init warning on whatever compiler version (italocoin)
2019-04-15Merge pull request #5355Riccardo Spagni9-11/+79
c68fe787 device/trezor: add button pressed request (Dusan Klinec) 827f52ad wallet: API changes to enable passphrase entry (Dusan Klinec)
2019-04-15Increment m_threads_active when mining thread startsDoyle1-0/+1
2019-04-14hardfork: remove "no hf version db" recreation checkmoneromooo-monero1-20/+2
This is now obsolete, and this removes the warning on startup on a new db that confuses some people
2019-04-14cryptonote_protocol: warn when the last connection goesmoneromooo-monero1-0/+2
2019-04-14easylogging++: minimal stdout logging formatmoneromooo-monero2-5/+22
It's a bit of a hack, but doing it right would need a lot of changes to the easylogging++ source.
2019-04-14daemon: fix ratio not being floating pointmoneromooo-monero1-1/+1
Coverity 197648
2019-04-14core_rpc_server: remove dummy assigning int to boolmoneromooo-monero1-3/+1
Coverity 197653
2019-04-14lmdb: catch non-LMDB negative errors before strerrormoneromooo-monero1-0/+2
That should hopefully shut coverity up
2019-04-14blockchain_db: fix db txn ending too earlymoneromooo-monero9-95/+144
The db txn in add_block ending caused the entire overarching batch txn to stop. Also add a new guard class so a db txn can be stopped in the face of exceptions. Also use a read only db txn in init when the db itself is read only, and do not save the max tx size in that case.
2019-04-13bulletproofs: cut down on keyV allocationsmoneromooo-monero1-29/+33
2019-04-13net_helper: avoid unnecessary memcpymoneromooo-monero1-3/+4
2019-04-13daemon: if a log file has a /, interpret it from the cwdmoneromooo-monero1-1/+6
rather than from data dir where it normally is. It makes things like --log-file ./foo.log behave as you'd expect.
2019-04-12Merge pull request #5423luigi11111-1/+2
8f1fe45 simplewallet: fix merge error with new welcome command (moneromooo-monero)
2019-04-12rpc: new sanity check on relayed transactionsmoneromooo-monero7-1/+154
This will weed out some transactions with silly rings
2019-04-12abstract_tcp_server2: fix timeout on exitmoneromooo-monero2-2/+9
When closing connections due to exiting, the IO service is already gone, so the data exchange needed for a gracious SSL shutdown cannot happen. We just close the socket in that case.
2019-04-12simplewallet: fix warning about long payment id using the old optionmoneromooo-monero1-1/+1
2019-04-12wallet_rpc_server: fix inconsistent wallet caches on reloadmoneromooo-monero3-46/+78
Loading the same wallet as the currently loaded one would autosave the current state after loading it, leading to some kind of rollback effect. We now save before loading to avoid this. If loading fails, it means the current wallet will be saved (or maybe not, depending on where the failure occurs: most of the sanity checks occur before saving). There is a new autosave_current flag to open/restore calls so the (enabled by default) autosave can be skipped.
2019-04-12rpc.getblocktemplate: set reserved_offset to zero when reserve_size==0stoffu1-1/+4
2019-04-11p2p: fix integer overflow in host bansmoneromooo-monero2-13/+25
2019-04-11ringct: prevent use of full ringct signatures for more than one inputmoneromooo-monero4-142/+60
2019-04-11simplewallet: fix merge error with new welcome commandmoneromooo-monero1-1/+2
2019-04-11wallet2: update estimate_rct_tx_size for smaller rct proofsmoneromooo-monero1-1/+1
2019-04-11rpc: fix off by one in get_heightmoneromooo-monero1-0/+1
2019-04-11Merge pull request #5386Riccardo Spagni2-0/+34
d843f200 simplewallet: add a welcome/disclaimer message command (moneromooo-monero)
2019-04-11Merge pull request #5384Riccardo Spagni2-0/+3
0eee6cd7 block_weight: catch exceptions in main for clean exit on error (moneromooo-monero) 4b3bb829 epee: init a new ssl related variable in ctor (moneromooo-monero)
2019-04-11Merge pull request #5383Riccardo Spagni21-122/+966
0575794f console: simple shell over console.py (moneromooo-monero) 047af5c3 console.py: can now connect to several daemons/wallets (moneromooo-monero) 9f9571aa cmake: always detect python, it's neeed for some tests (moneromooo-monero) 8646bd00 functional_tests: exit with 1 if any test fails (moneromooo-monero) 6fd8834d console.py: add tab completion (moneromooo-monero) 04a20cb2 functional_tests: cold signing key images/outputs import/export (moneromooo-monero) 798e3cad functional_tests: add double spend detection tests (moneromooo-monero) 7c657bb2 functional_tests: add alt chains tests (moneromooo-monero) f8be31d2 functional_tests: add wallet creation language tests (moneromooo-monero) 2d68b31f functional_tests: add more wallet tests (moneromooo-monero) 23f86dad python-rpc: add set_log_level and set_log_categories (moneromooo-monero) b3a32d55 functional_tests: add describe_transfer tests (moneromooo-monero) 108f4375 console.py: support connecting to any host, not just 127.0.0.1 (moneromooo-monero) 064ab123 functional_tests: add more blockchain related tests (moneromooo-monero) 21b1ac1d functional_tests: add bans tests (moneromooo-monero)
2019-04-11simplewallet: add a welcome/disclaimer message commandmoneromooo-monero2-0/+34
I saw one when landing on www.tribler.org, and it seemed like a good idea to have something similar, alongside some more general "what is monero" text.
2019-04-11block_weight: catch exceptions in main for clean exit on errormoneromooo-monero1-0/+2
2019-04-11epee: init a new ssl related variable in ctormoneromooo-monero1-0/+1
2019-04-11console: simple shell over console.pymoneromooo-monero1-0/+3
to avoid the "python -i" part
2019-04-11console.py: can now connect to several daemons/walletsmoneromooo-monero3-53/+69
Also throw exceptions instead of print+exit, since that makes the error print last, below the python stack trace, where it's much less easy to miss it.
2019-04-11cmake: always detect python, it's neeed for some testsmoneromooo-monero1-0/+2
2019-04-11functional_tests: exit with 1 if any test failsmoneromooo-monero1-0/+2
2019-04-11console.py: add tab completionmoneromooo-monero1-0/+9
2019-04-11functional_tests: cold signing key images/outputs import/exportmoneromooo-monero2-0/+50
2019-04-11functional_tests: add double spend detection testsmoneromooo-monero2-2/+75
2019-04-11functional_tests: add alt chains testsmoneromooo-monero2-1/+49
2019-04-11functional_tests: add wallet creation language testsmoneromooo-monero2-4/+35
2019-04-11functional_tests: add more wallet testsmoneromooo-monero3-0/+86
get_transfer_by_txid, get_height, open/close
2019-04-11python-rpc: add set_log_level and set_log_categoriesmoneromooo-monero1-0/+12
2019-04-11functional_tests: add describe_transfer testsmoneromooo-monero3-1/+35
2019-04-11console.py: support connecting to any host, not just 127.0.0.1moneromooo-monero1-5/+23
2019-04-11functional_tests: add more blockchain related testsmoneromooo-monero11-77/+399
Related to emission, reorgs, getting tx data back, output distribution and histogram
2019-04-11functional_tests: add bans testsmoneromooo-monero2-0/+138
2019-04-11Merge pull request #5411Riccardo Spagni1-3/+4
3de49afc README.md: fork table, copy lines from release branch (Gingeropolous) e172fbae README.md: fix missing comma (Tyler Saballus) 97f0899b README.md: minor spelling issue (Justin Gerber)
2019-04-11Merge pull request #5388Riccardo Spagni6-12/+100
0be5b2ee simplewallet: new unset_ring command (moneromooo-monero)
2019-04-11Merge pull request #5382Riccardo Spagni5-22/+63
c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero) 3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero) 36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero) cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)
2019-04-11Merge pull request #5381Riccardo Spagni2-6/+10
def40161 miner: fix race when stopping mining with start mining enabled (moneromooo-monero)
2019-04-11Merge pull request #5380Riccardo Spagni3-3/+3
113e4877 blockchain_stats: fix sign in formatting function (moneromooo-monero) adaea3ea various: remove unused variables (moneromooo-monero) 631ef00e blockchain: some debug info when adding txes-from-block fails (moneromooo-monero)
2019-04-11Merge pull request #5379Riccardo Spagni3-5/+26
83fc45a4 Add NanoX support (cslashm)
2019-04-11Merge pull request #5378Riccardo Spagni3-25/+1
eda2661a Allow pruning before v10 (moneromooo-monero)
2019-04-11Merge pull request #5376Riccardo Spagni2-1/+5
c746f45d Add hash of top block to /getheight RPC (Howard Chu)
2019-04-11Merge pull request #5374Riccardo Spagni10-20/+264
a2561653 wallet: new option to start background mining (moneromooo-monero)
2019-04-11Merge pull request #5373Riccardo Spagni2-3/+6
aff80e70 blockchain: fix returned height in create_block_template (moneromooo-monero)
2019-04-11Merge pull request #5371Riccardo Spagni6-2/+56
9f8dc4ce simplewallet: new net_stats command (moneromooo-monero)
2019-04-11simplewallet: new net_stats commandmoneromooo-monero6-2/+56
displays total sent and received bytes
2019-04-11Merge pull request #5367Riccardo Spagni2-5/+5
07b716bf util: name replace_file arguments better (moneromooo-monero)
2019-04-11Merge pull request #5366Riccardo Spagni1-1/+1
c2f271d1 device/trezor: increase live-refresh timeout (Dusan Klinec)
2019-04-11Merge pull request #5123Riccardo Spagni10-16/+100
089c7637 cryptonote: rework block blob size sanity check (moneromooo-monero)
2019-04-11Merge pull request #4939Riccardo Spagni1-1/+5
f064efae README: add and remove dependencies on OSX line (George)
2019-04-11Merge pull request #5320Riccardo Spagni15-322/+474
2e578b82 Enabling daemon-rpc SSL now requires non-system CA verification (Lee Clagett) d58f3682 Require manual override for user chain certificates. (Lee Clagett) 97cd1fa9 Only check top-level certificate against fingerprint list. (Lee Clagett) 7c388fb3 Call `use_certificate_chain_file` instead of `use_certificate_file` (Lee Clagett) eca0fea4 Perform RFC 2818 hostname verification in client SSL handshakes (Lee Clagett) 0416764c Require server verification when SSL is enabled. (Lee Clagett) 96d602ac Add `verify_fail_if_no_cert` option for proper client authentication (Lee Clagett) 21eb1b07 Pass SSL arguments via one class and use shared_ptr instead of reference (Lee Clagett) 1f5ed328 Change default SSL to "enabled" if user specifies fingerprint/certificate (Lee Clagett) f18a069f Do not require client certificate unless server has some whitelisted. (Lee Clagett) a3b02848 Change SSL certificate file list to OpenSSL builtin load_verify_location (Lee Clagett)
2019-04-10device/trezor: env-configurable portsDusan Klinec3-22/+54
2019-04-10tests: trezor tests fixes and improvementsDusan Klinec4-25/+76
- configurable hardforks via env vars
2019-04-10wallet_rpc_server: add a all flag to export_outputsmoneromooo-monero4-9/+13
if we don't want to export new outputs only
2019-04-10Fix linker issues using easyloggingMartijn Otto2-1/+93
2019-04-09unit_tests/long_term_block_weight: some tweaks that seem to make more sensestoffu1-8/+9
2019-04-09tests/block_weight: use integer division when computing medianstoffu1-2/+2
2019-04-09tests/block_weight: remove unused MULTIPLIER_SMALLstoffu1-1/+0
2019-04-09blockchain: remove unused calc of short_term_constraintstoffu1-1/+0
2019-04-08readme: add some more instructions for translatorserciccione1-2/+2
- added link to guide for Pootle - link directly to CLI project on Pootle - improved wording
2019-04-07README.md: fork table, copy lines from release branchGingeropolous1-1/+2
2019-04-07README.md: fix missing commaTyler Saballus1-1/+1
2019-04-07README.md: minor spelling issueJustin Gerber1-1/+1
The word 'dont' is not spelled correctly.
2019-04-07Enabling daemon-rpc SSL now requires non-system CA verificationLee Clagett4-17/+51
If `--daemon-ssl enabled` is set in the wallet, then a user certificate, fingerprint, or onion/i2p address must be provided.
2019-04-07build: libusb static compilation fixDusan Klinec1-1/+10
2019-04-07tests: fix test_options initialization errorDusan Klinec5-6/+6
2019-04-07build fix: combinator.h stdexcept missing includeDusan Klinec1-0/+1
2019-04-07easylogging++: update to v9.96.7moneromooo-monero2-15/+21
2019-04-07blockchain_import: error out if preparing to handle blocks failsmoneromooo-monero1-1/+5
Coverity 197562
2019-04-07core: don't check block rate nor fork time in regtest modemoneromooo-monero1-1/+4
2019-04-07device/trezor: add button pressed requestDusan Klinec7-1/+42
2019-04-07Require manual override for user chain certificates.Lee Clagett3-1/+10
An override for the wallet to daemon connection is provided, but not for other SSL contexts. The intent is to prevent users from supplying a system CA as the "user" whitelisted certificate, which is less secure since the key is controlled by a third party.
2019-04-07Only check top-level certificate against fingerprint list.Lee Clagett1-2/+4
This allows "chain" certificates to be used with the fingerprint whitelist option. A user can get a system-ca signature as backup while clients explicitly whitelist the server certificate. The user specified CA can also be combined with fingerprint whitelisting.
2019-04-07Call `use_certificate_chain_file` instead of `use_certificate_file`Lee Clagett1-1/+1
The former has the same behavior with single self signed certificates while allowing the server to have separate short-term authentication keys with long-term authorization keys.
2019-04-07Perform RFC 2818 hostname verification in client SSL handshakesLee Clagett3-5/+26
If the verification mode is `system_ca`, clients will now do hostname verification. Thus, only certificates from expected hostnames are allowed when SSL is enabled. This can be overridden by forcible setting the SSL mode to autodetect. Clients will also send the hostname even when `system_ca` is not being performed. This leaks possible metadata, but allows servers providing multiple hostnames to respond with the correct certificate. One example is cloudflare, which getmonero.org is currently using.
2019-04-07Require server verification when SSL is enabled.Lee Clagett2-11/+16
If SSL is "enabled" via command line without specifying a fingerprint or certificate, the system CA list is checked for server verification and _now_ fails the handshake if that check fails. This change was made to remain consistent with standard SSL/TLS client behavior. This can still be overridden by using the allow any certificate flag. If the SSL behavior is autodetect, the system CA list is still checked but a warning is logged if this fails. The stream is not rejected because a re-connect will be attempted - its better to have an unverified encrypted stream than an unverified + unencrypted stream.
2019-04-07Add `verify_fail_if_no_cert` option for proper client authenticationLee Clagett1-1/+1
Using `verify_peer` on server side requests a certificate from the client. If no certificate is provided, the server silently accepts the connection and rejects if the client sends an unexpected certificate. Adding `verify_fail_if_no_cert` has no affect on client and for server requires that the peer sends a certificate or fails the handshake. This is the desired behavior when the user specifies a fingerprint or CA file.
2019-04-07Pass SSL arguments via one class and use shared_ptr instead of referenceLee Clagett13-210/+303
2019-04-06Change default SSL to "enabled" if user specifies fingerprint/certificateLee Clagett3-14/+29
Currently if a user specifies a ca file or fingerprint to verify peer, the default behavior is SSL autodetect which allows for mitm downgrade attacks. It should be investigated whether a manual override should be allowed - the configuration is likely always invalid.
2019-04-06Do not require client certificate unless server has some whitelisted.Lee Clagett1-12/+27
Currently a client must provide a certificate, even if the server is configured to allow all certificates. This drops that requirement from the client - unless the server is configured to use a CA file or fingerprint(s) for verification - which is the standard behavior for SSL servers. The "system-wide" CA is not being used as a "fallback" to verify clients before or after this patch.
2019-04-06Change SSL certificate file list to OpenSSL builtin load_verify_locationLee Clagett13-134/+92
Specifying SSL certificates for peer verification does an exact match, making it a not-so-obvious alias for the fingerprints option. This changes the checks to OpenSSL which loads concatenated certificate(s) from a single file and does a certificate-authority (chain of trust) check instead. There is no drop in security - a compromised exact match fingerprint has the same worse case failure. There is increased security in allowing separate long-term CA key and short-term SSL server keys. This also removes loading of the system-default CA files if a custom CA file or certificate fingerprint is specified.
2019-04-06wallet: add number of blocks required for the balance to fully unlockmoneromooo-monero5-22/+63
2019-04-06Merge pull request #5364Riccardo Spagni1-62/+3
e8cf7dcc rpc: merge the two get_info implementations (moneromooo-monero)
2019-04-06Merge pull request #5391Riccardo Spagni1-0/+5
71907980 unit_tests: fix long term block weight test after cache change (moneromooo-monero)
2019-04-06rpc: merge the two get_info implementationsmoneromooo-monero1-62/+3
2019-04-06Merge pull request #5375Riccardo Spagni1-0/+1
1569776a Add missing include (Leon Klingele)
2019-04-06Merge pull request #5360Riccardo Spagni1-2/+16
b0c552f5 cryptonote_protocol_handler: add block/tx hashes in notify logs (moneromooo-monero)
2019-04-06Merge pull request #5358Riccardo Spagni1-7/+40
dffdccdc No longer use deprecated RSA_generate_key in favor of RSA_generate_key_ex (Martijn Otto)
2019-04-06Merge pull request #5353Riccardo Spagni1-1/+1
1bc78cc2 tests: trezor_test fix (Dusan Klinec)
2019-04-06Merge pull request #5351Riccardo Spagni1-12/+43
a299dc96 rpc.gettransactions: fill as_json with partial tx in pruned mode (stoffu)
2019-04-06Merge pull request #5350Riccardo Spagni2-36/+23
050bb337 wallet2: factor the watchonly/multisig/etc fields on creation (moneromooo-monero)
2019-04-06Merge pull request #5348Riccardo Spagni4-8/+11
59776a64 epee: some more minor JSON parsing speedup (moneromooo-monero)
2019-04-06Merge pull request #5347Riccardo Spagni2-1/+24
d45b85e1 wallet2: skip derivation precalc for blocks we know we'll skip (moneromooo-monero)
2019-04-06Merge pull request #5346Riccardo Spagni6-20/+65
c84ea299 cryptonote_basic: some more minor speedups (moneromooo-monero) e40eb2ad cryptonote_basic: speedup calculate_block_hash (moneromooo-monero) 547a9708 cryptonote: block parsing + hash calculation speedup (moneromooo-monero) 11604b6d blockchain: avoid unneeded block copy (moneromooo-monero) 8461df04 save some database calls when getting top block hash and height (moneromooo-monero) 3bbc3661 Avoid repeated (de)serialization when syncing (moneromooo-monero)
2019-04-06Merge pull request #5345Riccardo Spagni2-4/+12
678262ab wallet_rpc_server: allow english/local language names in create_wallet (moneromooo-monero)
2019-04-06Merge pull request #5344Riccardo Spagni3-5/+5
5e1a3e48 lmdb: fix size_t size issues on 32 bit (moneromooo-monero)
2019-04-06Merge pull request #5343Riccardo Spagni1-4/+4
cafa15b9 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero)
2019-04-06Merge pull request #5342Riccardo Spagni1-3/+3
849a768f perf_timer: move some debug levels to info for consistency (moneromooo-monero)
2019-04-06Merge pull request #5341Riccardo Spagni1-6/+7
0218bc49 test: hmac_keccak - fix number of chunks counting (Dusan Klinec)
2019-04-06Merge pull request #5340Riccardo Spagni2-2/+2
16eda54b wallet: use original user address if we have a short payment id (moneromooo-monero)
2019-04-05wallet: API changes to enable passphrase entryDusan Klinec4-10/+37
2019-04-05rpc: make wide_difficulty hexadecimalmoneromooo-monero4-8/+26
This should be friendlier for clients which don't have bignum support
2019-04-05cryptonote: rework block blob size sanity checkmoneromooo-monero10-16/+100
Use the actual block weight limit, assuming that weight is always greater or equal to size
2019-04-04wallet: new option to start background miningmoneromooo-monero10-20/+264
The setup-background-mining option can be used to select background mining when a wallet loads. The user will be asked the first time the wallet is created.
2019-04-04wallet2: add --no-dns flagmoneromooo-monero2-3/+10
2019-04-04crypto: replace rand<T>()%N idiom with unbiased rand_idx(N)stoffu5-12/+36
2019-04-04rpc.gettransactions: fill as_json with partial tx in pruned modestoffu1-12/+43
2019-04-03wallet2: support multi out txes without change in sanity checkmoneromooo-monero1-7/+9
2019-04-03Merge pull request #5390Riccardo Spagni1-0/+1
8bb253b0 libwallet_merged: add missing net target (selsta)
2019-04-03tests: add a few try/catch in main to shut coverity upmoneromooo-monero4-0/+15
2019-04-03unit_tests: fix long term block weight test after cache changemoneromooo-monero1-0/+5
2019-04-02libwallet_merged: add missing net targetselsta1-0/+1
2019-04-02simplewallet: new unset_ring commandmoneromooo-monero6-12/+100
Useful when debugging, though not much for users
2019-04-02Merge pull request #5387Riccardo Spagni1-2/+2
d3018d0f api/wallet: fix some wrong namespace (stoffu)
2019-04-01README: add and remove dependencies on OSX lineGeorge1-1/+5
2019-04-02api/wallet: fix some wrong namespacestoffu1-2/+2
2019-04-01wallet: add number of blocks required for the balance to fully unlockmoneromooo-monero5-23/+64
2019-04-01wallet2: set confirmations to 0 for pool txes in proofsmoneromooo-monero1-4/+4
It makes more sense than (uint64_t)-1, which is going to look like very much confirmed when not checking in_pool
2019-04-01wallet_rpc_server: error out on getting the spend key from a hot walletmoneromooo-monero1-1/+7
2019-04-01wallet_rpc_server: always fill out subaddr_indices in get_transfersmoneromooo-monero1-0/+2
It was not filled out for in and pool types
2019-04-01miner: fix race when stopping mining with start mining enabledmoneromooo-monero2-6/+10
2019-04-01blockchain_stats: fix sign in formatting functionmoneromooo-monero1-1/+1
2019-04-01various: remove unused variablesmoneromooo-monero1-2/+0
2019-04-01blockchain: some debug info when adding txes-from-block failsmoneromooo-monero1-0/+2