Age | Commit message (Collapse) | Author | Files | Lines |
|
4fb77946 unit tests: OOB indexes & adding subaddress (Cole Lightfighter)
4fd6a3d2 Subaddress unit tests (Cole Lightfighter)
|
|
ac4018a7 wallet2: workaround for lightwallet before supporting subaddress (followup #2656) (kenshi84)
|
|
118a1bed rpc: make get_coinbase_tx_sum a restricted RPC (moneromooo-monero)
|
|
6bab9efe debug utils: fix debug build: rm unused identifier (redfish)
b92d3f96 cmake: fix shared library build (redfish)
|
|
ad96c478 wallet-cli: added --generate-from-spend-key option (stoffu)
|
|
0aa4cc80 ITS#8339 Solaris 10/11 robust mutex fixes (Howard Chu)
|
|
6bd4dac6 util: ignore SIGPIPE (moneromooo-monero)
|
|
7dbf76d0 Fix an object lifetime bug in net load tests (moneromooo-monero)
|
|
10013e94 Protect node privacy by proper filtering in restricted-mode RPC answers (binaryFate)
|
|
ccf53a56 track double spending in the txpool (moneromooo-monero)
|
|
78cf010e Add stoffu's GPG key (stoffu)
|
|
|
|
|
|
11e0deef cmake: add dep of version lib on version.cpp (redfish)
35340259 .gitignore: do not ignore cmake source files (redfish)
|
|
This patch allows to filter out sensitive information for queries that rely on the pool state, when running in restricted mode.
This filtering is only applied to data sent back to RPC queries. Results of inline commands typed locally in the daemon are not affected.
In practice, when running with `--restricted-rpc`:
* get_transaction_pool will list relayed transactions with the fields "last relayed time" and "received time" set to zero.
* get_transaction_pool will not list transaction that have do_not_relay set to true, and will not list key images that are used only for such transactions
* get_transaction_pool_hashes.bin will not list such transaction
* get_transaction_pool_stats will not count such transactions in any of the aggregated values that are computed
The implementation does not make filtering the default, so developers should be mindful of this if they add new RPC functionality.
Fixes #2590.
|
|
37c3792b wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked balance() (stoffu)
|
|
balance()
|
|
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.
Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
|
|
b370ef54 Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
|
|
8041b4e9 wallet-cli: allow priority argument for sweep_all and donate (stoffu)
|
|
93ad1f87 Fix #2559: more flexible print_tx daemon command (binaryFate)
|
|
b2d416f2 Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
|
|
ff7745bb Edited test readme for accuracy and depth (Cole Lightfighter)
c300ae56 Added test documentation & Keccak unit test (Cole Lightfighter)
f6119a8e Added test documentation & Keccak unit test (Cole Lightfighter)
|
|
161401dd Fix JSON-RPC response object over ZMQ (Lee Clagett)
|
|
|
|
88ebfd64 core_tests: fix for subaddress patch (kenshi84)
e373a203 performance_tests: add master spend pubkey to subaddress hashtable (kenshi84)
|
|
8233a24b unit_tests: fix build on windows (moneromooo-monero)
|
|
6a90506a Link against libpgm/libnorm if found, optional libzmq ldependencies (moneromooo-monero)
|
|
4b228dd3 cmake: epee: use var from FindOpenSSL.cmake (redfish)
29497f79 epee: use boost type for SSL error code (redfish)
|
|
d0463312 fix libwallet api test after api change (Jaquee)
a46c1eed Wallet2: Don't throw when subaddress label doesn't exist (Jaquee)
086b7db2 Wallet API: default values for account and subaddr index (Jaquee)
|
|
52c13810 blockchain_utilities: Add monero-blockchain-{ex,im}port binaries to default install targets (Bertrand Jacquin)
|
|
66255c0e Problem: Copyright notice is very confusing (Gareth)
|
|
69c37200 RPC Add cross origin resource sharing support (Tim L)
|
|
fab3b722 Add more specific RPC error codes (Michał Sałaban)
|
|
935f7462 blockchain: do not lock the blockchain lock for simple DB getters (moneromooo-monero)
|
|
626e8078 wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
|
|
44f14638 wallet2: fix tx size estimator for large number of inputs (moneromooo-monero)
|
|
f946bb7b fixed an LMDB issue on OpenBSD (#2699) which leads to a crash in monerod (ston1th)
|
|
969b5a2a net_helper: fix massive slowdown after SSL support (moneromooo-monero)
|
|
4dd05a2f subaddress: change prefix so that it starts with 8 (kenshi84)
|
|
ca87cbd8 wallet2: fix subaddress fields serialization (moneromooo-monero)
|
|
|
|
It is safe in those cases, though might return slightly out of date
information if another thread is busy modifying the blockchain,
but it avoids potentially lengthy delays just to get things like
the current blockchain height.
|
|
|
|
|
|
|
|
|
|
|
|
When loading an older wallet cache, they wouldn't be initialized,
leading them to have random(ish) values, and so assigned to some
random subaddress.
|
|
|
|
|
|
|
|
|
|
Also, move cmake source files into cmake/ to keep them together.
|
|
|
|
|
|
Tests for checking proper error throwing for out-of-bounds subaddress
indexes, and proper addition of subaddresses.
Signed-off-by: Cole Lightfighter <cole@onicsla.bz>
|
|
Solution: add line break to copyright notice and fix grammar.
|
|
This fixes linking when path to openssl
is defined manually:
cmake -DOPENSSL_ROOT_DIR='/usr/include/openssl-1.0;/usr/lib/openssl-1.0' ...
This is useful for building with OpenSSL v1.0
when default system installation is v1.1.
The linking error is undefined SSL_load_error_strings symbol.
This is due to -L /usr/lib/openssl-1.0 not making it onto
the linkline (so -lssl pulls in the default system openssl).
|
|
Fixes compile error when building with OpenSSL v1.1:
contrib/epee/include/net/net_helper.h: In member function ‘void epee::net_utils::blocked_mode_client::shutdown_ssl()’:
contrib/epee/include/net/net_helper.h:579:106: error: ‘SSL_R_SHORT_READ’ was not declared in this scope
if (ec.category() == boost::asio::error::get_ssl_category() && ec.value() != ERR_PACK(ERR_LIB_SSL, 0, SSL_R_SHORT_READ))
^
contrib/epee/include/net/net_helper.h:579:106: note: suggested alternative: ‘SSL_F_SSL_READ’
See boost/asio/ssl/error.hpp.
Boost handles differences between OpenSSL versions.
cmake: fail if Boost is too old for OpenSSL v1.1
|
|
Basic unit test fixture, and initialization of a subaddress account.
Signed-off-by: Cole Lightfighter <cole@onicsla.bz>
|
|
|
|
|
|
Fix #1530
|
|
Reported by iDunk on IRC
|
|
|
|
#2656)
|
|
|
|
default install targets
Binaries available to download on https://getmonero.org/downloads/ as
embedding monerod, monero-wallet-{cli,rpc} and
monero-blockchain-{ex,im}port.
This change synchronise download results with a manual build from
source
|
|
4d35ad76 Fix compiler warnings with Clang 6.0.0. (Vasil Dimov)
|
|
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{ }
monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
tools::signal_handler::install([&wrpc, &wal](int) {
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
|
|
fddd8d22 performance_tests: fix build after subaddress patch (moneromooo-monero)
|
|
|
|
52ec0e7f epee: link against ssl/crypto for the new SSL code (moneromooo-monero)
|
|
|
|
3492de01 fix lightwallet and subaddresses conflict (Jaquee)
329f149e remove reference to cryptonote::null_hash (Jaquee)
|
|
|
|
|
|
22b51e06 db_lmdb: include chain height when failing to find an output key (moneromooo-monero)
5db433b3 blockchain: avoid exceptions in output verification (moneromooo-monero)
|
|
529a6a4a core: guard against a mined block not finding all txes in the pool (moneromooo-monero)
|
|
2051f89f cmake: build tests last (redfish)
|
|
44c1d160 unit_tests: fix compiling on Windows (iDunk5400)
|
|
fe484f30 unit_tests: data dir is now overridden with --data-dir (moneromooo-monero)
|
|
4090e8c6 simplewallet: add get/set for refresh-from-height (moneromooo-monero)
|
|
0a872798 protocol: kick idle peers by dropping them (moneromooo-monero)
|
|
bc1b9333 frob level 1 logs a bit for consistency (moneromooo-monero)
|
|
885c773a cmake: print which stack trace lib is used (redfish)
|
|
b776c725 daemon: use @N syntax to output_histogram for specific amounts (moneromooo-monero)
|
|
c4136134 miner: always update block template when starting (moneromooo-monero)
|
|
06fb9bcf wallet2: fix refresh height calc for new wallets (moneromooo-monero)
|
|
dc19659d Remove network_address_base which has been merged with ipv4_network_address in 8b006877 (Michał Sałaban)
2183ade0 Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. (Michał Sałaban)
|
|
8f0cea63 add a command_line function to check for defaulted options (moneromooo-monero)
|
|
cba34494 rpc: out_peers now works again (moneromooo-monero)
|
|
7b8d3ec6 wallet-cli: add --do-not-relay option (stoffu)
|
|
27fdaaa4 Fix building with -DARCH=default -DNO_AES=ON (moneromooo-monero)
|
|
240f769d tests: add sha256sum unit test (moneromooo-monero)
|
|
e6636577 Add needed dependencies (Emilien Devos)
|
|
7e7acdc3 daemon: catch out of range exceptions too when calling stoll/stoi (moneromooo-monero)
|
|
8028dde7 block_queue: use boost::uuids::nil_uuid where appropriate (moneromooo-monero)
|
|
f139a6ca wallet2: fix backlog being off by 1 (moneromooo-monero)
|
|
b5b4abb8 simplewallet: fix setting default-ring-size to 0 (moneromooo-monero)
|
|
7130cf0c Add tools::on_startup, and warn about glibc 2.25 bug if found (moneromooo-monero)
|
|
54940d8c blockchain_import: remove a few commented out obsolete lines (moneromooo-monero)
|
|
452d4fae tests: fix hashchain unit tests (moneromooo-monero)
|
|
acc186eb README: Add package installation instructions for Void Linux (Helmut Pozimski)
|
|
97c2e449 wallet2+API: use separate callbacks for lightwallets (Jaquee)
d9261867 walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee)
9442b043 walletAPI: lightwallet exceptions (Jaquee)
fc922934 walletAPI: add lightwallet login() and importWalletRequest() (Jaquee)
79207743 walletAPI: init() lightwallet and SSL support (Jaquee)
dde5a1fc walletAPI: add tx unlock_time (Jaquee)
bba5cbed wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee)
7a482f30 wallet2: create_transactions_2 lightwallet support (Jaquee)
ce61b818 wallet2: get_outs lightwallet support (Jaquee)
1197cb71 wallet2: commit_tx() lightwallet support (Jaquee)
43b57804 wallet2: refactor is_tx_spendtime_unlocked() (Jaquee)
32e2b003 wallet2: add lightwallet exceptions to common functions (Jaquee)
2e692fc0 wallet2: refresh() lightwallet support (Jaquee)
f44d156c my/openmonero API functions (Jaquee)
288d3c75 wallet2: add remove_obsolete_pool_txs() (Jaquee)
2c6aad7e wallet2: add on_pool_tx_removed callback (Jaquee)
ff7c30aa wallet2: light wallet member variables (Jaquee)
e2a276cb wallet2: add ssl option to init() (Jaquee)
a13540be add string_tools::validate_hex() (Jaquee)
fd773d88 refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee)
8bfa6c2d lightwallet rpc server commands (Jaquee)
76961ddc Serializer: string to integer conversion for MyMonero compatibility (Jaquee)
1cf940f2 epee http_client SSL support (Jaquee)
eec10137 CMakeLists.txt - Add openssl include dir (Jaquee)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
a4b4651c dns_utils: allow an optional DNS server IP in DNS_PUBLIC (moneromooo-monero)
|
|
d74336d5 wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
|
|
|
|
|
|
|
|
69ce33f2 core: fix failure to sync when a tx is already in the pool (moneromooo-monero)
|
|
735fafec simplewallet: allow 1/yes/y as well as true for start_mining options (moneromooo-monero)
|
|
bf2d9113 simplewallet: fix --restore-from-height being ignored (moneromooo-monero)
|
|
|
|
efb95f96 readme: update Arch/AUR pkg name; post-rebranding (redfish)
|
|
787ff011 add Mishi Choudhary's GPG key (Riccardo Spagni)
|
|
mymonero timestamp conversion
|
|
|
|
551a8ea6 mnemonics: new Lojban word list (Wei Tang)
|
|
|
|
7adceee6 precomputed block hashes are now in blocks of N (currently 256) (moneromooo-monero)
|
|
53ad5a0f Subaddresses (kenshi84)
|
|
It's pretty slow and I/O intensive
|
|
https://sourceware.org/bugzilla/show_bug.cgi?id=21778
|
|
|
|
|
|
To help debugging logs.
|
|
This can happen if we get a bad tx, so let's not spam the log.
|
|
This can happen for several reasons, but mainly if another block
was received, which took that tx off the pool.
|
|
Check for PTHREAD_MUTEX_ROBUST_NP definition (this doesn't work
on Linux/glibc because they used an enum). Zero out mutex before
initing.
|
|
tcp://a.b.c.d
|
|
In practice, this seems to cause monero-wallet-rpc to exit
when ^C quits whatever its output is piped into (such as tee),
but it saves, while it did not before.
|
|
The commands handler must not be destroyed before the config
object, or we'll be accessing freed memory.
An earlier attempt at using boost::shared_ptr to control object
lifetime turned out to be very invasive, though would be a
better solution in theory.
|
|
Keep -Werror for src, contrib and do not pass it for tests/
|
|
|
|
|
|
rather than a raw string without option
|
|
|
|
This is safer, as we don't risk break expectations (eg, requesting
block hashes and then receiving a late set of blocks). Dropping a
connection means another will be attempted in a fresh state.
Also bump the kick timeout to 5 minutes, to ensure we only kick
really idle peers.
|
|
Level 1 logs map to INFO, so setting log level to 1 should
show these. Demote some stuff to DEBUG to avoid spam, though.
|
|
in 8b006877
|
|
To avoid the suprize of stack tracing being enabled
but libunwind not being linked in.
|
|
Makes debugging tx verification easier
|
|
This fixes using the previous address when starting mining,
then stopping and restarting with a different address
|
|
|
|
|
|
|
|
|
|
wallet-dir already exists.
|
|
7d4ef258 rpc: fix getting txpool transactions (moneromooo-monero)
|
|
180a848c wallet2: Missing underflow check on low heights (landergate)
|
|
15e62581 connection_context: initialize m_callback_request_count to 0 (moneromooo-monero)
5fa199c6 copyable_atomic: add a ctor with initial value (moneromooo-monero)
|
|
71c7f8d0 core: fix logging the one time public key on error (moneromooo-monero)
|
|
93ed9321 cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
|
|
269a2a01 blockchain: fix off by one getting blocks (moneromooo-monero)
|
|
4e115a3a core: remove out sorting from v7 rules (moneromooo-monero)
|
|
cbc5508b construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
|
|
bd937139 wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
|
|
38f2ccbe fix portable binaries build targets (lancillotto)
|
|
540d6fa3 tests: pass data dir as arg (redfish)
|
|
986d03d4 simplewallet: allow to set threshold before warning about tx backlog (selsta)
|
|
8b006877 Upgrades to epee::net_utils::network_address - internal nullptr checks - prevent modifications to network_address (shallow copy issues) - automagically works with any type containing interface functions - removed fnv1a hashing - ipv4_network_address now flattened with no base class (Lee Clagett)
|
|
|
|
|
|
|
|
|
|
- internal nullptr checks
- prevent modifications to network_address (shallow copy issues)
- automagically works with any type containing interface functions
- removed fnv1a hashing
- ipv4_network_address now flattened with no base class
|
|
|
|
And any other exception, just to be safe
|
|
|
|
We don't want to count "partly filled" blocks in this case
|
|
It'd be set to the current wallet default instead
|
|
|
|
and relax the not-empty safety check to stay more intuitiuve
|
|
wallet_generate_key_image_helper
|
|
work properly
|
|
6a0fb301 performance_tests: adjust some iterations down a bit (moneromooo-monero)
|
|
c34093db simplewallet: add privacy warning when using an untrusted demon (moneromooo-monero)
|
|
309290d1 Source updates are in a source subdirectory (moneromooo-monero)
|
|
792ba4f0 Log categories can now be added to and removed from (moneromooo-monero)
48f92eb6 easylogging++: add categories getter (moneromooo-monero)
f35afe62 epee: factor log level/categories setting (moneromooo-monero)
|
|
c3de19ed json_object: add missing do_not_relay to tx_in_pool serialization (moneromooo-monero)
|
|
|