aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-08-28New "Halfway RingCT" outputs for coinbase transactionsmoneromooo-monero19-36/+120
When RingCT is enabled, outputs from coinbase transactions are created as a single output, and stored as RingCT output, with a fake mask. Their amount is not hidden on the blockchain itself, but they are then able to be used as fake inputs in a RingCT ring. Since the output amounts are hidden, their "dustiness" is not an obstacle anymore to mixing, and this makes the coinbase transactions a lot smaller, as well as helping the TXO set to grow more slowly. Also add a new "Null" type of rct signature, which decreases the size required when no signatures are to be stored, as in a coinbase tx.
2016-08-28rct: log why verification failsmoneromooo-monero1-9/+13
and remove some unnecessary variables in the checking code
2016-08-28rct: serialize txnFee as varintmoneromooo-monero1-1/+1
2016-08-28rct amount key modified as per luigi1111's recommendationsmoneromooo-monero15-133/+85
This allows the key to be not the same for two outputs sent to the same address (eg, if you pay yourself, and also get change back). Also remove the key amounts lists and return parameters since we don't actually generate random ones, so we don't need to save them as we can recalculate them when needed if we have the correct keys.
2016-08-28rct: rework v2 txes into prunable and non prunable datamoneromooo-monero8-90/+153
Nothing is pruned, but this allows easier changes later.
2016-08-28rct: rework the verification preparation processmoneromooo-monero6-200/+195
The whole rct data apart from the MLSAGs is now included in the signed message, to avoid malleability issues. Instead of passing the data that's not serialized as extra parameters to the verification API, the transaction is modified to fill all that information. This means the transaction can not be const anymore, but it cleaner in other ways.
2016-08-28rct: change the simple flag to a typemoneromooo-monero8-25/+46
for future expansion
2016-08-28rct: avoid the need for the last II elementShen Noether6-55/+55
This element is used in the generation of the MLSAG, but isn't needed in verification. Also misc changes in the cryptonote code to match, by mooo.
2016-08-28wallet: do not store signatures in the wallet cachemoneromooo-monero11-31/+95
Saves some substantial space. Also avoid calculating tx hashes we don't need.
2016-08-28core: add some locking around pool usemoneromooo-monero2-1/+4
2016-08-28wallet2: factor m_spent changesmoneromooo-monero2-26/+31
Makes it easier to track what is going on.
2016-08-28wallet: always use new algorithm for RPC transfersmoneromooo-monero2-7/+2
This ensures we get rct transactions when appropriate
2016-08-28rct: do not serialize senderPk - it is not used anymoremoneromooo-monero3-3/+5
2016-08-28core_tests: fix a couple pre-rct tests using rctmoneromooo-monero1-2/+2
2016-08-28wallet: use the prefered rct case only when enough rct outs existmoneromooo-monero2-1/+27
2016-08-28wallet: do not try to use rct txes a few blocks before the forkmoneromooo-monero3-22/+31
2016-08-28tx_pool: log why a transaction was rejected for version checksmoneromooo-monero1-0/+3
2016-08-28change fork settings to allow pre-rct txes for one more fork cyclemoneromooo-monero5-14/+19
2016-08-28simplewallet: better check_tx_key feedbackmoneromooo-monero1-2/+20
Print number of confirmations if the tx is in the blockchain, or a warning if it's in the pool.
2016-08-28rct: make the amount key derivable by a third party with the tx keymoneromooo-monero12-92/+140
Scheme design from luigi1114.
2016-08-28rct: do not serialize public keys in outPkmoneromooo-monero8-34/+87
They can be reconstructed from vout
2016-08-28wallet2_api: zero amounts are now allowed with rctmoneromooo-monero1-6/+0
2016-08-28wallet2_api: update on_money_{received,spent} prototypes for rct changesmoneromooo-monero1-4/+2
2016-08-28rpc: send global indices along with blocks/transacions on refreshmoneromooo-monero4-35/+78
This plugs a privacy leak, where the wallet tells the daemon which transactions contain outputs for the wallet by asking for additional information for that particular transaction. As a nice bonus, this actually makes refresh slightly faster.
2016-08-28core: always use the new simple rct variantmoneromooo-monero1-1/+1
2016-08-28tests: add tests for wallet output selectionmoneromooo-monero2-1/+100
2016-08-28wallet: better tx input selectionmoneromooo-monero2-29/+77
We try to avoid related inputs, when possible
2016-08-28rct: use the already defined H where possiblemoneromooo-monero1-2/+1
Found by luigi1111w
2016-08-28wallet: handle 0 change properlymoneromooo-monero1-7/+8
With RCT, we allow 0 size outputs, to try and encourage txes with two inputs and two outputs. Consolidation would then have two non zero inputs, one zero output, and one larger output.
2016-08-28port get_tx_key/check_tx_key to rctmoneromooo-monero10-34/+181
2016-08-28tests: add basic tests for simple rct apimoneromooo-monero1-44/+378
2016-08-28integrate simple rct apimoneromooo-monero11-182/+394
2016-08-28serialization: add override for serializing boolmoneromooo-monero1-0/+6
2016-08-28ringct: optimization/cleanup of hash functionsShen Noether3-22/+45
2016-08-28ringct: "simple" ringct variantShen Noether6-3/+262
Allows the fake outs to be in different positions for each ring. For rct inputs only.
2016-08-28wallet: rct specific output selectionmoneromooo-monero2-3/+125
Before the normal selection, we attempt to find either one or two suitable outputs to use as inputs to the rct tx. The intent is that most rct txes will have one or two inputs, and we want all to look the same if possible. When two outputs are needed, we try to find a pair which are not related (ie, by being from the same or similar block height).
2016-08-28wallet: make sweep_all work with rct txes toomoneromooo-monero1-7/+21
2016-08-28mixable transactions must be rct for v3moneromooo-monero4-6/+33
2016-08-28wallet: factor transfer_rct code with transfer codemoneromooo-monero4-267/+42
The "transfer" simplewallet command is renamed to "transfer_original". "transfer_new" is renamed "transfer", "transfer_rct" is removed, and the new "transfer" now selects rct or non rct transactions based on the current block height.
2016-08-28Condition v2 txes on v3 hard forkmoneromooo-monero2-1/+12
2016-08-28move the rct commitments to the output_amounts databasemoneromooo-monero8-195/+63
Since these are needed at the same time as the output pubkeys, this is a whole lot faster, and takes less space. Only outputs of 0 amount store the commitment. When reading other outputs, a fake commitment is regenerated on the fly. This avoids having to rewrite the database to add space for fake commitments for existing outputs. This code relies on two things: - LMDB must support fixed size records per key, rather than per database (ie, all records on key 0 are the same size, all records for non 0 keys are same size, but records from key 0 and non 0 keys do have different sizes). - the commitment must be directly after the rest of the data in outkey and output_data_t.
2016-08-28rct: add the tx prefix hash into the MLSAGmoneromooo-monero6-9/+43
to protect the non-signatures parts of the tx from tampering.
2016-08-28ringct: fix size unit mismatch calling keccakmoneromooo-monero1-1/+1
2016-08-28ringct: do not serialize what can be reconstructedmoneromooo-monero8-71/+145
The mixRing (output keys and commitments) and II fields (key images) can be reconstructed from vin data. This saves some modest amount of space in the tx.
2016-08-28Add rct core testsmoneromooo-monero7-10/+764
2016-08-28Use the supplied hard fork version in validate_miner_transactionmoneromooo-monero1-1/+1
rather than using the current one. No functional changes, but may save some bugs in the future.
2016-08-28wallet: update spent status when an accepted tx disappearsmoneromooo-monero1-0/+19
2016-08-28wallet: reset output spent status on blockchain reorgmoneromooo-monero2-11/+61
If the blockchain gets reorganized, all outputs spent in the part of the blockchain that's blown away need to be reset to unspent (they may end up spent again on the blocks that replace the blocks that are removed, however).
2016-08-28ringct: catch errors from ge_frombytes_vartimemoneromooo-monero1-11/+12
2016-08-28tests: test for ringct rctSig data sizesmoneromooo-monero1-3/+44
ie, more data or less data than expected in various fields
2016-08-28ringct: add missing size check for ecdhInfomoneromooo-monero1-0/+1
2016-08-28ringct: change asserts to return false for boolean functionsmoneromooo-monero1-10/+10
2016-08-28add rct to the protocolmoneromooo-monero26-274/+1208
It is not yet constrained to a fork, so don't use on the real network or you'll be orphaned or rejected.
2016-08-28db_lmdb: update reset for recent db changesmoneromooo-monero1-0/+10
- we need to drop the new m_tx_indices database - we reset the version to current version This fixes the core tests failing to initialize.
2016-08-28ringct: add functions to commit to an amountmoneromooo-monero2-0/+21
One to commit to an amount with zero key (for use with fake commitments for pre-rct outputs), and one with an arbitrary key (for rct outputs).
2016-08-28make rct tx serialization workmoneromooo-monero4-28/+305
It may be suboptimal, but it's a pain to have to rebuild everything when some of this changes. Also, no clue why there seems to be two different code paths for serializing a tx...
2016-08-28crypto: error out where appropriatemoneromooo-monero1-2/+2
2016-08-28ringct: allow no outputs, and add tests for this and feesmoneromooo-monero2-33/+75
2016-08-28ringct: make fee optionalmoneromooo-monero1-2/+9
2016-08-28ringct: txn fee stuffShen Noether4-13/+85
2016-08-28ringct: new {gen,decode}Rct APIs for conveniencemoneromooo-monero2-11/+27
A new version of genRct takes the mixRing as parameter, instead of the inPk. inPk are part of the mixRing, and it is cleaner to pass the mixRing data than to fetch it from the RingCT code. A new version of decodeRct also returns the mask. Also, failure to decode throws, so errors are properly detected.
2016-08-28ringct: add more convenience functionsmoneromooo-monero1-4/+14
2016-08-28core: link against libringctmoneromooo-monero1-0/+1
2016-08-28core: new /getrandom_rctouts.bin binary RPC callmoneromooo-monero7-0/+192
to get random ringct outputs to mix with
2016-08-28ringct: add convenience functions to bridge ringct and cryptonotemoneromooo-monero1-0/+5
2016-08-28blockchain_db: add functions for adding/removing/getting rct commitmentsmoneromooo-monero4-0/+157
2016-08-28ringct: restore verRange check in debug modemoneromooo-monero1-1/+1
2016-08-28ringct: add check for destinations/amount size being equalmoneromooo-monero1-0/+1
2016-08-28ringct: fix off by 1 in mixin usagemoneromooo-monero1-3/+3
2016-08-28ringct: simplify random key generationmoneromooo-monero1-7/+2
2016-08-28tests: new ringct test for checking H2 valuesShen Noether1-0/+11
Ported from Shen's RingCT repo
2016-08-28ringct: cosmetic fixesShen Noether4-46/+9
Ported from Shen's RingCT repo
2016-08-28ringct: changes to hashToPointSimple to calcualte H2 valuesShen Noether1-0/+5
Ported from Shen's RingCT repo
2016-08-28ringct: compare keys with bitwise equality, not crypto opsShen Noether1-7/+6
Ported from Shen's RingCT repo
2016-08-28ringct: fix size argument to cn_fast_hashShen Noether1-1/+1
Ported from Shen's RingCT repo
2016-08-28tests: zero inputs/outputs are in fact supposed to be acceptedmoneromooo-monero1-14/+14
2016-08-28ringct: add a test for prooveRange being non deterministicmoneromooo-monero1-0/+9
2016-08-28Fix sc_0 to skGen in ProveRangeShen Noether1-1/+1
2016-08-28ringct: add a few consts where appropriatemoneromooo-monero2-6/+6
2016-08-28tests: more ringct range proof testsmoneromooo-monero2-1/+246
2016-08-28rct: add serialization machinery to rct typesmoneromooo-monero2-10/+61
2016-08-28serialization: declare do_serialize specializations before usemoneromooo-monero2-1/+6
This lets my gcc picks those instead of the generic template where appropriate (and then fail since std::vector<something> does not have a serialize method.
2016-08-28Added note on generating H2Shen Noether1-1/+2
2016-08-28Fixed missing last index H2Shen Noether1-1/+2
2016-08-28remove original Cryptonote blockchain_storage blockchain formatmoneromooo-monero24-2966/+8
2016-08-28ringct: lock access to the PRNGmoneromooo-monero1-2/+2
2016-08-28ringct: add simple input validationmoneromooo-monero2-32/+74
Throw when inputs aren't the expected size.
2016-08-28tests: add some more ringct building block testsmoneromooo-monero1-1/+50
2016-08-28ringct: add convenience operators to keymoneromooo-monero1-0/+4
2016-08-28tests: add Shen Noether's basic ringct testsmoneromooo-monero2-1/+209
2016-08-28ringct: import of Shen Noether's ring confidential transactionsmoneromooo-monero15-13/+2410
2016-08-26Merge pull request #991Riccardo Spagni1-4/+12
f88029e db_lmdb: do not try to modify the database in read only mode (moneromooo-monero)
2016-08-26db_lmdb: do not try to modify the database in read only modemoneromooo-monero1-4/+12
2016-08-26Merge pull request #989Riccardo Spagni1-1/+1
0ed35f7 README.md: Boost version updated for windows (tobiasw2)
2016-08-26Merge pull request #986Riccardo Spagni1-1/+1
da58422 Update README.i18n (arb0r)
2016-08-26Merge pull request #984Riccardo Spagni2-2/+5
78035d2 Fix fake 'network synchronized, begin using' messages (Thomas Winget)
2016-08-26Merge pull request #982Riccardo Spagni1-1/+1
65238d2 fix #691 removed help about leaving wallet name empty on --generate-new-wallet (guzzi_jones)
2016-08-26Merge pull request #978Riccardo Spagni3-5/+103
99dd572 libwallet_api: tests: checking for result while opening wallet (Ilya Kitaev) bcf7b67 libwallet_api: Wallet::amountFromString fixed (Ilya Kitaev) 32bc7b4 libwallet_api: helper method to return maximumAllowedAmount (Ilya Kitaev) cbe534d libwallet_api: tests: removed logged passwords (Ilya Kitaev) b1a5a93 libwallet_api: do not store wallet on close if status is not ok (Ilya Kitaev)
2016-08-26Merge pull request #976Riccardo Spagni1-1/+8
c2f4e16 simplewallet: default to max-concurrency 1 on MacOS X (moneromooo-monero)
2016-08-25README.md: Boost version updated for windowstobiasw21-1/+1
2016-08-24Merge pull request #988Riccardo Spagni1-0/+1
5f873ea added Symas as a sponsor (Riccardo Spagni)
2016-08-24added Symas as a sponsorRiccardo Spagni1-0/+1
2016-08-24Merge pull request #981Riccardo Spagni1-1/+1
3729ac8 Docs: re-introduce Boost 1.58 min req from 2a2b655 (anonimal)
2016-08-24Merge branch 'ranok-patch-1'Riccardo Spagni1-8/+4
2016-08-24resolved conflicts in readme.mdRiccardo Spagni1-8/+4
2016-08-24Update README.i18narb0r1-1/+1
Fixed typo.
2016-08-23Fix fake 'network synchronized, begin using' messagesThomas Winget2-2/+5
2016-08-24fix #691 removed help about leaving wallet name empty on --generate-new-walletguzzi_jones1-1/+1
2016-08-23Docs: re-introduce Boost 1.58 min req from 2a2b655anonimal1-1/+1
2016-08-23libwallet_api: tests: checking for result while opening walletIlya Kitaev1-4/+6
2016-08-23libwallet_api: Wallet::amountFromString fixedIlya Kitaev2-1/+24
2016-08-23libwallet_api: helper method to return maximumAllowedAmountIlya Kitaev2-0/+6
2016-08-22Merge branch 'radfish-PR--readme-clarify-conf-syntax'Riccardo Spagni1-7/+44
2016-08-22fix README conflictsRiccardo Spagni1-7/+44
2016-08-22Merge pull request #972Riccardo Spagni1-1/+1
2c5e68f cmake: fix typo in handling of STACK_TRACE (redfish)
2016-08-22Merge pull request #970Riccardo Spagni1-0/+3
25f529a wallet: store key images after importing them (moneromooo-monero)
2016-08-22Merge pull request #968Riccardo Spagni1-0/+1
9cca53a wallet: fix build on Mac and Windows (missing include) (moneromooo-monero)
2016-08-22Merge pull request #967Riccardo Spagni1-1/+3
e596e25 simplewallet: do not suggest removing cache if the password was wrong (moneromooo-monero)
2016-08-22Merge pull request #964Riccardo Spagni2-8/+4
2a2b655 Build: make boost 1.58 minimum requirement. Fixes #956 (anonimal)
2016-08-22README formattingJacob Torrey1-4/+4
Very slight changes to make the markdown slightly more readable and easy to copy/paste from.
2016-08-22libwallet_api: tests: removed logged passwordsIlya Kitaev1-2/+2
2016-08-22libwallet_api: do not store wallet on close if status is not okIlya Kitaev2-5/+72
2016-08-21readme: format Windows deps as a listredfish1-1/+8
2016-08-21readme: formatting for rlwrap command snippetredfish1-2/+6
2016-08-21simplewallet: default to max-concurrency 1 on MacOS Xmoneromooo-monero1-1/+8
A suspected bug in pthread/kernel, though might be that I messed something up too... This might rope in more platforms though.
2016-08-20readme: add deps for documentationredfish1-1/+6
2016-08-20readme: add deps: miniupnpc and libunwindredfish1-0/+2
miniupnpc is included in source repo, but list it anyway, eventually that fork will hopefully go away from this repo.
2016-08-20readme: add pkg-config depredfish1-0/+1
2016-08-20readme: decrease size of sponsor logosredfish1-1/+6
2016-08-20readme: format dependencies into a list #951redfish1-2/+15
2016-08-20readme: clarify conf syntax re leading dashesredfish1-1/+1
2016-08-19cmake: fix typo in handling of STACK_TRACEredfish1-1/+1
This fixes the log output not getting redirected to log file.
2016-08-17wallet: store key images after importing themmoneromooo-monero1-0/+3
It avoids rescan_spent resetting spent status, for example.
2016-08-17wallet: fix build on Mac and Windows (missing include)moneromooo-monero1-0/+1
Reported by RaskaRuby, tested by iDunk5400.
2016-08-16simplewallet: do not suggest removing cache if the password was wrongmoneromooo-monero1-1/+3
2016-08-16Build: make boost 1.58 minimum requirement. Fixes #956anonimal2-8/+4
2016-08-16Merge pull request #963Riccardo Spagni2-5/+9
44dab04 Build: use libstdc++ with clang < 3.7 (anonimal) 455ded4 Build: use Boost 1.58 for Travis build. Refs #956 (anonimal)
2016-08-16Merge pull request #959Riccardo Spagni5-2/+50
7e4e002 daemon: print time to next fork (moneromooo-monero)
2016-08-16Build: use libstdc++ with clang < 3.7anonimal1-2/+2
2016-08-15Build: use Boost 1.58 for Travis build. Refs #956anonimal1-3/+7
2016-08-12daemon: print time to next forkmoneromooo-monero5-2/+50
2016-08-11Merge pull request #955Riccardo Spagni1-6/+12
7442dd0 More for Issue #855 (Howard Chu)
2016-08-11Merge pull request #948Riccardo Spagni16-80/+345
11dc091 Fake outs set is now decided by the wallet (moneromooo-monero) 1593553 new unlocked parameter to output_histogram (moneromooo-monero)
2016-08-11More for Issue #855Howard Chu1-6/+12
Plug rpage leak in cursor_set
2016-08-11Fake outs set is now decided by the walletmoneromooo-monero13-62/+304
This plugs a privacy leak from the wallet to the daemon, as the daemon could previously see what input is included as a transaction input, which the daemon hadn't previously supplied. Now, the wallet requests a particular set of outputs, including the real one. This can result in transactions that can't be accepted if the wallet happens to select too many outputs with non standard unlock times. The daemon could know this and select another output, but the wallet is blind to it. It's currently very unlikely since I don't think anything uses non default unlock times. The wallet requests more outputs than necessary so it can use spares if any of the returns outputs are still locked. If there are not enough spares to reach the desired mixin, the transaction will fail.
2016-08-11Merge pull request #953Riccardo Spagni1-2/+1
240864f db_lmdb: errors dropping hf starting height db on reset are not fatal (moneromooo-monero)
2016-08-11Merge pull request #952Riccardo Spagni2-4/+9
709c724 Better fix (#4) (hyc) d2644c1 fix restore-deterministic height (luigi1111)
2016-08-11Merge pull request #949Riccardo Spagni2-69/+64
da1007f simplewallet: make the refresh thread into more generic idle thread (moneromooo-monero)
2016-08-11Merge pull request #947Riccardo Spagni1-1/+2
663fc32 wallet2: if importing key images fails, print failure index (moneromooo-monero)
2016-08-11Merge pull request #943Riccardo Spagni4-53/+106
f0c0a3f Fix #864 Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true (guzzi_jones)
2016-08-11Merge pull request #940Riccardo Spagni1-0/+2
e890f51 Build: take out tests in Travis CI (anonimal) 198e408 Build: add vanilla clang to Travis CI (anonimal) 659bee6 Build: add make release-test to Travis CI (anonimal)
2016-08-11Merge pull request #939Riccardo Spagni2-42/+45
33b5ebd cmake: do not pass -O2 in debug build on ARM (redfish) 35dc40a cmake: libatomic only needed for 32-bit Clang builds (redfish) 042db0b cmake: cleanup logic that sets flags per target/subdir (redfish)
2016-08-10db_lmdb: errors dropping hf starting height db on reset are not fatalmoneromooo-monero1-2/+1
This db is now dropped unconditionally, so may or may not be there in the first place.
2016-08-09Better fix (#4)hyc2-4/+9
2016-08-09fix restore-deterministic heightluigi11111-2/+2
Simplewallet improperly skipped the restore from height code if restoring a deterministic wallet AND not specifying a wallet file in the command line. The other generate options require a wallet file as an argument, which prevents "ask_wallet_create_if_needed()" from being called, which in turn causes "m_generate_new" to remain unset. Specifying a wallet file at launch with --restore-deterministic emulated this behavior.
2016-08-07simplewallet: make the refresh thread into more generic idle threadmoneromooo-monero2-69/+64
2016-08-04wallet2: if importing key images fails, print failure indexmoneromooo-monero1-1/+2
2016-08-01cmake: do not pass -O2 in debug build on ARMredfish1-7/+8
Also, minor cleanup of redundant flag-setting code.
2016-08-01new unlocked parameter to output_histogrammoneromooo-monero9-18/+41
This constrains the number of instances of any amount to the unlocked ones (as defined by the default unlock time setting: outputs with non default unlock time are not considered, so may be counted as unlocked even if they are not actually unlocked).
2016-08-01Fix #864guzzi_jones4-53/+106
Squashed commit of the following: commit 9af9e4223b58bbb65a3519af2c2bfc273cbd23d6 fixed some formatting commit c7920e1cf88ff46eb9294101344d9a567f22e2da Merge: 97eb28b 1da1c68 fix#864 fix using boolean commit 97eb28ba5dd49ddde8c8785f39b24d955e5de31c Fix #864 boolean value used to verify on new wallet commit 1da1c68bd3a9a373c70482b6e6e95251096149f1 fix #864 changed to boolean to prompt for verify commit 5bee96652434762d2c91ce31a1b1c9f169446ddc fix 864; made variable names easier for understanding branching. commit 45715960d30293f781b2ff9e5e647c2ec893f4a3 fix #864; allow password to be entered twice for new wallets for verification. fix #864 password entry verification; ammended boolean fix #864 ; default constructor for password_container should set verify=true
2016-07-30Build: take out tests in Travis CIanonimal1-1/+1
2016-07-29Build: add vanilla clang to Travis CIanonimal1-0/+2
2016-07-29Build: add make release-test to Travis CIanonimal1-1/+1
2016-07-28cmake: libatomic only needed for 32-bit Clang buildsredfish1-5/+3
2016-07-28cmake: cleanup logic that sets flags per target/subdirredfish2-32/+36
The previous logic that used a COMMON_*_FLAGS intermediate variable and then re-assigned CMAKE_*_FLAGS before including each subdirectory was confusing and ugly. This PR is the right way to do it. This commit is purely refactoring: built binaries unchanged.
2016-07-27Merge pull request #937Riccardo Spagni4-25/+35
0f990d0 cmake,common: flag for stack trace (redfish)
2016-07-27Merge pull request #936Riccardo Spagni4-19/+36
4618873 tests: fix a bitflag test typo (moneromooo-monero) 89e68d7 unit_tests: check adding checkpoints succeeded (moneromooo-monero) 121165f db_lmdb: add some missing api call checks (moneromooo-monero) 22d8344 core_rpc_server: fix gray/white peer list mixup (moneromooo-monero)
2016-07-27cmake,common: flag for stack traceredfish4-25/+35
By default the flag is enabled whenever libunwind is found on the system, with the exception of static build on OSX (for which we can't install the throw hook #932 due to lack of support for --wrap in OSX ld64 linker).
2016-07-26tests: fix a bitflag test typomoneromooo-monero1-1/+1
2016-07-26unit_tests: check adding checkpoints succeededmoneromooo-monero1-3/+3
2016-07-26db_lmdb: add some missing api call checksmoneromooo-monero1-14/+31
2016-07-26core_rpc_server: fix gray/white peer list mixupmoneromooo-monero1-1/+1
2016-07-26Merge pull request #928Riccardo Spagni8-1/+364
ebf97d7 wallet: new {ex,im}port_key_images commands and RPC calls (moneromooo-monero)
2016-07-26Merge pull request #931Riccardo Spagni1-3/+8
b3801fa hardfork: fix off by one in rescaning fork state after restart (moneromooo-monero)
2016-07-26Merge pull request #934Riccardo Spagni1-6/+17
4b3a788 cmake: install throw hook in OSX build too (redfish) 3c92c2f cmake: do not install hook on throw when building tests (redfish)
2016-07-26cmake: install throw hook in OSX build tooredfish1-0/+3
This is an attempt to fix build with STATIC=ON on OSX (#932): [ 95%] Linking CXX executable ../../bin/bitmonerod Undefined symbols for architecture x86_64: "___real___cxa_throw", referenced from: ___wrap___cxa_throw in libcommon.a(stack_trace.cpp.o) ld: symbol(s) not found for architecture x86_64
2016-07-26cmake: do not install hook on throw when building testsredfish1-6/+14
This fixes build of tests with STATIC=ON, which failed with: /tmp/cc8lNtqY.ltrans12.ltrans.o: In function `boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::thread_resource_error> >::rethrow() const [clone .lto_priv.41]': cc8lNtqY.ltrans12.o:(.text+0x4e): undefined reference to `__wrap___cxa_throw' The hook is implemented in libcommon, which is not linked into some of the test binaries. An alternative solution is to link all tests against libcommon, but that seems worse because it introduces a false dependency (also, I tried that and for some of the test binaries the linker still failed to pick up the symol from libcommon, strangely.)
2016-07-25hardfork: fix off by one in rescaning fork state after restartmoneromooo-monero1-3/+8
This code should die anyway.
2016-07-24Merge pull request #927Riccardo Spagni1-22/+4
8bed9a4 cmake: wallet: libunbound is not always static (redfish)
2016-07-24wallet: new {ex,im}port_key_images commands and RPC callsmoneromooo-monero8-1/+364
They are used to export a signed set of key images from a wallet with a private spend key, so an auditor with the matching view key may see which of those are spent, and which are not.
2016-07-23cmake: wallet: libunbound is not always staticredfish1-22/+4
It is not clear why libunbound was added to this in the first place, since it wasn't here before and #915 doesn't seem to introduce any new dependency on it. Tested build with STATIC=OFF (with and without libunbound-dev libunbound8 installed) and STATIC=ON, on Ubuntu Trusty, Debian Jessie, and Arch Linux. For static builds, beware of #926 and #907. If this hack was introduced to make it build on some other system (Windows? OS X?), then it will have to be dealt with, but not this way.
2016-07-23Merge pull request #923Riccardo Spagni1-0/+1
8312887 simplewallet: suggest removing cache when loading fails (moneromooo-monero)
2016-07-23Merge pull request #916Riccardo Spagni5-54/+243
b89b963 wallet: add unconfirmed incoming txes from the txpool (moneromooo-monero)
2016-07-23Merge pull request #915Riccardo Spagni7-75/+450
d7597c5 refreshing wallet even if error happened (Ilya Kitaev) 6d32a3d wallet_api: async init, Wallet::connected status, log level (Ilya Kitaev) 193d251 libwallet_api cmake: conditionally creating libwallet_merged2 only for STATIC build (Ilya Kitaev) 10c06dd wallet_api: segfault on refresh fixed (Ilya Kitaev) 9d2cb4f WalletListener functionality (Ilya Kitaev) d27b883 hack to successfull linking for MSYS2 (Ilya Kitaev) 083380c Transaction fee multiplier aka priority integraged (Ilya Kitaev) 00ed12b Wallet::paymentIdValid (Ilya Kitaev)
2016-07-23Merge pull request #910Riccardo Spagni1-0/+2
080a606 simplewallet: revert to foreground refresh at startup (moneromooo-monero)
2016-07-23Merge pull request #886Riccardo Spagni1-15/+22
dca9fe1 cmake: do not pass -Werror when building tests (redfish)
2016-07-23Merge pull request #920Riccardo Spagni1-0/+8
ca33ce6 include result in the notifications template (Riccardo Spagni) 2a8352d only alert on IRC when the status changes (Riccardo Spagni) 6b6fb7f add IRC notifications to travis (Riccardo Spagni)
2016-07-23include result in the notifications templateRiccardo Spagni1-1/+1
2016-07-23only alert on IRC when the status changesRiccardo Spagni1-0/+2
2016-07-23Merge pull request #924Riccardo Spagni1-1/+1
61ed40a Tests: fix signed/unsigned comparison in hash-target (anonimal)
2016-07-22cmake: do not pass -Werror when building testsredfish1-15/+22
The tests currently issue a warning that "warning: -fassociative-math disabled; other options take precedence" The associative math optimization is turned on indirectly by -Ofast. Apparently, the optimization is forced to be disabled, while compiling test harnesses generated by Google Test framework. Unfortunately, there is no -Wno-error=* flag to disable this warning (see gcc --help=warnings). An alternative to this patch is to disable the optimization explicitly with -fno-associative-math, but that seems worse. Another alternative is to not pass -Ofast for tests build, but we want the tests to be built with exact same optimization flags as the code being tested, otherwise the value of the tests is diminished. Another alternative is to remove -Werror from the entire build, but it's good to include that flag to preclude people leaving warnings. A note regarding implementation of not passing -Werror for tests: I considered filtering out -Werror from CMAKE_{C,CXX}_FLAGS but that seems to be worse because it's surprizing behavior, to those reading the code that adds -Werror. It is better to add it for when it is used and not added otherwise. I also considered relying on order, adding -Werror after inluding 'tests' subdir, but before including the other subdirs, but that also seems cryptic to the reader. So, I settled with the current solution, of explicitly setting CMAKE_{C,CXX}_FLAGS to different values before including the respective subdir. Testing done: compared compiler invocation for non-tests source files using `make VERBOSE=1` with and without this commit: the only difference is the position of -Werror. So, this commit doesn't change the binary.
2016-07-22Tests: fix signed/unsigned comparison in hash-targetanonimal1-1/+1
* References #886
2016-07-22simplewallet: suggest removing cache when loading failsmoneromooo-monero1-0/+1
2016-07-20wallet: add unconfirmed incoming txes from the txpoolmoneromooo-monero5-54/+243
Shown in show_transfers simplewallet command, and get_transfers RPC command, if req.pool is true.
2016-07-20simplewallet: revert to foreground refresh at startupmoneromooo-monero1-0/+2
Background refresh is confusing to users at startup.
2016-07-20add IRC notifications to travisRiccardo Spagni1-0/+6
2016-07-20Merge pull request #914Riccardo Spagni1-2/+2
87b1153 wallet2_api: use uint64_t for amounts (moneromooo-monero)
2016-07-20Merge pull request #919Riccardo Spagni1-7/+6
48e14ef fix atomic library to only fire off for clang (Riccardo Spagni) 39f7fad fix duplicate clang block in cmake (Riccardo Spagni)
2016-07-20Merge pull request #918Riccardo Spagni1-5/+5
b249482 Docs: fix 'Development Resources' formatting in README. (anonimal)
2016-07-20fix atomic library to only fire off for clangRiccardo Spagni1-3/+5
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-19 05:40:03 +0000