aboutsummaryrefslogtreecommitdiff
path: root/src/common
diff options
context:
space:
mode:
Diffstat (limited to 'src/common')
-rw-r--r--src/common/combinator.h1
-rw-r--r--src/common/dns_utils.cpp7
-rw-r--r--src/common/util.cpp8
-rw-r--r--src/common/util.h2
4 files changed, 8 insertions, 10 deletions
diff --git a/src/common/combinator.h b/src/common/combinator.h
index 72c6800d5..ba851bd81 100644
--- a/src/common/combinator.h
+++ b/src/common/combinator.h
@@ -32,6 +32,7 @@
#include <iostream>
#include <vector>
+#include <stdexcept>
namespace tools {
diff --git a/src/common/dns_utils.cpp b/src/common/dns_utils.cpp
index 1a1155c7c..5e03bf897 100644
--- a/src/common/dns_utils.cpp
+++ b/src/common/dns_utils.cpp
@@ -33,7 +33,7 @@
#include <stdlib.h>
#include "include_base_utils.h"
#include "common/threadpool.h"
-#include <random>
+#include "crypto/crypto.h"
#include <boost/thread/mutex.hpp>
#include <boost/algorithm/string/join.hpp>
#include <boost/optional.hpp>
@@ -517,10 +517,7 @@ bool load_txt_records_from_dns(std::vector<std::string> &good_records, const std
std::vector<std::vector<std::string> > records;
records.resize(dns_urls.size());
- std::random_device rd;
- std::mt19937 gen(rd());
- std::uniform_int_distribution<int> dis(0, dns_urls.size() - 1);
- size_t first_index = dis(gen);
+ size_t first_index = crypto::rand_idx(dns_urls.size());
// send all requests in parallel
std::deque<bool> avail(dns_urls.size(), false), valid(dns_urls.size(), false);
diff --git a/src/common/util.cpp b/src/common/util.cpp
index 728efc294..3388974ce 100644
--- a/src/common/util.cpp
+++ b/src/common/util.cpp
@@ -641,16 +641,16 @@ std::string get_nix_version_display_string()
return res;
}
- std::error_code replace_file(const std::string& replacement_name, const std::string& replaced_name)
+ std::error_code replace_file(const std::string& old_name, const std::string& new_name)
{
int code;
#if defined(WIN32)
// Maximizing chances for success
std::wstring wide_replacement_name;
- try { wide_replacement_name = string_tools::utf8_to_utf16(replacement_name); }
+ try { wide_replacement_name = string_tools::utf8_to_utf16(old_name); }
catch (...) { return std::error_code(GetLastError(), std::system_category()); }
std::wstring wide_replaced_name;
- try { wide_replaced_name = string_tools::utf8_to_utf16(replaced_name); }
+ try { wide_replaced_name = string_tools::utf8_to_utf16(new_name); }
catch (...) { return std::error_code(GetLastError(), std::system_category()); }
DWORD attributes = ::GetFileAttributesW(wide_replaced_name.c_str());
@@ -662,7 +662,7 @@ std::string get_nix_version_display_string()
bool ok = 0 != ::MoveFileExW(wide_replacement_name.c_str(), wide_replaced_name.c_str(), MOVEFILE_REPLACE_EXISTING);
code = ok ? 0 : static_cast<int>(::GetLastError());
#else
- bool ok = 0 == std::rename(replacement_name.c_str(), replaced_name.c_str());
+ bool ok = 0 == std::rename(old_name.c_str(), new_name.c_str());
code = ok ? 0 : errno;
#endif
return std::error_code(code, std::system_category());
diff --git a/src/common/util.h b/src/common/util.h
index 77a5a9af6..f6d5c9b1f 100644
--- a/src/common/util.h
+++ b/src/common/util.h
@@ -145,7 +145,7 @@ namespace tools
bool create_directories_if_necessary(const std::string& path);
/*! \brief std::rename wrapper for nix and something strange for windows.
*/
- std::error_code replace_file(const std::string& replacement_name, const std::string& replaced_name);
+ std::error_code replace_file(const std::string& old_name, const std::string& new_name);
bool sanitize_locale();