diff options
| author | jeff <jeffro256@tutanota.com> | 2023-09-21 22:33:00 -0500 |
|---|---|---|
| committer | jeff <jeffro256@tutanota.com> | 2023-09-22 09:20:56 -0500 |
| commit | 205c80427ba6f5751d1aef800f1dd00d736a3ca9 (patch) | |
| tree | e2f138f829b1d6c141de8002a6623577d65d40fe /tests/core_tests/block_reward.cpp | |
| parent | Merge pull request #8988 (diff) | |
| download | monero-205c80427ba6f5751d1aef800f1dd00d736a3ca9.tar.xz | |
wallet: store watch-only wallet correctly when `change_password()` is called
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason,
and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets.
This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0,
and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out.
This never got brought up before this because you would have to change the file location of the watch-only
wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the
new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared.
Diffstat (limited to 'tests/core_tests/block_reward.cpp')
0 files changed, 0 insertions, 0 deletions