diff options
| author | Jeffrey <jeffryan@tamu.edu> | 2022-02-19 13:49:38 -0600 |
|---|---|---|
| committer | Jeffrey <jeffryan@tamu.edu> | 2022-02-19 13:49:38 -0600 |
| commit | 9bde2dbfedf46fb40609fd9db43f5c8ee9283a9b (patch) | |
| tree | 82ce8d4499876d91a7d604e44b04d7558baa6c7e /src | |
| parent | Merge pull request #8135 (diff) | |
| download | monero-9bde2dbfedf46fb40609fd9db43f5c8ee9283a9b.tar.xz | |
Fixes: Don't require --rpc-login with --rpc-access-control-origins #8168
This PR removes the requirement for --rpc-login to be specified if --rpc-access-control-origins is.
This will allow public nodes to serve cross-origin requests. You can still use --rpc-login with
--rpc-access-control-origins, but it is no longer mandatory.
Original Issue: #8168
Diffstat (limited to 'src')
| -rw-r--r-- | src/rpc/rpc_args.cpp | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/rpc/rpc_args.cpp b/src/rpc/rpc_args.cpp index 0966fb6d2..b2d019ae7 100644 --- a/src/rpc/rpc_args.cpp +++ b/src/rpc/rpc_args.cpp @@ -247,12 +247,6 @@ namespace cryptonote auto access_control_origins_input = command_line::get_arg(vm, arg.rpc_access_control_origins); if (!access_control_origins_input.empty()) { - if (!config.login) - { - LOG_ERROR(arg.rpc_access_control_origins.name << tr(" requires RPC server password --") << arg.rpc_login.name << tr(" cannot be empty")); - return boost::none; - } - std::vector<std::string> access_control_origins; boost::split(access_control_origins, access_control_origins_input, boost::is_any_of(",")); std::for_each(access_control_origins.begin(), access_control_origins.end(), std::bind(&boost::trim<std::string>, std::placeholders::_1, std::locale::classic())); |