Merge pull request #1503

542571f5 simplewallet: remove unnecessary local_args.erase(...) in set_variable() (kenshi84)

1 files changed, 8 insertions, 24 deletions

diff --git a/src/simplewallet/simplewallet.cpp b/src/simplewallet/simplewallet.cpp
index 57d1d459d..44b9edf62 100644
--- a/src/simplewallet/simplewallet.cpp
+++ b/src/simplewallet/simplewallet.cpp
@@ -614,9 +614,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else if (args[1] == "language")
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        seed_set_language(local_args);
+        seed_set_language(args);
         return true;
       }
     }
@@ -629,9 +627,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_always_confirm_transfers(local_args);
+        set_always_confirm_transfers(args);
         return true;
       }
     }
@@ -644,9 +640,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_store_tx_info(local_args);
+        set_store_tx_info(args);
         return true;
       }
     }
@@ -659,9 +653,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_default_mixin(local_args);
+        set_default_mixin(args);
         return true;
       }
     }
@@ -674,9 +666,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_auto_refresh(local_args);
+        set_auto_refresh(args);
         return true;
       }
     }
@@ -690,9 +680,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_refresh_type(local_args);
+        set_refresh_type(args);
         return true;
       }
     }
@@ -705,9 +693,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_default_priority(local_args);
+        set_default_priority(args);
         return true;
       }
     }
@@ -720,9 +706,7 @@ bool simple_wallet::set_variable(const std::vector<std::string> &args)
       }
       else
       {
-        std::vector<std::string> local_args = args;
-        local_args.erase(local_args.begin(), local_args.begin()+2);
-        set_confirm_missing_payment_id(local_args);
+        set_confirm_missing_payment_id(args);
         return true;
       }
     }