diff options
| author | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-01-01 16:34:23 +0000 |
|---|---|---|
| committer | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-01-16 00:25:46 +0000 |
| commit | 5833d66f6540e7b34e10ddef37c2b67bd501994b (patch) | |
| tree | e4d312059948a0528583e7ea58d2c0b40307a494 /src | |
| parent | easylogging++: fix logging with static const header only data members (diff) | |
| download | monero-5833d66f6540e7b34e10ddef37c2b67bd501994b.tar.xz | |
Change logging to easylogging++
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
Diffstat (limited to 'src')
65 files changed, 785 insertions, 996 deletions
diff --git a/src/blockchain_db/blockchain_db.cpp b/src/blockchain_db/blockchain_db.cpp index 7eb81d933..a88af2fc9 100644 --- a/src/blockchain_db/blockchain_db.cpp +++ b/src/blockchain_db/blockchain_db.cpp @@ -32,6 +32,9 @@ #include "cryptonote_core/cryptonote_format_utils.h" #include "profile_tools.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "blockchain.db" + using epee::string_tools::pod_to_hex; namespace cryptonote diff --git a/src/blockchain_db/lmdb/db_lmdb.cpp b/src/blockchain_db/lmdb/db_lmdb.cpp index ca79ab4f8..343fd1fa4 100644 --- a/src/blockchain_db/lmdb/db_lmdb.cpp +++ b/src/blockchain_db/lmdb/db_lmdb.cpp @@ -38,6 +38,10 @@ #include "crypto/crypto.h" #include "profile_tools.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "blockchain.db.lmdb" + + #if defined(__i386) || defined(__x86_64) #define MISALIGNED_OK 1 #endif @@ -388,14 +392,14 @@ void BlockchainLMDB::do_resize(uint64_t increase_size) boost::filesystem::space_info si = boost::filesystem::space(path); if(si.available < add_size) { - LOG_PRINT_RED_L0("!! WARNING: Insufficient free space to extend database !!: " << si.available / 1LL << 20L); + MERROR("!! WARNING: Insufficient free space to extend database !!: " << si.available / 1LL << 20L); return; } } catch(...) { // print something but proceed. - LOG_PRINT_YELLOW("Unable to query free disk space.", LOG_LEVEL_0); + MWARNING("Unable to query free disk space."); } MDB_envinfo mei; @@ -437,7 +441,7 @@ void BlockchainLMDB::do_resize(uint64_t increase_size) if (result) throw0(DB_ERROR(lmdb_error("Failed to set new mapsize: ", result).c_str())); - LOG_PRINT_GREEN("LMDB Mapsize increased." << " Old: " << mei.me_mapsize / (1024 * 1024) << "MiB" << ", New: " << new_mapsize / (1024 * 1024) << "MiB", LOG_LEVEL_0); + MINFO("LMDB Mapsize increased." << " Old: " << mei.me_mapsize / (1024 * 1024) << "MiB" << ", New: " << new_mapsize / (1024 * 1024) << "MiB"); mdb_txn_safe::allow_new_txns(); } @@ -1168,7 +1172,7 @@ void BlockchainLMDB::open(const std::string& filename, const int mdb_flags) { if (*(const uint32_t*)v.mv_data > VERSION) { - LOG_PRINT_RED_L0("Existing lmdb database was made by a later version. We don't know how it will change yet."); + MINFO("Existing lmdb database was made by a later version. We don't know how it will change yet."); compatible = false; } #if VERSION > 0 @@ -1198,8 +1202,8 @@ void BlockchainLMDB::open(const std::string& filename, const int mdb_flags) txn.abort(); mdb_env_close(m_env); m_open = false; - LOG_PRINT_RED_L0("Existing lmdb database is incompatible with this version."); - LOG_PRINT_RED_L0("Please delete the existing database and resync."); + MFATAL("Existing lmdb database is incompatible with this version."); + MFATAL("Please delete the existing database and resync."); return; } @@ -1216,7 +1220,7 @@ void BlockchainLMDB::open(const std::string& filename, const int mdb_flags) txn.abort(); mdb_env_close(m_env); m_open = false; - LOG_PRINT_RED_L0("Failed to write version to database."); + MERROR("Failed to write version to database."); return; } } @@ -2864,7 +2868,7 @@ void BlockchainLMDB::fixup() ptr = (char *)k.mv_data; \ ptr[sizeof(name)-2] = 's' -#define LOGIF(y) if (y <= epee::log_space::log_singletone::get_log_detalisation_level()) +#define LOGIF(y) if (ELPP->vRegistry()->allowed(y, MONERO_DEFAULT_LOG_CATEGORY)) void BlockchainLMDB::migrate_0_1() { @@ -2875,8 +2879,8 @@ void BlockchainLMDB::migrate_0_1() MDB_val k, v; char *ptr; - LOG_PRINT_YELLOW("Migrating blockchain from DB version 0 to 1 - this may take a while:", LOG_LEVEL_0); - LOG_PRINT_L0("updating blocks, hf_versions, outputs, txs, and spent_keys tables..."); + MLOG_YELLOW(el::Level::Info, "Migrating blockchain from DB version 0 to 1 - this may take a while:"); + MINFO("updating blocks, hf_versions, outputs, txs, and spent_keys tables..."); do { result = mdb_txn_begin(m_env, NULL, 0, txn); @@ -2887,10 +2891,10 @@ void BlockchainLMDB::migrate_0_1() if ((result = mdb_stat(txn, m_blocks, &db_stats))) throw0(DB_ERROR(lmdb_error("Failed to query m_blocks: ", result).c_str())); m_height = db_stats.ms_entries; - LOG_PRINT_L0("Total number of blocks: " << m_height); - LOG_PRINT_L1("block migration will update block_heights, block_info, and hf_versions..."); + MINFO("Total number of blocks: " << m_height); + MINFO("block migration will update block_heights, block_info, and hf_versions..."); - LOG_PRINT_L1("migrating block_heights:"); + MINFO("migrating block_heights:"); MDB_dbi o_heights; unsigned int flags; @@ -2925,7 +2929,7 @@ void BlockchainLMDB::migrate_0_1() while(1) { if (!(i % 2000)) { if (i) { - LOGIF(1) { + LOGIF(el::Level::Info) { std::cout << i << " / " << z << " \r" << std::flush; } txn.commit(); @@ -3016,7 +3020,7 @@ void BlockchainLMDB::migrate_0_1() MDB_val k, v; if (!(i % 2000)) { if (i) { - LOGIF(1) { + LOGIF(el::Level::Info) { std::cout << i << " / " << z << " \r" << std::flush; } txn.commit(); @@ -3148,7 +3152,7 @@ void BlockchainLMDB::migrate_0_1() while(1) { if (!(i % 2000)) { if (i) { - LOGIF(1) { + LOGIF(el::Level::Info) { std::cout << i << " / " << z << " \r" << std::flush; } txn.commit(); @@ -3294,7 +3298,7 @@ void BlockchainLMDB::migrate_0_1() while(1) { if (!(i % 1000)) { if (i) { - LOGIF(1) { + LOGIF(el::Level::Info) { std::cout << i << " / " << z << " \r" << std::flush; } MDB_val_set(pk, "txblk"); diff --git a/src/blockchain_utilities/CMakeLists.txt b/src/blockchain_utilities/CMakeLists.txt index a9ece98fc..b26fe04cc 100644 --- a/src/blockchain_utilities/CMakeLists.txt +++ b/src/blockchain_utilities/CMakeLists.txt @@ -72,6 +72,7 @@ target_link_libraries(blockchain_import cryptonote_core blockchain_db p2p + epee ${Boost_FILESYSTEM_LIBRARY} ${Boost_SYSTEM_LIBRARY} ${Boost_THREAD_LIBRARY} @@ -98,6 +99,7 @@ target_link_libraries(blockchain_export cryptonote_core blockchain_db p2p + epee ${Boost_FILESYSTEM_LIBRARY} ${Boost_SYSTEM_LIBRARY} ${Boost_THREAD_LIBRARY} @@ -118,6 +120,7 @@ target_link_libraries(cn_deserialize LINK_PRIVATE cryptonote_core p2p + epee ${CMAKE_THREAD_LIBS_INIT}) add_dependencies(cn_deserialize diff --git a/src/blockchain_utilities/blockchain_export.cpp b/src/blockchain_utilities/blockchain_export.cpp index 231bea337..952855fa5 100644 --- a/src/blockchain_utilities/blockchain_export.cpp +++ b/src/blockchain_utilities/blockchain_export.cpp @@ -38,8 +38,11 @@ #include "blockchain_db/db_types.h" #include "version.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "bcutil" + namespace po = boost::program_options; -using namespace epee; // log_space +using namespace epee; std::string join_set_strings(const std::unordered_set<std::string>& db_types_all, const char* delim) { @@ -122,10 +125,8 @@ int main(int argc, char* argv[]) log_level = command_line::get_arg(vm, arg_log_level); block_stop = command_line::get_arg(vm, arg_block_stop); - log_space::get_set_log_detalisation_level(true, log_level); - log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL); + mlog_configure("", true); LOG_PRINT_L0("Starting..."); - LOG_PRINT_L0("Setting log level = " << log_level); bool opt_testnet = command_line::get_arg(vm, arg_testnet_on); bool opt_blocks_dat = command_line::get_arg(vm, arg_blocks_dat); diff --git a/src/blockchain_utilities/blockchain_import.cpp b/src/blockchain_utilities/blockchain_import.cpp index 43e2f8b45..dc8d2d8fd 100644 --- a/src/blockchain_utilities/blockchain_import.cpp +++ b/src/blockchain_utilities/blockchain_import.cpp @@ -44,6 +44,9 @@ #include "fake_core.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "bcutil" + namespace { // CONFIG @@ -132,7 +135,7 @@ int parse_db_arguments(const std::string& db_arg_str, std::string& db_type, int& #if !defined(BERKELEY_DB) if (db_type == "berkeley") { - LOG_ERROR("BerkeleyDB support disabled."); + MFATAL("BerkeleyDB support disabled."); return false; } #endif @@ -163,7 +166,7 @@ int parse_db_arguments(const std::string& db_arg_str, std::string& db_type, int& continue; if (db_type == "lmdb") { - LOG_PRINT_L1("LMDB flag: " << it); + MINFO("LMDB flag: " << it); if (it == "nosync") db_flags |= MDB_NOSYNC; else if (it == "nometasync") @@ -211,7 +214,7 @@ int pop_blocks(FakeCore& simple_core, int num_blocks) if (simple_core.support_batch) use_batch = true; else - LOG_PRINT_L0("WARNING: batch transactions enabled but unsupported or unnecessary for this database type - ignoring"); + MWARNING("WARNING: batch transactions enabled but unsupported or unnecessary for this database type - ignoring"); } if (use_batch) @@ -260,14 +263,14 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, boost::system::error_code ec; if (!boost::filesystem::exists(fs_import_file_path, ec)) { - LOG_PRINT_L0("bootstrap file not found: " << fs_import_file_path); + MFATAL("bootstrap file not found: " << fs_import_file_path); return false; } BootstrapFile bootstrap; // BootstrapFile bootstrap(import_file_path); uint64_t total_source_blocks = bootstrap.count_blocks(import_file_path); - LOG_PRINT_L0("bootstrap file last block number: " << total_source_blocks-1 << " (zero-based height) total blocks: " << total_source_blocks); + MINFO("bootstrap file last block number: " << total_source_blocks-1 << " (zero-based height) total blocks: " << total_source_blocks); std::cout << ENDL; std::cout << "Preparing to read blocks..." << ENDL; @@ -280,7 +283,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, uint64_t num_imported = 0; if (import_file.fail()) { - LOG_PRINT_L0("import_file.open() fail"); + MFATAL("import_file.open() fail"); return false; } @@ -309,7 +312,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, // These are what we'll try to use, and they don't have to be a determination // from source and destination blockchains, but those are the defaults. - LOG_PRINT_L0("start block: " << start_height << " stop block: " << + MINFO("start block: " << start_height << " stop block: " << block_stop); bool use_batch = false; @@ -318,13 +321,13 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, if (simple_core.support_batch) use_batch = true; else - LOG_PRINT_L0("WARNING: batch transactions enabled but unsupported or unnecessary for this database type - ignoring"); + MWARNING("WARNING: batch transactions enabled but unsupported or unnecessary for this database type - ignoring"); } if (use_batch) simple_core.batch_start(db_batch_size); - LOG_PRINT_L0("Reading blockchain from bootstrap file..."); + MINFO("Reading blockchain from bootstrap file..."); std::cout << ENDL; // Within the loop, we skip to start_height before we start adding. @@ -338,7 +341,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, // TODO: bootstrap.read_chunk(); if (! import_file) { std::cout << refresh_string; - LOG_PRINT_L0("End of file reached"); + MINFO("End of file reached"); quit = 1; break; } @@ -349,29 +352,29 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, { throw std::runtime_error("Error in deserialization of chunk size"); } - LOG_PRINT_L3("chunk_size: " << chunk_size); + MDEBUG("chunk_size: " << chunk_size); if (chunk_size > BUFFER_SIZE) { - LOG_PRINT_L0("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE); + MWARNING("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE); throw std::runtime_error("Aborting: chunk size exceeds buffer size"); } if (chunk_size > 100000) { - LOG_PRINT_L0("NOTE: chunk_size " << chunk_size << " > 100000"); + MINFO("NOTE: chunk_size " << chunk_size << " > 100000"); } else if (chunk_size == 0) { - LOG_PRINT_L0("ERROR: chunk_size == 0"); + MFATAL("ERROR: chunk_size == 0"); return 2; } import_file.read(buffer_block, chunk_size); if (! import_file) { - LOG_PRINT_L0("ERROR: unexpected end of file: bytes read before error: " + MFATAL("ERROR: unexpected end of file: bytes read before error: " << import_file.gcount() << " of chunk_size " << chunk_size); return 2; } bytes_read += chunk_size; - LOG_PRINT_L3("Total bytes read: " << bytes_read); + MINFO("Total bytes read: " << bytes_read); if (h + NUM_BLOCKS_PER_CHUNK < start_height + 1) { @@ -384,7 +387,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, << " / " << block_stop << std::flush; std::cout << ENDL << ENDL; - LOG_PRINT_L0("Specified block number reached - stopping. block: " << h-1 << " total blocks: " << h); + MINFO("Specified block number reached - stopping. block: " << h-1 << " total blocks: " << h); quit = 1; break; } @@ -405,14 +408,14 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, if ((h-1) % display_interval == 0) { std::cout << refresh_string; - LOG_PRINT_L0("loading block number " << h-1); + MDEBUG("loading block number " << h-1); } else { - LOG_PRINT_L3("loading block number " << h-1); + MDEBUG("loading block number " << h-1); } b = bp.block; - LOG_PRINT_L2("block prev_id: " << b.prev_id << ENDL); + MDEBUG("block prev_id: " << b.prev_id << ENDL); if ((h-1) % progress_interval == 0) { @@ -427,12 +430,12 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, archived_txs = bp.txs; // std::cout << refresh_string; - // LOG_PRINT_L1("txs: " << archived_txs.size()); + // MDEBUG("txs: " << archived_txs.size()); // if archived_txs is invalid // { // std::cout << refresh_string; - // LOG_PRINT_RED_L0("exception while de-archiving txs, height=" << h); + // MFATAL("exception while de-archiving txs, height=" << h); // quit = 1; // break; // } @@ -445,20 +448,20 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, ++tx_num; // if tx is invalid // { - // LOG_PRINT_RED_L0("exception while indexing tx from txs, height=" << h <<", tx_num=" << tx_num); + // MFATAL("exception while indexing tx from txs, height=" << h <<", tx_num=" << tx_num); // quit = 1; // break; // } // std::cout << refresh_string; - // LOG_PRINT_L1("tx hash: " << get_transaction_hash(tx)); + // MDEBUG("tx hash: " << get_transaction_hash(tx)); // crypto::hash hsh = null_hash; // size_t blob_size = 0; // NOTE: all tx hashes except for coinbase tx are available in the block data // get_transaction_hash(tx, hsh, blob_size); - // LOG_PRINT_L0("tx " << tx_num << " " << hsh << " : " << ENDL); - // LOG_PRINT_L0(obj_to_json_str(tx) << ENDL); + // MDEBUG("tx " << tx_num << " " << hsh << " : " << ENDL); + // MDEBUG(obj_to_json_str(tx) << ENDL); // add blocks with verification. // for Blockchain and blockchain_storage add_new_block(). @@ -475,7 +478,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, r = simple_core.m_pool.add_tx(tx, tvc, true, true, false, version); if (!r) { - LOG_PRINT_RED_L0("failed to add transaction to transaction pool, height=" << h <<", tx_num=" << tx_num); + MFATAL("failed to add transaction to transaction pool, height=" << h <<", tx_num=" << tx_num); quit = 1; break; } @@ -499,8 +502,8 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, if (bvc.m_verifivation_failed) { - LOG_PRINT_L0("Failed to add block to blockchain, verification failed, height = " << h); - LOG_PRINT_L0("skipping rest of file"); + MFATAL("Failed to add block to blockchain, verification failed, height = " << h); + MFATAL("skipping rest of file"); // ok to commit previously batched data because it failed only in // verification of potential new block with nothing added to batch // yet @@ -509,8 +512,8 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, } if (! bvc.m_added_to_main_chain) { - LOG_PRINT_L0("Failed to add block to blockchain, height = " << h); - LOG_PRINT_L0("skipping rest of file"); + MFATAL("Failed to add block to blockchain, height = " << h); + MFATAL("skipping rest of file"); // make sure we don't commit partial block data quit = 2; break; @@ -527,9 +530,9 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, coins_generated = bp.coins_generated; // std::cout << refresh_string; - // LOG_PRINT_L2("block_size: " << block_size); - // LOG_PRINT_L2("cumulative_difficulty: " << cumulative_difficulty); - // LOG_PRINT_L2("coins_generated: " << coins_generated); + // MDEBUG("block_size: " << block_size); + // MDEBUG("cumulative_difficulty: " << cumulative_difficulty); + // MDEBUG("coins_generated: " << coins_generated); try { @@ -538,7 +541,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, catch (const std::exception& e) { std::cout << refresh_string; - LOG_PRINT_RED_L0("Error adding block to blockchain: " << e.what()); + MFATAL("Error adding block to blockchain: " << e.what()); quit = 2; // make sure we don't commit partial block data break; } @@ -563,7 +566,7 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, catch (const std::exception& e) { std::cout << refresh_string; - LOG_PRINT_RED_L0("exception while reading from file, height=" << h << ": " << e.what()); + MFATAL("exception while reading from file, height=" << h << ": " << e.what()); return 2; } } // while @@ -582,10 +585,10 @@ int import_from_file(FakeCore& simple_core, const std::string& import_file_path, simple_core.batch_stop(); } simple_core.m_storage.get_db().show_stats(); - LOG_PRINT_L0("Number of blocks imported: " << num_imported); + MINFO("Number of blocks imported: " << num_imported); if (h > 0) // TODO: if there was an error, the last added block is probably at zero-based height h-2 - LOG_PRINT_L0("Finished at block: " << h-1 << " total blocks: " << h); + MINFO("Finished at block: " << h-1 << " total blocks: " << h); } std::cout << ENDL; return 0; @@ -602,7 +605,7 @@ int main(int argc, char* argv[]) std::string available_dbs = join_set_strings(db_types_all, ", "); available_dbs = "available: " + available_dbs; - uint32_t log_level = LOG_LEVEL_0; + uint32_t log_level = 0; uint64_t num_blocks = 0; uint64_t block_stop = 0; std::string m_config_folder; @@ -719,10 +722,8 @@ int main(int argc, char* argv[]) m_config_folder = command_line::get_arg(vm, data_dir_arg); db_arg_str = command_line::get_arg(vm, arg_database); - log_space::get_set_log_detalisation_level(true, log_level); - log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL); - LOG_PRINT_L0("Starting..."); - LOG_PRINT_L0("Setting log level = " << log_level); + mlog_configure("", true); + MINFO("Starting..."); boost::filesystem::path fs_import_file_path; @@ -767,23 +768,23 @@ int main(int argc, char* argv[]) db_engine_compiled = "memory"; } - LOG_PRINT_L0("database: " << db_type); - LOG_PRINT_L0("database flags: " << db_flags); - LOG_PRINT_L0("verify: " << std::boolalpha << opt_verify << std::noboolalpha); + MINFO("database: " << db_type); + MINFO("database flags: " << db_flags); + MINFO("verify: " << std::boolalpha << opt_verify << std::noboolalpha); if (opt_batch) { - LOG_PRINT_L0("batch: " << std::boolalpha << opt_batch << std::noboolalpha + MINFO("batch: " << std::boolalpha << opt_batch << std::noboolalpha << " batch size: " << db_batch_size); } else { - LOG_PRINT_L0("batch: " << std::boolalpha << opt_batch << std::noboolalpha); + MINFO("batch: " << std::boolalpha << opt_batch << std::noboolalpha); } - LOG_PRINT_L0("resume: " << std::boolalpha << opt_resume << std::noboolalpha); - LOG_PRINT_L0("testnet: " << std::boolalpha << opt_testnet << std::noboolalpha); + MINFO("resume: " << std::boolalpha << opt_resume << std::noboolalpha); + MINFO("testnet: " << std::boolalpha << opt_testnet << std::noboolalpha); - LOG_PRINT_L0("bootstrap file path: " << import_file_path); - LOG_PRINT_L0("database path: " << m_config_folder); + MINFO("bootstrap file path: " << import_file_path); + MINFO("database path: " << m_config_folder); try { @@ -813,15 +814,15 @@ int main(int argc, char* argv[]) if (! vm["pop-blocks"].defaulted()) { num_blocks = command_line::get_arg(vm, arg_pop_blocks); - LOG_PRINT_L0("height: " << simple_core.m_storage.get_current_blockchain_height()); + MINFO("height: " << simple_core.m_storage.get_current_blockchain_height()); pop_blocks(simple_core, num_blocks); - LOG_PRINT_L0("height: " << simple_core.m_storage.get_current_blockchain_height()); + MINFO("height: " << simple_core.m_storage.get_current_blockchain_height()); return 0; } if (! vm["drop-hard-fork"].defaulted()) { - LOG_PRINT_L0("Dropping hard fork tables..."); + MINFO("Dropping hard fork tables..."); simple_core.m_storage.get_db().drop_hard_fork_info(); return 0; } diff --git a/src/blockchain_utilities/blocksdat_file.cpp b/src/blockchain_utilities/blocksdat_file.cpp index 926562ba2..7ccb9a145 100644 --- a/src/blockchain_utilities/blocksdat_file.cpp +++ b/src/blockchain_utilities/blocksdat_file.cpp @@ -28,6 +28,8 @@ #include "blocksdat_file.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "bcutil" namespace po = boost::program_options; @@ -50,7 +52,7 @@ bool BlocksdatFile::open_writer(const boost::filesystem::path& file_path, uint64 { if (!boost::filesystem::is_directory(dir_path)) { - LOG_PRINT_RED_L0("export directory path is a file: " << dir_path); + MFATAL("export directory path is a file: " << dir_path); return false; } } @@ -58,7 +60,7 @@ bool BlocksdatFile::open_writer(const boost::filesystem::path& file_path, uint64 { if (!boost::filesystem::create_directory(dir_path)) { - LOG_PRINT_RED_L0("Failed to create directory " << dir_path); + MFATAL("Failed to create directory " << dir_path); return false; } } @@ -66,7 +68,7 @@ bool BlocksdatFile::open_writer(const boost::filesystem::path& file_path, uint64 m_raw_data_file = new std::ofstream(); - LOG_PRINT_L0("creating file"); + MINFO("creating file"); m_raw_data_file->open(file_path.string(), std::ios_base::binary | std::ios_base::out | std::ios::trunc); if (m_raw_data_file->fail()) @@ -123,21 +125,21 @@ bool BlocksdatFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem uint64_t block_start = 0; uint64_t block_stop = 0; - LOG_PRINT_L0("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1); + MINFO("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1); if ((requested_block_stop > 0) && (requested_block_stop < m_blockchain_storage->get_current_blockchain_height())) { - LOG_PRINT_L0("Using requested block height: " << requested_block_stop); + MINFO("Using requested block height: " << requested_block_stop); block_stop = requested_block_stop; } else { block_stop = m_blockchain_storage->get_current_blockchain_height() - 1; - LOG_PRINT_L0("Using block height of source blockchain: " << block_stop); + MINFO("Using block height of source blockchain: " << block_stop); } - LOG_PRINT_L0("Storing blocks raw data..."); + MINFO("Storing blocks raw data..."); if (!BlocksdatFile::open_writer(output_file, block_stop)) { - LOG_PRINT_RED_L0("failed to open raw file for write"); + MFATAL("failed to open raw file for write"); return false; } for (m_cur_height = block_start; m_cur_height <= block_stop; ++m_cur_height) @@ -157,7 +159,7 @@ bool BlocksdatFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem std::cout << refresh_string; std::cout << "block " << m_cur_height-1 << "/" << block_stop << ENDL; - LOG_PRINT_L0("Number of blocks exported: " << num_blocks_written); + MINFO("Number of blocks exported: " << num_blocks_written); return BlocksdatFile::close(); } diff --git a/src/blockchain_utilities/bootstrap_file.cpp b/src/blockchain_utilities/bootstrap_file.cpp index 61bd35a6f..add2c65e6 100644 --- a/src/blockchain_utilities/bootstrap_file.cpp +++ b/src/blockchain_utilities/bootstrap_file.cpp @@ -32,6 +32,8 @@ #include "bootstrap_file.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "bcutil" namespace po = boost::program_options; @@ -59,7 +61,7 @@ bool BootstrapFile::open_writer(const boost::filesystem::path& file_path) { if (!boost::filesystem::is_directory(dir_path)) { - LOG_PRINT_RED_L0("export directory path is a file: " << dir_path); + MFATAL("export directory path is a file: " << dir_path); return false; } } @@ -67,7 +69,7 @@ bool BootstrapFile::open_writer(const boost::filesystem::path& file_path) { if (!boost::filesystem::create_directory(dir_path)) { - LOG_PRINT_RED_L0("Failed to create directory " << dir_path); + MFATAL("Failed to create directory " << dir_path); return false; } } @@ -80,14 +82,14 @@ bool BootstrapFile::open_writer(const boost::filesystem::path& file_path) if (! boost::filesystem::exists(file_path)) { - LOG_PRINT_L0("creating file"); + MDEBUG("creating file"); do_initialize_file = true; num_blocks = 0; } else { num_blocks = count_blocks(file_path.string()); - LOG_PRINT_L0("appending to existing file with height: " << num_blocks-1 << " total blocks: " << num_blocks); + MDEBUG("appending to existing file with height: " << num_blocks-1 << " total blocks: " << num_blocks); } m_height = num_blocks; @@ -138,7 +140,7 @@ bool BootstrapFile::initialize_file() uint32_t bd_size = 0; blobdata bd = t_serializable_object_to_blob(bfi); - LOG_PRINT_L1("bootstrap::file_info size: " << bd.size()); + MDEBUG("bootstrap::file_info size: " << bd.size()); bd_size = bd.size(); if (! ::serialization::dump_binary(bd_size, blob)) @@ -149,7 +151,7 @@ bool BootstrapFile::initialize_file() *output_stream_header << bd; bd = t_serializable_object_to_blob(bbi); - LOG_PRINT_L1("bootstrap::blocks_info size: " << bd.size()); + MDEBUG("bootstrap::blocks_info size: " << bd.size()); bd_size = bd.size(); if (! ::serialization::dump_binary(bd_size, blob)) @@ -172,10 +174,10 @@ void BootstrapFile::flush_chunk() m_output_stream->flush(); uint32_t chunk_size = m_buffer.size(); - // LOG_PRINT_L0("chunk_size " << chunk_size); + // MTRACE("chunk_size " << chunk_size); if (chunk_size > BUFFER_SIZE) { - LOG_PRINT_L0("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE); + MWARNING("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE); } std::string blob; @@ -196,14 +198,14 @@ void BootstrapFile::flush_chunk() long num_chars_written = pos_after - pos_before; if (static_cast<unsigned long>(num_chars_written) != chunk_size) { - LOG_PRINT_RED_L0("Error writing chunk: height: " << m_cur_height << " chunk_size: " << chunk_size << " num chars written: " << num_chars_written); + MFATAL("Error writing chunk: height: " << m_cur_height << " chunk_size: " << chunk_size << " num chars written: " << num_chars_written); throw std::runtime_error("Error writing chunk"); } m_buffer.clear(); delete m_output_stream; m_output_stream = new boost::iostreams::stream<boost::iostreams::back_insert_device<buffer_type>>(m_buffer); - LOG_PRINT_L1("flushed chunk: chunk_size: " << chunk_size); + MDEBUG("flushed chunk: chunk_size: " << chunk_size); } void BootstrapFile::write_block(block& block) @@ -267,10 +269,10 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem m_blockchain_storage = _blockchain_storage; m_tx_pool = _tx_pool; uint64_t progress_interval = 100; - LOG_PRINT_L0("Storing blocks raw data..."); + MINFO("Storing blocks raw data..."); if (!BootstrapFile::open_writer(output_file)) { - LOG_PRINT_RED_L0("failed to open raw file for write"); + MFATAL("failed to open raw file for write"); return false; } block b; @@ -280,16 +282,16 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem // height. uint64_t block_start = m_height; uint64_t block_stop = 0; - LOG_PRINT_L0("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1); + MINFO("source blockchain height: " << m_blockchain_storage->get_current_blockchain_height()-1); if ((requested_block_stop > 0) && (requested_block_stop < m_blockchain_storage->get_current_blockchain_height())) { - LOG_PRINT_L0("Using requested block height: " << requested_block_stop); + MINFO("Using requested block height: " << requested_block_stop); block_stop = requested_block_stop; } else { block_stop = m_blockchain_storage->get_current_blockchain_height() - 1; - LOG_PRINT_L0("Using block height of source blockchain: " << block_stop); + MINFO("Using block height of source blockchain: " << block_stop); } for (m_cur_height = block_start; m_cur_height <= block_stop; ++m_cur_height) { @@ -315,9 +317,9 @@ bool BootstrapFile::store_blockchain_raw(Blockchain* _blockchain_storage, tx_mem std::cout << refresh_string; std::cout << "block " << m_cur_height-1 << "/" << block_stop << ENDL; - LOG_PRINT_L0("Number of blocks exported: " << num_blocks_written); + MINFO("Number of blocks exported: " << num_blocks_written); if (num_blocks_written > 0) - LOG_PRINT_L0("Largest chunk: " << m_max_chunk << " bytes"); + MINFO("Largest chunk: " << m_max_chunk << " bytes"); return BootstrapFile::close(); } @@ -338,11 +340,11 @@ uint64_t BootstrapFile::seek_to_first_chunk(std::ifstream& import_file) if (file_magic != blockchain_raw_magic) { - LOG_PRINT_RED_L0("bootstrap file not recognized"); + MFATAL("bootstrap file not recognized"); throw std::runtime_error("Aborting"); } else - LOG_PRINT_L0("bootstrap file recognized"); + MINFO("bootstrap file recognized"); uint32_t buflen_file_info; @@ -352,7 +354,7 @@ uint64_t BootstrapFile::seek_to_first_chunk(std::ifstream& import_file) throw std::runtime_error("Error reading expected number of bytes"); if (! ::serialization::parse_binary(str1, buflen_file_info)) throw std::runtime_error("Error in deserialization of buflen_file_info"); - LOG_PRINT_L1("bootstrap::file_info size: " << buflen_file_info); + MINFO("bootstrap::file_info size: " << buflen_file_info); if (buflen_file_info > sizeof(buf1)) throw std::runtime_error("Error: bootstrap::file_info size exceeds buffer size"); @@ -363,9 +365,9 @@ uint64_t BootstrapFile::seek_to_first_chunk(std::ifstream& import_file) bootstrap::file_info bfi; if (! ::serialization::parse_binary(str1, bfi)) throw std::runtime_error("Error in deserialization of bootstrap::file_info"); - LOG_PRINT_L0("bootstrap file v" << unsigned(bfi.major_version) << "." << unsigned(bfi.minor_version)); - LOG_PRINT_L0("bootstrap magic size: " << sizeof(file_magic)); - LOG_PRINT_L0("bootstrap header size: " << bfi.header_size); + MINFO("bootstrap file v" << unsigned(bfi.major_version) << "." << unsigned(bfi.minor_version)); + MINFO("bootstrap magic size: " << sizeof(file_magic)); + MINFO("bootstrap header size: " << bfi.header_size); uint64_t full_header_size = sizeof(file_magic) + bfi.header_size; import_file.seekg(full_header_size); @@ -379,7 +381,7 @@ uint64_t BootstrapFile::count_blocks(const std::string& import_file_path) boost::system::error_code ec; if (!boost::filesystem::exists(raw_file_path, ec)) { - LOG_PRINT_L0("bootstrap file not found: " << raw_file_path); + MFATAL("bootstrap file not found: " << raw_file_path); throw std::runtime_error("Aborting"); } std::ifstream import_file; @@ -388,14 +390,14 @@ uint64_t BootstrapFile::count_blocks(const std::string& import_file_path) uint64_t h = 0; if (import_file.fail()) { - LOG_PRINT_L0("import_file.open() fail"); + MFATAL("import_file.open() fail"); throw std::runtime_error("Aborting"); } uint64_t full_header_size; // 4 byte magic + length of header structures full_header_size = seek_to_first_chunk(import_file); - LOG_PRINT_L0("Scanning blockchain from bootstrap file..."); + MINFO("Scanning blockchain from bootstrap file..."); block b; bool quit = false; uint64_t bytes_read = 0; @@ -409,7 +411,7 @@ uint64_t BootstrapFile::count_blocks(const std::string& import_file_path) import_file.read(buf1, sizeof(chunk_size)); if (!import_file) { std::cout << refresh_string; - LOG_PRINT_L1("End of file reached"); + MDEBUG("End of file reached"); quit = true; break; } @@ -425,38 +427,38 @@ uint64_t BootstrapFile::count_blocks(const std::string& import_file_path) str1.assign(buf1, sizeof(chunk_size)); if (! ::serialization::parse_binary(str1, chunk_size)) throw std::runtime_error("Error in deserialization of chunk_size"); - LOG_PRINT_L3("chunk_size: " << chunk_size); + MDEBUG("chunk_size: " << chunk_size); if (chunk_size > BUFFER_SIZE) { std::cout << refresh_string; - LOG_PRINT_L0("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE + MWARNING("WARNING: chunk_size " << chunk_size << " > BUFFER_SIZE " << BUFFER_SIZE << " height: " << h-1); throw std::runtime_error("Aborting: chunk size exceeds buffer size"); } if (chunk_size > 100000) { std::cout << refresh_string; - LOG_PRINT_L0("NOTE: chunk_size " << chunk_size << " > 100000" << " height: " + MDEBUG("NOTE: chunk_size " << chunk_size << " > 100000" << " height: " << h-1); } else if (chunk_size <= 0) { std::cout << refresh_string; - LOG_PRINT_L0("ERROR: chunk_size " << chunk_size << " <= 0" << " height: " << h-1); + MDEBUG("ERROR: chunk_size " << chunk_size << " <= 0" << " height: " << h-1); throw std::runtime_error("Aborting"); } // skip to next expected block size value import_file.seekg(chunk_size, std::ios_base::cur); if (! import_file) { std::cout << refresh_string; - LOG_PRINT_L0("ERROR: unexpected end of file: bytes read before error: " + MFATAL("ERROR: unexpected end of file: bytes read before error: " << import_file.gcount() << " of chunk_size " << chunk_size); throw std::runtime_error("Aborting"); } bytes_read += chunk_size; // std::cout << refresh_string; - LOG_PRINT_L3("Number bytes scanned: " << bytes_read); + MINFO("Number bytes scanned: " << bytes_read); } import_file.close(); diff --git a/src/blockchain_utilities/cn_deserialize.cpp b/src/blockchain_utilities/cn_deserialize.cpp index a8448dcee..ae8e38435 100644 --- a/src/blockchain_utilities/cn_deserialize.cpp +++ b/src/blockchain_utilities/cn_deserialize.cpp @@ -33,8 +33,11 @@ #include "common/command_line.h" #include "version.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "bcutil" + namespace po = boost::program_options; -using namespace epee; // log_space +using namespace epee; using namespace cryptonote; @@ -87,8 +90,7 @@ int main(int argc, char* argv[]) return 1; } - log_space::get_set_log_detalisation_level(true, log_level); - log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL); + mlog_configure("", true); std::string m_config_folder; diff --git a/src/common/dns_utils.cpp b/src/common/dns_utils.cpp index 35fb9fe6c..2efdcffcd 100644 --- a/src/common/dns_utils.cpp +++ b/src/common/dns_utils.cpp @@ -41,6 +41,9 @@ using namespace epee; namespace bf = boost::filesystem; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.dns" + static boost::mutex instance_lock; namespace diff --git a/src/common/i18n.cpp b/src/common/i18n.cpp index c04790ce6..05eea3b66 100644 --- a/src/common/i18n.cpp +++ b/src/common/i18n.cpp @@ -36,6 +36,9 @@ #include "common/util.h" #include "common/i18n.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "i18n" + static const unsigned char qm_magic[16] = {0x3c, 0xb8, 0x64, 0x18, 0xca, 0xef, 0x9c, 0x95, 0xcd, 0x21, 0x1c, 0xbf, 0x60, 0xa1, 0xbd, 0xdd}; static std::map<std::string,std::string> i18n_entries; diff --git a/src/common/perf_timer.cpp b/src/common/perf_timer.cpp index d23c9f11d..3b68485d9 100644 --- a/src/common/perf_timer.cpp +++ b/src/common/perf_timer.cpp @@ -28,18 +28,22 @@ #include "perf_timer.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "perf" + namespace tools { -int performance_timer_log_level = 2; +el::Level performance_timer_log_level = el::Level::Debug; __thread std::vector<PerformanceTimer*> *performance_timers = NULL; -void set_performance_timer_log_level(int level) +void set_performance_timer_log_level(el::Level level) { - if (level < LOG_LEVEL_MIN || level > LOG_LEVEL_MAX) + if (level != el::Level::Debug && level != el::Level::Trace && level != el::Level::Info + && level != el::Level::Warning && level != el::Level::Error && level != el::Level::Fatal) { - LOG_PRINT_L0("Wrong log level: " << level << ", using 2"); - level = 2; + MERROR("Wrong log level: " << el::LevelHelper::convertToString(level) << ", using Debug"); + level = el::Level::Debug; } performance_timer_log_level = level; } diff --git a/src/common/perf_timer.h b/src/common/perf_timer.h index 5eb5aaaec..56662ff24 100644 --- a/src/common/perf_timer.h +++ b/src/common/perf_timer.h @@ -32,23 +32,26 @@ #include <stdio.h> #include "misc_log_ex.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "perf" + namespace tools { class PerformanceTimer; -extern int performance_timer_log_level; +extern el::Level performance_timer_log_level; extern __thread std::vector<PerformanceTimer*> *performance_timers; class PerformanceTimer { public: - PerformanceTimer(const std::string &s, int l = LOG_LEVEL_2): name(s), level(l), started(false) + PerformanceTimer(const std::string &s, el::Level l = el::Level::Debug): name(s), level(l), started(false) { ticks = epee::misc_utils::get_tick_count(); if (!performance_timers) { - LOG_PRINT("PERF ----------", level); + MLOG(level, "PERF ----------"); performance_timers = new std::vector<PerformanceTimer*>(); } else @@ -56,7 +59,7 @@ public: PerformanceTimer *pt = performance_timers->back(); if (!pt->started) { - LOG_PRINT("PERF " << std::string((performance_timers->size()-1) * 2, ' ') << " " << pt->name, pt->level); + MLOG(pt->level, "PERF " << std::string((performance_timers->size()-1) * 2, ' ') << " " << pt->name); pt->started = true; } } @@ -69,7 +72,7 @@ public: ticks = epee::misc_utils::get_tick_count() - ticks; char s[12]; snprintf(s, sizeof(s), "%8llu ", (unsigned long long)ticks); - LOG_PRINT("PERF " << s << std::string(performance_timers->size() * 2, ' ') << " " << name, level); + MLOG(level, "PERF " << s << std::string(performance_timers->size() * 2, ' ') << " " << name); if (performance_timers->empty()) { delete performance_timers; @@ -79,12 +82,12 @@ public: private: std::string name; - int level; + el::Level level; uint64_t ticks; bool started; }; -void set_performance_timer_log_level(int level); +void set_performance_timer_log_level(el::Level level); #define PERF_TIMER(name) tools::PerformanceTimer pt_##name(#name, tools::performance_timer_log_level) #define PERF_TIMER_L(name, l) tools::PerformanceTimer pt_##name(#name, l) diff --git a/src/common/scoped_message_writer.h b/src/common/scoped_message_writer.h index 77dda7181..f82181926 100644 --- a/src/common/scoped_message_writer.h +++ b/src/common/scoped_message_writer.h @@ -34,20 +34,23 @@ namespace tools { +/************************************************************************/ +/* */ +/************************************************************************/ class scoped_message_writer { private: bool m_flush; std::stringstream m_oss; - epee::log_space::console_colors m_color; + epee::console_colors m_color; bool m_bright; - int m_log_level; + el::Level m_log_level; public: scoped_message_writer( - epee::log_space::console_colors color = epee::log_space::console_color_default + epee::console_colors color = epee::console_color_default , bool bright = false , std::string&& prefix = std::string() - , int log_level = LOG_LEVEL_2 + , el::Level log_level = el::Level::Info ) : m_flush(true) , m_color(color) @@ -88,17 +91,17 @@ public: { m_flush = false; - LOG_PRINT(m_oss.str(), m_log_level); + MCLOG(m_log_level, "msgwriter", m_oss.str()); - if (epee::log_space::console_color_default == m_color) + if (epee::console_color_default == m_color) { std::cout << m_oss.str(); } else { - epee::log_space::set_console_color(m_color, m_bright); + set_console_color(m_color, m_bright); std::cout << m_oss.str(); - epee::log_space::reset_console_color(); + epee::reset_console_color(); } std::cout << std::endl; } @@ -107,17 +110,17 @@ public: inline scoped_message_writer success_msg_writer() { - return scoped_message_writer(epee::log_space::console_color_green, false, std::string(), LOG_LEVEL_2); + return scoped_message_writer(epee::console_color_green, false, std::string(), el::Level::Info); } -inline scoped_message_writer msg_writer(epee::log_space::console_colors color = epee::log_space::console_color_default) +inline scoped_message_writer msg_writer(epee::console_colors color = epee::console_color_default) { - return scoped_message_writer(color, false, std::string(), LOG_LEVEL_2); + return scoped_message_writer(color, false, std::string(), el::Level::Info); } inline scoped_message_writer fail_msg_writer() { - return scoped_message_writer(epee::log_space::console_color_red, true, "Error: ", LOG_LEVEL_0); + return scoped_message_writer(epee::console_color_red, true, "Error: ", el::Level::Error); } } // namespace tools diff --git a/src/common/stack_trace.cpp b/src/common/stack_trace.cpp index 5bbd3e252..ce05b7e04 100644 --- a/src/common/stack_trace.cpp +++ b/src/common/stack_trace.cpp @@ -35,6 +35,11 @@ #include <dlfcn.h> #endif +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "stacktrace" + +#define ST_LOG(x) CERROR(el::base::Writer,el::base::DispatchAction::FileOnlyLog,MONERO_DEFAULT_LOG_CATEGORY) << x + // from http://stackoverflow.com/questions/11665829/how-can-i-print-stack-trace-for-caught-exceptions-in-c-code-injection-in-c // The decl of __cxa_throw in /usr/include/.../cxxabi.h uses @@ -103,34 +108,34 @@ void log_stack_trace(const char *msg) const char *log = stack_trace_log.empty() ? NULL : stack_trace_log.c_str(); if (msg) - LOG_PRINT2(log, msg, LOG_LEVEL_0); - LOG_PRINT2(log, "Unwound call stack:", LOG_LEVEL_0); + ST_LOG(msg); + ST_LOG("Unwound call stack:"); if (unw_getcontext(&ctx) < 0) { - LOG_PRINT2(log, "Failed to create unwind context", LOG_LEVEL_0); + ST_LOG("Failed to create unwind context"); return; } if (unw_init_local(&cur, &ctx) < 0) { - LOG_PRINT2(log, "Failed to find the first unwind frame", LOG_LEVEL_0); + ST_LOG("Failed to find the first unwind frame"); return; } for (level = 1; level < 999; ++level) { // 999 for safety int ret = unw_step(&cur); if (ret < 0) { - LOG_PRINT2(log, "Failed to find the next frame", LOG_LEVEL_0); + ST_LOG("Failed to find the next frame"); return; } if (ret == 0) break; if (unw_get_reg(&cur, UNW_REG_IP, &ip) < 0) { - LOG_PRINT2(log, " " << std::setw(4) << level, LOG_LEVEL_0); + ST_LOG(" " << std::setw(4) << level); continue; } if (unw_get_proc_name(&cur, sym, sizeof(sym), &off) < 0) { - LOG_PRINT2(log, " " << std::setw(4) << level << std::setbase(16) << std::setw(20) << "0x" << ip, LOG_LEVEL_0); + ST_LOG(" " << std::setw(4) << level << std::setbase(16) << std::setw(20) << "0x" << ip); continue; } dsym = abi::__cxa_demangle(sym, NULL, NULL, &status); - LOG_PRINT2(log, " " << std::setw(4) << level << std::setbase(16) << std::setw(20) << "0x" << ip << " " << (!status && dsym ? dsym : sym) << " + " << "0x" << off, LOG_LEVEL_0); + ST_LOG(" " << std::setw(4) << level << std::setbase(16) << std::setw(20) << "0x" << ip << " " << (!status && dsym ? dsym : sym) << " + " << "0x" << off); free(dsym); } } diff --git a/src/common/util.h b/src/common/util.h index 501a6d487..4437d821f 100644 --- a/src/common/util.h +++ b/src/common/util.h @@ -152,7 +152,7 @@ namespace tools } else { - LOG_PRINT_RED_L0("Got control signal " << type << ". Exiting without saving..."); + MGINFO_RED("Got control signal " << type << ". Exiting without saving..."); return FALSE; } return TRUE; diff --git a/src/cryptonote_core/CMakeLists.txt b/src/cryptonote_core/CMakeLists.txt index 3b676e8ce..ad1745b7f 100644 --- a/src/cryptonote_core/CMakeLists.txt +++ b/src/cryptonote_core/CMakeLists.txt @@ -76,7 +76,6 @@ target_link_libraries(cryptonote_core PUBLIC common crypto - otshell_utils blockchain_db ringct ${Boost_DATE_TIME_LIBRARY} diff --git a/src/cryptonote_core/account.cpp b/src/cryptonote_core/account.cpp index bd703eee2..8f2db6863 100644 --- a/src/cryptonote_core/account.cpp +++ b/src/cryptonote_core/account.cpp @@ -40,6 +40,10 @@ extern "C" } #include "cryptonote_core/cryptonote_basic_impl.h" #include "cryptonote_core/cryptonote_format_utils.h" + +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "account" + using namespace std; DISABLE_VS_WARNINGS(4244 4345) diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp index 47fc26d39..8f1f0b260 100644 --- a/src/cryptonote_core/blockchain.cpp +++ b/src/cryptonote_core/blockchain.cpp @@ -56,6 +56,9 @@ #include "blocks/blocks.h" #endif +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "blockchain" + //#include "serialization/json_archive.h" /* TODO: @@ -71,6 +74,8 @@ extern "C" void slow_hash_free_state(); DISABLE_VS_WARNINGS(4267) +#define MERROR_VER(x) MCERROR("verify", x) + // used to overestimate the block reward when estimating a per kB to use #define BLOCK_REWARD_OVERESTIMATE (10 * 1000000000000) @@ -180,7 +185,7 @@ bool Blockchain::scan_outputkeys_for_indexes(size_t tx_version, const txin_to_ke } catch (...) { - LOG_PRINT_L0("Output does not exist! amount = " << tx_in_to_key.amount); + MERROR_VER("Output does not exist! amount = " << tx_in_to_key.amount); return false; } } @@ -189,7 +194,7 @@ bool Blockchain::scan_outputkeys_for_indexes(size_t tx_version, const txin_to_ke // check for partial results and add the rest if needed; if (outputs.size() < absolute_offsets.size() && outputs.size() > 0) { - LOG_PRINT_L1("Additional outputs needed: " << absolute_offsets.size() - outputs.size()); + MDEBUG("Additional outputs needed: " << absolute_offsets.size() - outputs.size()); std::vector < uint64_t > add_offsets; std::vector<output_data_t> add_outputs; for (size_t i = outputs.size(); i < absolute_offsets.size(); i++) @@ -200,7 +205,7 @@ bool Blockchain::scan_outputkeys_for_indexes(size_t tx_version, const txin_to_ke } catch (...) { - LOG_PRINT_L0("Output does not exist! amount = " << tx_in_to_key.amount); + MERROR_VER("Output does not exist! amount = " << tx_in_to_key.amount); return false; } outputs.insert(outputs.end(), add_outputs.begin(), add_outputs.end()); @@ -224,13 +229,13 @@ bool Blockchain::scan_outputkeys_for_indexes(size_t tx_version, const txin_to_ke // call to the passed boost visitor to grab the public key for the output if (!vis.handle_output(output_index.unlock_time, output_index.pubkey, output_index.commitment)) { - LOG_PRINT_L0("Failed to handle_output for output no = " << count << ", with absolute offset " << i); + MERROR_VER("Failed to handle_output for output no = " << count << ", with absolute offset " << i); return false; } } catch (...) { - LOG_PRINT_L0("Output does not exist! amount = " << tx_in_to_key.amount << ", absolute_offset = " << i); + MERROR_VER("Output does not exist! amount = " << tx_in_to_key.amount << ", absolute_offset = " << i); return false; } @@ -248,12 +253,12 @@ bool Blockchain::scan_outputkeys_for_indexes(size_t tx_version, const txin_to_ke } catch (const OUTPUT_DNE& e) { - LOG_PRINT_L0("Output does not exist: " << e.what()); + MERROR_VER("Output does not exist: " << e.what()); return false; } catch (const TX_DNE& e) { - LOG_PRINT_L0("Transaction does not exist: " << e.what()); + MERROR_VER("Transaction does not exist: " << e.what()); return false; } @@ -326,7 +331,7 @@ bool Blockchain::init(BlockchainDB* db, const bool testnet, const cryptonote::te // taking testnet into account if(!m_db->height()) { - LOG_PRINT_L0("Blockchain not loaded, generating genesis block."); + MINFO("Blockchain not loaded, generating genesis block."); block bl = boost::value_initialized<block>(); block_verification_context bvc = boost::value_initialized<block_verification_context>(); if (m_testnet) @@ -372,7 +377,7 @@ bool Blockchain::init(BlockchainDB* db, const bool testnet, const cryptonote::te load_compiled_in_block_hashes(); #endif - LOG_PRINT_GREEN("Blockchain initialized. last block: " << m_db->height() - 1 << ", " << epee::misc_utils::get_time_interval_string(timestamp_diff) << " time ago, current difficulty: " << get_difficulty_for_next_block(), LOG_LEVEL_0); + MINFO("Blockchain initialized. last block: " << m_db->height() - 1 << ", " << epee::misc_utils::get_time_interval_string(timestamp_diff) << " time ago, current difficulty: " << get_difficulty_for_next_block()); m_db->block_txn_stop(); update_next_cumulative_size_limit(); @@ -404,18 +409,18 @@ bool Blockchain::store_blockchain() } catch (const std::exception& e) { - LOG_PRINT_L0(std::string("Error syncing blockchain db: ") + e.what() + "-- shutting down now to prevent issues!"); + MERROR(std::string("Error syncing blockchain db: ") + e.what() + "-- shutting down now to prevent issues!"); throw; } catch (...) { - LOG_PRINT_L0("There was an issue storing the blockchain, shutting down now to prevent issues!"); + MERROR("There was an issue storing the blockchain, shutting down now to prevent issues!"); throw; } TIME_MEASURE_FINISH(save); if(m_show_time_stats) - LOG_PRINT_L0("Blockchain stored OK, took: " << save << " ms"); + MINFO("Blockchain stored OK, took: " << save << " ms"); return true; } //------------------------------------------------------------------ @@ -423,7 +428,7 @@ bool Blockchain::deinit() { LOG_PRINT_L3("Blockchain::" << __func__); - LOG_PRINT_L1("Stopping blockchain read/write activity"); + MTRACE("Stopping blockchain read/write activity"); // stop async service m_async_work_idle.reset(); @@ -441,7 +446,7 @@ bool Blockchain::deinit() try { m_db->close(); - LOG_PRINT_L1("Local blockchain read/write activity stopped successfully"); + MTRACE("Local blockchain read/write activity stopped successfully"); } catch (const std::exception& e) { @@ -620,12 +625,12 @@ crypto::hash Blockchain::get_block_id_by_height(uint64_t height) const } catch (const std::exception& e) { - LOG_PRINT_L0(std::string("Something went wrong fetching block hash by height: ") + e.what()); + MERROR(std::string("Something went wrong fetching block hash by height: ") + e.what()); throw; } catch (...) { - LOG_PRINT_L0(std::string("Something went wrong fetching block hash by height")); + MERROR(std::string("Something went wrong fetching block hash by height")); throw; } return null_hash; @@ -654,12 +659,12 @@ bool Blockchain::get_block_by_hash(const crypto::hash &h, block &blk) const } catch (const std::exception& e) { - LOG_PRINT_L0(std::string("Something went wrong fetching block by hash: ") + e.what()); + MERROR(std::string("Something went wrong fetching block by hash: ") + e.what()); throw; } catch (...) { - LOG_PRINT_L0(std::string("Something went wrong fetching block hash by hash")); + MERROR(std::string("Something went wrong fetching block hash by hash")); throw; } @@ -773,10 +778,10 @@ bool Blockchain::rollback_blockchain_switching(std::list<block>& original_chain, m_hardfork->reorganize_from_chain_height(rollback_height); - LOG_PRINT_L1("Rollback to height " << rollback_height << " was successful."); + MINFO("Rollback to height " << rollback_height << " was successful."); if (original_chain.size()) { - LOG_PRINT_L1("Restoration to previous blockchain successful as well."); + MINFO("Restoration to previous blockchain successful as well."); } return true; } @@ -824,7 +829,7 @@ bool Blockchain::switch_to_alternative_blockchain(std::list<blocks_ext_by_hash:: // return false if(!r || !bvc.m_added_to_main_chain) { - LOG_PRINT_L1("Failed to switch to alternative blockchain"); + MERROR("Failed to switch to alternative blockchain"); // rollback_blockchain_switching should be moved to two different // functions: rollback and apply_chain, but for now we pretend it is @@ -835,7 +840,7 @@ bool Blockchain::switch_to_alternative_blockchain(std::list<blocks_ext_by_hash:: // about them again so we can immediately dismiss them, but needs some // looking into. add_block_as_invalid(ch_ent->second, get_block_hash(ch_ent->second.bl)); - LOG_PRINT_L1("The block was inserted as invalid while connecting new alternative chain, block_id: " << get_block_hash(ch_ent->second.bl)); + MERROR("The block was inserted as invalid while connecting new alternative chain, block_id: " << get_block_hash(ch_ent->second.bl)); m_alternative_chains.erase(*alt_ch_iter++); for(auto alt_ch_to_orph_iter = alt_ch_iter; alt_ch_to_orph_iter != alt_chain.end(); ) @@ -857,7 +862,7 @@ bool Blockchain::switch_to_alternative_blockchain(std::list<blocks_ext_by_hash:: bool r = handle_alternative_block(old_ch_ent, get_block_hash(old_ch_ent), bvc); if(!r) { - LOG_PRINT_L1("Failed to push ex-main chain blocks to alternative chain "); + MERROR("Failed to push ex-main chain blocks to alternative chain "); // previously this would fail the blockchain switching, but I don't // think this is bad enough to warrant that. } @@ -872,7 +877,7 @@ bool Blockchain::switch_to_alternative_blockchain(std::list<blocks_ext_by_hash:: m_hardfork->reorganize_from_chain_height(split_height); - LOG_PRINT_GREEN("REORGANIZE SUCCESS! on height: " << split_height << ", new blockchain size: " << m_db->height(), LOG_LEVEL_0); + MGINFO_GREEN("REORGANIZE SUCCESS! on height: " << split_height << ", new blockchain size: " << m_db->height()); return true; } //------------------------------------------------------------------ @@ -953,10 +958,10 @@ bool Blockchain::prevalidate_miner_transaction(const block& b, uint64_t height) CHECK_AND_ASSERT_MES(b.miner_tx.vin[0].type() == typeid(txin_gen), false, "coinbase transaction in the block has the wrong type"); if(boost::get<txin_gen>(b.miner_tx.vin[0]).height != height) { - LOG_PRINT_RED_L1("The miner transaction in block has invalid height: " << boost::get<txin_gen>(b.miner_tx.vin[0]).height << ", expected: " << height); + MWARNING("The miner transaction in block has invalid height: " << boost::get<txin_gen>(b.miner_tx.vin[0]).height << ", expected: " << height); return false; } - LOG_PRINT_L1("Miner tx hash: " << get_transaction_hash(b.miner_tx)); + MDEBUG("Miner tx hash: " << get_transaction_hash(b.miner_tx)); CHECK_AND_ASSERT_MES(b.miner_tx.unlock_time == height + CRYPTONOTE_MINED_MONEY_UNLOCK_WINDOW, false, "coinbase transaction transaction has the wrong unlock time=" << b.miner_tx.unlock_time << ", expected " << height + CRYPTONOTE_MINED_MONEY_UNLOCK_WINDOW); //check outs overflow @@ -965,7 +970,7 @@ bool Blockchain::prevalidate_miner_transaction(const block& b, uint64_t height) // does not overflow a uint64_t, and this transaction *is* a uint64_t... if(!check_outs_overflow(b.miner_tx)) { - LOG_PRINT_RED_L1("miner transaction has money overflow in block " << get_block_hash(b)); + MERROR("miner transaction has money overflow in block " << get_block_hash(b)); return false; } @@ -985,7 +990,7 @@ bool Blockchain::validate_miner_transaction(const block& b, size_t cumulative_bl if (version == 3) { for (auto &o: b.miner_tx.vout) { if (!is_valid_decomposed_amount(o.amount)) { - LOG_PRINT_L1("miner tx output " << print_money(o.amount) << " is not a valid decomposed amount"); + MERROR_VER("miner tx output " << print_money(o.amount) << " is not a valid decomposed amount"); return false; } } @@ -995,12 +1000,12 @@ bool Blockchain::validate_miner_transaction(const block& b, size_t cumulative_bl get_last_n_blocks_sizes(last_blocks_sizes, CRYPTONOTE_REWARD_BLOCKS_WINDOW); if (!get_block_reward(epee::misc_utils::median(last_blocks_sizes), cumulative_block_size, already_generated_coins, base_reward, version)) { - LOG_PRINT_L1("block size " << cumulative_block_size << " is bigger than allowed for this blockchain"); + MERROR_VER("block size " << cumulative_block_size << " is bigger than allowed for this blockchain"); return false; } if(base_reward + fee < money_in_use) { - LOG_PRINT_L1("coinbase transaction spend too much money (" << print_money(money_in_use) << "). Block reward is " << print_money(base_reward + fee) << "(" << print_money(base_reward) << "+" << print_money(fee) << ")"); + MERROR_VER("coinbase transaction spend too much money (" << print_money(money_in_use) << "). Block reward is " << print_money(base_reward + fee) << "(" << print_money(base_reward) << "+" << print_money(fee) << ")"); return false; } // From hard fork 2, we allow a miner to claim less block reward than is allowed, in case a miner wants less dust @@ -1008,7 +1013,7 @@ bool Blockchain::validate_miner_transaction(const block& b, size_t cumulative_bl { if(base_reward + fee != money_in_use) { - LOG_PRINT_L1("coinbase transaction doesn't use full amount of block reward: spent: " << money_in_use << ", block reward " << base_reward + fee << "(" << base_reward << "+" << fee << ")"); + MDEBUG("coinbase transaction doesn't use full amount of block reward: spent: " << money_in_use << ", block reward " << base_reward + fee << "(" << base_reward << "+" << fee << ")"); return false; } } @@ -1139,7 +1144,7 @@ bool Blockchain::create_block_template(block& b, const account_public_address& m LOG_ERROR("Creating block template: error: wrongly calculated fee"); } CRITICAL_REGION_END(); - LOG_PRINT_L1("Creating block template: height " << height << + MDEBUG("Creating block template: height " << height << ", median size " << median_size << ", already generated coins " << already_generated_coins << ", transaction size " << txs_size << @@ -1157,7 +1162,7 @@ bool Blockchain::create_block_template(block& b, const account_public_address& m CHECK_AND_ASSERT_MES(r, false, "Failed to construct miner tx, first chance"); size_t cumulative_size = txs_size + get_object_blobsize(b.miner_tx); #if defined(DEBUG_CREATE_BLOCK_TEMPLATE) - LOG_PRINT_L1("Creating block template: miner tx size " << get_object_blobsize(b.miner_tx) << + MDEBUG("Creating block template: miner tx size " << get_object_blobsize(b.miner_tx) << ", cumulative size " << cumulative_size); #endif for (size_t try_count = 0; try_count != 10; ++try_count) @@ -1170,7 +1175,7 @@ bool Blockchain::create_block_template(block& b, const account_public_address& m { cumulative_size = txs_size + coinbase_blob_size; #if defined(DEBUG_CREATE_BLOCK_TEMPLATE) - LOG_PRINT_L1("Creating block template: miner tx size " << coinbase_blob_size << + MDEBUG("Creating block template: miner tx size " << coinbase_blob_size << ", cumulative size " << cumulative_size << " is greater then before"); #endif continue; @@ -1180,7 +1185,7 @@ bool Blockchain::create_block_template(block& b, const account_public_address& m { size_t delta = cumulative_size - txs_size - coinbase_blob_size; #if defined(DEBUG_CREATE_BLOCK_TEMPLATE) - LOG_PRINT_L1("Creating block template: miner tx size " << coinbase_blob_size << + MDEBUG("Creating block template: miner tx size " << coinbase_blob_size << ", cumulative size " << txs_size + coinbase_blob_size << " is less then before, adding " << delta << " zero bytes"); #endif @@ -1193,16 +1198,16 @@ bool Blockchain::create_block_template(block& b, const account_public_address& m if (cumulative_size != txs_size + get_object_blobsize(b.miner_tx)) { //fuck, not lucky, -1 makes varint-counter size smaller, in that case we continue to grow with cumulative_size - LOG_PRINT_RED("Miner tx creation has no luck with delta_extra size = " << delta << " and " << delta - 1 , LOG_LEVEL_2); + MDEBUG("Miner tx creation has no luck with delta_extra size = " << delta << " and " << delta - 1); cumulative_size += delta - 1; continue; } - LOG_PRINT_GREEN("Setting extra for block: " << b.miner_tx.extra.size() << ", try_count=" << try_count, LOG_LEVEL_1); + MDEBUG("Setting extra for block: " << b.miner_tx.extra.size() << ", try_count=" << try_count); } } CHECK_AND_ASSERT_MES(cumulative_size == txs_size + get_object_blobsize(b.miner_tx), false, "unexpected case: cumulative_size=" << cumulative_size << " is not equal txs_cumulative_size=" << txs_size << " + get_object_blobsize(b.miner_tx)=" << get_object_blobsize(b.miner_tx)); #if defined(DEBUG_CREATE_BLOCK_TEMPLATE) - LOG_PRINT_L1("Creating block template: miner tx size " << coinbase_blob_size << + MDEBUG("Creating block template: miner tx size " << coinbase_blob_size << ", cumulative size " << cumulative_size << " is now good"); #endif return true; @@ -1246,7 +1251,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id uint64_t block_height = get_block_height(b); if(0 == block_height) { - LOG_PRINT_L1("Block with id: " << epee::string_tools::pod_to_hex(id) << " (as alternative), but miner tx says height is 0."); + MERROR_VER("Block with id: " << epee::string_tools::pod_to_hex(id) << " (as alternative), but miner tx says height is 0."); bvc.m_verifivation_failed = true; return false; } @@ -1256,7 +1261,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id // the block to be added, then this is fine. if (!m_checkpoints.is_alternative_block_allowed(get_current_blockchain_height(), block_height)) { - LOG_PRINT_RED_L1("Block with id: " << id << std::endl << " can't be accepted for alternative chain, block height: " << block_height << std::endl << " blockchain height: " << get_current_blockchain_height()); + MERROR_VER("Block with id: " << id << std::endl << " can't be accepted for alternative chain, block height: " << block_height << std::endl << " blockchain height: " << get_current_blockchain_height()); bvc.m_verifivation_failed = true; return false; } @@ -1299,7 +1304,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id // this alternate chain with it. if (!m_db->block_exists(alt_chain.front()->second.bl.prev_id)) { - LOG_PRINT_L1("alternate chain does not appear to connect to main chain..."); + MERROR("alternate chain does not appear to connect to main chain..."); return false; } @@ -1322,7 +1327,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id // (not earlier than the median of the last X blocks) if(!check_block_timestamp(timestamps, b)) { - LOG_PRINT_RED_L1("Block with id: " << id << std::endl << " for alternative chain, has invalid timestamp: " << b.timestamp); + MERROR_VER("Block with id: " << id << std::endl << " for alternative chain, has invalid timestamp: " << b.timestamp); bvc.m_verifivation_failed = true; return false; } @@ -1348,14 +1353,14 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id get_block_longhash(bei.bl, proof_of_work, bei.height); if(!check_hash(proof_of_work, current_diff)) { - LOG_PRINT_RED_L1("Block with id: " << id << std::endl << " for alternative chain, does not have enough proof of work: " << proof_of_work << std::endl << " expected difficulty: " << current_diff); + MERROR_VER("Block with id: " << id << std::endl << " for alternative chain, does not have enough proof of work: " << proof_of_work << std::endl << " expected difficulty: " << current_diff); bvc.m_verifivation_failed = true; return false; } if(!prevalidate_miner_transaction(b, bei.height)) { - LOG_PRINT_RED_L1("Block with id: " << epee::string_tools::pod_to_hex(id) << " (as alternative) has incorrect miner transaction."); + MERROR_VER("Block with id: " << epee::string_tools::pod_to_hex(id) << " (as alternative) has incorrect miner transaction."); bvc.m_verifivation_failed = true; return false; } @@ -1385,7 +1390,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id if(is_a_checkpoint) { //do reorganize! - LOG_PRINT_GREEN("###### REORGANIZE on height: " << alt_chain.front()->second.height << " of " << m_db->height() - 1 << ", checkpoint is found in alternative chain on height " << bei.height, LOG_LEVEL_0); + MGINFO_GREEN("###### REORGANIZE on height: " << alt_chain.front()->second.height << " of " << m_db->height() - 1 << ", checkpoint is found in alternative chain on height " << bei.height); bool r = switch_to_alternative_blockchain(alt_chain, true); @@ -1397,7 +1402,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id else if(main_chain_cumulative_difficulty < bei.cumulative_difficulty) //check if difficulty bigger then in main chain { //do reorganize! - LOG_PRINT_GREEN("###### REORGANIZE on height: " << alt_chain.front()->second.height << " of " << m_db->height() - 1 << " with cum_difficulty " << m_db->get_block_cumulative_difficulty(m_db->height() - 1) << std::endl << " alternative blockchain size: " << alt_chain.size() << " with cum_difficulty " << bei.cumulative_difficulty, LOG_LEVEL_0); + MGINFO_GREEN("###### REORGANIZE on height: " << alt_chain.front()->second.height << " of " << m_db->height() - 1 << " with cum_difficulty " << m_db->get_block_cumulative_difficulty(m_db->height() - 1) << std::endl << " alternative blockchain size: " << alt_chain.size() << " with cum_difficulty " << bei.cumulative_difficulty); bool r = switch_to_alternative_blockchain(alt_chain, false); if (r) @@ -1408,7 +1413,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id } else { - LOG_PRINT_BLUE("----- BLOCK ADDED AS ALTERNATIVE ON HEIGHT " << bei.height << std::endl << "id:\t" << id << std::endl << "PoW:\t" << proof_of_work << std::endl << "difficulty:\t" << current_diff, LOG_LEVEL_0); + MGINFO_BLUE("----- BLOCK ADDED AS ALTERNATIVE ON HEIGHT " << bei.height << std::endl << "id:\t" << id << std::endl << "PoW:\t" << proof_of_work << std::endl << "difficulty:\t" << current_diff); return true; } } @@ -1416,7 +1421,7 @@ bool Blockchain::handle_alternative_block(const block& b, const crypto::hash& id { //block orphaned bvc.m_marked_as_orphaned = true; - LOG_PRINT_RED_L1("Block recognized as orphaned and rejected, id = " << id); + MERROR_VER("Block recognized as orphaned and rejected, id = " << id); } return true; @@ -1805,7 +1810,7 @@ bool Blockchain::find_blockchain_supplement(const std::list<crypto::hash>& qbloc // how can we expect to sync from the client that the block list came from? if(!qblock_ids.size() /*|| !req.m_total_height*/) { - LOG_PRINT_L1("Client sent wrong NOTIFY_REQUEST_CHAIN: m_block_ids.size()=" << qblock_ids.size() << /*", m_height=" << req.m_total_height <<*/ ", dropping connection"); + MCERROR("net.p2p", "Client sent wrong NOTIFY_REQUEST_CHAIN: m_block_ids.size()=" << qblock_ids.size() << /*", m_height=" << req.m_total_height <<*/ ", dropping connection"); return false; } @@ -1815,7 +1820,7 @@ bool Blockchain::find_blockchain_supplement(const std::list<crypto::hash>& qbloc auto gen_hash = m_db->get_block_hash_from_height(0); if(qblock_ids.back() != gen_hash) { - LOG_PRINT_L1("Client sent wrong NOTIFY_REQUEST_CHAIN: genesis block mismatch: " << std::endl << "id: " << qblock_ids.back() << ", " << std::endl << "expected: " << gen_hash << "," << std::endl << " dropping connection"); + MCERROR("net.p2p", "Client sent wrong NOTIFY_REQUEST_CHAIN: genesis block mismatch: " << std::endl << "id: " << qblock_ids.back() << ", " << std::endl << "expected: " << gen_hash << "," << std::endl << " dropping connection"); m_db->block_txn_abort(); return false; } @@ -1833,7 +1838,7 @@ bool Blockchain::find_blockchain_supplement(const std::list<crypto::hash>& qbloc } catch (const std::exception& e) { - LOG_PRINT_L1("Non-critical error trying to find block by hash in BlockchainDB, hash: " << *bl_it); + MWARNING("Non-critical error trying to find block by hash in BlockchainDB, hash: " << *bl_it); m_db->block_txn_abort(); return false; } @@ -1844,7 +1849,7 @@ bool Blockchain::find_blockchain_supplement(const std::list<crypto::hash>& qbloc // but just in case... if(bl_it == qblock_ids.end()) { - LOG_PRINT_L1("Internal error handling connection, can't find split point"); + MERROR("Internal error handling connection, can't find split point"); return false; } @@ -1863,7 +1868,7 @@ uint64_t Blockchain::block_difficulty(uint64_t i) const } catch (const BLOCK_DNE& e) { - LOG_PRINT_L0("Attempted to get block difficulty for height above blockchain height"); + MERROR("Attempted to get block difficulty for height above blockchain height"); } return 0; } @@ -1928,7 +1933,7 @@ void Blockchain::print_blockchain(uint64_t start_index, uint64_t end_index) cons auto h = m_db->height(); if(start_index > h) { - LOG_PRINT_L1("Wrong starter index set: " << start_index << ", expected max index " << h); + MERROR("Wrong starter index set: " << start_index << ", expected max index " << h); return; } @@ -1936,8 +1941,7 @@ void Blockchain::print_blockchain(uint64_t start_index, uint64_t end_index) cons { ss << "height " << i << ", timestamp " << m_db->get_block_timestamp(i) << ", cumul_dif " << m_db->get_block_cumulative_difficulty(i) << ", size " << m_db->get_block_size(i) << "\nid\t\t" << m_db->get_block_hash_from_height(i) << "\ndifficulty\t\t" << m_db->get_block_difficulty(i) << ", nonce " << m_db->get_block_from_height(i).nonce << ", tx_count " << m_db->get_block_from_height(i).tx_hashes.size() << std::endl; } - LOG_PRINT_L1("Current blockchain:" << std::endl << ss.str()); - LOG_PRINT_L0("Blockchain printed with log level 1"); + MCINFO("globlal", "Current blockchain:" << std::endl << ss.str()); } //------------------------------------------------------------------ void Blockchain::print_blockchain_index() const @@ -1954,7 +1958,7 @@ void Blockchain::print_blockchain_index() const } } - LOG_PRINT_L0("Current blockchain index:" << std::endl << ss.str()); + MINFO("Current blockchain index:" << std::endl << ss.str()); } //------------------------------------------------------------------ //TODO: remove this function and references to it @@ -2041,7 +2045,7 @@ bool Blockchain::add_block_as_invalid(const block_extended_info& bei, const cryp CRITICAL_REGION_LOCAL(m_blockchain_lock); auto i_res = m_invalid_blocks.insert(std::map<crypto::hash, block_extended_info>::value_type(h, bei)); CHECK_AND_ASSERT_MES(i_res.second, false, "at insertion invalid by tx returned status existed"); - LOG_PRINT_L1("BLOCK ADDED AS INVALID: " << h << std::endl << ", prev_id=" << bei.bl.prev_id << ", m_invalid_blocks count=" << m_invalid_blocks.size()); + MINFO("BLOCK ADDED AS INVALID: " << h << std::endl << ", prev_id=" << bei.bl.prev_id << ", m_invalid_blocks count=" << m_invalid_blocks.size()); return true; } //------------------------------------------------------------------ @@ -2158,7 +2162,7 @@ bool Blockchain::get_tx_outputs_gindexs(const crypto::hash& tx_id, std::vector<u uint64_t tx_index; if (!m_db->tx_exists(tx_id, tx_index)) { - LOG_PRINT_RED_L1("warning: get_tx_outputs_gindexs failed to find transaction with id = " << tx_id); + MERROR_VER("get_tx_outputs_gindexs failed to find transaction with id = " << tx_id); return false; } @@ -2200,7 +2204,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, uint64_t& max_used_block_heigh if(m_show_time_stats) { size_t mixin = tx.vin[0].type() == typeid(txin_to_key) ? boost::get<txin_to_key>(tx.vin[0]).key_offsets.size() - 1 : 0; - LOG_PRINT_L0("HASH: " << "-" << " I/M/O: " << tx.vin.size() << "/" << mixin << "/" << tx.vout.size() << " H: " << 0 << " chcktx: " << a); + MINFO("HASH: " << "-" << " I/M/O: " << tx.vin.size() << "/" << mixin << "/" << tx.vout.size() << " H: " << 0 << " chcktx: " << a); } return true; } @@ -2212,7 +2216,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, uint64_t& max_used_block_heigh if(m_show_time_stats) { size_t mixin = tx.vin[0].type() == typeid(txin_to_key) ? boost::get<txin_to_key>(tx.vin[0]).key_offsets.size() - 1 : 0; - LOG_PRINT_L0("HASH: " << get_transaction_hash(tx) << " I/M/O: " << tx.vin.size() << "/" << mixin << "/" << tx.vout.size() << " H: " << max_used_block_height << " ms: " << a + m_fake_scan_time << " B: " << get_object_blobsize(tx)); + MINFO("HASH: " << get_transaction_hash(tx) << " I/M/O: " << tx.vin.size() << "/" << mixin << "/" << tx.vout.size() << " H: " << max_used_block_height << " ms: " << a + m_fake_scan_time << " B: " << get_object_blobsize(tx)); } if (!res) return false; @@ -2388,7 +2392,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, else { uint64_t n_outputs = m_db->get_num_outputs(in_to_key.amount); - LOG_PRINT_L2("output size " << print_money(in_to_key.amount) << ": " << n_outputs << " available"); + MDEBUG("output size " << print_money(in_to_key.amount) << ": " << n_outputs << " available"); // n_outputs includes the output we're considering if (n_outputs <= min_mixin) ++n_unmixable; @@ -2404,13 +2408,13 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if (n_unmixable == 0) { - LOG_PRINT_L1("Tx " << get_transaction_hash(tx) << " has too low mixin (" << mixin << "), and no unmixable inputs"); + MERROR_VER("Tx " << get_transaction_hash(tx) << " has too low mixin (" << mixin << "), and no unmixable inputs"); tvc.m_low_mixin = true; return false; } if (n_mixable > 1) { - LOG_PRINT_L1("Tx " << get_transaction_hash(tx) << " has too low mixin (" << mixin << "), and more than one mixable input with unmixable inputs"); + MERROR_VER("Tx " << get_transaction_hash(tx) << " has too low mixin (" << mixin << "), and more than one mixable input with unmixable inputs"); tvc.m_low_mixin = true; return false; } @@ -2420,14 +2424,14 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, const size_t max_tx_version = (hf_version <= 3) ? 1 : 2; if (tx.version > max_tx_version) { - LOG_PRINT_L1("transaction version " << (unsigned)tx.version << " is higher than max accepted version " << max_tx_version); + MERROR_VER("transaction version " << (unsigned)tx.version << " is higher than max accepted version " << max_tx_version); tvc.m_verifivation_failed = true; return false; } const size_t min_tx_version = (n_unmixable > 0 ? 1 : (hf_version >= 5) ? 2 : 1); if (tx.version < min_tx_version) { - LOG_PRINT_L1("transaction version " << (unsigned)tx.version << " is lower than min accepted version " << min_tx_version); + MERROR_VER("transaction version " << (unsigned)tx.version << " is lower than min accepted version " << min_tx_version); tvc.m_verifivation_failed = true; return false; } @@ -2486,7 +2490,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if(have_tx_keyimg_as_spent(in_to_key.k_image)) { - LOG_PRINT_L1("Key image already spent in blockchain: " << epee::string_tools::pod_to_hex(in_to_key.k_image)); + MERROR_VER("Key image already spent in blockchain: " << epee::string_tools::pod_to_hex(in_to_key.k_image)); tvc.m_double_spend = true; return false; } @@ -2502,7 +2506,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if(!itk->second) { - LOG_PRINT_L1("Failed ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); + MERROR_VER("Failed ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); return false; } @@ -2518,10 +2522,10 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if (!check_tx_input(tx.version, in_to_key, tx_prefix_hash, tx.version == 1 ? tx.signatures[sig_index] : std::vector<crypto::signature>(), tx.rct_signatures, pubkeys[sig_index], pmax_used_block_height)) { it->second[in_to_key.k_image] = false; - LOG_PRINT_L1("Failed to check ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); + MERROR_VER("Failed to check ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); if (pmax_used_block_height) // a default value of NULL is used when called from Blockchain::handle_block_to_main_chain() { - LOG_PRINT_L1(" *pmax_used_block_height: " << *pmax_used_block_height); + MERROR_VER(" *pmax_used_block_height: " << *pmax_used_block_height); } return false; @@ -2541,11 +2545,11 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if (!results[sig_index]) { it->second[in_to_key.k_image] = false; - LOG_PRINT_L1("Failed to check ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); + MERROR_VER("Failed to check ring signature for tx " << get_transaction_hash(tx) << " vin key with k_image: " << in_to_key.k_image << " sig_index: " << sig_index); if (pmax_used_block_height) // a default value of NULL is used when called from Blockchain::handle_block_to_main_chain() { - LOG_PRINT_L1("*pmax_used_block_height: " << *pmax_used_block_height); + MERROR_VER("*pmax_used_block_height: " << *pmax_used_block_height); } return false; @@ -2575,7 +2579,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if (failed) { - LOG_PRINT_L1("Failed to check ring signatures!, t_loop: " << t_t1); + MERROR_VER("Failed to check ring signatures!, t_loop: " << t_t1); return false; } } @@ -2584,7 +2588,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if (!expand_transaction_2(tx, tx_prefix_hash, pubkeys)) { - LOG_PRINT_L1("Failed to expand rct signatures!"); + MERROR_VER("Failed to expand rct signatures!"); return false; } @@ -2596,7 +2600,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { case rct::RCTTypeNull: { // we only accept no signatures for coinbase txes - LOG_PRINT_L1("Null rct signature on non-coinbase tx"); + MERROR_VER("Null rct signature on non-coinbase tx"); return false; } case rct::RCTTypeSimple: { @@ -2604,14 +2608,14 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if (pubkeys.size() != rv.mixRing.size()) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); + MERROR_VER("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); return false; } for (size_t i = 0; i < pubkeys.size(); ++i) { if (pubkeys[i].size() != rv.mixRing[i].size()) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); + MERROR_VER("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); return false; } } @@ -2622,12 +2626,12 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if (pubkeys[n][m].dest != rct::rct2pk(rv.mixRing[n][m].dest)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched pubkey at vin " << n << ", index " << m); + MERROR_VER("Failed to check ringct signatures: mismatched pubkey at vin " << n << ", index " << m); return false; } if (pubkeys[n][m].mask != rct::rct2pk(rv.mixRing[n][m].mask)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched commitment at vin " << n << ", index " << m); + MERROR_VER("Failed to check ringct signatures: mismatched commitment at vin " << n << ", index " << m); return false; } } @@ -2636,21 +2640,21 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if (rv.p.MGs.size() != tx.vin.size()) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched MGs/vin sizes"); + MERROR_VER("Failed to check ringct signatures: mismatched MGs/vin sizes"); return false; } for (size_t n = 0; n < tx.vin.size(); ++n) { if (memcmp(&boost::get<txin_to_key>(tx.vin[n]).k_image, &rv.p.MGs[n].II[0], 32)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched key image"); + MERROR_VER("Failed to check ringct signatures: mismatched key image"); return false; } } if (!rct::verRctSimple(rv, false)) { - LOG_PRINT_L1("Failed to check ringct signatures!"); + MERROR_VER("Failed to check ringct signatures!"); return false; } break; @@ -2665,7 +2669,7 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, size_matches &= pubkeys.size() == rv.mixRing[i].size(); if (!size_matches) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); + MERROR_VER("Failed to check ringct signatures: mismatched pubkeys/mixRing size"); return false; } @@ -2675,12 +2679,12 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, { if (pubkeys[n][m].dest != rct::rct2pk(rv.mixRing[m][n].dest)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched pubkey at vin " << n << ", index " << m); + MERROR_VER("Failed to check ringct signatures: mismatched pubkey at vin " << n << ", index " << m); return false; } if (pubkeys[n][m].mask != rct::rct2pk(rv.mixRing[m][n].mask)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched commitment at vin " << n << ", index " << m); + MERROR_VER("Failed to check ringct signatures: mismatched commitment at vin " << n << ", index " << m); return false; } } @@ -2689,32 +2693,32 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if (rv.p.MGs.size() != 1) { - LOG_PRINT_L1("Failed to check ringct signatures: Bad MGs size"); + MERROR_VER("Failed to check ringct signatures: Bad MGs size"); return false; } if (rv.p.MGs[0].II.size() != tx.vin.size()) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched II/vin sizes"); + MERROR_VER("Failed to check ringct signatures: mismatched II/vin sizes"); return false; } for (size_t n = 0; n < tx.vin.size(); ++n) { if (memcmp(&boost::get<txin_to_key>(tx.vin[n]).k_image, &rv.p.MGs[0].II[n], 32)) { - LOG_PRINT_L1("Failed to check ringct signatures: mismatched II/vin sizes"); + MERROR_VER("Failed to check ringct signatures: mismatched II/vin sizes"); return false; } } if (!rct::verRct(rv, false)) { - LOG_PRINT_L1("Failed to check ringct signatures!"); + MERROR_VER("Failed to check ringct signatures!"); return false; } break; } default: - LOG_PRINT_L1("Unsupported rct type: " << rv.type); + MERROR_VER("Unsupported rct type: " << rv.type); return false; } } @@ -2777,7 +2781,7 @@ bool Blockchain::check_fee(size_t blob_size, uint64_t fee) const return false; fee_per_kb = get_dynamic_per_kb_fee(base_reward, median); } - LOG_PRINT_L2("Using " << print_money(fee) << "/kB fee"); + MDEBUG("Using " << print_money(fee) << "/kB fee"); uint64_t needed_fee = blob_size / 1024; needed_fee += (blob_size % 1024) ? 1 : 0; @@ -2785,7 +2789,7 @@ bool Blockchain::check_fee(size_t blob_size, uint64_t fee) const if (fee < needed_fee) { - LOG_PRINT_L1("transaction fee is not enough: " << print_money(fee) << ", minimum fee: " << print_money(needed_fee)); + MERROR_VER("transaction fee is not enough: " << print_money(fee) << ", minimum fee: " << print_money(needed_fee)); return false; } return true; @@ -2815,12 +2819,12 @@ uint64_t Blockchain::get_dynamic_per_kb_fee_estimate(uint64_t grace_blocks) cons uint64_t base_reward; if (!get_block_reward(median, 1, already_generated_coins, base_reward, version)) { - LOG_PRINT_L1("Failed to determine block reward, using placeholder " << print_money(BLOCK_REWARD_OVERESTIMATE) << " as a high bound"); + MERROR("Failed to determine block reward, using placeholder " << print_money(BLOCK_REWARD_OVERESTIMATE) << " as a high bound"); base_reward = BLOCK_REWARD_OVERESTIMATE; } uint64_t fee = get_dynamic_per_kb_fee(base_reward, median); - LOG_PRINT_L2("Estimating " << grace_blocks << "-block fee at " << print_money(fee) << "/kB"); + MDEBUG("Estimating " << grace_blocks << "-block fee at " << print_money(fee) << "/kB"); return fee; } @@ -2875,7 +2879,7 @@ bool Blockchain::check_tx_input(size_t tx_version, const txin_to_key& txin, cons //check tx unlock time if (!m_bch.is_tx_spendtime_unlocked(unlock_time)) { - LOG_PRINT_L1("One of outputs for one of inputs has wrong tx.unlock_time = " << unlock_time); + MERROR_VER("One of outputs for one of inputs has wrong tx.unlock_time = " << unlock_time); return false; } @@ -2895,13 +2899,13 @@ bool Blockchain::check_tx_input(size_t tx_version, const txin_to_key& txin, cons outputs_visitor vi(output_keys, *this); if (!scan_outputkeys_for_indexes(tx_version, txin, vi, tx_prefix_hash, pmax_related_block_height)) { - LOG_PRINT_L1("Failed to get output keys for tx with amount = " << print_money(txin.amount) << " and count indexes " << txin.key_offsets.size()); + MERROR_VER("Failed to get output keys for tx with amount = " << print_money(txin.amount) << " and count indexes " << txin.key_offsets.size()); return false; } if(txin.key_offsets.size() != output_keys.size()) { - LOG_PRINT_L1("Output keys for tx with amount = " << txin.amount << " and count indexes " << txin.key_offsets.size() << " returned wrong keys count " << output_keys.size()); + MERROR_VER("Output keys for tx with amount = " << txin.amount << " and count indexes " << txin.key_offsets.size() << " returned wrong keys count " << output_keys.size()); return false; } if (tx_version == 1) { @@ -2927,7 +2931,7 @@ bool Blockchain::check_block_timestamp(std::vector<uint64_t>& timestamps, const if(b.timestamp < median_ts) { - LOG_PRINT_L1("Timestamp of block with id: " << get_block_hash(b) << ", " << b.timestamp << ", less than median of last " << BLOCKCHAIN_TIMESTAMP_CHECK_WINDOW << " blocks, " << median_ts); + MERROR_VER("Timestamp of block with id: " << get_block_hash(b) << ", " << b.timestamp << ", less than median of last " << BLOCKCHAIN_TIMESTAMP_CHECK_WINDOW << " blocks, " << median_ts); return false; } @@ -2946,7 +2950,7 @@ bool Blockchain::check_block_timestamp(const block& b) const LOG_PRINT_L3("Blockchain::" << __func__); if(b.timestamp > get_adjusted_time() + CRYPTONOTE_BLOCK_FUTURE_TIME_LIMIT) { - LOG_PRINT_L1("Timestamp of block with id: " << get_block_hash(b) << ", " << b.timestamp << ", bigger than adjusted time + 2 hours"); + MERROR_VER("Timestamp of block with id: " << get_block_hash(b) << ", " << b.timestamp << ", bigger than adjusted time + 2 hours"); return false; } @@ -2982,7 +2986,7 @@ void Blockchain::return_tx_to_pool(const std::vector<transaction> &txs) // all the transactions in a popped block when a reorg happens. if (!m_tx_pool.add_tx(tx, tvc, true, true, false, version)) { - LOG_PRINT_L0("Failed to return taken transaction with hash: " << get_transaction_hash(tx) << " to tx_pool"); + MERROR("Failed to return taken transaction with hash: " << get_transaction_hash(tx) << " to tx_pool"); } } } @@ -2998,10 +3002,10 @@ bool Blockchain::flush_txes_from_pool(const std::list<crypto::hash> &txids) size_t blob_size; uint64_t fee; bool relayed, do_not_relay; - LOG_PRINT_L1("Removing txid " << txid << " from the pool"); + MINFO("Removing txid " << txid << " from the pool"); if(m_tx_pool.have_tx(txid) && !m_tx_pool.take_tx(txid, tx, blob_size, fee, relayed, do_not_relay)) { - LOG_PRINT_L0("Failed to remove txid " << txid << " from the pool"); + MERROR("Failed to remove txid " << txid << " from the pool"); res = false; } } @@ -3022,7 +3026,7 @@ bool Blockchain::handle_block_to_main_chain(const block& bl, const crypto::hash& m_db->block_txn_start(true); if(bl.prev_id != get_tail_id()) { - LOG_PRINT_L1("Block with id: " << id << std::endl << "has wrong prev_id: " << bl.prev_id << std::endl << "expected: " << get_tail_id()); + MERROR_VER("Block with id: " << id << std::endl << "has wrong prev_id: " << bl.prev_id << std::endl << "expected: " << get_tail_id()); leave: m_db->block_txn_stop(); return false; @@ -3031,7 +3035,7 @@ leave: // this is a cheap test if (!m_hardfork->check(bl)) { - LOG_PRINT_L1("Block with id: " << id << std::endl << "has old version: " << (unsigned)bl.major_version << std::endl << "current: " << (unsigned)m_hardfork->get_current_version()); + MERROR_VER("Block with id: " << id << std::endl << "has old version: " << (unsigned)bl.major_version << std::endl << "current: " << (unsigned)m_hardfork->get_current_version()); bvc.m_verifivation_failed = true; goto leave; } @@ -3043,7 +3047,7 @@ leave: // of a set number of the most recent blocks. if(!check_block_timestamp(bl)) { - LOG_PRINT_L1("Block with id: " << id << std::endl << "has invalid timestamp: " << bl.timestamp); + MERROR_VER("Block with id: " << id << std::endl << "has invalid timestamp: " << bl.timestamp); bvc.m_verifivation_failed = true; goto leave; } @@ -3083,7 +3087,7 @@ leave: auto hash = get_block_hash(bl); if (memcmp(&hash, &m_blocks_hash_check[m_db->height()], sizeof(hash)) != 0) { - LOG_PRINT_L1("Block with id is INVALID: " << id); + MERROR_VER("Block with id is INVALID: " << id); bvc.m_verifivation_failed = true; goto leave; } @@ -3104,7 +3108,7 @@ leave: // validate proof_of_work versus difficulty target if(!check_hash(proof_of_work, current_diffic)) { - LOG_PRINT_L1("Block with id: " << id << std::endl << "does not have enough proof of work: " << proof_of_work << std::endl << "unexpected difficulty: " << current_diffic); + MERROR_VER("Block with id: " << id << std::endl << "does not have enough proof of work: " << proof_of_work << std::endl << "unexpected difficulty: " << current_diffic); bvc.m_verifivation_failed = true; goto leave; } @@ -3131,7 +3135,7 @@ leave: // sanity check basic miner tx properties; if(!prevalidate_miner_transaction(bl, m_db->height())) { - LOG_PRINT_L1("Block with id: " << id << " failed to pass prevalidation"); + MERROR_VER("Block with id: " << id << " failed to pass prevalidation"); bvc.m_verifivation_failed = true; goto leave; } @@ -3166,7 +3170,7 @@ leave: // XXX old code does not check whether tx exists if (m_db->tx_exists(tx_id)) { - LOG_PRINT_L1("Block with id: " << id << " attempting to add transaction already in blockchain with id: " << tx_id); + MERROR("Block with id: " << id << " attempting to add transaction already in blockchain with id: " << tx_id); bvc.m_verifivation_failed = true; return_tx_to_pool(txs); goto leave; @@ -3179,7 +3183,7 @@ leave: // get transaction with hash <tx_id> from tx_pool if(!m_tx_pool.take_tx(tx_id, tx, blob_size, fee, relayed, do_not_relay)) { - LOG_PRINT_L1("Block with id: " << id << " has at least one unknown transaction with id: " << tx_id); + MERROR_VER("Block with id: " << id << " has at least one unknown transaction with id: " << tx_id); bvc.m_verifivation_failed = true; return_tx_to_pool(txs); goto leave; @@ -3218,11 +3222,11 @@ leave: tx_verification_context tvc; if(!check_tx_inputs(tx, tvc)) { - LOG_PRINT_L1("Block with id: " << id << " has at least one transaction (id: " << tx_id << ") with wrong inputs."); + MERROR_VER("Block with id: " << id << " has at least one transaction (id: " << tx_id << ") with wrong inputs."); //TODO: why is this done? make sure that keeping invalid blocks makes sense. add_block_as_invalid(bl, id); - LOG_PRINT_L1("Block with id " << id << " added as invalid because of wrong inputs in transactions"); + MERROR_VER("Block with id " << id << " added as invalid because of wrong inputs in transactions"); bvc.m_verifivation_failed = true; return_tx_to_pool(txs); goto leave; @@ -3235,10 +3239,10 @@ leave: // the transaction inputs, but do some sanity checks anyway. if (memcmp(&m_blocks_txs_check[tx_index++], &tx_id, sizeof(tx_id)) != 0) { - LOG_PRINT_L1("Block with id: " << id << " has at least one transaction (id: " << tx_id << ") with wrong inputs."); + MERROR_VER("Block with id: " << id << " has at least one transaction (id: " << tx_id << ") with wrong inputs."); //TODO: why is this done? make sure that keeping invalid blocks makes sense. add_block_as_invalid(bl, id); - LOG_PRINT_L1("Block with id " << id << " added as invalid because of wrong inputs in transactions"); + MERROR_VER("Block with id " << id << " added as invalid because of wrong inputs in transactions"); bvc.m_verifivation_failed = true; return_tx_to_pool(txs); goto leave; @@ -3258,7 +3262,7 @@ leave: uint64_t already_generated_coins = m_db->height() ? m_db->get_block_already_generated_coins(m_db->height() - 1) : 0; if(!validate_miner_transaction(bl, cumulative_block_size, fee_summary, base_reward, already_generated_coins, bvc.m_partial_block_reward, m_hardfork->get_current_version())) { - LOG_PRINT_L1("Block with id: " << id << " has incorrect miner transaction"); + MERROR_VER("Block with id: " << id << " has incorrect miner transaction"); bvc.m_verifivation_failed = true; return_tx_to_pool(txs); goto leave; @@ -3317,10 +3321,10 @@ leave: // do this after updating the hard fork state since the size limit may change due to fork update_next_cumulative_size_limit(); - LOG_PRINT_L1("+++++ BLOCK SUCCESSFULLY ADDED" << std::endl << "id:\t" << id << std::endl << "PoW:\t" << proof_of_work << std::endl << "HEIGHT " << new_height-1 << ", difficulty:\t" << current_diffic << std::endl << "block reward: " << print_money(fee_summary + base_reward) << "(" << print_money(base_reward) << " + " << print_money(fee_summary) << "), coinbase_blob_size: " << coinbase_blob_size << ", cumulative size: " << cumulative_block_size << ", " << block_processing_time << "(" << target_calculating_time << "/" << longhash_calculating_time << ")ms"); + MINFO("+++++ BLOCK SUCCESSFULLY ADDED" << std::endl << "id:\t" << id << std::endl << "PoW:\t" << proof_of_work << std::endl << "HEIGHT " << new_height-1 << ", difficulty:\t" << current_diffic << std::endl << "block reward: " << print_money(fee_summary + base_reward) << "(" << print_money(base_reward) << " + " << print_money(fee_summary) << "), coinbase_blob_size: " << coinbase_blob_size << ", cumulative size: " << cumulative_block_size << ", " << block_processing_time << "(" << target_calculating_time << "/" << longhash_calculating_time << ")ms"); if(m_show_time_stats) { - LOG_PRINT_L0("Height: " << new_height << " blob: " << coinbase_blob_size << " cumm: " + MINFO("Height: " << new_height << " blob: " << coinbase_blob_size << " cumm: " << cumulative_block_size << " p/t: " << block_processing_time << " (" << target_calculating_time << "/" << longhash_calculating_time << "/" << t1 << "/" << t2 << "/" << t3 << "/" << t_exists << "/" << t_pool @@ -3448,7 +3452,7 @@ bool Blockchain::update_checkpoints(const std::string& file_path, bool check_dns } else { - LOG_PRINT_L0("One or more checkpoints fetched from DNS conflicted with existing checkpoints!"); + MERROR("One or more checkpoints fetched from DNS conflicted with existing checkpoints!"); } } @@ -3486,7 +3490,7 @@ void Blockchain::block_longhash_worker(const uint64_t height, const std::vector< //------------------------------------------------------------------ bool Blockchain::cleanup_handle_incoming_blocks(bool force_sync) { - LOG_PRINT_YELLOW("Blockchain::" << __func__, LOG_LEVEL_3); + MTRACE("Blockchain::" << __func__); CRITICAL_REGION_LOCAL(m_blockchain_lock); TIME_MEASURE_START(t1); @@ -3536,7 +3540,7 @@ void Blockchain::output_scan_worker(const uint64_t amount, const std::vector<uin } catch (const std::exception& e) { - LOG_PRINT_L1("EXCEPTION: " << e.what()); + MERROR_VER("EXCEPTION: " << e.what()); } catch (...) { @@ -3553,7 +3557,7 @@ void Blockchain::output_scan_worker(const uint64_t amount, const std::vector<uin // keys. bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_entry> &blocks_entry) { - LOG_PRINT_YELLOW("Blockchain::" << __func__, LOG_LEVEL_3); + MTRACE("Blockchain::" << __func__); TIME_MEASURE_START(prepare); bool stop_batch; CRITICAL_REGION_LOCAL(m_blockchain_lock); @@ -3583,7 +3587,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e std::vector<boost::thread *> thread_list; int batches = blocks_entry.size() / threads; int extra = blocks_entry.size() % threads; - LOG_PRINT_L1("block_batches: " << batches); + MDEBUG("block_batches: " << batches); std::vector<std::unordered_map<crypto::hash, crypto::hash>> maps(threads); std::vector < std::vector < block >> blocks(threads); auto it = blocks_entry.begin(); @@ -3606,7 +3610,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e crypto::hash tophash = m_db->top_block_hash(); if (block.prev_id != tophash) { - LOG_PRINT_L1("Skipping prepare blocks. New blocks don't belong to chain."); + MDEBUG("Skipping prepare blocks. New blocks don't belong to chain."); return true; } } @@ -3672,7 +3676,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e if (blocks_exist) { - LOG_PRINT_L0("Skipping prepare blocks. Blocks exist."); + MDEBUG("Skipping prepare blocks. Blocks exist."); return true; } @@ -3686,7 +3690,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e m_fake_pow_calc_time = prepare / blocks_entry.size(); if (blocks_entry.size() > 1 && threads > 1 && m_show_time_stats) - LOG_PRINT_L0("Prepare blocks took: " << prepare << " ms"); + MDEBUG("Prepare blocks took: " << prepare << " ms"); TIME_MEASURE_START(scantable); @@ -3699,7 +3703,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e #define SCAN_TABLE_QUIT(m) \ do { \ - LOG_PRINT_L0(m) ;\ + MERROR_VER(m) ;\ m_scan_table.clear(); \ return false; \ } while(0); \ @@ -3873,7 +3877,7 @@ bool Blockchain::prepare_handle_incoming_blocks(const std::list<block_complete_e { m_fake_scan_time = scantable / total_txs; if(m_show_time_stats) - LOG_PRINT_L0("Prepare scantable took: " << scantable << " ms"); + MDEBUG("Prepare scantable took: " << scantable << " ms"); } return true; @@ -3951,7 +3955,7 @@ void Blockchain::load_compiled_in_block_hashes() const size_t size_needed = 4 + nblocks * sizeof(crypto::hash); if(nblocks > 0 && nblocks > m_db->height() && get_blocks_dat_size(m_testnet) >= size_needed) { - LOG_PRINT_L0("Loading precomputed blocks: " << nblocks); + MINFO("Loading precomputed blocks: " << nblocks); p += sizeof(uint32_t); for (uint32_t i = 0; i < nblocks; i++) { diff --git a/src/cryptonote_core/checkpoints.cpp b/src/cryptonote_core/checkpoints.cpp index dc1912856..3cf804ede 100644 --- a/src/cryptonote_core/checkpoints.cpp +++ b/src/cryptonote_core/checkpoints.cpp @@ -39,6 +39,9 @@ using namespace epee; #include <sstream> #include <random> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "checkpoints" + namespace { bool dns_records_match(const std::vector<std::string>& a, const std::vector<std::string>& b) @@ -99,11 +102,11 @@ namespace cryptonote if(it->second == h) { - LOG_PRINT_GREEN("CHECKPOINT PASSED FOR HEIGHT " << height << " " << h, LOG_LEVEL_1); + MINFO("CHECKPOINT PASSED FOR HEIGHT " << height << " " << h); return true; }else { - LOG_ERROR("CHECKPOINT FAILED FOR HEIGHT " << height << ". EXPECTED HASH: " << it->second << ", FETCHED HASH: " << h); + MWARNING("CHECKPOINT FAILED FOR HEIGHT " << height << ". EXPECTED HASH: " << it->second << ", FETCHED HASH: " << h); return false; } } diff --git a/src/cryptonote_core/cryptonote_basic_impl.cpp b/src/cryptonote_core/cryptonote_basic_impl.cpp index 4f35b8298..5a8c61dd9 100644 --- a/src/cryptonote_core/cryptonote_basic_impl.cpp +++ b/src/cryptonote_core/cryptonote_basic_impl.cpp @@ -42,6 +42,9 @@ using namespace epee; #include "crypto/hash.h" #include "common/int-util.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "cn" + namespace cryptonote { struct integrated_address { @@ -98,7 +101,7 @@ namespace cryptonote { } if(current_block_size > 2 * median_size) { - LOG_PRINT_L4("Block cumulative size is too big: " << current_block_size << ", expected less than " << 2 * median_size); + MERROR("Block cumulative size is too big: " << current_block_size << ", expected less than " << 2 * median_size); return false; } diff --git a/src/cryptonote_core/cryptonote_core.cpp b/src/cryptonote_core/cryptonote_core.cpp index ede7ed748..5294431d6 100644 --- a/src/cryptonote_core/cryptonote_core.cpp +++ b/src/cryptonote_core/cryptonote_core.cpp @@ -51,8 +51,13 @@ using namespace epee; #endif #include "ringct/rctSigs.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "cn" + DISABLE_VS_WARNINGS(4355) +#define MERROR_VER(x) MCERROR("verify", x) + namespace cryptonote { @@ -282,10 +287,10 @@ namespace cryptonote const boost::filesystem::path old_files = folder; if (boost::filesystem::exists(old_files / "blockchain.bin")) { - LOG_PRINT_RED_L0("Found old-style blockchain.bin in " << old_files.string()); - LOG_PRINT_RED_L0("Monero now uses a new format. You can either remove blockchain.bin to start syncing"); - LOG_PRINT_RED_L0("the blockchain anew, or use monero-blockchain-export and monero-blockchain-import to"); - LOG_PRINT_RED_L0("convert your existing blockchain.bin to the new format. See README.md for instructions."); + MWARNING("Found old-style blockchain.bin in " << old_files.string()); + MWARNING("Monero now uses a new format. You can either remove blockchain.bin to start syncing"); + MWARNING("the blockchain anew, or use monero-blockchain-export and monero-blockchain-import to"); + MWARNING("convert your existing blockchain.bin to the new format. See README.md for instructions."); return false; } } @@ -310,7 +315,7 @@ namespace cryptonote } folder /= db->get_db_name(); - LOG_PRINT_L0("Loading blockchain from folder " << folder.string() << " ..."); + MGINFO("Loading blockchain from folder " << folder.string() << " ..."); const std::string filename = folder.string(); // default to fast:async:1 @@ -326,7 +331,7 @@ namespace cryptonote boost::split(options, db_sync_mode, boost::is_any_of(" :")); for(const auto &option : options) - LOG_PRINT_L0("option: " << option); + MDEBUG("option: " << option); // default to fast:async:1 uint64_t DEFAULT_FLAGS = DBS_FAST_MODE; @@ -523,12 +528,12 @@ namespace cryptonote bool r = add_new_tx(tx, tx_hash, tx_prefixt_hash, tx_blob.size(), tvc, keeped_by_block, relayed, do_not_relay); if(tvc.m_verifivation_failed) - {LOG_PRINT_RED_L1("Transaction verification failed: " << tx_hash);} + {MERROR_VER("Transaction verification failed: " << tx_hash);} else if(tvc.m_verifivation_impossible) - {LOG_PRINT_RED_L1("Transaction verification impossible: " << tx_hash);} + {MERROR_VER("Transaction verification impossible: " << tx_hash);} if(tvc.m_added_to_pool) - LOG_PRINT_L1("tx added: " << tx_hash); + MDEBUG("tx added: " << tx_hash); return r; } //----------------------------------------------------------------------------------------------- @@ -547,33 +552,33 @@ namespace cryptonote { if(!tx.vin.size()) { - LOG_PRINT_RED_L1("tx with empty inputs, rejected for tx id= " << get_transaction_hash(tx)); + MERROR_VER("tx with empty inputs, rejected for tx id= " << get_transaction_hash(tx)); return false; } if(!check_inputs_types_supported(tx)) { - LOG_PRINT_RED_L1("unsupported input types for tx id= " << get_transaction_hash(tx)); + MERROR_VER("unsupported input types for tx id= " << get_transaction_hash(tx)); return false; } if(!check_outs_valid(tx)) { - LOG_PRINT_RED_L1("tx with invalid outputs, rejected for tx id= " << get_transaction_hash(tx)); + MERROR_VER("tx with invalid outputs, rejected for tx id= " << get_transaction_hash(tx)); return false; } if (tx.version > 1) { if (tx.rct_signatures.outPk.size() != tx.vout.size()) { - LOG_PRINT_RED_L1("tx with mismatched vout/outPk count, rejected for tx id= " << get_transaction_hash(tx)); + MERROR_VER("tx with mismatched vout/outPk count, rejected for tx id= " << get_transaction_hash(tx)); return false; } } if(!check_money_overflow(tx)) { - LOG_PRINT_RED_L1("tx has money overflow, rejected for tx id= " << get_transaction_hash(tx)); + MERROR_VER("tx has money overflow, rejected for tx id= " << get_transaction_hash(tx)); return false; } @@ -585,7 +590,7 @@ namespace cryptonote if(amount_in <= amount_out) { - LOG_PRINT_RED_L1("tx with wrong amounts: ins " << amount_in << ", outs " << amount_out << ", rejected for tx id= " << get_transaction_hash(tx)); + MERROR_VER("tx with wrong amounts: ins " << amount_in << ", outs " << amount_out << ", rejected for tx id= " << get_transaction_hash(tx)); return false; } } @@ -593,14 +598,14 @@ namespace cryptonote if(!keeped_by_block && get_object_blobsize(tx) >= m_blockchain_storage.get_current_cumulative_blocksize_limit() - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE) { - LOG_PRINT_RED_L1("tx is too large " << get_object_blobsize(tx) << ", expected not bigger than " << m_blockchain_storage.get_current_cumulative_blocksize_limit() - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE); + MERROR_VER("tx is too large " << get_object_blobsize(tx) << ", expected not bigger than " << m_blockchain_storage.get_current_cumulative_blocksize_limit() - CRYPTONOTE_COINBASE_BLOB_RESERVED_SIZE); return false; } //check if tx use different key images if(!check_tx_inputs_keyimages_diff(tx)) { - LOG_PRINT_RED_L1("tx uses a single key image more than once"); + MERROR_VER("tx uses a single key image more than once"); return false; } @@ -610,24 +615,24 @@ namespace cryptonote switch (rv.type) { case rct::RCTTypeNull: // coinbase should not come here, so we reject for all other types - LOG_PRINT_RED_L1("Unexpected Null rctSig type"); + MERROR_VER("Unexpected Null rctSig type"); return false; case rct::RCTTypeSimple: if (!rct::verRctSimple(rv, true)) { - LOG_PRINT_RED_L1("rct signature semantics check failed"); + MERROR_VER("rct signature semantics check failed"); return false; } break; case rct::RCTTypeFull: if (!rct::verRct(rv, true)) { - LOG_PRINT_RED_L1("rct signature semantics check failed"); + MERROR_VER("rct signature semantics check failed"); return false; } break; default: - LOG_PRINT_RED_L1("Unknown rct type: " << rv.type); + MERROR_VER("Unknown rct type: " << rv.type); return false; } } @@ -992,10 +997,10 @@ namespace cryptonote { if(!m_starter_message_showed) { - LOG_PRINT_L0(ENDL << "**********************************************************************" << ENDL + MGINFO_YELLOW(ENDL << "**********************************************************************" << ENDL << "The daemon will start synchronizing with the network. It may take up to several hours." << ENDL << ENDL - << "You can set the level of process detailization* through \"set_log <level>\" command*, where <level> is between 0 (no details) and 4 (very verbose)." << ENDL + << "You can set the level of process detailization* through \"set_log <level|categories>\" command*, where <level> is between 0 (no details) and 4 (very verbose), or custom category based levels (eg, *:WARNING)" << ENDL << ENDL << "Use \"help\" command to see the list of available commands." << ENDL << ENDL @@ -1014,19 +1019,18 @@ namespace cryptonote bool core::check_fork_time() { HardFork::State state = m_blockchain_storage.get_hard_fork_state(); + const el::Level level = el::Level::Warning; switch (state) { case HardFork::LikelyForked: - LOG_PRINT_RED_L0(ENDL - << "**********************************************************************" << ENDL - << "Last scheduled hard fork is too far in the past." << ENDL - << "We are most likely forked from the network. Daemon update needed now." << ENDL - << "**********************************************************************" << ENDL); + MCLOG_RED(level, "global", "**********************************************************************"); + MCLOG_RED(level, "global", "Last scheduled hard fork is too far in the past."); + MCLOG_RED(level, "global", "We are most likely forked from the network. Daemon update needed now."); + MCLOG_RED(level, "global", "**********************************************************************"); break; case HardFork::UpdateNeeded: - LOG_PRINT_RED_L0(ENDL - << "**********************************************************************" << ENDL - << "Last scheduled hard fork time shows a daemon update is needed now." << ENDL - << "**********************************************************************" << ENDL); + MCLOG_RED(level, "global", "**********************************************************************"); + MCLOG_RED(level, "global", "Last scheduled hard fork time shows a daemon update is needed now."); + MCLOG_RED(level, "global", "**********************************************************************"); break; default: break; diff --git a/src/cryptonote_core/cryptonote_format_utils.cpp b/src/cryptonote_core/cryptonote_format_utils.cpp index d6dbc400a..b5f2b069d 100644 --- a/src/cryptonote_core/cryptonote_format_utils.cpp +++ b/src/cryptonote_core/cryptonote_format_utils.cpp @@ -39,6 +39,9 @@ using namespace epee; #include "crypto/hash.h" #include "ringct/rctSigs.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "cn" + #define ENCRYPTED_PAYMENT_ID_TAIL 0x8d static const uint64_t valid_decomposed_outputs[] = { @@ -623,7 +626,7 @@ namespace cryptonote zero_secret_key &= (sender_account_keys.m_spend_secret_key.data[i] == 0); if (zero_secret_key) { - LOG_PRINT_L1("Null secret key, skipping signatures"); + MDEBUG("Null secret key, skipping signatures"); } if (tx.version == 1) @@ -659,7 +662,7 @@ namespace cryptonote i++; } - LOG_PRINT2("construct_tx.log", "transaction_created: " << get_transaction_hash(tx) << ENDL << obj_to_json_str(tx) << ENDL << ss_ring_s.str() , LOG_LEVEL_3); + MCINFO("construct_tx", "transaction_created: " << get_transaction_hash(tx) << ENDL << obj_to_json_str(tx) << ENDL << ss_ring_s.str()); } else { @@ -764,7 +767,7 @@ namespace cryptonote CHECK_AND_ASSERT_MES(tx.vout.size() == outSk.size(), false, "outSk size does not match vout"); - LOG_PRINT2("construct_tx.log", "transaction_created: " << get_transaction_hash(tx) << ENDL << obj_to_json_str(tx) << ENDL, LOG_LEVEL_3); + MCINFO("construct_tx", "transaction_created: " << get_transaction_hash(tx) << ENDL << obj_to_json_str(tx) << ENDL); } return true; diff --git a/src/cryptonote_core/difficulty.cpp b/src/cryptonote_core/difficulty.cpp index 54da77392..1c5b9cfbd 100644 --- a/src/cryptonote_core/difficulty.cpp +++ b/src/cryptonote_core/difficulty.cpp @@ -39,6 +39,9 @@ #include "cryptonote_config.h" #include "difficulty.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "difficulty" + namespace cryptonote { using std::size_t; diff --git a/src/cryptonote_core/hardfork.cpp b/src/cryptonote_core/hardfork.cpp index 8f9ff97d3..13d7d717d 100644 --- a/src/cryptonote_core/hardfork.cpp +++ b/src/cryptonote_core/hardfork.cpp @@ -33,6 +33,9 @@ #include "blockchain_db/blockchain_db.h" #include "hardfork.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "hardfork" + using namespace cryptonote; static uint8_t get_block_vote(const cryptonote::block &b) diff --git a/src/cryptonote_core/miner.cpp b/src/cryptonote_core/miner.cpp index 6f4e706ed..51f508858 100644 --- a/src/cryptonote_core/miner.cpp +++ b/src/cryptonote_core/miner.cpp @@ -43,6 +43,9 @@ #include "string_coding.h" #include "storages/portable_storage_template_helper.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "miner" + using namespace epee; #include "miner.h" @@ -193,7 +196,7 @@ namespace cryptonote m_config_folder_path = boost::filesystem::path(command_line::get_arg(vm, arg_extra_messages)).parent_path().string(); m_config = AUTO_VAL_INIT(m_config); epee::serialization::load_t_from_json_file(m_config, m_config_folder_path + "/" + MINER_CONFIG_FILE_NAME); - LOG_PRINT_L0("Loaded " << m_extra_messages.size() << " extra messages, current index " << m_config.current_extra_message_index); + MINFO("Loaded " << m_extra_messages.size() << " extra messages, current index " << m_config.current_extra_message_index); } if(command_line::has_arg(vm, arg_start_mining)) @@ -278,11 +281,11 @@ namespace cryptonote //----------------------------------------------------------------------------------------------------- bool miner::stop() { - LOG_PRINT_L1("Miner has received stop signal"); + MTRACE("Miner has received stop signal"); if (!is_mining()) { - LOG_PRINT_L1("Not mining - nothing to stop" ); + MDEBUG("Not mining - nothing to stop" ); return true; } @@ -292,7 +295,7 @@ namespace cryptonote BOOST_FOREACH(boost::thread& th, m_threads) th.join(); - LOG_PRINT_L0("Mining has been stopped, " << m_threads.size() << " finished" ); + MINFO("Mining has been stopped, " << m_threads.size() << " finished" ); m_threads.clear(); return true; } @@ -328,7 +331,7 @@ namespace cryptonote CRITICAL_REGION_LOCAL(m_miners_count_lock); ++m_pausers_count; if(m_pausers_count == 1 && is_mining()) - LOG_PRINT_L2("MINING PAUSED"); + MDEBUG("MINING PAUSED"); } //----------------------------------------------------------------------------------------------------- void miner::resume() @@ -338,17 +341,17 @@ namespace cryptonote if(m_pausers_count < 0) { m_pausers_count = 0; - LOG_PRINT_RED_L0("Unexpected miner::resume() called"); + MERROR("Unexpected miner::resume() called"); } if(!m_pausers_count && is_mining()) - LOG_PRINT_L2("MINING RESUMED"); + MDEBUG("MINING RESUMED"); } //----------------------------------------------------------------------------------------------------- bool miner::worker_thread() { uint32_t th_local_index = boost::interprocess::ipcdetail::atomic_inc32(&m_thread_index); - LOG_PRINT_L0("Miner thread was started ["<< th_local_index << "]"); - log_space::log_singletone::set_thread_log_prefix(std::string("[miner ") + std::to_string(th_local_index) + "]"); + MGINFO("Miner thread was started ["<< th_local_index << "]"); + MLOG_SET_THREAD_NAME(std::string("[miner ") + std::to_string(th_local_index) + "]"); uint32_t nonce = m_starter_nonce + th_local_index; uint64_t height = 0; difficulty_type local_diff = 0; @@ -389,7 +392,7 @@ namespace cryptonote { //we lucky! ++m_config.current_extra_message_index; - LOG_PRINT_GREEN("Found block for difficulty: " << local_diff, LOG_LEVEL_0); + MGINFO_GREEN("Found block for difficulty: " << local_diff); if(!m_phandler->handle_block_found(b)) { --m_config.current_extra_message_index; @@ -404,7 +407,7 @@ namespace cryptonote ++m_hashes; } slow_hash_free_state(); - LOG_PRINT_L0("Miner thread stopped ["<< th_local_index << "]"); + MGINFO("Miner thread stopped ["<< th_local_index << "]"); return true; } //----------------------------------------------------------------------------------------------------- diff --git a/src/cryptonote_core/tx_pool.cpp b/src/cryptonote_core/tx_pool.cpp index 78d75f41f..6ad139023 100644 --- a/src/cryptonote_core/tx_pool.cpp +++ b/src/cryptonote_core/tx_pool.cpp @@ -45,6 +45,9 @@ #include "common/perf_timer.h" #include "crypto/hash.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "txpool" + DISABLE_VS_WARNINGS(4244 4345 4503) //'boost::foreach_detail_::or_' : decorated name length exceeded, name was truncated namespace cryptonote diff --git a/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp b/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp index 9d9ab3321..56b82ed15 100644 --- a/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp +++ b/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp @@ -73,11 +73,11 @@ #include "../../src/cryptonote_protocol/cryptonote_protocol_handler.h" #include "../../src/p2p/network_throttle.hpp" -#include "../../contrib/otshell_utils/utils.hpp" -using namespace nOT::nUtils; - #include "../../../src/cryptonote_core/cryptonote_core.h" // e.g. for the send_stop_signal() +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.cn" + // ################################################################################################ // ################################################################################################ // the "header part". Not separated out for .hpp because point of this modification is @@ -122,25 +122,24 @@ cryptonote_protocol_handler_base::~cryptonote_protocol_handler_base() { void cryptonote_protocol_handler_base::handler_request_blocks_history(std::list<crypto::hash>& ids) { using namespace epee::net_utils; - LOG_PRINT_L1("### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); - LOG_PRINT_RED("RATE LIMIT NOT IMPLEMENTED HERE YET (download at unlimited speed?)" , LOG_LEVEL_1); - _note_c("net/req2", "### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); + MDEBUG("### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); + MWARNING("RATE LIMIT NOT IMPLEMENTED HERE YET (download at unlimited speed?)"); // TODO } -void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet_size) { _scope_dbg1(""); +void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet_size) { using namespace epee::net_utils; double delay=0; // will be calculated - _dbg1("Packet size: " << packet_size); + MDEBUG("Packet size: " << packet_size); do { // rate limiting //XXX /*if (::cryptonote::core::get_is_stopping()) { - _dbg1("We are stopping - so abort sleep"); + MDEBUG("We are stopping - so abort sleep"); return; }*/ /*if (m_was_shutdown) { - _dbg2_c("net/netuse/sleep","m_was_shutdown - so abort sleep"); + MDEBUG("m_was_shutdown - so abort sleep"); return; }*/ @@ -155,9 +154,7 @@ void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet if (delay > 0) { //delay += rand2*0.1; long int ms = (long int)(delay * 1000); - _info_c("net/sleep", "Sleeping in " << __FUNCTION__ << " for " << ms << " ms before packet_size="<<packet_size); // XXX debug sleep - _dbg1_c("net/sleep/", "sleep in sleep_before_packet"); - _dbg2("Sleep for " << ms); + MDEBUG("Sleeping for " << ms << " ms before packet_size="<<packet_size); // XXX debug sleep boost::this_thread::sleep(boost::posix_time::milliseconds( ms ) ); // TODO randomize sleeps } } while(delay > 0); diff --git a/src/cryptonote_protocol/cryptonote_protocol_handler.h b/src/cryptonote_protocol/cryptonote_protocol_handler.h index 08dde4904..4b2de39b9 100644 --- a/src/cryptonote_protocol/cryptonote_protocol_handler.h +++ b/src/cryptonote_protocol/cryptonote_protocol_handler.h @@ -69,8 +69,6 @@ namespace cryptonote virtual double get_avg_block_size() = 0; virtual double estimate_one_block_size() noexcept; // for estimating size of blocks to download - - virtual std::ofstream& get_logreq() const =0; }; template<class t_core> @@ -138,7 +136,6 @@ namespace cryptonote bool m_one_request = true; std::atomic<bool> m_stopping; - // static std::ofstream m_logreq; boost::mutex m_buffer_mutex; double get_avg_block_size(); boost::circular_buffer<size_t> m_avg_buffer = boost::circular_buffer<size_t>(10); @@ -161,8 +158,6 @@ namespace cryptonote epee::serialization::store_t_to_binary(arg, arg_buff); return m_p2p->relay_notify_to_all(t_parameter::ID, arg_buff, exclude_context); } - - virtual std::ofstream& get_logreq() const ; }; } // namespace diff --git a/src/cryptonote_protocol/cryptonote_protocol_handler.inl b/src/cryptonote_protocol/cryptonote_protocol_handler.inl index 54f1c849e..16a75c422 100644 --- a/src/cryptonote_protocol/cryptonote_protocol_handler.inl +++ b/src/cryptonote_protocol/cryptonote_protocol_handler.inl @@ -41,19 +41,15 @@ #include "cryptonote_core/cryptonote_format_utils.h" #include "profile_tools.h" -#include "../../contrib/otshell_utils/utils.hpp" #include "../../src/p2p/network_throttle-detail.hpp" -#include "../../src/p2p/data_logger.hpp" -using namespace nOT::nUtils; + +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.cn" namespace cryptonote { -// static -// template<class t_core> std::ofstream t_cryptonote_protocol_handler<t_core>::m_logreq("logreq.txt"); // static - - //----------------------------------------------------------------------------------------------------------------------- template<class t_core> @@ -284,10 +280,10 @@ namespace cryptonote int64_t max_block_height = max(static_cast<int64_t>(hshd.current_height),static_cast<int64_t>(m_core.get_current_blockchain_height())); int64_t last_block_v1 = 1009826; int64_t diff_v2 = max_block_height > last_block_v1 ? min(abs(diff), max_block_height - last_block_v1) : 0; - LOG_PRINT_CCONTEXT_YELLOW("Sync data returned a new top block candidate: " << m_core.get_current_blockchain_height() << " -> " << hshd.current_height + MCLOG(is_inital ? el::Level::Info : el::Level::Debug, "global", context << "Sync data returned a new top block candidate: " << m_core.get_current_blockchain_height() << " -> " << hshd.current_height << " [Your node is " << std::abs(diff) << " blocks (" << ((abs(diff) - diff_v2) / (24 * 60 * 60 / DIFFICULTY_TARGET_V1)) + (diff_v2 / (24 * 60 * 60 / DIFFICULTY_TARGET_V2)) << " days) " << (0 <= diff ? std::string("behind") : std::string("ahead")) - << "] " << ENDL << "SYNCHRONIZATION started", (is_inital ? LOG_LEVEL_0:LOG_LEVEL_1)); + << "] " << ENDL << "SYNCHRONIZATION started"); LOG_PRINT_L1("Remote blockchain height: " << hshd.current_height << ", id: " << hshd.top_id); context.m_state = cryptonote_connection_context::state_synchronizing; context.m_remote_blockchain_height = hshd.current_height; @@ -515,12 +511,12 @@ namespace cryptonote // ones we received. if(context.m_requested_objects.size()) { - LOG_PRINT_CCONTEXT_RED + MERROR ( "NOTIFY_NEW_FLUFFY_BLOCK: peer sent the number of transaction requested" << ", but not the actual transactions requested" << ", context.m_requested_objects.size() = " << context.m_requested_objects.size() - << ", dropping connection", LOG_LEVEL_0 + << ", dropping connection" ); m_p2p->drop_connection(context); @@ -842,8 +838,8 @@ namespace cryptonote if(context.m_requested_objects.size()) { - LOG_PRINT_CCONTEXT_RED("returned not all requested objects (context.m_requested_objects.size()=" - << context.m_requested_objects.size() << "), dropping connection", LOG_LEVEL_0); + MERROR("returned not all requested objects (context.m_requested_objects.size()=" + << context.m_requested_objects.size() << "), dropping connection"); m_p2p->drop_connection(context); return 1; } @@ -854,7 +850,7 @@ namespace cryptonote epee::misc_utils::auto_scope_leave_caller scope_exit_handler = epee::misc_utils::create_scope_leave_handler( boost::bind(&t_core::resume_mine, &m_core)); - LOG_PRINT_CCONTEXT_YELLOW( "Got NEW BLOCKS inside of " << __FUNCTION__ << ": size: " << arg.blocks.size() , LOG_LEVEL_1); + MLOG_YELLOW(el::Level::Debug, "Got NEW BLOCKS inside of " << __FUNCTION__ << ": size: " << arg.blocks.size()); if (m_core.get_test_drop_download() && m_core.get_test_drop_download_height()) { // DISCARD BLOCKS for testing @@ -913,15 +909,12 @@ namespace cryptonote TIME_MEASURE_FINISH(block_process_time); LOG_PRINT_CCONTEXT_L2("Block process time: " << block_process_time + transactions_process_time << "(" << transactions_process_time << "/" << block_process_time << ")ms"); - epee::net_utils::data_logger::get_instance().add_data("calc_time", block_process_time + transactions_process_time); - epee::net_utils::data_logger::get_instance().add_data("block_processing", 1); - } // each download block m_core.cleanup_handle_incoming_blocks(); if (m_core.get_current_blockchain_height() > previous_height) { - LOG_PRINT_CCONTEXT_YELLOW( "Synced " << m_core.get_current_blockchain_height() << "/" << m_core.get_target_blockchain_height() , LOG_LEVEL_0); + MGINFO_YELLOW("Synced " << m_core.get_current_blockchain_height() << "/" << m_core.get_target_blockchain_height()); } } // if not DISCARD BLOCK @@ -973,7 +966,7 @@ namespace cryptonote auto it = context.m_needed_objects.begin(); const size_t count_limit = m_core.get_block_sync_size(); - _note_c("net/req-calc" , "Setting count_limit: " << count_limit); + MDEBUG("Setting count_limit: " << count_limit); while(it != context.m_needed_objects.end() && count < count_limit) { if( !(check_having_blocks && m_core.have_block(*it))) @@ -1015,7 +1008,7 @@ namespace cryptonote << "\r\non connection [" << epee::net_utils::print_connection_context_short(context)<< "]"); context.m_state = cryptonote_connection_context::state_normal; - LOG_PRINT_CCONTEXT_GREEN(" SYNCHRONIZED OK", LOG_LEVEL_0); + MGINFO_GREEN("SYNCHRONIZED OK"); on_connection_synchronized(); } return true; @@ -1027,7 +1020,7 @@ namespace cryptonote bool val_expected = false; if(m_synchronized.compare_exchange_strong(val_expected, true)) { - LOG_PRINT_L0(ENDL << "**********************************************************************" << ENDL + MGINFO_GREEN(ENDL << "**********************************************************************" << ENDL << "You are now synchronized with the network. You may now start monero-wallet-cli." << ENDL << ENDL << "Please note, that the blockchain will be saved only after you quit the daemon with \"exit\" command or if you use \"save\" command." << ENDL @@ -1118,12 +1111,12 @@ namespace cryptonote { if(m_core.get_testnet() && (support_flags & P2P_SUPPORT_FLAG_FLUFFY_BLOCKS)) { - LOG_PRINT_CCONTEXT_YELLOW("PEER SUPPORTS FLUFFY BLOCKS - RELAYING THIN/COMPACT WHATEVER BLOCK", LOG_LEVEL_1); + MDEBUG("PEER SUPPORTS FLUFFY BLOCKS - RELAYING THIN/COMPACT WHATEVER BLOCK"); fluffyConnections.push_back(context.m_connection_id); } else { - LOG_PRINT_CCONTEXT_YELLOW("PEER DOESN'T SUPPORT FLUFFY BLOCKS - RELAYING FULL BLOCK", LOG_LEVEL_1); + MDEBUG("PEER DOESN'T SUPPORT FLUFFY BLOCKS - RELAYING FULL BLOCK"); fullConnections.push_back(context.m_connection_id); } } @@ -1146,18 +1139,6 @@ namespace cryptonote return relay_post_notify<NOTIFY_NEW_TRANSACTIONS>(arg, exclude_context); } - /// @deprecated - template<class t_core> std::ofstream& t_cryptonote_protocol_handler<t_core>::get_logreq() const { - static std::ofstream * logreq=NULL; - if (!logreq) { - LOG_PRINT_RED("LOG OPENED",LOG_LEVEL_0); - logreq = new std::ofstream("logreq.txt"); // leak mem (singleton) - *logreq << "Opened log" << std::endl; - } - LOG_PRINT_YELLOW("LOG USED",LOG_LEVEL_0); - (*logreq) << "log used" << std::endl; - return *logreq; - } //------------------------------------------------------------------------------------------------------------------------ template<class t_core> void t_cryptonote_protocol_handler<t_core>::stop() diff --git a/src/daemon/CMakeLists.txt b/src/daemon/CMakeLists.txt index 0f4baf932..1b6363f7b 100644 --- a/src/daemon/CMakeLists.txt +++ b/src/daemon/CMakeLists.txt @@ -89,7 +89,6 @@ target_link_libraries(daemon cryptonote_core crypto common - otshell_utils p2p cryptonote_protocol daemonizer diff --git a/src/daemon/command_line_args.h b/src/daemon/command_line_args.h index 1fe2ddcf6..cb9fb6014 100644 --- a/src/daemon/command_line_args.h +++ b/src/daemon/command_line_args.h @@ -46,10 +46,10 @@ namespace daemon_args , "Specify log file" , "" }; - const command_line::arg_descriptor<int> arg_log_level = { + const command_line::arg_descriptor<std::string> arg_log_level = { "log-level" , "" - , LOG_LEVEL_0 + , "" }; const command_line::arg_descriptor<std::vector<std::string>> arg_command = { "daemon_command" diff --git a/src/daemon/command_parser_executor.cpp b/src/daemon/command_parser_executor.cpp index 9d28cd41e..27f9d0fd7 100644 --- a/src/daemon/command_parser_executor.cpp +++ b/src/daemon/command_parser_executor.cpp @@ -29,6 +29,9 @@ #include "common/dns_utils.h" #include "daemon/command_parser_executor.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { t_command_parser_executor::t_command_parser_executor( @@ -117,24 +120,24 @@ bool t_command_parser_executor::set_log_level(const std::vector<std::string>& ar { if(args.size() != 1) { - std::cout << "use: set_log <log_level_number_0-4>" << std::endl; + std::cout << "use: set_log [<log_level_number_0-4> | <categories>]" << std::endl; return true; } uint16_t l = 0; - if(!epee::string_tools::get_xtype_from_string(l, args[0])) + if(epee::string_tools::get_xtype_from_string(l, args[0])) { - std::cout << "wrong number format, use: set_log <log_level_number_0-4>" << std::endl; - return true; + if(4 < l) + { + std::cout << "wrong number range, use: set_log <log_level_number_0-4>" << std::endl; + return true; + } + return m_executor.set_log_level(l); } - - if(LOG_LEVEL_4 < l) + else { - std::cout << "wrong number range, use: set_log <log_level_number_0-4>" << std::endl; - return true; + return m_executor.set_log_categories(args.front()); } - - return m_executor.set_log_level(l); } bool t_command_parser_executor::print_height(const std::vector<std::string>& args) diff --git a/src/daemon/command_parser_executor.h b/src/daemon/command_parser_executor.h index 7763ebed0..15293ade9 100644 --- a/src/daemon/command_parser_executor.h +++ b/src/daemon/command_parser_executor.h @@ -72,6 +72,8 @@ public: bool set_log_level(const std::vector<std::string>& args); + bool set_log_categories(const std::vector<std::string>& args); + bool print_height(const std::vector<std::string>& args); bool print_block(const std::vector<std::string>& args); diff --git a/src/daemon/command_server.cpp b/src/daemon/command_server.cpp index 086478a47..95fd3178c 100644 --- a/src/daemon/command_server.cpp +++ b/src/daemon/command_server.cpp @@ -30,6 +30,9 @@ #include "version.h" #include "daemon/command_server.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { namespace p = std::placeholders; @@ -133,7 +136,7 @@ t_command_server::t_command_server( m_command_lookup.set_handler( "set_log" , std::bind(&t_command_parser_executor::set_log_level, &m_parser, p::_1) - , "set_log <level> - Change current log detalization level, <level> is a number 0-4" + , "set_log <level>|<categories> - Change current loglevel, <level> is a number 0-4" ); m_command_lookup.set_handler( "diff" diff --git a/src/daemon/core.h b/src/daemon/core.h index 2b7f0d177..23f7a9f63 100644 --- a/src/daemon/core.h +++ b/src/daemon/core.h @@ -33,6 +33,9 @@ #include "misc_log_ex.h" #include "daemon/command_line_args.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { @@ -68,12 +71,12 @@ public: bool run() { //initialize core here - LOG_PRINT_L0("Initializing core..."); + MGINFO("Initializing core..."); if (!m_core.init(m_vm_HACK)) { return false; } - LOG_PRINT_L0("Core initialized OK"); + MGINFO("Core initialized OK"); return true; } @@ -84,12 +87,12 @@ public: ~t_core() { - LOG_PRINT_L0("Deinitializing core..."); + MGINFO("Deinitializing core..."); try { m_core.deinit(); m_core.set_cryptonote_protocol(nullptr); } catch (...) { - LOG_PRINT_L0("Failed to deinitialize core..."); + MERROR("Failed to deinitialize core..."); } } }; diff --git a/src/daemon/daemon.cpp b/src/daemon/daemon.cpp index 74875bfb0..287c30cb4 100644 --- a/src/daemon/daemon.cpp +++ b/src/daemon/daemon.cpp @@ -46,6 +46,9 @@ using namespace epee; #include <functional> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { struct t_internals { @@ -136,17 +139,17 @@ bool t_daemon::run(bool interactive) } mp_internals->rpc.stop(); - LOG_PRINT("Node stopped.", LOG_LEVEL_0); + MGINFO("Node stopped."); return true; } catch (std::exception const & ex) { - LOG_ERROR("Uncaught exception! " << ex.what()); + MFATAL("Uncaught exception! " << ex.what()); return false; } catch (...) { - LOG_ERROR("Uncaught exception!"); + MFATAL("Uncaught exception!"); return false; } } diff --git a/src/daemon/daemon.h b/src/daemon/daemon.h index 655ca8a3d..c8fae5c28 100644 --- a/src/daemon/daemon.h +++ b/src/daemon/daemon.h @@ -29,6 +29,9 @@ #pragma once #include <boost/program_options.hpp> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { struct t_internals; diff --git a/src/daemon/executor.cpp b/src/daemon/executor.cpp index 9583fd056..ac5803cfb 100644 --- a/src/daemon/executor.cpp +++ b/src/daemon/executor.cpp @@ -26,16 +26,19 @@ // STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF // THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. -#include "daemon/executor.h" - #include "misc_log_ex.h" +#include "daemon/executor.h" + #include "common/command_line.h" #include "cryptonote_config.h" #include "version.h" #include <string> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { std::string const t_executor::NAME = "Monero Daemon"; @@ -64,7 +67,6 @@ namespace daemonize boost::program_options::variables_map const & vm ) { - epee::log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL); return t_daemon{vm}.run(true); } } diff --git a/src/daemon/executor.h b/src/daemon/executor.h index 37b4970f4..a6b47b93d 100644 --- a/src/daemon/executor.h +++ b/src/daemon/executor.h @@ -34,6 +34,9 @@ #include <string> #include <vector> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { class t_executor final diff --git a/src/daemon/main.cpp b/src/daemon/main.cpp index 0895e1bf1..e08065ccd 100644 --- a/src/daemon/main.cpp +++ b/src/daemon/main.cpp @@ -47,6 +47,9 @@ #include "common/stack_trace.h" #endif // STACK_TRACE +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace po = boost::program_options; namespace bf = boost::filesystem; @@ -54,7 +57,6 @@ int main(int argc, char const * argv[]) { try { - _note_c("dbg/main", "Begin of main()"); // TODO parse the debug options like set log level right here at start tools::sanitize_locale(); @@ -79,7 +81,6 @@ int main(int argc, char const * argv[]) bf::path default_conf = default_data_dir / std::string(CRYPTONOTE_NAME ".conf"); command_line::add_arg(visible_options, daemon_args::arg_config_file, default_conf.string()); command_line::add_arg(visible_options, command_line::arg_test_dbg_lock_sleep); - cryptonote::core::init_options(core_settings); // Settings bf::path default_log = default_data_dir / std::string(CRYPTONOTE_NAME ".log"); @@ -196,6 +197,23 @@ int main(int argc, char const * argv[]) } po::notify(vm); + // log_file_path + // default: <data_dir>/<CRYPTONOTE_NAME>.log + // if log-file argument given: + // absolute path + // relative path: relative to data_dir + bf::path log_file_path {data_dir / std::string(CRYPTONOTE_NAME ".log")}; + if (! vm["log-file"].defaulted()) + log_file_path = command_line::get_arg(vm, daemon_args::arg_log_file); + log_file_path = bf::absolute(log_file_path, relative_path_base); + mlog_configure(log_file_path.string(), true); + + // Set log level + if (!vm["log-level"].defaulted()) + { + mlog_set_log(command_line::get_arg(vm, daemon_args::arg_log_level).c_str()); + } + // If there are positional options, we're running a daemon command { auto command = command_line::get_arg(vm, daemon_args::arg_command); @@ -236,55 +254,17 @@ int main(int argc, char const * argv[]) } } - // Start with log level 0 - epee::log_space::get_set_log_detalisation_level(true, LOG_LEVEL_0); - - // Set log level - { - int new_log_level = command_line::get_arg(vm, daemon_args::arg_log_level); - if(new_log_level < LOG_LEVEL_MIN || new_log_level > LOG_LEVEL_MAX) - { - LOG_PRINT_L0("Wrong log level value: " << new_log_level); - } - else if (epee::log_space::get_set_log_detalisation_level(false) != new_log_level) - { - epee::log_space::get_set_log_detalisation_level(true, new_log_level); - int otshell_utils_log_level = 100 - (new_log_level * 20); - gCurrentLogger.setDebugLevel(otshell_utils_log_level); - LOG_PRINT_L0("LOG_LEVEL set to " << new_log_level); - } - } - - // log_file_path - // default: <data_dir>/<CRYPTONOTE_NAME>.log - // if log-file argument given: - // absolute path - // relative path: relative to data_dir - - // Set log file - { - bf::path log_file_path {data_dir / std::string(CRYPTONOTE_NAME ".log")}; - if (! vm["log-file"].defaulted()) - log_file_path = command_line::get_arg(vm, daemon_args::arg_log_file); - log_file_path = bf::absolute(log_file_path, relative_path_base); - - epee::log_space::log_singletone::add_logger( - LOGGER_FILE - , log_file_path.filename().string().c_str() - , log_file_path.parent_path().string().c_str() - ); #ifdef STACK_TRACE - tools::set_stack_trace_log(log_file_path.filename().string()); + tools::set_stack_trace_log(log_file_path.filename().string()); #endif // STACK_TRACE - } if (command_line::has_arg(vm, daemon_args::arg_max_concurrency)) tools::set_max_concurrency(command_line::get_arg(vm, daemon_args::arg_max_concurrency)); // logging is now set up - LOG_PRINT_L0("Monero '" << MONERO_RELEASE_NAME << "' (v" << MONERO_VERSION_FULL << ")"); + MGINFO("Monero '" << MONERO_RELEASE_NAME << "' (v" << MONERO_VERSION_FULL << ")"); - _note_c("dbg/main", "Moving from main() into the daemonize now."); + MINFO("Moving from main() into the daemonize now."); return daemonizer::daemonize(argc, argv, daemonize::t_executor{}, vm); } diff --git a/src/daemon/p2p.h b/src/daemon/p2p.h index 3858989ce..f29c2d822 100644 --- a/src/daemon/p2p.h +++ b/src/daemon/p2p.h @@ -34,6 +34,9 @@ #include "p2p/net_node.h" #include "daemon/protocol.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { @@ -57,12 +60,12 @@ public: : m_server{protocol.get()} { //initialize objects - LOG_PRINT_L0("Initializing p2p server..."); + MGINFO("Initializing p2p server..."); if (!m_server.init(vm)) { throw std::runtime_error("Failed to initialize p2p server."); } - LOG_PRINT_L0("P2p server initialized OK"); + MGINFO("P2p server initialized OK"); } t_node_server & get() @@ -72,9 +75,9 @@ public: void run() { - LOG_PRINT_L0("Starting p2p net loop..."); + MGINFO("Starting p2p net loop..."); m_server.run(); - LOG_PRINT_L0("p2p net loop stopped"); + MGINFO("p2p net loop stopped"); } void stop() @@ -84,11 +87,11 @@ public: ~t_p2p() { - LOG_PRINT_L0("Deinitializing p2p..."); + MGINFO("Deinitializing p2p..."); try { m_server.deinit(); } catch (...) { - LOG_PRINT_L0("Failed to deinitialize p2p..."); + MERROR("Failed to deinitialize p2p..."); } } }; diff --git a/src/daemon/protocol.h b/src/daemon/protocol.h index eb894fb81..bc2333659 100644 --- a/src/daemon/protocol.h +++ b/src/daemon/protocol.h @@ -30,6 +30,9 @@ #pragma once +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { @@ -47,12 +50,12 @@ public: ) : m_protocol{core.get(), nullptr} { - LOG_PRINT_L0("Initializing cryptonote protocol..."); + MGINFO("Initializing cryptonote protocol..."); if (!m_protocol.init(vm)) { throw std::runtime_error("Failed to initialize cryptonote protocol."); } - LOG_PRINT_L0("Cryptonote protocol initialized OK"); + MGINFO("Cryptonote protocol initialized OK"); } t_protocol_raw & get() @@ -69,11 +72,11 @@ public: ~t_protocol() { - LOG_PRINT_L0("Stopping cryptonote protocol..."); + MGINFO("Stopping cryptonote protocol..."); try { m_protocol.deinit(); m_protocol.set_p2p_endpoint(nullptr); - LOG_PRINT_L0("Cryptonote protocol stopped successfully"); + MGINFO("Cryptonote protocol stopped successfully"); } catch (...) { LOG_ERROR("Failed to stop cryptonote protocol!"); } diff --git a/src/daemon/rpc.h b/src/daemon/rpc.h index bfd2afd84..8b0d5808d 100644 --- a/src/daemon/rpc.h +++ b/src/daemon/rpc.h @@ -32,6 +32,9 @@ #include "rpc/core_rpc_server.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { @@ -52,27 +55,27 @@ public: ) : m_server{core.get(), p2p.get()} { - LOG_PRINT_L0("Initializing core rpc server..."); + MGINFO("Initializing core rpc server..."); if (!m_server.init(vm)) { throw std::runtime_error("Failed to initialize core rpc server."); } - LOG_PRINT_GREEN("Core rpc server initialized OK on port: " << m_server.get_binded_port(), LOG_LEVEL_0); + MGINFO("Core rpc server initialized OK on port: " << m_server.get_binded_port()); } void run() { - LOG_PRINT_L0("Starting core rpc server..."); + MGINFO("Starting core rpc server..."); if (!m_server.run(2, false)) { throw std::runtime_error("Failed to start core rpc server."); } - LOG_PRINT_L0("Core rpc server started ok"); + MGINFO("Core rpc server started ok"); } void stop() { - LOG_PRINT_L0("Stopping core rpc server..."); + MGINFO("Stopping core rpc server..."); m_server.send_stop_signal(); m_server.timed_wait_server_stop(5000); } @@ -84,11 +87,11 @@ public: ~t_rpc() { - LOG_PRINT_L0("Deinitializing rpc server..."); + MGINFO("Deinitializing rpc server..."); try { m_server.deinit(); } catch (...) { - LOG_PRINT_L0("Failed to deinitialize rpc server..."); + MERROR("Failed to deinitialize rpc server..."); } } }; diff --git a/src/daemon/rpc_command_executor.cpp b/src/daemon/rpc_command_executor.cpp index c7a122d00..8558ebc17 100644 --- a/src/daemon/rpc_command_executor.cpp +++ b/src/daemon/rpc_command_executor.cpp @@ -38,6 +38,9 @@ #include <ctime> #include <string> +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { namespace { @@ -517,6 +520,34 @@ bool t_rpc_command_executor::set_log_level(int8_t level) { return true; } +bool t_rpc_command_executor::set_log_categories(const std::string &categories) { + cryptonote::COMMAND_RPC_SET_LOG_CATEGORIES::request req; + cryptonote::COMMAND_RPC_SET_LOG_CATEGORIES::response res; + req.categories = categories; + + std::string fail_message = "Unsuccessful"; + + if (m_is_rpc) + { + if (!m_rpc_client->rpc_request(req, res, "/set_log_categories", fail_message.c_str())) + { + return true; + } + } + else + { + if (!m_rpc_server->on_set_log_categories(req, res) || res.status != CORE_RPC_STATUS_OK) + { + tools::fail_msg_writer() << fail_message.c_str(); + return true; + } + } + + tools::success_msg_writer() << "Log categories are now " << categories; + + return true; +} + bool t_rpc_command_executor::print_height() { cryptonote::COMMAND_RPC_GET_HEIGHT::request req; cryptonote::COMMAND_RPC_GET_HEIGHT::response res; diff --git a/src/daemon/rpc_command_executor.h b/src/daemon/rpc_command_executor.h index af283c1f1..afcd99d32 100644 --- a/src/daemon/rpc_command_executor.h +++ b/src/daemon/rpc_command_executor.h @@ -45,6 +45,9 @@ #include "p2p/net_node.h" #include "rpc/core_rpc_server.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "daemon" + namespace daemonize { class t_rpc_command_executor final { @@ -82,6 +85,8 @@ public: bool set_log_level(int8_t level); + bool set_log_categories(const std::string &categories); + bool print_height(); bool print_block_by_hash(crypto::hash block_hash); diff --git a/src/p2p/connection_basic.cpp b/src/p2p/connection_basic.cpp index 981a02882..80915e9a3 100644 --- a/src/p2p/connection_basic.cpp +++ b/src/p2p/connection_basic.cpp @@ -77,14 +77,13 @@ #include <boost/asio/ip/unicast.hpp> #include "../../contrib/epee/include/net/abstract_tcp_server2.h" -#include "../../contrib/otshell_utils/utils.hpp" -#include "data_logger.hpp" -using namespace nOT::nUtils; - // TODO: #include "../../src/p2p/network_throttle-detail.hpp" #include "../../src/cryptonote_core/cryptonote_core.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.p2p" + // ################################################################################################ // local (TU local) headers // ################################################################################################ @@ -219,19 +218,6 @@ uint64_t connection_basic::get_rate_down_limit() { } void connection_basic::save_limit_to_file(int limit) { - // saving limit to file - if (!epee::net_utils::data_logger::m_save_graph) - return; - - { - CRITICAL_REGION_LOCAL( network_throttle_manager::m_lock_get_global_throttle_out ); - epee::net_utils::data_logger::get_instance().add_data("upload_limit", network_throttle_manager::get_global_throttle_out().get_target_speed() / 1024); - } - - { - CRITICAL_REGION_LOCAL( network_throttle_manager::m_lock_get_global_throttle_in ); - epee::net_utils::data_logger::get_instance().add_data("download_limit", network_throttle_manager::get_global_throttle_in().get_target_speed() / 1024); - } } void connection_basic::set_tos_flag(int tos) { @@ -259,9 +245,8 @@ void connection_basic::sleep_before_packet(size_t packet_size, int phase, int q delay *= 0.50; if (delay > 0) { long int ms = (long int)(delay * 1000); - _info_c("net/sleep", "Sleeping in " << __FUNCTION__ << " for " << ms << " ms before packet_size="<<packet_size); // debug sleep + MDEBUG("Sleeping in " << __FUNCTION__ << " for " << ms << " ms before packet_size="<<packet_size); // debug sleep _dbg1("sleep in sleep_before_packet"); - epee::net_utils::data_logger::get_instance().add_data("sleep_up", ms); boost::this_thread::sleep(boost::posix_time::milliseconds( ms ) ); } } while(delay > 0); @@ -280,25 +265,21 @@ void connection_basic::set_start_time() { void connection_basic::do_send_handler_write(const void* ptr , size_t cb ) { sleep_before_packet(cb,1,-1); - _info_c("net/out/size", "handler_write (direct) - before ASIO write, for packet="<<cb<<" B (after sleep)"); + MDEBUG("handler_write (direct) - before ASIO write, for packet="<<cb<<" B (after sleep)"); set_start_time(); } void connection_basic::do_send_handler_write_from_queue( const boost::system::error_code& e, size_t cb, int q_len ) { sleep_before_packet(cb,2,q_len); - _info_c("net/out/size", "handler_write (after write, from queue="<<q_len<<") - before ASIO write, for packet="<<cb<<" B (after sleep)"); + MDEBUG("handler_write (after write, from queue="<<q_len<<") - before ASIO write, for packet="<<cb<<" B (after sleep)"); set_start_time(); } void connection_basic::logger_handle_net_read(size_t size) { // network data read - size /= 1024; - epee::net_utils::data_logger::get_instance().add_data("download", size); } void connection_basic::logger_handle_net_write(size_t size) { - size /= 1024; - epee::net_utils::data_logger::get_instance().add_data("upload", size); } double connection_basic::get_sleep_time(size_t cb) { @@ -308,7 +289,6 @@ double connection_basic::get_sleep_time(size_t cb) { } void connection_basic::set_save_graph(bool save_graph) { - epee::net_utils::data_logger::m_save_graph = save_graph; } diff --git a/src/p2p/data_logger.cpp b/src/p2p/data_logger.cpp deleted file mode 100644 index fe54aef63..000000000 --- a/src/p2p/data_logger.cpp +++ /dev/null @@ -1,202 +0,0 @@ -// Copyright (c) 2014-2016, The Monero Project -// -// All rights reserved. -// -// Redistribution and use in source and binary forms, with or without modification, are -// permitted provided that the following conditions are met: -// -// 1. Redistributions of source code must retain the above copyright notice, this list of -// conditions and the following disclaimer. -// -// 2. Redistributions in binary form must reproduce the above copyright notice, this list -// of conditions and the following disclaimer in the documentation and/or other -// materials provided with the distribution. -// -// 3. Neither the name of the copyright holder nor the names of its contributors may be -// used to endorse or promote products derived from this software without specific -// prior written permission. -// -// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY -// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF -// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL -// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, -// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, -// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF -// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -#include "data_logger.hpp" -#include <stdexcept> - -#include <boost/chrono.hpp> -#include <boost/filesystem.hpp> -#include <boost/thread.hpp> -#include <chrono> -#include "../../contrib/otshell_utils/utils.hpp" - -namespace epee -{ -namespace net_utils -{ - data_logger &data_logger::get_instance() { - boost::call_once(m_singleton, - [] { - _info_c("dbg/data","Creating singleton of data_logger"); - if (m_state != data_logger_state::state_before_init) { _erro_c("dbg/data","Internal error in singleton"); throw std::runtime_error("data_logger singleton"); } - m_state = data_logger_state::state_during_init; - m_obj.reset(new data_logger()); - m_state = data_logger_state::state_ready_to_use; - } - ); - - if (m_state != data_logger_state::state_ready_to_use) { - _erro ("trying to use not working data_logger"); - throw std::runtime_error("data_logger ctor state"); - } - - return * m_obj; - } - - data_logger::data_logger() { - _note_c("dbg/data","Starting data logger (for graphs data)"); - if (m_state != data_logger_state::state_during_init) { _erro_c("dbg/data","Singleton ctor state"); throw std::runtime_error("data_logger ctor state"); } - boost::lock_guard<boost::mutex> lock(mMutex); // lock - - // prepare all the files for given data channels: - mFilesMap["peers"] = data_logger::fileData("log/dr-monero/peers.data"); - mFilesMap["download"] = data_logger::fileData("log/dr-monero/net/in-all.data"); - mFilesMap["upload"] = data_logger::fileData("log/dr-monero/net/out-all.data"); - mFilesMap["request"] = data_logger::fileData("log/dr-monero/net/req-all.data"); - mFilesMap["sleep_down"] = data_logger::fileData("log/dr-monero/down_sleep_log.data"); - mFilesMap["sleep_up"] = data_logger::fileData("log/dr-monero/up_sleep_log.data"); - mFilesMap["calc_time"] = data_logger::fileData("log/dr-monero/get_objects_calc_time.data"); - mFilesMap["blockchain_processing_time"] = data_logger::fileData("log/dr-monero/blockchain_log.data"); - mFilesMap["block_processing"] = data_logger::fileData("log/dr-monero/block_proc.data"); - - mFilesMap["peers_limit"] = data_logger::fileData("log/dr-monero/peers_limit.info"); - mFilesMap["download_limit"] = data_logger::fileData("log/dr-monero/limit_down.info"); - mFilesMap["upload_limit"] = data_logger::fileData("log/dr-monero/limit_up.info"); - - mFilesMap["peers_limit"].mLimitFile = true; - mFilesMap["download_limit"].mLimitFile = true; - mFilesMap["upload_limit"].mLimitFile = true; - - // do NOT modify mFilesMap below this point, since there is no locking for this used (yet) - - _info_c("dbg/data","Creating thread for data logger"); // create timer thread - m_thread_maybe_running=true; - std::shared_ptr<boost::thread> logger_thread(new boost::thread([&]() { - _info_c("dbg/data","Inside thread for data logger"); - while (m_state == data_logger_state::state_during_init) { // wait for creation to be done (in other thread, in singleton) before actually running - boost::this_thread::sleep_for(boost::chrono::seconds(1)); - } - _info_c("dbg/data","Inside thread for data logger - going into main loop"); - while (m_state == data_logger_state::state_ready_to_use) { // run as long as we are not closing the single object - boost::this_thread::sleep_for(boost::chrono::seconds(1)); - saveToFile(); // save all the pending data - } - _info_c("dbg/data","Inside thread for data logger - done the main loop"); - m_thread_maybe_running=false; - })); - logger_thread->detach(); - _info_c("dbg/data","Data logger constructed"); - } - - data_logger::~data_logger() noexcept(false) { - _note_c("dbg/data","Destructor of the data logger"); - { - boost::lock_guard<boost::mutex> lock(mMutex); - m_state = data_logger_state::state_dying; - } - _info_c("dbg/data","State was set to dying"); - while(m_thread_maybe_running) { // wait for the thread to exit - boost::this_thread::sleep_for(boost::chrono::seconds(1)); - _info_c("dbg/data","Waiting for background thread to exit"); - } - _info_c("dbg/data","Thread exited"); - } - - void data_logger::kill_instance() { - m_state = data_logger_state::state_dying; - m_obj.reset(); - } - - void data_logger::add_data(std::string filename, unsigned int data) { - boost::lock_guard<boost::mutex> lock(mMutex); - if (m_state != data_logger_state::state_ready_to_use) { _info_c("dbg/data","Data logger is not ready, returning."); return; } - - if (mFilesMap.find(filename) == mFilesMap.end()) { // no such file/counter - _erro_c("dbg/data","Trying to use not opened data file filename="<<filename); - _erro_c("dbg/data","Disabling saving of graphs due to error"); - m_save_graph=false; // <--- disabling saving graphs - return; - } - - if (mFilesMap[filename].mLimitFile) { // this holds a number (that is not additive) - e.g. the limit setting - mFilesMap[filename].mDataToSave = data; - } else { - mFilesMap[filename].mDataToSave += data; // this holds a number that should be sum of all accumulated samples - } - } - - bool data_logger::is_dying() { - if (m_state == data_logger_state::state_dying) { - return true; - } - else { - return false; - } - } - - void data_logger::saveToFile() { - _dbg2_c("dbg/data","saving to files"); - boost::lock_guard<boost::mutex> lock(mMutex); - if (m_state != data_logger_state::state_ready_to_use) { _info_c("dbg/data","Data logger is not ready, returning."); return; } - nOT::nUtils::cFilesystemUtils::CreateDirTree("log/dr-monero/net/"); - for (auto &element : mFilesMap) - { - element.second.save(); - if (!element.second.mLimitFile) element.second.mDataToSave = 0; - } - } - - // the inner class: - - double data_logger::fileData::get_current_time() { - #if defined(__APPLE__) - auto point = std::chrono::system_clock::now(); - #else - auto point = std::chrono::steady_clock::now(); - #endif - auto time_from_epoh = point.time_since_epoch(); - auto ms = std::chrono::duration_cast< std::chrono::milliseconds >( time_from_epoh ).count(); - double ms_f = ms; - return ms_f / 1000.; - } - - data_logger::fileData::fileData(std::string pFile) { - _dbg3_c("dbg/data","opening data file named pFile="<<pFile<<" for this="<<this); - mFile = std::make_shared<std::ofstream> (pFile); - _dbg1_c("dbg/data","opened data file named pFile="<<pFile<<" in mFile="<<mFile<<" for this="<<this); - mPath = pFile; - } - - void data_logger::fileData::save() { - if (!data_logger::m_save_graph) return; // <--- disabled - _dbg2_c("dbg/data","saving to the file now, mFile="<<mFile); - mFile->open(mPath, std::ios::app); - *mFile << static_cast<int>(get_current_time()) << " " << mDataToSave << std::endl; - mFile->close(); - } - - -data_logger_state data_logger::m_state(data_logger_state::state_before_init); ///< (static) state of the singleton object -std::atomic<bool> data_logger::m_save_graph(false); // (static) -std::atomic<bool> data_logger::m_thread_maybe_running(false); // (static) -boost::once_flag data_logger::m_singleton; // (static) -std::unique_ptr<data_logger> data_logger::m_obj; // (static) - -} // namespace -} // namespace - diff --git a/src/p2p/data_logger.hpp b/src/p2p/data_logger.hpp deleted file mode 100644 index 278d08bfc..000000000 --- a/src/p2p/data_logger.hpp +++ /dev/null @@ -1,105 +0,0 @@ -// Copyright (c) 2014-2016, The Monero Project -// -// All rights reserved. -// -// Redistribution and use in source and binary forms, with or without modification, are -// permitted provided that the following conditions are met: -// -// 1. Redistributions of source code must retain the above copyright notice, this list of -// conditions and the following disclaimer. -// -// 2. Redistributions in binary form must reproduce the above copyright notice, this list -// of conditions and the following disclaimer in the documentation and/or other -// materials provided with the distribution. -// -// 3. Neither the name of the copyright holder nor the names of its contributors may be -// used to endorse or promote products derived from this software without specific -// prior written permission. -// -// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY -// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF -// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL -// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, -// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS -// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, -// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF -// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -#ifndef INCLUDED_p2p_data_logger_hpp -#define INCLUDED_p2p_data_logger_hpp - -#include <string> -#include <map> -#include <fstream> -#include <memory> -#include <boost/thread/thread.hpp> -#include <boost/thread/mutex.hpp> -#include <boost/thread/once.hpp> -#include <atomic> - -namespace epee -{ -namespace net_utils -{ - -enum class data_logger_state { state_before_init, state_during_init, state_ready_to_use, state_dying }; - -/*** -@note: use it ONLY via singleton! It will be spawned then, and will auto destruct on program exit. -@note: do call ::kill_instance() before exiting main, at end of main. But before make sure no one else (e.g. no other threads) will try to use this/singleton -@note: it is not allowed to use this class from code "runnig before or after main", e.g. from ctors of static objects, because of static-creation-order races -@note: on creation (e.g. from singleton), it spawns a thread that saves all data in background -*/ - class data_logger { - public: - static data_logger &get_instance(); ///< singleton - static void kill_instance(); ///< call this before ending main to allow more gracefull shutdown of the main singleton and it's background thread - ~data_logger() noexcept(false); ///< destr, will be called when singleton is killed when global m_obj dies. will kill theads etc - - private: - data_logger(); ///< constructor is private, use only via singleton get_instance - - public: - data_logger(const data_logger &ob) = delete; // use only one per program - data_logger(data_logger &&ob) = delete; - data_logger & operator=(const data_logger&) = delete; - data_logger & operator=(data_logger&&) = delete; - - void add_data(std::string filename, unsigned int data); ///< use this to append data here. Use it only the singleton. It locks itself. - - static std::atomic<bool> m_save_graph; ///< global setting flag, should we save all the data or not (can disable logging graphs data) - static bool is_dying(); - - private: - static boost::once_flag m_singleton; ///< to guarantee singleton creates the object exactly once - static data_logger_state m_state; ///< state of the singleton object - static std::atomic<bool> m_thread_maybe_running; ///< is the background thread (more or less) running, or is it fully finished - static std::unique_ptr<data_logger> m_obj; ///< the singleton object. Only use it via get_instance(). Can be killed by kill_instance() - - /*** - * one graph/file with data - */ - class fileData { - public: - fileData() = default; - fileData(const fileData &ob) = delete; - fileData(std::string pFile); - - std::shared_ptr<std::ofstream> mFile; - long int mDataToSave = 0; ///< sum of the data (in current interval, will be counted from 0 on next interval) - static double get_current_time(); - void save(); - std::string mPath; - bool mLimitFile = false; ///< this holds a number (that is not additive) - e.g. the limit setting - }; - - std::map<std::string, fileData> mFilesMap; - boost::mutex mMutex; - void saveToFile(); ///< write data to the target files. do not use this directly - }; - -} // namespace -} // namespace - -#endif diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl index f32e7a435..34a3f9363 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl @@ -48,7 +48,6 @@ #include "net/local_ip.h" #include "crypto/crypto.h" #include "storages/levin_abstract_invoke2.h" -#include "data_logger.hpp" // We have to look for miniupnpc headers in different places, dependent on if its compiled or external #ifdef UPNP_STATIC @@ -61,6 +60,9 @@ #include "upnperrors.h" #endif +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.p2p" + #define NET_MAKE_IP(b1,b2,b3,b4) ((LPARAM)(((DWORD)(b1)<<24)+((DWORD)(b2)<<16)+((DWORD)(b3)<<8)+((DWORD)(b4)))) @@ -203,7 +205,7 @@ namespace nodetool if(time(nullptr) >= it->second) { m_blocked_ips.erase(it); - LOG_PRINT_CYAN("IP " << epee::string_tools::get_ip_string_from_int32(addr) << " unblocked.", LOG_LEVEL_0); + MLOG_CYAN(el::Level::Info, "IP " << epee::string_tools::get_ip_string_from_int32(addr) << " unblocked."); return true; } return false; @@ -235,7 +237,7 @@ namespace nodetool for (const auto &c: conns) m_net_server.get_config_object().close(c); - LOG_PRINT_CYAN("IP " << epee::string_tools::get_ip_string_from_int32(addr) << " blocked.", LOG_LEVEL_0); + MLOG_CYAN(el::Level::Info, "IP " << epee::string_tools::get_ip_string_from_int32(addr) << " blocked."); return true; } //----------------------------------------------------------------------------------- @@ -247,7 +249,7 @@ namespace nodetool if (i == m_blocked_ips.end()) return false; m_blocked_ips.erase(i); - LOG_PRINT_CYAN("IP " << epee::string_tools::get_ip_string_from_int32(addr) << " unblocked.", LOG_LEVEL_0); + MLOG_CYAN(el::Level::Info, "IP " << epee::string_tools::get_ip_string_from_int32(addr) << " unblocked."); return true; } //----------------------------------------------------------------------------------- @@ -256,7 +258,7 @@ namespace nodetool { CRITICAL_REGION_LOCAL(m_ip_fails_score_lock); uint64_t fails = ++m_ip_fails_score[address]; - LOG_PRINT_CYAN("IP " << epee::string_tools::get_ip_string_from_int32(address) << " fail score=" << fails, LOG_LEVEL_1); + MDEBUG("IP " << epee::string_tools::get_ip_string_from_int32(address) << " fail score=" << fails); if(fails > P2P_IP_FAILS_BEFORE_BLOCK) { auto it = m_ip_fails_score.find(address); @@ -376,11 +378,11 @@ namespace nodetool na.ip = boost::asio::detail::socket_ops::host_to_network_long(endpoint.address().to_v4().to_ulong()); na.port = endpoint.port(); seed_nodes.push_back(na); - LOG_PRINT_L4("Added seed node: " << endpoint.address().to_v4().to_string(ec) << ':' << na.port); + MINFO("Added seed node: " << endpoint.address().to_v4().to_string(ec) << ':' << na.port); } else { - LOG_PRINT_L2("IPv6 doesn't supported, skip '" << host << "' -> " << endpoint.address().to_v6().to_string(ec)); + MDEBUG("IPv6 doesn't supported, skip '" << host << "' -> " << endpoint.address().to_v6().to_string(ec)); } } } @@ -416,7 +418,7 @@ namespace nodetool { boost::thread* th = new boost::thread([=, &dns_results, &addr_str] { - LOG_PRINT_L4("dns_threads[" << result_index << "] created for: " << addr_str); + MDEBUG("dns_threads[" << result_index << "] created for: " << addr_str); // TODO: care about dnssec avail/valid bool avail, valid; std::vector<std::string> addr_list; @@ -424,7 +426,7 @@ namespace nodetool try { addr_list = tools::DNSResolver::instance().get_ipv4(addr_str, avail, valid); - LOG_PRINT_L4("dns_threads[" << result_index << "] DNS resolve done"); + MDEBUG("dns_threads[" << result_index << "] DNS resolve done"); boost::this_thread::interruption_point(); } catch(const boost::thread_interrupted&) @@ -432,11 +434,11 @@ namespace nodetool // thread interruption request // even if we now have results, finish thread without setting // result variables, which are now out of scope in main thread - LOG_PRINT_L4("dns_threads[" << result_index << "] interrupted"); + MWARNING("dns_threads[" << result_index << "] interrupted"); return; } - LOG_PRINT_L4("dns_threads[" << result_index << "] addr_str: " << addr_str << " number of results: " << addr_list.size()); + MINFO("dns_threads[" << result_index << "] addr_str: " << addr_str << " number of results: " << addr_list.size()); dns_results[result_index] = addr_list; }); @@ -444,14 +446,14 @@ namespace nodetool ++result_index; } - LOG_PRINT_L4("dns_threads created, now waiting for completion or timeout of " << CRYPTONOTE_DNS_TIMEOUT_MS << "ms"); + MDEBUG("dns_threads created, now waiting for completion or timeout of " << CRYPTONOTE_DNS_TIMEOUT_MS << "ms"); boost::chrono::system_clock::time_point deadline = boost::chrono::system_clock::now() + boost::chrono::milliseconds(CRYPTONOTE_DNS_TIMEOUT_MS); uint64_t i = 0; for (boost::thread* th : dns_threads) { if (! th->try_join_until(deadline)) { - LOG_PRINT_L4("dns_threads[" << i << "] timed out, sending interrupt"); + MWARNING("dns_threads[" << i << "] timed out, sending interrupt"); th->interrupt(); } ++i; @@ -460,7 +462,7 @@ namespace nodetool i = 0; for (const auto& result : dns_results) { - LOG_PRINT_L4("DNS lookup for " << m_seed_nodes_list[i] << ": " << result.size() << " results"); + MDEBUG("DNS lookup for " << m_seed_nodes_list[i] << ": " << result.size() << " results"); // if no results for node, thread's lookup likely timed out if (result.size()) { @@ -472,7 +474,7 @@ namespace nodetool if (!full_addrs.size()) { - LOG_PRINT_L0("DNS seed node lookup either timed out or failed, falling back to defaults"); + MINFO("DNS seed node lookup either timed out or failed, falling back to defaults"); full_addrs.insert("198.74.231.92:18080"); full_addrs.insert("161.67.132.39:18080"); full_addrs.insert("163.172.182.165:18080"); @@ -483,10 +485,10 @@ namespace nodetool for (const auto& full_addr : full_addrs) { - LOG_PRINT_L2("Seed node: " << full_addr); + MDEBUG("Seed node: " << full_addr); append_net_address(m_seed_nodes, full_addr); } - LOG_PRINT_L1("Number of seed nodes: " << m_seed_nodes.size()); + MDEBUG("Number of seed nodes: " << m_seed_nodes.size()); bool res = handle_command_line(vm, testnet); CHECK_AND_ASSERT_MES(res, false, "Failed to handle command line"); @@ -520,18 +522,18 @@ namespace nodetool return res; //try to bind - LOG_PRINT_L0("Binding on " << m_bind_ip << ":" << m_port); + MINFO("Binding on " << m_bind_ip << ":" << m_port); res = m_net_server.init_server(m_port, m_bind_ip); CHECK_AND_ASSERT_MES(res, false, "Failed to bind server"); m_listenning_port = m_net_server.get_binded_port(); - LOG_PRINT_GREEN("Net service bound to " << m_bind_ip << ":" << m_listenning_port, LOG_LEVEL_0); + MLOG_GREEN(el::Level::Info, "Net service bound to " << m_bind_ip << ":" << m_listenning_port); if(m_external_port) - LOG_PRINT_L0("External port defined as " << m_external_port); + MDEBUG("External port defined as " << m_external_port); // Add UPnP port mapping if(m_no_igd == false) { - LOG_PRINT_L0("Attempting to add IGD port mapping."); + MDEBUG("Attempting to add IGD port mapping."); int result; #if MINIUPNPC_API_VERSION > 13 // default according to miniupnpc.h @@ -558,19 +560,19 @@ namespace nodetool if (portMappingResult != 0) { LOG_ERROR("UPNP_AddPortMapping failed, error: " << strupnperror(portMappingResult)); } else { - LOG_PRINT_GREEN("Added IGD port mapping.", LOG_LEVEL_0); + MLOG_GREEN(el::Level::Info, "Added IGD port mapping."); } } else if (result == 2) { - LOG_PRINT_L0("IGD was found but reported as not connected."); + MWARNING("IGD was found but reported as not connected."); } else if (result == 3) { - LOG_PRINT_L0("UPnP device was found but not recognized as IGD."); + MWARNING("UPnP device was found but not recognized as IGD."); } else { - LOG_ERROR("UPNP_GetValidIGD returned an unknown result code."); + MWARNING("UPNP_GetValidIGD returned an unknown result code."); } FreeUPNPUrls(&urls); } else { - LOG_PRINT_L0("No IGD was found."); + MINFO("No IGD was found."); } } return res; @@ -600,9 +602,6 @@ namespace nodetool }); // lambda m_current_number_of_out_peers = number_of_peers; - if (epee::net_utils::data_logger::is_dying()) - break; - epee::net_utils::data_logger::get_instance().add_data("peers", number_of_peers); boost::this_thread::sleep_for(boost::chrono::seconds(1)); } // main loop of thread @@ -619,13 +618,13 @@ namespace nodetool attrs.set_stack_size(THREAD_STACK_SIZE); //go to loop - LOG_PRINT("Run net_service loop( " << thrds_count << " threads)...", LOG_LEVEL_0); + MINFO("Run net_service loop( " << thrds_count << " threads)..."); if(!m_net_server.run_server(thrds_count, true, attrs)) { LOG_ERROR("Failed to run net tcp server!"); } - LOG_PRINT("net_service loop stopped.", LOG_LEVEL_0); + MINFO("net_service loop stopped."); return true; } @@ -652,7 +651,7 @@ namespace nodetool TRY_ENTRY(); if (!tools::create_directories_if_necessary(m_config_folder)) { - LOG_PRINT_L0("Failed to create data directory: " << m_config_folder); + MWARNING("Failed to create data directory: " << m_config_folder); return false; } @@ -661,7 +660,7 @@ namespace nodetool p2p_data.open( state_file_path , std::ios_base::binary | std::ios_base::out| std::ios::trunc); if(p2p_data.fail()) { - LOG_PRINT_L0("Failed to save config to file " << state_file_path); + MWARNING("Failed to save config to file " << state_file_path); return false; }; @@ -678,7 +677,7 @@ namespace nodetool { m_payload_handler.stop(); m_net_server.send_stop_signal(); - LOG_PRINT_L0("[node] Stop signal sent"); + MDEBUG("[node] Stop signal sent"); return true; } //----------------------------------------------------------------------------------- @@ -702,19 +701,19 @@ namespace nodetool if(code < 0) { - LOG_PRINT_CC_RED(context, "COMMAND_HANDSHAKE invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")", LOG_LEVEL_1); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")"); return; } if(rsp.node_data.network_id != m_network_id) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE Failed, wrong network! (" << epee::string_tools::get_str_from_guid_a(rsp.node_data.network_id) << "), closing connection."); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE Failed, wrong network! (" << epee::string_tools::get_str_from_guid_a(rsp.node_data.network_id) << "), closing connection."); return; } if(!handle_remote_peerlist(rsp.local_peerlist, rsp.node_data.local_time, context)) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE: failed to handle_remote_peerlist(...), closing connection."); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE: failed to handle_remote_peerlist(...), closing connection."); add_ip_fail(context.m_remote_ip); return; } @@ -723,7 +722,7 @@ namespace nodetool { if(!m_payload_handler.process_payload_sync_data(rsp.payload_data, context, true)) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE invoked, but process_payload_sync_data returned false, dropping connection."); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE invoked, but process_payload_sync_data returned false, dropping connection."); hsh_result = false; return; } @@ -733,14 +732,14 @@ namespace nodetool if(rsp.node_data.peer_id == m_config.m_peer_id) { - LOG_PRINT_CCONTEXT_L2("Connection to self detected, dropping connection"); + LOG_DEBUG_CC(context, "Connection to self detected, dropping connection"); hsh_result = false; return; } - LOG_PRINT_CCONTEXT_L1(" COMMAND_HANDSHAKE INVOKED OK"); + LOG_DEBUG_CC(context, " COMMAND_HANDSHAKE INVOKED OK"); }else { - LOG_PRINT_CCONTEXT_L1(" COMMAND_HANDSHAKE(AND CLOSE) INVOKED OK"); + LOG_DEBUG_CC(context, " COMMAND_HANDSHAKE(AND CLOSE) INVOKED OK"); } }, P2P_DEFAULT_HANDSHAKE_INVOKE_TIMEOUT); @@ -751,7 +750,7 @@ namespace nodetool if(!hsh_result) { - LOG_PRINT_CC_L1(context_, "COMMAND_HANDSHAKE Failed"); + LOG_ERROR_CC(context_, "COMMAND_HANDSHAKE Failed"); m_net_server.get_config_object().close(context_.m_connection_id); } else @@ -776,13 +775,13 @@ namespace nodetool { if(code < 0) { - LOG_PRINT_CC_RED(context, "COMMAND_TIMED_SYNC invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")", LOG_LEVEL_1); + LOG_ERROR_CC(context, "COMMAND_TIMED_SYNC invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")"); return; } if(!handle_remote_peerlist(rsp.local_peerlist, rsp.local_time, context)) { - LOG_ERROR_CCONTEXT("COMMAND_TIMED_SYNC: failed to handle_remote_peerlist(...), closing connection."); + LOG_WARNING_CC(context, "COMMAND_TIMED_SYNC: failed to handle_remote_peerlist(...), closing connection."); m_net_server.get_config_object().close(context.m_connection_id ); add_ip_fail(context.m_remote_ip); } @@ -793,7 +792,7 @@ namespace nodetool if(!r) { - LOG_PRINT_CC_L2(context_, "COMMAND_TIMED_SYNC Failed"); + LOG_ERROR_CC(context_, "COMMAND_TIMED_SYNC Failed"); return false; } return true; @@ -808,7 +807,7 @@ namespace nodetool size_t x = crypto::rand<size_t>()%(max_index+1); size_t res = (x*x*x)/(max_index*max_index); //parabola \/ - LOG_PRINT_L3("Random connection index=" << res << "(x="<< x << ", max_index=" << max_index << ")"); + MDEBUG("Random connection index=" << res << "(x="<< x << ", max_index=" << max_index << ")"); return res; } //----------------------------------------------------------------------------------- @@ -853,9 +852,9 @@ namespace nodetool #define LOG_PRINT_CC_PRIORITY_NODE(priority, con, msg) \ do { \ if (priority) {\ - LOG_PRINT_CC_L1(con, msg); \ + LOG_INFO_CC(con, "[priority]" << msg); \ } else {\ - LOG_PRINT_CC_L1(con, msg); \ + LOG_INFO_CC(con, msg); \ } \ } while(0) @@ -872,7 +871,7 @@ namespace nodetool m_current_number_of_out_peers --; // atomic variable, update time = 1s return false; } - LOG_PRINT_L1("Connecting to " << epee::string_tools::get_ip_string_from_int32(na.ip) << ":" + MDEBUG("Connecting to " << epee::string_tools::get_ip_string_from_int32(na.ip) << ":" << epee::string_tools::num_to_string_fast(na.port) << "(white=" << white << ", last_seen: " << (last_seen_stamp ? epee::misc_utils::get_time_interval_string(time(NULL) - last_seen_stamp):"never") << ")..."); @@ -910,7 +909,7 @@ namespace nodetool if(just_take_peerlist) { m_net_server.get_config_object().close(con.m_connection_id); - LOG_PRINT_CC_GREEN(con, "CONNECTION HANDSHAKED OK AND CLOSED.", LOG_LEVEL_2); + LOG_DEBUG_CC(con, "CONNECTION HANDSHAKED OK AND CLOSED."); return true; } @@ -923,7 +922,7 @@ namespace nodetool m_peerlist.append_with_peer_white(pe_local); //update last seen and push it to peerlist manager - LOG_PRINT_CC_GREEN(con, "CONNECTION HANDSHAKED OK.", LOG_LEVEL_2); + LOG_DEBUG_CC(con, "CONNECTION HANDSHAKED OK."); return true; } @@ -986,7 +985,7 @@ namespace nodetool if(is_addr_recently_failed(pe.adr)) continue; - LOG_PRINT_L2("Selected peer: " << pe.id << " " << epee::string_tools::get_ip_string_from_int32(pe.adr.ip) + MDEBUG("Selected peer: " << pe.id << " " << epee::string_tools::get_ip_string_from_int32(pe.adr.ip) << ":" << boost::lexical_cast<std::string>(pe.adr.port) << "[white=" << use_white_list << "] last_seen: " << (pe.last_seen ? epee::misc_utils::get_time_interval_string(time(NULL) - pe.last_seen) : "never")); @@ -1021,7 +1020,7 @@ namespace nodetool break; if(++try_count > m_seed_nodes.size()) { - LOG_PRINT_RED_L0("Failed to connect to any of seed peers, continuing without seeds"); + MWARNING("Failed to connect to any of seed peers, continuing without seeds"); break; } if(++current_index >= m_seed_nodes.size()) @@ -1105,7 +1104,7 @@ namespace nodetool template<class t_payload_net_handler> bool node_server<t_payload_net_handler>::peer_sync_idle_maker() { - LOG_PRINT_L2("STARTED PEERLIST IDLE HANDSHAKE"); + MDEBUG("STARTED PEERLIST IDLE HANDSHAKE"); typedef std::list<std::pair<epee::net_utils::connection_context_base, peerid_type> > local_connects_type; local_connects_type cncts; m_net_server.get_config_object().foreach_connection([&](const p2p_connection_context& cntxt) @@ -1117,7 +1116,7 @@ namespace nodetool std::for_each(cncts.begin(), cncts.end(), [&](const typename local_connects_type::value_type& vl){do_peer_timed_sync(vl.first, vl.second);}); - LOG_PRINT_L2("FINISHED PEERLIST IDLE HANDSHAKE"); + MDEBUG("FINISHED PEERLIST IDLE HANDSHAKE"); return true; } //----------------------------------------------------------------------------------- @@ -1133,7 +1132,7 @@ namespace nodetool { if(be.last_seen > local_time) { - LOG_PRINT_RED_L1("FOUND FUTURE peerlist for entry " << epee::string_tools::get_ip_string_from_int32(be.adr.ip) << ":" << be.adr.port << " last_seen: " << be.last_seen << ", local_time(on remote node):" << local_time); + MWARNING("FOUND FUTURE peerlist for entry " << epee::string_tools::get_ip_string_from_int32(be.adr.ip) << ":" << be.adr.port << " last_seen: " << be.last_seen << ", local_time(on remote node):" << local_time); return false; } be.last_seen += delta; @@ -1148,8 +1147,8 @@ namespace nodetool std::list<peerlist_entry> peerlist_ = peerlist; if(!fix_time_delta(peerlist_, local_time, delta)) return false; - LOG_PRINT_CCONTEXT_L2("REMOTE PEERLIST: TIME_DELTA: " << delta << ", remote peerlist size=" << peerlist_.size()); - LOG_PRINT_CCONTEXT_L3("REMOTE PEERLIST: " << print_peerlist_to_string(peerlist_)); + LOG_DEBUG_CC(context, "REMOTE PEERLIST: TIME_DELTA: " << delta << ", remote peerlist size=" << peerlist_.size()); + LOG_DEBUG_CC(context, "REMOTE PEERLIST: " << print_peerlist_to_string(peerlist_)); return m_peerlist.merge_peerlist(peerlist_); } //----------------------------------------------------------------------------------- @@ -1332,7 +1331,7 @@ namespace nodetool { if(ec) { - LOG_PRINT_CC_L2(ping_context, "back ping connect failed to " << ip << ":" << port); + LOG_WARNING_CC(ping_context, "back ping connect failed to " << ip << ":" << port); return false; } COMMAND_PING::request req; @@ -1351,13 +1350,13 @@ namespace nodetool { if(code <= 0) { - LOG_PRINT_CC_L2(ping_context, "Failed to invoke COMMAND_PING to " << ip << ":" << port << "(" << code << ", " << epee::levin::get_err_descr(code) << ")"); + LOG_ERROR_CC(ping_context, "Failed to invoke COMMAND_PING to " << ip << ":" << port << "(" << code << ", " << epee::levin::get_err_descr(code) << ")"); return; } if(rsp.status != PING_OK_RESPONSE_STATUS_TEXT || pr != rsp.peer_id) { - LOG_PRINT_CC_L2(ping_context, "back ping invoke wrong response \"" << rsp.status << "\" from" << ip << ":" << port << ", hsh_peer_id=" << pr_ << ", rsp.peer_id=" << rsp.peer_id); + LOG_ERROR_CC(ping_context, "back ping invoke wrong response \"" << rsp.status << "\" from" << ip << ":" << port << ", hsh_peer_id=" << pr_ << ", rsp.peer_id=" << rsp.peer_id); m_net_server.get_config_object().close(ping_context.m_connection_id); return; } @@ -1367,7 +1366,7 @@ namespace nodetool if(!inv_call_res) { - LOG_PRINT_CC_L2(ping_context, "back ping invoke failed to " << ip << ":" << port); + LOG_ERROR_CC(ping_context, "back ping invoke failed to " << ip << ":" << port); m_net_server.get_config_object().close(ping_context.m_connection_id); return false; } @@ -1375,7 +1374,7 @@ namespace nodetool }); if(!r) { - LOG_ERROR("Failed to call connect_async, network error."); + LOG_ERROR_CC(context, "Failed to call connect_async, network error."); } return r; } @@ -1394,7 +1393,7 @@ namespace nodetool { if(code < 0) { - LOG_PRINT_CC_RED(context_, "COMMAND_REQUEST_SUPPORT_FLAGS invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")", LOG_LEVEL_1); + LOG_ERROR_CC(context_, "COMMAND_REQUEST_SUPPORT_FLAGS invoke failed. (" << code << ", " << epee::levin::get_err_descr(code) << ")"); return; } @@ -1411,7 +1410,7 @@ namespace nodetool { if(!m_payload_handler.process_payload_sync_data(arg.payload_data, context, false)) { - LOG_ERROR_CCONTEXT("Failed to process_payload_sync_data(), dropping connection"); + LOG_ERROR_CC(context, "Failed to process_payload_sync_data(), dropping connection"); drop_connection(context); return 1; } @@ -1420,7 +1419,7 @@ namespace nodetool rsp.local_time = time(NULL); m_peerlist.get_peerlist_head(rsp.local_peerlist); m_payload_handler.get_payload_sync_data(rsp.payload_data); - LOG_PRINT_CCONTEXT_L2("COMMAND_TIMED_SYNC"); + LOG_DEBUG_CC(context, "COMMAND_TIMED_SYNC"); return 1; } //----------------------------------------------------------------------------------- @@ -1430,7 +1429,7 @@ namespace nodetool if(arg.node_data.network_id != m_network_id) { - LOG_PRINT_CCONTEXT_L1("WRONG NETWORK AGENT CONNECTED! id=" << epee::string_tools::get_str_from_guid_a(arg.node_data.network_id)); + LOG_INFO_CC(context, "WRONG NETWORK AGENT CONNECTED! id=" << epee::string_tools::get_str_from_guid_a(arg.node_data.network_id)); drop_connection(context); add_ip_fail(context.m_remote_ip); return 1; @@ -1438,7 +1437,7 @@ namespace nodetool if(!context.m_is_income) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE came not from incoming connection"); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE came not from incoming connection"); drop_connection(context); add_ip_fail(context.m_remote_ip); return 1; @@ -1446,14 +1445,14 @@ namespace nodetool if(context.peer_id) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE came, but seems that connection already have associated peer_id (double COMMAND_HANDSHAKE?)"); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE came, but seems that connection already have associated peer_id (double COMMAND_HANDSHAKE?)"); drop_connection(context); return 1; } if(!m_payload_handler.process_payload_sync_data(arg.payload_data, context, true)) { - LOG_ERROR_CCONTEXT("COMMAND_HANDSHAKE came, but process_payload_sync_data returned false, dropping connection."); + LOG_ERROR_CC(context, "COMMAND_HANDSHAKE came, but process_payload_sync_data returned false, dropping connection."); drop_connection(context); return 1; } @@ -1476,7 +1475,7 @@ namespace nodetool pe.last_seen = static_cast<int64_t>(last_seen); pe.id = peer_id_l; this->m_peerlist.append_with_peer_white(pe); - LOG_PRINT_CCONTEXT_L2("PING SUCCESS " << epee::string_tools::get_ip_string_from_int32(context.m_remote_ip) << ":" << port_l); + LOG_DEBUG_CC(context, "PING SUCCESS " << epee::string_tools::get_ip_string_from_int32(context.m_remote_ip) << ":" << port_l); }); } @@ -1489,14 +1488,14 @@ namespace nodetool m_peerlist.get_peerlist_head(rsp.local_peerlist); get_local_node_data(rsp.node_data); m_payload_handler.get_payload_sync_data(rsp.payload_data); - LOG_PRINT_CCONTEXT_GREEN("COMMAND_HANDSHAKE", LOG_LEVEL_1); + LOG_DEBUG_CC(context, "COMMAND_HANDSHAKE"); return 1; } //----------------------------------------------------------------------------------- template<class t_payload_net_handler> int node_server<t_payload_net_handler>::handle_ping(int command, COMMAND_PING::request& arg, COMMAND_PING::response& rsp, p2p_connection_context& context) { - LOG_PRINT_CCONTEXT_L2("COMMAND_PING"); + LOG_DEBUG_CC(context, "COMMAND_PING"); rsp.status = PING_OK_RESPONSE_STATUS_TEXT; rsp.peer_id = m_config.m_peer_id; return 1; @@ -1508,14 +1507,14 @@ namespace nodetool std::list<peerlist_entry> pl_white; std::list<peerlist_entry> pl_gray; m_peerlist.get_peerlist_full(pl_gray, pl_white); - LOG_PRINT_L0(ENDL << "Peerlist white:" << ENDL << print_peerlist_to_string(pl_white) << ENDL << "Peerlist gray:" << ENDL << print_peerlist_to_string(pl_gray) ); + MINFO(ENDL << "Peerlist white:" << ENDL << print_peerlist_to_string(pl_white) << ENDL << "Peerlist gray:" << ENDL << print_peerlist_to_string(pl_gray) ); return true; } //----------------------------------------------------------------------------------- template<class t_payload_net_handler> bool node_server<t_payload_net_handler>::log_connections() { - LOG_PRINT_L0("Connections: \r\n" << print_connections_container() ); + MINFO("Connections: \r\n" << print_connections_container() ); return true; } //----------------------------------------------------------------------------------- @@ -1539,13 +1538,13 @@ namespace nodetool template<class t_payload_net_handler> void node_server<t_payload_net_handler>::on_connection_new(p2p_connection_context& context) { - LOG_PRINT_L2("["<< epee::net_utils::print_connection_context(context) << "] NEW CONNECTION"); + MINFO("["<< epee::net_utils::print_connection_context(context) << "] NEW CONNECTION"); } //----------------------------------------------------------------------------------- template<class t_payload_net_handler> void node_server<t_payload_net_handler>::on_connection_close(p2p_connection_context& context) { - LOG_PRINT_L2("["<< epee::net_utils::print_connection_context(context) << "] CLOSE CONNECTION"); + MINFO("["<< epee::net_utils::print_connection_context(context) << "] CLOSE CONNECTION"); } template<class t_payload_net_handler> @@ -1595,10 +1594,8 @@ namespace nodetool { if(max == -1) { m_config.m_net_config.connections_count = P2P_DEFAULT_CONNECTIONS_COUNT; - epee::net_utils::data_logger::get_instance().add_data("peers_limit", m_config.m_net_config.connections_count); return true; } - epee::net_utils::data_logger::get_instance().add_data("peers_limit", max); m_config.m_net_config.connections_count = max; return true; } @@ -1632,7 +1629,7 @@ namespace nodetool limit *= 1024; epee::net_utils::connection<epee::levin::async_protocol_handler<p2p_connection_context> >::set_rate_up_limit( limit ); - LOG_PRINT_L0("Set limit-up to " << limit/1024 << " kB/s"); + MINFO("Set limit-up to " << limit/1024 << " kB/s"); return true; } @@ -1646,7 +1643,7 @@ namespace nodetool } limit *= 1024; epee::net_utils::connection<epee::levin::async_protocol_handler<p2p_connection_context> >::set_rate_down_limit( limit ); - LOG_PRINT_L0("Set limit-down to " << limit/1024 << " kB/s"); + MINFO("Set limit-down to " << limit/1024 << " kB/s"); return true; } @@ -1668,11 +1665,11 @@ namespace nodetool } if(!this->islimitup) { epee::net_utils::connection<epee::levin::async_protocol_handler<p2p_connection_context> >::set_rate_up_limit(limit_up); - LOG_PRINT_L0("Set limit-up to " << limit_up/1024 << " kB/s"); + MINFO("Set limit-up to " << limit_up/1024 << " kB/s"); } if(!this->islimitdown) { epee::net_utils::connection<epee::levin::async_protocol_handler<p2p_connection_context> >::set_rate_down_limit(limit_down); - LOG_PRINT_L0("Set limit-down to " << limit_down/1024 << " kB/s"); + MINFO("Set limit-down to " << limit_down/1024 << " kB/s"); } return true; diff --git a/src/p2p/network_throttle-detail.cpp b/src/p2p/network_throttle-detail.cpp index ed3c8e7b4..9efaaf95a 100644 --- a/src/p2p/network_throttle-detail.cpp +++ b/src/p2p/network_throttle-detail.cpp @@ -77,9 +77,8 @@ // TODO: #include "../../src/p2p/network_throttle-detail.hpp" -#include "../../contrib/otshell_utils/utils.hpp" -#include "data_logger.hpp" -using namespace nOT::nUtils; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.throttle" // ################################################################################################ // ################################################################################################ @@ -89,8 +88,6 @@ using namespace nOT::nUtils; // ################################################################################################ // ################################################################################################ -using namespace nOT::nUtils; - namespace epee { namespace net_utils @@ -163,7 +160,7 @@ void network_throttle::set_name(const std::string &name) void network_throttle::set_target_speed( network_speed_kbps target ) { m_target_speed = target * 1024; - _note_c("net/"+m_nameshort, "Setting LIMIT: " << target << " kbps"); + MINFO("Setting LIMIT: " << target << " kbps"); set_real_target_speed(target); } @@ -220,7 +217,7 @@ void network_throttle::_handle_trafic_exact(size_t packet_size, size_t orginal_s std::ostringstream oss; oss << "["; for (auto sample: m_history) oss << sample.m_size << " "; oss << "]" << std::ends; std::string history_str = oss.str(); - _dbg2_c( "net/" + m_nameshort , "Throttle " << m_name << ": packet of ~"<<packet_size<<"b " << " (from "<<orginal_size<<" b)" + MDEBUG("Throttle " << m_name << ": packet of ~"<<packet_size<<"b " << " (from "<<orginal_size<<" b)" << " Speed AVG=" << std::setw(4) << ((long int)(cts .average/1024)) <<"[w="<<cts .window<<"]" << " " << std::setw(4) << ((long int)(cts2.average/1024)) <<"[w="<<cts2.window<<"]" <<" / " << " Limit="<< ((long int)(m_target_speed/1024)) <<" KiB/sec " @@ -241,8 +238,6 @@ network_time_seconds network_throttle::get_sleep_time_after_tick(size_t packet_s } void network_throttle::logger_handle_net(const std::string &filename, double time, size_t size) { - if (! epee::net_utils::data_logger::m_save_graph) - return; boost::mutex mutex; mutex.lock(); { std::fstream file; @@ -312,8 +307,7 @@ void network_throttle::calculate_times(size_t packet_size, calculate_times_struc if (dbg) { std::ostringstream oss; oss << "["; for (auto sample: m_history) oss << sample.m_size << " "; oss << "]" << std::ends; std::string history_str = oss.str(); - _dbg1_c( "net/"+m_nameshort+"_c" , - (cts.delay > 0 ? "SLEEP" : "") + MDEBUG((cts.delay > 0 ? "SLEEP" : "") << "dbg " << m_name << ": " << "speed is A=" << std::setw(8) <<cts.average<<" vs " << "Max=" << std::setw(8) <<M<<" " diff --git a/src/ringct/rctOps.cpp b/src/ringct/rctOps.cpp index 21f29ccf5..0e1715072 100644 --- a/src/ringct/rctOps.cpp +++ b/src/ringct/rctOps.cpp @@ -33,6 +33,9 @@ using namespace crypto; using namespace std; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "ringct" + namespace rct { //Various key initialization functions diff --git a/src/ringct/rctSigs.cpp b/src/ringct/rctSigs.cpp index 1e4f1e852..74fed0ede 100644 --- a/src/ringct/rctSigs.cpp +++ b/src/ringct/rctSigs.cpp @@ -39,6 +39,9 @@ using namespace crypto; using namespace std; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "ringct" + namespace rct { //Borromean (c.f. gmax/andytoshi's paper) boroSig genBorromean(const key64 x, const key64 P1, const key64 P2, const bits indices) { diff --git a/src/ringct/rctTypes.cpp b/src/ringct/rctTypes.cpp index e773c6043..1526dcf7c 100644 --- a/src/ringct/rctTypes.cpp +++ b/src/ringct/rctTypes.cpp @@ -32,6 +32,9 @@ using namespace crypto; using namespace std; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "ringct" + namespace rct { //dp diff --git a/src/rpc/core_rpc_server.cpp b/src/rpc/core_rpc_server.cpp index 0cec3c26e..29c61eca2 100644 --- a/src/rpc/core_rpc_server.cpp +++ b/src/rpc/core_rpc_server.cpp @@ -678,17 +678,20 @@ namespace cryptonote //------------------------------------------------------------------------------------------------------------------------------ bool core_rpc_server::on_set_log_level(const COMMAND_RPC_SET_LOG_LEVEL::request& req, COMMAND_RPC_SET_LOG_LEVEL::response& res) { - if (req.level < LOG_LEVEL_MIN || req.level > LOG_LEVEL_MAX) + if (req.level < 0 || req.level > 4) { res.status = "Error: log level not valid"; + return true; } - else - { - epee::log_space::log_singletone::get_set_log_detalisation_level(true, req.level); - int otshell_utils_log_level = 100 - (req.level * 20); - gCurrentLogger.setDebugLevel(otshell_utils_log_level); - res.status = CORE_RPC_STATUS_OK; - } + mlog_set_log_level(req.level); + res.status = CORE_RPC_STATUS_OK; + return true; + } + //------------------------------------------------------------------------------------------------------------------------------ + bool core_rpc_server::on_set_log_categories(const COMMAND_RPC_SET_LOG_CATEGORIES::request& req, COMMAND_RPC_SET_LOG_CATEGORIES::response& res) + { + mlog_set_categories(req.categories.c_str()); + res.status = CORE_RPC_STATUS_OK; return true; } //------------------------------------------------------------------------------------------------------------------------------ diff --git a/src/rpc/core_rpc_server.h b/src/rpc/core_rpc_server.h index 0c0668f3b..9d6ff9740 100644 --- a/src/rpc/core_rpc_server.h +++ b/src/rpc/core_rpc_server.h @@ -91,6 +91,7 @@ namespace cryptonote MAP_URI_AUTO_JON2_IF("/get_peer_list", on_get_peer_list, COMMAND_RPC_GET_PEER_LIST, !m_restricted) MAP_URI_AUTO_JON2_IF("/set_log_hash_rate", on_set_log_hash_rate, COMMAND_RPC_SET_LOG_HASH_RATE, !m_restricted) MAP_URI_AUTO_JON2_IF("/set_log_level", on_set_log_level, COMMAND_RPC_SET_LOG_LEVEL, !m_restricted) + MAP_URI_AUTO_JON2_IF("/set_log_categories", on_set_log_categories, COMMAND_RPC_SET_LOG_CATEGORIES, !m_restricted) MAP_URI_AUTO_JON2("/get_transaction_pool", on_get_transaction_pool, COMMAND_RPC_GET_TRANSACTION_POOL) MAP_URI_AUTO_JON2_IF("/stop_daemon", on_stop_daemon, COMMAND_RPC_STOP_DAEMON, !m_restricted) MAP_URI_AUTO_JON2("/getinfo", on_get_info, COMMAND_RPC_GET_INFO) @@ -141,6 +142,7 @@ namespace cryptonote bool on_get_peer_list(const COMMAND_RPC_GET_PEER_LIST::request& req, COMMAND_RPC_GET_PEER_LIST::response& res); bool on_set_log_hash_rate(const COMMAND_RPC_SET_LOG_HASH_RATE::request& req, COMMAND_RPC_SET_LOG_HASH_RATE::response& res); bool on_set_log_level(const COMMAND_RPC_SET_LOG_LEVEL::request& req, COMMAND_RPC_SET_LOG_LEVEL::response& res); + bool on_set_log_categories(const COMMAND_RPC_SET_LOG_CATEGORIES::request& req, COMMAND_RPC_SET_LOG_CATEGORIES::response& res); bool on_get_transaction_pool(const COMMAND_RPC_GET_TRANSACTION_POOL::request& req, COMMAND_RPC_GET_TRANSACTION_POOL::response& res); bool on_stop_daemon(const COMMAND_RPC_STOP_DAEMON::request& req, COMMAND_RPC_STOP_DAEMON::response& res); bool on_out_peers(const COMMAND_RPC_OUT_PEERS::request& req, COMMAND_RPC_OUT_PEERS::response& res); diff --git a/src/rpc/core_rpc_server_commands_defs.h b/src/rpc/core_rpc_server_commands_defs.h index 2530bc06d..b3aa8d901 100644 --- a/src/rpc/core_rpc_server_commands_defs.h +++ b/src/rpc/core_rpc_server_commands_defs.h @@ -909,6 +909,26 @@ namespace cryptonote }; }; + struct COMMAND_RPC_SET_LOG_CATEGORIES + { + struct request + { + std::string categories; + + BEGIN_KV_SERIALIZE_MAP() + KV_SERIALIZE(categories) + END_KV_SERIALIZE_MAP() + }; + + struct response + { + std::string status; + BEGIN_KV_SERIALIZE_MAP() + KV_SERIALIZE(status) + END_KV_SERIALIZE_MAP() + }; + }; + struct tx_info { std::string id_hash; diff --git a/src/simplewallet/simplewallet.cpp b/src/simplewallet/simplewallet.cpp index 3412617d4..2637e8db5 100644 --- a/src/simplewallet/simplewallet.cpp +++ b/src/simplewallet/simplewallet.cpp @@ -68,6 +68,9 @@ using boost::lexical_cast; namespace po = boost::program_options; typedef cryptonote::simple_wallet sw; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.simplewallet" + #define EXTENDED_LOGS_FILE "wallet_details.log" #define DEFAULT_MIX 4 @@ -136,8 +139,8 @@ namespace class message_writer { public: - message_writer(epee::log_space::console_colors color = epee::log_space::console_color_default, bool bright = false, - std::string&& prefix = std::string(), int log_level = LOG_LEVEL_2) + message_writer(console_colors color = console_color_default, bool bright = false, + std::string&& prefix = std::string(), el::Level log_level = el::Level::Info) : m_flush(true) , m_color(color) , m_bright(bright) @@ -173,17 +176,17 @@ namespace { m_flush = false; - LOG_PRINT(m_oss.str(), m_log_level); + MCLOG(m_log_level, "global", m_oss.str()); - if (epee::log_space::console_color_default == m_color) + if (console_color_default == m_color) { std::cout << m_oss.str(); } else { - epee::log_space::set_console_color(m_color, m_bright); + set_console_color(m_color, m_bright); std::cout << m_oss.str(); - epee::log_space::reset_console_color(); + reset_console_color(); } std::cout << std::endl; } @@ -197,19 +200,19 @@ namespace private: bool m_flush; std::stringstream m_oss; - epee::log_space::console_colors m_color; + console_colors m_color; bool m_bright; - int m_log_level; + el::Level m_log_level; }; message_writer success_msg_writer(bool color = false) { - return message_writer(color ? epee::log_space::console_color_green : epee::log_space::console_color_default, false, std::string(), LOG_LEVEL_2); + return message_writer(color ? console_color_green : console_color_default, false, std::string(), el::Level::Info); } message_writer fail_msg_writer() { - return message_writer(epee::log_space::console_color_red, true, sw::tr("Error: "), LOG_LEVEL_0); + return message_writer(console_color_red, true, sw::tr("Error: "), el::Level::Error); } bool is_it_true(const std::string& s) @@ -571,7 +574,7 @@ simple_wallet::simple_wallet() m_cmd_binder.set_handler("donate", boost::bind(&simple_wallet::donate, this, _1), tr("donate [<mixin_count>] <amount> [payment_id] - Donate <amount> to the development team (donate.getmonero.org)")); m_cmd_binder.set_handler("sign_transfer", boost::bind(&simple_wallet::sign_transfer, this, _1), tr("Sign a transaction from a file")); m_cmd_binder.set_handler("submit_transfer", boost::bind(&simple_wallet::submit_transfer, this, _1), tr("Submit a signed transaction from a file")); - m_cmd_binder.set_handler("set_log", boost::bind(&simple_wallet::set_log, this, _1), tr("set_log <level> - Change current log detail level, <0-4>")); + m_cmd_binder.set_handler("set_log", boost::bind(&simple_wallet::set_log, this, _1), tr("set_log <level>|<categories> - Change current log detail (level must be <0-4>)")); m_cmd_binder.set_handler("address", boost::bind(&simple_wallet::print_address, this, _1), tr("Show current wallet public address")); m_cmd_binder.set_handler("integrated_address", boost::bind(&simple_wallet::print_integrated_address, this, _1), tr("integrated_address [PID] - Encode a payment ID into an integrated address for the current wallet public address (no argument uses a random payment ID), or decode an integrated address to standard address and payment ID")); m_cmd_binder.set_handler("address_book", boost::bind(&simple_wallet::address_book, this, _1), tr("address_book [(add (<address> [pid <long or short payment id>])|<integrated address> [<description possibly with whitespaces>])|(delete <index>)] - Print all entries in the address book, optionally adding/deleting an entry to/from it")); @@ -745,22 +748,24 @@ bool simple_wallet::set_log(const std::vector<std::string> &args) { if(args.size() != 1) { - fail_msg_writer() << tr("usage: set_log <log_level_number_0-4>"); + fail_msg_writer() << tr("usage: set_log <log_level_number_0-4> | <categories>"); return true; } uint16_t l = 0; - if(!epee::string_tools::get_xtype_from_string(l, args[0])) + if(epee::string_tools::get_xtype_from_string(l, args[0])) { - fail_msg_writer() << tr("wrong number format, use: set_log <log_level_number_0-4>"); - return true; + if(4 < l) + { + fail_msg_writer() << tr("wrong number range, use: set_log <log_level_number_0-4>"); + return true; + } + + mlog_set_log_level(l); } - if(LOG_LEVEL_4 < l) + else { - fail_msg_writer() << tr("wrong number range, use: set_log <log_level_number_0-4>"); - return true; + mlog_set_categories(args.front().c_str()); } - - log_space::log_singletone::get_set_log_detalisation_level(true, l); return true; } //---------------------------------------------------------------------------------------------------- @@ -1244,7 +1249,7 @@ bool simple_wallet::new_wallet(const boost::program_options::variables_map& vm, if (was_deprecated_wallet) { // The user had used an older version of the wallet with old style mnemonics. - message_writer(epee::log_space::console_color_green, false) << "\n" << tr("You had been using " + message_writer(console_color_green, false) << "\n" << tr("You had been using " "a deprecated version of the wallet. Please use the new seed that we provide.\n"); } mnemonic_language = get_mnemonic_language(); @@ -1268,7 +1273,7 @@ bool simple_wallet::new_wallet(const boost::program_options::variables_map& vm, try { recovery_val = m_wallet->generate(m_wallet_file, std::move(rc.second).password(), recovery_key, recover, two_random); - message_writer(epee::log_space::console_color_white, true) << tr("Generated new wallet: ") + message_writer(console_color_white, true) << tr("Generated new wallet: ") << m_wallet->get_account().get_public_address_str(m_wallet->testnet()); std::cout << tr("View key: ") << string_tools::pod_to_hex(m_wallet->get_account().get_keys().m_view_secret_key) << ENDL; } @@ -1325,7 +1330,7 @@ bool simple_wallet::new_wallet(const boost::program_options::variables_map& vm, { m_wallet->generate(m_wallet_file, std::move(rc.second).password(), address, viewkey); } - message_writer(epee::log_space::console_color_white, true) << tr("Generated new wallet: ") + message_writer(console_color_white, true) << tr("Generated new wallet: ") << m_wallet->get_account().get_public_address_str(m_wallet->testnet()); } catch (const std::exception& e) @@ -1356,7 +1361,7 @@ bool simple_wallet::open_wallet(const boost::program_options::variables_map& vm) return false; } - message_writer(epee::log_space::console_color_white, true) << + message_writer(console_color_white, true) << (m_wallet->watch_only() ? tr("Opened watch-only wallet") : tr("Opened wallet")) << ": " << m_wallet->get_account().get_public_address_str(m_wallet->testnet()); // If the wallet file is deprecated, we should ask for mnemonic language again and store @@ -1366,7 +1371,7 @@ bool simple_wallet::open_wallet(const boost::program_options::variables_map& vm) { if (m_wallet->is_deterministic()) { - message_writer(epee::log_space::console_color_green, false) << "\n" << tr("You had been using " + message_writer(console_color_green, false) << "\n" << tr("You had been using " "a deprecated version of the wallet. Please proceed to upgrade your wallet.\n"); std::string mnemonic_language = get_mnemonic_language(); if (mnemonic_language.empty()) @@ -1381,7 +1386,7 @@ bool simple_wallet::open_wallet(const boost::program_options::variables_map& vm) } else { - message_writer(epee::log_space::console_color_green, false) << "\n" << tr("You had been using " + message_writer(console_color_green, false) << "\n" << tr("You had been using " "a deprecated version of the wallet. Your wallet file format is being upgraded now.\n"); m_wallet->rewrite(m_wallet_file, password); } @@ -1558,7 +1563,7 @@ void simple_wallet::on_new_block(uint64_t height, const cryptonote::block& block //---------------------------------------------------------------------------------------------------- void simple_wallet::on_money_received(uint64_t height, const cryptonote::transaction& tx, uint64_t amount) { - message_writer(epee::log_space::console_color_green, false) << "\r" << + message_writer(console_color_green, false) << "\r" << tr("Height ") << height << ", " << tr("transaction ") << get_transaction_hash(tx) << ", " << tr("received ") << print_money(amount); @@ -1575,7 +1580,7 @@ void simple_wallet::on_unconfirmed_money_received(uint64_t height, const crypton //---------------------------------------------------------------------------------------------------- void simple_wallet::on_money_spent(uint64_t height, const cryptonote::transaction& in_tx, uint64_t amount, const cryptonote::transaction& spend_tx) { - message_writer(epee::log_space::console_color_magenta, false) << "\r" << + message_writer(console_color_magenta, false) << "\r" << tr("Height ") << height << ", " << tr("transaction ") << get_transaction_hash(spend_tx) << ", " << tr("spent ") << print_money(amount); @@ -1587,7 +1592,7 @@ void simple_wallet::on_money_spent(uint64_t height, const cryptonote::transactio //---------------------------------------------------------------------------------------------------- void simple_wallet::on_skip_transaction(uint64_t height, const cryptonote::transaction& tx) { - message_writer(epee::log_space::console_color_red, true) << "\r" << + message_writer(console_color_red, true) << "\r" << tr("Height ") << height << ", " << tr("transaction ") << get_transaction_hash(tx) << ", " << tr("unsupported transaction format"); @@ -1739,7 +1744,7 @@ bool simple_wallet::show_incoming_transfers(const std::vector<std::string>& args std::string verbose_string; if (verbose) verbose_string = (boost::format("%68s%68s") % td.get_public_key() % (td.m_key_image_known ? epee::string_tools::pod_to_hex(td.m_key_image) : std::string('?', 64))).str(); - message_writer(td.m_spent ? epee::log_space::console_color_magenta : epee::log_space::console_color_green, false) << + message_writer(td.m_spent ? console_color_magenta : console_color_green, false) << boost::format("%21s%8s%12s%8s%16u%68s%s") % print_money(td.amount()) % (td.m_spent ? tr("T") : tr("F")) % @@ -3394,7 +3399,7 @@ bool simple_wallet::show_transfers(const std::vector<std::string> &args_) // print in and out sorted by height for (std::map<uint64_t, std::pair<bool, std::string>>::const_iterator i = output.begin(); i != output.end(); ++i) { - message_writer(i->second.first ? epee::log_space::console_color_green : epee::log_space::console_color_magenta, false) << + message_writer(i->second.first ? console_color_green : console_color_magenta, false) << boost::format("%8.8llu %6.6s %s") % ((unsigned long long)i->first) % (i->second.first ? tr("in") : tr("out")) % i->second.second; } @@ -3604,7 +3609,7 @@ bool simple_wallet::run() m_idle_thread = boost::thread([&]{wallet_idle_thread();}); std::string addr_start = m_wallet->get_account().get_public_address_str(m_wallet->testnet()).substr(0, 6); - message_writer(epee::log_space::console_color_green, false) << "Background refresh thread started"; + message_writer(console_color_green, false) << "Background refresh thread started"; return m_cmd_binder.run_handling(std::string("[") + tr("wallet") + " " + addr_start + "]: ", ""); } //---------------------------------------------------------------------------------------------------- @@ -4248,6 +4253,7 @@ int main(int argc, char* argv[]) const bool r = w.init(*vm); CHECK_AND_ASSERT_MES(r, 1, sw::tr("Failed to initialize wallet")); +try{ throw 1; } catch(...){} std::vector<std::string> command = command_line::get_arg(*vm, arg_command); if (!command.empty()) { diff --git a/src/simplewallet/simplewallet.h b/src/simplewallet/simplewallet.h index bf4ace948..237c1e3e1 100644 --- a/src/simplewallet/simplewallet.h +++ b/src/simplewallet/simplewallet.h @@ -47,6 +47,9 @@ #include "wallet/password_container.h" #include "crypto/crypto.h" // for definition of crypto::secret_key +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.simplewallet" + /*! * \namespace cryptonote * \brief Holds cryptonote related classes and helpers. diff --git a/src/wallet/api/wallet_manager.cpp b/src/wallet/api/wallet_manager.cpp index 48faa3183..12bce0285 100644 --- a/src/wallet/api/wallet_manager.cpp +++ b/src/wallet/api/wallet_manager.cpp @@ -436,7 +436,7 @@ WalletManager *WalletManagerFactory::getWalletManager() static WalletManagerImpl * g_walletManager = nullptr; if (!g_walletManager) { - epee::log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL, LOG_LEVEL_MAX); + mlog_configure("monero-wallet-gui.log", false); g_walletManager = new WalletManagerImpl(); } @@ -445,7 +445,7 @@ WalletManager *WalletManagerFactory::getWalletManager() void WalletManagerFactory::setLogLevel(int level) { - epee::log_space::log_singletone::get_set_log_detalisation_level(true, level); + mlog_set_log_level(level); } diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp index 8a03b94af..25b21c722 100644 --- a/src/wallet/wallet2.cpp +++ b/src/wallet/wallet2.cpp @@ -67,6 +67,9 @@ extern "C" } using namespace cryptonote; +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.wallet2" + // used to choose when to stop adding outputs to a tx #define APPROXIMATE_INPUT_BYTES 80 @@ -2065,7 +2068,7 @@ crypto::secret_key wallet2::generate(const std::string& wallet_, const std::stri THROW_WALLET_EXCEPTION_IF(!r, error::file_save_error, m_keys_file); r = file_io_utils::save_string_to_file(m_wallet_file + ".address.txt", m_account.get_public_address_str(m_testnet)); - if(!r) LOG_PRINT_RED_L0("String with address text not saved"); + if(!r) MERROR("String with address text not saved"); cryptonote::block b; generate_genesis(b); @@ -2100,7 +2103,7 @@ void wallet2::generate(const std::string& wallet_, const std::string& password, THROW_WALLET_EXCEPTION_IF(!r, error::file_save_error, m_keys_file); r = file_io_utils::save_string_to_file(m_wallet_file + ".address.txt", m_account.get_public_address_str(m_testnet)); - if(!r) LOG_PRINT_RED_L0("String with address text not saved"); + if(!r) MERROR("String with address text not saved"); cryptonote::block b; generate_genesis(b); @@ -2135,7 +2138,7 @@ void wallet2::generate(const std::string& wallet_, const std::string& password, THROW_WALLET_EXCEPTION_IF(!r, error::file_save_error, m_keys_file); r = file_io_utils::save_string_to_file(m_wallet_file + ".address.txt", m_account.get_public_address_str(m_testnet)); - if(!r) LOG_PRINT_RED_L0("String with address text not saved"); + if(!r) MERROR("String with address text not saved"); cryptonote::block b; generate_genesis(b); diff --git a/src/wallet/wallet2.h b/src/wallet/wallet2.h index 5a569950f..b5542440b 100644 --- a/src/wallet/wallet2.h +++ b/src/wallet/wallet2.h @@ -56,6 +56,10 @@ #include "password_container.h" #include <iostream> + +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.wallet2" + #define WALLET_RCP_CONNECTION_TIMEOUT 200000 class Serialization_portability_wallet_Test; diff --git a/src/wallet/wallet_args.cpp b/src/wallet/wallet_args.cpp index f7eec8cfc..7ec4ad6e4 100644 --- a/src/wallet/wallet_args.cpp +++ b/src/wallet/wallet_args.cpp @@ -40,6 +40,9 @@ #include <crtdbg.h> #endif +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.wallet2" + // workaround for a suspected bug in pthread/kernel on MacOS X #ifdef __APPLE__ #define DEFAULT_MAX_CONCURRENCY 1 @@ -78,7 +81,7 @@ namespace wallet_args _CrtSetDbgFlag ( _CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF ); #endif - const command_line::arg_descriptor<uint32_t> arg_log_level = {"log-level", "", LOG_LEVEL_0}; + const command_line::arg_descriptor<std::string> arg_log_level = {"log-level", "0-4 or categories", ""}; const command_line::arg_descriptor<uint32_t> arg_max_concurrency = {"max-concurrency", wallet_args::tr("Max number of threads to use for a parallel job"), DEFAULT_MAX_CONCURRENCY}; const command_line::arg_descriptor<std::string> arg_log_file = {"log-file", wallet_args::tr("Specify log file"), ""}; @@ -93,26 +96,7 @@ namespace wallet_args command_line::add_arg(desc_general, command_line::arg_help); command_line::add_arg(desc_general, command_line::arg_version); - - bf::path default_log {epee::log_space::log_singletone::get_default_log_folder()}; - std::string log_file_name = epee::log_space::log_singletone::get_default_log_file(); - if (log_file_name.empty()) - { - // Sanity check: File path should also be empty if file name is. If not, - // this would be a problem in epee's discovery of current process's file - // path. - if (! default_log.empty()) - { - tools::fail_msg_writer() << wallet_args::tr("unexpected empty log file name in presence of non-empty file path"); - return boost::none; - } - // epee didn't find path to executable from argv[0], so use this default file name. - log_file_name = "monero-wallet-cli.log"; - // The full path will use cwd because epee also returned an empty default log folder. - } - default_log /= log_file_name; - - command_line::add_arg(desc_params, arg_log_file, default_log.string()); + command_line::add_arg(desc_params, arg_log_file, ""); command_line::add_arg(desc_params, arg_log_level); command_line::add_arg(desc_params, arg_max_concurrency); @@ -146,39 +130,28 @@ namespace wallet_args if (!r) return boost::none; - // log_file_path - // default: < argv[0] directory >/monero-wallet-cli.log - // so if ran as "monero-wallet-cli" (no path), log file will be in cwd - // - // if log-file argument given: - // absolute path - // relative path: relative to cwd - - // Set log file - bf::path log_file_path {bf::absolute(command_line::get_arg(vm, arg_log_file))}; - - // Set up logging options - int log_level = LOG_LEVEL_2; - epee::log_space::get_set_log_detalisation_level(true, log_level); - //epee::log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL, LOG_LEVEL_0); - epee::log_space::log_singletone::add_logger(LOGGER_FILE, - log_file_path.filename().string().c_str(), - log_file_path.parent_path().string().c_str(), - LOG_LEVEL_4 - ); - if(command_line::has_arg(vm, arg_max_concurrency)) tools::set_max_concurrency(command_line::get_arg(vm, arg_max_concurrency)); - tools::scoped_message_writer(epee::log_space::console_color_white, true) << "Monero '" << MONERO_RELEASE_NAME << "' (v" << MONERO_VERSION_FULL << ")"; + std::string log_path; + if (!vm["log-file"].defaulted()) + log_path = command_line::get_arg(vm, arg_log_file); + else + log_path = mlog_get_default_log_path("monero-wallet-cli,log"); + mlog_configure(log_path, false); + if (!vm["log-level"].defaulted()) + { + mlog_set_log(command_line::get_arg(vm, arg_log_level).c_str()); + } + + tools::scoped_message_writer(epee::console_color_white, true) << "Monero '" << MONERO_RELEASE_NAME << "' (v" << MONERO_VERSION_FULL << ")"; - if(command_line::has_arg(vm, arg_log_level)) - log_level = command_line::get_arg(vm, arg_log_level); - LOG_PRINT_L0("Setting log level = " << log_level); - LOG_PRINT_L0(wallet_args::tr("default_log: ") << default_log.string()); - tools::scoped_message_writer(epee::log_space::console_color_white, true) << boost::format(wallet_args::tr("Logging at log level %d to %s")) % - log_level % log_file_path.string(); - epee::log_space::get_set_log_detalisation_level(true, log_level); + if (!vm["log-level"].defaulted()) + MINFO("Setting log level = " << command_line::get_arg(vm, arg_log_level)); + else + MINFO("Setting log levels = " << getenv("MONERO_LOGS")); + MINFO(wallet_args::tr("Logging to: ") << log_path); + tools::scoped_message_writer(epee::console_color_white, true) << boost::format(wallet_args::tr("Logging to %s")) % log_path; return {std::move(vm)}; } diff --git a/src/wallet/wallet_rpc_server.cpp b/src/wallet/wallet_rpc_server.cpp index d61b11f8a..bf2cba346 100644 --- a/src/wallet/wallet_rpc_server.cpp +++ b/src/wallet/wallet_rpc_server.cpp @@ -46,6 +46,9 @@ using namespace epee; #include "string_tools.h" #include "crypto/hash.h" +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.rpc" + namespace { const command_line::arg_descriptor<std::string, true> arg_rpc_bind_port = {"rpc-bind-port", "Sets bind port for server"}; @@ -1323,7 +1326,8 @@ int main(int argc, char** argv) { return 1; } - epee::log_space::log_singletone::add_logger(LOGGER_CONSOLE, NULL, NULL, LOG_LEVEL_2); + mlog_configure("monero-wallet-rpc.log", true); + mlog_set_log_level(2); std::unique_ptr<tools::wallet2> wal; try @@ -1368,12 +1372,12 @@ int main(int argc, char** argv) { // if we ^C during potentially length load/refresh, there's no server loop yet if (quit) { - LOG_PRINT_L0(tools::wallet_rpc_server::tr("Storing wallet...")); + MINFO(tools::wallet_rpc_server::tr("Storing wallet...")); wal->store(); - LOG_PRINT_GREEN(tools::wallet_rpc_server::tr("Stored ok"), LOG_LEVEL_0); + MINFO(tools::wallet_rpc_server::tr("Stored ok")); return 1; } - LOG_PRINT_GREEN(tools::wallet_rpc_server::tr("Loaded ok"), LOG_LEVEL_0); + MINFO(tools::wallet_rpc_server::tr("Loaded ok")); } catch (const std::exception& e) { @@ -1393,7 +1397,7 @@ int main(int argc, char** argv) { { LOG_PRINT_L0(tools::wallet_rpc_server::tr("Storing wallet...")); wal->store(); - LOG_PRINT_GREEN(tools::wallet_rpc_server::tr("Stored ok"), LOG_LEVEL_0); + LOG_PRINT_L0(tools::wallet_rpc_server::tr("Stored ok")); } catch (const std::exception& e) { diff --git a/src/wallet/wallet_rpc_server.h b/src/wallet/wallet_rpc_server.h index 4ff1b267f..7d5db1bcb 100644 --- a/src/wallet/wallet_rpc_server.h +++ b/src/wallet/wallet_rpc_server.h @@ -36,6 +36,10 @@ #include "net/http_server_impl_base.h" #include "wallet_rpc_server_commands_defs.h" #include "wallet2.h" + +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.rpc" + namespace tools { /************************************************************************/ diff --git a/src/wallet/wallet_rpc_server_commands_defs.h b/src/wallet/wallet_rpc_server_commands_defs.h index ea0fc685f..4d643637f 100644 --- a/src/wallet/wallet_rpc_server_commands_defs.h +++ b/src/wallet/wallet_rpc_server_commands_defs.h @@ -33,6 +33,10 @@ #include "cryptonote_core/cryptonote_basic.h" #include "crypto/hash.h" #include "wallet_rpc_server_error_codes.h" + +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "wallet.rpc" + namespace tools { namespace wallet_rpc |