diff options
| author | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-10-01 14:06:54 +0100 |
|---|---|---|
| committer | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-12-17 16:12:18 +0000 |
| commit | 265290388bd2134108d689818518f7d9c830292c (patch) | |
| tree | f4009e97bb83c923349cc5326b954b176ce3cd71 /src/wallet/wallet_rpc_server.cpp | |
| parent | add multisig core test and factor multisig building blocks (diff) | |
| download | monero-265290388bd2134108d689818518f7d9c830292c.tar.xz | |
wallet: guard against partly initialized multisig wallet
Diffstat (limited to 'src/wallet/wallet_rpc_server.cpp')
| -rw-r--r-- | src/wallet/wallet_rpc_server.cpp | 29 |
1 files changed, 25 insertions, 4 deletions
diff --git a/src/wallet/wallet_rpc_server.cpp b/src/wallet/wallet_rpc_server.cpp index ac991d861..043890fd1 100644 --- a/src/wallet/wallet_rpc_server.cpp +++ b/src/wallet/wallet_rpc_server.cpp @@ -2342,7 +2342,7 @@ namespace tools bool wallet_rpc_server::on_is_multisig(const wallet_rpc::COMMAND_RPC_IS_MULTISIG::request& req, wallet_rpc::COMMAND_RPC_IS_MULTISIG::response& res, epee::json_rpc::error& er) { if (!m_wallet) return not_open(er); - res.multisig = m_wallet->multisig(&res.threshold, &res.total); + res.multisig = m_wallet->multisig(&res.ready, &res.threshold, &res.total); return true; } //------------------------------------------------------------------------------------------------------------------------------ @@ -2468,12 +2468,19 @@ namespace tools er.message = "Command unavailable in restricted mode."; return false; } - if (!m_wallet->multisig()) + bool ready; + if (!m_wallet->multisig(&ready)) { er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG; er.message = "This wallet is not multisig"; return false; } + if (!ready) + { + er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG; + er.message = "This wallet is multisig, but not yet finalized"; + return false; + } std::vector<tools::wallet2::multisig_info> info; try @@ -2514,13 +2521,20 @@ namespace tools er.message = "Command unavailable in restricted mode."; return false; } + bool ready; uint32_t threshold, total; - if (!m_wallet->multisig(&threshold, &total)) + if (!m_wallet->multisig(&ready, &threshold, &total)) { er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG; er.message = "This wallet is not multisig"; return false; } + if (!ready) + { + er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG; + er.message = "This wallet is multisig, but not yet finalized"; + return false; + } if (req.info.size() < threshold - 1) { @@ -2607,13 +2621,20 @@ namespace tools er.message = "Command unavailable in restricted mode."; return false; } + bool ready; uint32_t threshold, total; - if (!m_wallet->multisig(&threshold, &total)) + if (!m_wallet->multisig(&ready, &threshold, &total)) { er.code = WALLET_RPC_ERROR_CODE_NOT_MULTISIG; er.message = "This wallet is not multisig"; return false; } + if (ready) + { + er.code = WALLET_RPC_ERROR_CODE_ALREADY_MULTISIG; + er.message = "This wallet is multisig, and already finalized"; + return false; + } if (req.multisig_info.size() < threshold - 1) { |