aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/wallet_rpc_server.cpp
diff options
context:
space:
mode:
authormoneromooo-monero <moneromooo-monero@users.noreply.github.com>2017-02-14 19:35:44 +0000
committermoneromooo-monero <moneromooo-monero@users.noreply.github.com>2017-02-14 19:45:46 +0000
commit83ec209f42f02deab973254231efeb794edf2c16 (patch)
tree32ed00a75bce1b2f3c6611400dca7a2537367351 /src/wallet/wallet_rpc_server.cpp
parentMerge pull request #1719 (diff)
downloadmonero-83ec209f42f02deab973254231efeb794edf2c16.tar.xz
simplewallet: validate hex input size
Diffstat (limited to '')
-rw-r--r--src/wallet/wallet_rpc_server.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/wallet/wallet_rpc_server.cpp b/src/wallet/wallet_rpc_server.cpp
index 881279e42..ee50c3cdb 100644
--- a/src/wallet/wallet_rpc_server.cpp
+++ b/src/wallet/wallet_rpc_server.cpp
@@ -983,7 +983,7 @@ namespace tools
while (i != req.txids.end())
{
cryptonote::blobdata txid_blob;
- if(!epee::string_tools::parse_hexstr_to_binbuff(*i++, txid_blob))
+ if(!epee::string_tools::parse_hexstr_to_binbuff(*i++, txid_blob) || txid_blob.size() != sizeof(crypto::hash))
{
er.code = WALLET_RPC_ERROR_CODE_WRONG_TXID;
er.message = "TX ID has invalid format";
@@ -1013,7 +1013,7 @@ namespace tools
while (i != req.txids.end())
{
cryptonote::blobdata txid_blob;
- if(!epee::string_tools::parse_hexstr_to_binbuff(*i++, txid_blob))
+ if(!epee::string_tools::parse_hexstr_to_binbuff(*i++, txid_blob) || txid_blob.size() != sizeof(crypto::hash))
{
er.code = WALLET_RPC_ERROR_CODE_WRONG_TXID;
er.message = "TX ID has invalid format";
@@ -1206,7 +1206,7 @@ namespace tools
{
cryptonote::blobdata bd;
- if(!epee::string_tools::parse_hexstr_to_binbuff(req.signed_key_images[n].key_image, bd))
+ if(!epee::string_tools::parse_hexstr_to_binbuff(req.signed_key_images[n].key_image, bd) || bd.size() != sizeof(crypto::key_image))
{
er.code = WALLET_RPC_ERROR_CODE_WRONG_KEY_IMAGE;
er.message = "failed to parse key image";
@@ -1214,7 +1214,7 @@ namespace tools
}
ski[n].first = *reinterpret_cast<const crypto::key_image*>(bd.data());
- if(!epee::string_tools::parse_hexstr_to_binbuff(req.signed_key_images[n].signature, bd))
+ if(!epee::string_tools::parse_hexstr_to_binbuff(req.signed_key_images[n].signature, bd) || bd.size() != sizeof(crypto::signature))
{
er.code = WALLET_RPC_ERROR_CODE_WRONG_SIGNATURE;
er.message = "failed to parse signature";