diff options
| author | Jeffrey Ryan <jeffreyryan@tutanota.com> | 2022-05-28 13:09:07 -0500 |
|---|---|---|
| committer | Jeffrey Ryan <jeffreyryan@tutanota.com> | 2022-07-11 20:32:03 -0500 |
| commit | 4d7f6f5cd51c0c02ab00c4f652015331e69ea1e0 (patch) | |
| tree | c4c7f346f087d40e7b04a3aec615c97a2dde3761 /src/wallet/wallet2.cpp | |
| parent | Merge pull request #8340 (diff) | |
| download | monero-4d7f6f5cd51c0c02ab00c4f652015331e69ea1e0.tar.xz | |
GCC: fix some unused warnings
hash_extra: don't test for success in `jh_hash` and `skein_hash` since its guaranteed
device_ledger: move anonymous global variable apdu_verbose into .cpp file
Add comments to `refreshed` method variable in wallet2
Diffstat (limited to 'src/wallet/wallet2.cpp')
| -rw-r--r-- | src/wallet/wallet2.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp index 0b2a6c0f5..c218d071c 100644 --- a/src/wallet/wallet2.cpp +++ b/src/wallet/wallet2.cpp @@ -3418,6 +3418,10 @@ void wallet2::refresh(bool trusted_daemon, uint64_t start_height, uint64_t & blo uint64_t blocks_start_height; std::vector<cryptonote::block_complete_entry> blocks; std::vector<parsed_block> parsed_blocks; + // TODO moneromooo-monero says this about the "refreshed" variable: + // "I had to reorder some code to fix... a timing info leak IIRC. In turn, this undid something I had fixed before, ... a subtle race condition with the txpool. + // It was pretty subtle IIRC, and so I needed time to think about how to refix it after the move, and I never got to it." + // https://github.com/monero-project/monero/pull/6097 bool refreshed = false; std::shared_ptr<std::map<std::pair<uint64_t, uint64_t>, size_t>> output_tracker_cache; hw::device &hwdev = m_account.get_device(); |