aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/node_rpc_proxy.h
diff options
context:
space:
mode:
authorj-berman <justinberman@protonmail.com>2022-09-09 20:34:18 -0600
committerj-berman <justinberman@protonmail.com>2023-03-13 12:57:43 -0700
commit65e13dbef1c3a4cc036919203eec2052a121f034 (patch)
tree988b9a581d279b9e31ee4e19594614bdbe9faba4 /src/wallet/node_rpc_proxy.h
parentMerge pull request #8739 (diff)
downloadmonero-65e13dbef1c3a4cc036919203eec2052a121f034.tar.xz
wallet2: fix rescanning tx via scan_tx
- Detach & re-process txs >= lowest scan height - ensures that if a user calls scan_tx(tx1) after scanning tx2, the wallet correctly processes tx1 and tx2 - if a user provides a tx with a height higher than the wallet's last scanned height, the wallet will scan starting from that tx's height - scan_tx requires trusted daemon iff need to re-process existing txs: in addition to querying a daemon for txids, if a user provides a txid of a tx with height *lower* than any *already* scanned txs in the wallet, then the wallet will also query the daemon for all the *higher* txs as well. This is likely unexpected behavior to a caller, and so to protect a caller from revealing txid's to an untrusted daemon in an unexpected way, require the daemon be trusted.
Diffstat (limited to '')
-rw-r--r--src/wallet/node_rpc_proxy.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/wallet/node_rpc_proxy.h b/src/wallet/node_rpc_proxy.h
index e320565ac..f78cd6427 100644
--- a/src/wallet/node_rpc_proxy.h
+++ b/src/wallet/node_rpc_proxy.h
@@ -59,6 +59,7 @@ public:
boost::optional<std::string> get_dynamic_base_fee_estimate_2021_scaling(uint64_t grace_blocks, std::vector<uint64_t> &fees);
boost::optional<std::string> get_fee_quantization_mask(uint64_t &fee_quantization_mask);
boost::optional<std::string> get_rpc_payment_info(bool mining, bool &payment_required, uint64_t &credits, uint64_t &diff, uint64_t &credits_per_hash_found, cryptonote::blobdata &blob, uint64_t &height, uint64_t &seed_height, crypto::hash &seed_hash, crypto::hash &next_seed_hash, uint32_t &cookie);
+ boost::optional<std::string> get_block_header_by_height(uint64_t height, cryptonote::block_header_response &block_header);
private:
template<typename T> void handle_payment_changes(const T &res, std::true_type) {