diff options
author | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-01-01 16:34:23 +0000 |
---|---|---|
committer | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2017-01-16 00:25:46 +0000 |
commit | 5833d66f6540e7b34e10ddef37c2b67bd501994b (patch) | |
tree | e4d312059948a0528583e7ea58d2c0b40307a494 /src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp | |
parent | easylogging++: fix logging with static const header only data members (diff) | |
download | monero-5833d66f6540e7b34e10ddef37c2b67bd501994b.tar.xz |
Change logging to easylogging++
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
Diffstat (limited to 'src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp')
-rw-r--r-- | src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp b/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp index 9d9ab3321..56b82ed15 100644 --- a/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp +++ b/src/cryptonote_protocol/cryptonote_protocol_handler-base.cpp @@ -73,11 +73,11 @@ #include "../../src/cryptonote_protocol/cryptonote_protocol_handler.h" #include "../../src/p2p/network_throttle.hpp" -#include "../../contrib/otshell_utils/utils.hpp" -using namespace nOT::nUtils; - #include "../../../src/cryptonote_core/cryptonote_core.h" // e.g. for the send_stop_signal() +#undef MONERO_DEFAULT_LOG_CATEGORY +#define MONERO_DEFAULT_LOG_CATEGORY "net.cn" + // ################################################################################################ // ################################################################################################ // the "header part". Not separated out for .hpp because point of this modification is @@ -122,25 +122,24 @@ cryptonote_protocol_handler_base::~cryptonote_protocol_handler_base() { void cryptonote_protocol_handler_base::handler_request_blocks_history(std::list<crypto::hash>& ids) { using namespace epee::net_utils; - LOG_PRINT_L1("### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); - LOG_PRINT_RED("RATE LIMIT NOT IMPLEMENTED HERE YET (download at unlimited speed?)" , LOG_LEVEL_1); - _note_c("net/req2", "### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); + MDEBUG("### ~~~RRRR~~~~ ### sending request (type 2), limit = " << ids.size()); + MWARNING("RATE LIMIT NOT IMPLEMENTED HERE YET (download at unlimited speed?)"); // TODO } -void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet_size) { _scope_dbg1(""); +void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet_size) { using namespace epee::net_utils; double delay=0; // will be calculated - _dbg1("Packet size: " << packet_size); + MDEBUG("Packet size: " << packet_size); do { // rate limiting //XXX /*if (::cryptonote::core::get_is_stopping()) { - _dbg1("We are stopping - so abort sleep"); + MDEBUG("We are stopping - so abort sleep"); return; }*/ /*if (m_was_shutdown) { - _dbg2_c("net/netuse/sleep","m_was_shutdown - so abort sleep"); + MDEBUG("m_was_shutdown - so abort sleep"); return; }*/ @@ -155,9 +154,7 @@ void cryptonote_protocol_handler_base::handler_response_blocks_now(size_t packet if (delay > 0) { //delay += rand2*0.1; long int ms = (long int)(delay * 1000); - _info_c("net/sleep", "Sleeping in " << __FUNCTION__ << " for " << ms << " ms before packet_size="<<packet_size); // XXX debug sleep - _dbg1_c("net/sleep/", "sleep in sleep_before_packet"); - _dbg2("Sleep for " << ms); + MDEBUG("Sleeping for " << ms << " ms before packet_size="<<packet_size); // XXX debug sleep boost::this_thread::sleep(boost::posix_time::milliseconds( ms ) ); // TODO randomize sleeps } } while(delay > 0); |