diff options
| author | Zachary Michaels <mikezackles@gmail.com> | 2014-07-01 10:55:41 -0400 |
|---|---|---|
| committer | Zachary Michaels <mikezackles@gmail.com> | 2014-07-01 14:57:27 -0400 |
| commit | 7259f07a200fd583deb0dca1372bbe5fd760b440 (patch) | |
| tree | 91902f8de5dfcdb53be57bfa9d093b94e9c6c087 /src/common | |
| parent | Explicit namespaces (diff) | |
| download | monero-7259f07a200fd583deb0dca1372bbe5fd760b440.tar.xz | |
Fix assert bug in base58 encode
The previous implementation was almost certainly a typo.
full_block_size is the maximum index in the encoded_block_sizes array,
and size is used as an index in this array. So now 1 <= size <=
full_block_size == 8 instead of 1 <= size <= sizeof(full_block_size) ==
size_of(size_t) == ? (maybe 4 on 32-bit systems!)
Diffstat (limited to 'src/common')
| -rw-r--r-- | src/common/base58.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/common/base58.cpp b/src/common/base58.cpp index 454c0db67..575279aa5 100644 --- a/src/common/base58.cpp +++ b/src/common/base58.cpp @@ -110,7 +110,7 @@ namespace tools void encode_block(const char* block, size_t size, char* res) { - assert(1 <= size && size <= sizeof(full_block_size)); + assert(1 <= size && size <= full_block_size); uint64_t num = uint_8be_to_64(reinterpret_cast<const uint8_t*>(block), size); int i = static_cast<int>(encoded_block_sizes[size]) - 1; |