aboutsummaryrefslogtreecommitdiff
path: root/contrib/epee/src/parserse_base_utils.cpp
diff options
context:
space:
mode:
authorJeffrey <jeffryan@tamu.edu>2022-03-30 13:29:32 -0500
committerJeffrey <jeffryan@tamu.edu>2022-03-30 13:29:32 -0500
commit1ce9e9cda411a1399bd9d16e21b46c821205b31a (patch)
tree7e21eb10207b37e8951e6a071d8a80236f711d2e /contrib/epee/src/parserse_base_utils.cpp
parentMerge pull request #8216 (diff)
downloadmonero-1ce9e9cda411a1399bd9d16e21b46c821205b31a.tar.xz
Remove dead code from parserse_base_utils and fix unit tests
* Remove `match_string()`, `match_number()`, and `match_word()` * Remove `match_word_with_extrasymb()` and `match_word_til_equal_mark()` * Adapt unit test for `match_number()` to `match_number2()` * Adapt unit test for `match_string()` to `match_string2()` Note: the unit tests were testing for the old version of the functions, and the interfaces for these functions changed slightly, so I had to also edit the tests. As of writing, this PR has no merge conflicts with #8211 Additional changes during review: * Explicitly set up is_[float/signed]_val to be changed before each call * Structify the tests and fix uninitialized variables
Diffstat (limited to 'contrib/epee/src/parserse_base_utils.cpp')
-rw-r--r--contrib/epee/src/parserse_base_utils.cpp38
1 files changed, 0 insertions, 38 deletions
diff --git a/contrib/epee/src/parserse_base_utils.cpp b/contrib/epee/src/parserse_base_utils.cpp
index e96c2dede..e154a75f8 100644
--- a/contrib/epee/src/parserse_base_utils.cpp
+++ b/contrib/epee/src/parserse_base_utils.cpp
@@ -239,44 +239,6 @@ namespace misc_utils
}
ASSERT_MES_AND_THROW("failed to match word number in json entry: " << std::string(star_end_string, buf_end));
}
- bool match_word_with_extrasymb(std::string::const_iterator& star_end_string, std::string::const_iterator buf_end, std::string& val)
- {
- val.clear();
-
- for(std::string::const_iterator it = star_end_string;it != buf_end;++it)
- {
- if(!isalnum(*it) && *it != '-' && *it != '_')
- {
- val.assign(star_end_string, it);
- if(val.size())
- {
- star_end_string = --it;
- return true;
- }else
- return false;
- }
- }
- return false;
- }
- bool match_word_til_equal_mark(std::string::const_iterator& star_end_string, std::string::const_iterator buf_end, std::string::const_iterator& word_end)
- {
- word_end = star_end_string;
-
- for(std::string::const_iterator it = star_end_string;it != buf_end;++it)
- {
- if(isspace(*it))
- {
-
- continue;
- }else if( *it == '=' )
- {
- star_end_string = it;
- word_end = it;
- return true;
- }
- }
- return false;
- }
}
}
}