aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorluigi1111 <luigi1111w@gmail.com>2021-10-17 23:26:50 -0500
committerluigi1111 <luigi1111w@gmail.com>2021-10-17 23:26:50 -0500
commit19a6cc26fc679f28f104d78add701bd9da26022a (patch)
tree7a2b0280971e1c9969580073b33763a9ef23b24c
parentMerge pull request #7859 (diff)
parentUB: Not calling virtual method in destructor of WalletImpl (diff)
downloadmonero-19a6cc26fc679f28f104d78add701bd9da26022a.tar.xz
Merge pull request #7867
eed7e79 UB: Not calling virtual method in destructor of WalletImpl (mj-xmr)
-rw-r--r--src/wallet/api/wallet.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp
index 0afbda705..989061250 100644
--- a/src/wallet/api/wallet.cpp
+++ b/src/wallet/api/wallet.cpp
@@ -450,7 +450,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again
- pauseRefresh();
+ WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities
// Stop refresh thread