aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKevin Thomas <me@kevinthomas.dev>2021-12-31 01:05:22 -0800
committerKevin Thomas <me@kevinthomas.dev>2021-12-31 01:05:22 -0800
commite73e1e7e6f505a000b517fb6a867783c170d65d4 (patch)
tree2c3740579236f6444dcdd8d590b8907742b2843d
parentMerge pull request #8103 (diff)
downloadmonero-e73e1e7e6f505a000b517fb6a867783c170d65d4.tar.xz
Use CMD in Dockerfile
According to Dockerfile best practices (https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#entrypoint) the best use for ENTRYPOINT is to set the image’s main command and then use CMD as the default flags. This makes it easier to change the flags passed to monerod when running the Docker image.
-rw-r--r--Dockerfile3
1 files changed, 2 insertions, 1 deletions
diff --git a/Dockerfile b/Dockerfile
index 587007470..1c373cbc9 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -61,5 +61,6 @@ EXPOSE 18081
# switch to user monero
USER monero
-ENTRYPOINT ["monerod", "--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"]
+ENTRYPOINT ["monerod"]
+CMD ["--p2p-bind-ip=0.0.0.0", "--p2p-bind-port=18080", "--rpc-bind-ip=0.0.0.0", "--rpc-bind-port=18081", "--non-interactive", "--confirm-external-bind"]