diff options
| author | Bertrand Jacquin <bertrand@jacquin.bzh> | 2018-06-17 22:34:11 +0100 |
|---|---|---|
| committer | Bertrand Jacquin <bertrand@jacquin.bzh> | 2022-07-18 00:11:53 +0100 |
| commit | dc3a18789e8c8ef6252bd94546bf8cd6184a56eb (patch) | |
| tree | 0dadee7436d1248ba7000d1208bfd1763bddd8e9 | |
| parent | Merge pull request #8435 (diff) | |
| download | monero-dc3a18789e8c8ef6252bd94546bf8cd6184a56eb.tar.xz | |
Drop in-tree miniupnpc
Since 6b8539803184 ("Build: update CMake and p2p for in-tree
miniupnp"), a hard dependency is made on miniupnpc which is a git
submodule not part of the archive available upstream.
| -rw-r--r-- | external/CMakeLists.txt | 19 | ||||
| -rw-r--r-- | src/p2p/net_node.inl | 6 |
2 files changed, 6 insertions, 19 deletions
diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index 5b7f69a56..fc4045506 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -36,22 +36,9 @@ # others. find_package(Miniupnpc REQUIRED) - -message(STATUS "Using in-tree miniupnpc") -set(UPNPC_NO_INSTALL TRUE CACHE BOOL "Disable miniupnp installation" FORCE) -add_subdirectory(miniupnp/miniupnpc) -set_property(TARGET libminiupnpc-static PROPERTY FOLDER "external") -set_property(TARGET libminiupnpc-static PROPERTY POSITION_INDEPENDENT_CODE ON) -if(MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_FLAGS " -wd4244 -wd4267") -elseif(NOT MSVC) - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_FLAGS " -Wno-undef -Wno-unused-result -Wno-unused-value") -endif() -if(CMAKE_SYSTEM_NAME MATCHES "NetBSD") - set_property(TARGET libminiupnpc-static APPEND_STRING PROPERTY COMPILE_FLAGS " -D_NETBSD_SOURCE") -endif() - -set(UPNP_LIBRARIES "libminiupnpc-static" PARENT_SCOPE) +set(UPNP_STATIC false PARENT_SCOPE) +set(UPNP_INCLUDE ${MINIUPNP_INCLUDE_DIR} PARENT_SCOPE) +set(UPNP_LIBRARIES ${MINIUPNP_LIBRARY} PARENT_SCOPE) find_package(Unbound) diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl index f33ce977d..3d0c05a19 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl @@ -60,9 +60,9 @@ #include "cryptonote_core/cryptonote_core.h" #include "net/parse.h" -#include <miniupnp/miniupnpc/miniupnpc.h> -#include <miniupnp/miniupnpc/upnpcommands.h> -#include <miniupnp/miniupnpc/upnperrors.h> +#include <miniupnpc/miniupnpc.h> +#include <miniupnpc/upnpcommands.h> +#include <miniupnpc/upnperrors.h> #undef MONERO_DEFAULT_LOG_CATEGORY #define MONERO_DEFAULT_LOG_CATEGORY "net.p2p" |