diff options
| author | luigi1111 <luigi1111w@gmail.com> | 2022-04-06 00:14:44 -0400 |
|---|---|---|
| committer | luigi1111 <luigi1111w@gmail.com> | 2022-04-06 00:14:44 -0400 |
| commit | 627f04c19a94340a60e77f7276ca9df722a85894 (patch) | |
| tree | fbe70c5871e644d5bd04670a5a80470e968705e9 | |
| parent | Merge pull request #8205 (diff) | |
| parent | Remove footgun doc comment in miner TX validation (diff) | |
| download | monero-627f04c19a94340a60e77f7276ca9df722a85894.tar.xz | |
Merge pull request #8212
591c174 Remove footgun doc comment in miner TX validation (Luke Parker)
| -rw-r--r-- | src/cryptonote_core/blockchain.cpp | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp index 069beca62..4eaca039c 100644 --- a/src/cryptonote_core/blockchain.cpp +++ b/src/cryptonote_core/blockchain.cpp @@ -1363,9 +1363,6 @@ bool Blockchain::prevalidate_miner_transaction(const block& b, uint64_t height, CHECK_AND_ASSERT_MES(b.miner_tx.unlock_time == height + CRYPTONOTE_MINED_MONEY_UNLOCK_WINDOW, false, "coinbase transaction transaction has the wrong unlock time=" << b.miner_tx.unlock_time << ", expected " << height + CRYPTONOTE_MINED_MONEY_UNLOCK_WINDOW); //check outs overflow - //NOTE: not entirely sure this is necessary, given that this function is - // designed simply to make sure the total amount for a transaction - // does not overflow a uint64_t, and this transaction *is* a uint64_t... if(!check_outs_overflow(b.miner_tx)) { MERROR("miner transaction has money overflow in block " << get_block_hash(b)); |