aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormj-xmr <mjxmr@protonmail.com>2021-08-16 08:58:15 +0200
committermj-xmr <mjxmr@protonmail.com>2021-09-08 15:33:07 +0200
commit36527c05bdf65f6ad67e0ec6abdc5a126902e411 (patch)
treec5f4315effb070928c64fd6de8aa8650dc9c6630
parentMerge pull request #7902 (diff)
downloadmonero-36527c05bdf65f6ad67e0ec6abdc5a126902e411.tar.xz
UB: virtual method in destructor of WalletImpl v0.17
-rw-r--r--src/wallet/api/wallet.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/wallet/api/wallet.cpp b/src/wallet/api/wallet.cpp
index f019a38a8..92ab55a50 100644
--- a/src/wallet/api/wallet.cpp
+++ b/src/wallet/api/wallet.cpp
@@ -453,7 +453,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again
- pauseRefresh();
+ WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities
// Stop refresh thread