aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbinaryFate <binaryfate@users.noreply.github.com>2019-09-28 19:22:15 +0200
committerbinaryFate <binaryfate@users.noreply.github.com>2019-09-28 19:22:15 +0200
commit6b4bc0d389596bb5d3da1c1388e0c6c28ecfda63 (patch)
tree151eb7fc910077f7b6632ab34aeb911d4c3f80b2
parentMerge pull request #5549 (diff)
downloadmonero-6b4bc0d389596bb5d3da1c1388e0c6c28ecfda63.tar.xz
RPC on_transfer_split error consistent with on_transfer if no tx sent
-rw-r--r--src/wallet/wallet_rpc_server.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/wallet/wallet_rpc_server.cpp b/src/wallet/wallet_rpc_server.cpp
index 0e0221c03..2ca746cfe 100644
--- a/src/wallet/wallet_rpc_server.cpp
+++ b/src/wallet/wallet_rpc_server.cpp
@@ -1003,6 +1003,13 @@ namespace tools
std::vector<wallet2::pending_tx> ptx_vector = m_wallet->create_transactions_2(dsts, mixin, req.unlock_time, priority, extra, req.account_index, req.subaddr_indices);
LOG_PRINT_L2("on_transfer_split called create_transactions_2");
+ if (ptx_vector.empty())
+ {
+ er.code = WALLET_RPC_ERROR_CODE_TX_NOT_POSSIBLE;
+ er.message = "No transaction created";
+ return false;
+ }
+
return fill_response(ptx_vector, req.get_tx_keys, res.tx_key_list, res.amount_list, res.fee_list, res.multisig_txset, res.unsigned_txset, req.do_not_relay,
res.tx_hash_list, req.get_tx_hex, res.tx_blob_list, req.get_tx_metadata, res.tx_metadata_list, er);
}