diff options
author | luigi1111 <luigi1111w@gmail.com> | 2020-06-19 16:05:03 -0500 |
---|---|---|
committer | luigi1111 <luigi1111w@gmail.com> | 2020-06-19 16:05:03 -0500 |
commit | 1336992a5bea26085bd04b15c223591bdbf74b93 (patch) | |
tree | b04b30fae26775b98e1e1241981376c025cf5353 | |
parent | Merge pull request #6642 (diff) | |
parent | functional_tests: add simple relay_tx test (diff) | |
download | monero-1336992a5bea26085bd04b15c223591bdbf74b93.tar.xz |
Merge pull request #6643
23df29d functional_tests: add simple relay_tx test (moneromooo-monero)
e306834 rpc: fix relay_tx error return mixup (moneromooo-monero)
-rw-r--r-- | src/rpc/core_rpc_server.cpp | 2 | ||||
-rwxr-xr-x | tests/functional_tests/txpool.py | 11 |
2 files changed, 12 insertions, 1 deletions
diff --git a/src/rpc/core_rpc_server.cpp b/src/rpc/core_rpc_server.cpp index 213d9c702..3807d73d9 100644 --- a/src/rpc/core_rpc_server.cpp +++ b/src/rpc/core_rpc_server.cpp @@ -2816,7 +2816,7 @@ namespace cryptonote crypto::hash txid = *reinterpret_cast<const crypto::hash*>(txid_data.data()); cryptonote::blobdata txblob; - if (!m_core.get_pool_transaction(txid, txblob, relay_category::legacy)) + if (m_core.get_pool_transaction(txid, txblob, relay_category::legacy)) { NOTIFY_NEW_TRANSACTIONS::request r; r.txs.push_back(std::move(txblob)); diff --git a/tests/functional_tests/txpool.py b/tests/functional_tests/txpool.py index 27ae89764..9b64ef994 100755 --- a/tests/functional_tests/txpool.py +++ b/tests/functional_tests/txpool.py @@ -241,6 +241,17 @@ class TransferTest(): assert x.fee == txes[txid].fee assert x.tx_blob == txes[txid].tx_blob + print('Checking relaying txes') + res = daemon.get_transaction_pool_hashes() + assert len(res.tx_hashes) > 0 + txid = res.tx_hashes[0] + daemon.relay_tx([txid]) + res = daemon.get_transactions([txid]) + assert len(res.txs) == 1 + assert res.txs[0].tx_hash == txid + assert res.txs[0].in_pool + assert res.txs[0].relayed + daemon.flush_txpool() self.check_empty_pool() |