diff options
| author | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2019-12-05 12:27:57 +0000 |
|---|---|---|
| committer | moneromooo-monero <moneromooo-monero@users.noreply.github.com> | 2020-01-29 14:39:58 +0000 |
| commit | 4771a7aec198421fd6c7875b88f496b6c689ade8 (patch) | |
| tree | 86204c0083c73786de74143bbf509d342fde9a81 | |
| parent | p2p: avoid sending the same peer list over and over (diff) | |
| download | monero-4771a7aec198421fd6c7875b88f496b6c689ade8.tar.xz | |
p2p: remove obsolete local time in handshake
Also removes a potential fingerprinting vector
| -rw-r--r-- | src/p2p/net_node.inl | 3 | ||||
| -rw-r--r-- | src/p2p/p2p_protocol_defs.h | 2 |
2 files changed, 0 insertions, 5 deletions
diff --git a/src/p2p/net_node.inl b/src/p2p/net_node.inl index 13da53b1d..998406c91 100644 --- a/src/p2p/net_node.inl +++ b/src/p2p/net_node.inl @@ -1918,9 +1918,6 @@ namespace nodetool template<class t_payload_net_handler> bool node_server<t_payload_net_handler>::get_local_node_data(basic_node_data& node_data, const network_zone& zone) { - time_t local_time; - time(&local_time); - node_data.local_time = local_time; // \TODO This can be an identifying value across zones (public internet to tor/i2p) ... node_data.peer_id = zone.m_config.m_peer_id; if(!m_hide_my_port && zone.m_can_pingback) node_data.my_port = m_external_port ? m_external_port : m_listening_port; diff --git a/src/p2p/p2p_protocol_defs.h b/src/p2p/p2p_protocol_defs.h index 3684c317a..53defe9bd 100644 --- a/src/p2p/p2p_protocol_defs.h +++ b/src/p2p/p2p_protocol_defs.h @@ -165,7 +165,6 @@ namespace nodetool struct basic_node_data { uuid network_id; - uint64_t local_time; uint32_t my_port; uint16_t rpc_port; uint32_t rpc_credits_per_hash; @@ -174,7 +173,6 @@ namespace nodetool BEGIN_KV_SERIALIZE_MAP() KV_SERIALIZE_VAL_POD_AS_BLOB(network_id) KV_SERIALIZE(peer_id) - KV_SERIALIZE(local_time) KV_SERIALIZE(my_port) KV_SERIALIZE_OPT(rpc_port, (uint16_t)(0)) KV_SERIALIZE_OPT(rpc_credits_per_hash, (uint32_t)0) |