aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDion Ahmetaj <ahmetajd@coned.com>2017-02-02 12:34:51 -0500
committerDion Ahmetaj <Dion Ahmetaj>2017-02-10 18:07:41 -0500
commit68652cd94d0cf3a94e36fbd631db83c201dc5908 (patch)
tree304d2b4af53b92a34018d341210c4f6e7a6ef6a5
parentMoved around checking of AC power in order to bail quicker to sleep if not pl... (diff)
downloadmonero-68652cd94d0cf3a94e36fbd631db83c201dc5908.tar.xz
Added some //TODO comments pertaining to returning enums instead of bools in order to be better able to handle failure states.
Diffstat (limited to '')
-rw-r--r--src/cryptonote_basic/miner.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/cryptonote_basic/miner.cpp b/src/cryptonote_basic/miner.cpp
index 08877c260..e654ac185 100644
--- a/src/cryptonote_basic/miner.cpp
+++ b/src/cryptonote_basic/miner.cpp
@@ -798,5 +798,10 @@ namespace cryptonote
LOG_ERROR(__func__ << " : couldn't query power status");
return false; // shouldn't get here unless no support for querying battery status
+ // TODO: return enum with ability to signify failure in querying for power status
+ // and change bg-mining logic so that it stops. As @vtnerd states, with the current
+ // setup "If someone enabled background mining on a system that fails to grab ac
+ // status, it will just continually check with little hope of ever being resolved
+ // automagically". This is also the case for time/idle stats functions.
}
}